SubscriptionsTest - Code Metrics - Inspection of "Merge pull request #38 from valetanddama/master" - xsolla/xsolla-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 313249...11f8f0 )

unknown

created 2016-10-26 07:37 UTC

SubscriptionsTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	219
Duplicated Lines	29.22 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	18
c	2
b	0
f	0
lcom	1
cbo	2
dl	64
loc	219
rs	10

18 Methods

Rating	Name	Duplication	Size	Complexity
A	testCreateSubscriptionPlan()	0	10	1
A	testUpdateSubscriptionPlan()	0	9	1
A	testDisableSubscriptionPlan()	0	7	1
A	testEnableSubscriptionPlan()	0	7	1
A	testDeleteSubscriptionPlan()	0	7	1
A	testCreateSubscriptionProduct()	9	9	1
A	testListSubscriptionPlans()	8	8	1
A	testListSubscriptionPlansWithParams()	12	12	1
A	testUpdateSubscriptionProduct()	9	9	1
A	testDeleteSubscriptionProduct()	0	7	1
A	testListSubscriptionProducts()	0	7	1
A	testListSubscriptionProductsWithParams()	0	8	1
A	testUpdateSubscription()	0	4	1
A	testListSubscriptions()	8	8	1
A	testListSubscriptionWithParams()	10	10	1
A	testListUserSubscriptionPayments()	8	8	1
A	testListSubscriptionPayments()	0	7	1
A	testListSubscriptionCurrencies()	0	7	1

How to fix Duplicated Code

<?php

namespace Xsolla\SDK\Tests\Integration\API;

/**
 * @group api
 */
class SubscriptionsTest extends AbstractAPITest
{
    protected static $planId;

    protected static $productId;

    protected $plan = array(
        'name' => array(
            'en' => 'Subscription Plan Name',
        ),
        'group_id' => 'group_id',
        'charge' => array(
            'amount' => 1,
            'currency' => 'USD',
            'period' => array(
                'value' => 1,
                'type' => 'month',
            ),
        ),
        'expiration' => array(
            'value' => 3,
            'type' => 'month',
        ),
    );

    protected $product = array(
        'name' => 'Product Name',
        'group_id' => 'group_id',
    );

    public function testCreateSubscriptionPlan()
    {
        $response = static::$xsollaClient->CreateSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'request' => $this->plan,
        ));
        static::assertArrayHasKey('plan_id', $response);
        static::assertInternalType('integer', $response['plan_id']);
        static::$planId = $response['plan_id'];
    }

    /**
     * @depends testCreateSubscriptionPlan
     */
    public function testListSubscriptionPlans()

    {
        $response = static::$xsollaClient->ListSubscriptionPlans(array(
            'project_id' => static::$projectId,
            'limit' => 100,
        ));
        static::assertInternalType('array', $response);
    }

    /**
     * @depends testListSubscriptionPlans
     */
    public function testUpdateSubscriptionPlan()
    {
        $response = static::$xsollaClient->UpdateSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'plan_id' => static::$planId,
            'request' => $this->plan,
        ));
        static::assertInternalType('array', $response);
    }

    /**
     * @depends testUpdateSubscriptionPlan
     */
    public function testDisableSubscriptionPlan()
    {
        static::$xsollaClient->DisableSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'plan_id' => static::$planId,
        ));
    }

    /**
     * @depends testDisableSubscriptionPlan
     */
    public function testEnableSubscriptionPlan()
    {
        static::$xsollaClient->EnableSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'plan_id' => static::$planId,
        ));
    }

    /**
     * @depends testEnableSubscriptionPlan
     */
    public function testDeleteSubscriptionPlan()
    {
        static::$xsollaClient->DeleteSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'plan_id' => static::$planId,
        ));
    }

    /**
     * @depends testDeleteSubscriptionPlan
     */
    public function testCreateSubscriptionProduct()

    {
        $response = static::$xsollaClient->CreateSubscriptionProduct(array(
            'project_id' => static::$projectId,
            'request' => $this->product,
        ));
        static::assertArrayHasKey('product_id', $response);
        static::$productId = $response['product_id'];
    }

    /**
     * @depends testCreateSubscriptionProduct
     */
    public function testListSubscriptionPlansWithParams()

    {
        $response = static::$xsollaClient->ListSubscriptionPlans(array(
            'project_id' => static::$projectId,
            'limit' => 100,
            'offset' => 0,
            'product_id' => static::$productId,
            'group_id' => $this->product['group_id'],
            'external_id' => 12345,
        ));
        static::assertInternalType('array', $response);
    }

    /**
     * @depends testCreateSubscriptionProduct
     */
    public function testUpdateSubscriptionProduct()

    {
        $response = static::$xsollaClient->UpdateSubscriptionProduct(array(
            'project_id' => static::$projectId,
            'product_id' => static::$productId,
            'request' => $this->product,
        ));
        static::assertInternalType('array', $response);
    }

    /**
     * @depends testUpdateSubscriptionProduct
     */
    public function testDeleteSubscriptionProduct()
    {
        static::$xsollaClient->DeleteSubscriptionProduct(array(
            'project_id' => static::$projectId,
            'product_id' => static::$productId,
        ));
    }

    public function testListSubscriptionProducts()
    {
        $response = static::$xsollaClient->ListSubscriptionProducts(array(
            'project_id' => static::$projectId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testListSubscriptionProductsWithParams()
    {
        $response = static::$xsollaClient->ListSubscriptionProducts(array(
            'project_id' => static::$projectId,
            'product_id' => static::$productId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testUpdateSubscription()
    {
        static::markTestIncomplete('We haven\'t active subscriptions in test project.');
    }

    public function testListSubscriptions()

    {
        $response = static::$xsollaClient->ListSubscriptions(array(
            'project_id' => static::$projectId,
            'user_id' => static::$userId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testListSubscriptionWithParams()

    {
        $response = static::$xsollaClient->ListSubscriptions(array(
            'project_id' => static::$projectId,
            'user_id' => static::$userId,
            'plan_id' => static::$planId,
            'product_id' => static::$productId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testListUserSubscriptionPayments()

    {
        $response = static::$xsollaClient->ListUserSubscriptionPayments(array(
            'project_id' => static::$projectId,
            'user_id' => static::$userId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testListSubscriptionPayments()
    {
        $response = static::$xsollaClient->ListSubscriptionPayments(array(
            'project_id' => static::$projectId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testListSubscriptionCurrencies()
    {
        $response = static::$xsollaClient->ListSubscriptionCurrencies(array(
            'project_id' => static::$projectId,
        ));
        static::assertInternalType('array', $response);
    }
}


1		<?php
2
3		namespace Xsolla\SDK\Tests\Integration\API;
4
5		/**
6		* @group api
7		*/
8		class SubscriptionsTest extends AbstractAPITest
9		{
10		protected static $planId;
11
12		protected static $productId;
13
14		protected $plan = array(
15		'name' => array(
16		'en' => 'Subscription Plan Name',
17		),
18		'group_id' => 'group_id',
19		'charge' => array(
20		'amount' => 1,
21		'currency' => 'USD',
22		'period' => array(
23		'value' => 1,
24		'type' => 'month',
25		),
26		),
27		'expiration' => array(
28		'value' => 3,
29		'type' => 'month',
30		),
31		);
32
33		protected $product = array(
34		'name' => 'Product Name',
35		'group_id' => 'group_id',
36		);
37
38		public function testCreateSubscriptionPlan()
39		{
40		$response = static::$xsollaClient->CreateSubscriptionPlan(array(
41		'project_id' => static::$projectId,
42		'request' => $this->plan,
43		));
44		static::assertArrayHasKey('plan_id', $response);
45		static::assertInternalType('integer', $response['plan_id']);
46		static::$planId = $response['plan_id'];
47		}
48
49		/**
50		* @depends testCreateSubscriptionPlan
51		*/
52	View Code Duplication	public function testListSubscriptionPlans()
		0 ignored issues – show Duplication introduced 2016-10-24 14:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$response = static::$xsollaClient->ListSubscriptionPlans(array(
55		'project_id' => static::$projectId,
56		'limit' => 100,
57		));
58		static::assertInternalType('array', $response);
59		}
60
61		/**
62		* @depends testListSubscriptionPlans
63		*/
64		public function testUpdateSubscriptionPlan()
65		{
66		$response = static::$xsollaClient->UpdateSubscriptionPlan(array(
67		'project_id' => static::$projectId,
68		'plan_id' => static::$planId,
69		'request' => $this->plan,
70		));
71		static::assertInternalType('array', $response);
72		}
73
74		/**
75		* @depends testUpdateSubscriptionPlan
76		*/
77		public function testDisableSubscriptionPlan()
78		{
79		static::$xsollaClient->DisableSubscriptionPlan(array(
80		'project_id' => static::$projectId,
81		'plan_id' => static::$planId,
82		));
83		}
84
85		/**
86		* @depends testDisableSubscriptionPlan
87		*/
88		public function testEnableSubscriptionPlan()
89		{
90		static::$xsollaClient->EnableSubscriptionPlan(array(
91		'project_id' => static::$projectId,
92		'plan_id' => static::$planId,
93		));
94		}
95
96		/**
97		* @depends testEnableSubscriptionPlan
98		*/
99		public function testDeleteSubscriptionPlan()
100		{
101		static::$xsollaClient->DeleteSubscriptionPlan(array(
102		'project_id' => static::$projectId,
103		'plan_id' => static::$planId,
104		));
105		}
106
107		/**
108		* @depends testDeleteSubscriptionPlan
109		*/
110	View Code Duplication	public function testCreateSubscriptionProduct()
		0 ignored issues – show Duplication introduced 2015-12-08 10:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
111		{
112		$response = static::$xsollaClient->CreateSubscriptionProduct(array(
113		'project_id' => static::$projectId,
114		'request' => $this->product,
115		));
116		static::assertArrayHasKey('product_id', $response);
117		static::$productId = $response['product_id'];
118		}
119
120		/**
121		* @depends testCreateSubscriptionProduct
122		*/
123	View Code Duplication	public function testListSubscriptionPlansWithParams()
		0 ignored issues – show Duplication introduced 2016-10-25 09:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
124		{
125		$response = static::$xsollaClient->ListSubscriptionPlans(array(
126		'project_id' => static::$projectId,
127		'limit' => 100,
128		'offset' => 0,
129		'product_id' => static::$productId,
130		'group_id' => $this->product['group_id'],
131		'external_id' => 12345,
132		));
133		static::assertInternalType('array', $response);
134		}
135
136		/**
137		* @depends testCreateSubscriptionProduct
138		*/
139	View Code Duplication	public function testUpdateSubscriptionProduct()
		0 ignored issues – show Duplication introduced 2015-12-08 10:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
140		{
141		$response = static::$xsollaClient->UpdateSubscriptionProduct(array(
142		'project_id' => static::$projectId,
143		'product_id' => static::$productId,
144		'request' => $this->product,
145		));
146		static::assertInternalType('array', $response);
147		}
148
149		/**
150		* @depends testUpdateSubscriptionProduct
151		*/
152		public function testDeleteSubscriptionProduct()
153		{
154		static::$xsollaClient->DeleteSubscriptionProduct(array(
155		'project_id' => static::$projectId,
156		'product_id' => static::$productId,
157		));
158		}
159
160		public function testListSubscriptionProducts()
161		{
162		$response = static::$xsollaClient->ListSubscriptionProducts(array(
163		'project_id' => static::$projectId,
164		));
165		static::assertInternalType('array', $response);
166		}
167
168		public function testListSubscriptionProductsWithParams()
169		{
170		$response = static::$xsollaClient->ListSubscriptionProducts(array(
171		'project_id' => static::$projectId,
172		'product_id' => static::$productId,
173		));
174		static::assertInternalType('array', $response);
175		}
176
177		public function testUpdateSubscription()
178		{
179		static::markTestIncomplete('We haven\'t active subscriptions in test project.');
180		}
181
182	View Code Duplication	public function testListSubscriptions()
		0 ignored issues – show Duplication introduced 2015-12-08 10:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
183		{
184		$response = static::$xsollaClient->ListSubscriptions(array(
185		'project_id' => static::$projectId,
186		'user_id' => static::$userId,
187		));
188		static::assertInternalType('array', $response);
189		}
190
191	View Code Duplication	public function testListSubscriptionWithParams()
		0 ignored issues – show Duplication introduced 2016-10-25 09:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
192		{
193		$response = static::$xsollaClient->ListSubscriptions(array(
194		'project_id' => static::$projectId,
195		'user_id' => static::$userId,
196		'plan_id' => static::$planId,
197		'product_id' => static::$productId,
198		));
199		static::assertInternalType('array', $response);
200		}
201
202	View Code Duplication	public function testListUserSubscriptionPayments()
		0 ignored issues – show Duplication introduced 2015-12-08 10:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
203		{
204		$response = static::$xsollaClient->ListUserSubscriptionPayments(array(
205		'project_id' => static::$projectId,
206		'user_id' => static::$userId,
207		));
208		static::assertInternalType('array', $response);
209		}
210
211		public function testListSubscriptionPayments()
212		{
213		$response = static::$xsollaClient->ListSubscriptionPayments(array(
214		'project_id' => static::$projectId,
215		));
216		static::assertInternalType('array', $response);
217		}
218
219		public function testListSubscriptionCurrencies()
220		{
221		$response = static::$xsollaClient->ListSubscriptionCurrencies(array(
222		'project_id' => static::$projectId,
223		));
224		static::assertInternalType('array', $response);
225		}
226		}
227

xsolla / xsolla-sdk-php

Push — master ( 313249...11f8f0 )

SubscriptionsTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

18 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like