Gica\CodeAnalysis\ClassDiscovery

Complexity

Total Complexity

13

Size/Duplication

Total Lines	118
Duplicated Lines	8.47 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

94.59%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	10	10	1
A	discoverListeners()	0	18	3
A	isListenerFileName()	0	4	1
A	extractClassFromFileIfAccepted()	0	10	2
A	readFile()	0	4	1
A	getDiscoveredClasses()	0	4	1
A	filterFiles()	0	6	1
A	getClassIfAccepted()	0	10	2
A	sort()	0	6	1

<?php
/******************************************************************************
 * Copyright (c) 2016 Constantin Galbenu <gica.galbenu@gmail.com>             *
 ******************************************************************************/

namespace Gica\CodeAnalysis;


use Gica\CodeAnalysis\MethodListenerDiscovery\ClassSorter;
use Gica\CodeAnalysis\MethodListenerDiscovery\ListenerClassValidator;
use Gica\CodeAnalysis\Traits\FilesInDirectoryExtracter;

class ClassDiscovery
{
    use FilesInDirectoryExtracter;

    protected $discoveredClasses = [];

    /** @var ListenerClassValidator */
    private $classValidator;
    /**
     * @var ClassSorter
     */
    private $classSorter;
    /**
     * @var PhpClassInFileInspector
     */
    private $phpClassInFileInspector;

    public function __construct(

This method seems to be duplicated in your project.

        ListenerClassValidator $classValidator,
        ClassSorter $classSorter,
        PhpClassInFileInspector $phpClassInFileInspector = null
    )
    {
        $this->classValidator = $classValidator;
        $this->classSorter = $classSorter;
        $this->phpClassInFileInspector = $phpClassInFileInspector ?? new PhpClassInFileInspector;
    }


    public function discoverListeners($directory)
    {
        $files = $this->getFilesInDirectory($directory);

        $files = $this->filterFiles($files);

        foreach ($files as $file) {
            $fullFilePath = $file;

            $extractedClass = $this->extractClassFromFileIfAccepted($fullFilePath);

            if ($extractedClass) {
                $this->discoveredClasses[] = $extractedClass;
            }
        }

        $this->discoveredClasses = $this->sort($this->discoveredClasses);
    }

    /**
     * @param string $filePath
     * @return bool
     */
    protected function isListenerFileName($filePath)
    {
        return preg_match('#\.php$#ims', $filePath);
    }

    /**
     * @param $fullFilePath
     * @return bool|\ReflectionClass
     */
    protected function extractClassFromFileIfAccepted($fullFilePath)
    {
        $fqn = $this->phpClassInFileInspector->getFullyQualifiedClassName($fullFilePath);

        if (!$fqn) {

The expression $fqn of type null|string is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            return false;
        }

        return $this->getClassIfAccepted($fqn);
    }

    protected function readFile($fullFilePath)
    {
        return file_get_contents($fullFilePath);
    }

    /**
     * @return \ReflectionClass[]
     */
    public function getDiscoveredClasses()
    {
        return $this->discoveredClasses;
    }

    protected function filterFiles(array $files)
    {
        return array_filter($files, function ($file) {
            return $this->isListenerFileName($file);
        });
    }

    /**
     * @param $className
     * @return \ReflectionClass|null
     */
    private function getClassIfAccepted($className)
    {
        $reflectionClass = new \ReflectionClass($className);

        if ($this->classValidator->isClassAccepted($reflectionClass)) {
            return $reflectionClass;
        }

        return null;
    }

    /**
     * @param \ReflectionClass[] $discoveredClasses
     * @return \ReflectionClass[]
     */
    private function sort($discoveredClasses)
    {
        usort($discoveredClasses, $this->classSorter);

        return $discoveredClasses;
    }
}