xpressengine / xpressengine

core/tests/Interception/ProxyInvocationHandlerTest.php

Doc Comments +3 added lines, -5 removed lines

@@ -84,10 +84,9 @@ 
      * getAdvisorList
      *
      * @param null $proxyObject
-     * @param null $sortedList
-     * @param null $advisorArr
+     * @param MockInterface $advisorList
      *
-     * @return AdvisorList
+     * @return ProxyInvocationHandler
      */
     protected function getHandler($proxyObject = null, $method = 'originMethod', $advisorList = null)
     {
@@ -107,11 +106,10 @@ 
     /**
      * getAdvisorList
      *
-     * @param null $proxyObject
      * @param null $sortedList
      * @param null $advisorArr
      *
-     * @return AdvisorList
+     * @return MockInterface
      */
     protected function getAdvisorList($sortedList = null, $advisorArr = null)
     {

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
         $handler = $this->getHandler(null, 'origin', $advisorList);
 
         $args = ['1', '2'];
-        $originMethod = function ($a, $b) {
+        $originMethod = function($a, $b) {
             return $a.$b;
         };
 
@@ -73,7 +73,7 @@ 
         $handler = $this->getHandler(null, 'origin', $advisorList);
 
         $args = ['1', '2'];
-        $originMethod = function ($a, $b) {
+        $originMethod = function($a, $b) {
             return $a.$b;
         };
 

core/tests/Media/AudioHandlerTest.php

Doc Comments +4 added lines

@@ -103,6 +103,10 @@
         $instance->remove($mockMedia);
     }
 
+    /**
+     * @param AudioHandler $object
+     * @param string $methodName
+     */
     private function invokeMethod(&$object, $methodName, array $parameters = array())
     {
         $reflection = new \ReflectionClass(get_class($object));

core/tests/Media/VideoHandlerTest.php

Doc Comments +4 added lines

@@ -151,6 +151,10 @@
         ];
     }
 
+    /**
+     * @param VideoHandler $object
+     * @param string $methodName
+     */
     private function invokeMethod(&$object, $methodName, array $parameters = array())
     {
         $reflection = new \ReflectionClass(get_class($object));

Spacing +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
         $instance->shouldReceive('createModel')->once()->with($mockFile)->andReturn($mockVideo);
         $instance->shouldReceive('extractInformation')->once()->with($mockVideo)->andReturn([
             ['streams' => true],
-            ['var1' => 'val1', 'var2' => 'val2' ],
+            ['var1' => 'val1', 'var2' => 'val2'],
             30,
             123456
         ]);

core/tests/Menu/DirectLinkTest.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace Xpressengine\Tests\Menu;
 
 use PHPUnit_Framework_TestCase;
-use Mockery as m;
 use Xpressengine\Menu\MenuType\DirectLink;
 
 /**

core/tests/Plugin/PluginCollectionTest.php

Doc Comments +4 added lines

@@ -132,6 +132,10 @@
         $this->assertEquals(2, $collection->count());
     }
 
+    /**
+     * @param PluginCollection $object
+     * @param string $property
+     */
     protected function getPropertyValue($object, $property)
     {
         $refl     = new \ReflectionObject($object);

core/tests/Plugin/PluginEntityTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Xpressengine\Tests\Plugin;
 
 use Mockery;
-use Mockery\MockInterface;
 use Xpressengine\Plugin\PluginCollection;
 use Xpressengine\Plugin\PluginEntity;
 

Spacing +4 added lines, -4 removed lines

@@ -145,14 +145,14 @@
      */
     public function testGetters($entity)
     {
-        $this->assertEquals('title',$entity->getTitle());
-        $this->assertEquals(__DIR__.'/plugins/plugin_sample',$entity->getPath());
+        $this->assertEquals('title', $entity->getTitle());
+        $this->assertEquals(__DIR__.'/plugins/plugin_sample', $entity->getPath());
         $this->assertEquals('khongchi plugin.', $entity->getDescription());
         $this->assertCount(6, $entity->getSupport());
         $this->assertEquals('khongchi/plugin_sample', $entity->getName());
         $this->assertEquals(['xpressengine', 'board'], $entity->getKeywords());
-        $this->assertEquals('khongchi',$entity->getAuthors()[0]['name']);
-        $this->assertEquals('LGPL-2.0',$entity->getLicense());
+        $this->assertEquals('khongchi', $entity->getAuthors()[0]['name']);
+        $this->assertEquals('LGPL-2.0', $entity->getLicense());
     }
 
     private function getMetaData()

core/tests/Plugin/PluginHandlerTest.php

Doc Comments +10 added lines, -4 removed lines

@@ -184,7 +184,7 @@ 
     /**
      * makeCollection
      *
-     * @return PluginCollection
+     * @return Mockery\MockInterface
      */
     private function makeCollection()
     {
@@ -192,7 +192,7 @@ 
     }
 
     /**
-     * @return Factory
+     * @return Mockery\MockInterface
      */
     private function makeViewFactory()
     {
@@ -205,7 +205,7 @@ 
     /**
      * makeRegister
      *
-     * @return PluginRegister
+     * @return Mockery\MockInterface
      */
     private function makeRegister()
     {
@@ -215,7 +215,7 @@ 
     }
 
     /**
-     * @return Application
+     * @return Mockery\MockInterface
      */
     private function makeApp()
     {
@@ -229,6 +229,9 @@ 
         return Mockery::mock('\Xpressengine\Plugin\PluginEntity');
     }
 
+    /**
+     * @param PluginHandler $handler
+     */
     private function setConfig($handler)
     {
 
@@ -237,6 +240,9 @@ 
         return $config;
     }
 
+    /**
+     * @param Mockery\MockInterface $plugins
+     */
     private function getHandler($dir = null, $plugins = null, $factory = null, $register = null, $app = null)
     {
         if($dir === null) $dir = __DIR__.'/plugins';

Indentation +2 added lines, -2 removed lines

@@ -122,7 +122,7 @@ 
         $handler = $this->getHandler(null, $plugins);
         $config = $this->setConfig($handler);
         $config->shouldReceive('getVal')->with('plugin.list', [])->once()->andReturn([
-           $pluginId => []
+            $pluginId => []
         ]);
         $config->shouldReceive('setVal')->withAnyArgs()->once()->andReturnNull();
 
@@ -174,7 +174,7 @@ 
         $handler = $this->getHandler(null, $plugins);
         $config = $this->setConfig($handler);
         $config->shouldReceive('getVal')->with('plugin.list', [])->once()->andReturn([
-           $pluginId => []
+            $pluginId => []
         ]);
         $config->shouldReceive('setVal')->withAnyArgs()->once()->andReturnNull();
 

Braces +15 added lines, -5 removed lines

@@ -239,11 +239,21 @@
 
     private function getHandler($dir = null, $plugins = null, $factory = null, $register = null, $app = null)
     {
-        if($dir === null) $dir = __DIR__.'/plugins';
-        if($plugins === null) $plugins = $this->makeCollection();
-        if($factory === null) $factory = $this->makeViewFactory();
-        if($register === null) $register = $this->makeRegister();
-        if($app === null) $app = $this->makeApp();
+        if($dir === null) {
+            $dir = __DIR__.'/plugins';
+        }
+        if($plugins === null) {
+            $plugins = $this->makeCollection();
+        }
+        if($factory === null) {
+            $factory = $this->makeViewFactory();
+        }
+        if($register === null) {
+            $register = $this->makeRegister();
+        }
+        if($app === null) {
+            $app = $this->makeApp();
+        }
         return new PluginHandler($dir, $plugins, $factory, $register, $app);
     }
 }

Spacing +5 added lines, -5 removed lines

@@ -239,11 +239,11 @@
 
     private function getHandler($dir = null, $plugins = null, $factory = null, $register = null, $app = null)
     {
-        if($dir === null) $dir = __DIR__.'/plugins';
-        if($plugins === null) $plugins = $this->makeCollection();
-        if($factory === null) $factory = $this->makeViewFactory();
-        if($register === null) $register = $this->makeRegister();
-        if($app === null) $app = $this->makeApp();
+        if ($dir === null) $dir = __DIR__.'/plugins';
+        if ($plugins === null) $plugins = $this->makeCollection();
+        if ($factory === null) $factory = $this->makeViewFactory();
+        if ($register === null) $register = $this->makeRegister();
+        if ($app === null) $app = $this->makeApp();
         return new PluginHandler($dir, $plugins, $factory, $register, $app);
     }
 }

core/tests/Plugin/plugins/plugin_sample/plugin.php

Doc Comments +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
 {
 
     /**
-     * @return boolean
+     * @return boolean|null
      */
     public function install()
     {
@@ -27,7 +27,7 @@ 
     }
 
     /**
-     * @return boolean
+     * @return boolean|null
      */
     public function unInstall()
     {

Indentation +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
         );
 
         $args::get('/manage', function () {
-           return 'hihihi';
+            return 'hihihi';
         });
     }
 

Spacing +8 added lines, -8 removed lines

@@ -56,14 +56,14 @@ 
     {
         // 라우트 등록
         intercept('Plugin@addPluginRoutes', 'route_for_pluginsample',
-            function ($target, &$args) {
+            function($target, &$args) {
                 $routes = $args[0];
                 $this->registerAssignedRoute($routes);
                 $target($args);
             }
         );
 
-        $args::get('/manage', function () {
+        $args::get('/manage', function() {
            return 'hihihi';
         });
     }
@@ -72,16 +72,16 @@ 
     {
 
 
-        $routes->{$this->pluginId} = function () {
+        $routes->{$this->pluginId} = function() {
 
             // for static action
             require_once('board_manager.php');
 
-            Route::get('/manage', function () {
+            Route::get('/manage', function() {
                 $boardManager = BoardManager::getInstance();
                 return $boardManager->getIndex();
             });
-            Route::get('/manage/list', function () {
+            Route::get('/manage/list', function() {
                 $boardManager = BoardManager::getInstance();
                 return $boardManager->getList();
             });
@@ -89,17 +89,17 @@ 
             // for dynamic action(using alias)
             require_once('board.php');
 
-            Route::get('{bid}/list', function ($bid) {
+            Route::get('{bid}/list', function($bid) {
                 $board = Board::getInstance();
                 return $board->getList($bid);
             });
 
-            Route::get('{bid}/setting', function ($bid) {
+            Route::get('{bid}/setting', function($bid) {
                 $board = Board::getInstance();
                 return $board->getSetting($bid);
             });
 
-            Route::get('{bid}/{act?}', function ($bid, $act = null) {
+            Route::get('{bid}/{act?}', function($bid, $act = null) {
 
                 $act    = $act ?: \Input::get('act', 'list');
                 $board  = Board::getInstance();

core/tests/Plugin/PluginScannerTest.php

Doc Comments +1 added lines

@@ -91,6 +91,7 @@
     /**
      * getReaderMock
      *
+     * @param string $dir
      * @return \Mockery\MockInterface
      */
     protected function getReaderMock($dir)