xpressengine / xpressengine

core/src/Xpressengine/Widget/WidgetHandler.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
  */
 namespace Xpressengine\Widget;
 
-use Closure;
 use Exception;
 use Illuminate\Contracts\Support\Renderable;
 use Illuminate\Contracts\View\Factory;

Indentation -1 removed lines

@@ -283,7 +283,6 @@
 
     /**
      * validateDBInfo
-
      * @param                 $dbInfo
      *
      * @return bool

core/tests/Captcha/GoogleRecaptchaTest.php

Doc Comments +6 added lines

@@ -67,6 +67,12 @@
         ];
     }
 
+    /**
+     * @param string $siteKey
+     * @param string $secret
+     * @param m\MockInterface $request
+     * @param m\MockInterface $frontend
+     */
     private function createInstance($siteKey, $secret, $request, $frontend)
     {
         return new GoogleRecaptcha($siteKey, $secret, $request, $frontend);

core/tests/Database/ProxyManagerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
     }
 
     /**
-     * @return m\MockInterface|\Xpressengine\Database\ProxyInterface
+     * @return m\MockInterface
      */
     private function getProxyInstance()
     {

core/tests/Database/TransactionHandlerTest.php

Doc Comments +4 added lines, -4 removed lines

@@ -66,7 +66,7 @@ 
      *
      * @param mixed  $object       object
      * @param string $propertyName method name
-     * @param mixed  $value        parameters
+     * @param integer  $value        parameters
      * @return void
      */
     private function setProperty(&$object, $propertyName, $value)
@@ -81,7 +81,7 @@ 
     /**
      * get connector
      *
-     * @return m\MockInterface|\Xpressengine\Database\VirtualConnection
+     * @return m\MockInterface
      */
     private function getConnector()
     {
@@ -91,7 +91,7 @@ 
     /**
      * get connection
      *
-     * @return m\MockInterface|\Illuminate\Database\Connection
+     * @return m\MockInterface
      */
     private function getConnection()
     {
@@ -101,7 +101,7 @@ 
     /**
      * get database coupler
      *
-     * @return m\MockInterface|\Xpressengine\Database\DatabaseCoupler
+     * @return m\MockInterface
      */
     private function getDatabaseCoupler()
     {

core/tests/DynamicField/DynamicFieldHandlerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     /**
      * get config entity
      *
-     * @return m\MockInterface|\Xpressengine\Config\ConfigEntity
+     * @return m\MockInterface
      */
     private function getConfigEntity()
     {

Spacing +1 added lines, -1 removed lines

@@ -415,7 +415,7 @@
         $config = $this->getConfigEntity();
         $config->shouldReceive('get')->once()->with('required')->andReturn(false);
 
-        $result =$handler->getRules($config);
+        $result = $handler->getRules($config);
         $this->assertEquals([], $result);
 
         $config->shouldReceive('get')->with('id')->andReturn('id');

core/tests/Interception/AdvisorCollectionTest.php

Doc Comments +4 added lines

@@ -104,6 +104,10 @@
 
     }
 
+    /**
+     * @param AdvisorCollection $object
+     * @param string $property
+     */
     protected function getPropertyValue($object, $property)
     {
         $refl     = new \ReflectionObject($object);

Spacing +6 added lines, -6 removed lines

@@ -33,14 +33,14 @@ 
     public function testPutDuplicateAdvisorName()
     {
         $advisor1 = new Advisor(
-            'ad1', 'Xpressengine\Tests\Interception\Document@insertDocument', function ($target, $args) {
+            'ad1', 'Xpressengine\Tests\Interception\Document@insertDocument', function($target, $args) {
             return $target($args);
         }
         );
         $this->advisorCollection->put($advisor1);
 
         $advisor2 = new Advisor(
-            'ad1', ['Xpressengine\Tests\Interception\Document@insertDocument', 'Xpressengine\Tests\Interception\Document@deleteDocument'], function ($target, $args) {
+            'ad1', ['Xpressengine\Tests\Interception\Document@insertDocument', 'Xpressengine\Tests\Interception\Document@deleteDocument'], function($target, $args) {
             return $target($args);
         }
         );
@@ -52,14 +52,14 @@ 
     {
 
         $advisor1 = new Advisor(
-            'ad1', 'Xpressengine\Tests\Interception\Document@insertDocument', function ($target, $args) {
+            'ad1', 'Xpressengine\Tests\Interception\Document@insertDocument', function($target, $args) {
             return $target($args);
         }
         );
         $this->advisorCollection->put($advisor1);
 
         $advisor2 = new Advisor(
-            'ad2', ['Xpressengine\Tests\Interception\Document@insertDocument', 'Xpressengine\Tests\Interception\Document@deleteDocument'], function ($target, $args) {
+            'ad2', ['Xpressengine\Tests\Interception\Document@insertDocument', 'Xpressengine\Tests\Interception\Document@deleteDocument'], function($target, $args) {
             return $target($args);
         }
 
@@ -67,7 +67,7 @@ 
         $this->advisorCollection->put($advisor2, ['before' => ['ad1', 'ad3']]);
 
         $advisor3 = new Advisor(
-            'ad3', 'Xpressengine\Tests\Interception\Document@deleteDocument', function ($target, $args) {
+            'ad3', 'Xpressengine\Tests\Interception\Document@deleteDocument', function($target, $args) {
             return $target($args);
         });
 
@@ -91,7 +91,7 @@ 
     {
 
         $advisor1 = new Advisor(
-            'ad1', 'Bar@insertDocument', function ($target, $args) {
+            'ad1', 'Bar@insertDocument', function($target, $args) {
             return $target($args);
         }
         );

core/tests/Interception/AdvisorListTest.php

Doc Comments -1 removed lines

@@ -34,7 +34,6 @@
     /**
      * getAdvisorList
      *
-     * @param null $proxyObject
      * @param null $sortedList
      * @param null $advisorArr
      *

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 namespace Xpressengine\Tests\Interception;
 
-use Xpressengine\Interception\Advisor;
 use Xpressengine\Interception\AdvisorList;
 
 class AdvisorListTest extends \PHPUnit_Framework_TestCase

core/tests/Interception/ClassPassTest.php

Doc Comments +3 added lines

@@ -28,6 +28,9 @@
         $this->assertContains('Proxy_Dave_Dave extends Dave\\Dave', $code);
     }
 
+    /**
+     * @param string $string
+     */
     private function getConfig($string)
     {
         $m = \Mockery::mock('\Xpressengine\Interception\Proxy\ProxyConfig');

Spacing +3 added lines, -3 removed lines

@@ -32,13 +32,13 @@
     {
         $m = \Mockery::mock('\Xpressengine\Interception\Proxy\ProxyConfig');
         $m->shouldReceive('getTargetName')->andReturnUsing(
-            function () use ($string) {
+            function() use ($string) {
                 return trim($string, '\\');
             }
         );
         $m->shouldReceive('getProxyName')->andReturnUsing(
-            function () use ($string) {
-                return 'Proxy_' . str_replace('\\', '_', trim($string, '\\'));
+            function() use ($string) {
+                return 'Proxy_'.str_replace('\\', '_', trim($string, '\\'));
             }
         );
         return $m;

core/tests/Interception/InterceptionHandlerTest.php

Doc Comments +4 added lines

@@ -69,6 +69,10 @@
     }
 
 
+    /**
+     * @param \Mockery\MockInterface $advisorCollection
+     * @param \Mockery\MockInterface $generator
+     */
     protected function getHandler($advisorCollection = null, $generator = null)
     {
 

Unused Use Statements -3 removed lines

@@ -4,9 +4,6 @@
 use Xpressengine\Interception\Advisor;
 use Xpressengine\Interception\AdvisorCollection;
 use Xpressengine\Interception\InterceptionHandler;
-use Xpressengine\Interception\Proxy\Loader\EvalLoader;
-use Xpressengine\Interception\Proxy\Loader\FileLoader;
-use Xpressengine\Interception\Proxy\Loader\Loader;
 use Xpressengine\Interception\Proxy\ProxyGenerator;
 
 class InterceptionHandlerTest extends \PHPUnit_Framework_TestCase

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
         $advisor = $interceptor->addAdvisor(
             'Xpressengine\Tests\Interception\Document@insertDocument',
             'spamfilter',
-            function ($target, $args) {
+            function($target, $args) {
                 return $target($args);
             }
         );