xpressengine / xpressengine

core/tests/Site/SiteHandlerTest.php

Doc Comments +3 added lines

@@ -315,6 +315,9 @@
         ];
     }
 
+    /**
+     * @param string $methodName
+     */
     private function invokeMethod(&$object, $methodName, array $parameters = array())
     {
         $reflection = new \ReflectionClass(get_class($object));

core/tests/Tag/TagHandlerTest.php

Doc Comments +4 added lines

@@ -191,6 +191,10 @@
         $this->assertInstanceOf('Xpressengine\Tag\Tag', current($tags));
     }
 
+    /**
+     * @param TagHandler $object
+     * @param string $methodName
+     */
     private function invokeMethod(&$object, $methodName, array $parameters = array())
     {
         $reflection = new \ReflectionClass(get_class($object));

Spacing +2 added lines, -2 removed lines

@@ -99,7 +99,7 @@ 
         $mockTag->shouldReceive('getKey')->andReturn(1);
 
         $mockConn->shouldReceive('table')->with('taggable')->andReturnSelf();
-        $mockConn->shouldReceive('insert')->once()->with(m::on(function ($args) {
+        $mockConn->shouldReceive('insert')->once()->with(m::on(function($args) {
             return $args['tagId'] === 1
                 && $args['taggableId'] === 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'
                 && $args['position'] === 0;
@@ -124,7 +124,7 @@ 
         $mockTag->shouldReceive('getKey')->andReturn(1);
 
         $mockConn->shouldReceive('table')->with('taggable')->andReturnSelf();
-        $mockConn->shouldReceive('insert')->once()->with(m::on(function ($args) {
+        $mockConn->shouldReceive('insert')->once()->with(m::on(function($args) {
             return $args['tagId'] === 1
             && $args['taggableId'] === 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'
             && $args['position'] === 0;

resources/FieldSkins/Category/DefaultSkin.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Xpressengine\DynamicField\AbstractSkin;
 use Xpressengine\Config\ConfigEntity;
 use View;
-use XeCategory;
 
 class DefaultSkin extends AbstractSkin
 {

Spacing +5 added lines, -5 removed lines

@@ -32,7 +32,7 @@ 
      */
     public function settings(ConfigEntity $config = null, $view = 'dynamicField/category/default/createSkin')
     {
-        return View::make($view, ['config' => $config,])->render();
+        return View::make($view, ['config' => $config, ])->render();
     }
 
     /**
@@ -65,8 +65,8 @@ 
 
         $itemId = '';
         $item = '';
-        if (isset($args[$config->get('id') . 'ItemId'])) {
-            $itemId = $args[$config->get('id') . 'ItemId'];
+        if (isset($args[$config->get('id').'ItemId'])) {
+            $itemId = $args[$config->get('id').'ItemId'];
             $item = CategoryItem::find($itemId);
         }
 
@@ -87,8 +87,8 @@ 
     {
         $config = $this->config;
         $item = '';
-        if (isset($args[$config->get('id') . 'ItemId'])) {
-            $itemId = $args[$config->get('id') . 'ItemId'];
+        if (isset($args[$config->get('id').'ItemId'])) {
+            $itemId = $args[$config->get('id').'ItemId'];
             $item = CategoryItem::find($itemId);
         }
 

core/tests/Temporary/TemporaryHandlerTest.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
         $auth->shouldReceive('guest')->andReturn(false);
         $auth->shouldReceive('user')->andReturn($mockUser);
 
-        $repo->shouldReceive('insert')->once()->with(m::on(function ($entity) {
+        $repo->shouldReceive('insert')->once()->with(m::on(function($entity) {
             return (
                 $entity->userId == 'userId'
                 && $entity->key == 'someKey'

core/tests/Category/CategoryHandlerTest.php

Spacing +3 added lines, -3 removed lines

@@ -193,7 +193,7 @@ 
         $instance = new CategoryHandler();
 
         $collection = m::mock('Illuminate\Database\Eloquent\Collection');
-        $collection->shouldReceive('filter')->once()->with(m::on(function () { return true; }))->andReturnSelf();
+        $collection->shouldReceive('filter')->once()->with(m::on(function() { return true; }))->andReturnSelf();
 
         $mockParent = m::mock('Xpressengine\Category\Models\CategoryItem');
         $mockParent->shouldReceive('getChildren')->andReturn($collection);
@@ -215,7 +215,7 @@ 
         $mockItem->shouldReceive('setAttribute')->once()->with('ordering', 1)->andReturnNull();
         $mockItem->shouldReceive('save')->once()->andReturnNull();
 
-        $collection->shouldReceive('each')->once()->with(m::on(function ($closure) use ($mockItem, $mockSibling) {
+        $collection->shouldReceive('each')->once()->with(m::on(function($closure) use ($mockItem, $mockSibling) {
             $arr = [$mockSibling, $mockItem];
 
             foreach ($arr as $idx => $model) {
@@ -225,7 +225,7 @@ 
             return true;
         }))->andReturnSelf();
 
-        $invoke = function (&$object, $methodName, array $parameters = array()) {
+        $invoke = function(&$object, $methodName, array $parameters = array()) {
             $reflection = new \ReflectionClass(get_class($object));
             $method = $reflection->getMethod($methodName);
             $method->setAccessible(true);

core/tests/Menu/MenuHandlerTest.php

Spacing +41 added lines, -41 removed lines

@@ -8,8 +8,8 @@ 
 {
     public function testCreate()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['createModel', 'generateNewId', 'registerDefaultPermission'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['createModel', 'generateNewId', 'registerDefaultPermission'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenu = m::mock('Xpressengine\Menu\Models\Menu');
         $mockMenu->shouldReceive('fill')->once()->with([
@@ -37,8 +37,8 @@ 
 
     public function testPut()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = new MenuHandler($keygen, $configs, $permissoins, $modules,  $routes);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = new MenuHandler($keygen, $configs, $permissoins, $modules, $routes);
 
         $mockMenu = m::mock('Xpressengine\Menu\Models\Menu');
         $mockMenu->shouldReceive('isDirty')->andReturn(true);
@@ -49,8 +49,8 @@ 
 
     public function testRemove()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['deleteMenuTheme', 'deleteMenuPermission'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['deleteMenuTheme', 'deleteMenuPermission'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $collection = m::mock('stdClass');
         $collection->shouldReceive('count')->andReturn(0);
@@ -68,8 +68,8 @@ 
 
     public function testRemoveThrowsExceptionWhenHasItem()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['deleteMenuTheme', 'deleteMenuPermission'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['deleteMenuTheme', 'deleteMenuPermission'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $collection = m::mock('stdClass');
         $collection->shouldReceive('count')->andReturn(1);
@@ -88,11 +88,11 @@ 
 
     public function testCreateItem()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
         $instance = $this->getMock(
             MenuHandler::class,
             ['createItemModel', 'generateNewId', 'setOrder', 'registerItemPermission', 'storeMenuType'],
-            [$keygen, $configs, $permissoins, $modules,  $routes]
+            [$keygen, $configs, $permissoins, $modules, $routes]
         );
 
         $mockMenu = m::mock('Xpressengine\Menu\Models\Menu');
@@ -118,7 +118,7 @@ 
         $instance->expects($this->any())->method('generateNewId')->willReturn('abcdefg');
 
         $mockRelate = m::mock('stdClass');
-        $mockRelate->shouldReceive('attach')->once()->with(m::on(function () { return true; }), ['depth' => 0]);
+        $mockRelate->shouldReceive('attach')->once()->with(m::on(function() { return true; }), ['depth' => 0]);
         $mockMenuItem->shouldReceive('ancestors')->andReturn($mockRelate);
 
 
@@ -130,8 +130,8 @@ 
 
         $mockMenuItem->shouldReceive('setAttribute')->once()->with('id', 'abcdefg');
 
-        $mockRelate->shouldReceive('attach')->once()->with('pid', m::on(function () { return true; }));
-        $mockRelate->shouldReceive('attach')->once()->with('ppid', m::on(function () { return true; }));
+        $mockRelate->shouldReceive('attach')->once()->with('pid', m::on(function() { return true; }));
+        $mockRelate->shouldReceive('attach')->once()->with('ppid', m::on(function() { return true; }));
 
 
         $instance->expects($this->any())->method('setOrder')->with($mockMenuItem, 1);
@@ -151,11 +151,11 @@ 
 
     public function testPutItem()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
         $instance = $this->getMock(
             MenuHandler::class,
             ['updateMenuType'],
-            [$keygen, $configs, $permissoins, $modules,  $routes]
+            [$keygen, $configs, $permissoins, $modules, $routes]
         );
 
         $mockMenuItem = m::mock('Xpressengine\Menu\Models\MenuItem');
@@ -169,11 +169,11 @@ 
 
     public function testRemoveItem()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
         $instance = $this->getMock(
             MenuHandler::class,
             ['deleteItemPermission', 'destroyMenuType'],
-            [$keygen, $configs, $permissoins, $modules,  $routes]
+            [$keygen, $configs, $permissoins, $modules, $routes]
         );
 
         $mockMenuItem = m::mock('Xpressengine\Menu\Models\MenuItem');
@@ -194,8 +194,8 @@ 
 
     public function testRemoveItemThrowsExceptionWhenHasItem()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['deleteItemPermission'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['deleteItemPermission'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenuItem = m::mock('Xpressengine\Menu\Models\MenuItem');
         $mockMenuItem->shouldReceive('getDescendantCount')->andReturn(1);
@@ -211,8 +211,8 @@ 
 
     public function testSetOrder()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = new MenuHandler($keygen, $configs, $permissoins, $modules,  $routes);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = new MenuHandler($keygen, $configs, $permissoins, $modules, $routes);
 
         $collection = m::mock('stdClass');
         $collection->shouldReceive('filter')->andReturn($collection);
@@ -236,8 +236,8 @@ 
 
     public function testMoveItem()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['createItemModel', 'unlinkHierarchy', 'linkHierarchy'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['createItemModel', 'unlinkHierarchy', 'linkHierarchy'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenu = m::mock('Xpressengine\Menu\Models\Menu');
         $mockMenu->shouldReceive('getKey')->andReturn('menuKey');
@@ -274,8 +274,8 @@ 
 
     public function testSetMenuTheme()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenu = m::mock('Xpressengine\Menu\Models\Menu');
         $mockMenu->shouldReceive('getKey')->andReturn('menuKey');
@@ -292,8 +292,8 @@ 
 
     public function testGetMenuTheme()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenu = m::mock('Xpressengine\Menu\Models\Menu');
         $mockMenu->shouldReceive('getKey')->andReturn('menuKey');
@@ -309,8 +309,8 @@ 
 
     public function testUpdateMenuTheme()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenu = m::mock('Xpressengine\Menu\Models\Menu');
         $mockMenu->shouldReceive('getKey')->andReturn('menuKey');
@@ -330,8 +330,8 @@ 
 
     public function testDeleteMenuTheme()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenu = m::mock('Xpressengine\Menu\Models\Menu');
         $mockMenu->shouldReceive('getKey')->andReturn('menuKey');
@@ -345,8 +345,8 @@ 
 
     public function testSetMenuItemTheme()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenuItem = m::mock('Xpressengine\Menu\Models\MenuItem');
 
@@ -362,8 +362,8 @@ 
 
     public function testGetMenuItemTheme()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenuItem = m::mock('Xpressengine\Menu\Models\MenuItem');
 
@@ -378,8 +378,8 @@ 
 
     public function testUpdateMenuItemTheme()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenuItem = m::mock('Xpressengine\Menu\Models\MenuItem');
 
@@ -398,8 +398,8 @@ 
 
     public function testDeleteMenuItemTheme()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockMenuItem = m::mock('Xpressengine\Menu\Models\MenuItem');
 
@@ -412,8 +412,8 @@ 
 
     public function testMoveItemConfig()
     {
-        list($keygen, $configs, $permissoins, $modules,  $routes) = $this->getMocks();
-        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules,  $routes]);
+        list($keygen, $configs, $permissoins, $modules, $routes) = $this->getMocks();
+        $instance = $this->getMock(MenuHandler::class, ['menuKeyString'], [$keygen, $configs, $permissoins, $modules, $routes]);
 
         $mockBefore = m::mock('Xpressengine\Menu\Models\MenuItem');
         $mockAfter = m::mock('Xpressengine\Menu\Models\MenuItem');

core/tests/Document/DocumentHandlerTest.php

Indentation +4 added lines, -4 removed lines

@@ -25,10 +25,10 @@
     protected $request;
 
         /**
-     * tear down
-     *
-     * @return void
-     */
+         * tear down
+         *
+         * @return void
+         */
     public function tearDown()
     {
         m::close();

Doc Comments +5 added lines, -5 removed lines

@@ -53,7 +53,7 @@ 
 
 
     /**
-     * @return m\MockInterface|\Xpressengine\Document\Models\Document
+     * @return m\MockInterface
      */
     private function getDocModel()
     {
@@ -63,7 +63,7 @@ 
     }
 
     /**
-     * @return m\MockInterface|\Xpressengine\Document\Models\Revision
+     * @return m\MockInterface
      */
     private function getRevisionModel()
     {
@@ -75,7 +75,7 @@ 
     /**
      * get User instance
      *
-     * @return m\MockInterface|\Xpressengine\User\UserInterface
+     * @return m\MockInterface
      */
     private function getUser()
     {
@@ -89,7 +89,7 @@ 
     /**
      * get config entity
      *
-     * @return m\MockInterface|\Xpressengine\Config\ConfigEntity
+     * @return m\MockInterface
      */
     private function getConfigEntity()
     {
@@ -99,7 +99,7 @@ 
     /**
      * @param array $items items
      *
-     * @return m\MockInterface|\Illuminate\Pagination\LengthAwarePaginator
+     * @return m\MockInterface
      */
     private function getPaginator(array $items)
     {

core/src/Xpressengine/User/Models/Guest.php

Spacing +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
      */
     public static function setDefaultProfileImage($img)
     {
-        self::$profileImage= $img;
+        self::$profileImage = $img;
     }
 
     /**

core/src/Xpressengine/User/EmailBroker.php

Spacing +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
         $this->mailer->send(
             $this->view,
             compact('mail'),
-            function ($m) use ($mail, $callback) {
+            function($m) use ($mail, $callback) {
                 $m->to($mail->getAddress());
 
                 if (!is_null($callback)) {

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use Closure;
 use Illuminate\Contracts\Mail\Mailer;
 use Xpressengine\User\Exceptions\InvalidConfirmationCodeException;
-use Xpressengine\User\Exceptions\PendingEmailNotExistsException;
 
 /**
  * 이 클래스는 Xpressengine에서 이메일 인증 처리를 수행하는 클래스이다.