xpressengine / xpressengine

core/src/Xpressengine/Storage/Storage.php

Doc Comments +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
     /**
      * check exists
      *
-     * @return bool
+     * @return boolean|null
      */
     public function exists()
     {

Spacing +8 added lines, -8 removed lines

@@ -206,7 +206,7 @@ 
         $disk = $disk ?: $this->distributor->allot($uploaded);
         $user = $user ?: $this->auth->user();
 
-        if (!$this->files->store(file_get_contents($uploaded->getPathname()), $path . '/' . $name, $disk)) {
+        if (!$this->files->store(file_get_contents($uploaded->getPathname()), $path.'/'.$name, $disk)) {
             throw new WritingFailException;
         }
 
@@ -245,7 +245,7 @@ 
         $disk = $disk ?: $this->distributor->allot($tempFile);
         $user = $user ?: $this->auth->user();
 
-        if (!$this->files->store($content, $path . '/' . $name, $disk)) {
+        if (!$this->files->store($content, $path.'/'.$name, $disk)) {
             throw new WritingFailException;
         }
 
@@ -294,7 +294,7 @@ 
         header('Expires: 0');
         header('Cache-Control: must-revalidate');
         header('Pragma: public');
-        header('Content-Length: ' . $file->size);
+        header('Content-Length: '.$file->size);
 
         file_put_contents('php://output', $file->getContent());
     }
@@ -404,9 +404,9 @@ 
 
         $path = trim($path, '/');
         if (empty($path) !== true) {
-            $path = $path . '/';
+            $path = $path.'/';
         }
-        return $path . $dividePath;
+        return $path.$dividePath;
     }
 
     /**
@@ -417,7 +417,7 @@ 
      */
     private function makeFilename($clientname)
     {
-        return date('YmdHis') . hash('sha1', $clientname);
+        return date('YmdHis').hash('sha1', $clientname);
     }
 
     /**
@@ -441,7 +441,7 @@ 
 
         $array = [];
         foreach ($rows as $row) {
-            $row = (array)$row;
+            $row = (array) $row;
             $array[$row['mime']] = $row['amount'];
         }
 
@@ -469,7 +469,7 @@ 
 
         $array = [];
         foreach ($rows as $row) {
-            $row = (array)$row;
+            $row = (array) $row;
             $array[$row['mime']] = $row['cnt'];
         }
 

core/src/Xpressengine/User/Repositories/PendingEmailRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
      * @param UserInterface $user
      * @param array         $data
      *
-     * @return EmailInterface
+     * @return \Xpressengine\Database\Eloquent\DynamicModel
      */
     public function create(UserInterface $user, array $data)
     {

core/src/Xpressengine/User/Repositories/UserAccountRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
      * @param UserInterface $user
      * @param array         $data
      *
-     * @return AccountInterface
+     * @return \Xpressengine\Database\Eloquent\DynamicModel
      */
     public function create(UserInterface $user, array $data)
     {
@@ -60,7 +60,7 @@ 
      *
      * @param string $userId user id
      *
-     * @return array
+     * @return \Illuminate\Database\Eloquent\Collection
      */
     public function findByUserId($userId)
     {

core/src/Xpressengine/User/Repositories/UserEmailRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -47,7 +47,7 @@ 
      * @param UserInterface $user
      * @param array         $data
      *
-     * @return EmailInterface
+     * @return \Xpressengine\Database\Eloquent\DynamicModel
      */
     public function create(UserInterface $user, array $data)
     {
@@ -91,7 +91,7 @@ 
      *
      * @param $userId
      *
-     * @return EmailInterface[]
+     * @return \Illuminate\Database\Eloquent\Collection
      */
     public function findByUserId($userId)
     {

core/src/Xpressengine/User/Repositories/UserRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
      *
      * @param array $data
      *
-     * @return UserInterface
+     * @return \Xpressengine\Database\Eloquent\DynamicModel
      */
     public function create(array $data)
     {
@@ -103,7 +103,7 @@ 
      * @param string        $emailPrefix 조회할 이메일의 이름영역
      * @param string[]|null $with        함께 반환할 relation 정보
      *
-     * @return UserInterface[]
+     * @return \Illuminate\Database\Eloquent\Collection
      */
     public function searchByEmailPrefix($emailPrefix, $with = null)
     {

Spacing +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
     {
         $user = $this->query()->whereHas(
             'emails',
-            function ($q) use ($address) {
+            function($q) use ($address) {
                 $q->where('address', $address);
             }
         )->first();
@@ -98,7 +98,7 @@ 
     {
         $users = $this->query()->whereHas(
             'emails',
-            function ($q) use ($emailPrefix) {
+            function($q) use ($emailPrefix) {
                 $q->where('address', 'like', $emailPrefix.'@%');
             }
         )->get();

core/tests/Permission/PermissionHandlerTest.php

Doc Comments +3 added lines

@@ -315,6 +315,9 @@
         ];
     }
 
+    /**
+     * @param string $methodName
+     */
     private function invokeMethod(&$object, $methodName, array $parameters = array())
     {
         $reflection = new \ReflectionClass(get_class($object));

Spacing +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
             ->shouldAllowMockingProtectedMethods();
 
         $instance->shouldReceive('find')->once()->with('plugin.dummy', 'default')->andReturnNull();
-        $instance->shouldReceive('setAncestor')->once()->with(m::on(function ($permission) {
+        $instance->shouldReceive('setAncestor')->once()->with(m::on(function($permission) {
             return $permission instanceof Permission;
         }));
 
@@ -95,7 +95,7 @@ 
 
         $repo->shouldReceive('findByName')->once()->with('default', 'plugin.dummy')->andReturnNull();
         $repo->shouldReceive('fetchAncestor')->once()->andReturn([$mockParent]);
-        $repo->shouldReceive('insert')->once()->with(m::on(function ($value) {
+        $repo->shouldReceive('insert')->once()->with(m::on(function($value) {
             return $value instanceof Permission;
         }))->andReturn($mockPermission);
 

core/tests/Permission/PolicyTest.php

Doc Comments +10 added lines

@@ -57,11 +57,21 @@
 
 class SamplePolicy extends Policy
 {
+    /**
+     * @param m\MockInterface $user
+     * @param string $name
+     * @param string $siteKey
+     */
     public function update($user, $name, $siteKey)
     {
         return $this->check($user, $this->get($name, $siteKey), 'update');
     }
 
+    /**
+     * @param m\MockInterface $user
+     * @param string $name
+     * @param string $siteKey
+     */
     public function read($user, $name, $siteKey)
     {
         return $this->check($user, $this->get($name, $siteKey), 'read');

core/tests/Routing/DatabaseRouteRepositoryTest.php

Doc Comments +3 added lines

@@ -315,6 +315,9 @@
         ];
     }
 
+    /**
+     * @param string $methodName
+     */
     private function invokeMethod(&$object, $methodName, array $parameters = array())
     {
         $reflection = new \ReflectionClass(get_class($object));

core/tests/Routing/InstanceRouteTest.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace Xpressengine\Tests\Menu;
 
 use PHPUnit_Framework_TestCase;
-use Mockery as m;
 use Xpressengine\Menu\MenuType\DirectLink;
 
 /**