xpressengine / xpressengine

app/Http/Controllers/Auth/PasswordController.php

Doc Comments +2 added lines, -3 removed lines

@@ -78,7 +78,7 @@ 
      * Send a reset link to the given user.
      *
      * @param  Request  $request
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse|null
      */
     public function postReset(Request $request)
     {
@@ -128,7 +128,6 @@ 
     /**
      * Display the password reset view for the given token.
      *
-     * @param  string  $token
      * @return Response
      */
     public function getPassword(Request $request)
@@ -147,7 +146,7 @@ 
      * Reset the given user's password.
      *
      * @param  Request  $request
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function postPassword(Request $request)
     {

Indentation +3 added lines, -3 removed lines

@@ -12,7 +12,7 @@ 
 
 class PasswordController extends Controller {
 
-	/*
+    /*
 	|--------------------------------------------------------------------------
 	| Password Reset Controller
 	|--------------------------------------------------------------------------
@@ -182,8 +182,8 @@ 
                 $passwordConfig = app('config')->get('xe.member.password');
                 $passwordLevel = array_get($passwordConfig['levels'], $passwordConfig['default']);
                 return redirect()->back()
-                                 ->withInput($request->only('email'))
-                                 ->with('alert', ['type' => 'danger', 'message' => $passwordLevel['description']]);
+                                    ->withInput($request->only('email'))
+                                    ->with('alert', ['type' => 'danger', 'message' => $passwordLevel['description']]);
         }
     }
 

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Illuminate\Contracts\Auth\PasswordBroker;
 use Illuminate\Http\Request;
 use Illuminate\Http\Response;
-use InvalidArgumentException;
 use XePresenter;
 use Session;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

Spacing +3 added lines, -3 removed lines

@@ -94,7 +94,7 @@ 
 
         $response = $this->passwords->sendResetLink(
             $request->only('email'),
-            function ($m) {
+            function($m) {
                 $m->subject($this->getEmailSubject());
             }
         );
@@ -136,7 +136,7 @@ 
             throw new NotFoundHttpException;
         }
 
-        return XePresenter::make('password', compact('email','token'));
+        return XePresenter::make('password', compact('email', 'token'));
     }
 
     /**
@@ -159,7 +159,7 @@ 
 
         $response = $this->passwords->reset(
             $credentials,
-            function ($user, $password) {
+            function($user, $password) {
                 $password = bcrypt($password);
 
                 $this->handler->update($user, compact('password'));

app/Http/Controllers/SettingsController.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 namespace App\Http\Controllers;
 
-use App\Http\Requests;
 use Storage;
 use Xpressengine\Http\Request;
 use Xpressengine\Menu\MenuRetrieveHandler;

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         foreach ($permissionGroups as $tab => &$group) {
             foreach ($group as $key => &$item) {
                 $permission = $permissionHandler->find($item['id']);
-                if($permission === null) {
+                if ($permission === null) {
                     $permission = $permissionHandler->register($item['id'], new Grant());
                 }
                 $item['permission'] = $permission;

app/Providers/SettingsServiceProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     /**
      * Get the services provided by the provider.
      *
-     * @return array
+     * @return string[]
      */
     public function provides()
     {

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Xpressengine\Settings\SettingsMenuPermission;
 use Xpressengine\Permission\Factory as PermissionFactory;
 use Xpressengine\Themes\SettingsTheme;
-use Xpressengine\Themes\DefaultSettings;
 use Xpressengine\UIObjects\Settings\SettingsPermission;
 
 class SettingsServiceProvider extends ServiceProvider

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     {
         $this->app->singleton(
             'xe.uiobject',
-            function ($app) {
+            function($app) {
 
                 $aliases = $app['config']->get('xe.uiobject.aliases');
 

app/Sections/SkinSection.php

Doc Comments +2 added lines, -2 removed lines

@@ -30,8 +30,8 @@
     /**
      * makeView
      *
-     * @param $target
-     * @param $instanceId
+     * @param string $target
+     * @param string|null $instanceId
      * @param $mode
      *
      * @return \Illuminate\Contracts\View\View

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
         // get skin list
         $skinList = $skinHandler->getList($target);
 
-        $skins = function ($skinList, $selectedSkin) {
+        $skins = function($skinList, $selectedSkin) {
             yield [
                 'text' => '선택하세요',
                 'selected' => false

migrations/MenuMigration.php

Doc Comments +3 added lines

@@ -193,6 +193,9 @@
         $permissionHandler->registerItemPermission($item, new Grant);
     }
 
+    /**
+     * @param string $mainMenu
+     */
     protected function setThemeConfig($mainMenu)
     {
         /** @var ThemeHandler $themeHandler */

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Xpressengine\Menu\MenuHandler;
 use Xpressengine\Menu\Models\Menu;
 use Xpressengine\Menu\Models\MenuItem;
-use Xpressengine\Permission\Grant;
 use Xpressengine\Support\Migration;
 use Xpressengine\Theme\ThemeHandler;
 use Xpressengine\Config\ConfigManager;

Spacing +5 added lines, -5 removed lines

@@ -16,7 +16,7 @@ 
 
     public function install()
     {
-        Schema::create('menu', function (Blueprint $table) {
+        Schema::create('menu', function(Blueprint $table) {
             $table->engine = "InnoDB";
 
             $table->string('id', 8);
@@ -28,7 +28,7 @@ 
             $table->primary('id');
         });
 
-        Schema::create('menu_item', function (Blueprint $table) {
+        Schema::create('menu_item', function(Blueprint $table) {
             $table->engine = "InnoDB";
 
             $table->string('id', 8);
@@ -46,7 +46,7 @@ 
             $table->primary('id');
         });
 
-        Schema::create('menu_closure', function (Blueprint $table) {
+        Schema::create('menu_closure', function(Blueprint $table) {
             $table->engine = "InnoDB";
 
             $table->increments('id');
@@ -195,8 +195,8 @@ 
     {
         /** @var ThemeHandler $themeHandler */
         $themeHandler = app('xe.theme');
-        $themeHandler->setThemeConfig('alice', 'mainMenu', $mainMenu );
-        $themeHandler->setThemeConfig('alice', 'subMenu', $mainMenu );
+        $themeHandler->setThemeConfig('alice', 'mainMenu', $mainMenu);
+        $themeHandler->setThemeConfig('alice', 'subMenu', $mainMenu);
     }
 
     /**

resources/FieldTypes/Number.php

Doc Comments -2 removed lines

@@ -89,8 +89,6 @@
     }
 
     /**
-     * @param ConfigEntity $config
-     * @param DynamicFieldHandler $handler
      * @param array $args
      * @param array $wheres
      * @throws \Exception

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Xpressengine\DynamicField\ColumnEntity;
 use Xpressengine\DynamicField\ColumnDataType;
 use Xpressengine\Config\ConfigEntity;
-use XeRegister;
 use Xpressengine\DynamicField\DynamicFieldHandler;
 use Xpressengine\FieldSkins\Number\DefaultSkin;
 use View;

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
      */
     public function getSettingsView(ConfigEntity $config = null)
     {
-        return View::make('dynamicField/number/createType', ['config' => $config,])->render();
+        return View::make('dynamicField/number/createType', ['config' => $config, ])->render();
     }
 
     /**

resources/UIObjects/Menu/Menu.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php namespace Xpressengine\UIObjects\Menu;
 
-use PhpQuery\PhpQuery;
 use Xpressengine\UIObject\AbstractUIObject;
 
 class Menu extends AbstractUIObject

resources/UIObjects/Menu/MenuType.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace Xpressengine\UIObjects\Menu;
 
-use PhpQuery\PhpQuery;
-use Xpressengine\Menu\MenuEntity;
-use ReflectionClass;
 use Xpressengine\UIObject\AbstractUIObject;
 
 /**

resources/UIObjects/Permission/Permission.php

Doc Comments +4 added lines

@@ -149,6 +149,10 @@
     {
     }
 
+    /**
+     * @param string $container
+     * @param string $jsonRet
+     */
     protected function loadReactComponent($container, $title, $jsonRet)
     {
 

Indentation +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
         $inheritMode = null;
 
         $grant = $args['grant'];
-         $title = $args['title'];
+            $title = $args['title'];
         if (isset($args['mode'])) {
             $inheritMode = $args['mode'];
         }

Spacing +2 added lines, -2 removed lines

@@ -114,8 +114,8 @@
         $userRepo = app('xe.users');
 
         $groups = $groupRepo->findMany($grant['group']);
-        $users = $userRepo->findMany($grant['user'], ['id','displayName']);
-        $excepts = $userRepo->findMany($grant['except'], ['id','displayName']);
+        $users = $userRepo->findMany($grant['user'], ['id', 'displayName']);
+        $excepts = $userRepo->findMany($grant['except'], ['id', 'displayName']);
 
         $permissionValueArray['rating'] = $grant['rating'];
         $permissionValueArray['group'] = $groups;