xpressengine / xe-core

modules/editor/editor.model.php

Doc Comments +7 added lines

@@ -113,6 +113,11 @@ 
 		Context::set('drComponentList',$drComponentInfo);
 	}
 
+	/**
+	 * @param string $drComponentName
+	 *
+	 * @return string
+	 */
 	function getDrComponentXmlInfo($drComponentName)
 	{
 		$lang_type = Context::getLangType();
@@ -191,6 +196,7 @@ 
 	 * @brief Return the editor template
 	 * You can call upload_target_srl when modifying content
 	 * The upload_target_srl is used for a routine to check if an attachment exists
+	 * @param stdClass $option
 	 */
 	function getEditor($upload_target_srl = 0, $option = null)
 	{
@@ -486,6 +492,7 @@ 
 
 	/**
 	 * @brief Get information which has been auto-saved
+	 * @param integer $upload_target_srl
 	 */
 	function getSavedDoc($upload_target_srl)
 	{

Spacing +143 added lines, -143 removed lines

@@ -23,7 +23,7 @@ 
 	 */
 	function getEditorConfig($module_srl = null)
 	{
-		if(!$GLOBALS['__editor_module_config__'][$module_srl] && $module_srl)
+		if (!$GLOBALS['__editor_module_config__'][$module_srl] && $module_srl)
 		{
 			// Get trackback settings of the selected module
 			$oModuleModel = getModel('module');
@@ -34,55 +34,55 @@ 
 		$oModuleModel = getModel('module');
 		$editor_default_config = $oModuleModel->getModuleConfig('editor');
 
-		if(!is_object($editor_config)) $editor_config = new stdClass();
+		if (!is_object($editor_config)) $editor_config = new stdClass();
 
-		if($editor_config->enable_autosave != 'N') $editor_config->enable_autosave = 'Y';
-		if(!is_array($editor_config->enable_html_grant)) $editor_config->enable_html_grant = array();
-		if(!is_array($editor_config->enable_comment_html_grant)) $editor_config->enable_comment_html_grant = array();
-		if(!is_array($editor_config->upload_file_grant)) $editor_config->upload_file_grant = array();
-		if(!is_array($editor_config->comment_upload_file_grant)) $editor_config->comment_upload_file_grant = array();
-		if(!is_array($editor_config->enable_default_component_grant)) $editor_config->enable_default_component_grant = array();
-		if(!is_array($editor_config->enable_comment_default_component_grant)) $editor_config->enable_comment_default_component_grant = array();
-		if(!is_array($editor_config->enable_component_grant)) $editor_config->enable_component_grant = array();
-		if(!is_array($editor_config->enable_comment_component_grant)) $editor_config->enable_comment_component_grant= array();
+		if ($editor_config->enable_autosave != 'N') $editor_config->enable_autosave = 'Y';
+		if (!is_array($editor_config->enable_html_grant)) $editor_config->enable_html_grant = array();
+		if (!is_array($editor_config->enable_comment_html_grant)) $editor_config->enable_comment_html_grant = array();
+		if (!is_array($editor_config->upload_file_grant)) $editor_config->upload_file_grant = array();
+		if (!is_array($editor_config->comment_upload_file_grant)) $editor_config->comment_upload_file_grant = array();
+		if (!is_array($editor_config->enable_default_component_grant)) $editor_config->enable_default_component_grant = array();
+		if (!is_array($editor_config->enable_comment_default_component_grant)) $editor_config->enable_comment_default_component_grant = array();
+		if (!is_array($editor_config->enable_component_grant)) $editor_config->enable_component_grant = array();
+		if (!is_array($editor_config->enable_comment_component_grant)) $editor_config->enable_comment_component_grant = array();
 
-		if(!$editor_config->editor_height)
+		if (!$editor_config->editor_height)
 		{
 			$editor_config->editor_height = ($editor_default_config->editor_height) ? $editor_default_config->editor_height : 500;
 		}
-		if(!$editor_config->comment_editor_height)
+		if (!$editor_config->comment_editor_height)
 		{
 			$editor_config->comment_editor_height = ($editor_default_config->comment_editor_height) ? $editor_default_config->comment_editor_height : 120;
 		}
-		if(!$editor_config->editor_skin)
+		if (!$editor_config->editor_skin)
 		{
 			$editor_config->editor_skin = ($editor_default_config->editor_skin) ? $editor_default_config->editor_skin : 'ckeditor';
 		}
-		if(!$editor_config->comment_editor_skin)
+		if (!$editor_config->comment_editor_skin)
 		{
 			$editor_config->comment_editor_skin = ($editor_default_config->comment_editor_skin) ? $editor_default_config->comment_editor_skin : 'ckeditor';
 		}
-		if(!$editor_config->content_style)
+		if (!$editor_config->content_style)
 		{
 			$editor_config->content_style = ($editor_default_config->content_style) ? $editor_default_config->content_style : 'ckeditor_light';
 		}
-		if(!$editor_config->content_font && $editor_default_config->content_font)
+		if (!$editor_config->content_font && $editor_default_config->content_font)
 		{
 			$editor_config->content_font = $editor_default_config->content_font;
 		}
-		if(!$editor_config->content_font_size && $editor_default_config->content_font_size)
+		if (!$editor_config->content_font_size && $editor_default_config->content_font_size)
 		{
 			$editor_config->content_font_size = $editor_default_config->content_font_size;
 		}
-		if(!$editor_config->sel_editor_colorset && $editor_default_config->sel_editor_colorset)
+		if (!$editor_config->sel_editor_colorset && $editor_default_config->sel_editor_colorset)
 		{
 			$editor_config->sel_editor_colorset = $editor_default_config->sel_editor_colorset;
 		}
-		if(!$editor_config->sel_comment_editor_colorset && $editor_default_config->sel_comment_editor_colorset)
+		if (!$editor_config->sel_comment_editor_colorset && $editor_default_config->sel_comment_editor_colorset)
 		{
 			$editor_config->sel_comment_editor_colorset = $editor_default_config->sel_comment_editor_colorset;
 		}
-		if(!$editor_config->comment_content_style && $editor_default_config->comment_content_style)
+		if (!$editor_config->comment_content_style && $editor_default_config->comment_content_style)
 		{
 			$editor_config->comment_content_style = $editor_default_config->comment_content_style;
 		}
@@ -92,25 +92,25 @@ 
 
 	function loadDrComponents()
 	{
-		$drComponentPath = _XE_PATH_ . 'modules/editor/skins/dreditor/drcomponents/';
+		$drComponentPath = _XE_PATH_.'modules/editor/skins/dreditor/drcomponents/';
 		$drComponentList = FileHandler::readDir($drComponentPath);
 
 		$oTemplate = &TemplateHandler::getInstance();
 
 		$drComponentInfo = array();
-		if($drComponentList)
+		if ($drComponentList)
 		{
-			foreach($drComponentList as $i => $drComponent)
+			foreach ($drComponentList as $i => $drComponent)
 			{
 				unset($obj);
 				$obj = $this->getDrComponentXmlInfo($drComponent);
-				Context::loadLang(sprintf('%s%s/lang/',$drComponentPath,$drComponent));
-				$path = sprintf('%s%s/tpl/',$drComponentPath,$drComponent);
-				$obj->html = $oTemplate->compile($path,$drComponent);
+				Context::loadLang(sprintf('%s%s/lang/', $drComponentPath, $drComponent));
+				$path = sprintf('%s%s/tpl/', $drComponentPath, $drComponent);
+				$obj->html = $oTemplate->compile($path, $drComponent);
 				$drComponentInfo[$drComponent] = $obj;
 			}
 		}
-		Context::set('drComponentList',$drComponentInfo);
+		Context::set('drComponentList', $drComponentInfo);
 	}
 
 	function getDrComponentXmlInfo($drComponentName)
@@ -122,7 +122,7 @@ 
 		$xml_file = sprintf('%sinfo.xml', $component_path);
 		$cache_file = sprintf('./files/cache/editor/dr_%s.%s.php', $drComponentName, $lang_type);
 		// Return information after including it after cached xml file exists
-		if(file_exists($cache_file) && file_exists($xml_file) && filemtime($cache_file) > filemtime($xml_file))
+		if (file_exists($cache_file) && file_exists($xml_file) && filemtime($cache_file) > filemtime($xml_file))
 		{
 			include($cache_file);
 			return $xml_info;
@@ -151,10 +151,10 @@ 
 		$buff .= sprintf('$xml_info->license_link = "%s";', $component_info->license_link);
 
 		// Author information
-		if(!is_array($xml_doc->component->author)) $author_list[] = $xml_doc->component->author;
+		if (!is_array($xml_doc->component->author)) $author_list[] = $xml_doc->component->author;
 		else $author_list = $xml_doc->component->author;
 
-		for($i=0; $i < count($author_list); $i++)
+		for ($i = 0; $i < count($author_list); $i++)
 		{
 			$buff .= sprintf('$xml_info->author['.$i.']->name = "%s";', $author_list[$i]->name->body);
 			$buff .= sprintf('$xml_info->author['.$i.']->email_address = "%s";', $author_list[$i]->attrs->email_address);
@@ -163,10 +163,10 @@ 
 
 		// List extra variables (text type only in the editor component)
 		$extra_vars = $xml_doc->component->extra_vars->var;
-		if($extra_vars)
+		if ($extra_vars)
 		{
-			if(!is_array($extra_vars)) $extra_vars = array($extra_vars);
-			foreach($extra_vars as $key => $val)
+			if (!is_array($extra_vars)) $extra_vars = array($extra_vars);
+			foreach ($extra_vars as $key => $val)
 			{
 				unset($obj);
 				$key = $val->attrs->name;
@@ -198,47 +198,47 @@ 
 		 * Editor's default options
 		 */
 		// Option setting to allow file upload
-		if($upload_target_srl)
+		if ($upload_target_srl)
 		{
 			$option->editor_sequence = $upload_target_srl;
 		}
-		if(!$option->allow_fileupload) $allow_fileupload = false;
+		if (!$option->allow_fileupload) $allow_fileupload = false;
 		else $allow_fileupload = true;
 		// content_style setting
-		if(!$option->content_style) $option->content_style = 'ckeditor_light';
+		if (!$option->content_style) $option->content_style = 'ckeditor_light';
 		Context::set('content_style', $option->content_style);
-		Context::set('content_style_path', getScriptPath() . ltrim($this->module_path, './') . 'styles/' . $option->content_style);
+		Context::set('content_style_path', getScriptPath().ltrim($this->module_path, './').'styles/'.$option->content_style);
 		// Default font setting
 		Context::set('content_font', addslashes($option->content_font));
 		Context::set('content_font_size', $option->content_font_size);
 
 		// Option setting to allow auto-save
-		if(!$option->enable_autosave) $enable_autosave = false;
-		elseif(Context::get($option->primary_key_name)) $enable_autosave = false;
+		if (!$option->enable_autosave) $enable_autosave = false;
+		elseif (Context::get($option->primary_key_name)) $enable_autosave = false;
 		else $enable_autosave = true;
 		// Option setting to allow the default editor component
-		if(!$option->enable_default_component) $enable_default_component = false;
+		if (!$option->enable_default_component) $enable_default_component = false;
 		else $enable_default_component = true;
 		// Option setting to allow other extended components
-		if(!$option->enable_component) $enable_component = false;
+		if (!$option->enable_component) $enable_component = false;
 		else $enable_component = true;
 		// Setting for html-mode
-		if($option->disable_html) $html_mode = false;
+		if ($option->disable_html) $html_mode = false;
 		else $html_mode = true;
 		// Set Height
-		if(!$option->height) $editor_height = 300;
+		if (!$option->height) $editor_height = 300;
 		else $editor_height = $option->height;
 		// Skin Setting
 		$skin = $option->skin;
-		if(!$skin) $skin = 'ckeditor';
+		if (!$skin) $skin = 'ckeditor';
 
 		$colorset = $option->colorset;
-		if(!$colorset) $colorset = 'moono';
+		if (!$colorset) $colorset = 'moono';
 		Context::set('colorset', $colorset);
 		Context::set('skin', $skin);
 		Context::set('module_type', $option->module_type);
 
-		if($skin=='dreditor')
+		if ($skin == 'dreditor')
 		{
 			$this->loadDrComponents();
 		}
@@ -246,7 +246,7 @@ 
 		/**
 		 * Check the automatic backup feature (do not use if the post is edited)
 		 */
-		if($enable_autosave)
+		if ($enable_autosave)
 		{
 			// Extract auto-saved data
 			$saved_doc = $this->getSavedDoc($upload_target_srl);
@@ -258,26 +258,26 @@ 
 		/**
 		 * Extract editor's unique number (in order to display multiple editors on a single page)
 		 */
-		if($option->editor_sequence) $editor_sequence = $option->editor_sequence;
+		if ($option->editor_sequence) $editor_sequence = $option->editor_sequence;
 		else
 		{
-			if(!$_SESSION['_editor_sequence_']) $_SESSION['_editor_sequence_'] = 1;
-			$editor_sequence = $_SESSION['_editor_sequence_'] ++;
+			if (!$_SESSION['_editor_sequence_']) $_SESSION['_editor_sequence_'] = 1;
+			$editor_sequence = $_SESSION['_editor_sequence_']++;
 		}
 
 		/**
 		 * Upload setting by using configuration of the file module internally
 		 */
 		$files_count = 0;
-		if($allow_fileupload)
+		if ($allow_fileupload)
 		{
 			$oFileModel = getModel('file');
 			// Get upload configuration to set on SWFUploader
 			$file_config = $oFileModel->getUploadConfig();
-			$file_config->allowed_attach_size = $file_config->allowed_attach_size*1024*1024;
-			$file_config->allowed_filesize = $file_config->allowed_filesize*1024*1024;
+			$file_config->allowed_attach_size = $file_config->allowed_attach_size * 1024 * 1024;
+			$file_config->allowed_filesize = $file_config->allowed_filesize * 1024 * 1024;
 
-			Context::set('file_config',$file_config);
+			Context::set('file_config', $file_config);
 			// Configure upload status such as file size
 			$upload_status = $oFileModel->getUploadStatus();
 			Context::set('upload_status', $upload_status);
@@ -285,9 +285,9 @@ 
 			$oFileController = getController('file');
 			$oFileController->setUploadInfo($editor_sequence, $upload_target_srl);
 			// Check if the file already exists
-			if($upload_target_srl) $files_count = $oFileModel->getFilesCount($upload_target_srl);
+			if ($upload_target_srl) $files_count = $oFileModel->getFilesCount($upload_target_srl);
 		}
-		Context::set('files_count', (int)$files_count);
+		Context::set('files_count', (int) $files_count);
 
 		Context::set('allow_fileupload', $allow_fileupload);
 		// Set editor_sequence value
@@ -304,10 +304,10 @@ 
 		 * Check editor component
 		 */
 		$site_module_info = Context::get('site_module_info');
-		$site_srl = (int)$site_module_info->site_srl;
-		if($enable_component)
+		$site_srl = (int) $site_module_info->site_srl;
+		if ($enable_component)
 		{
-			if(!Context::get('component_list'))
+			if (!Context::get('component_list'))
 			{
 				$component_list = $this->getComponentList(true, $site_srl);
 				Context::set('component_list', $component_list);
@@ -334,7 +334,7 @@ 
 		$tpl_path = sprintf('%sskins/%s/', $this->module_path, $skin);
 		$tpl_file = 'editor.html';
 
-		if(!file_exists($tpl_path.$tpl_file))
+		if (!file_exists($tpl_path.$tpl_file))
 		{
 			$skin = 'ckeditor';
 			$tpl_path = sprintf('%sskins/%s/', $this->module_path, $skin);
@@ -364,7 +364,7 @@ 
 		$config->module_type = $type;
 
 		// Configurations listed according to a type
-		if($type == 'document')
+		if ($type == 'document')
 		{
 			$config->editor_skin = $editor_config->editor_skin;
 			$config->content_style = $editor_config->content_style;
@@ -393,7 +393,7 @@ 
 			$config->enable_autosave = 'N';
 		}
 		// Check a group_list of the currently logged-in user for permission check
-		if(Context::get('is_logged'))
+		if (Context::get('is_logged'))
 		{
 			$logged_info = Context::get('logged_info');
 			$group_list = $logged_info->group_list;
@@ -412,12 +412,12 @@ 
 		$option->colorset = $config->sel_editor_colorset;
 		// Permission check for file upload
 		$option->allow_fileupload = false;
-		if($logged_info->is_admin=='Y') $option->allow_fileupload = true;
-		elseif(count($config->upload_file_grant))
+		if ($logged_info->is_admin == 'Y') $option->allow_fileupload = true;
+		elseif (count($config->upload_file_grant))
 		{
-			foreach($group_list as $group_srl => $group_info)
+			foreach ($group_list as $group_srl => $group_info)
 			{
-				if(in_array($group_srl, $config->upload_file_grant))
+				if (in_array($group_srl, $config->upload_file_grant))
 				{
 					$option->allow_fileupload = true;
 					break;
@@ -427,12 +427,12 @@ 
 		else $option->allow_fileupload = true;
 		// Permission check for using default components
 		$option->enable_default_component = false;
-		if($logged_info->is_admin=='Y') $option->enable_default_component = true;
-		elseif(count($config->enable_default_component_grant))
+		if ($logged_info->is_admin == 'Y') $option->enable_default_component = true;
+		elseif (count($config->enable_default_component_grant))
 		{
-			foreach($group_list as $group_srl => $group_info)
+			foreach ($group_list as $group_srl => $group_info)
 			{
-				if(in_array($group_srl, $config->enable_default_component_grant))
+				if (in_array($group_srl, $config->enable_default_component_grant))
 				{
 					$option->enable_default_component = true;
 					break;
@@ -442,12 +442,12 @@ 
 		else $option->enable_default_component = true;
 		// Permisshion check for using extended components
 		$option->enable_component = false;
-		if($logged_info->is_admin=='Y') $option->enable_component = true;
-		elseif(count($config->enable_component_grant))
+		if ($logged_info->is_admin == 'Y') $option->enable_component = true;
+		elseif (count($config->enable_component_grant))
 		{
-			foreach($group_list as $group_srl => $group_info)
+			foreach ($group_list as $group_srl => $group_info)
 			{
-				if(in_array($group_srl, $config->enable_component_grant))
+				if (in_array($group_srl, $config->enable_component_grant))
 				{
 					$option->enable_component = true;
 					break;
@@ -457,12 +457,12 @@ 
 		else $option->enable_component = true;
 		// HTML editing privileges
 		$enable_html = false;
-		if($logged_info->is_admin=='Y') $enable_html = true;
-		elseif(count($config->enable_html_grant))
+		if ($logged_info->is_admin == 'Y') $enable_html = true;
+		elseif (count($config->enable_html_grant))
 		{
-			foreach($group_list as $group_srl => $group_info)
+			foreach ($group_list as $group_srl => $group_info)
 			{
-				if(in_array($group_srl, $config->enable_html_grant))
+				if (in_array($group_srl, $config->enable_html_grant))
 				{
 					$enable_html = true;
 					break;
@@ -471,12 +471,12 @@ 
 		}
 		else $enable_html = true;
 
-		if($enable_html) $option->disable_html = false;
+		if ($enable_html) $option->disable_html = false;
 		else $option->disable_html = true;
 		// Set Height
 		$option->height = $config->editor_height;
 		// Set an option for Auto-save
-		$option->enable_autosave = $config->enable_autosave=='Y'?true:false;
+		$option->enable_autosave = $config->enable_autosave == 'Y' ?true:false;
 		// Other settings
 		$option->primary_key_name = $primary_key_name;
 		$option->content_key_name = $content_key_name;
@@ -492,31 +492,31 @@ 
 		$auto_save_args = new stdClass();
 		$auto_save_args->module_srl = Context::get('module_srl');
 		// Get the current module if module_srl doesn't exist
-		if(!$auto_save_args->module_srl)
+		if (!$auto_save_args->module_srl)
 		{
 			$current_module_info = Context::get('current_module_info');
 			$auto_save_args->module_srl = $current_module_info->module_srl;
 		}
 		// Find a document by using member_srl for logged-in user and ipaddress for non-logged user
-		if(Context::get('is_logged'))
+		if (Context::get('is_logged'))
 		{
 			$logged_info = Context::get('logged_info');
 			$auto_save_args->member_srl = $logged_info->member_srl;
 		}
 		else
 		{
-			$auto_save_args->certify_key = $_COOKIE['autosave_certify_key_' . $auto_save_args->module_srl];
+			$auto_save_args->certify_key = $_COOKIE['autosave_certify_key_'.$auto_save_args->module_srl];
 			// @see https://github.com/xpressengine/xe-core/issues/2208
 			// 변경 이전에 작성된 게시물 호환성 유지
-			if(!$auto_save_args->certify_key) $auto_save_args->ipaddress = $_SERVER['REMOTE_ADDR'];
+			if (!$auto_save_args->certify_key) $auto_save_args->ipaddress = $_SERVER['REMOTE_ADDR'];
 		}
 		// Extract auto-saved data from the DB
 		$output = executeQuery('editor.getSavedDocument', $auto_save_args);
 		$saved_doc = $output->data;
 		// Return null if no result is auto-saved
-		if(!$saved_doc) return;
+		if (!$saved_doc) return;
 
-		if($saved_doc->certify_key && !isset($auto_save_args->certify_key))
+		if ($saved_doc->certify_key && !isset($auto_save_args->certify_key))
 		{
 			return;
 		}
@@ -524,16 +524,16 @@ 
 		// Check if the auto-saved document already exists
 		$oDocumentModel = getModel('document');
 		$oSaved = $oDocumentModel->getDocument($saved_doc->document_srl);
-		if($oSaved->isExists()) return;
+		if ($oSaved->isExists()) return;
 		// Move all the files if the auto-saved data contains document_srl and file
 		// Then set document_srl to editor_sequence
-		if($saved_doc->document_srl && $upload_target_srl && !Context::get('document_srl'))
+		if ($saved_doc->document_srl && $upload_target_srl && !Context::get('document_srl'))
 		{
 			$saved_doc->module_srl = $auto_save_args->module_srl;
 			$oFileController = getController('file');
 			$oFileController->moveFile($saved_doc->document_srl, $saved_doc->module_srl, $upload_target_srl);
 		}
-		else if($upload_target_srl) $saved_doc->document_srl = $upload_target_srl;
+		else if ($upload_target_srl) $saved_doc->document_srl = $upload_target_srl;
 		// Change auto-saved data
 		$saved_doc->certify_key = $auto_save_args->certify_key;
 		$oEditorController = getController('editor');
@@ -550,18 +550,18 @@ 
 	 */
 	function getComponentObject($component, $editor_sequence = 0, $site_srl = 0)
 	{
-		if(!preg_match('/^[a-zA-Z0-9_-]+$/',$component) || !preg_match('/^[0-9]+$/', $editor_sequence . $site_srl)) return;
+		if (!preg_match('/^[a-zA-Z0-9_-]+$/', $component) || !preg_match('/^[0-9]+$/', $editor_sequence.$site_srl)) return;
 
-		if(!$this->loaded_component_list[$component][$editor_sequence])
+		if (!$this->loaded_component_list[$component][$editor_sequence])
 		{
 			// Create an object of the component and execute
 			$class_path = sprintf('%scomponents/%s/', $this->module_path, $component);
 			$class_file = sprintf('%s%s.class.php', $class_path, $component);
-			if(!file_exists($class_file)) return new BaseObject(-1, sprintf(Context::getLang('msg_component_is_not_founded'), $component));
+			if (!file_exists($class_file)) return new BaseObject(-1, sprintf(Context::getLang('msg_component_is_not_founded'), $component));
 			// Create an object after loading the class file
 			require_once($class_file);
 			$oComponent = new $component($editor_sequence, $class_path);
-			if(!$oComponent) return new BaseObject(-1, sprintf(Context::getLang('msg_component_is_not_founded'), $component));
+			if (!$oComponent) return new BaseObject(-1, sprintf(Context::getLang('msg_component_is_not_founded'), $component));
 			// Add configuration information
 			$component_info = $this->getComponent($component, $site_srl);
 			$oComponent->setInfo($component_info);
@@ -582,14 +582,14 @@ 
 	/**
 	 * @brief Return the cache file name of editor component list
 	 */
-	function getCacheFile($filter_enabled= true, $site_srl = 0)
+	function getCacheFile($filter_enabled = true, $site_srl = 0)
 	{
 		$lang = Context::getLangType();
 		$cache_path = _XE_PATH_.'files/cache/editor/cache/';
 		FileHandler::makeDir($cache_path);
-		$cache_file = $cache_path.'component_list.' . $lang .'.';
-		if($filter_enabled) $cache_file .= 'filter.';
-		if($site_srl) $cache_file .= $site_srl.'.';
+		$cache_file = $cache_path.'component_list.'.$lang.'.';
+		if ($filter_enabled) $cache_file .= 'filter.';
+		if ($site_srl) $cache_file .= $site_srl.'.';
 		$cache_file .= 'php';
 		return $cache_file;
 	}
@@ -597,19 +597,19 @@ 
 	/**
 	 * @brief Return a component list (DB Information included)
 	 */
-	function getComponentList($filter_enabled = true, $site_srl=0, $from_db=false)
+	function getComponentList($filter_enabled = true, $site_srl = 0, $from_db = false)
 	{
 		$cache_file = $this->getCacheFile(false, $site_srl);
-		if($from_db || !file_exists($cache_file))
+		if ($from_db || !file_exists($cache_file))
 		{
 			$oEditorController = getController('editor');
 			$oEditorController->makeCache(false, $site_srl);
 		}
 
-		if(!file_exists($cache_file)) return;
+		if (!file_exists($cache_file)) return;
 		include($cache_file);
 		$logged_info = Context::get('logged_info');
-		if($logged_info && is_array($logged_info->group_list))
+		if ($logged_info && is_array($logged_info->group_list))
 		{
 			$group_list = array_keys($logged_info->group_list);
 		}
@@ -618,45 +618,45 @@ 
 			$group_list = array();
 		}
 
-		if(count($component_list))
+		if (count($component_list))
 		{
-			foreach($component_list as $key => $val)
+			foreach ($component_list as $key => $val)
 			{
-				if(!trim($key)) continue;
-				if(!is_dir(_XE_PATH_.'modules/editor/components/'.$key))
+				if (!trim($key)) continue;
+				if (!is_dir(_XE_PATH_.'modules/editor/components/'.$key))
 				{
 					FileHandler::removeFile($cache_file);
 					return $this->getComponentList($filter_enabled, $site_srl);
 				}
-				if(!$filter_enabled) continue;
-				if($val->enabled == "N")
+				if (!$filter_enabled) continue;
+				if ($val->enabled == "N")
 				{
 					unset($component_list->{$key});
 					continue;
 				}
-				if($logged_info->is_admin == "Y" || $logged_info->is_site_admin == "Y") continue;
-				if($val->target_group)
+				if ($logged_info->is_admin == "Y" || $logged_info->is_site_admin == "Y") continue;
+				if ($val->target_group)
 				{
-					if(!$logged_info)
+					if (!$logged_info)
 					{
 						$val->enabled = "N";
 					}
 					else
 					{
 						$is_granted = false;
-						foreach($group_list as $group_srl)
+						foreach ($group_list as $group_srl)
 						{
-							if(in_array($group_srl, $val->target_group)) $is_granted = true;
+							if (in_array($group_srl, $val->target_group)) $is_granted = true;
 						}
-						if(!$is_granted) $val->enabled = "N";
+						if (!$is_granted) $val->enabled = "N";
 					}
 				}
-				if($val->enabled != "N" && $val->mid_list)
+				if ($val->enabled != "N" && $val->mid_list)
 				{
 					$mid = Context::get('mid');
-					if(!in_array($mid, $val->mid_list)) $val->enabled = "N";
+					if (!in_array($mid, $val->mid_list)) $val->enabled = "N";
 				}
-				if($val->enabled == "N")
+				if ($val->enabled == "N")
 				{
 					unset($component_list->{$key});
 					continue;
@@ -674,7 +674,7 @@ 
 		$args = new stdClass();
 		$args->component_name = $component_name;
 
-		if($site_srl)
+		if ($site_srl)
 		{
 			$args->site_srl = $site_srl;
 			$output = executeQuery('editor.getSiteComponent', $args);
@@ -685,7 +685,7 @@ 
 		}
 		$component = $output->data;
 
-		if(!$output->data) return false;
+		if (!$output->data) return false;
 
 		$component_name = $component->component_name;
 
@@ -697,25 +697,25 @@ 
 
 		$xml_info->mid_list = array();
 
-		if($component->extra_vars)
+		if ($component->extra_vars)
 		{
 			$extra_vars = unserialize($component->extra_vars);
 
-			if($extra_vars->target_group)
+			if ($extra_vars->target_group)
 			{
 				$xml_info->target_group = $extra_vars->target_group;
 				unset($extra_vars->target_group);
 			}
 
-			if($extra_vars->mid_list)
+			if ($extra_vars->mid_list)
 			{
 				$xml_info->mid_list = $extra_vars->mid_list;
 				unset($extra_vars->mid_list);
 			}
 
-			if($xml_info->extra_vars)
+			if ($xml_info->extra_vars)
 			{
-				foreach($xml_info->extra_vars as $key => $val)
+				foreach ($xml_info->extra_vars as $key => $val)
 				{
 					$xml_info->extra_vars->{$key}->value = $extra_vars->{$key};
 				}
@@ -739,7 +739,7 @@ 
 		$cache_file = sprintf('./files/cache/editor/%s.%s.php', $component, $lang_type);
 
 		// Include and return xml file information if cached file exists
-		if(file_exists($cache_file) && file_exists($xml_file) && filemtime($cache_file) > filemtime($xml_file))
+		if (file_exists($cache_file) && file_exists($xml_file) && filemtime($cache_file) > filemtime($xml_file))
 		{
 			include($cache_file);
 
@@ -756,7 +756,7 @@ 
 		$component_info->component_name = $component;
 		$component_info->title = $xml_doc->component->title->body;
 
-		if($xml_doc->component->version)
+		if ($xml_doc->component->version)
 		{
 			$component_info->description = str_replace('\n', "\n", $xml_doc->component->description->body);
 			$component_info->version = $xml_doc->component->version->body;
@@ -782,10 +782,10 @@ 
 
 		// Author information
 		$author_list = array();
-		if(!is_array($xml_doc->component->author)) $author_list[] = $xml_doc->component->author;
+		if (!is_array($xml_doc->component->author)) $author_list[] = $xml_doc->component->author;
 		else $author_list = $xml_doc->component->author;
 
-		for($i = 0; $i < count($author_list); $i++)
+		for ($i = 0; $i < count($author_list); $i++)
 		{
 			$author = new stdClass;
 			$author->name = $author_list[$i]->name->body;
@@ -796,39 +796,39 @@ 
 
 		// List extra variables (text type only for editor component)
 		$extra_vars = $xml_doc->component->extra_vars;
-		if($extra_vars)
+		if ($extra_vars)
 		{
 			$extra_var_groups = $extra_vars->group;
-			if(!$extra_var_groups)
+			if (!$extra_var_groups)
 			{
 				$extra_var_groups = $extra_vars;
 			}
-			if(!is_array($extra_var_groups))
+			if (!is_array($extra_var_groups))
 			{
 				$extra_var_groups = array($extra_var_groups);
 			}
 
-			foreach($extra_var_groups as $group)
+			foreach ($extra_var_groups as $group)
 			{
 				$extra_vars = $group->var;
-				if(!is_array($group->var))
+				if (!is_array($group->var))
 				{
 					$extra_vars = array($group->var);
 				}
 
-				foreach($extra_vars as $key => $val)
+				foreach ($extra_vars as $key => $val)
 				{
-					if(!$val)
+					if (!$val)
 					{
 						continue;
 					}
 
 					$obj = new stdClass();
-					if(!$val->attrs)
+					if (!$val->attrs)
 					{
 						$val->attrs = new stdClass();
 					}
-					if(!$val->attrs->type)
+					if (!$val->attrs->type)
 					{
 						$val->attrs->type = 'text';
 					}
@@ -838,26 +838,26 @@ 
 					$obj->title = $val->title->body;
 					$obj->type = $val->attrs->type;
 					$obj->description = $val->description->body;
-					if($obj->name)
+					if ($obj->name)
 					{
 						$obj->value = $extra_vals->{$obj->name};
 					}
-					if(strpos($obj->value, '|@|') != FALSE)
+					if (strpos($obj->value, '|@|') != FALSE)
 					{
 						$obj->value = explode('|@|', $obj->value);
 					}
-					if($obj->type == 'mid_list' && !is_array($obj->value))
+					if ($obj->type == 'mid_list' && !is_array($obj->value))
 					{
 						$obj->value = array($obj->value);
 					}
 
 					// 'Select'type obtained from the option list.
-					if($val->options && !is_array($val->options))
+					if ($val->options && !is_array($val->options))
 					{
 						$val->options = array($val->options);
 					}
 
-					for($i = 0, $c = count($val->options); $i < $c; $i++)
+					for ($i = 0, $c = count($val->options); $i < $c; $i++)
 					{
 						$obj->options[$i] = new stdClass();
 						$obj->options[$i]->title = $val->options[$i]->title->body;
@@ -871,7 +871,7 @@ 
 
 		$buff = array();
 		$buff[] = '<?php if(!defined(\'__XE__\')) exit();';
-		$buff[] = '$xml_info = ' . var_export($component_info, TRUE) . ';';
+		$buff[] = '$xml_info = '.var_export($component_info, TRUE).';';
 		$buff = str_replace('stdClass::__set_state', '(object)', implode(PHP_EOL, $buff));
 
 		FileHandler::writeFile($cache_file, $buff, 'w');

Braces +176 added lines, -81 removed lines

@@ -34,17 +34,37 @@ 
 		$oModuleModel = getModel('module');
 		$editor_default_config = $oModuleModel->getModuleConfig('editor');
 
-		if(!is_object($editor_config)) $editor_config = new stdClass();
-
-		if($editor_config->enable_autosave != 'N') $editor_config->enable_autosave = 'Y';
-		if(!is_array($editor_config->enable_html_grant)) $editor_config->enable_html_grant = array();
-		if(!is_array($editor_config->enable_comment_html_grant)) $editor_config->enable_comment_html_grant = array();
-		if(!is_array($editor_config->upload_file_grant)) $editor_config->upload_file_grant = array();
-		if(!is_array($editor_config->comment_upload_file_grant)) $editor_config->comment_upload_file_grant = array();
-		if(!is_array($editor_config->enable_default_component_grant)) $editor_config->enable_default_component_grant = array();
-		if(!is_array($editor_config->enable_comment_default_component_grant)) $editor_config->enable_comment_default_component_grant = array();
-		if(!is_array($editor_config->enable_component_grant)) $editor_config->enable_component_grant = array();
-		if(!is_array($editor_config->enable_comment_component_grant)) $editor_config->enable_comment_component_grant= array();
+		if(!is_object($editor_config)) {
+			$editor_config = new stdClass();
+		}
+
+		if($editor_config->enable_autosave != 'N') {
+			$editor_config->enable_autosave = 'Y';
+		}
+		if(!is_array($editor_config->enable_html_grant)) {
+			$editor_config->enable_html_grant = array();
+		}
+		if(!is_array($editor_config->enable_comment_html_grant)) {
+			$editor_config->enable_comment_html_grant = array();
+		}
+		if(!is_array($editor_config->upload_file_grant)) {
+			$editor_config->upload_file_grant = array();
+		}
+		if(!is_array($editor_config->comment_upload_file_grant)) {
+			$editor_config->comment_upload_file_grant = array();
+		}
+		if(!is_array($editor_config->enable_default_component_grant)) {
+			$editor_config->enable_default_component_grant = array();
+		}
+		if(!is_array($editor_config->enable_comment_default_component_grant)) {
+			$editor_config->enable_comment_default_component_grant = array();
+		}
+		if(!is_array($editor_config->enable_component_grant)) {
+			$editor_config->enable_component_grant = array();
+		}
+		if(!is_array($editor_config->enable_comment_component_grant)) {
+			$editor_config->enable_comment_component_grant= array();
+		}
 
 		if(!$editor_config->editor_height)
 		{
@@ -151,8 +171,11 @@ 
 		$buff .= sprintf('$xml_info->license_link = "%s";', $component_info->license_link);
 
 		// Author information
-		if(!is_array($xml_doc->component->author)) $author_list[] = $xml_doc->component->author;
-		else $author_list = $xml_doc->component->author;
+		if(!is_array($xml_doc->component->author)) {
+			$author_list[] = $xml_doc->component->author;
+		} else {
+			$author_list = $xml_doc->component->author;
+		}
 
 		for($i=0; $i < count($author_list); $i++)
 		{
@@ -165,7 +188,9 @@ 
 		$extra_vars = $xml_doc->component->extra_vars->var;
 		if($extra_vars)
 		{
-			if(!is_array($extra_vars)) $extra_vars = array($extra_vars);
+			if(!is_array($extra_vars)) {
+				$extra_vars = array($extra_vars);
+			}
 			foreach($extra_vars as $key => $val)
 			{
 				unset($obj);
@@ -202,10 +227,15 @@ 
 		{
 			$option->editor_sequence = $upload_target_srl;
 		}
-		if(!$option->allow_fileupload) $allow_fileupload = false;
-		else $allow_fileupload = true;
+		if(!$option->allow_fileupload) {
+			$allow_fileupload = false;
+		} else {
+			$allow_fileupload = true;
+		}
 		// content_style setting
-		if(!$option->content_style) $option->content_style = 'ckeditor_light';
+		if(!$option->content_style) {
+			$option->content_style = 'ckeditor_light';
+		}
 		Context::set('content_style', $option->content_style);
 		Context::set('content_style_path', getScriptPath() . ltrim($this->module_path, './') . 'styles/' . $option->content_style);
 		// Default font setting
@@ -213,27 +243,47 @@ 
 		Context::set('content_font_size', $option->content_font_size);
 
 		// Option setting to allow auto-save
-		if(!$option->enable_autosave) $enable_autosave = false;
-		elseif(Context::get($option->primary_key_name)) $enable_autosave = false;
-		else $enable_autosave = true;
+		if(!$option->enable_autosave) {
+			$enable_autosave = false;
+		} elseif(Context::get($option->primary_key_name)) {
+			$enable_autosave = false;
+		} else {
+			$enable_autosave = true;
+		}
 		// Option setting to allow the default editor component
-		if(!$option->enable_default_component) $enable_default_component = false;
-		else $enable_default_component = true;
+		if(!$option->enable_default_component) {
+			$enable_default_component = false;
+		} else {
+			$enable_default_component = true;
+		}
 		// Option setting to allow other extended components
-		if(!$option->enable_component) $enable_component = false;
-		else $enable_component = true;
+		if(!$option->enable_component) {
+			$enable_component = false;
+		} else {
+			$enable_component = true;
+		}
 		// Setting for html-mode
-		if($option->disable_html) $html_mode = false;
-		else $html_mode = true;
+		if($option->disable_html) {
+			$html_mode = false;
+		} else {
+			$html_mode = true;
+		}
 		// Set Height
-		if(!$option->height) $editor_height = 300;
-		else $editor_height = $option->height;
+		if(!$option->height) {
+			$editor_height = 300;
+		} else {
+			$editor_height = $option->height;
+		}
 		// Skin Setting
 		$skin = $option->skin;
-		if(!$skin) $skin = 'ckeditor';
+		if(!$skin) {
+			$skin = 'ckeditor';
+		}
 
 		$colorset = $option->colorset;
-		if(!$colorset) $colorset = 'moono';
+		if(!$colorset) {
+			$colorset = 'moono';
+		}
 		Context::set('colorset', $colorset);
 		Context::set('skin', $skin);
 		Context::set('module_type', $option->module_type);
@@ -258,10 +308,13 @@ 
 		/**
 		 * Extract editor's unique number (in order to display multiple editors on a single page)
 		 */
-		if($option->editor_sequence) $editor_sequence = $option->editor_sequence;
-		else
+		if($option->editor_sequence) {
+			$editor_sequence = $option->editor_sequence;
+		} else
 		{
-			if(!$_SESSION['_editor_sequence_']) $_SESSION['_editor_sequence_'] = 1;
+			if(!$_SESSION['_editor_sequence_']) {
+				$_SESSION['_editor_sequence_'] = 1;
+			}
 			$editor_sequence = $_SESSION['_editor_sequence_'] ++;
 		}
 
@@ -285,7 +338,9 @@ 
 			$oFileController = getController('file');
 			$oFileController->setUploadInfo($editor_sequence, $upload_target_srl);
 			// Check if the file already exists
-			if($upload_target_srl) $files_count = $oFileModel->getFilesCount($upload_target_srl);
+			if($upload_target_srl) {
+				$files_count = $oFileModel->getFilesCount($upload_target_srl);
+			}
 		}
 		Context::set('files_count', (int)$files_count);
 
@@ -377,8 +432,7 @@ 
 			$config->enable_html_grant = $editor_config->enable_html_grant;
 			$config->editor_height = $editor_config->editor_height;
 			$config->enable_autosave = $editor_config->enable_autosave;
-		}
-		else
+		} else
 		{
 			$config->editor_skin = $editor_config->comment_editor_skin;
 			$config->content_style = $editor_config->comment_content_style;
@@ -397,8 +451,7 @@ 
 		{
 			$logged_info = Context::get('logged_info');
 			$group_list = $logged_info->group_list;
-		}
-		else
+		} else
 		{
 			$group_list = array();
 		}
@@ -412,8 +465,9 @@ 
 		$option->colorset = $config->sel_editor_colorset;
 		// Permission check for file upload
 		$option->allow_fileupload = false;
-		if($logged_info->is_admin=='Y') $option->allow_fileupload = true;
-		elseif(count($config->upload_file_grant))
+		if($logged_info->is_admin=='Y') {
+			$option->allow_fileupload = true;
+		} elseif(count($config->upload_file_grant))
 		{
 			foreach($group_list as $group_srl => $group_info)
 			{
@@ -423,12 +477,14 @@ 
 					break;
 				}
 			}
+		} else {
+			$option->allow_fileupload = true;
 		}
-		else $option->allow_fileupload = true;
 		// Permission check for using default components
 		$option->enable_default_component = false;
-		if($logged_info->is_admin=='Y') $option->enable_default_component = true;
-		elseif(count($config->enable_default_component_grant))
+		if($logged_info->is_admin=='Y') {
+			$option->enable_default_component = true;
+		} elseif(count($config->enable_default_component_grant))
 		{
 			foreach($group_list as $group_srl => $group_info)
 			{
@@ -438,12 +494,14 @@ 
 					break;
 				}
 			}
+		} else {
+			$option->enable_default_component = true;
 		}
-		else $option->enable_default_component = true;
 		// Permisshion check for using extended components
 		$option->enable_component = false;
-		if($logged_info->is_admin=='Y') $option->enable_component = true;
-		elseif(count($config->enable_component_grant))
+		if($logged_info->is_admin=='Y') {
+			$option->enable_component = true;
+		} elseif(count($config->enable_component_grant))
 		{
 			foreach($group_list as $group_srl => $group_info)
 			{
@@ -453,12 +511,14 @@ 
 					break;
 				}
 			}
+		} else {
+			$option->enable_component = true;
 		}
-		else $option->enable_component = true;
 		// HTML editing privileges
 		$enable_html = false;
-		if($logged_info->is_admin=='Y') $enable_html = true;
-		elseif(count($config->enable_html_grant))
+		if($logged_info->is_admin=='Y') {
+			$enable_html = true;
+		} elseif(count($config->enable_html_grant))
 		{
 			foreach($group_list as $group_srl => $group_info)
 			{
@@ -468,11 +528,15 @@ 
 					break;
 				}
 			}
+		} else {
+			$enable_html = true;
 		}
-		else $enable_html = true;
 
-		if($enable_html) $option->disable_html = false;
-		else $option->disable_html = true;
+		if($enable_html) {
+			$option->disable_html = false;
+		} else {
+			$option->disable_html = true;
+		}
 		// Set Height
 		$option->height = $config->editor_height;
 		// Set an option for Auto-save
@@ -502,19 +566,22 @@ 
 		{
 			$logged_info = Context::get('logged_info');
 			$auto_save_args->member_srl = $logged_info->member_srl;
-		}
-		else
+		} else
 		{
 			$auto_save_args->certify_key = $_COOKIE['autosave_certify_key_' . $auto_save_args->module_srl];
 			// @see https://github.com/xpressengine/xe-core/issues/2208
 			// 변경 이전에 작성된 게시물 호환성 유지
-			if(!$auto_save_args->certify_key) $auto_save_args->ipaddress = $_SERVER['REMOTE_ADDR'];
+			if(!$auto_save_args->certify_key) {
+				$auto_save_args->ipaddress = $_SERVER['REMOTE_ADDR'];
+			}
 		}
 		// Extract auto-saved data from the DB
 		$output = executeQuery('editor.getSavedDocument', $auto_save_args);
 		$saved_doc = $output->data;
 		// Return null if no result is auto-saved
-		if(!$saved_doc) return;
+		if(!$saved_doc) {
+			return;
+		}
 
 		if($saved_doc->certify_key && !isset($auto_save_args->certify_key))
 		{
@@ -524,7 +591,9 @@ 
 		// Check if the auto-saved document already exists
 		$oDocumentModel = getModel('document');
 		$oSaved = $oDocumentModel->getDocument($saved_doc->document_srl);
-		if($oSaved->isExists()) return;
+		if($oSaved->isExists()) {
+			return;
+		}
 		// Move all the files if the auto-saved data contains document_srl and file
 		// Then set document_srl to editor_sequence
 		if($saved_doc->document_srl && $upload_target_srl && !Context::get('document_srl'))
@@ -532,8 +601,9 @@ 
 			$saved_doc->module_srl = $auto_save_args->module_srl;
 			$oFileController = getController('file');
 			$oFileController->moveFile($saved_doc->document_srl, $saved_doc->module_srl, $upload_target_srl);
+		} else if($upload_target_srl) {
+			$saved_doc->document_srl = $upload_target_srl;
 		}
-		else if($upload_target_srl) $saved_doc->document_srl = $upload_target_srl;
 		// Change auto-saved data
 		$saved_doc->certify_key = $auto_save_args->certify_key;
 		$oEditorController = getController('editor');
@@ -550,18 +620,24 @@ 
 	 */
 	function getComponentObject($component, $editor_sequence = 0, $site_srl = 0)
 	{
-		if(!preg_match('/^[a-zA-Z0-9_-]+$/',$component) || !preg_match('/^[0-9]+$/', $editor_sequence . $site_srl)) return;
+		if(!preg_match('/^[a-zA-Z0-9_-]+$/',$component) || !preg_match('/^[0-9]+$/', $editor_sequence . $site_srl)) {
+			return;
+		}
 
 		if(!$this->loaded_component_list[$component][$editor_sequence])
 		{
 			// Create an object of the component and execute
 			$class_path = sprintf('%scomponents/%s/', $this->module_path, $component);
 			$class_file = sprintf('%s%s.class.php', $class_path, $component);
-			if(!file_exists($class_file)) return new BaseObject(-1, sprintf(Context::getLang('msg_component_is_not_founded'), $component));
+			if(!file_exists($class_file)) {
+				return new BaseObject(-1, sprintf(Context::getLang('msg_component_is_not_founded'), $component));
+			}
 			// Create an object after loading the class file
 			require_once($class_file);
 			$oComponent = new $component($editor_sequence, $class_path);
-			if(!$oComponent) return new BaseObject(-1, sprintf(Context::getLang('msg_component_is_not_founded'), $component));
+			if(!$oComponent) {
+				return new BaseObject(-1, sprintf(Context::getLang('msg_component_is_not_founded'), $component));
+			}
 			// Add configuration information
 			$component_info = $this->getComponent($component, $site_srl);
 			$oComponent->setInfo($component_info);
@@ -588,8 +664,12 @@ 
 		$cache_path = _XE_PATH_.'files/cache/editor/cache/';
 		FileHandler::makeDir($cache_path);
 		$cache_file = $cache_path.'component_list.' . $lang .'.';
-		if($filter_enabled) $cache_file .= 'filter.';
-		if($site_srl) $cache_file .= $site_srl.'.';
+		if($filter_enabled) {
+			$cache_file .= 'filter.';
+		}
+		if($site_srl) {
+			$cache_file .= $site_srl.'.';
+		}
 		$cache_file .= 'php';
 		return $cache_file;
 	}
@@ -606,14 +686,15 @@ 
 			$oEditorController->makeCache(false, $site_srl);
 		}
 
-		if(!file_exists($cache_file)) return;
+		if(!file_exists($cache_file)) {
+			return;
+		}
 		include($cache_file);
 		$logged_info = Context::get('logged_info');
 		if($logged_info && is_array($logged_info->group_list))
 		{
 			$group_list = array_keys($logged_info->group_list);
-		}
-		else
+		} else
 		{
 			$group_list = array();
 		}
@@ -622,39 +703,50 @@ 
 		{
 			foreach($component_list as $key => $val)
 			{
-				if(!trim($key)) continue;
+				if(!trim($key)) {
+					continue;
+				}
 				if(!is_dir(_XE_PATH_.'modules/editor/components/'.$key))
 				{
 					FileHandler::removeFile($cache_file);
 					return $this->getComponentList($filter_enabled, $site_srl);
 				}
-				if(!$filter_enabled) continue;
+				if(!$filter_enabled) {
+					continue;
+				}
 				if($val->enabled == "N")
 				{
 					unset($component_list->{$key});
 					continue;
 				}
-				if($logged_info->is_admin == "Y" || $logged_info->is_site_admin == "Y") continue;
+				if($logged_info->is_admin == "Y" || $logged_info->is_site_admin == "Y") {
+					continue;
+				}
 				if($val->target_group)
 				{
 					if(!$logged_info)
 					{
 						$val->enabled = "N";
-					}
-					else
+					} else
 					{
 						$is_granted = false;
 						foreach($group_list as $group_srl)
 						{
-							if(in_array($group_srl, $val->target_group)) $is_granted = true;
+							if(in_array($group_srl, $val->target_group)) {
+								$is_granted = true;
+							}
+						}
+						if(!$is_granted) {
+							$val->enabled = "N";
 						}
-						if(!$is_granted) $val->enabled = "N";
 					}
 				}
 				if($val->enabled != "N" && $val->mid_list)
 				{
 					$mid = Context::get('mid');
-					if(!in_array($mid, $val->mid_list)) $val->enabled = "N";
+					if(!in_array($mid, $val->mid_list)) {
+						$val->enabled = "N";
+					}
 				}
 				if($val->enabled == "N")
 				{
@@ -678,14 +770,15 @@ 
 		{
 			$args->site_srl = $site_srl;
 			$output = executeQuery('editor.getSiteComponent', $args);
-		}
-		else
+		} else
 		{
 			$output = executeQuery('editor.getComponent', $args);
 		}
 		$component = $output->data;
 
-		if(!$output->data) return false;
+		if(!$output->data) {
+			return false;
+		}
 
 		$component_name = $component->component_name;
 
@@ -764,8 +857,7 @@ 
 			$component_info->homepage = $xml_doc->component->link->body;
 			$component_info->license = $xml_doc->component->license->body;
 			$component_info->license_link = $xml_doc->component->license->attrs->link;
-		}
-		else
+		} else
 		{
 			sscanf($xml_doc->component->author->attrs->date, '%d. %d. %d', $date_obj->y, $date_obj->m, $date_obj->d);
 			$date = sprintf('%04d%02d%02d', $date_obj->y, $date_obj->m, $date_obj->d);
@@ -782,8 +874,11 @@ 
 
 		// Author information
 		$author_list = array();
-		if(!is_array($xml_doc->component->author)) $author_list[] = $xml_doc->component->author;
-		else $author_list = $xml_doc->component->author;
+		if(!is_array($xml_doc->component->author)) {
+			$author_list[] = $xml_doc->component->author;
+		} else {
+			$author_list = $xml_doc->component->author;
+		}
 
 		for($i = 0; $i < count($author_list); $i++)
 		{

modules/module/module.model.php

Doc Comments +2 added lines

@@ -1038,6 +1038,7 @@ 
 	/**
 	 * @brief Get a list of skins for the module
 	 * Return file analysis of skin and skin.xml
+	 * @param string $path
 	 */
 	function getSkins($path, $dir = 'skins')
 	{
@@ -1362,6 +1363,7 @@ 
 	/**
 	 * @brief Return module configurations
 	 * Global configuration is used to manage board, member and others
+	 * @param string $module
 	 */
 	function getModuleConfig($module, $site_srl = 0)
 	{

Spacing +369 added lines, -369 removed lines

@@ -19,26 +19,26 @@ 
 	 */
 	function isIDExists($id, $site_srl = 0)
 	{
-		if(!preg_match('/^[a-z]{1}([a-z0-9_]+)$/i',$id)) return true;
+		if (!preg_match('/^[a-z]{1}([a-z0-9_]+)$/i', $id)) return true;
 		// directory and rss/atom/api reserved checking, etc.
 		$dirs = FileHandler::readDir(_XE_PATH_);
 		$dirs[] = 'rss';
 		$dirs[] = 'atom';
 		$dirs[] = 'api';
-		if(in_array($id, $dirs)) return true;
+		if (in_array($id, $dirs)) return true;
 		// mid test
 		$args = new stdClass();
 		$args->mid = $id;
 		$args->site_srl = $site_srl;
 		$output = executeQuery('module.isExistsModuleName', $args);
-		if($output->data->count) return true;
+		if ($output->data->count) return true;
 		// vid test (check mid != vid if site_srl=0, which means it is not a virtual site)
-		if(!$site_srl)
+		if (!$site_srl)
 		{
 			$site_args = new stdClass();
 			$site_args->domain = $id;
 			$output = executeQuery('module.isExistsSiteDomain', $site_args);
-			if($output->data->count) return true;
+			if ($output->data->count) return true;
 		}
 
 		return false;
@@ -82,10 +82,10 @@ 
 	function getDefaultMid()
 	{
 		$default_url = Context::getDefaultUrl();
-		if($default_url && substr_compare($default_url, '/', -1) === 0) $default_url = substr($default_url, 0, -1);
+		if ($default_url && substr_compare($default_url, '/', -1) === 0) $default_url = substr($default_url, 0, -1);
 
 		$request_url = Context::getRequestUri();
-		if($request_url && substr_compare($request_url, '/', -1) === 0) $request_url = substr($request_url, 0, -1);
+		if ($request_url && substr_compare($request_url, '/', -1) === 0) $request_url = substr($request_url, 0, -1);
 
 		$default_url_parse = parse_url($default_url);
 		$request_url_parse = parse_url($request_url);
@@ -95,20 +95,20 @@ 
 		// Set up
 		$domain = '';
 		$site_info = NULL;
-		if($default_url && $default_url_parse['host'] != $request_url_parse['host'])
+		if ($default_url && $default_url_parse['host'] != $request_url_parse['host'])
 		{
 			$hostname = $request_url_parse['host'];
 			$path = $request_url_parse['path'];
 			$port = $request_url_parse['port'];
-			if(strlen($path) >= 1 && substr_compare($path, '/', -1) === 0) $path = substr($path, 0, -1);
+			if (strlen($path) >= 1 && substr_compare($path, '/', -1) === 0) $path = substr($path, 0, -1);
 
-			$domain = sprintf('%s%s%s', $hostname, $port && ($port != 80 )? ':'.$port  : '', $path);
+			$domain = sprintf('%s%s%s', $hostname, $port && ($port != 80) ? ':'.$port : '', $path);
 		}
 
-		if($domain === '')
+		if ($domain === '')
 		{
-			if(!$vid) $vid = $mid;
-			if($vid)
+			if (!$vid) $vid = $mid;
+			if ($vid)
 			{
 				$domain = $vid;
 			}
@@ -116,89 +116,89 @@ 
 
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
 		// If domain is set, look for subsite
-		if($domain !== '')
+		if ($domain !== '')
 		{
 			$site_info = false;
-			if($oCacheHandler->isSupport())
+			if ($oCacheHandler->isSupport())
 			{
-				$object_key = 'site_info:' . md5($domain);
+				$object_key = 'site_info:'.md5($domain);
 				$domain_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 				$site_info = $oCacheHandler->get($domain_cache_key);
 			}
 
-			if($site_info === false)
+			if ($site_info === false)
 			{
 				$args = new stdClass();
 				$args->domain = $domain;
 				$output = executeQuery('module.getSiteInfoByDomain', $args);
 				$site_info = $output->data;
 
-				if($oCacheHandler->isSupport()) $oCacheHandler->put($domain_cache_key, $site_info);
+				if ($oCacheHandler->isSupport()) $oCacheHandler->put($domain_cache_key, $site_info);
 			}
 
-			if($site_info && $vid)
+			if ($site_info && $vid)
 			{
 				Context::set('vid', $site_info->domain, true);
-				if(strtolower($mid)==strtolower($site_info->domain)) Context::set('mid', $site_info->mid,true);
+				if (strtolower($mid) == strtolower($site_info->domain)) Context::set('mid', $site_info->mid, true);
 			}
-			if(!$site_info || !$site_info->domain) { $domain = ''; unset($site_info); }
+			if (!$site_info || !$site_info->domain) { $domain = ''; unset($site_info); }
 		}
 
 		// If no virtual website was found, get default website
-		if($domain === '')
+		if ($domain === '')
 		{
 			$site_info = false;
-			if($oCacheHandler->isSupport())
+			if ($oCacheHandler->isSupport())
 			{
 				$object_key = 'default_site';
 				$default_site_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 				$site_info = $oCacheHandler->get($default_site_cache_key);
 			}
 
-			if($site_info === false)
+			if ($site_info === false)
 			{
 				$args = new stdClass();
 				$args->site_srl = 0;
 				$output = executeQuery('module.getSiteInfo', $args);
 				// Update the related informaion if there is no default site info
-				if(!$output->data)
+				if (!$output->data)
 				{
 					// Create a table if sites table doesn't exist
 					$oDB = &DB::getInstance();
-					if(!$oDB->isTableExists('sites')) $oDB->createTableByXmlFile(_XE_PATH_.'modules/module/schemas/sites.xml');
-					if(!$oDB->isTableExists('sites')) return;
+					if (!$oDB->isTableExists('sites')) $oDB->createTableByXmlFile(_XE_PATH_.'modules/module/schemas/sites.xml');
+					if (!$oDB->isTableExists('sites')) return;
 
 					// Get mid, language
 					$mid_output = $oDB->executeQuery('module.getDefaultMidInfo', $args);
 					$db_info = Context::getDBInfo();
 					$domain = Context::getDefaultUrl();
 					$url_info = parse_url($domain);
-					$domain = $url_info['host'].( (!empty($url_info['port'])&&$url_info['port']!=80)?':'.$url_info['port']:'').$url_info['path'];
+					$domain = $url_info['host'].((!empty($url_info['port']) && $url_info['port'] != 80) ? ':'.$url_info['port'] : '').$url_info['path'];
 
 					$site_args = new stdClass;
 					$site_args->site_srl = 0;
-					$site_args->index_module_srl  = $mid_output->data->module_srl;
+					$site_args->index_module_srl = $mid_output->data->module_srl;
 					$site_args->domain = $domain;
 					$site_args->default_language = $db_info->lang_type;
 
-					if($output->data && !$output->data->index_module_srl)
+					if ($output->data && !$output->data->index_module_srl)
 					{
 						$output = executeQuery('module.updateSite', $site_args);
 					}
 					else
 					{
 						$output = executeQuery('module.insertSite', $site_args);
-						if(!$output->toBool()) return $output;
+						if (!$output->toBool()) return $output;
 					}
 					$output = executeQuery('module.getSiteInfo', $args);
 				}
 				$site_info = $output->data;
-				if($oCacheHandler->isSupport()) $oCacheHandler->put($default_site_cache_key, $site_info);
+				if ($oCacheHandler->isSupport()) $oCacheHandler->put($default_site_cache_key, $site_info);
 			}
 		}
 
-		if(!$site_info->module_srl) return $site_info;
-		if(is_array($site_info) && $site_info->data[0]) $site_info = $site_info[0];
+		if (!$site_info->module_srl) return $site_info;
+		if (is_array($site_info) && $site_info->data[0]) $site_info = $site_info[0];
 		return $this->addModuleExtraVars($site_info);
 	}
 
@@ -207,48 +207,48 @@ 
 	 */
 	function getModuleInfoByMid($mid, $site_srl = 0, $columnList = array())
 	{
-		if(!$mid || ($mid && !preg_match("/^[a-z][a-z0-9_]+$/i", $mid)))
+		if (!$mid || ($mid && !preg_match("/^[a-z][a-z0-9_]+$/i", $mid)))
 		{
 			return;
 		}
 
 		$args = new stdClass();
 		$args->mid = $mid;
-		$args->site_srl = (int)$site_srl;
+		$args->site_srl = (int) $site_srl;
 
 		$module_srl = false;
 		$module_info = false;
 
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
 			$object_key = 'module_srl:'.$mid.'_'.$site_srl;
 			$module_srl_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 			$module_srl = $oCacheHandler->get($module_srl_cache_key);
-			if($module_srl)
+			if ($module_srl)
 			{
-				$object_key = 'mid_info:' . $module_srl;
+				$object_key = 'mid_info:'.$module_srl;
 				$module_info_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 				$module_info = $oCacheHandler->get($module_info_cache_key);
 			}
 		}
 
-		if($module_info === false)
+		if ($module_info === false)
 		{
 			$output = executeQuery('module.getMidInfo', $args);
 			$module_info = $output->data;
-			if($oCacheHandler->isSupport())
+			if ($oCacheHandler->isSupport())
 			{
 				$oCacheHandler->put($module_srl_cache_key, $module_info->module_srl);
 
-				$object_key = 'mid_info:' . $module_info->module_srl;
+				$object_key = 'mid_info:'.$module_info->module_srl;
 				$module_info_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 				$oCacheHandler->put($module_info_cache_key, $module_info);
 			}
 		}
 
 		$this->applyDefaultSkin($module_info);
-		if(!$module_info->module_srl && $module_info->data[0]) $module_info = $module_info->data[0];
+		if (!$module_info->module_srl && $module_info->data[0]) $module_info = $module_info->data[0];
 		return $this->addModuleExtraVars($module_info);
 	}
 
@@ -264,7 +264,7 @@ 
 		$menuItemSrl = Context::get('menu_item_srl');
 		$menuItemSrl = (!$menuItemSrl) ? $menu_item_srl : $menuItemSrl;
 
-		if(!$menuItemSrl)
+		if (!$menuItemSrl)
 		{
 			$this->stop(-1, 'msg_invalid_request');
 			return;
@@ -273,7 +273,7 @@ 
 		$args = new stdClass();
 		$args->menu_item_srl = $menuItemSrl;
 		$output = executeQuery('module.getModuleInfoByMenuItemSrl', $args);
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			return $output;
 		}
@@ -297,12 +297,12 @@ 
 		$layoutInfoMobile = $layoutSrlMobile ? $oLayoutModel->getLayoutRawData($layoutSrlMobile, array('title')) : NULL;
 		$skinInfoPc = $this->loadSkinInfo(Modulehandler::getModulePath($moduleInfo->module), $skinNamePc);
 		$skinInfoMobile = $this->loadSkinInfo(Modulehandler::getModulePath($moduleInfo->module), $skinNameMobile, 'm.skins');
-		if(!$skinInfoPc)
+		if (!$skinInfoPc)
 		{
 			$skinInfoPc = new stdClass();
 			$skinInfoPc->title = $skinNamePc;
 		}
-		if(!$skinInfoMobile)
+		if (!$skinInfoMobile)
 		{
 			$skinInfoMobile = new stdClass();
 			$skinInfoMobile->title = $skinNameMobile;
@@ -321,23 +321,23 @@ 
 		$mid_info = false;
 
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
 			$object_key = 'module_srl:'.$mid.'_'.$site_srl;
 			$module_srl_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 			$module_srl = $oCacheHandler->get($module_srl_cache_key);
-			if($module_srl)
+			if ($module_srl)
 			{
-				$object_key = 'mid_info:' . $module_srl;
+				$object_key = 'mid_info:'.$module_srl;
 				$module_info_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 				$mid_info = $oCacheHandler->get($module_info_cache_key);
 			}
 
-			if($mid_info === false)
+			if ($mid_info === false)
 			{
 				$oCacheHandler->put($module_srl_cache_key, $output->data->module_srl);
 
-				$object_key = 'mid_info:' . $output->data->module_srl;
+				$object_key = 'mid_info:'.$output->data->module_srl;
 				$module_info_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 				$oCacheHandler->put($module_info_cache_key, $moduleInfo);
 			}
@@ -350,7 +350,7 @@ 
 
 		$moduleInfo = $this->addModuleExtraVars($moduleInfo);
 
-		if($moduleInfo->module == 'page' && $moduleInfo->page_type != 'ARTICLE')
+		if ($moduleInfo->module == 'page' && $moduleInfo->page_type != 'ARTICLE')
 		{
 			unset($moduleInfo->skin);
 			unset($moduleInfo->mskin);
@@ -369,32 +369,32 @@ 
 		$mid_info = false;
 
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
-			$object_key = 'mid_info:' . $module_srl;
+			$object_key = 'mid_info:'.$module_srl;
 			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 			$mid_info = $oCacheHandler->get($cache_key);
 		}
 
-		if($mid_info === false)
+		if ($mid_info === false)
 		{
 			// Get data
 			$args = new stdClass();
 			$args->module_srl = $module_srl;
 			$output = executeQuery('module.getMidInfo', $args);
-			if(!$output->toBool()) return;
+			if (!$output->toBool()) return;
 
 			$mid_info = $output->data;
 			$this->applyDefaultSkin($mid_info);
-			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $mid_info);
+			if ($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $mid_info);
 		}
 
-		if($mid_info && count($columnList))
+		if ($mid_info && count($columnList))
 		{
 			$module_info = new stdClass();
-			foreach($mid_info as $key => $item)
+			foreach ($mid_info as $key => $item)
 			{
-				if(in_array($key, $columnList))
+				if (in_array($key, $columnList))
 				{
 					$module_info->$key = $item;
 				}
@@ -403,7 +403,7 @@ 
 		else $module_info = $mid_info;
 
 		$oModuleController = getController('module');
-		if(isset($module_info->browser_title)) $oModuleController->replaceDefinedLangCode($module_info->browser_title);
+		if (isset($module_info->browser_title)) $oModuleController->replaceDefinedLangCode($module_info->browser_title);
 
 		$this->applyDefaultSkin($module_info);
 		return $this->addModuleExtraVars($module_info);
@@ -416,12 +416,12 @@ 
 	 */
 	private function applyDefaultSkin(&$moduleInfo)
 	{
-		if($moduleInfo->is_skin_fix == 'N')
+		if ($moduleInfo->is_skin_fix == 'N')
 		{
 			$moduleInfo->skin = '/USE_DEFAULT/';
 		}
 
-		if($moduleInfo->is_mskin_fix == 'N')
+		if ($moduleInfo->is_mskin_fix == 'N')
 		{
 			$moduleInfo->mskin = '/USE_DEFAULT/';
 		}
@@ -439,7 +439,7 @@ 
 		$count = count($output->data);
 
 		$modules = array();
-		for($i=0;$i<$count;$i++)
+		for ($i = 0; $i < $count; $i++)
 		{
 			$modules[] = $output->data[$i];
 		}
@@ -451,11 +451,11 @@ 
 	 */
 	function getModulesInfo($module_srls, $columnList = array())
 	{
-		if(is_array($module_srls)) $module_srls = implode(',',$module_srls);
+		if (is_array($module_srls)) $module_srls = implode(',', $module_srls);
 		$args = new stdClass();
 		$args->module_srls = $module_srls;
 		$output = executeQueryArray('module.getModulesInfo', $args, $columnList);
-		if(!$output->toBool()) return;
+		if (!$output->toBool()) return;
 		return $this->addModuleExtraVars($output->data);
 	}
 
@@ -465,31 +465,31 @@ 
 	function addModuleExtraVars($module_info)
 	{
 		// Process although one or more module informaion is requested
-		if(!is_array($module_info)) $target_module_info = array($module_info);
+		if (!is_array($module_info)) $target_module_info = array($module_info);
 		else $target_module_info = $module_info;
 		// Get module_srl
 		$module_srls = array();
-		foreach($target_module_info as $key => $val)
+		foreach ($target_module_info as $key => $val)
 		{
 			$module_srl = $val->module_srl;
-			if(!$module_srl) continue;
+			if (!$module_srl) continue;
 			$module_srls[] = $val->module_srl;
 		}
 		// Extract extra information of the module and skin
 		$extra_vars = $this->getModuleExtraVars($module_srls);
-		if(!count($module_srls) || !count($extra_vars)) return $module_info;
+		if (!count($module_srls) || !count($extra_vars)) return $module_info;
 
-		foreach($target_module_info as $key => $val)
+		foreach ($target_module_info as $key => $val)
 		{
-			if(!$extra_vars[$val->module_srl] || !count($extra_vars[$val->module_srl])) continue;
-			foreach($extra_vars[$val->module_srl] as $k => $v)
+			if (!$extra_vars[$val->module_srl] || !count($extra_vars[$val->module_srl])) continue;
+			foreach ($extra_vars[$val->module_srl] as $k => $v)
 			{
-				if($target_module_info[$key]->{$k}) continue;
+				if ($target_module_info[$key]->{$k}) continue;
 				$target_module_info[$key]->{$k} = $v;
 			}
 		}
 
-		if(is_array($module_info)) return $target_module_info;
+		if (is_array($module_info)) return $target_module_info;
 		return $target_module_info[0];
 	}
 
@@ -500,37 +500,37 @@ 
 	{
 		$list = false;
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
-			if(count($args) === 1 && isset($args->site_srl))
+			if (count($args) === 1 && isset($args->site_srl))
 			{
-				$object_key = 'module:mid_list_' . $args->site_srl;
+				$object_key = 'module:mid_list_'.$args->site_srl;
 				$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 				$list = $oCacheHandler->get($cache_key);
 			}
 		}
 
-		if($list === false)
+		if ($list === false)
 		{
-			if($oCacheHandler->isSupport() && count($args) === 1 && isset($args->site_srl))
+			if ($oCacheHandler->isSupport() && count($args) === 1 && isset($args->site_srl))
 			{
 				$columnList = array();
 			}
 
 			$output = executeQuery('module.getMidList', $args, $columnList);
-			if(!$output->toBool()) return $output;
+			if (!$output->toBool()) return $output;
 			$list = $output->data;
 
-			if($oCacheHandler->isSupport() && count($args) === 1 && isset($args->site_srl))
+			if ($oCacheHandler->isSupport() && count($args) === 1 && isset($args->site_srl))
 			{
 				$oCacheHandler->put($cache_key, $list);
 			}
 		}
-		if(!$list) return;
+		if (!$list) return;
 
-		if(!is_array($list)) $list = array($list);
+		if (!is_array($list)) $list = array($list);
 
-		foreach($list as $val)
+		foreach ($list as $val)
 		{
 			$mid_list[$val->mid] = $val;
 		}
@@ -544,10 +544,10 @@ 
 	function getModuleSrlList($args = null, $columnList = array())
 	{
 		$output = executeQueryArray('module.getMidList', $args, $columnList);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
 		$list = $output->data;
-		if(!$list) return;
+		if (!$list) return;
 
 		return $list;
 	}
@@ -557,22 +557,22 @@ 
 	 */
 	function getModuleSrlByMid($mid)
 	{
-		if($mid && !is_array($mid)) $mid = explode(',',$mid);
-		if(is_array($mid)) $mid = "'".implode("','",$mid)."'";
+		if ($mid && !is_array($mid)) $mid = explode(',', $mid);
+		if (is_array($mid)) $mid = "'".implode("','", $mid)."'";
 
 		$site_module_info = Context::get('site_module_info');
 
 		$args = new stdClass;
 		$args->mid = $mid;
-		if($site_module_info) $args->site_srl = $site_module_info->site_srl;
+		if ($site_module_info) $args->site_srl = $site_module_info->site_srl;
 		$output = executeQuery('module.getModuleSrlByMid', $args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
 		$list = $output->data;
-		if(!$list) return;
-		if(!is_array($list)) $list = array($list);
+		if (!$list) return;
+		if (!is_array($list)) $list = array($list);
 
-		foreach($list as $key => $val)
+		foreach ($list as $key => $val)
 		{
 			$module_srl_list[] = $val->module_srl;
 		}
@@ -588,33 +588,33 @@ 
 		$action_forward = false;
 		// cache controll
 		$oCacheHandler = CacheHandler::getInstance('object', NULL, TRUE);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
 			$cache_key = 'action_forward';
 			$action_forward = $oCacheHandler->get($cache_key);
 		}
 
 		// retrieve and caching all registered action_forward
-		if($action_forward === false)
+		if ($action_forward === false)
 		{
 			$args = new stdClass();
-			$output = executeQueryArray('module.getActionForward',$args);
-			if(!$output->toBool()) return new stdClass;
-			if(!$output->data) $output->data = array();
+			$output = executeQueryArray('module.getActionForward', $args);
+			if (!$output->toBool()) return new stdClass;
+			if (!$output->data) $output->data = array();
 
 			$action_forward = array();
-			foreach($output->data as $item)
+			foreach ($output->data as $item)
 			{
 				$action_forward[$item->act] = $item;
 			}
 
-			if($oCacheHandler->isSupport())
+			if ($oCacheHandler->isSupport())
 			{
 				$oCacheHandler->put($cache_key, $action_forward);
 			}
 		}
 
-		if($action_forward[$act])
+		if ($action_forward[$act])
 		{
 			return $action_forward[$act];
 		}
@@ -629,25 +629,25 @@ 
 	 */
 	function getTriggers($trigger_name, $called_position)
 	{
-		if(is_null($GLOBALS['__triggers__']))
+		if (is_null($GLOBALS['__triggers__']))
 		{
 			$triggers = FALSE;
 			$oCacheHandler = CacheHandler::getInstance('object', NULL, TRUE);
-			if($oCacheHandler->isSupport())
+			if ($oCacheHandler->isSupport())
 			{
 				$cache_key = 'triggers';
 				$triggers = $oCacheHandler->get($cache_key);
 			}
-			if($triggers === FALSE)
+			if ($triggers === FALSE)
 			{
 				$output = executeQueryArray('module.getTriggers');
 				$triggers = $output->data;
-				if($output->toBool() && $oCacheHandler->isSupport())
+				if ($output->toBool() && $oCacheHandler->isSupport())
 				{
 					$oCacheHandler->put($cache_key, $triggers);
 				}
 			}
-			foreach($triggers as $item)
+			foreach ($triggers as $item)
 			{
 				$GLOBALS['__triggers__'][$item->trigger_name][$item->called_position][] = $item;
 			}
@@ -663,11 +663,11 @@ 
 	{
 		$triggers = $this->getTriggers($trigger_name, $called_position);
 
-		if($triggers && is_array($triggers))
+		if ($triggers && is_array($triggers))
 		{
-			foreach($triggers as $item)
+			foreach ($triggers as $item)
 			{
-				if($item->module == $module && $item->type == $type && $item->called_method == $called_method)
+				if ($item->module == $module && $item->type == $type && $item->called_method == $called_method)
 				{
 					return $item;
 				}
@@ -680,12 +680,12 @@ 
 	/**
 	 * @brief Get module extend
 	 */
-	function getModuleExtend($parent_module, $type, $kind='')
+	function getModuleExtend($parent_module, $type, $kind = '')
 	{
 		$key = $parent_module.'.'.$kind.'.'.$type;
 
 		$module_extend_info = $this->loadModuleExtends();
-		if(array_key_exists($key, $module_extend_info))
+		if (array_key_exists($key, $module_extend_info))
 		{
 			return $module_extend_info[$key];
 		}
@@ -701,29 +701,29 @@ 
 		$cache_file = './files/config/module_extend.php';
 		$cache_file = FileHandler::getRealPath($cache_file);
 
-		if(!isset($GLOBALS['__MODULE_EXTEND__']))
+		if (!isset($GLOBALS['__MODULE_EXTEND__']))
 		{
 			// check pre install
-			if(file_exists(FileHandler::getRealPath('./files')) && !file_exists($cache_file))
+			if (file_exists(FileHandler::getRealPath('./files')) && !file_exists($cache_file))
 			{
 				$arr = array();
 				$output = executeQueryArray('module.getModuleExtend');
-				if($output->data)
+				if ($output->data)
 				{
-					foreach($output->data as $v)
+					foreach ($output->data as $v)
 					{
 						$arr[] = sprintf("'%s.%s.%s' => '%s'", $v->parent_module, $v->kind, $v->type, $v->extend_module);
 					}
 				}
 
 				$str = '<?PHP return array(%s); ?>';
-				$str = sprintf($str, join(',',$arr));
+				$str = sprintf($str, join(',', $arr));
 
 				FileHandler::writeFile($cache_file, $str);
 			}
 
 
-			if(file_exists($cache_file))
+			if (file_exists($cache_file))
 			{
 				$GLOBALS['__MODULE_EXTEND__'] = include($cache_file);
 			}
@@ -743,20 +743,20 @@ 
 	{
 		// Get a path of the requested module. Return if not exists.
 		$module_path = ModuleHandler::getModulePath($module);
-		if(!$module_path) return;
+		if (!$module_path) return;
 		// Read the xml file for module skin information
 		$xml_file = sprintf("%s/conf/info.xml", $module_path);
-		if(!file_exists($xml_file)) return;
+		if (!file_exists($xml_file)) return;
 
 		$oXmlParser = new XmlParser();
 		$tmp_xml_obj = $oXmlParser->loadXmlFile($xml_file);
 		$xml_obj = $tmp_xml_obj->module;
 
-		if(!$xml_obj) return;
+		if (!$xml_obj) return;
 
 		// Module Information
 		$module_info = new stdClass();
-		if($xml_obj->version && $xml_obj->attrs->version == '0.2')
+		if ($xml_obj->version && $xml_obj->attrs->version == '0.2')
 		{
 			// module format 0.2
 			$module_info->title = $xml_obj->title->body;
@@ -764,16 +764,16 @@ 
 			$module_info->version = $xml_obj->version->body;
 			$module_info->homepage = $xml_obj->link->body;
 			$module_info->category = $xml_obj->category->body;
-			if(!$module_info->category) $module_info->category = 'service';
+			if (!$module_info->category) $module_info->category = 'service';
 			sscanf($xml_obj->date->body, '%d-%d-%d', $date_obj->y, $date_obj->m, $date_obj->d);
 			$module_info->date = sprintf('%04d%02d%02d', $date_obj->y, $date_obj->m, $date_obj->d);
 			$module_info->license = $xml_obj->license->body;
 			$module_info->license_link = $xml_obj->license->attrs->link;
 
-			if(!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;
+			if (!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;
 			else $author_list = $xml_obj->author;
 
-			foreach($author_list as $author)
+			foreach ($author_list as $author)
 			{
 				$author_obj = new stdClass();
 				$author_obj->name = $author->name->body;
@@ -789,7 +789,7 @@ 
 			$module_info->description = $xml_obj->author->description->body;
 			$module_info->version = $xml_obj->attrs->version;
 			$module_info->category = $xml_obj->attrs->category;
-			if(!$module_info->category) $module_info->category = 'service';
+			if (!$module_info->category) $module_info->category = 'service';
 			sscanf($xml_obj->author->attrs->date, '%d. %d. %d', $date_obj->y, $date_obj->m, $date_obj->d);
 			$module_info->date = sprintf('%04d%02d%02d', $date_obj->y, $date_obj->m, $date_obj->d);
 			$author_obj = new stdClass();
@@ -818,17 +818,17 @@ 
 	{
 		// Get a path of the requested module. Return if not exists.
 		$class_path = ModuleHandler::getModulePath($module);
-		if(!$class_path) return;
+		if (!$class_path) return;
 
 		// Check if module.xml exists in the path. Return if not exist
 		$xml_file = sprintf("%sconf/module.xml", $class_path);
-		if(!file_exists($xml_file)) return;
+		if (!file_exists($xml_file)) return;
 
 		// Check if cached file exists
-		$cache_file = sprintf(_XE_PATH_ . "files/cache/module_info/%s.%s.%s.php", $module, Context::getLangType(), __XE_VERSION__);
+		$cache_file = sprintf(_XE_PATH_."files/cache/module_info/%s.%s.%s.php", $module, Context::getLangType(), __XE_VERSION__);
 
 		// Update if no cache file exists or it is older than xml file
-		if(!file_exists($cache_file) || filemtime($cache_file) < filemtime($xml_file) || $re_cache)
+		if (!file_exists($cache_file) || filemtime($cache_file) < filemtime($xml_file) || $re_cache)
 		{
 			$info = new stdClass();
 			$buff = array(); // /< Set buff variable to use in the cache file
@@ -841,7 +841,7 @@ 
 
 			$xml_obj = XmlParser::loadXmlFile($xml_file); // /< Read xml file and convert it to xml object
 
-			if(!count($xml_obj->module)) return; // /< Error occurs if module tag doesn't included in the xml
+			if (!count($xml_obj->module)) return; // /< Error occurs if module tag doesn't included in the xml
 
 			$grants = $xml_obj->module->grants->grant; // /< Permission information
 			$permissions = $xml_obj->module->permissions->permission; // /<  Acting permission
@@ -851,17 +851,17 @@ 
 			$default_index = $admin_index = '';
 
 			// Arrange permission information
-			if($grants)
+			if ($grants)
 			{
-				if(is_array($grants)) $grant_list = $grants;
+				if (is_array($grants)) $grant_list = $grants;
 				else $grant_list[] = $grants;
 
 				$info->grant = new stdClass();
 				$buff[] = '$info->grant = new stdClass;';
-				foreach($grant_list as $grant)
+				foreach ($grant_list as $grant)
 				{
 					$name = $grant->attrs->name;
-					$default = $grant->attrs->default?$grant->attrs->default:'guest';
+					$default = $grant->attrs->default ? $grant->attrs->default : 'guest';
 					$title = $grant->title->body;
 
 					$info->grant->{$name} = new stdClass();
@@ -874,15 +874,15 @@ 
 				}
 			}
 			// Permissions to grant
-			if($permissions)
+			if ($permissions)
 			{
-				if(is_array($permissions)) $permission_list = $permissions;
+				if (is_array($permissions)) $permission_list = $permissions;
 				else $permission_list[] = $permissions;
 
 				$buff[] = '$info->permission = new stdClass;';
 
 				$info->permission = new stdClass();
-				foreach($permission_list as $permission)
+				foreach ($permission_list as $permission)
 				{
 					$action = $permission->attrs->action;
 					$target = $permission->attrs->target;
@@ -893,14 +893,14 @@ 
 				}
 			}
 			// for admin menus
-			if($menus)
+			if ($menus)
 			{
-				if(is_array($menus)) $menu_list = $menus;
+				if (is_array($menus)) $menu_list = $menus;
 				else $menu_list[] = $menus;
 
 				$buff[] = '$info->menu = new stdClass;';
 				$info->menu = new stdClass();
-				foreach($menu_list as $menu)
+				foreach ($menu_list as $menu)
 				{
 					$menu_name = $menu->attrs->name;
 					$menu_title = is_array($menu->title) ? $menu->title[0]->body : $menu->title->body;
@@ -918,23 +918,23 @@ 
 			}
 
 			// actions
-			if($actions)
+			if ($actions)
 			{
-				if(is_array($actions)) $action_list = $actions;
+				if (is_array($actions)) $action_list = $actions;
 				else $action_list[] = $actions;
 
 				$buff[] = '$info->action = new stdClass;';
 				$info->action = new stdClass();
-				foreach($action_list as $action)
+				foreach ($action_list as $action)
 				{
 					$name = $action->attrs->name;
 
 					$type = $action->attrs->type;
-					$grant = $action->attrs->grant?$action->attrs->grant:'guest';
-					$standalone = $action->attrs->standalone=='false'?'false':'true';
-					$ruleset = $action->attrs->ruleset?$action->attrs->ruleset:'';
-					$method = $action->attrs->method?$action->attrs->method:'';
-					$check_csrf = $action->attrs->check_csrf=='false'?'false':'true';
+					$grant = $action->attrs->grant ? $action->attrs->grant : 'guest';
+					$standalone = $action->attrs->standalone == 'false' ? 'false' : 'true';
+					$ruleset = $action->attrs->ruleset ? $action->attrs->ruleset : '';
+					$method = $action->attrs->method ? $action->attrs->method : '';
+					$check_csrf = $action->attrs->check_csrf == 'false' ? 'false' : 'true';
 
 					$index = $action->attrs->index;
 					$admin_index = $action->attrs->admin_index;
@@ -949,14 +949,14 @@ 
 					$info->action->{$name}->ruleset = $ruleset;
 					$info->action->{$name}->method = $method;
 					$info->action->{$name}->check_csrf = $check_csrf;
-					if($action->attrs->menu_name)
+					if ($action->attrs->menu_name)
 					{
-						if($menu_index == 'true')
+						if ($menu_index == 'true')
 						{
 							$info->menu->{$action->attrs->menu_name}->index = $name;
 							$buff[] = sprintf('$info->menu->%s->index=\'%s\';', $action->attrs->menu_name, $name);
 						}
-						if(is_array($info->menu->{$action->attrs->menu_name}->acts))
+						if (is_array($info->menu->{$action->attrs->menu_name}->acts))
 						{
 							$info->menu->{$action->attrs->menu_name}->acts[] = $name;
 							$currentKey = array_search($name, $info->menu->{$action->attrs->menu_name}->acts);
@@ -974,22 +974,22 @@ 
 					$buff[] = sprintf('$info->action->%s->method=\'%s\';', $name, $method);
 					$buff[] = sprintf('$info->action->%s->check_csrf=\'%s\';', $name, $check_csrf);
 
-					if($index=='true')
+					if ($index == 'true')
 					{
 						$default_index_act = $name;
 						$info->default_index_act = $name;
 					}
-					if($admin_index=='true')
+					if ($admin_index == 'true')
 					{
 						$admin_index_act = $name;
 						$info->admin_index_act = $name;
 					}
-					if($setup_index=='true')
+					if ($setup_index == 'true')
 					{
 						$setup_index_act = $name;
 						$info->setup_index_act = $name;
 					}
-					if($simple_setup_index=='true')
+					if ($simple_setup_index == 'true')
 					{
 						$simple_setup_index_act = $name;
 						$info->simple_setup_index_act = $name;
@@ -1010,7 +1010,7 @@ 
 			return $info;
 		}
 
-		if(file_exists($cache_file)) return include($cache_file);
+		if (file_exists($cache_file)) return include($cache_file);
 	}
 
 	/**
@@ -1021,7 +1021,7 @@ 
 	{
 		$module = Context::get('module_type');
 
-		if($module == 'ARTICLE')
+		if ($module == 'ARTICLE')
 		{
 			$module = 'page';
 		}
@@ -1041,26 +1041,26 @@ 
 	 */
 	function getSkins($path, $dir = 'skins')
 	{
-		if(substr($path, -1) == '/')
+		if (substr($path, -1) == '/')
 		{
 			$path = substr($path, 0, -1);
 		}
 
 		$skin_path = sprintf("%s/%s/", $path, $dir);
 		$list = FileHandler::readDir($skin_path);
-		if(!count($list)) return;
+		if (!count($list)) return;
 
 		natcasesort($list);
 
-		foreach($list as $skin_name)
+		foreach ($list as $skin_name)
 		{
-			if(!is_dir($skin_path . $skin_name))
+			if (!is_dir($skin_path.$skin_name))
 			{
 				continue;
 			}
 			unset($skin_info);
 			$skin_info = $this->loadSkinInfo($path, $skin_name, $dir);
-			if(!$skin_info)
+			if (!$skin_info)
 			{
 				$skin_info = new stdClass();
 				$skin_info->title = $skin_name;
@@ -1073,15 +1073,15 @@ 
 		$tmpPath = trim($tmpPath);
 		$module = array_pop(explode(' ', $tmpPath));
 
-		if($dir == 'skins')
+		if ($dir == 'skins')
 		{
 			$oAdminModel = getAdminModel('admin');
 			$themesInfo = $oAdminModel->getThemeList();
 
-			foreach($themesInfo as $themeName => $info)
+			foreach ($themesInfo as $themeName => $info)
 			{
 				$skinInfos = $info->skin_infos;
-				if(isset($skinInfos[$module]) && $skinInfos[$module]->is_theme)
+				if (isset($skinInfos[$module]) && $skinInfos[$module]->is_theme)
 				{
 					$themeSkinInfo = $GLOBALS['__ThemeModuleSkin__'][$module]['skins'][$skinInfos[$module]->name];
 					$skin_list[$skinInfos[$module]->name] = $themeSkinInfo;
@@ -1093,13 +1093,13 @@ 
 		$oMenuAdminModel = getAdminModel('menu');
 		$installedMenuTypes = $oMenuAdminModel->getModuleListInSitemap($siteInfo->site_srl);
 		$moduleName = $module;
-		if($moduleName === 'page')
+		if ($moduleName === 'page')
 		{
 			$moduleName = 'ARTICLE';
 		}
-		if(array_key_exists($moduleName, $installedMenuTypes))
+		if (array_key_exists($moduleName, $installedMenuTypes))
 		{
-			if($dir == 'skins')
+			if ($dir == 'skins')
 			{
 				$type = 'P';
 			}
@@ -1109,12 +1109,12 @@ 
 			}
 			$defaultSkinName = $this->getModuleDefaultSkin($module, $type, $site_info->site_srl);
 
-			if(isset($defaultSkinName))
+			if (isset($defaultSkinName))
 			{
 				$defaultSkinInfo = $this->loadSkinInfo($path, $defaultSkinName, $dir);
 
 				$useDefault = new stdClass();
-				$useDefault->title = Context::getLang('use_site_default_skin') . ' (' . $defaultSkinInfo->title . ')';
+				$useDefault->title = Context::getLang('use_site_default_skin').' ('.$defaultSkinInfo->title.')';
 
 				$useDefaultList['/USE_DEFAULT/'] = $useDefault;
 
@@ -1131,20 +1131,20 @@ 
 	function loadSkinInfo($path, $skin, $dir = 'skins')
 	{
 		// Read xml file having skin information
-		if(substr($path,-1)!='/') $path .= '/';
+		if (substr($path, -1) != '/') $path .= '/';
 		$skin_xml_file = sprintf("%s%s/%s/skin.xml", $path, $dir, $skin);
-		if(!file_exists($skin_xml_file)) return;
+		if (!file_exists($skin_xml_file)) return;
 		// Create XmlParser object
 		$oXmlParser = new XmlParser();
 		$_xml_obj = $oXmlParser->loadXmlFile($skin_xml_file);
 		// Return if no skin information is
-		if(!$_xml_obj->skin) return;
+		if (!$_xml_obj->skin) return;
 		$xml_obj = $_xml_obj->skin;
 		// Skin Name
 		$skin_info = new stdClass();
 		$skin_info->title = $xml_obj->title->body;
 		// Author information
-		if($xml_obj->version && $xml_obj->attrs->version == '0.2')
+		if ($xml_obj->version && $xml_obj->attrs->version == '0.2')
 		{
 			// skin format v0.2
 			sscanf($xml_obj->date->body, '%d-%d-%d', $date_obj->y, $date_obj->m, $date_obj->d);
@@ -1155,10 +1155,10 @@ 
 			$skin_info->license_link = $xml_obj->license->attrs->link;
 			$skin_info->description = $xml_obj->description->body;
 
-			if(!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;
+			if (!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;
 			else $author_list = $xml_obj->author;
 
-			foreach($author_list as $author)
+			foreach ($author_list as $author)
 			{
 				$author_obj = new stdClass();
 				$author_obj->name = $author->name->body;
@@ -1167,25 +1167,25 @@ 
 				$skin_info->author[] = $author_obj;
 			}
 			// List extra vars
-			if($xml_obj->extra_vars)
+			if ($xml_obj->extra_vars)
 			{
 				$extra_var_groups = $xml_obj->extra_vars->group;
-				if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
-				if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
+				if (!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
+				if (!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
 
-				foreach($extra_var_groups as $group)
+				foreach ($extra_var_groups as $group)
 				{
 					$extra_vars = $group->var;
-					if(!$extra_vars)
+					if (!$extra_vars)
 					{
 						continue;
 					}
-					if(!is_array($group->var)) $extra_vars = array($group->var);
+					if (!is_array($group->var)) $extra_vars = array($group->var);
 
-					foreach($extra_vars as $key => $val)
+					foreach ($extra_vars as $key => $val)
 					{
 						$obj = new stdClass();
-						if(!$val->attrs->type) { $val->attrs->type = 'text'; }
+						if (!$val->attrs->type) { $val->attrs->type = 'text'; }
 
 						$obj->group = $group->title->body;
 						$obj->name = $val->attrs->name;
@@ -1194,14 +1194,14 @@ 
 						$obj->description = $val->description->body;
 						$obj->value = $extra_vals->{$obj->name};
 						$obj->default = $val->attrs->default;
-						if(strpos($obj->value, '|@|') != false) { $obj->value = explode('|@|', $obj->value); }
-						if($obj->type == 'mid_list' && !is_array($obj->value)) { $obj->value = array($obj->value); }
+						if (strpos($obj->value, '|@|') != false) { $obj->value = explode('|@|', $obj->value); }
+						if ($obj->type == 'mid_list' && !is_array($obj->value)) { $obj->value = array($obj->value); }
 						// Get an option list from 'select'type
-						if(is_array($val->options))
+						if (is_array($val->options))
 						{
 							$option_count = count($val->options);
 
-							for($i = 0; $i < $option_count; $i++)
+							for ($i = 0; $i < $option_count; $i++)
 							{
 								$obj->options[$i] = new stdClass();
 								$obj->options[$i]->title = $val->options[$i]->title->body;
@@ -1238,18 +1238,18 @@ 
 			$skin_info->author[0]->homepage = $xml_obj->maker->attrs->link;
 			// Variables used in the skin
 			$extra_var_groups = $xml_obj->extra_vars->group;
-			if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
-			if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
+			if (!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
+			if (!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
 
-			foreach($extra_var_groups as $group)
+			foreach ($extra_var_groups as $group)
 			{
 				$extra_vars = $group->var;
 
-				if($extra_vars)
+				if ($extra_vars)
 				{
-					if(!is_array($extra_vars)) $extra_vars = array($extra_vars);
+					if (!is_array($extra_vars)) $extra_vars = array($extra_vars);
 
-					foreach($extra_vars as $var)
+					foreach ($extra_vars as $var)
 					{
 						unset($obj);
 						unset($options);
@@ -1260,11 +1260,11 @@ 
 						$title = $var->title->body;
 						$description = $var->description->body;
 						// Get an option list from 'select'type.
-						if(is_array($var->default))
+						if (is_array($var->default))
 						{
 							$option_count = count($var->default);
 
-							for($i = 0; $i < $option_count; $i++)
+							for ($i = 0; $i < $option_count; $i++)
 							{
 								$options[$i]->title = $var->default[$i]->body;
 								$options[$i]->value = $var->default[$i]->body;
@@ -1298,19 +1298,19 @@ 
 
 		// colorset
 		$colorset = $xml_obj->colorset->color;
-		if($colorset)
+		if ($colorset)
 		{
-			if(!is_array($colorset)) $colorset = array($colorset);
+			if (!is_array($colorset)) $colorset = array($colorset);
 
-			foreach($colorset as $color)
+			foreach ($colorset as $color)
 			{
 				$name = $color->attrs->name;
 				$title = $color->title->body;
 				$screenshot = $color->attrs->src;
-				if($screenshot)
+				if ($screenshot)
 				{
 					$screenshot = sprintf("%s%s/%s/%s", $path, $dir, $skin, $screenshot);
-					if(!file_exists($screenshot)) $screenshot = "";
+					if (!file_exists($screenshot)) $screenshot = "";
 				}
 				else $screenshot = "";
 
@@ -1322,19 +1322,19 @@ 
 			}
 		}
 		// Menu type (settings for layout)
-		if($xml_obj->menus->menu)
+		if ($xml_obj->menus->menu)
 		{
 			$menus = $xml_obj->menus->menu;
-			if(!is_array($menus)) $menus = array($menus);
+			if (!is_array($menus)) $menus = array($menus);
 
 			$menu_count = count($menus);
 			$skin_info->menu_count = $menu_count;
-			for($i=0;$i<$menu_count;$i++)
+			for ($i = 0; $i < $menu_count; $i++)
 			{
 				unset($obj);
 
 				$obj->name = $menus[$i]->attrs->name;
-				if($menus[$i]->attrs->default == "true") $obj->default = true;
+				if ($menus[$i]->attrs->default == "true") $obj->default = true;
 				$obj->title = $menus[$i]->title->body;
 				$obj->maxdepth = $menus[$i]->maxdepth->body;
 
@@ -1343,7 +1343,7 @@ 
 		}
 
 		$thumbnail = sprintf("%s%s/%s/thumbnail.png", $path, $dir, $skin);
-		$skin_info->thumbnail = (file_exists($thumbnail))?$thumbnail:null;
+		$skin_info->thumbnail = (file_exists($thumbnail)) ? $thumbnail : null;
 		return $skin_info;
 	}
 
@@ -1354,7 +1354,7 @@ 
 	{
 		$args = new stdClass;
 		$args->site_srl = $site_srl;
-		if(!is_null($module)) $args->module = $module;
+		if (!is_null($module)) $args->module = $module;
 		$output = executeQuery('module.getModuleCount', $args);
 		return $output->data->count;
 	}
@@ -1368,26 +1368,26 @@ 
 		$config = false;
 		// cache controll
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
-			$object_key = 'module_config:' . $module . '_' . $site_srl;
+			$object_key = 'module_config:'.$module.'_'.$site_srl;
 			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 			$config = $oCacheHandler->get($cache_key);
 		}
 
-		if($config === false)
+		if ($config === false)
 		{
-			if(!$GLOBALS['__ModuleConfig__'][$site_srl][$module])
+			if (!$GLOBALS['__ModuleConfig__'][$site_srl][$module])
 			{
 				$args = new stdClass();
 				$args->module = $module;
 				$args->site_srl = $site_srl;
 				$output = executeQuery('module.getModuleConfig', $args);
-				if($output->data->config) $config = unserialize($output->data->config);
+				if ($output->data->config) $config = unserialize($output->data->config);
 				else $config = null;
 
 				//insert in cache
-				if($oCacheHandler->isSupport())
+				if ($oCacheHandler->isSupport())
 				{
 					$oCacheHandler->put($cache_key, $config);
 				}
@@ -1408,26 +1408,26 @@ 
 		$config = false;
 		// cache controll
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
 			$object_key = 'module_part_config:'.$module.'_'.$module_srl;
 			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 			$config = $oCacheHandler->get($cache_key);
 		}
 
-		if($config === false)
+		if ($config === false)
 		{
-			if(!isset($GLOBALS['__ModulePartConfig__'][$module][$module_srl]))
+			if (!isset($GLOBALS['__ModulePartConfig__'][$module][$module_srl]))
 			{
 				$args = new stdClass();
 				$args->module = $module;
 				$args->module_srl = $module_srl;
 				$output = executeQuery('module.getModulePartConfig', $args);
-				if($output->data->config) $config = unserialize($output->data->config);
+				if ($output->data->config) $config = unserialize($output->data->config);
 				else $config = null;
 
 				//insert in cache
-				if($oCacheHandler->isSupport())
+				if ($oCacheHandler->isSupport())
 				{
 					$oCacheHandler->put($cache_key, $config);
 				}
@@ -1446,11 +1446,11 @@ 
 	{
 		$args = new stdClass();
 		$args->module = $module;
-		if($site_srl) $args->site_srl = $site_srl;
+		if ($site_srl) $args->site_srl = $site_srl;
 		$output = executeQueryArray('module.getModulePartConfigs', $args);
-		if(!$output->toBool() || !$output->data) return array();
+		if (!$output->toBool() || !$output->data) return array();
 
-		foreach($output->data as $key => $val)
+		foreach ($output->data as $key => $val)
 		{
 			$result[$val->module_srl] = unserialize($val->config);
 		}
@@ -1466,12 +1466,12 @@ 
 		$args->moduleCategorySrl = $moduleCategorySrl;
 		// Get data from the DB
 		$output = executeQuery('module.getModuleCategories', $args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 		$list = $output->data;
-		if(!$list) return;
-		if(!is_array($list)) $list = array($list);
+		if (!$list) return;
+		if (!is_array($list)) $list = array($list);
 
-		foreach($list as $val)
+		foreach ($list as $val)
 		{
 			$category_list[$val->module_category_srl] = $val;
 		}
@@ -1487,7 +1487,7 @@ 
 		$args = new stdClass;
 		$args->module_category_srl = $module_category_srl;
 		$output = executeQuery('module.getModuleCategory', $args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 		return $output->data;
 	}
 
@@ -1499,10 +1499,10 @@ 
 		// Get a list of downloaded and installed modules
 		$searched_list = FileHandler::readDir('./modules');
 		$searched_count = count($searched_list);
-		if(!$searched_count) return;
+		if (!$searched_count) return;
 		sort($searched_list);
 
-		for($i=0;$i<$searched_count;$i++)
+		for ($i = 0; $i < $searched_count; $i++)
 		{
 			// Module name
 			$module_name = $searched_list[$i];
@@ -1512,7 +1512,7 @@ 
 			$info = $this->getModuleInfoXml($module_name);
 			unset($obj);
 
-			if(!isset($info)) continue;
+			if (!isset($info)) continue;
 			$info->module = $module_name;
 			$info->created_table_count = $created_table_count;
 			$info->table_count = $table_count;
@@ -1529,19 +1529,19 @@ 
 		$info = null;
 
 		$moduledir = ModuleHandler::getModulePath($module_name);
-		if(file_exists(FileHandler::getRealPath($moduledir."schemas")))
+		if (file_exists(FileHandler::getRealPath($moduledir."schemas")))
 		{
 			$tmp_files = FileHandler::readDir($moduledir."schemas", '/(\.xml)$/');
 			$table_count = count($tmp_files);
 			// Check if the table is created
 			$created_table_count = 0;
-			for($j=0;$j<count($tmp_files);$j++)
+			for ($j = 0; $j < count($tmp_files); $j++)
 			{
-				list($table_name) = explode(".",$tmp_files[$j]);
-				if($oDB->isTableExists($table_name)) $created_table_count ++;
+				list($table_name) = explode(".", $tmp_files[$j]);
+				if ($oDB->isTableExists($table_name)) $created_table_count++;
 			}
 			// Check if DB is installed
-			if($table_count > $created_table_count) return true;
+			if ($table_count > $created_table_count) return true;
 			else return false;
 		}
 		return false;
@@ -1551,7 +1551,7 @@ 
 	{
 		// Check if it is upgraded to module.class.php on each module
 		$oDummy = getModule($module_name, 'class');
-		if($oDummy && method_exists($oDummy, "checkUpdate"))
+		if ($oDummy && method_exists($oDummy, "checkUpdate"))
 		{
 			return $oDummy->checkUpdate();
 		}
@@ -1565,15 +1565,15 @@ 
 	 */
 	public function needUpdate($update_id)
 	{
-		if(!is_array($update_id)) $update_id = array($update_id);
+		if (!is_array($update_id)) $update_id = array($update_id);
 
 		$args = new stdClass();
 		$args->update_id = implode(',', $update_id);
 		$output = executeQueryArray('module.getModuleUpdateLog', $args);
 
-		if(!!$output->error) return false;
-		if(!$output->data) $output->data = array();
-		if(count($update_id) === count($output->data)) return false;
+		if (!!$output->error) return false;
+		if (!$output->data) $output->data = array();
+		if (count($update_id) === count($output->data)) return false;
 
 		return true;
 	}
@@ -1590,31 +1590,31 @@ 
 		sort($searched_list);
 
 		$searched_count = count($searched_list);
-		if(!$searched_count) return;
+		if (!$searched_count) return;
 
-		for($i=0;$i<$searched_count;$i++)
+		for ($i = 0; $i < $searched_count; $i++)
 		{
 			// module name
 			$module_name = $searched_list[$i];
 
 			$path = ModuleHandler::getModulePath($module_name);
-			if(!is_dir(FileHandler::getRealPath($path))) continue;
+			if (!is_dir(FileHandler::getRealPath($path))) continue;
 
 			// Get the number of xml files to create a table in schemas
 			$tmp_files = FileHandler::readDir($path.'schemas', '/(\.xml)$/');
 			$table_count = count($tmp_files);
 			// Check if the table is created
 			$created_table_count = 0;
-			for($j=0;$j<$table_count;$j++)
+			for ($j = 0; $j < $table_count; $j++)
 			{
-				list($table_name) = explode('.',$tmp_files[$j]);
-				if($oDB->isTableExists($table_name)) $created_table_count ++;
+				list($table_name) = explode('.', $tmp_files[$j]);
+				if ($oDB->isTableExists($table_name)) $created_table_count++;
 			}
 			// Get information of the module
 			$info = NULL;
 			$info = $this->getModuleInfoXml($module_name);
 
-			if(!$info) continue;
+			if (!$info) continue;
 
 			$info->module = $module_name;
 			$info->category = $info->category;
@@ -1623,12 +1623,12 @@ 
 			$info->path = $path;
 			$info->admin_index_act = $info->admin_index_act;
 			// Check if DB is installed
-			if($table_count > $created_table_count) $info->need_install = true;
+			if ($table_count > $created_table_count) $info->need_install = true;
 			else $info->need_install = false;
 			// Check if it is upgraded to module.class.php on each module
 			$oDummy = null;
 			$oDummy = getModule($module_name, 'class');
-			if($oDummy && method_exists($oDummy, "checkUpdate"))
+			if ($oDummy && method_exists($oDummy, "checkUpdate"))
 			{
 				$info->need_update = $oDummy->checkUpdate();
 			}
@@ -1649,15 +1649,15 @@ 
 	 */
 	function syncModuleToSite(&$data)
 	{
-		if(!$data) return;
+		if (!$data) return;
 
-		if(is_array($data))
+		if (is_array($data))
 		{
-			foreach($data as $key => $val)
+			foreach ($data as $key => $val)
 			{
 				$module_srls[] = $val->module_srl;
 			}
-			if(!count($module_srls)) return;
+			if (!count($module_srls)) return;
 		}
 		else
 		{
@@ -1665,17 +1665,17 @@ 
 		}
 
 		$args = new stdClass();
-		$args->module_srls = implode(',',$module_srls);
+		$args->module_srls = implode(',', $module_srls);
 		$output = executeQueryArray('module.getModuleSites', $args);
-		if(!$output->data) return array();
-		foreach($output->data as $key => $val)
+		if (!$output->data) return array();
+		foreach ($output->data as $key => $val)
 		{
 			$modules[$val->module_srl] = $val;
 		}
 
-		if(is_array($data))
+		if (is_array($data))
 		{
-			foreach($data as $key => $val)
+			foreach ($data as $key => $val)
 			{
 				$data[$key]->domain = $modules[$val->module_srl]->domain;
 			}
@@ -1691,14 +1691,14 @@ 
 	 */
 	function isSiteAdmin($member_info, $site_srl = null)
 	{
-		if(!$member_info->member_srl) return false;
-		if($member_info->is_admin == 'Y') return true;
+		if (!$member_info->member_srl) return false;
+		if ($member_info->is_admin == 'Y') return true;
 
 		$args = new stdClass();
-		if(!isset($site_srl))
+		if (!isset($site_srl))
 		{
 			$site_module_info = Context::get('site_module_info');
-			if(!$site_module_info) return;
+			if (!$site_module_info) return;
 			$args->site_srl = $site_module_info->site_srl;
 		}
 		else
@@ -1708,7 +1708,7 @@ 
 
 		$args->member_srl = $member_info->member_srl;
 		$output = executeQuery('module.isSiteAdmin', $args);
-		if($output->data->member_srl == $args->member_srl) return true;
+		if ($output->data->member_srl == $args->member_srl) return true;
 		return false;
 	}
 
@@ -1731,7 +1731,7 @@ 
 		$obj = new stdClass();
 		$obj->module_srl = $module_srl;
 		$output = executeQueryArray('module.getAdminID', $obj);
-		if(!$output->toBool() || !$output->data) return;
+		if (!$output->toBool() || !$output->data) return;
 
 		return $output->data;
 	}
@@ -1744,20 +1744,20 @@ 
 	{
 		$extra_vars = array();
 		$get_module_srls = array();
-		if(!is_array($list_module_srl)) $list_module_srl = array($list_module_srl);
+		if (!is_array($list_module_srl)) $list_module_srl = array($list_module_srl);
 
 		$vars = false;
 		// cache controll
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
-			foreach($list_module_srl as $module_srl)
+			foreach ($list_module_srl as $module_srl)
 			{
 				$object_key = 'module_extra_vars:'.$module_srl;
 				$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 				$vars = $oCacheHandler->get($cache_key);
 
-				if($vars)
+				if ($vars)
 				{
 					$extra_vars[$module_srl] = $vars;
 				}
@@ -1772,35 +1772,35 @@ 
 			$get_module_srls = $list_module_srl;
 		}
 
-		if(count($get_module_srls) > 0)
+		if (count($get_module_srls) > 0)
 		{
 			$args = new stdClass();
 			$args->module_srl = implode(',', $get_module_srls);
 			$output = executeQueryArray('module.getModuleExtraVars', $args);
 
-			if(!$output->toBool())
+			if (!$output->toBool())
 			{
 				return;
 			}
 
-			if(!$output->data)
+			if (!$output->data)
 			{
-				foreach($get_module_srls as $module_srl)
+				foreach ($get_module_srls as $module_srl)
 				{
 					$extra_vars[$module_srl] = new stdClass;
 				}
 			}
-			foreach($output->data as $key => $val)
+			foreach ($output->data as $key => $val)
 			{
-				if(in_array($val->name, array('mid','module')) || $val->value == 'Array') continue;
+				if (in_array($val->name, array('mid', 'module')) || $val->value == 'Array') continue;
 
-				if(!isset($extra_vars[$val->module_srl]))
+				if (!isset($extra_vars[$val->module_srl]))
 				{
 					$extra_vars[$val->module_srl] = new stdClass();
 				}
 				$extra_vars[$val->module_srl]->{$val->name} = $val->value;
 
-				if($oCacheHandler->isSupport())
+				if ($oCacheHandler->isSupport())
 				{
 					$object_key = 'module_extra_vars:'.$val->module_srl;
 					$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
@@ -1819,27 +1819,27 @@ 
 	{
 		$skin_vars = false;
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
 			$object_key = 'module_skin_vars:'.$module_srl;
 			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 			$skin_vars = $oCacheHandler->get($cache_key);
 		}
 
-		if($skin_vars === false)
+		if ($skin_vars === false)
 		{
 			$args = new stdClass();
 			$args->module_srl = $module_srl;
-			$output = executeQueryArray('module.getModuleSkinVars',$args);
-			if(!$output->toBool()) return;
+			$output = executeQueryArray('module.getModuleSkinVars', $args);
+			if (!$output->toBool()) return;
 
 			$skin_vars = array();
-			foreach($output->data as $vars)
+			foreach ($output->data as $vars)
 			{
 				$skin_vars[$vars->name] = $vars;
 			}
 
-			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);
+			if ($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);
 		}
 
 		return $skin_vars;
@@ -1851,32 +1851,32 @@ 
 	function getModuleDefaultSkin($module_name, $skin_type = 'P', $site_srl = 0, $updateCache = true)
 	{
 		$target = ($skin_type == 'M') ? 'mskin' : 'skin';
-		if(!$site_srl) $site_srl = 0;
+		if (!$site_srl) $site_srl = 0;
 
 		$designInfoFile = sprintf(_XE_PATH_.'files/site_design/design_%s.php', $site_srl);
-		if(is_readable($designInfoFile))
+		if (is_readable($designInfoFile))
 		{
 			include($designInfoFile);
 
 			$skinName = $designInfo->module->{$module_name}->{$target};
 		}
-		if(!$skinName)
+		if (!$skinName)
 		{
 			$dir = ($skin_type == 'M') ? 'm.skins/' : 'skins/';
 			$moduleSkinPath = ModuleHandler::getModulePath($module_name).$dir;
 
-			if(is_dir($moduleSkinPath.'default'))
+			if (is_dir($moduleSkinPath.'default'))
 			{
 				$skinName = 'default';
 			}
-			else if(is_dir($moduleSkinPath.'xe_default'))
+			else if (is_dir($moduleSkinPath.'xe_default'))
 			{
 				$skinName = 'xe_default';
 			}
 			else
 			{
 				$skins = FileHandler::readDir($moduleSkinPath);
-				if(count($skins) > 0)
+				if (count($skins) > 0)
 				{
 					$skinName = $skins[0];
 				}
@@ -1886,9 +1886,9 @@ 
 				}
 			}
 
-			if($updateCache && $skinName)
+			if ($updateCache && $skinName)
 			{
-				if(!isset($designInfo->module->{$module_name})) $designInfo->module->{$module_name} = new stdClass();
+				if (!isset($designInfo->module->{$module_name})) $designInfo->module->{$module_name} = new stdClass();
 				$designInfo->module->{$module_name}->{$target} = $skinName;
 
 				$oAdminController = getAdminController('admin');
@@ -1904,10 +1904,10 @@ 
 	 */
 	function syncSkinInfoToModuleInfo(&$module_info)
 	{
-		if(!$module_info->module_srl) return;
+		if (!$module_info->module_srl) return;
 
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if(Mobile::isFromMobilePhone())
+		if (Mobile::isFromMobilePhone())
 		{
 			$skin_vars = $this->getModuleMobileSkinVars($module_info->module_srl);
 		}
@@ -1916,11 +1916,11 @@ 
 			$skin_vars = $this->getModuleSkinVars($module_info->module_srl);
 		}
 
-		if(!$skin_vars) return;
+		if (!$skin_vars) return;
 
-		foreach($skin_vars as $name => $val)
+		foreach ($skin_vars as $name => $val)
 		{
-			if(isset($module_info->{$name})) continue;
+			if (isset($module_info->{$name})) continue;
 			$module_info->{$name} = $val->value;
 		}
 	}
@@ -1934,27 +1934,27 @@ 
 	{
 		$skin_vars = false;
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
 			$object_key = 'module_mobile_skin_vars:'.$module_srl;
 			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 			$skin_vars = $oCacheHandler->get($cache_key);
 		}
 
-		if($skin_vars === false)
+		if ($skin_vars === false)
 		{
 			$args = new stdClass();
 			$args->module_srl = $module_srl;
-			$output = executeQueryArray('module.getModuleMobileSkinVars',$args);
-			if(!$output->toBool() || !$output->data) return;
+			$output = executeQueryArray('module.getModuleMobileSkinVars', $args);
+			if (!$output->toBool() || !$output->data) return;
 
 			$skin_vars = array();
-			foreach($output->data as $vars)
+			foreach ($output->data as $vars)
 			{
 				$skin_vars[$vars->name] = $vars;
 			}
 
-			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);
+			if ($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);
 		}
 
 		return $skin_vars;
@@ -1966,32 +1966,32 @@ 
 	 */
 	function syncMobileSkinInfoToModuleInfo(&$module_info)
 	{
-		if(!$module_info->module_srl) return;
+		if (!$module_info->module_srl) return;
 		$skin_vars = false;
 		// cache controll
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
 			$object_key = 'module_mobile_skin_vars:'.$module_info->module_srl;
 			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 			$skin_vars = $oCacheHandler->get($cache_key);
 		}
-		if($skin_vars === false)
+		if ($skin_vars === false)
 		{
 			$args = new stdClass;
 			$args->module_srl = $module_info->module_srl;
-			$output = executeQueryArray('module.getModuleMobileSkinVars',$args);
-			if(!$output->toBool()) return;
+			$output = executeQueryArray('module.getModuleMobileSkinVars', $args);
+			if (!$output->toBool()) return;
 			$skin_vars = $output->data;
 
 			//insert in cache
-			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);
+			if ($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);
 		}
-		if(!$skin_vars) return;
+		if (!$skin_vars) return;
 
-		foreach($output->data as $val)
+		foreach ($output->data as $val)
 		{
-			if(isset($module_info->{$val->name})) continue;
+			if (isset($module_info->{$val->name})) continue;
 			$module_info->{$val->name} = $val->value;
 		}
 	}
@@ -2003,7 +2003,7 @@ 
 	{
 		$grant = new stdClass();
 
-		if(!$xml_info)
+		if (!$xml_info)
 		{
 			$module = $module_info->module;
 			$xml_info = $this->getModuleActionXml($module);
@@ -2011,9 +2011,9 @@ 
 		// Set variables to grant group permission
 		$module_srl = $module_info->module_srl;
 		$grant_info = $xml_info->grant;
-		if($member_info->member_srl)
+		if ($member_info->member_srl)
 		{
-			if(is_array($member_info->group_list)) $group_list = array_keys($member_info->group_list);
+			if (is_array($member_info->group_list)) $group_list = array_keys($member_info->group_list);
 			else $group_list = array();
 		}
 		else
@@ -2021,10 +2021,10 @@ 
 			$group_list = array();
 		}
 		// If module_srl doesn't exist(if unable to set permissions)
-		if(!$module_srl)
+		if (!$module_srl)
 		{
 			$grant->access = true;
-			if($this->isSiteAdmin($member_info, $module_info->site_srl))
+			if ($this->isSiteAdmin($member_info, $module_info->site_srl))
 			{
 				$grant->access = $grant->manager = $grant->is_site_admin = true;
 			}
@@ -2035,23 +2035,23 @@ 
 		{
 			// If module_srl exists
 			// Get a type of granted permission
-			$grant->access = $grant->manager = $grant->is_site_admin = ($member_info->is_admin=='Y'||$this->isSiteAdmin($member_info, $module_info->site_srl))?true:false;
+			$grant->access = $grant->manager = $grant->is_site_admin = ($member_info->is_admin == 'Y' || $this->isSiteAdmin($member_info, $module_info->site_srl)) ?true:false;
 			$grant->is_admin = ($member_info->is_admin == 'Y') ? true : false;
 			// If a just logged-in member is, check if the member is a module administrator
-			if(!$grant->manager && $member_info->member_srl)
+			if (!$grant->manager && $member_info->member_srl)
 			{
 				$args = new stdClass();
 				$args->module_srl = $module_srl;
 				$args->member_srl = $member_info->member_srl;
-				$output = executeQuery('module.getModuleAdmin',$args);
-				if($output->data && $output->data->member_srl == $member_info->member_srl) $grant->manager = true;
+				$output = executeQuery('module.getModuleAdmin', $args);
+				if ($output->data && $output->data->member_srl == $member_info->member_srl) $grant->manager = true;
 			}
 			// If not an administrator, get information from the DB and grant manager privilege.
-			if(!$grant->manager)
+			if (!$grant->manager)
 			{
 				$args = new stdClass();
 				// If planet, get permission settings from the planet home
-				if($module_info->module == 'planet')
+				if ($module_info->module == 'planet')
 				{
 					$output = executeQueryArray('module.getPlanetGrants', $args);
 				}
@@ -2064,42 +2064,42 @@ 
 
 				$grant_exists = $granted = array();
 
-				if($output->data)
+				if ($output->data)
 				{
 					// Arrange names and groups who has privileges
-					foreach($output->data as $val)
+					foreach ($output->data as $val)
 					{
 						$grant_exists[$val->name] = true;
-						if($granted[$val->name]) continue;
+						if ($granted[$val->name]) continue;
 						// Log-in member only
-						if($val->group_srl == -1)
+						if ($val->group_srl == -1)
 						{
 							$granted[$val->name] = true;
-							if($member_info->member_srl) $grant->{$val->name} = true;
+							if ($member_info->member_srl) $grant->{$val->name} = true;
 							// Site-joined member only
 						}
-						elseif($val->group_srl == -2)
+						elseif ($val->group_srl == -2)
 						{
 							$granted[$val->name] = true;
 							// Do not grant any permission for non-logged member
-							if(!$member_info->member_srl) $grant->{$val->name} = false;
+							if (!$member_info->member_srl) $grant->{$val->name} = false;
 							// Log-in member
 							else
 							{
 								$site_module_info = Context::get('site_module_info');
 								// Permission granted if no information of the currently connected site exists
-								if(!$site_module_info->site_srl) $grant->{$val->name} = true;
+								if (!$site_module_info->site_srl) $grant->{$val->name} = true;
 								// Permission is not granted if information of the currently connected site exists
-								elseif(count($group_list)) $grant->{$val->name} = true;
+								elseif (count($group_list)) $grant->{$val->name} = true;
 							}
 							// All of non-logged members
 						}
-						elseif($val->group_srl == -3)
+						elseif ($val->group_srl == -3)
 						{
 							$granted[$val->name] = true;
 							$grant->{$val->name} = ($grant->is_admin || $grant->is_site_admin);
 						}
-						elseif($val->group_srl == 0)
+						elseif ($val->group_srl == 0)
 						{
 							$granted[$val->name] = true;
 							$grant->{$val->name} = true;
@@ -2107,7 +2107,7 @@ 
 						}
 						else
 						{
-							if($group_list && count($group_list) && in_array($val->group_srl, $group_list))
+							if ($group_list && count($group_list) && in_array($val->group_srl, $group_list))
 							{
 								$grant->{$val->name} = true;
 								$granted[$val->name] = true;
@@ -2116,29 +2116,29 @@ 
 					}
 				}
 				// Separate processing for the virtual group access
-				if(!$grant_exists['access']) $grant->access = true;
-				if(count($grant_info))
+				if (!$grant_exists['access']) $grant->access = true;
+				if (count($grant_info))
 				{
-					foreach($grant_info as  $grant_name => $grant_item)
+					foreach ($grant_info as  $grant_name => $grant_item)
 					{
-						if($grant_exists[$grant_name]) continue;
-						switch($grant_item->default)
+						if ($grant_exists[$grant_name]) continue;
+						switch ($grant_item->default)
 						{
 							case 'guest' :
 								$grant->{$grant_name} = true;
 								break;
 							case 'member' :
-								if($member_info->member_srl) $grant->{$grant_name} = true;
+								if ($member_info->member_srl) $grant->{$grant_name} = true;
 								else $grant->{$grant_name} = false;
 								break;
 							case 'site' :
 								$site_module_info = Context::get('site_module_info');
-								if($member_info->member_srl && (($site_module_info->site_srl && count($group_list)) || !$site_module_info->site_srl)) $grant->{$grant_name} = true;
+								if ($member_info->member_srl && (($site_module_info->site_srl && count($group_list)) || !$site_module_info->site_srl)) $grant->{$grant_name} = true;
 								else $grant->{$grant_name} = false;
 								break;
 							case 'manager' :
 							case 'root' :
-								if($member_info->is_admin == 'Y') $grant->{$grant_name} = true;
+								if ($member_info->is_admin == 'Y') $grant->{$grant_name} = true;
 								else $grant->{$grant_name} = false;
 								break;
 						}
@@ -2146,12 +2146,12 @@ 
 				}
 			}
 			// Set true to grant all privileges if an administrator is
-			if($grant->manager)
+			if ($grant->manager)
 			{
 				$grant->access = true;
-				if(count($grant_info))
+				if (count($grant_info))
 				{
-					foreach($grant_info as $key => $val)
+					foreach ($grant_info as $key => $val)
 					{
 						$grant->{$key} = true;
 					}
@@ -2183,27 +2183,27 @@ 
 
 	function unserializeAttributes($module_filebox_list)
 	{
-		if(is_array($module_filebox_list->data))
+		if (is_array($module_filebox_list->data))
 		{
-			foreach($module_filebox_list->data as &$item)
+			foreach ($module_filebox_list->data as &$item)
 			{
-				if(empty($item->comment))
+				if (empty($item->comment))
 				{
 					continue;
 				}
 
 				$attributes = explode(';', $item->comment);
-				foreach($attributes as $attribute)
+				foreach ($attributes as $attribute)
 				{
 					$values = explode(':', $attribute);
-					if((count($values) % 2) ==1)
+					if ((count($values) % 2) == 1)
 					{
-						for($i=2;$i<count($values);$i++)
+						for ($i = 2; $i < count($values); $i++)
 						{
-							$values[1].=":".$values[$i];
+							$values[1] .= ":".$values[$i];
 						}
 					}
-					$atts[$values[0]]=$values[1];
+					$atts[$values[0]] = $values[1];
 				}
 				$item->attributes = $atts;
 				unset($atts);
@@ -2215,16 +2215,16 @@ 
 	function getFileBoxListHtml()
 	{
 		$logged_info = Context::get('logged_info');
-		if($logged_info->is_admin !='Y' && !$logged_info->is_site_admin) return new BaseObject(-1, 'msg_not_permitted');
+		if ($logged_info->is_admin != 'Y' && !$logged_info->is_site_admin) return new BaseObject(-1, 'msg_not_permitted');
 		$link = parse_url($_SERVER["HTTP_REFERER"]);
-		$link_params = explode('&',$link['query']);
+		$link_params = explode('&', $link['query']);
 		foreach ($link_params as $param)
 		{
-			$param = explode("=",$param);
-			if($param[0] == 'selected_widget') $selected_widget = $param[1];
+			$param = explode("=", $param);
+			if ($param[0] == 'selected_widget') $selected_widget = $param[1];
 		}
 		$oWidgetModel = getModel('widget');
-		if($selected_widget) $widget_info = $oWidgetModel->getWidgetInfo($selected_widget);
+		if ($selected_widget) $widget_info = $oWidgetModel->getWidgetInfo($selected_widget);
 		Context::set('allow_multiple', $widget_info->extra_var->images->allow_multiple);
 
 		$oModuleModel = getModel('module');
@@ -2240,24 +2240,24 @@ 
 		$security->encodeHTML('filebox_list..comment', 'filebox_list..attributes.');
 
 		$oTemplate = &TemplateHandler::getInstance();
-		$html = $oTemplate->compile(_XE_PATH_ . 'modules/module/tpl/', 'filebox_list_html');
+		$html = $oTemplate->compile(_XE_PATH_.'modules/module/tpl/', 'filebox_list_html');
 
 		$this->add('html', $html);
 	}
 
 	function getModuleFileBoxPath($module_filebox_srl)
 	{
-		return sprintf("./files/attach/filebox/%s",getNumberingPath($module_filebox_srl,3));
+		return sprintf("./files/attach/filebox/%s", getNumberingPath($module_filebox_srl, 3));
 	}
 
 	/**
 	 * @brief Return ruleset cache file path
 	 * @param module, act
 	 */
-	function getValidatorFilePath($module, $ruleset, $mid=null)
+	function getValidatorFilePath($module, $ruleset, $mid = null)
 	{
 		// load dynamic ruleset xml file
-		if(strpos($ruleset, '@') !== false)
+		if (strpos($ruleset, '@') !== false)
 		{
 			$rulsetFile = str_replace('@', '', $ruleset);
 			$xml_file = sprintf('./files/ruleset/%s.xml', $rulsetFile);
@@ -2267,20 +2267,20 @@ 
 		{
 			$rulsetFile = str_replace('#', '', $ruleset).'.'.$mid;
 			$xml_file = sprintf('./files/ruleset/%s.xml', $rulsetFile);
-			if(is_readable($xml_file))
+			if (is_readable($xml_file))
 				return FileHandler::getRealPath($xml_file);
-			else{
+			else {
 				$ruleset = str_replace('#', '', $ruleset);
 			}
 
 		}
 		// Get a path of the requested module. Return if not exists.
 		$class_path = ModuleHandler::getModulePath($module);
-		if(!$class_path) return;
+		if (!$class_path) return;
 
 		// Check if module.xml exists in the path. Return if not exist
 		$xml_file = sprintf("%sruleset/%s.xml", $class_path, $ruleset);
-		if(!file_exists($xml_file)) return;
+		if (!file_exists($xml_file)) return;
 
 		return $xml_file;
 	}
@@ -2292,7 +2292,7 @@ 
 		$requestVars = Context::getRequestVars();
 
 		$args = new stdClass;
-		$args->site_srl = (int)$requestVars->site_srl;
+		$args->site_srl = (int) $requestVars->site_srl;
 		$args->page = 1; // /< Page
 		$args->list_count = 100; // /< the number of posts to display on a single page
 		$args->page_count = 5; // /< the number of pages that appear in the page navigation
@@ -2304,9 +2304,9 @@ 
 
 		$list = array();
 
-		if($output->toBool())
+		if ($output->toBool())
 		{
-			foreach((array)$output->data as $code_info)
+			foreach ((array) $output->data as $code_info)
 			{
 				unset($codeInfo);
 				$codeInfo = array('name'=>'$user_lang->'.$code_info->name, 'value'=>$code_info->value);

Braces +470 added lines, -209 removed lines

@@ -19,26 +19,34 @@ 
 	 */
 	function isIDExists($id, $site_srl = 0)
 	{
-		if(!preg_match('/^[a-z]{1}([a-z0-9_]+)$/i',$id)) return true;
+		if(!preg_match('/^[a-z]{1}([a-z0-9_]+)$/i',$id)) {
+			return true;
+		}
 		// directory and rss/atom/api reserved checking, etc.
 		$dirs = FileHandler::readDir(_XE_PATH_);
 		$dirs[] = 'rss';
 		$dirs[] = 'atom';
 		$dirs[] = 'api';
-		if(in_array($id, $dirs)) return true;
+		if(in_array($id, $dirs)) {
+			return true;
+		}
 		// mid test
 		$args = new stdClass();
 		$args->mid = $id;
 		$args->site_srl = $site_srl;
 		$output = executeQuery('module.isExistsModuleName', $args);
-		if($output->data->count) return true;
+		if($output->data->count) {
+			return true;
+		}
 		// vid test (check mid != vid if site_srl=0, which means it is not a virtual site)
 		if(!$site_srl)
 		{
 			$site_args = new stdClass();
 			$site_args->domain = $id;
 			$output = executeQuery('module.isExistsSiteDomain', $site_args);
-			if($output->data->count) return true;
+			if($output->data->count) {
+				return true;
+			}
 		}
 
 		return false;
@@ -82,10 +90,14 @@ 
 	function getDefaultMid()
 	{
 		$default_url = Context::getDefaultUrl();
-		if($default_url && substr_compare($default_url, '/', -1) === 0) $default_url = substr($default_url, 0, -1);
+		if($default_url && substr_compare($default_url, '/', -1) === 0) {
+			$default_url = substr($default_url, 0, -1);
+		}
 
 		$request_url = Context::getRequestUri();
-		if($request_url && substr_compare($request_url, '/', -1) === 0) $request_url = substr($request_url, 0, -1);
+		if($request_url && substr_compare($request_url, '/', -1) === 0) {
+			$request_url = substr($request_url, 0, -1);
+		}
 
 		$default_url_parse = parse_url($default_url);
 		$request_url_parse = parse_url($request_url);
@@ -100,14 +112,18 @@ 
 			$hostname = $request_url_parse['host'];
 			$path = $request_url_parse['path'];
 			$port = $request_url_parse['port'];
-			if(strlen($path) >= 1 && substr_compare($path, '/', -1) === 0) $path = substr($path, 0, -1);
+			if(strlen($path) >= 1 && substr_compare($path, '/', -1) === 0) {
+				$path = substr($path, 0, -1);
+			}
 
 			$domain = sprintf('%s%s%s', $hostname, $port && ($port != 80 )? ':'.$port  : '', $path);
 		}
 
 		if($domain === '')
 		{
-			if(!$vid) $vid = $mid;
+			if(!$vid) {
+				$vid = $mid;
+			}
 			if($vid)
 			{
 				$domain = $vid;
@@ -133,13 +149,17 @@ 
 				$output = executeQuery('module.getSiteInfoByDomain', $args);
 				$site_info = $output->data;
 
-				if($oCacheHandler->isSupport()) $oCacheHandler->put($domain_cache_key, $site_info);
+				if($oCacheHandler->isSupport()) {
+					$oCacheHandler->put($domain_cache_key, $site_info);
+				}
 			}
 
 			if($site_info && $vid)
 			{
 				Context::set('vid', $site_info->domain, true);
-				if(strtolower($mid)==strtolower($site_info->domain)) Context::set('mid', $site_info->mid,true);
+				if(strtolower($mid)==strtolower($site_info->domain)) {
+					Context::set('mid', $site_info->mid,true);
+				}
 			}
 			if(!$site_info || !$site_info->domain) { $domain = ''; unset($site_info); }
 		}
@@ -165,8 +185,12 @@ 
 				{
 					// Create a table if sites table doesn't exist
 					$oDB = &DB::getInstance();
-					if(!$oDB->isTableExists('sites')) $oDB->createTableByXmlFile(_XE_PATH_.'modules/module/schemas/sites.xml');
-					if(!$oDB->isTableExists('sites')) return;
+					if(!$oDB->isTableExists('sites')) {
+						$oDB->createTableByXmlFile(_XE_PATH_.'modules/module/schemas/sites.xml');
+					}
+					if(!$oDB->isTableExists('sites')) {
+						return;
+					}
 
 					// Get mid, language
 					$mid_output = $oDB->executeQuery('module.getDefaultMidInfo', $args);
@@ -184,21 +208,28 @@ 
 					if($output->data && !$output->data->index_module_srl)
 					{
 						$output = executeQuery('module.updateSite', $site_args);
-					}
-					else
+					} else
 					{
 						$output = executeQuery('module.insertSite', $site_args);
-						if(!$output->toBool()) return $output;
+						if(!$output->toBool()) {
+							return $output;
+						}
 					}
 					$output = executeQuery('module.getSiteInfo', $args);
 				}
 				$site_info = $output->data;
-				if($oCacheHandler->isSupport()) $oCacheHandler->put($default_site_cache_key, $site_info);
+				if($oCacheHandler->isSupport()) {
+					$oCacheHandler->put($default_site_cache_key, $site_info);
+				}
 			}
 		}
 
-		if(!$site_info->module_srl) return $site_info;
-		if(is_array($site_info) && $site_info->data[0]) $site_info = $site_info[0];
+		if(!$site_info->module_srl) {
+			return $site_info;
+		}
+		if(is_array($site_info) && $site_info->data[0]) {
+			$site_info = $site_info[0];
+		}
 		return $this->addModuleExtraVars($site_info);
 	}
 
@@ -248,7 +279,9 @@ 
 		}
 
 		$this->applyDefaultSkin($module_info);
-		if(!$module_info->module_srl && $module_info->data[0]) $module_info = $module_info->data[0];
+		if(!$module_info->module_srl && $module_info->data[0]) {
+			$module_info = $module_info->data[0];
+		}
 		return $this->addModuleExtraVars($module_info);
 	}
 
@@ -340,8 +373,7 @@ 
 				$object_key = 'mid_info:' . $output->data->module_srl;
 				$module_info_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
 				$oCacheHandler->put($module_info_cache_key, $moduleInfo);
-			}
-			else
+			} else
 			{
 				$mid_info->designSettings = $moduleInfo->designSettings;
 				$moduleInfo = $mid_info;
@@ -382,11 +414,15 @@ 
 			$args = new stdClass();
 			$args->module_srl = $module_srl;
 			$output = executeQuery('module.getMidInfo', $args);
-			if(!$output->toBool()) return;
+			if(!$output->toBool()) {
+				return;
+			}
 
 			$mid_info = $output->data;
 			$this->applyDefaultSkin($mid_info);
-			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $mid_info);
+			if($oCacheHandler->isSupport()) {
+				$oCacheHandler->put($cache_key, $mid_info);
+			}
 		}
 
 		if($mid_info && count($columnList))
@@ -399,11 +435,14 @@ 
 					$module_info->$key = $item;
 				}
 			}
+		} else {
+			$module_info = $mid_info;
 		}
-		else $module_info = $mid_info;
 
 		$oModuleController = getController('module');
-		if(isset($module_info->browser_title)) $oModuleController->replaceDefinedLangCode($module_info->browser_title);
+		if(isset($module_info->browser_title)) {
+			$oModuleController->replaceDefinedLangCode($module_info->browser_title);
+		}
 
 		$this->applyDefaultSkin($module_info);
 		return $this->addModuleExtraVars($module_info);
@@ -451,11 +490,15 @@ 
 	 */
 	function getModulesInfo($module_srls, $columnList = array())
 	{
-		if(is_array($module_srls)) $module_srls = implode(',',$module_srls);
+		if(is_array($module_srls)) {
+			$module_srls = implode(',',$module_srls);
+		}
 		$args = new stdClass();
 		$args->module_srls = $module_srls;
 		$output = executeQueryArray('module.getModulesInfo', $args, $columnList);
-		if(!$output->toBool()) return;
+		if(!$output->toBool()) {
+			return;
+		}
 		return $this->addModuleExtraVars($output->data);
 	}
 
@@ -465,31 +508,44 @@ 
 	function addModuleExtraVars($module_info)
 	{
 		// Process although one or more module informaion is requested
-		if(!is_array($module_info)) $target_module_info = array($module_info);
-		else $target_module_info = $module_info;
+		if(!is_array($module_info)) {
+			$target_module_info = array($module_info);
+		} else {
+			$target_module_info = $module_info;
+		}
 		// Get module_srl
 		$module_srls = array();
 		foreach($target_module_info as $key => $val)
 		{
 			$module_srl = $val->module_srl;
-			if(!$module_srl) continue;
+			if(!$module_srl) {
+				continue;
+			}
 			$module_srls[] = $val->module_srl;
 		}
 		// Extract extra information of the module and skin
 		$extra_vars = $this->getModuleExtraVars($module_srls);
-		if(!count($module_srls) || !count($extra_vars)) return $module_info;
+		if(!count($module_srls) || !count($extra_vars)) {
+			return $module_info;
+		}
 
 		foreach($target_module_info as $key => $val)
 		{
-			if(!$extra_vars[$val->module_srl] || !count($extra_vars[$val->module_srl])) continue;
+			if(!$extra_vars[$val->module_srl] || !count($extra_vars[$val->module_srl])) {
+				continue;
+			}
 			foreach($extra_vars[$val->module_srl] as $k => $v)
 			{
-				if($target_module_info[$key]->{$k}) continue;
+				if($target_module_info[$key]->{$k}) {
+					continue;
+				}
 				$target_module_info[$key]->{$k} = $v;
 			}
 		}
 
-		if(is_array($module_info)) return $target_module_info;
+		if(is_array($module_info)) {
+			return $target_module_info;
+		}
 		return $target_module_info[0];
 	}
 
@@ -518,7 +574,9 @@ 
 			}
 
 			$output = executeQuery('module.getMidList', $args, $columnList);
-			if(!$output->toBool()) return $output;
+			if(!$output->toBool()) {
+				return $output;
+			}
 			$list = $output->data;
 
 			if($oCacheHandler->isSupport() && count($args) === 1 && isset($args->site_srl))
@@ -526,9 +584,13 @@ 
 				$oCacheHandler->put($cache_key, $list);
 			}
 		}
-		if(!$list) return;
+		if(!$list) {
+			return;
+		}
 
-		if(!is_array($list)) $list = array($list);
+		if(!is_array($list)) {
+			$list = array($list);
+		}
 
 		foreach($list as $val)
 		{
@@ -544,10 +606,14 @@ 
 	function getModuleSrlList($args = null, $columnList = array())
 	{
 		$output = executeQueryArray('module.getMidList', $args, $columnList);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		$list = $output->data;
-		if(!$list) return;
+		if(!$list) {
+			return;
+		}
 
 		return $list;
 	}
@@ -557,20 +623,32 @@ 
 	 */
 	function getModuleSrlByMid($mid)
 	{
-		if($mid && !is_array($mid)) $mid = explode(',',$mid);
-		if(is_array($mid)) $mid = "'".implode("','",$mid)."'";
+		if($mid && !is_array($mid)) {
+			$mid = explode(',',$mid);
+		}
+		if(is_array($mid)) {
+			$mid = "'".implode("','",$mid)."'";
+		}
 
 		$site_module_info = Context::get('site_module_info');
 
 		$args = new stdClass;
 		$args->mid = $mid;
-		if($site_module_info) $args->site_srl = $site_module_info->site_srl;
+		if($site_module_info) {
+			$args->site_srl = $site_module_info->site_srl;
+		}
 		$output = executeQuery('module.getModuleSrlByMid', $args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		$list = $output->data;
-		if(!$list) return;
-		if(!is_array($list)) $list = array($list);
+		if(!$list) {
+			return;
+		}
+		if(!is_array($list)) {
+			$list = array($list);
+		}
 
 		foreach($list as $key => $val)
 		{
@@ -599,8 +677,12 @@ 
 		{
 			$args = new stdClass();
 			$output = executeQueryArray('module.getActionForward',$args);
-			if(!$output->toBool()) return new stdClass;
-			if(!$output->data) $output->data = array();
+			if(!$output->toBool()) {
+				return new stdClass;
+			}
+			if(!$output->data) {
+				$output->data = array();
+			}
 
 			$action_forward = array();
 			foreach($output->data as $item)
@@ -617,8 +699,7 @@ 
 		if($action_forward[$act])
 		{
 			return $action_forward[$act];
-		}
-		else
+		} else
 		{
 			return new stdClass();
 		}
@@ -726,8 +807,7 @@ 
 			if(file_exists($cache_file))
 			{
 				$GLOBALS['__MODULE_EXTEND__'] = include($cache_file);
-			}
-			else
+			} else
 			{
 				$GLOBALS['__MODULE_EXTEND__'] = array();
 			}
@@ -743,16 +823,22 @@ 
 	{
 		// Get a path of the requested module. Return if not exists.
 		$module_path = ModuleHandler::getModulePath($module);
-		if(!$module_path) return;
+		if(!$module_path) {
+			return;
+		}
 		// Read the xml file for module skin information
 		$xml_file = sprintf("%s/conf/info.xml", $module_path);
-		if(!file_exists($xml_file)) return;
+		if(!file_exists($xml_file)) {
+			return;
+		}
 
 		$oXmlParser = new XmlParser();
 		$tmp_xml_obj = $oXmlParser->loadXmlFile($xml_file);
 		$xml_obj = $tmp_xml_obj->module;
 
-		if(!$xml_obj) return;
+		if(!$xml_obj) {
+			return;
+		}
 
 		// Module Information
 		$module_info = new stdClass();
@@ -764,14 +850,19 @@ 
 			$module_info->version = $xml_obj->version->body;
 			$module_info->homepage = $xml_obj->link->body;
 			$module_info->category = $xml_obj->category->body;
-			if(!$module_info->category) $module_info->category = 'service';
+			if(!$module_info->category) {
+				$module_info->category = 'service';
+			}
 			sscanf($xml_obj->date->body, '%d-%d-%d', $date_obj->y, $date_obj->m, $date_obj->d);
 			$module_info->date = sprintf('%04d%02d%02d', $date_obj->y, $date_obj->m, $date_obj->d);
 			$module_info->license = $xml_obj->license->body;
 			$module_info->license_link = $xml_obj->license->attrs->link;
 
-			if(!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;
-			else $author_list = $xml_obj->author;
+			if(!is_array($xml_obj->author)) {
+				$author_list[] = $xml_obj->author;
+			} else {
+				$author_list = $xml_obj->author;
+			}
 
 			foreach($author_list as $author)
 			{
@@ -781,15 +872,16 @@ 
 				$author_obj->homepage = $author->attrs->link;
 				$module_info->author[] = $author_obj;
 			}
-		}
-		else
+		} else
 		{
 			// module format 0.1
 			$module_info->title = $xml_obj->title->body;
 			$module_info->description = $xml_obj->author->description->body;
 			$module_info->version = $xml_obj->attrs->version;
 			$module_info->category = $xml_obj->attrs->category;
-			if(!$module_info->category) $module_info->category = 'service';
+			if(!$module_info->category) {
+				$module_info->category = 'service';
+			}
 			sscanf($xml_obj->author->attrs->date, '%d. %d. %d', $date_obj->y, $date_obj->m, $date_obj->d);
 			$module_info->date = sprintf('%04d%02d%02d', $date_obj->y, $date_obj->m, $date_obj->d);
 			$author_obj = new stdClass();
@@ -818,11 +910,15 @@ 
 	{
 		// Get a path of the requested module. Return if not exists.
 		$class_path = ModuleHandler::getModulePath($module);
-		if(!$class_path) return;
+		if(!$class_path) {
+			return;
+		}
 
 		// Check if module.xml exists in the path. Return if not exist
 		$xml_file = sprintf("%sconf/module.xml", $class_path);
-		if(!file_exists($xml_file)) return;
+		if(!file_exists($xml_file)) {
+			return;
+		}
 
 		// Check if cached file exists
 		$cache_file = sprintf(_XE_PATH_ . "files/cache/module_info/%s.%s.%s.php", $module, Context::getLangType(), __XE_VERSION__);
@@ -841,7 +937,10 @@ 
 
 			$xml_obj = XmlParser::loadXmlFile($xml_file); // /< Read xml file and convert it to xml object
 
-			if(!count($xml_obj->module)) return; // /< Error occurs if module tag doesn't included in the xml
+			if(!count($xml_obj->module)) {
+				return;
+			}
+			// /< Error occurs if module tag doesn't included in the xml
 
 			$grants = $xml_obj->module->grants->grant; // /< Permission information
 			$permissions = $xml_obj->module->permissions->permission; // /<  Acting permission
@@ -853,8 +952,11 @@ 
 			// Arrange permission information
 			if($grants)
 			{
-				if(is_array($grants)) $grant_list = $grants;
-				else $grant_list[] = $grants;
+				if(is_array($grants)) {
+					$grant_list = $grants;
+				} else {
+					$grant_list[] = $grants;
+				}
 
 				$info->grant = new stdClass();
 				$buff[] = '$info->grant = new stdClass;';
@@ -876,8 +978,11 @@ 
 			// Permissions to grant
 			if($permissions)
 			{
-				if(is_array($permissions)) $permission_list = $permissions;
-				else $permission_list[] = $permissions;
+				if(is_array($permissions)) {
+					$permission_list = $permissions;
+				} else {
+					$permission_list[] = $permissions;
+				}
 
 				$buff[] = '$info->permission = new stdClass;';
 
@@ -895,8 +1000,11 @@ 
 			// for admin menus
 			if($menus)
 			{
-				if(is_array($menus)) $menu_list = $menus;
-				else $menu_list[] = $menus;
+				if(is_array($menus)) {
+					$menu_list = $menus;
+				} else {
+					$menu_list[] = $menus;
+				}
 
 				$buff[] = '$info->menu = new stdClass;';
 				$info->menu = new stdClass();
@@ -920,8 +1028,11 @@ 
 			// actions
 			if($actions)
 			{
-				if(is_array($actions)) $action_list = $actions;
-				else $action_list[] = $actions;
+				if(is_array($actions)) {
+					$action_list = $actions;
+				} else {
+					$action_list[] = $actions;
+				}
 
 				$buff[] = '$info->action = new stdClass;';
 				$info->action = new stdClass();
@@ -1010,7 +1121,9 @@ 
 			return $info;
 		}
 
-		if(file_exists($cache_file)) return include($cache_file);
+		if(file_exists($cache_file)) {
+			return include($cache_file);
+		}
 	}
 
 	/**
@@ -1048,7 +1161,9 @@ 
 
 		$skin_path = sprintf("%s/%s/", $path, $dir);
 		$list = FileHandler::readDir($skin_path);
-		if(!count($list)) return;
+		if(!count($list)) {
+			return;
+		}
 
 		natcasesort($list);
 
@@ -1102,8 +1217,7 @@ 
 			if($dir == 'skins')
 			{
 				$type = 'P';
-			}
-			else
+			} else
 			{
 				$type = 'M';
 			}
@@ -1131,14 +1245,20 @@ 
 	function loadSkinInfo($path, $skin, $dir = 'skins')
 	{
 		// Read xml file having skin information
-		if(substr($path,-1)!='/') $path .= '/';
+		if(substr($path,-1)!='/') {
+			$path .= '/';
+		}
 		$skin_xml_file = sprintf("%s%s/%s/skin.xml", $path, $dir, $skin);
-		if(!file_exists($skin_xml_file)) return;
+		if(!file_exists($skin_xml_file)) {
+			return;
+		}
 		// Create XmlParser object
 		$oXmlParser = new XmlParser();
 		$_xml_obj = $oXmlParser->loadXmlFile($skin_xml_file);
 		// Return if no skin information is
-		if(!$_xml_obj->skin) return;
+		if(!$_xml_obj->skin) {
+			return;
+		}
 		$xml_obj = $_xml_obj->skin;
 		// Skin Name
 		$skin_info = new stdClass();
@@ -1155,8 +1275,11 @@ 
 			$skin_info->license_link = $xml_obj->license->attrs->link;
 			$skin_info->description = $xml_obj->description->body;
 
-			if(!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;
-			else $author_list = $xml_obj->author;
+			if(!is_array($xml_obj->author)) {
+				$author_list[] = $xml_obj->author;
+			} else {
+				$author_list = $xml_obj->author;
+			}
 
 			foreach($author_list as $author)
 			{
@@ -1170,8 +1293,12 @@ 
 			if($xml_obj->extra_vars)
 			{
 				$extra_var_groups = $xml_obj->extra_vars->group;
-				if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
-				if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
+				if(!$extra_var_groups) {
+					$extra_var_groups = $xml_obj->extra_vars;
+				}
+				if(!is_array($extra_var_groups)) {
+					$extra_var_groups = array($extra_var_groups);
+				}
 
 				foreach($extra_var_groups as $group)
 				{
@@ -1180,7 +1307,9 @@ 
 					{
 						continue;
 					}
-					if(!is_array($group->var)) $extra_vars = array($group->var);
+					if(!is_array($group->var)) {
+						$extra_vars = array($group->var);
+					}
 
 					foreach($extra_vars as $key => $val)
 					{
@@ -1207,8 +1336,7 @@ 
 								$obj->options[$i]->title = $val->options[$i]->title->body;
 								$obj->options[$i]->value = $val->options[$i]->attrs->value;
 							}
-						}
-						else
+						} else
 						{
 							$obj->options[0] = new stdClass();
 							$obj->options[0]->title = $val->options->title->body;
@@ -1219,8 +1347,7 @@ 
 					}
 				}
 			}
-		}
-		else
+		} else
 		{
 			// skin format v0.1
 			sscanf($xml_obj->maker->attrs->date, '%d-%d-%d', $date_obj->y, $date_obj->m, $date_obj->d);
@@ -1238,8 +1365,12 @@ 
 			$skin_info->author[0]->homepage = $xml_obj->maker->attrs->link;
 			// Variables used in the skin
 			$extra_var_groups = $xml_obj->extra_vars->group;
-			if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
-			if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
+			if(!$extra_var_groups) {
+				$extra_var_groups = $xml_obj->extra_vars;
+			}
+			if(!is_array($extra_var_groups)) {
+				$extra_var_groups = array($extra_var_groups);
+			}
 
 			foreach($extra_var_groups as $group)
 			{
@@ -1247,7 +1378,9 @@ 
 
 				if($extra_vars)
 				{
-					if(!is_array($extra_vars)) $extra_vars = array($extra_vars);
+					if(!is_array($extra_vars)) {
+						$extra_vars = array($extra_vars);
+					}
 
 					foreach($extra_vars as $var)
 					{
@@ -1269,8 +1402,7 @@ 
 								$options[$i]->title = $var->default[$i]->body;
 								$options[$i]->value = $var->default[$i]->body;
 							}
-						}
-						else
+						} else
 						{
 							$options[0]->title = $var->default->body;
 							$options[0]->value = $var->default->body;
@@ -1300,7 +1432,9 @@ 
 		$colorset = $xml_obj->colorset->color;
 		if($colorset)
 		{
-			if(!is_array($colorset)) $colorset = array($colorset);
+			if(!is_array($colorset)) {
+				$colorset = array($colorset);
+			}
 
 			foreach($colorset as $color)
 			{
@@ -1310,9 +1444,12 @@ 
 				if($screenshot)
 				{
 					$screenshot = sprintf("%s%s/%s/%s", $path, $dir, $skin, $screenshot);
-					if(!file_exists($screenshot)) $screenshot = "";
+					if(!file_exists($screenshot)) {
+						$screenshot = "";
+					}
+				} else {
+					$screenshot = "";
 				}
-				else $screenshot = "";
 
 				$obj = new stdClass();
 				$obj->name = $name;
@@ -1325,7 +1462,9 @@ 
 		if($xml_obj->menus->menu)
 		{
 			$menus = $xml_obj->menus->menu;
-			if(!is_array($menus)) $menus = array($menus);
+			if(!is_array($menus)) {
+				$menus = array($menus);
+			}
 
 			$menu_count = count($menus);
 			$skin_info->menu_count = $menu_count;
@@ -1334,7 +1473,9 @@ 
 				unset($obj);
 
 				$obj->name = $menus[$i]->attrs->name;
-				if($menus[$i]->attrs->default == "true") $obj->default = true;
+				if($menus[$i]->attrs->default == "true") {
+					$obj->default = true;
+				}
 				$obj->title = $menus[$i]->title->body;
 				$obj->maxdepth = $menus[$i]->maxdepth->body;
 
@@ -1354,7 +1495,9 @@ 
 	{
 		$args = new stdClass;
 		$args->site_srl = $site_srl;
-		if(!is_null($module)) $args->module = $module;
+		if(!is_null($module)) {
+			$args->module = $module;
+		}
 		$output = executeQuery('module.getModuleCount', $args);
 		return $output->data->count;
 	}
@@ -1383,8 +1526,11 @@ 
 				$args->module = $module;
 				$args->site_srl = $site_srl;
 				$output = executeQuery('module.getModuleConfig', $args);
-				if($output->data->config) $config = unserialize($output->data->config);
-				else $config = null;
+				if($output->data->config) {
+					$config = unserialize($output->data->config);
+				} else {
+					$config = null;
+				}
 
 				//insert in cache
 				if($oCacheHandler->isSupport())
@@ -1423,8 +1569,11 @@ 
 				$args->module = $module;
 				$args->module_srl = $module_srl;
 				$output = executeQuery('module.getModulePartConfig', $args);
-				if($output->data->config) $config = unserialize($output->data->config);
-				else $config = null;
+				if($output->data->config) {
+					$config = unserialize($output->data->config);
+				} else {
+					$config = null;
+				}
 
 				//insert in cache
 				if($oCacheHandler->isSupport())
@@ -1446,9 +1595,13 @@ 
 	{
 		$args = new stdClass();
 		$args->module = $module;
-		if($site_srl) $args->site_srl = $site_srl;
+		if($site_srl) {
+			$args->site_srl = $site_srl;
+		}
 		$output = executeQueryArray('module.getModulePartConfigs', $args);
-		if(!$output->toBool() || !$output->data) return array();
+		if(!$output->toBool() || !$output->data) {
+			return array();
+		}
 
 		foreach($output->data as $key => $val)
 		{
@@ -1466,10 +1619,16 @@ 
 		$args->moduleCategorySrl = $moduleCategorySrl;
 		// Get data from the DB
 		$output = executeQuery('module.getModuleCategories', $args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 		$list = $output->data;
-		if(!$list) return;
-		if(!is_array($list)) $list = array($list);
+		if(!$list) {
+			return;
+		}
+		if(!is_array($list)) {
+			$list = array($list);
+		}
 
 		foreach($list as $val)
 		{
@@ -1487,7 +1646,9 @@ 
 		$args = new stdClass;
 		$args->module_category_srl = $module_category_srl;
 		$output = executeQuery('module.getModuleCategory', $args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 		return $output->data;
 	}
 
@@ -1499,7 +1660,9 @@ 
 		// Get a list of downloaded and installed modules
 		$searched_list = FileHandler::readDir('./modules');
 		$searched_count = count($searched_list);
-		if(!$searched_count) return;
+		if(!$searched_count) {
+			return;
+		}
 		sort($searched_list);
 
 		for($i=0;$i<$searched_count;$i++)
@@ -1512,7 +1675,9 @@ 
 			$info = $this->getModuleInfoXml($module_name);
 			unset($obj);
 
-			if(!isset($info)) continue;
+			if(!isset($info)) {
+				continue;
+			}
 			$info->module = $module_name;
 			$info->created_table_count = $created_table_count;
 			$info->table_count = $table_count;
@@ -1538,11 +1703,16 @@ 
 			for($j=0;$j<count($tmp_files);$j++)
 			{
 				list($table_name) = explode(".",$tmp_files[$j]);
-				if($oDB->isTableExists($table_name)) $created_table_count ++;
+				if($oDB->isTableExists($table_name)) {
+					$created_table_count ++;
+				}
 			}
 			// Check if DB is installed
-			if($table_count > $created_table_count) return true;
-			else return false;
+			if($table_count > $created_table_count) {
+				return true;
+			} else {
+				return false;
+			}
 		}
 		return false;
 	}
@@ -1565,15 +1735,23 @@ 
 	 */
 	public function needUpdate($update_id)
 	{
-		if(!is_array($update_id)) $update_id = array($update_id);
+		if(!is_array($update_id)) {
+			$update_id = array($update_id);
+		}
 
 		$args = new stdClass();
 		$args->update_id = implode(',', $update_id);
 		$output = executeQueryArray('module.getModuleUpdateLog', $args);
 
-		if(!!$output->error) return false;
-		if(!$output->data) $output->data = array();
-		if(count($update_id) === count($output->data)) return false;
+		if(!!$output->error) {
+			return false;
+		}
+		if(!$output->data) {
+			$output->data = array();
+		}
+		if(count($update_id) === count($output->data)) {
+			return false;
+		}
 
 		return true;
 	}
@@ -1590,7 +1768,9 @@ 
 		sort($searched_list);
 
 		$searched_count = count($searched_list);
-		if(!$searched_count) return;
+		if(!$searched_count) {
+			return;
+		}
 
 		for($i=0;$i<$searched_count;$i++)
 		{
@@ -1598,7 +1778,9 @@ 
 			$module_name = $searched_list[$i];
 
 			$path = ModuleHandler::getModulePath($module_name);
-			if(!is_dir(FileHandler::getRealPath($path))) continue;
+			if(!is_dir(FileHandler::getRealPath($path))) {
+				continue;
+			}
 
 			// Get the number of xml files to create a table in schemas
 			$tmp_files = FileHandler::readDir($path.'schemas', '/(\.xml)$/');
@@ -1608,13 +1790,17 @@ 
 			for($j=0;$j<$table_count;$j++)
 			{
 				list($table_name) = explode('.',$tmp_files[$j]);
-				if($oDB->isTableExists($table_name)) $created_table_count ++;
+				if($oDB->isTableExists($table_name)) {
+					$created_table_count ++;
+				}
 			}
 			// Get information of the module
 			$info = NULL;
 			$info = $this->getModuleInfoXml($module_name);
 
-			if(!$info) continue;
+			if(!$info) {
+				continue;
+			}
 
 			$info->module = $module_name;
 			$info->category = $info->category;
@@ -1623,16 +1809,18 @@ 
 			$info->path = $path;
 			$info->admin_index_act = $info->admin_index_act;
 			// Check if DB is installed
-			if($table_count > $created_table_count) $info->need_install = true;
-			else $info->need_install = false;
+			if($table_count > $created_table_count) {
+				$info->need_install = true;
+			} else {
+				$info->need_install = false;
+			}
 			// Check if it is upgraded to module.class.php on each module
 			$oDummy = null;
 			$oDummy = getModule($module_name, 'class');
 			if($oDummy && method_exists($oDummy, "checkUpdate"))
 			{
 				$info->need_update = $oDummy->checkUpdate();
-			}
-			else
+			} else
 			{
 				continue;
 			}
@@ -1649,7 +1837,9 @@ 
 	 */
 	function syncModuleToSite(&$data)
 	{
-		if(!$data) return;
+		if(!$data) {
+			return;
+		}
 
 		if(is_array($data))
 		{
@@ -1657,9 +1847,10 @@ 
 			{
 				$module_srls[] = $val->module_srl;
 			}
-			if(!count($module_srls)) return;
-		}
-		else
+			if(!count($module_srls)) {
+				return;
+			}
+		} else
 		{
 			$module_srls[] = $data->module_srl;
 		}
@@ -1667,7 +1858,9 @@ 
 		$args = new stdClass();
 		$args->module_srls = implode(',',$module_srls);
 		$output = executeQueryArray('module.getModuleSites', $args);
-		if(!$output->data) return array();
+		if(!$output->data) {
+			return array();
+		}
 		foreach($output->data as $key => $val)
 		{
 			$modules[$val->module_srl] = $val;
@@ -1679,8 +1872,7 @@ 
 			{
 				$data[$key]->domain = $modules[$val->module_srl]->domain;
 			}
-		}
-		else
+		} else
 		{
 			$data->domain = $modules[$data->module_srl]->domain;
 		}
@@ -1691,24 +1883,31 @@ 
 	 */
 	function isSiteAdmin($member_info, $site_srl = null)
 	{
-		if(!$member_info->member_srl) return false;
-		if($member_info->is_admin == 'Y') return true;
+		if(!$member_info->member_srl) {
+			return false;
+		}
+		if($member_info->is_admin == 'Y') {
+			return true;
+		}
 
 		$args = new stdClass();
 		if(!isset($site_srl))
 		{
 			$site_module_info = Context::get('site_module_info');
-			if(!$site_module_info) return;
+			if(!$site_module_info) {
+				return;
+			}
 			$args->site_srl = $site_module_info->site_srl;
-		}
-		else
+		} else
 		{
 			$args->site_srl = $site_srl;
 		}
 
 		$args->member_srl = $member_info->member_srl;
 		$output = executeQuery('module.isSiteAdmin', $args);
-		if($output->data->member_srl == $args->member_srl) return true;
+		if($output->data->member_srl == $args->member_srl) {
+			return true;
+		}
 		return false;
 	}
 
@@ -1731,7 +1930,9 @@ 
 		$obj = new stdClass();
 		$obj->module_srl = $module_srl;
 		$output = executeQueryArray('module.getAdminID', $obj);
-		if(!$output->toBool() || !$output->data) return;
+		if(!$output->toBool() || !$output->data) {
+			return;
+		}
 
 		return $output->data;
 	}
@@ -1744,7 +1945,9 @@ 
 	{
 		$extra_vars = array();
 		$get_module_srls = array();
-		if(!is_array($list_module_srl)) $list_module_srl = array($list_module_srl);
+		if(!is_array($list_module_srl)) {
+			$list_module_srl = array($list_module_srl);
+		}
 
 		$vars = false;
 		// cache controll
@@ -1760,14 +1963,12 @@ 
 				if($vars)
 				{
 					$extra_vars[$module_srl] = $vars;
-				}
-				else
+				} else
 				{
 					$get_module_srls[] = $module_srl;
 				}
 			}
-		}
-		else
+		} else
 		{
 			$get_module_srls = $list_module_srl;
 		}
@@ -1792,7 +1993,9 @@ 
 			}
 			foreach($output->data as $key => $val)
 			{
-				if(in_array($val->name, array('mid','module')) || $val->value == 'Array') continue;
+				if(in_array($val->name, array('mid','module')) || $val->value == 'Array') {
+					continue;
+				}
 
 				if(!isset($extra_vars[$val->module_srl]))
 				{
@@ -1831,7 +2034,9 @@ 
 			$args = new stdClass();
 			$args->module_srl = $module_srl;
 			$output = executeQueryArray('module.getModuleSkinVars',$args);
-			if(!$output->toBool()) return;
+			if(!$output->toBool()) {
+				return;
+			}
 
 			$skin_vars = array();
 			foreach($output->data as $vars)
@@ -1839,7 +2044,9 @@ 
 				$skin_vars[$vars->name] = $vars;
 			}
 
-			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);
+			if($oCacheHandler->isSupport()) {
+				$oCacheHandler->put($cache_key, $skin_vars);
+			}
 		}
 
 		return $skin_vars;
@@ -1851,7 +2058,9 @@ 
 	function getModuleDefaultSkin($module_name, $skin_type = 'P', $site_srl = 0, $updateCache = true)
 	{
 		$target = ($skin_type == 'M') ? 'mskin' : 'skin';
-		if(!$site_srl) $site_srl = 0;
+		if(!$site_srl) {
+			$site_srl = 0;
+		}
 
 		$designInfoFile = sprintf(_XE_PATH_.'files/site_design/design_%s.php', $site_srl);
 		if(is_readable($designInfoFile))
@@ -1868,19 +2077,16 @@ 
 			if(is_dir($moduleSkinPath.'default'))
 			{
 				$skinName = 'default';
-			}
-			else if(is_dir($moduleSkinPath.'xe_default'))
+			} else if(is_dir($moduleSkinPath.'xe_default'))
 			{
 				$skinName = 'xe_default';
-			}
-			else
+			} else
 			{
 				$skins = FileHandler::readDir($moduleSkinPath);
 				if(count($skins) > 0)
 				{
 					$skinName = $skins[0];
-				}
-				else
+				} else
 				{
 					$skinName = NULL;
 				}
@@ -1888,7 +2094,9 @@ 
 
 			if($updateCache && $skinName)
 			{
-				if(!isset($designInfo->module->{$module_name})) $designInfo->module->{$module_name} = new stdClass();
+				if(!isset($designInfo->module->{$module_name})) {
+					$designInfo->module->{$module_name} = new stdClass();
+				}
 				$designInfo->module->{$module_name}->{$target} = $skinName;
 
 				$oAdminController = getAdminController('admin');
@@ -1904,23 +2112,28 @@ 
 	 */
 	function syncSkinInfoToModuleInfo(&$module_info)
 	{
-		if(!$module_info->module_srl) return;
+		if(!$module_info->module_srl) {
+			return;
+		}
 
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
 		if(Mobile::isFromMobilePhone())
 		{
 			$skin_vars = $this->getModuleMobileSkinVars($module_info->module_srl);
-		}
-		else
+		} else
 		{
 			$skin_vars = $this->getModuleSkinVars($module_info->module_srl);
 		}
 
-		if(!$skin_vars) return;
+		if(!$skin_vars) {
+			return;
+		}
 
 		foreach($skin_vars as $name => $val)
 		{
-			if(isset($module_info->{$name})) continue;
+			if(isset($module_info->{$name})) {
+				continue;
+			}
 			$module_info->{$name} = $val->value;
 		}
 	}
@@ -1946,7 +2159,9 @@ 
 			$args = new stdClass();
 			$args->module_srl = $module_srl;
 			$output = executeQueryArray('module.getModuleMobileSkinVars',$args);
-			if(!$output->toBool() || !$output->data) return;
+			if(!$output->toBool() || !$output->data) {
+				return;
+			}
 
 			$skin_vars = array();
 			foreach($output->data as $vars)
@@ -1954,7 +2169,9 @@ 
 				$skin_vars[$vars->name] = $vars;
 			}
 
-			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);
+			if($oCacheHandler->isSupport()) {
+				$oCacheHandler->put($cache_key, $skin_vars);
+			}
 		}
 
 		return $skin_vars;
@@ -1966,7 +2183,9 @@ 
 	 */
 	function syncMobileSkinInfoToModuleInfo(&$module_info)
 	{
-		if(!$module_info->module_srl) return;
+		if(!$module_info->module_srl) {
+			return;
+		}
 		$skin_vars = false;
 		// cache controll
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
@@ -1981,17 +2200,25 @@ 
 			$args = new stdClass;
 			$args->module_srl = $module_info->module_srl;
 			$output = executeQueryArray('module.getModuleMobileSkinVars',$args);
-			if(!$output->toBool()) return;
+			if(!$output->toBool()) {
+				return;
+			}
 			$skin_vars = $output->data;
 
 			//insert in cache
-			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);
+			if($oCacheHandler->isSupport()) {
+				$oCacheHandler->put($cache_key, $skin_vars);
+			}
+		}
+		if(!$skin_vars) {
+			return;
 		}
-		if(!$skin_vars) return;
 
 		foreach($output->data as $val)
 		{
-			if(isset($module_info->{$val->name})) continue;
+			if(isset($module_info->{$val->name})) {
+				continue;
+			}
 			$module_info->{$val->name} = $val->value;
 		}
 	}
@@ -2013,10 +2240,12 @@ 
 		$grant_info = $xml_info->grant;
 		if($member_info->member_srl)
 		{
-			if(is_array($member_info->group_list)) $group_list = array_keys($member_info->group_list);
-			else $group_list = array();
-		}
-		else
+			if(is_array($member_info->group_list)) {
+				$group_list = array_keys($member_info->group_list);
+			} else {
+				$group_list = array();
+			}
+		} else
 		{
 			$group_list = array();
 		}
@@ -2030,8 +2259,7 @@ 
 			}
 
 			$grant->is_admin = $grant->manager = ($member_info->is_admin == 'Y') ? true : false;
-		}
-		else
+		} else
 		{
 			// If module_srl exists
 			// Get a type of granted permission
@@ -2044,7 +2272,9 @@ 
 				$args->module_srl = $module_srl;
 				$args->member_srl = $member_info->member_srl;
 				$output = executeQuery('module.getModuleAdmin',$args);
-				if($output->data && $output->data->member_srl == $member_info->member_srl) $grant->manager = true;
+				if($output->data && $output->data->member_srl == $member_info->member_srl) {
+					$grant->manager = true;
+				}
 			}
 			// If not an administrator, get information from the DB and grant manager privilege.
 			if(!$grant->manager)
@@ -2054,8 +2284,7 @@ 
 				if($module_info->module == 'planet')
 				{
 					$output = executeQueryArray('module.getPlanetGrants', $args);
-				}
-				else
+				} else
 				{
 					$args = new stdClass;
 					$args->module_srl = $module_srl;
@@ -2070,42 +2299,48 @@ 
 					foreach($output->data as $val)
 					{
 						$grant_exists[$val->name] = true;
-						if($granted[$val->name]) continue;
+						if($granted[$val->name]) {
+							continue;
+						}
 						// Log-in member only
 						if($val->group_srl == -1)
 						{
 							$granted[$val->name] = true;
-							if($member_info->member_srl) $grant->{$val->name} = true;
+							if($member_info->member_srl) {
+								$grant->{$val->name} = true;
+							}
 							// Site-joined member only
-						}
-						elseif($val->group_srl == -2)
+						} elseif($val->group_srl == -2)
 						{
 							$granted[$val->name] = true;
 							// Do not grant any permission for non-logged member
-							if(!$member_info->member_srl) $grant->{$val->name} = false;
+							if(!$member_info->member_srl) {
+								$grant->{$val->name} = false;
+							}
 							// Log-in member
 							else
 							{
 								$site_module_info = Context::get('site_module_info');
 								// Permission granted if no information of the currently connected site exists
-								if(!$site_module_info->site_srl) $grant->{$val->name} = true;
+								if(!$site_module_info->site_srl) {
+									$grant->{$val->name} = true;
+								}
 								// Permission is not granted if information of the currently connected site exists
-								elseif(count($group_list)) $grant->{$val->name} = true;
+								elseif(count($group_list)) {
+									$grant->{$val->name} = true;
+								}
 							}
 							// All of non-logged members
-						}
-						elseif($val->group_srl == -3)
+						} elseif($val->group_srl == -3)
 						{
 							$granted[$val->name] = true;
 							$grant->{$val->name} = ($grant->is_admin || $grant->is_site_admin);
-						}
-						elseif($val->group_srl == 0)
+						} elseif($val->group_srl == 0)
 						{
 							$granted[$val->name] = true;
 							$grant->{$val->name} = true;
 							// If a target is a group
-						}
-						else
+						} else
 						{
 							if($group_list && count($group_list) && in_array($val->group_srl, $group_list))
 							{
@@ -2116,30 +2351,43 @@ 
 					}
 				}
 				// Separate processing for the virtual group access
-				if(!$grant_exists['access']) $grant->access = true;
+				if(!$grant_exists['access']) {
+					$grant->access = true;
+				}
 				if(count($grant_info))
 				{
 					foreach($grant_info as  $grant_name => $grant_item)
 					{
-						if($grant_exists[$grant_name]) continue;
+						if($grant_exists[$grant_name]) {
+							continue;
+						}
 						switch($grant_item->default)
 						{
 							case 'guest' :
 								$grant->{$grant_name} = true;
 								break;
 							case 'member' :
-								if($member_info->member_srl) $grant->{$grant_name} = true;
-								else $grant->{$grant_name} = false;
+								if($member_info->member_srl) {
+									$grant->{$grant_name} = true;
+								} else {
+									$grant->{$grant_name} = false;
+								}
 								break;
 							case 'site' :
 								$site_module_info = Context::get('site_module_info');
-								if($member_info->member_srl && (($site_module_info->site_srl && count($group_list)) || !$site_module_info->site_srl)) $grant->{$grant_name} = true;
-								else $grant->{$grant_name} = false;
+								if($member_info->member_srl && (($site_module_info->site_srl && count($group_list)) || !$site_module_info->site_srl)) {
+									$grant->{$grant_name} = true;
+								} else {
+									$grant->{$grant_name} = false;
+								}
 								break;
 							case 'manager' :
 							case 'root' :
-								if($member_info->is_admin == 'Y') $grant->{$grant_name} = true;
-								else $grant->{$grant_name} = false;
+								if($member_info->is_admin == 'Y') {
+									$grant->{$grant_name} = true;
+								} else {
+									$grant->{$grant_name} = false;
+								}
 								break;
 						}
 					}
@@ -2215,16 +2463,22 @@ 
 	function getFileBoxListHtml()
 	{
 		$logged_info = Context::get('logged_info');
-		if($logged_info->is_admin !='Y' && !$logged_info->is_site_admin) return new BaseObject(-1, 'msg_not_permitted');
+		if($logged_info->is_admin !='Y' && !$logged_info->is_site_admin) {
+			return new BaseObject(-1, 'msg_not_permitted');
+		}
 		$link = parse_url($_SERVER["HTTP_REFERER"]);
 		$link_params = explode('&',$link['query']);
 		foreach ($link_params as $param)
 		{
 			$param = explode("=",$param);
-			if($param[0] == 'selected_widget') $selected_widget = $param[1];
+			if($param[0] == 'selected_widget') {
+				$selected_widget = $param[1];
+			}
 		}
 		$oWidgetModel = getModel('widget');
-		if($selected_widget) $widget_info = $oWidgetModel->getWidgetInfo($selected_widget);
+		if($selected_widget) {
+			$widget_info = $oWidgetModel->getWidgetInfo($selected_widget);
+		}
 		Context::set('allow_multiple', $widget_info->extra_var->images->allow_multiple);
 
 		$oModuleModel = getModel('module');
@@ -2232,7 +2486,9 @@ 
 		Context::set('filebox_list', $output->data);
 
 		$page = Context::get('page');
-		if (!$page) $page = 1;
+		if (!$page) {
+			$page = 1;
+		}
 		Context::set('page', $page);
 		Context::set('page_navigation', $output->page_navigation);
 
@@ -2262,25 +2518,28 @@ 
 			$rulsetFile = str_replace('@', '', $ruleset);
 			$xml_file = sprintf('./files/ruleset/%s.xml', $rulsetFile);
 			return FileHandler::getRealPath($xml_file);
-		}
-		else if (strpos($ruleset, '#') !== false)
+		} else if (strpos($ruleset, '#') !== false)
 		{
 			$rulsetFile = str_replace('#', '', $ruleset).'.'.$mid;
 			$xml_file = sprintf('./files/ruleset/%s.xml', $rulsetFile);
-			if(is_readable($xml_file))
-				return FileHandler::getRealPath($xml_file);
-			else{
+			if(is_readable($xml_file)) {
+							return FileHandler::getRealPath($xml_file);
+			} else{
 				$ruleset = str_replace('#', '', $ruleset);
 			}
 
 		}
 		// Get a path of the requested module. Return if not exists.
 		$class_path = ModuleHandler::getModulePath($module);
-		if(!$class_path) return;
+		if(!$class_path) {
+			return;
+		}
 
 		// Check if module.xml exists in the path. Return if not exist
 		$xml_file = sprintf("%sruleset/%s.xml", $class_path, $ruleset);
-		if(!file_exists($xml_file)) return;
+		if(!file_exists($xml_file)) {
+			return;
+		}
 
 		return $xml_file;
 	}
@@ -2330,7 +2589,9 @@ 
 	function getLangByLangcode()
 	{
 		$langCode = Context::get('langCode');
-		if (!$langCode) return;
+		if (!$langCode) {
+			return;
+		}
 
 		$oModuleController = getController('module');
 		$oModuleController->replaceDefinedLangCode($langCode);

modules/install/install.admin.controller.php

Doc Comments +9 added lines, -1 removed lines

@@ -294,6 +294,7 @@ 
 
 	/**
 	 * @brief Supported languages (was procInstallAdminSaveLangSelected)
+	 * @param string $selected_lang
 	 */
 	function saveLangSelected($selected_lang)
 	{
@@ -312,7 +313,7 @@ 
 
 	/**
 	 * Change the way the thumbnails are show.
-	 * @param $config
+	 * @param stdClass $config
 	 * @return void
 	 */
 	function setModulesConfig($config)
@@ -337,6 +338,10 @@ 
 		$oModuleController->updateModuleConfig('module',$args);
 	}
 
+	/**
+	 * @param string $icon
+	 * @param string $iconname
+	 */
 	private function saveIconTmp($icon, $iconname)
 	{
 
@@ -383,6 +388,9 @@ 
 		return $relative_filename;
 	}
 
+	/**
+	 * @param string $iconname
+	 */
 	private function updateIcon($iconname, $deleteIcon = false) {
 
 		$site_info = Context::get('site_module_info');

Spacing +63 added lines, -63 removed lines

@@ -20,7 +20,7 @@ 
 	function procInstallAdminInstall()
 	{
 		$module_name = Context::get('module_name');
-		if(!$module_name) return new BaseObject(-1, 'invalid_request');
+		if (!$module_name) return new BaseObject(-1, 'invalid_request');
 
 		$oInstallController = getController('install');
 		$oInstallController->installModule($module_name, './modules/'.$module_name);
@@ -35,10 +35,10 @@ 
 	{
 		@set_time_limit(0);
 		$module_name = Context::get('module_name');
-		if(!$module_name) return new BaseObject(-1, 'invalid_request');
+		if (!$module_name) return new BaseObject(-1, 'invalid_request');
 
 		$oModule = getModule($module_name, 'class');
-		if($oModule) $output = $oModule->moduleUpdate();
+		if ($oModule) $output = $oModule->moduleUpdate();
 		else $output = new BaseObject(-1, 'invalid_request');
 
 		return $output;
@@ -53,51 +53,51 @@ 
 
 		$admin_ip_list = Context::get('admin_ip_list');
 
-		if($admin_ip_list)
+		if ($admin_ip_list)
 		{
-			$admin_ip_list = preg_replace("/[\r|\n|\r\n]+/",",",$admin_ip_list);
-			$admin_ip_list = preg_replace("/\s+/","",$admin_ip_list);
-			if(preg_match('/(<\?|<\?php|\?>)/xsm', $admin_ip_list))
+			$admin_ip_list = preg_replace("/[\r|\n|\r\n]+/", ",", $admin_ip_list);
+			$admin_ip_list = preg_replace("/\s+/", "", $admin_ip_list);
+			if (preg_match('/(<\?|<\?php|\?>)/xsm', $admin_ip_list))
 			{
 				$admin_ip_list = '';
 			}
-			$admin_ip_list .= ',127.0.0.1,' . $_SERVER['REMOTE_ADDR'];
-			$admin_ip_list = explode(',',trim($admin_ip_list, ','));
+			$admin_ip_list .= ',127.0.0.1,'.$_SERVER['REMOTE_ADDR'];
+			$admin_ip_list = explode(',', trim($admin_ip_list, ','));
 			$admin_ip_list = array_unique($admin_ip_list);
-			if(!IpFilter::validate($admin_ip_list)) {
+			if (!IpFilter::validate($admin_ip_list)) {
 				return new BaseObject(-1, 'msg_invalid_ip');
 			}
 		}
 		
 		$default_url = Context::get('default_url');
-		if($default_url && strncasecmp('http://', $default_url, 7) !== 0 && strncasecmp('https://', $default_url, 8) !== 0) $default_url = 'http://'.$default_url;
-		if($default_url && substr($default_url, -1) !== '/') $default_url = $default_url.'/';
+		if ($default_url && strncasecmp('http://', $default_url, 7) !== 0 && strncasecmp('https://', $default_url, 8) !== 0) $default_url = 'http://'.$default_url;
+		if ($default_url && substr($default_url, -1) !== '/') $default_url = $default_url.'/';
 
 		/* convert NON Alphabet URL to punycode URL - Alphabet URL will not be changed */
-		require_once(_XE_PATH_ . 'libs/idna_convert/idna_convert.class.php');
+		require_once(_XE_PATH_.'libs/idna_convert/idna_convert.class.php');
 		$IDN = new idna_convert(array('idn_version' => 2008));
 		$default_url = $IDN->encode($default_url);
 
 		$use_ssl = Context::get('use_ssl');
-		if(!$use_ssl) $use_ssl = 'none';
+		if (!$use_ssl) $use_ssl = 'none';
 
 		$http_port = Context::get('http_port');
 		$https_port = Context::get('https_port');
 
 		$use_rewrite = Context::get('use_rewrite');
-		if($use_rewrite!='Y') $use_rewrite = 'N';
+		if ($use_rewrite != 'Y') $use_rewrite = 'N';
 
 		$use_sso = Context::get('use_sso');
-		if($use_sso !='Y') $use_sso = 'N';
+		if ($use_sso != 'Y') $use_sso = 'N';
 
 		$use_db_session = Context::get('use_db_session');
-		if($use_db_session!='Y') $use_db_session = 'N';
+		if ($use_db_session != 'Y') $use_db_session = 'N';
 
 		$qmail_compatibility = Context::get('qmail_compatibility');
-		if($qmail_compatibility!='Y') $qmail_compatibility = 'N';
+		if ($qmail_compatibility != 'Y') $qmail_compatibility = 'N';
 
 		$use_html5 = Context::get('use_html5');
-		if(!$use_html5) $use_html5 = 'N';
+		if (!$use_html5) $use_html5 = 'N';
 
 		$db_info->default_url = $default_url;
 		$db_info->qmail_compatibility = $qmail_compatibility;
@@ -108,23 +108,23 @@ 
 		$db_info->use_html5 = $use_html5;
 		$db_info->admin_ip_list = $admin_ip_list;
 
-		if($http_port) $db_info->http_port = (int) $http_port;
-		else if($db_info->http_port) unset($db_info->http_port);
+		if ($http_port) $db_info->http_port = (int) $http_port;
+		else if ($db_info->http_port) unset($db_info->http_port);
 
-		if($https_port) $db_info->https_port = (int) $https_port;
-		else if($db_info->https_port) unset($db_info->https_port);
+		if ($https_port) $db_info->https_port = (int) $https_port;
+		else if ($db_info->https_port) unset($db_info->https_port);
 
 		unset($db_info->lang_type);
 
 		$oInstallController = getController('install');
-		if(!$oInstallController->makeConfigFile())
+		if (!$oInstallController->makeConfigFile())
 		{
 			return new BaseObject(-1, 'msg_invalid_request');
 		}
 		else
 		{
 			Context::setDBInfo($db_info);
-			if($default_url)
+			if ($default_url)
 			{
 				$site_args = new stdClass;
 				$site_args->site_srl = 0;
@@ -138,7 +138,7 @@ 
 
 	function procInstallAdminUpdateIndexModule()
 	{
-		if(!Context::get('index_module_srl') || !Context::get('menu_item_srl'))
+		if (!Context::get('index_module_srl') || !Context::get('menu_item_srl'))
 		{
 			return new BaseObject(-1, 'msg_invalid_request');
 		}
@@ -157,12 +157,12 @@ 
 		// update homeSitemap.php cache file
 		$oMenuAdminController = getAdminController('menu');
 		$homeMenuCacheFile = $oMenuAdminController->getHomeMenuCacheFile();
-		if(file_exists($homeMenuCacheFile))
+		if (file_exists($homeMenuCacheFile))
 		{
 			include($homeMenuCacheFile);
 		}
 
-		if(!$homeMenuSrl || $homeMenuSrl != $output->menu_srl)
+		if (!$homeMenuSrl || $homeMenuSrl != $output->menu_srl)
 		{
 			$oMenuAdminController->makeHomemenuCacheFile($output->menu_srl);
 		}
@@ -173,8 +173,8 @@ 
 	function procInstallAdminRemoveFTPInfo()
 	{
 		$ftp_config_file = Context::getFTPConfigFile();
-		if(file_exists($ftp_config_file)) unlink($ftp_config_file);
-		if($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
+		if (file_exists($ftp_config_file)) unlink($ftp_config_file);
+		if ($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
 		$this->setMessage('success_deleted');
 	}
 
@@ -185,11 +185,11 @@ 
 		$ftp_info->ftp_port = Context::get('ftp_port');
 		$ftp_info->ftp_host = Context::get('ftp_host');
 		$ftp_info->ftp_pasv = Context::get('ftp_pasv');
-		if(!$ftp_info->ftp_pasv) $ftp_info->ftp_pasv = "N";
+		if (!$ftp_info->ftp_pasv) $ftp_info->ftp_pasv = "N";
 		$ftp_info->sftp = Context::get('sftp');
 
 		$ftp_root_path = Context::get('ftp_root_path');
-		if(substr($ftp_root_path, strlen($ftp_root_path)-1) == "/")
+		if (substr($ftp_root_path, strlen($ftp_root_path) - 1) == "/")
 		{
 			$ftp_info->ftp_root_path = $ftp_root_path;
 		}
@@ -198,25 +198,25 @@ 
 			$ftp_info->ftp_root_path = $ftp_root_path.'/';
 		}
 
-		if(ini_get('safe_mode'))
+		if (ini_get('safe_mode'))
 		{
 			$ftp_info->ftp_password = Context::get('ftp_password');
 		}
 
 		$buff = '<?php if(!defined("__XE__")) exit();'."\n\$ftp_info = new stdClass;\n";
-		foreach($ftp_info as $key => $val)
+		foreach ($ftp_info as $key => $val)
 		{
-			if(!$val) continue;
-			if(preg_match('/(<\?|<\?php|\?>|fputs|fopen|fwrite|fgets|fread|file_get_contents|file_put_contents|exec|proc_open|popen|passthru|show_source|phpinfo|system|\/\*|\*\/|chr\()/xsm', preg_replace('/\s/', '', $val)))
+			if (!$val) continue;
+			if (preg_match('/(<\?|<\?php|\?>|fputs|fopen|fwrite|fgets|fread|file_get_contents|file_put_contents|exec|proc_open|popen|passthru|show_source|phpinfo|system|\/\*|\*\/|chr\()/xsm', preg_replace('/\s/', '', $val)))
 			{
 				continue;
 			}
-			$buff .= sprintf("\$ftp_info->%s = '%s';\n", $key, str_replace("'","\\'",$val));
+			$buff .= sprintf("\$ftp_info->%s = '%s';\n", $key, str_replace("'", "\\'", $val));
 		}
 		$buff .= "?>";
 		$config_file = Context::getFTPConfigFile();
 		FileHandler::WriteFile($config_file, $buff);
-		if($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
+		if ($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
 
 		$this->setMessage('success_updated');
 		$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'module', 'admin', 'act', 'dispAdminConfigFtp');
@@ -226,7 +226,7 @@ 
 	function procInstallAdminConfig()
 	{
 		$use_mobile_view = Context::get('use_mobile_view');
-		if($use_mobile_view!='Y') $use_mobile_view = 'N';
+		if ($use_mobile_view != 'Y') $use_mobile_view = 'N';
 
 		$time_zone = Context::get('time_zone');
 
@@ -237,15 +237,15 @@ 
 		unset($db_info->lang_type);
 		Context::setDBInfo($db_info);
 		$oInstallController = getController('install');
-		if(!$oInstallController->makeConfigFile())
+		if (!$oInstallController->makeConfigFile())
 		{
 			return new BaseObject(-1, 'msg_invalid_request');
 		}
 
 		$site_args = new stdClass();
 		$site_args->site_srl = 0;
-		$site_args->index_module_srl = Context::get('index_module_srl');//
-		$site_args->default_language = Context::get('change_lang_type');//
+		$site_args->index_module_srl = Context::get('index_module_srl'); //
+		$site_args->default_language = Context::get('change_lang_type'); //
 		$oModuleController = getController('module');
 		$oModuleController->updateSite($site_args);
 
@@ -257,8 +257,8 @@ 
 		$deleteFavicon = Context::get('is_delete_favicon');
 		$deleteMobicon = Context::get('is_delete_mobicon');
 
-		$this->updateIcon('favicon.ico',$deleteFavicon);
-		$this->updateIcon('mobicon.png',$deleteMobicon);
+		$this->updateIcon('favicon.ico', $deleteFavicon);
+		$this->updateIcon('mobicon.png', $deleteMobicon);
 
 		//모듈 설정 저장(썸네일, 풋터스크립트)
 		$config = new stdClass();
@@ -276,16 +276,16 @@ 
 
 		$favicon = Context::get('favicon');
 		$mobicon = Context::get('mobicon');
-		if(!$favicon && !$mobicon) {
+		if (!$favicon && !$mobicon) {
 			Context::set('msg', Context::getLang("msg_invalid_format"));
 			return;
 		}
-		if($favicon) {
+		if ($favicon) {
 			$name = 'favicon';
-			$tmpFileName = $this->saveIconTmp($favicon,'favicon.ico');
+			$tmpFileName = $this->saveIconTmp($favicon, 'favicon.ico');
 		} else {
 			$name = 'mobicon';
-			$tmpFileName = $this->saveIconTmp($mobicon,'mobicon.png');
+			$tmpFileName = $this->saveIconTmp($mobicon, 'mobicon.png');
 		}
 
 		Context::set('name', $name);
@@ -301,7 +301,7 @@ 
 
 		$lang_supported = Context::loadLangSupported();
 		$buff = null;
-		for($i=0;$i<count($langs);$i++)
+		for ($i = 0; $i < count($langs); $i++)
 		{
 			$buff .= sprintf("%s,%s\n", $langs[$i], $lang_supported[$langs[$i]]);
 
@@ -329,12 +329,12 @@ 
 		}
 
 		$oModuleController = getController('module');
-		$oModuleController->insertModuleConfig('document',$documentConfig);
+		$oModuleController->insertModuleConfig('document', $documentConfig);
 
 		$args = new stdClass;
 		$args->htmlFooter = $config->htmlFooter;
 		$args->siteTitle = $config->siteTitle;
-		$oModuleController->updateModuleConfig('module',$args);
+		$oModuleController->updateModuleConfig('module', $args);
 	}
 
 	private function saveIconTmp($icon, $iconname)
@@ -342,9 +342,9 @@ 
 
 		$site_info = Context::get('site_module_info');
 		$virtual_site = '';
-		if($site_info->site_srl) 
+		if ($site_info->site_srl) 
 		{
-			$virtual_site = $site_info->site_srl . '/';
+			$virtual_site = $site_info->site_srl.'/';
 		}
 
 		$target_file = $icon['tmp_name'];
@@ -353,20 +353,20 @@ 
 		$target_filename = _XE_PATH_.$relative_filename;
 
 		list($width, $height, $type_no, $attrs) = @getimagesize($target_file);
-		if($iconname == 'favicon.ico')
+		if ($iconname == 'favicon.ico')
 		{
-			if(!preg_match('/^.*(x-icon|\.icon)$/i',$type)) {
+			if (!preg_match('/^.*(x-icon|\.icon)$/i', $type)) {
 				Context::set('msg', '*.ico '.Context::getLang('msg_possible_only_file'));
 				return;
 			}
 		}
-		else if($iconname == 'mobicon.png')
+		else if ($iconname == 'mobicon.png')
 		{
-			if(!preg_match('/^.*(png).*$/',$type)) {
+			if (!preg_match('/^.*(png).*$/', $type)) {
 				Context::set('msg', '*.png '.Context::getLang('msg_possible_only_file'));
 				return;
 			}
-			if(!(($height == '57' && $width == '57') || ($height == '114' && $width == '114'))) {
+			if (!(($height == '57' && $width == '57') || ($height == '114' && $width == '114'))) {
 				Context::set('msg', Context::getLang('msg_invalid_format').' (size : 57x57, 114x114)');
 				return;
 			}
@@ -387,21 +387,21 @@ 
 
 		$site_info = Context::get('site_module_info');
 		$virtual_site = '';
-		if($site_info->site_srl) 
+		if ($site_info->site_srl) 
 		{
-			$virtual_site = $site_info->site_srl . '/';
+			$virtual_site = $site_info->site_srl.'/';
 		}
 
-		$image_filepath = _XE_PATH_.'files/attach/xeicon/' . $virtual_site;
+		$image_filepath = _XE_PATH_.'files/attach/xeicon/'.$virtual_site;
 
-		if($deleteIcon) {
+		if ($deleteIcon) {
 			FileHandler::removeFile($image_filepath.$iconname);
 			return;
 		}
 
 		$tmpicon_filepath = $image_filepath.'tmp/'.$iconname;
 		$icon_filepath = $image_filepath.$iconname;
-		if(file_exists($tmpicon_filepath))
+		if (file_exists($tmpicon_filepath))
 		{
 			FileHandler::moveFile($tmpicon_filepath, $icon_filepath);
 		}

Braces +68 added lines, -32 removed lines

@@ -20,7 +20,9 @@ 
 	function procInstallAdminInstall()
 	{
 		$module_name = Context::get('module_name');
-		if(!$module_name) return new BaseObject(-1, 'invalid_request');
+		if(!$module_name) {
+			return new BaseObject(-1, 'invalid_request');
+		}
 
 		$oInstallController = getController('install');
 		$oInstallController->installModule($module_name, './modules/'.$module_name);
@@ -35,11 +37,16 @@ 
 	{
 		@set_time_limit(0);
 		$module_name = Context::get('module_name');
-		if(!$module_name) return new BaseObject(-1, 'invalid_request');
+		if(!$module_name) {
+			return new BaseObject(-1, 'invalid_request');
+		}
 
 		$oModule = getModule($module_name, 'class');
-		if($oModule) $output = $oModule->moduleUpdate();
-		else $output = new BaseObject(-1, 'invalid_request');
+		if($oModule) {
+			$output = $oModule->moduleUpdate();
+		} else {
+			$output = new BaseObject(-1, 'invalid_request');
+		}
 
 		return $output;
 	}
@@ -70,8 +77,12 @@ 
 		}
 		
 		$default_url = Context::get('default_url');
-		if($default_url && strncasecmp('http://', $default_url, 7) !== 0 && strncasecmp('https://', $default_url, 8) !== 0) $default_url = 'http://'.$default_url;
-		if($default_url && substr($default_url, -1) !== '/') $default_url = $default_url.'/';
+		if($default_url && strncasecmp('http://', $default_url, 7) !== 0 && strncasecmp('https://', $default_url, 8) !== 0) {
+			$default_url = 'http://'.$default_url;
+		}
+		if($default_url && substr($default_url, -1) !== '/') {
+			$default_url = $default_url.'/';
+		}
 
 		/* convert NON Alphabet URL to punycode URL - Alphabet URL will not be changed */
 		require_once(_XE_PATH_ . 'libs/idna_convert/idna_convert.class.php');
@@ -79,25 +90,37 @@ 
 		$default_url = $IDN->encode($default_url);
 
 		$use_ssl = Context::get('use_ssl');
-		if(!$use_ssl) $use_ssl = 'none';
+		if(!$use_ssl) {
+			$use_ssl = 'none';
+		}
 
 		$http_port = Context::get('http_port');
 		$https_port = Context::get('https_port');
 
 		$use_rewrite = Context::get('use_rewrite');
-		if($use_rewrite!='Y') $use_rewrite = 'N';
+		if($use_rewrite!='Y') {
+			$use_rewrite = 'N';
+		}
 
 		$use_sso = Context::get('use_sso');
-		if($use_sso !='Y') $use_sso = 'N';
+		if($use_sso !='Y') {
+			$use_sso = 'N';
+		}
 
 		$use_db_session = Context::get('use_db_session');
-		if($use_db_session!='Y') $use_db_session = 'N';
+		if($use_db_session!='Y') {
+			$use_db_session = 'N';
+		}
 
 		$qmail_compatibility = Context::get('qmail_compatibility');
-		if($qmail_compatibility!='Y') $qmail_compatibility = 'N';
+		if($qmail_compatibility!='Y') {
+			$qmail_compatibility = 'N';
+		}
 
 		$use_html5 = Context::get('use_html5');
-		if(!$use_html5) $use_html5 = 'N';
+		if(!$use_html5) {
+			$use_html5 = 'N';
+		}
 
 		$db_info->default_url = $default_url;
 		$db_info->qmail_compatibility = $qmail_compatibility;
@@ -108,11 +131,17 @@ 
 		$db_info->use_html5 = $use_html5;
 		$db_info->admin_ip_list = $admin_ip_list;
 
-		if($http_port) $db_info->http_port = (int) $http_port;
-		else if($db_info->http_port) unset($db_info->http_port);
+		if($http_port) {
+			$db_info->http_port = (int) $http_port;
+		} else if($db_info->http_port) {
+			unset($db_info->http_port);
+		}
 
-		if($https_port) $db_info->https_port = (int) $https_port;
-		else if($db_info->https_port) unset($db_info->https_port);
+		if($https_port) {
+			$db_info->https_port = (int) $https_port;
+		} else if($db_info->https_port) {
+			unset($db_info->https_port);
+		}
 
 		unset($db_info->lang_type);
 
@@ -120,8 +149,7 @@ 
 		if(!$oInstallController->makeConfigFile())
 		{
 			return new BaseObject(-1, 'msg_invalid_request');
-		}
-		else
+		} else
 		{
 			Context::setDBInfo($db_info);
 			if($default_url)
@@ -173,8 +201,12 @@ 
 	function procInstallAdminRemoveFTPInfo()
 	{
 		$ftp_config_file = Context::getFTPConfigFile();
-		if(file_exists($ftp_config_file)) unlink($ftp_config_file);
-		if($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
+		if(file_exists($ftp_config_file)) {
+			unlink($ftp_config_file);
+		}
+		if($_SESSION['ftp_password']) {
+			unset($_SESSION['ftp_password']);
+		}
 		$this->setMessage('success_deleted');
 	}
 
@@ -185,15 +217,16 @@ 
 		$ftp_info->ftp_port = Context::get('ftp_port');
 		$ftp_info->ftp_host = Context::get('ftp_host');
 		$ftp_info->ftp_pasv = Context::get('ftp_pasv');
-		if(!$ftp_info->ftp_pasv) $ftp_info->ftp_pasv = "N";
+		if(!$ftp_info->ftp_pasv) {
+			$ftp_info->ftp_pasv = "N";
+		}
 		$ftp_info->sftp = Context::get('sftp');
 
 		$ftp_root_path = Context::get('ftp_root_path');
 		if(substr($ftp_root_path, strlen($ftp_root_path)-1) == "/")
 		{
 			$ftp_info->ftp_root_path = $ftp_root_path;
-		}
-		else
+		} else
 		{
 			$ftp_info->ftp_root_path = $ftp_root_path.'/';
 		}
@@ -206,7 +239,9 @@ 
 		$buff = '<?php if(!defined("__XE__")) exit();'."\n\$ftp_info = new stdClass;\n";
 		foreach($ftp_info as $key => $val)
 		{
-			if(!$val) continue;
+			if(!$val) {
+				continue;
+			}
 			if(preg_match('/(<\?|<\?php|\?>|fputs|fopen|fwrite|fgets|fread|file_get_contents|file_put_contents|exec|proc_open|popen|passthru|show_source|phpinfo|system|\/\*|\*\/|chr\()/xsm', preg_replace('/\s/', '', $val)))
 			{
 				continue;
@@ -216,7 +251,9 @@ 
 		$buff .= "?>";
 		$config_file = Context::getFTPConfigFile();
 		FileHandler::WriteFile($config_file, $buff);
-		if($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
+		if($_SESSION['ftp_password']) {
+			unset($_SESSION['ftp_password']);
+		}
 
 		$this->setMessage('success_updated');
 		$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'module', 'admin', 'act', 'dispAdminConfigFtp');
@@ -226,7 +263,9 @@ 
 	function procInstallAdminConfig()
 	{
 		$use_mobile_view = Context::get('use_mobile_view');
-		if($use_mobile_view!='Y') $use_mobile_view = 'N';
+		if($use_mobile_view!='Y') {
+			$use_mobile_view = 'N';
+		}
 
 		$time_zone = Context::get('time_zone');
 
@@ -322,8 +361,7 @@ 
 		if (!$config->thumbnail_type || $config->thumbnail_type != 'ratio')
 		{
 			$documentConfig->thumbnail_type = 'crop';
-		}
-		else
+		} else
 		{
 			$documentConfig->thumbnail_type = 'ratio';
 		}
@@ -359,8 +397,7 @@ 
 				Context::set('msg', '*.ico '.Context::getLang('msg_possible_only_file'));
 				return;
 			}
-		}
-		else if($iconname == 'mobicon.png')
+		} else if($iconname == 'mobicon.png')
 		{
 			if(!preg_match('/^.*(png).*$/',$type)) {
 				Context::set('msg', '*.png '.Context::getLang('msg_possible_only_file'));
@@ -370,8 +407,7 @@ 
 				Context::set('msg', Context::getLang('msg_invalid_format').' (size : 57x57, 114x114)');
 				return;
 			}
-		}
-		else
+		} else
 		{
 			Context::set('msg', Context::getLang('msg_invalid_format'));
 			return;

widgets/mcontent/mcontent.class.php

Spacing +145 added lines, -145 removed lines

@@ -18,32 +18,32 @@ 
 	function proc($args)
 	{
 		// Targets to sort
-		if(!in_array($args->order_target, array('list_order','update_order'))) $args->order_target = 'list_order';
+		if (!in_array($args->order_target, array('list_order', 'update_order'))) $args->order_target = 'list_order';
 		// Sort order
-		if(!in_array($args->order_type, array('asc','desc'))) $args->order_type = 'asc';
+		if (!in_array($args->order_type, array('asc', 'desc'))) $args->order_type = 'asc';
 		// The number of displayed lists
-		$args->list_count = (int)$args->list_count;
-		if(!$args->list_count) $args->list_count = 5;
+		$args->list_count = (int) $args->list_count;
+		if (!$args->list_count) $args->list_count = 5;
 		// Cut the length of the title
-		if(!$args->subject_cut_size) $args->subject_cut_size = 0;
+		if (!$args->subject_cut_size) $args->subject_cut_size = 0;
 		// Cut the length of contents
-		if(!$args->content_cut_size) $args->content_cut_size = 100;
+		if (!$args->content_cut_size) $args->content_cut_size = 100;
 		// Viewing options
-		$args->option_view_arr = explode(',',$args->option_view);
+		$args->option_view_arr = explode(',', $args->option_view);
 		// markup options
-		if(!$args->markup_type) $args->markup_type = 'list';
+		if (!$args->markup_type) $args->markup_type = 'list';
 		// Set variables for internal use
 		$oModuleModel = getModel('module');
 		$module_srls = $args->modules_info = $args->module_srls_info = $args->mid_lists = array();
 		$site_module_info = Context::get('site_module_info');
 		// List URLs if a type is RSS
-		if($args->content_type == 'rss')
+		if ($args->content_type == 'rss')
 		{
 			$args->rss_urls = array();
-			$rss_urls = array_unique(array($args->rss_url0,$args->rss_url1,$args->rss_url2,$args->rss_url3,$args->rss_url4));
-			for($i=0,$c=count($rss_urls);$i<$c;$i++)
+			$rss_urls = array_unique(array($args->rss_url0, $args->rss_url1, $args->rss_url2, $args->rss_url3, $args->rss_url4));
+			for ($i = 0, $c = count($rss_urls); $i < $c; $i++)
 			{
-				if($rss_urls[$i]) $args->rss_urls[] = $rss_urls[$i];
+				if ($rss_urls[$i]) $args->rss_urls[] = $rss_urls[$i];
 			}
 			// Get module information after listing module_srls if the module is not RSS
 		}
@@ -51,13 +51,13 @@ 
 		{
 			$obj = new stdClass();
 			// Apply to all modules in the site if a target module is not specified
-			if(!$args->module_srls)
+			if (!$args->module_srls)
 			{
-				$obj->site_srl = (int)$site_module_info->site_srl;
+				$obj->site_srl = (int) $site_module_info->site_srl;
 				$output = executeQueryArray('widgets.content.getMids', $obj);
-				if($output->data)
+				if ($output->data)
 				{
-					foreach($output->data as $key => $val)
+					foreach ($output->data as $key => $val)
 					{
 						$args->modules_info[$val->mid] = $val;
 						$args->module_srls_info[$val->module_srl] = $val;
@@ -73,35 +73,35 @@ 
 			{
 				$obj->module_srls = $args->module_srls;
 				$output = executeQueryArray('widgets.content.getMids', $obj);
-				if($output->data)
+				if ($output->data)
 				{
-					foreach($output->data as $key => $val)
+					foreach ($output->data as $key => $val)
 					{
 						$args->modules_info[$val->mid] = $val;
 						$args->module_srls_info[$val->module_srl] = $val;
 						$module_srls[] = $val->module_srl;
 					}
-					$idx = explode(',',$args->module_srls);
-					for($i=0,$c=count($idx);$i<$c;$i++)
+					$idx = explode(',', $args->module_srls);
+					for ($i = 0, $c = count($idx); $i < $c; $i++)
 					{
 						$srl = $idx[$i];
-						if(!$args->module_srls_info[$srl]) continue;
+						if (!$args->module_srls_info[$srl]) continue;
 						$args->mid_lists[$srl] = $args->module_srls_info[$srl]->mid;
 					}
 				}
 			}
 			// Exit if no module is found
-			if(!count($args->modules_info)) return Context::get('msg_not_founded');
-			$args->module_srl = implode(',',$module_srls);
+			if (!count($args->modules_info)) return Context::get('msg_not_founded');
+			$args->module_srl = implode(',', $module_srls);
 		}
 
 		/**
 		 * Method is separately made because content extraction, articles, comments, trackbacks, RSS and other elements exist
 		 */
 		// tab mode
-		if($args->tab_type == 'none' || $args->tab_type == '')
+		if ($args->tab_type == 'none' || $args->tab_type == '')
 		{
-			switch($args->content_type)
+			switch ($args->content_type)
 			{
 				case 'comment':
 					$content_items = $this->_getCommentItems($args);
@@ -125,17 +125,17 @@ 
 		{
 			$content_items = array();
 
-			switch($args->content_type)
+			switch ($args->content_type)
 			{
 				case 'comment':
-					foreach($args->mid_lists as $module_srl => $mid)
+					foreach ($args->mid_lists as $module_srl => $mid)
 					{
 						$args->module_srl = $module_srl;
 						$content_items[$module_srl] = $this->_getCommentItems($args);
 					}
 					break;
 				case 'image':
-					foreach($args->mid_lists as $module_srl => $mid)
+					foreach ($args->mid_lists as $module_srl => $mid)
 					{
 						$args->module_srl = $module_srl;
 						$content_items[$module_srl] = $this->_getImageItems($args);
@@ -145,13 +145,13 @@ 
 					$content_items = $this->getRssItems($args);
 					break;
 				case 'trackback':
-					foreach($args->mid_lists as $module_srl => $mid){
+					foreach ($args->mid_lists as $module_srl => $mid) {
 						$args->module_srl = $module_srl;
 						$content_items[$module_srl] = $this->_getTrackbackItems($args);
 					}
 					break;
 				default:
-					foreach($args->mid_lists as $module_srl => $mid)
+					foreach ($args->mid_lists as $module_srl => $mid)
 					{
 						$args->module_srl = $module_srl;
 						$content_items[$module_srl] = $this->_getDocumentItems($args);
@@ -160,7 +160,7 @@ 
 			}
 		}
 
-		$output = $this->_compile($args,$content_items);
+		$output = $this->_compile($args, $content_items);
 		return $output;
 	}
 
@@ -180,14 +180,14 @@ 
 
 		$content_items = array();
 
-		if(!count($output)) return;
+		if (!count($output)) return;
 
-		foreach($output as $key => $oComment)
+		foreach ($output as $key => $oComment)
 		{
 			$attribute = $oComment->getObjectVars();
 			$title = $oComment->getSummary($args->content_cut_size);
 			$thumbnail = $oComment->getThumbnail();
-			$url = sprintf("%s#comment_%s",getUrl('', 'mid', $args->mid_lists[$attribute->module_srl], 'document_srl',$oComment->get('document_srl')),$oComment->get('comment_srl'));
+			$url = sprintf("%s#comment_%s", getUrl('', 'mid', $args->mid_lists[$attribute->module_srl], 'document_srl', $oComment->get('document_srl')), $oComment->get('comment_srl'));
 
 			$attribute->mid = $args->mid_lists[$attribute->module_srl];
 			$browser_title = $args->module_srls_info[$attribute->module_srl]->browser_title;
@@ -212,10 +212,10 @@ 
 		// Get categories
 		$obj = new stdClass();
 		$obj->module_srl = $args->module_srl;
-		$output = executeQueryArray('widgets.content.getCategories',$obj);
-		if($output->toBool() && $output->data)
+		$output = executeQueryArray('widgets.content.getCategories', $obj);
+		if ($output->toBool() && $output->data)
 		{
-			foreach($output->data as $key => $val)
+			foreach ($output->data as $key => $val)
 			{
 				$category_lists[$val->module_srl][$val->category_srl] = $val;
 			}
@@ -223,17 +223,17 @@ 
 		// Get a list of documents
 		$obj->module_srl = $args->module_srl;
 		$obj->sort_index = $args->order_target;
-		$obj->order_type = $args->order_type=="desc"?"asc":"desc";
+		$obj->order_type = $args->order_type == "desc" ? "asc" : "desc";
 		$obj->list_count = $args->list_count;
 		$obj->statusList = array('PUBLIC');
 		$output = executeQueryArray('widgets.content.getNewestDocuments', $obj);
-		if(!$output->toBool() || !$output->data) return;
+		if (!$output->toBool() || !$output->data) return;
 		// If the result exists, make each document as an object
 		$content_items = array();
 		$first_thumbnail_idx = -1;
-		if(count($output->data))
+		if (count($output->data))
 		{
-			foreach($output->data as $key => $attribute)
+			foreach ($output->data as $key => $attribute)
 			{
 				$oDocument = new documentItem();
 				$oDocument->setAttribute($attribute, false);
@@ -242,23 +242,23 @@ 
 			}
 			$oDocumentModel->setToAllDocumentExtraVars();
 
-			for($i=0,$c=count($document_srls);$i<$c;$i++)
+			for ($i = 0, $c = count($document_srls); $i < $c; $i++)
 			{
 				$oDocument = $GLOBALS['XE_DOCUMENT_LIST'][$document_srls[$i]];
 				$document_srl = $oDocument->document_srl;
 				$module_srl = $oDocument->get('module_srl');
 				$category_srl = $oDocument->get('category_srl');
 				$thumbnail = $oDocument->getThumbnail();
-				$content_item = new mcontentItem( $args->module_srls_info[$module_srl]->browser_title );
+				$content_item = new mcontentItem($args->module_srls_info[$module_srl]->browser_title);
 				$content_item->adds($oDocument->getObjectVars());
 				$content_item->setTitle($oDocument->getTitleText());
-				$content_item->setCategory( $category_lists[$module_srl][$category_srl]->title );
-				$content_item->setDomain( $args->module_srls_info[$module_srl]->domain );
+				$content_item->setCategory($category_lists[$module_srl][$category_srl]->title);
+				$content_item->setDomain($args->module_srls_info[$module_srl]->domain);
 				$content_item->setContent($oDocument->getSummary($args->content_cut_size));
-				$content_item->setLink( getSiteUrl($domain,'', 'mid',$args->mid_lists[$module_srl], 'document_srl',$document_srl) );
+				$content_item->setLink(getSiteUrl($domain, '', 'mid', $args->mid_lists[$module_srl], 'document_srl', $document_srl));
 				$content_item->setThumbnail($thumbnail);
 				$content_item->add('mid', $args->mid_lists[$module_srl]);
-				if($first_thumbnail_idx==-1 && $thumbnail) $first_thumbnail_idx = $i;
+				if ($first_thumbnail_idx == -1 && $thumbnail) $first_thumbnail_idx = $i;
 				$content_items[] = $content_item;
 			}
 
@@ -276,10 +276,10 @@ 
 		$obj->direct_download = 'Y';
 		$obj->isvalid = 'Y';
 		// Get categories
-		$output = executeQueryArray('widgets.content.getCategories',$obj);
-		if($output->toBool() && $output->data)
+		$output = executeQueryArray('widgets.content.getCategories', $obj);
+		if ($output->toBool() && $output->data)
 		{
-			foreach($output->data as $key => $val)
+			foreach ($output->data as $key => $val)
 			{
 				$category_lists[$val->module_srl][$val->category_srl] = $val;
 			}
@@ -288,24 +288,24 @@ 
 		$obj->list_count = $args->list_count;
 		$files_output = executeQueryArray("file.getOneFileInDocument", $obj);
 		$files_count = count($files_output->data);
-		if(!$files_count) return;
+		if (!$files_count) return;
 
 		$content_items = array();
 
-		for($i=0;$i<$files_count;$i++) $document_srl_list[] = $files_output->data[$i]->document_srl;
+		for ($i = 0; $i < $files_count; $i++) $document_srl_list[] = $files_output->data[$i]->document_srl;
 
 		$tmp_document_list = $oDocumentModel->getDocuments($document_srl_list);
 
-		if(!count($tmp_document_list)) return;
+		if (!count($tmp_document_list)) return;
 
-		foreach($tmp_document_list as $oDocument)
+		foreach ($tmp_document_list as $oDocument)
 		{
 			$attribute = $oDocument->getObjectVars();
 			$browser_title = $args->module_srls_info[$attribute->module_srl]->browser_title;
 			$domain = $args->module_srls_info[$attribute->module_srl]->domain;
 			$category = $category_lists[$attribute->module_srl]->text;
 			$content = $oDocument->getSummary($args->content_cut_size);
-			$url = sprintf("%s#%s",$oDocument->getPermanentUrl() ,$oDocument->getCommentCount());
+			$url = sprintf("%s#%s", $oDocument->getPermanentUrl(), $oDocument->getCommentCount());
 			$thumbnail = $oDocument->getThumbnail();
 			$content_item = new mcontentItem($browser_title);
 			$content_item->adds($attribute);
@@ -327,11 +327,11 @@ 
 		$content_items = array();
 		$args->mid_lists = array();
 
-		foreach($args->rss_urls as $key => $rss)
+		foreach ($args->rss_urls as $key => $rss)
 		{
 			$args->rss_url = $rss;
 			$content_item = $this->_getRssItems($args);
-			if(count($content_item) > 0)
+			if (count($content_item) > 0)
 			{
 				$browser_title = $content_item[0]->getBrowserTitle();
 				$args->mid_lists[] = $browser_title;
@@ -339,40 +339,40 @@ 
 			}
 		}
 
-		if($args->tab_type == 'none' || $args->tab_type == '')
+		if ($args->tab_type == 'none' || $args->tab_type == '')
 		{
 			$items = array();
-			foreach($content_items as $key => $val)
+			foreach ($content_items as $key => $val)
 			{
-				foreach($val as $k => $v)
+				foreach ($val as $k => $v)
 				{
 					$date = $v->get('regdate');
-					$i=0;
-					while(array_key_exists(sprintf('%s%02d',$date,$i), $items)) $i++;
-					$items[sprintf('%s%02d',$date,$i)] = $v;
+					$i = 0;
+					while (array_key_exists(sprintf('%s%02d', $date, $i), $items)) $i++;
+					$items[sprintf('%s%02d', $date, $i)] = $v;
 				}
 			}
-			if($args->order_type =='asc') ksort($items);
+			if ($args->order_type == 'asc') ksort($items);
 			else krsort($items);
-			$content_items = array_slice(array_values($items),0,$args->list_count);
+			$content_items = array_slice(array_values($items), 0, $args->list_count);
 		} return $content_items;
 	}
 
 	function _getRssBody($value)
 	{
-		if(!$value || is_string($value)) return $value;
-		if(is_object($value)) $value = get_object_vars($value);
+		if (!$value || is_string($value)) return $value;
+		if (is_object($value)) $value = get_object_vars($value);
 		$body = null;
-		if(!count($value)) return;
-		foreach($value as $key => $val)
+		if (!count($value)) return;
+		foreach ($value as $key => $val)
 		{
-			if($key == 'body')
+			if ($key == 'body')
 			{
 				$body = $val;
 				continue;
 			}
-			if(is_object($val)||is_array($val)) $body = $this->_getRssBody($val);
-			if($body !== null) return $body;
+			if (is_object($val) || is_array($val)) $body = $this->_getRssBody($val);
+			if ($body !== null) return $body;
 		}
 		return $body;
 	}
@@ -383,17 +383,17 @@ 
 		// Replace tags such as </p> , </div> , </li> and others to a whitespace
 		$content = str_replace(array('</p>', '</div>', '</li>'), ' ', $content);
 		// Remove Tag
-		$content = preg_replace('!<([^>]*?)>!is','', $content);
+		$content = preg_replace('!<([^>]*?)>!is', '', $content);
 		// Replace tags to < , > , " 
-		$content = str_replace(array('&lt;','&gt;','&quot;','&nbsp;'), array('<','>','"',' '), $content);
+		$content = str_replace(array('&lt;', '&gt;', '&quot;', '&nbsp;'), array('<', '>', '"', ' '), $content);
 		// Delete a series of whitespaces
 		$content = preg_replace('/ ( +)/is', ' ', $content);
 		// Truncate string
 		$content = trim(cut_str($content, $str_size, $tail));
 		// Replace back < , > , "  to theoriginal tags
-		$content = str_replace(array('<','>','"'),array('&lt;','&gt;','&quot;'), $content);
+		$content = str_replace(array('<', '>', '"'), array('&lt;', '&gt;', '&quot;'), $content);
 		// Fixed a newline bug on a set of consecutive English letters 
-		$content = preg_replace('/([a-z0-9\+:\/\.\~,\|\!\@\#\$\%\^\&\*\(\)\_]){20}/is',"$0-",$content);
+		$content = preg_replace('/([a-z0-9\+:\/\.\~,\|\!\@\#\$\%\^\&\*\(\)\_]){20}/is', "$0-", $content);
 		return $content; 
 	}
 
@@ -404,7 +404,7 @@ 
 	 */
 	function requestFeedContents($rss_url)
 	{
-		$rss_url = str_replace('&amp;','&',Context::convertEncodingStr($rss_url));
+		$rss_url = str_replace('&amp;', '&', Context::convertEncodingStr($rss_url));
 		return FileHandler::getRemoteResource($rss_url, null, 3, 'GET', 'application/xml');
 	}
 
@@ -416,52 +416,52 @@ 
 		$buff = $this->requestFeedContents($args->rss_url);
 
 		$encoding = preg_match("/<\?xml.*encoding=\"(.+)\".*\?>/i", $buff, $matches);
-		if($encoding && stripos($matches[1], "UTF-8") === FALSE) $buff = Context::convertEncodingStr($buff);
+		if ($encoding && stripos($matches[1], "UTF-8") === FALSE) $buff = Context::convertEncodingStr($buff);
 
 		$buff = preg_replace("/<\?xml.*\?>/i", "", $buff);
 
 		$oXmlParser = new XmlParser();
 		$xml_doc = $oXmlParser->parse($buff);
 		$rss = new stdClass();
-		if($xml_doc->rss)
+		if ($xml_doc->rss)
 		{
 			$rss->title = $xml_doc->rss->channel->title->body;
 			$rss->link = $xml_doc->rss->channel->link->body;
 
 			$items = $xml_doc->rss->channel->item;
 
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if (!$items) return;
+			if ($items && !is_array($items)) $items = array($items);
 
 			$content_items = array();
 
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if ($key >= $args->list_count) break;
 				unset($item);
 				$item = new stdClass();
 
-				foreach($value as $key2 => $value2)
+				foreach ($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if (is_array($value2)) $value2 = array_shift($value2);
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 
 				$content_item = new mcontentItem($rss->title);
 				$content_item->setContentsLink($rss->link);
 				$content_item->setTitle($item->title);
-				$content_item->setNickName(max($item->author,$item->{'dc:creator'}));
+				$content_item->setNickName(max($item->author, $item->{'dc:creator'}));
 				//$content_item->setCategory($item->category);
-				$item->description = preg_replace('!<a href=!is','<a target="_blank" rel="noopener" href=', $item->description);
+				$item->description = preg_replace('!<a href=!is', '<a target="_blank" rel="noopener" href=', $item->description);
 				$content_item->setContent($this->_getSummary($item->description, $args->content_cut_size));
 				$content_item->setLink($item->link);
-				$date = date('YmdHis', strtotime(max($item->pubdate,$item->pubDate,$item->{'dc:date'})));
+				$date = date('YmdHis', strtotime(max($item->pubdate, $item->pubDate, $item->{'dc:date'})));
 				$content_item->setRegdate($date);
 
 				$content_items[] = $content_item;
 			}
 		}
-		else if($xml_doc->{'rdf:rdf'})
+		else if ($xml_doc->{'rdf:rdf'})
 		{
 			// rss1.0 supported (XE's XML is case-insensitive because XML parser converts all to small letters) Fixed by misol
 			$rss->title = $xml_doc->{'rdf:rdf'}->channel->title->body;
@@ -469,102 +469,102 @@ 
 
 			$items = $xml_doc->{'rdf:rdf'}->item;
 
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if (!$items) return;
+			if ($items && !is_array($items)) $items = array($items);
 
 			$content_items = array();
 
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if ($key >= $args->list_count) break;
 				unset($item);
 				$item = new stdClass();
 
-				foreach($value as $key2 => $value2)
+				foreach ($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if (is_array($value2)) $value2 = array_shift($value2);
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 
 				$content_item = new mcontentItem($rss->title);
 				$content_item->setContentsLink($rss->link);
 				$content_item->setTitle($item->title);
-				$content_item->setNickName(max($item->author,$item->{'dc:creator'}));
+				$content_item->setNickName(max($item->author, $item->{'dc:creator'}));
 				//$content_item->setCategory($item->category);
-				$item->description = preg_replace('!<a href=!is','<a target="_blank" rel="noopener" href=', $item->description);
+				$item->description = preg_replace('!<a href=!is', '<a target="_blank" rel="noopener" href=', $item->description);
 				$content_item->setContent($this->_getSummary($item->description, $args->content_cut_size));
 				$content_item->setLink($item->link);
-				$date = date('YmdHis', strtotime(max($item->pubdate,$item->pubDate,$item->{'dc:date'})));
+				$date = date('YmdHis', strtotime(max($item->pubdate, $item->pubDate, $item->{'dc:date'})));
 				$content_item->setRegdate($date);
 
 				$content_items[] = $content_item;
 			}
 		}
-		else if($xml_doc->feed && $xml_doc->feed->attrs->xmlns == 'http://www.w3.org/2005/Atom') 
+		else if ($xml_doc->feed && $xml_doc->feed->attrs->xmlns == 'http://www.w3.org/2005/Atom') 
 			{
 			// Atom 1.0 spec supported by misol
 			$rss->title = $xml_doc->feed->title->body;
 			$links = $xml_doc->feed->link;
-			if(is_array($links))
+			if (is_array($links))
 			{
 				foreach ($links as $value)
 				{
-					if($value->attrs->rel == 'alternate')
+					if ($value->attrs->rel == 'alternate')
 					{
 						$rss->link = $value->attrs->href;
 						break;
 					}
 				}
 			}
-			else if($links->attrs->rel == 'alternate') $rss->link = $links->attrs->href;
+			else if ($links->attrs->rel == 'alternate') $rss->link = $links->attrs->href;
 	
 			$items = $xml_doc->feed->entry;
 	
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if (!$items) return;
+			if ($items && !is_array($items)) $items = array($items);
 	
 			$content_items = array();
 	
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if ($key >= $args->list_count) break;
 				unset($item);
 	
-				foreach($value as $key2 => $value2)
+				foreach ($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if (is_array($value2)) $value2 = array_shift($value2);
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 	
 				$content_item = new mcontentItem($rss->title);
 				$links = $value->link;
-				if(is_array($links))
+				if (is_array($links))
 				{
 					foreach ($links as $val)
 					{
-						if($val->attrs->rel == 'alternate')
+						if ($val->attrs->rel == 'alternate')
 						{
 							$item->link = $val->attrs->href;
 							break;
 						}
 					}
 				}
-				else if($links->attrs->rel == 'alternate') $item->link = $links->attrs->href;
+				else if ($links->attrs->rel == 'alternate') $item->link = $links->attrs->href;
 	
 				$content_item->setContentsLink($rss->link);
-				if($item->title)
+				if ($item->title)
 				{
-					if(stripos($value->title->attrs->type, "html") === FALSE) $item->title = $value->title->body;
+					if (stripos($value->title->attrs->type, "html") === FALSE) $item->title = $value->title->body;
 				}
 				$content_item->setTitle($item->title);
-				$content_item->setNickName(max($item->author,$item->{'dc:creator'}));
+				$content_item->setNickName(max($item->author, $item->{'dc:creator'}));
 				$content_item->setAuthorSite($value->author->uri->body);
 	
 				//$content_item->setCategory($item->category);
 				$item->description = ($item->content) ? $item->content : $item->description = $item->summary;
-				$item->description = preg_replace('!<a href=!is','<a target="_blank" rel="noopener" href=', $item->description);
+				$item->description = preg_replace('!<a href=!is', '<a target="_blank" rel="noopener" href=', $item->description);
 	
-				if(($item->content && stripos($value->content->attrs->type, "html") === FALSE) || (!$item->content && stripos($value->summary->attrs->type, "html") === FALSE))
+				if (($item->content && stripos($value->content->attrs->type, "html") === FALSE) || (!$item->content && stripos($value->summary->attrs->type, "html") === FALSE))
 				{
 					$item->description = htmlspecialchars($item->description, ENT_COMPAT | ENT_HTML401, 'UTF-8', false);
 	
@@ -572,7 +572,7 @@ 
 	
 				$content_item->setContent($this->_getSummary($item->description, $args->content_cut_size));
 				$content_item->setLink($item->link);
-				$date = date('YmdHis', strtotime(max($item->published,$item->updated,$item->{'dc:date'})));
+				$date = date('YmdHis', strtotime(max($item->published, $item->updated, $item->{'dc:date'})));
 				$content_item->setRegdate($date);
 	
 				$content_items[] = $content_item;
@@ -581,12 +581,12 @@ 
 		return $content_items;
 	}
 
-	function _getTrackbackItems($args){
+	function _getTrackbackItems($args) {
 		// Get categories
-		$output = executeQueryArray('widgets.content.getCategories',$obj);
-		if($output->toBool() && $output->data)
+		$output = executeQueryArray('widgets.content.getCategories', $obj);
+		if ($output->toBool() && $output->data)
 		{
-			foreach($output->data as $key => $val) {
+			foreach ($output->data as $key => $val) {
 				$category_lists[$val->module_srl][$val->category_srl] = $val;
 			}
 		}
@@ -598,14 +598,14 @@ 
 		$oTrackbackModel = getModel('trackback');
 		$output = $oTrackbackModel->getNewestTrackbackList($obj);
 		// If an error occurs, just ignore it.
-		if(!$output->toBool() || !$output->data) return;
+		if (!$output->toBool() || !$output->data) return;
 		// If the result exists, make each document as an object
 		$content_items = array();
-		foreach($output->data as $key => $item)
+		foreach ($output->data as $key => $item)
 		{
 			$domain = $args->module_srls_info[$item->module_srl]->domain;
 			$category = $category_lists[$item->module_srl]->text;
-			$url = getSiteUrl($domain,'','mid', $args->mid_lists[$item->module_srl],'document_srl',$item->document_srl);
+			$url = getSiteUrl($domain, '', 'mid', $args->mid_lists[$item->module_srl], 'document_srl', $item->document_srl);
 			$browser_title = $args->module_srls_info[$item->module_srl]->browser_title;
 
 			$content_item = new mcontentItem($browser_title);
@@ -613,8 +613,8 @@ 
 			$content_item->setTitle($item->title);
 			$content_item->setCategory($category);
 			$content_item->setNickName($item->blog_name);
-			$content_item->setContent($item->excerpt);  ///<<
-			$content_item->setDomain($domain);  ///<<
+			$content_item->setContent($item->excerpt); ///<<
+			$content_item->setDomain($domain); ///<<
 			$content_item->setLink($url);
 			$content_item->add('mid', $args->mid_lists[$item->module_srl]);
 			$content_item->setRegdate($item->regdate);
@@ -623,7 +623,7 @@ 
 		return $content_items;
 	}
 
-	function _compile($args,$content_items)
+	function _compile($args, $content_items)
 	{
 		$oTemplate = &TemplateHandler::getInstance();
 		// Set variables for widget
@@ -671,7 +671,7 @@ 
 	var $contents_link = null;
 	var $domain = null;
 
-	function mcontentItem($browser_title='')
+	function mcontentItem($browser_title = '')
 	{
 		$this->browser_title = $browser_title;
 	}
@@ -681,58 +681,58 @@ 
 	}
 	function setFirstThumbnailIdx($first_thumbnail_idx)
 	{
-		if(is_null($this->first_thumbnail) && $first_thumbnail_idx>-1) {
+		if (is_null($this->first_thumbnail) && $first_thumbnail_idx > -1) {
 			$this->has_first_thumbnail_idx = true;
-			$this->first_thumbnail_idx= $first_thumbnail_idx;
+			$this->first_thumbnail_idx = $first_thumbnail_idx;
 		}
 	}
 	function setExtraImages($extra_images)
 	{
-		$this->add('extra_images',$extra_images);
+		$this->add('extra_images', $extra_images);
 	}
 	function setDomain($domain)
 	{
 		static $default_domain = null;
-		if(!$domain)
+		if (!$domain)
 		{
-			if(is_null($default_domain)) $default_domain = Context::getDefaultUrl();
+			if (is_null($default_domain)) $default_domain = Context::getDefaultUrl();
 			$domain = $default_domain;
 		}
 		$this->domain = $domain;
 	}
 	function setLink($url)
 	{
-		$this->add('url',$url);
+		$this->add('url', $url);
 	}
 	function setTitle($title)
 	{
-		$this->add('title',$title);
+		$this->add('title', $title);
 	}
 
 	function setThumbnail($thumbnail)
 	{
-		$this->add('thumbnail',$thumbnail);
+		$this->add('thumbnail', $thumbnail);
 	}
 	function setContent($content)
 	{
-		$this->add('content',$content);
+		$this->add('content', $content);
 	}
 	function setRegdate($regdate)
 	{
-		$this->add('regdate',$regdate);
+		$this->add('regdate', $regdate);
 	}
 	function setNickName($nick_name)
 	{
-		$this->add('nick_name',$nick_name);
+		$this->add('nick_name', $nick_name);
 	}
 	// Save author's homepage url by misol
 	function setAuthorSite($site_url)
 	{
-		$this->add('author_site',$site_url);
+		$this->add('author_site', $site_url);
 	}
 	function setCategory($category)
 	{
-		$this->add('category',$category);
+		$this->add('category', $category);
 	}
 	function getBrowserTitle()
 	{
@@ -760,17 +760,17 @@ 
 	{
 		return $this->get('module_srl');
 	}
-	function getTitle($cut_size = 0, $tail='...')
+	function getTitle($cut_size = 0, $tail = '...')
 	{
 		$title = strip_tags($this->get('title'));
 
-		if($cut_size) $title = cut_str($title, $cut_size, $tail);
+		if ($cut_size) $title = cut_str($title, $cut_size, $tail);
 
 		$attrs = array();
-		if($this->get('title_bold') == 'Y') $attrs[] = 'font-weight:bold';
-		if($this->get('title_color') && $this->get('title_color') != 'N') $attrs[] = 'color:#'.$this->get('title_color');
+		if ($this->get('title_bold') == 'Y') $attrs[] = 'font-weight:bold';
+		if ($this->get('title_color') && $this->get('title_color') != 'N') $attrs[] = 'color:#'.$this->get('title_color');
 
-		if(count($attrs)) $title = sprintf("<span style=\"%s\">%s</span>", implode(';', $attrs), htmlspecialchars($title));
+		if (count($attrs)) $title = sprintf("<span style=\"%s\">%s</span>", implode(';', $attrs), htmlspecialchars($title));
 
 		return $title;
 	}
@@ -793,12 +793,12 @@ 
 	function getCommentCount()
 	{
 		$comment_count = $this->get('comment_count');
-		return $comment_count>0 ? $comment_count : '';
+		return $comment_count > 0 ? $comment_count : '';
 	}
 	function getTrackbackCount()
 	{
 		$trackback_count = $this->get('trackback_count');
-		return $trackback_count>0 ? $trackback_count : '';
+		return $trackback_count > 0 ? $trackback_count : '';
 	}
 	function getRegdate($format = 'Y.m.d H:i:s')
 	{

Braces +137 added lines, -55 removed lines

@@ -18,20 +18,32 @@ 
 	function proc($args)
 	{
 		// Targets to sort
-		if(!in_array($args->order_target, array('list_order','update_order'))) $args->order_target = 'list_order';
+		if(!in_array($args->order_target, array('list_order','update_order'))) {
+			$args->order_target = 'list_order';
+		}
 		// Sort order
-		if(!in_array($args->order_type, array('asc','desc'))) $args->order_type = 'asc';
+		if(!in_array($args->order_type, array('asc','desc'))) {
+			$args->order_type = 'asc';
+		}
 		// The number of displayed lists
 		$args->list_count = (int)$args->list_count;
-		if(!$args->list_count) $args->list_count = 5;
+		if(!$args->list_count) {
+			$args->list_count = 5;
+		}
 		// Cut the length of the title
-		if(!$args->subject_cut_size) $args->subject_cut_size = 0;
+		if(!$args->subject_cut_size) {
+			$args->subject_cut_size = 0;
+		}
 		// Cut the length of contents
-		if(!$args->content_cut_size) $args->content_cut_size = 100;
+		if(!$args->content_cut_size) {
+			$args->content_cut_size = 100;
+		}
 		// Viewing options
 		$args->option_view_arr = explode(',',$args->option_view);
 		// markup options
-		if(!$args->markup_type) $args->markup_type = 'list';
+		if(!$args->markup_type) {
+			$args->markup_type = 'list';
+		}
 		// Set variables for internal use
 		$oModuleModel = getModel('module');
 		$module_srls = $args->modules_info = $args->module_srls_info = $args->mid_lists = array();
@@ -43,11 +55,12 @@ 
 			$rss_urls = array_unique(array($args->rss_url0,$args->rss_url1,$args->rss_url2,$args->rss_url3,$args->rss_url4));
 			for($i=0,$c=count($rss_urls);$i<$c;$i++)
 			{
-				if($rss_urls[$i]) $args->rss_urls[] = $rss_urls[$i];
+				if($rss_urls[$i]) {
+					$args->rss_urls[] = $rss_urls[$i];
+				}
 			}
 			// Get module information after listing module_srls if the module is not RSS
-		}
-		else
+		} else
 		{
 			$obj = new stdClass();
 			// Apply to all modules in the site if a target module is not specified
@@ -68,8 +81,7 @@ 
 
 				$args->modules_info = $oModuleModel->getMidList($obj);
 				// Apply to the module only if a target module is specified
-			}
-			else
+			} else
 			{
 				$obj->module_srls = $args->module_srls;
 				$output = executeQueryArray('widgets.content.getMids', $obj);
@@ -85,13 +97,17 @@ 
 					for($i=0,$c=count($idx);$i<$c;$i++)
 					{
 						$srl = $idx[$i];
-						if(!$args->module_srls_info[$srl]) continue;
+						if(!$args->module_srls_info[$srl]) {
+							continue;
+						}
 						$args->mid_lists[$srl] = $args->module_srls_info[$srl]->mid;
 					}
 				}
 			}
 			// Exit if no module is found
-			if(!count($args->modules_info)) return Context::get('msg_not_founded');
+			if(!count($args->modules_info)) {
+				return Context::get('msg_not_founded');
+			}
 			$args->module_srl = implode(',',$module_srls);
 		}
 
@@ -120,8 +136,7 @@ 
 					break;
 			}
 			// If not a tab type
-		}
-		else
+		} else
 		{
 			$content_items = array();
 
@@ -180,7 +195,9 @@ 
 
 		$content_items = array();
 
-		if(!count($output)) return;
+		if(!count($output)) {
+			return;
+		}
 
 		foreach($output as $key => $oComment)
 		{
@@ -227,7 +244,9 @@ 
 		$obj->list_count = $args->list_count;
 		$obj->statusList = array('PUBLIC');
 		$output = executeQueryArray('widgets.content.getNewestDocuments', $obj);
-		if(!$output->toBool() || !$output->data) return;
+		if(!$output->toBool() || !$output->data) {
+			return;
+		}
 		// If the result exists, make each document as an object
 		$content_items = array();
 		$first_thumbnail_idx = -1;
@@ -258,7 +277,9 @@ 
 				$content_item->setLink( getSiteUrl($domain,'', 'mid',$args->mid_lists[$module_srl], 'document_srl',$document_srl) );
 				$content_item->setThumbnail($thumbnail);
 				$content_item->add('mid', $args->mid_lists[$module_srl]);
-				if($first_thumbnail_idx==-1 && $thumbnail) $first_thumbnail_idx = $i;
+				if($first_thumbnail_idx==-1 && $thumbnail) {
+					$first_thumbnail_idx = $i;
+				}
 				$content_items[] = $content_item;
 			}
 
@@ -288,15 +309,21 @@ 
 		$obj->list_count = $args->list_count;
 		$files_output = executeQueryArray("file.getOneFileInDocument", $obj);
 		$files_count = count($files_output->data);
-		if(!$files_count) return;
+		if(!$files_count) {
+			return;
+		}
 
 		$content_items = array();
 
-		for($i=0;$i<$files_count;$i++) $document_srl_list[] = $files_output->data[$i]->document_srl;
+		for($i=0;$i<$files_count;$i++) {
+			$document_srl_list[] = $files_output->data[$i]->document_srl;
+		}
 
 		$tmp_document_list = $oDocumentModel->getDocuments($document_srl_list);
 
-		if(!count($tmp_document_list)) return;
+		if(!count($tmp_document_list)) {
+			return;
+		}
 
 		foreach($tmp_document_list as $oDocument)
 		{
@@ -348,22 +375,33 @@ 
 				{
 					$date = $v->get('regdate');
 					$i=0;
-					while(array_key_exists(sprintf('%s%02d',$date,$i), $items)) $i++;
+					while(array_key_exists(sprintf('%s%02d',$date,$i), $items)) {
+						$i++;
+					}
 					$items[sprintf('%s%02d',$date,$i)] = $v;
 				}
 			}
-			if($args->order_type =='asc') ksort($items);
-			else krsort($items);
+			if($args->order_type =='asc') {
+				ksort($items);
+			} else {
+				krsort($items);
+			}
 			$content_items = array_slice(array_values($items),0,$args->list_count);
 		} return $content_items;
 	}
 
 	function _getRssBody($value)
 	{
-		if(!$value || is_string($value)) return $value;
-		if(is_object($value)) $value = get_object_vars($value);
+		if(!$value || is_string($value)) {
+			return $value;
+		}
+		if(is_object($value)) {
+			$value = get_object_vars($value);
+		}
 		$body = null;
-		if(!count($value)) return;
+		if(!count($value)) {
+			return;
+		}
 		foreach($value as $key => $val)
 		{
 			if($key == 'body')
@@ -371,8 +409,12 @@ 
 				$body = $val;
 				continue;
 			}
-			if(is_object($val)||is_array($val)) $body = $this->_getRssBody($val);
-			if($body !== null) return $body;
+			if(is_object($val)||is_array($val)) {
+				$body = $this->_getRssBody($val);
+			}
+			if($body !== null) {
+				return $body;
+			}
 		}
 		return $body;
 	}
@@ -416,7 +458,9 @@ 
 		$buff = $this->requestFeedContents($args->rss_url);
 
 		$encoding = preg_match("/<\?xml.*encoding=\"(.+)\".*\?>/i", $buff, $matches);
-		if($encoding && stripos($matches[1], "UTF-8") === FALSE) $buff = Context::convertEncodingStr($buff);
+		if($encoding && stripos($matches[1], "UTF-8") === FALSE) {
+			$buff = Context::convertEncodingStr($buff);
+		}
 
 		$buff = preg_replace("/<\?xml.*\?>/i", "", $buff);
 
@@ -430,20 +474,28 @@ 
 
 			$items = $xml_doc->rss->channel->item;
 
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if(!$items) {
+				return;
+			}
+			if($items && !is_array($items)) {
+				$items = array($items);
+			}
 
 			$content_items = array();
 
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if($key >= $args->list_count) {
+					break;
+				}
 				unset($item);
 				$item = new stdClass();
 
 				foreach($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if(is_array($value2)) {
+						$value2 = array_shift($value2);
+					}
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 
@@ -460,8 +512,7 @@ 
 
 				$content_items[] = $content_item;
 			}
-		}
-		else if($xml_doc->{'rdf:rdf'})
+		} else if($xml_doc->{'rdf:rdf'})
 		{
 			// rss1.0 supported (XE's XML is case-insensitive because XML parser converts all to small letters) Fixed by misol
 			$rss->title = $xml_doc->{'rdf:rdf'}->channel->title->body;
@@ -469,20 +520,28 @@ 
 
 			$items = $xml_doc->{'rdf:rdf'}->item;
 
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if(!$items) {
+				return;
+			}
+			if($items && !is_array($items)) {
+				$items = array($items);
+			}
 
 			$content_items = array();
 
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if($key >= $args->list_count) {
+					break;
+				}
 				unset($item);
 				$item = new stdClass();
 
 				foreach($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if(is_array($value2)) {
+						$value2 = array_shift($value2);
+					}
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 
@@ -499,8 +558,7 @@ 
 
 				$content_items[] = $content_item;
 			}
-		}
-		else if($xml_doc->feed && $xml_doc->feed->attrs->xmlns == 'http://www.w3.org/2005/Atom') 
+		} else if($xml_doc->feed && $xml_doc->feed->attrs->xmlns == 'http://www.w3.org/2005/Atom') 
 			{
 			// Atom 1.0 spec supported by misol
 			$rss->title = $xml_doc->feed->title->body;
@@ -515,24 +573,33 @@ 
 						break;
 					}
 				}
+			} else if($links->attrs->rel == 'alternate') {
+				$rss->link = $links->attrs->href;
 			}
-			else if($links->attrs->rel == 'alternate') $rss->link = $links->attrs->href;
 	
 			$items = $xml_doc->feed->entry;
 	
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if(!$items) {
+				return;
+			}
+			if($items && !is_array($items)) {
+				$items = array($items);
+			}
 	
 			$content_items = array();
 	
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if($key >= $args->list_count) {
+					break;
+				}
 				unset($item);
 	
 				foreach($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if(is_array($value2)) {
+						$value2 = array_shift($value2);
+					}
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 	
@@ -548,13 +615,16 @@ 
 							break;
 						}
 					}
+				} else if($links->attrs->rel == 'alternate') {
+					$item->link = $links->attrs->href;
 				}
-				else if($links->attrs->rel == 'alternate') $item->link = $links->attrs->href;
 	
 				$content_item->setContentsLink($rss->link);
 				if($item->title)
 				{
-					if(stripos($value->title->attrs->type, "html") === FALSE) $item->title = $value->title->body;
+					if(stripos($value->title->attrs->type, "html") === FALSE) {
+						$item->title = $value->title->body;
+					}
 				}
 				$content_item->setTitle($item->title);
 				$content_item->setNickName(max($item->author,$item->{'dc:creator'}));
@@ -598,7 +668,9 @@ 
 		$oTrackbackModel = getModel('trackback');
 		$output = $oTrackbackModel->getNewestTrackbackList($obj);
 		// If an error occurs, just ignore it.
-		if(!$output->toBool() || !$output->data) return;
+		if(!$output->toBool() || !$output->data) {
+			return;
+		}
 		// If the result exists, make each document as an object
 		$content_items = array();
 		foreach($output->data as $key => $item)
@@ -695,7 +767,9 @@ 
 		static $default_domain = null;
 		if(!$domain)
 		{
-			if(is_null($default_domain)) $default_domain = Context::getDefaultUrl();
+			if(is_null($default_domain)) {
+				$default_domain = Context::getDefaultUrl();
+			}
 			$domain = $default_domain;
 		}
 		$this->domain = $domain;
@@ -764,13 +838,21 @@ 
 	{
 		$title = strip_tags($this->get('title'));
 
-		if($cut_size) $title = cut_str($title, $cut_size, $tail);
+		if($cut_size) {
+			$title = cut_str($title, $cut_size, $tail);
+		}
 
 		$attrs = array();
-		if($this->get('title_bold') == 'Y') $attrs[] = 'font-weight:bold';
-		if($this->get('title_color') && $this->get('title_color') != 'N') $attrs[] = 'color:#'.$this->get('title_color');
+		if($this->get('title_bold') == 'Y') {
+			$attrs[] = 'font-weight:bold';
+		}
+		if($this->get('title_color') && $this->get('title_color') != 'N') {
+			$attrs[] = 'color:#'.$this->get('title_color');
+		}
 
-		if(count($attrs)) $title = sprintf("<span style=\"%s\">%s</span>", implode(';', $attrs), htmlspecialchars($title));
+		if(count($attrs)) {
+			$title = sprintf("<span style=\"%s\">%s</span>", implode(';', $attrs), htmlspecialchars($title));
+		}
 
 		return $title;
 	}

classes/db/DBCubrid.class.php

Doc Comments +5 added lines, -5 removed lines

@@ -477,7 +477,7 @@ 
 	 * @param int $size column size
 	 * @param string|int $default default value
 	 * @param boolean $notnull not null status, default value is false
-	 * @return void
+	 * @return resource|null
 	 */
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = FALSE)
 	{
@@ -693,7 +693,7 @@ 
 	/**
 	 * Creates a table by using xml contents
 	 * @param string $xml_doc xml schema contents
-	 * @return void|object
+	 * @return null|resource
 	 */
 	function createTableByXml($xml_doc)
 	{
@@ -703,7 +703,7 @@ 
 	/**
 	 * Creates a table by using xml file path
 	 * @param string $file_name xml schema file path
-	 * @return void|object
+	 * @return null|resource
 	 */
 	function createTableByXmlFile($file_name)
 	{
@@ -723,7 +723,7 @@ 
 	 * opt : notnull, default, size\n
 	 * index : primary key, index, unique\n
 	 * @param string $xml_doc xml schema contents
-	 * @return void|object
+	 * @return null|resource
 	 */
 	function _createTable($xml_doc)
 	{
@@ -1125,7 +1125,7 @@ 
 
 	/**
 	 * If select query execute, return paging sql
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @param int $start_count
 	 * @param int $list_count

Spacing +141 added lines, -141 removed lines

@@ -52,7 +52,7 @@ 
 	function DBCubrid($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if ($auto_connect) $this->_connect();
 	}
 
 	/**
@@ -76,21 +76,21 @@ 
 		$result = @cubrid_connect($connection["db_hostname"], $connection["db_port"], $connection["db_database"], $connection["db_userid"], $connection["db_password"]);
 
 		// check connections
-		if(!$result)
+		if (!$result)
 		{
 			$this->setError(-1, 'database connect fail');
 			return;
 		}
 
-		if(!defined('__CUBRID_VERSION__'))
+		if (!defined('__CUBRID_VERSION__'))
 		{
 			$cubrid_version = cubrid_get_server_info($result);
 			$cubrid_version_elem = explode('.', $cubrid_version);
-			$cubrid_version = $cubrid_version_elem[0] . '.' . $cubrid_version_elem[1] . '.' . $cubrid_version_elem[2];
+			$cubrid_version = $cubrid_version_elem[0].'.'.$cubrid_version_elem[1].'.'.$cubrid_version_elem[2];
 			define('__CUBRID_VERSION__', $cubrid_version);
 		}
 
-		if(__CUBRID_VERSION__ >= '8.4.0')
+		if (__CUBRID_VERSION__ >= '8.4.0')
 			cubrid_set_autocommit($result, CUBRID_AUTOCOMMIT_TRUE);
 
 		return $result;
@@ -116,13 +116,13 @@ 
 	 */
 	function addQuotes($string)
 	{
-		if(version_compare(PHP_VERSION, "5.4.0", "<") &&
+		if (version_compare(PHP_VERSION, "5.4.0", "<") &&
 				get_magic_quotes_gpc())
 		{
 			$string = stripslashes(str_replace("\\", "\\\\", $string));
 		}
 
-		if(!is_numeric($string))
+		if (!is_numeric($string))
 		{
 			/*
 			  if ($this->isConnected()) {
@@ -146,17 +146,17 @@ 
 	 */
 	function _begin($transactionLevel = 0)
 	{
-		if(__CUBRID_VERSION__ >= '8.4.0')
+		if (__CUBRID_VERSION__ >= '8.4.0')
 		{
 			$connection = $this->_getConnection('master');
 
-			if(!$transactionLevel)
+			if (!$transactionLevel)
 			{
 				cubrid_set_autocommit($connection, CUBRID_AUTOCOMMIT_FALSE);
 			}
 			else
 			{
-				$this->_query("SAVEPOINT SP" . $transactionLevel, $connection);
+				$this->_query("SAVEPOINT SP".$transactionLevel, $connection);
 			}
 		}
 		return TRUE;
@@ -173,9 +173,9 @@ 
 
 		$point = $transactionLevel - 1;
 
-		if($point)
+		if ($point)
 		{
-			$this->_query("ROLLBACK TO SP" . $point, $connection);
+			$this->_query("ROLLBACK TO SP".$point, $connection);
 		}
 		else
 		{
@@ -206,29 +206,29 @@ 
 	 */
 	function __query($query, $connection)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$req = @cubrid_prepare($connection, $query);
-			if(!$req)
+			if (!$req)
 			{
 				$this->_setError();
 				return false;
 			}
 
 			$position = 0;
-			if($this->param)
+			if ($this->param)
 			{
-				foreach($this->param as $param)
+				foreach ($this->param as $param)
 				{
 					$value = $param->getUnescapedValue();
 					$type = $param->getType();
 
-					if($param->isColumnName())
+					if ($param->isColumnName())
 					{
 						continue;
 					}
 
-					switch($type)
+					switch ($type)
 					{
 						case 'number' :
 							$bind_type = 'numeric';
@@ -240,12 +240,12 @@ 
 							$bind_type = 'string';
 					}
 
-					if(is_array($value))
+					if (is_array($value))
 					{
-						foreach($value as $v)
+						foreach ($value as $v)
 						{
 							$bound = @cubrid_bind($req, ++$position, $v, $bind_type);
-							if(!$bound)
+							if (!$bound)
 							{
 								$this->_setError();
 								return false;
@@ -255,7 +255,7 @@ 
 					else
 					{
 						$bound = @cubrid_bind($req, ++$position, $value, $bind_type);
-						if(!$bound)
+						if (!$bound)
 						{
 							$this->_setError();
 							return false;
@@ -265,7 +265,7 @@ 
 			}
 
 			$result = @cubrid_execute($req);
-			if(!$result)
+			if (!$result)
 			{
 				$this->_setError();
 				return false;
@@ -275,7 +275,7 @@ 
 		// Execute the query
 		$result = @cubrid_execute($connection, $query);
 		// error check
-		if(!$result)
+		if (!$result)
 		{
 			$this->_setError();
 			return false;
@@ -306,12 +306,12 @@ 
 	function _fetch($result, $arrayIndexEndValue = NULL)
 	{
 		$output = array();
-		if(!$this->isConnected() || $this->isError() || !$result)
+		if (!$this->isConnected() || $this->isError() || !$result)
 		{
 			return array();
 		}
 
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 
 		}
@@ -322,25 +322,25 @@ 
 		$col_names = cubrid_column_names($result);
 		$max = count($col_types);
 
-		for($count = 0; $count < $max; $count++)
+		for ($count = 0; $count < $max; $count++)
 		{
-			if(preg_match("/^char/", $col_types[$count]) > 0)
+			if (preg_match("/^char/", $col_types[$count]) > 0)
 			{
 				$char_type_fields[] = $col_names[$count];
 			}
 		}
 
-		while($tmp = cubrid_fetch($result, CUBRID_OBJECT))
+		while ($tmp = cubrid_fetch($result, CUBRID_OBJECT))
 		{
-			if(is_array($char_type_fields))
+			if (is_array($char_type_fields))
 			{
-				foreach($char_type_fields as $val)
+				foreach ($char_type_fields as $val)
 				{
 					$tmp->{$val} = rtrim($tmp->{$val});
 				}
 			}
 
-			if($arrayIndexEndValue)
+			if ($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $tmp;
 			}
@@ -352,15 +352,15 @@ 
 
 		unset($char_type_fields);
 
-		if($result)
+		if ($result)
 		{
 			cubrid_close_request($result);
 		}
 
-		if(count($output) == 1)
+		if (count($output) == 1)
 		{
 			// If call is made for pagination, always return array
-			if(isset($arrayIndexEndValue))
+			if (isset($arrayIndexEndValue))
 			{
 				return $output;
 			}
@@ -395,7 +395,7 @@ 
 	 */
 	function _makeSequence()
 	{
-		if($_GLOBALS['XE_EXISTS_SEQUENCE'])
+		if ($_GLOBALS['XE_EXISTS_SEQUENCE'])
 			return;
 
 		// check cubrid serial
@@ -404,21 +404,21 @@ 
 		$output = $this->_fetch($result);
 
 		// if do not create serial
-		if($output->count == 0)
-		{
-			$query = sprintf('select max("a"."srl") as "srl" from ' .
-					'( select max("document_srl") as "srl" from ' .
-					'"%sdocuments" UNION ' .
-					'select max("comment_srl") as "srl" from ' .
-					'"%scomments" UNION ' .
-					'select max("member_srl") as "srl" from ' .
-					'"%smember"' .
+		if ($output->count == 0)
+		{
+			$query = sprintf('select max("a"."srl") as "srl" from '.
+					'( select max("document_srl") as "srl" from '.
+					'"%sdocuments" UNION '.
+					'select max("comment_srl") as "srl" from '.
+					'"%scomments" UNION '.
+					'select max("member_srl") as "srl" from '.
+					'"%smember"'.
 					') as "a"', $this->prefix, $this->prefix, $this->prefix);
 
 			$result = $this->_query($query);
 			$output = $this->_fetch($result);
 			$srl = $output->srl;
-			if($srl < 1)
+			if ($srl < 1)
 			{
 				$start = 1;
 			}
@@ -442,7 +442,7 @@ 
 	 */
 	function isTableExists($target_name)
 	{
-		if($target_name == 'sequence')
+		if ($target_name == 'sequence')
 		{
 			$query = sprintf("select \"name\" from \"db_serial\" where \"name\" = '%s%s'", $this->prefix, $target_name);
 		}
@@ -452,7 +452,7 @@ 
 		}
 
 		$result = $this->_query($query);
-		if(cubrid_num_rows($result) > 0)
+		if (cubrid_num_rows($result) > 0)
 		{
 			$output = TRUE;
 		}
@@ -461,7 +461,7 @@ 
 			$output = FALSE;
 		}
 
-		if($result)
+		if ($result)
 		{
 			cubrid_close_request($result);
 		}
@@ -482,22 +482,22 @@ 
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = FALSE)
 	{
 		$type = strtoupper($this->column_type[$type]);
-		if($type == 'INTEGER')
+		if ($type == 'INTEGER')
 		{
 			$size = '';
 		}
 
 		$query = sprintf("alter class \"%s%s\" add \"%s\" ", $this->prefix, $table_name, $column_name);
 
-		if($type == 'char' || $type == 'varchar')
+		if ($type == 'char' || $type == 'varchar')
 		{
-			if($size)
+			if ($size)
 			{
 				$size = $size * 3;
 			}
 		}
 
-		if($size)
+		if ($size)
 		{
 			$query .= sprintf("%s(%s) ", $type, $size);
 		}
@@ -506,9 +506,9 @@ 
 			$query .= sprintf("%s ", $type);
 		}
 
-		if(isset($default))
+		if (isset($default))
 		{
-			if($type == 'INTEGER' || $type == 'BIGINT' || $type == 'INT')
+			if ($type == 'INTEGER' || $type == 'BIGINT' || $type == 'INT')
 			{
 				$query .= sprintf("default %d ", $default);
 			}
@@ -518,7 +518,7 @@ 
 			}
 		}
 
-		if($notnull)
+		if ($notnull)
 		{
 			$query .= "not null ";
 		}
@@ -547,10 +547,10 @@ 
 	 */
 	function isColumnExists($table_name, $column_name)
 	{
-		$query = sprintf("select \"attr_name\" from \"db_attribute\" where " . "\"attr_name\" ='%s' and \"class_name\" = '%s%s'", $column_name, $this->prefix, $table_name);
+		$query = sprintf("select \"attr_name\" from \"db_attribute\" where "."\"attr_name\" ='%s' and \"class_name\" = '%s%s'", $column_name, $this->prefix, $table_name);
 		$result = $this->_query($query);
 
-		if(cubrid_num_rows($result) > 0)
+		if (cubrid_num_rows($result) > 0)
 		{
 			$output = TRUE;
 		}
@@ -559,7 +559,7 @@ 
 			$output = FALSE;
 		}
 
-		if($result)
+		if ($result)
 		{
 			cubrid_close_request($result);
 		}
@@ -579,12 +579,12 @@ 
 	 */
 	function addIndex($table_name, $index_name, $target_columns, $is_unique = FALSE)
 	{
-		if(!is_array($target_columns))
+		if (!is_array($target_columns))
 		{
 			$target_columns = array($target_columns);
 		}
 
-		$query = sprintf("create %s index \"%s\" on \"%s%s\" (%s);", $is_unique ? 'unique' : '', $index_name, $this->prefix, $table_name, '"' . implode('","', $target_columns) . '"');
+		$query = sprintf("create %s index \"%s\" on \"%s%s\" (%s);", $is_unique ? 'unique' : '', $index_name, $this->prefix, $table_name, '"'.implode('","', $target_columns).'"');
 
 		$this->_query($query);
 	}
@@ -611,17 +611,17 @@ 
 	 */
 	function isIndexExists($table_name, $index_name)
 	{
-		$query = sprintf("select \"index_name\" from \"db_index\" where " . "\"class_name\" = '%s%s' and (\"index_name\" = '%s' or \"index_name\" = '%s') ", $this->prefix, $table_name, $this->prefix . $index_name, $index_name);
+		$query = sprintf("select \"index_name\" from \"db_index\" where "."\"class_name\" = '%s%s' and (\"index_name\" = '%s' or \"index_name\" = '%s') ", $this->prefix, $table_name, $this->prefix.$index_name, $index_name);
 		$result = $this->_query($query);
 
-		if($this->isError())
+		if ($this->isError())
 		{
 			return FALSE;
 		}
 
 		$output = $this->_fetch($result);
 
-		if(!$output)
+		if (!$output)
 		{
 			return FALSE;
 		}
@@ -653,25 +653,25 @@ 
 				", strlen($this->prefix)
 				, $this->prefix
 				, strlen($this->prefix) + 1
-				, "'" . $this->prefix . '%' . "'"
+				, "'".$this->prefix.'%'."'"
 				, strlen($this->prefix)
 				, $this->prefix
 				, strlen($this->prefix) + 1
 		);
 		$result = $this->_query($query);
 
-		if($this->isError())
+		if ($this->isError())
 		{
 			return FALSE;
 		}
 
 		$output = $this->_fetch($result);
-		if(!$output)
+		if (!$output)
 		{
 			return FALSE;
 		}
 
-		if(!is_array($output))
+		if (!is_array($output))
 		{
 			$indexes_to_be_deleted = array($output);
 		}
@@ -680,10 +680,10 @@ 
 			$indexes_to_be_deleted = $output;
 		}
 
-		foreach($indexes_to_be_deleted as $index)
+		foreach ($indexes_to_be_deleted as $index)
 		{
 			$this->dropIndex(substr($index->class_name, strlen($this->prefix))
-					, $this->prefix . $index->unprefixed_index_name
+					, $this->prefix.$index->unprefixed_index_name
 					, $index->is_unique == 'YES' ? TRUE : FALSE);
 		}
 
@@ -707,7 +707,7 @@ 
 	 */
 	function createTableByXmlFile($file_name)
 	{
-		if(!file_exists($file_name))
+		if (!file_exists($file_name))
 		{
 			return;
 		}
@@ -734,28 +734,28 @@ 
 		$table_name = $xml_obj->table->attrs->name;
 
 		// if the table already exists exit function
-		if($this->isTableExists($table_name))
+		if ($this->isTableExists($table_name))
 		{
 			return;
 		}
 
 		// If the table name is sequence, it creates a serial
-		if($table_name == 'sequence')
+		if ($table_name == 'sequence')
 		{
-			$query = sprintf('create serial "%s" start with 1 increment by 1' .
-					' minvalue 1 ' .
-					'maxvalue 10000000000000000000000000000000000000' . ' nocycle;', $this->prefix . $table_name);
+			$query = sprintf('create serial "%s" start with 1 increment by 1'.
+					' minvalue 1 '.
+					'maxvalue 10000000000000000000000000000000000000'.' nocycle;', $this->prefix.$table_name);
 
 			return $this->_query($query);
 		}
 
 
-		$table_name = $this->prefix . $table_name;
+		$table_name = $this->prefix.$table_name;
 
 		$query = sprintf('create class "%s";', $table_name);
 		$this->_query($query);
 
-		if(!is_array($xml_obj->table->column))
+		if (!is_array($xml_obj->table->column))
 		{
 			$columns[] = $xml_obj->table->column;
 		}
@@ -770,7 +770,7 @@ 
 		$unique_list = array();
 		$index_list = array();
 
-		foreach($columns as $column)
+		foreach ($columns as $column)
 		{
 			$name = $column->attrs->name;
 			$type = $column->attrs->type;
@@ -781,7 +781,7 @@ 
 			$unique = $column->attrs->unique;
 			$default = $column->attrs->default;
 
-			switch($this->column_type[$type])
+			switch ($this->column_type[$type])
 			{
 				case 'integer' :
 					$size = NULL;
@@ -791,58 +791,58 @@ 
 					break;
 			}
 
-			if(isset($default) && ($type == 'varchar' || $type == 'char' ||
+			if (isset($default) && ($type == 'varchar' || $type == 'char' ||
 					$type == 'text' || $type == 'tinytext' || $type == 'bigtext'))
 			{
 				$default = sprintf("'%s'", $default);
 			}
 
-			if($type == 'varchar' || $type == 'char')
+			if ($type == 'varchar' || $type == 'char')
 			{
-				if($size)
+				if ($size)
 					$size = $size * 3;
 			}
 
 
-			$column_schema[] = sprintf('"%s" %s%s %s %s', $name, $this->column_type[$type], $size ? '(' . $size . ')' : '', isset($default) ? "default " . $default : '', $notnull ? 'not null' : '');
+			$column_schema[] = sprintf('"%s" %s%s %s %s', $name, $this->column_type[$type], $size ? '('.$size.')' : '', isset($default) ? "default ".$default : '', $notnull ? 'not null' : '');
 
-			if($primary_key)
+			if ($primary_key)
 			{
 				$primary_list[] = $name;
 			}
-			else if($unique)
+			else if ($unique)
 			{
 				$unique_list[$unique][] = $name;
 			}
-			else if($index)
+			else if ($index)
 			{
 				$index_list[$index][] = $name;
 			}
 		}
 
-		$query .= implode(',', $column_schema) . ';';
+		$query .= implode(',', $column_schema).';';
 		$this->_query($query);
 
-		if(count($primary_list))
+		if (count($primary_list))
 		{
-			$query = sprintf("alter class \"%s\" add attribute constraint " . "\"pkey_%s\" PRIMARY KEY(%s);", $table_name, $table_name, '"' . implode('","', $primary_list) . '"');
+			$query = sprintf("alter class \"%s\" add attribute constraint "."\"pkey_%s\" PRIMARY KEY(%s);", $table_name, $table_name, '"'.implode('","', $primary_list).'"');
 			$this->_query($query);
 		}
 
-		if(count($unique_list))
+		if (count($unique_list))
 		{
-			foreach($unique_list as $key => $val)
+			foreach ($unique_list as $key => $val)
 			{
-				$query = sprintf("create unique index \"%s\" on \"%s\" " . "(%s);", $key, $table_name, '"' . implode('","', $val) . '"');
+				$query = sprintf("create unique index \"%s\" on \"%s\" "."(%s);", $key, $table_name, '"'.implode('","', $val).'"');
 				$this->_query($query);
 			}
 		}
 
-		if(count($index_list))
+		if (count($index_list))
 		{
-			foreach($index_list as $key => $val)
+			foreach ($index_list as $key => $val)
 			{
-				$query = sprintf("create index \"%s\" on \"%s\" (%s);", $key, $table_name, '"' . implode('","', $val) . '"');
+				$query = sprintf("create index \"%s\" on \"%s\" (%s);", $key, $table_name, '"'.implode('","', $val).'"');
 				$this->_query($query);
 			}
 		}
@@ -856,22 +856,22 @@ 
 	 */
 	function _executeInsertAct($queryObject, $with_values = TRUE)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$this->param = $queryObject->getArguments();
 			$with_values = FALSE;
 		}
 		$query = $this->getInsertSql($queryObject, $with_values);
-		if(is_a($query, 'BaseObject'))
+		if (is_a($query, 'BaseObject'))
 		{
 			unset($this->param);
 			return;
 		}
 
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 
 		$result = $this->_query($query);
-		if($result && !$this->transaction_started)
+		if ($result && !$this->transaction_started)
 		{
 			$this->_commit();
 		}
@@ -887,23 +887,23 @@ 
 	 */
 	function _executeUpdateAct($queryObject, $with_values = TRUE)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$this->param = $queryObject->getArguments();
 			$with_values = FALSE;
 		}
 		$query = $this->getUpdateSql($queryObject, $with_values);
-		if(is_a($query, 'BaseObject'))
+		if (is_a($query, 'BaseObject'))
 		{
 			unset($this->param);
 			return;
 		}
 
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 
 		$result = $this->_query($query);
 
-		if($result && !$this->transaction_started)
+		if ($result && !$this->transaction_started)
 		{
 			$this->_commit();
 		}
@@ -919,23 +919,23 @@ 
 	 */
 	function _executeDeleteAct($queryObject, $with_values = TRUE)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$this->param = $queryObject->getArguments();
 			$with_values = FALSE;
 		}
 		$query = $this->getDeleteSql($queryObject, $with_values);
-		if(is_a($query, 'BaseObject'))
+		if (is_a($query, 'BaseObject'))
 		{
 			unset($this->param);
 			return;
 		}
 
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 
 		$result = $this->_query($query);
 
-		if($result && !$this->transaction_started)
+		if ($result && !$this->transaction_started)
 		{
 			$this->_commit();
 		}
@@ -955,29 +955,29 @@ 
 	 */
 	function _executeSelectAct($queryObject, $connection = NULL, $with_values = TRUE)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$this->param = $queryObject->getArguments();
 			$with_values = FALSE;
 		}
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			return $this->queryPageLimit($queryObject, $connection, $with_values);
 		}
 		else
 		{
 			$query = $this->getSelectSql($queryObject, $with_values);
-			if(is_a($query, 'BaseObject'))
+			if (is_a($query, 'BaseObject'))
 			{
 				unset($this->param);
 				return;
 			}
 
-			$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+			$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 			$result = $this->_query($query, $connection);
 
-			if($this->isError())
+			if ($this->isError())
 			{
 				unset($this->param);
 				return $this->queryError($queryObject);
@@ -1000,16 +1000,16 @@ 
 	function queryError($queryObject)
 	{
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
-			$buff = new BaseObject ();
+			$buff = new BaseObject();
 			$buff->total_count = 0;
 			$buff->total_page = 0;
 			$buff->page = 1;
 			$buff->data = array();
 			$buff->page_navigation = new PageHandler(/* $total_count */0, /* $total_page */1, /* $page */1, /* $page_count */10); //default page handler values
 			return $buff;
-		}else
+		} else
 			return;
 	}
 
@@ -1025,48 +1025,48 @@ 
 		$limit = $queryObject->getLimit();
 		// Total count
 		$temp_where = $queryObject->getWhereString($with_values, FALSE);
-		$count_query = sprintf('select count(*) as "count" %s %s', 'FROM ' . $queryObject->getFromString($with_values), ($temp_where === '' ? '' : ' WHERE ' . $temp_where));
+		$count_query = sprintf('select count(*) as "count" %s %s', 'FROM '.$queryObject->getFromString($with_values), ($temp_where === '' ? '' : ' WHERE '.$temp_where));
 
 		// Check for distinct query and if found update count query structure
 		$temp_select = $queryObject->getSelectString($with_values);
 		$uses_distinct = stripos($temp_select, "distinct") !== FALSE;
 		$uses_groupby = $queryObject->getGroupByString() != '';
-		if($uses_distinct || $uses_groupby)
+		if ($uses_distinct || $uses_groupby)
 		{
 			$count_query = sprintf('select %s %s %s %s'
 					, $temp_select
-					, 'FROM ' . $queryObject->getFromString($with_values)
-					, ($temp_where === '' ? '' : ' WHERE ' . $temp_where)
-					, ($uses_groupby ? ' GROUP BY ' . $queryObject->getGroupByString() : '')
+					, 'FROM '.$queryObject->getFromString($with_values)
+					, ($temp_where === '' ? '' : ' WHERE '.$temp_where)
+					, ($uses_groupby ? ' GROUP BY '.$queryObject->getGroupByString() : '')
 			);
 
 			// If query uses grouping or distinct, count from original select
 			$count_query = sprintf('select count(*) as "count" from (%s) xet', $count_query);
 		}
 
-		$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' ' . $this->comment_syntax, $queryObject->queryID) : '';
+		$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' '.$this->comment_syntax, $queryObject->queryID) : '';
 		$result = $this->_query($count_query, $connection);
 		$count_output = $this->_fetch($result);
 		$total_count = (int) (isset($count_output->count) ? $count_output->count : NULL);
 
 		$list_count = $limit->list_count->getValue();
-		if(!$list_count)
+		if (!$list_count)
 		{
 			$list_count = 20;
 		}
 		$page_count = $limit->page_count->getValue();
-		if(!$page_count)
+		if (!$page_count)
 		{
 			$page_count = 10;
 		}
 		$page = $limit->page->getValue();
-		if(!$page || $page < 1)
+		if (!$page || $page < 1)
 		{
 			$page = 1;
 		}
 
 		// total pages
-		if($total_count)
+		if ($total_count)
 		{
 			$total_page = (int) (($total_count - 1) / $list_count) + 1;
 		}
@@ -1076,7 +1076,7 @@ 
 		}
 
 		// check the page variables
-		if($page > $total_page)
+		if ($page > $total_page)
 		{
 			// If requested page is bigger than total number of pages, return empty list
 
@@ -1092,9 +1092,9 @@ 
 		$start_count = ($page - 1) * $list_count;
 
 		$query = $this->getSelectPageSql($queryObject, $with_values, $start_count, $list_count);
-		$query .= (__DEBUG_QUERY__ & 1 && $queryObject->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $queryObject->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 		$result = $this->_query($query, $connection);
-		if($this->isError())
+		if ($this->isError())
 		{
 			unset($this->param);
 			return $this->queryError($queryObject);
@@ -1135,44 +1135,44 @@ 
 	{
 
 		$select = $query->getSelectString($with_values);
-		if($select == '')
+		if ($select == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$select = 'SELECT ' . $select;
+		$select = 'SELECT '.$select;
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$from = ' FROM ' . $from;
+		$from = ' FROM '.$from;
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$groupBy = $query->getGroupByString();
-		if($groupBy != '')
+		if ($groupBy != '')
 		{
-			$groupBy = ' GROUP BY ' . $groupBy;
+			$groupBy = ' GROUP BY '.$groupBy;
 		}
 
 		$orderBy = $query->getOrderByString();
-		if($orderBy != '')
+		if ($orderBy != '')
 		{
-			$orderBy = ' ORDER BY ' . $orderBy;
+			$orderBy = ' ORDER BY '.$orderBy;
 		}
 
 		$limit = $query->getLimitString();
-		if($limit != '')
+		if ($limit != '')
 		{
 			$limit = sprintf(' LIMIT %d, %d', $start_count, $list_count);
 		}
 
-		return $select . ' ' . $from . ' ' . $where . ' ' . $groupBy . ' ' . $orderBy . ' ' . $limit;
+		return $select.' '.$from.' '.$where.' '.$groupBy.' '.$orderBy.' '.$limit;
 	}
 
 }

Braces +31 added lines, -41 removed lines

@@ -52,7 +52,9 @@ 
 	function DBCubrid($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if($auto_connect) {
+			$this->_connect();
+		}
 	}
 
 	/**
@@ -90,8 +92,9 @@ 
 			define('__CUBRID_VERSION__', $cubrid_version);
 		}
 
-		if(__CUBRID_VERSION__ >= '8.4.0')
-			cubrid_set_autocommit($result, CUBRID_AUTOCOMMIT_TRUE);
+		if(__CUBRID_VERSION__ >= '8.4.0') {
+					cubrid_set_autocommit($result, CUBRID_AUTOCOMMIT_TRUE);
+		}
 
 		return $result;
 	}
@@ -153,8 +156,7 @@ 
 			if(!$transactionLevel)
 			{
 				cubrid_set_autocommit($connection, CUBRID_AUTOCOMMIT_FALSE);
-			}
-			else
+			} else
 			{
 				$this->_query("SAVEPOINT SP" . $transactionLevel, $connection);
 			}
@@ -176,8 +178,7 @@ 
 		if($point)
 		{
 			$this->_query("ROLLBACK TO SP" . $point, $connection);
-		}
-		else
+		} else
 		{
 			@cubrid_rollback($connection);
 		}
@@ -251,8 +252,7 @@ 
 								return false;
 							}
 						}
-					}
-					else
+					} else
 					{
 						$bound = @cubrid_bind($req, ++$position, $value, $bind_type);
 						if(!$bound)
@@ -343,8 +343,7 @@ 
 			if($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $tmp;
-			}
-			else
+			} else
 			{
 				$output[] = $tmp;
 			}
@@ -395,8 +394,9 @@ 
 	 */
 	function _makeSequence()
 	{
-		if($_GLOBALS['XE_EXISTS_SEQUENCE'])
-			return;
+		if($_GLOBALS['XE_EXISTS_SEQUENCE']) {
+					return;
+		}
 
 		// check cubrid serial
 		$query = sprintf('select count(*) as "count" from "db_serial" where name=\'%ssequence\'', $this->prefix);
@@ -421,8 +421,7 @@ 
 			if($srl < 1)
 			{
 				$start = 1;
-			}
-			else
+			} else
 			{
 				$start = $srl + 1000000;
 			}
@@ -445,8 +444,7 @@ 
 		if($target_name == 'sequence')
 		{
 			$query = sprintf("select \"name\" from \"db_serial\" where \"name\" = '%s%s'", $this->prefix, $target_name);
-		}
-		else
+		} else
 		{
 			$query = sprintf("select \"class_name\" from \"db_class\" where \"class_name\" = '%s%s'", $this->prefix, $target_name);
 		}
@@ -455,8 +453,7 @@ 
 		if(cubrid_num_rows($result) > 0)
 		{
 			$output = TRUE;
-		}
-		else
+		} else
 		{
 			$output = FALSE;
 		}
@@ -500,8 +497,7 @@ 
 		if($size)
 		{
 			$query .= sprintf("%s(%s) ", $type, $size);
-		}
-		else
+		} else
 		{
 			$query .= sprintf("%s ", $type);
 		}
@@ -511,8 +507,7 @@ 
 			if($type == 'INTEGER' || $type == 'BIGINT' || $type == 'INT')
 			{
 				$query .= sprintf("default %d ", $default);
-			}
-			else
+			} else
 			{
 				$query .= sprintf("default '%s' ", $default);
 			}
@@ -553,8 +548,7 @@ 
 		if(cubrid_num_rows($result) > 0)
 		{
 			$output = TRUE;
-		}
-		else
+		} else
 		{
 			$output = FALSE;
 		}
@@ -674,8 +668,7 @@ 
 		if(!is_array($output))
 		{
 			$indexes_to_be_deleted = array($output);
-		}
-		else
+		} else
 		{
 			$indexes_to_be_deleted = $output;
 		}
@@ -758,8 +751,7 @@ 
 		if(!is_array($xml_obj->table->column))
 		{
 			$columns[] = $xml_obj->table->column;
-		}
-		else
+		} else
 		{
 			$columns = $xml_obj->table->column;
 		}
@@ -799,8 +791,9 @@ 
 
 			if($type == 'varchar' || $type == 'char')
 			{
-				if($size)
-					$size = $size * 3;
+				if($size) {
+									$size = $size * 3;
+				}
 			}
 
 
@@ -809,12 +802,10 @@ 
 			if($primary_key)
 			{
 				$primary_list[] = $name;
-			}
-			else if($unique)
+			} else if($unique)
 			{
 				$unique_list[$unique][] = $name;
-			}
-			else if($index)
+			} else if($index)
 			{
 				$index_list[$index][] = $name;
 			}
@@ -964,8 +955,7 @@ 
 		if($limit && $limit->isPageHandler())
 		{
 			return $this->queryPageLimit($queryObject, $connection, $with_values);
-		}
-		else
+		} else
 		{
 			$query = $this->getSelectSql($queryObject, $with_values);
 			if(is_a($query, 'BaseObject'))
@@ -1009,8 +999,9 @@ 
 			$buff->data = array();
 			$buff->page_navigation = new PageHandler(/* $total_count */0, /* $total_page */1, /* $page */1, /* $page_count */10); //default page handler values
 			return $buff;
-		}else
-			return;
+		} else {
+					return;
+		}
 	}
 
 	/**
@@ -1069,8 +1060,7 @@ 
 		if($total_count)
 		{
 			$total_page = (int) (($total_count - 1) / $list_count) + 1;
-		}
-		else
+		} else
 		{
 			$total_page = 1;
 		}

classes/db/DBMssql.class.php

Doc Comments +8 added lines, -7 removed lines

@@ -111,7 +111,7 @@ 
 	/**
 	 * DB transaction start
 	 * this method is private
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function _begin($transactionLevel = 0)
 	{
@@ -170,7 +170,7 @@ 
 	 * this method is private
 	 * @param string $query
 	 * @param resource $connection
-	 * @return resource|boolean Returns a statement resource on success and FALSE if an error occurred.
+	 * @return resource Returns a statement resource on success and FALSE if an error occurred.
 	 */
 	function __query($query, $connection)
 	{
@@ -375,7 +375,7 @@ 
 	 * @param int $size column size
 	 * @param string|int $default default value
 	 * @param boolean $notnull not null status, default value is false
-	 * @return void
+	 * @return null|resource
 	 */
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = false)
 	{
@@ -431,7 +431,7 @@ 
 	 * Check column exist status of the table
 	 * @param string $table_name table name
 	 * @param string $column_name column name
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function isColumnExists($table_name, $column_name)
 	{
@@ -495,7 +495,7 @@ 
 	 * Check index status of the table
 	 * @param string $table_name table name
 	 * @param string $index_name index name
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function isIndexExists($table_name, $index_name)
 	{
@@ -674,7 +674,7 @@ 
 
 	/**
 	 * Return update query string
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @param boolean $with_priority
 	 * @return string
@@ -726,8 +726,9 @@ 
 
 	/**
 	 * Return select query string
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
+	 * @param resource $connection
 	 * @return string
 	 */
 	function getSelectSql($query, $with_values = TRUE, $connection=NULL)

Spacing +112 added lines, -112 removed lines

@@ -45,7 +45,7 @@ 
 	function DBMssql($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if ($auto_connect) $this->_connect();
 	}
 
 	/**
@@ -70,10 +70,10 @@ 
 		//sqlsrv_configure( 'LogSubsystems', SQLSRV_LOG_SYSTEM_ALL );
 		$result = @sqlsrv_connect($connection["db_hostname"], array('Database' => $connection["db_database"], 'UID' => $connection["db_userid"], 'PWD' => $connection["db_password"]));
 
-		if(!$result)
+		if (!$result)
 		{
 			$errors = print_r(sqlsrv_errors(), true);
-			$this->setError(-1, 'database connect fail' . PHP_EOL . $errors);
+			$this->setError(-1, 'database connect fail'.PHP_EOL.$errors);
 			return;
 		}
 		return $result;
@@ -99,7 +99,7 @@ 
 	 */
 	function addQuotes($string)
 	{
-		if(version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
+		if (version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
 		{
 			$string = stripslashes(str_replace("\\", "\\\\", $string));
 		}
@@ -117,16 +117,16 @@ 
 	{
 		$connection = $this->_getConnection('master');
 
-		if(!$transactionLevel)
+		if (!$transactionLevel)
 		{
-			if(sqlsrv_begin_transaction($connection) === false)
+			if (sqlsrv_begin_transaction($connection) === false)
 			{
 				return;
 			}
 		}
 		else
 		{
-			$this->_query("SAVE TRANS SP" . $transactionLevel, $connection);
+			$this->_query("SAVE TRANS SP".$transactionLevel, $connection);
 		}
 		return true;
 	}
@@ -142,9 +142,9 @@ 
 
 		$point = $transactionLevel - 1;
 
-		if($point)
+		if ($point)
 		{
-			$this->_query("ROLLBACK TRANS SP" . $point, $connection);
+			$this->_query("ROLLBACK TRANS SP".$point, $connection);
 		}
 		else
 		{
@@ -176,18 +176,18 @@ 
 	{
 		$_param = array();
 
-		if(count($this->param))
+		if (count($this->param))
 		{
-			foreach($this->param as $k => $o)
+			foreach ($this->param as $k => $o)
 			{
-				if($o->isColumnName())
+				if ($o->isColumnName())
 				{
 					continue;
 				}
-				if($o->getType() == 'number')
+				if ($o->getType() == 'number')
 				{
 					$value = $o->getUnescapedValue();
-					if(is_array($value))
+					if (is_array($value))
 					{
 						$_param = array_merge($_param, $value);
 					}
@@ -199,9 +199,9 @@ 
 				else
 				{
 					$value = $o->getUnescapedValue();
-					if(is_array($value))
+					if (is_array($value))
 					{
-						foreach($value as $v)
+						foreach ($value as $v)
 						{
 							$_param[] = array($v, SQLSRV_PARAM_IN, SQLSRV_PHPTYPE_STRING('utf-8'));
 						}
@@ -216,7 +216,7 @@ 
 
 		// Run the query statement
 		$result = false;
-		if(count($_param))
+		if (count($_param))
 		{
 			$args = $this->_getParametersByReference($_param);
 			$stmt = sqlsrv_prepare($connection, $query, $args);
@@ -226,7 +226,7 @@ 
 			$stmt = sqlsrv_prepare($connection, $query);
 		}
 
-		if(!$stmt)
+		if (!$stmt)
 		{
 			$result = false;
 		}
@@ -236,7 +236,7 @@ 
 		}
 
 		// Error Check
-		if(!$result)
+		if (!$result)
 		{
 			$this->setError(print_r(sqlsrv_errors(), true));
 		}
@@ -259,9 +259,9 @@ 
 		$copy = array();
 		$args = array();
 		$i = 0;
-		foreach($_param as $key => $value)
+		foreach ($_param as $key => $value)
 		{
-			if(is_array($value))
+			if (is_array($value))
 			{
 				$value_copy = $value;
 				$value_arg = array();
@@ -288,7 +288,7 @@ 
 	function _fetch($result, $arrayIndexEndValue = NULL)
 	{
 		$output = array();
-		if(!$this->isConnected() || $this->isError() || !$result)
+		if (!$this->isConnected() || $this->isError() || !$result)
 		{
 			return $output;
 		}
@@ -296,18 +296,18 @@ 
 		$c = sqlsrv_num_fields($result);
 		$m = null;
 
-		while(sqlsrv_fetch($result))
+		while (sqlsrv_fetch($result))
 		{
-			if(!$m)
+			if (!$m)
 			{
 				$m = sqlsrv_field_metadata($result);
 			}
 			unset($row);
-			for($i = 0; $i < $c; $i++)
+			for ($i = 0; $i < $c; $i++)
 			{
 				$row->{$m[$i]['Name']} = sqlsrv_get_field($result, $i, SQLSRV_PHPTYPE_STRING('utf-8'));
 			}
-			if($arrayIndexEndValue)
+			if ($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $row;
 			}
@@ -317,9 +317,9 @@ 
 			}
 		}
 
-		if(count($output) == 1)
+		if (count($output) == 1)
 		{
-			if(isset($arrayIndexEndValue))
+			if (isset($arrayIndexEndValue))
 			{
 				return $output;
 			}
@@ -360,7 +360,7 @@ 
 		$result = $this->_query($query);
 		$tmp = $this->_fetch($result);
 
-		if(!$tmp)
+		if (!$tmp)
 		{
 			return false;
 		}
@@ -379,18 +379,18 @@ 
 	 */
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = false)
 	{
-		if($this->isColumnExists($table_name, $column_name))
+		if ($this->isColumnExists($table_name, $column_name))
 		{
 			return;
 		}
 		$type = $this->column_type[$type];
-		if(strtoupper($type) == 'INTEGER')
+		if (strtoupper($type) == 'INTEGER')
 		{
 			$size = '';
 		}
 
 		$query = sprintf("alter table %s%s add \"%s\" ", $this->prefix, $table_name, $column_name);
-		if($size)
+		if ($size)
 		{
 			$query .= sprintf(" %s(%s) ", $type, $size);
 		}
@@ -399,11 +399,11 @@ 
 			$query .= sprintf(" %s ", $type);
 		}
 
-		if(isset($default))
+		if (isset($default))
 		{
 			$query .= sprintf(" default '%s' ", $default);
 		}
-		if($notnull)
+		if ($notnull)
 		{
 			$query .= " not null ";
 		}
@@ -419,7 +419,7 @@ 
 	 */
 	function dropColumn($table_name, $column_name)
 	{
-		if(!$this->isColumnExists($table_name, $column_name))
+		if (!$this->isColumnExists($table_name, $column_name))
 		{
 			return;
 		}
@@ -437,12 +437,12 @@ 
 	{
 		$query = sprintf("select syscolumns.name as name from syscolumns, sysobjects where sysobjects.name = '%s%s' and sysobjects.id = syscolumns.id and syscolumns.name = '%s'", $this->prefix, $table_name, $column_name);
 		$result = $this->_query($query);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return;
 		}
 		$tmp = $this->_fetch($result);
-		if(!$tmp->name)
+		if (!$tmp->name)
 		{
 			return false;
 		}
@@ -461,11 +461,11 @@ 
 	 */
 	function addIndex($table_name, $index_name, $target_columns, $is_unique = false)
 	{
-		if($this->isIndexExists($table_name, $index_name))
+		if ($this->isIndexExists($table_name, $index_name))
 		{
 			return;
 		}
-		if(!is_array($target_columns))
+		if (!is_array($target_columns))
 		{
 			$target_columns = array($target_columns);
 		}
@@ -483,7 +483,7 @@ 
 	 */
 	function dropIndex($table_name, $index_name, $is_unique = false)
 	{
-		if(!$this->isIndexExists($table_name, $index_name))
+		if (!$this->isIndexExists($table_name, $index_name))
 		{
 			return;
 		}
@@ -502,13 +502,13 @@ 
 		$query = sprintf("select sysindexes.name as name from sysindexes, sysobjects where sysobjects.name = '%s%s' and sysobjects.id = sysindexes.id and sysindexes.name = '%s'", $this->prefix, $table_name, $index_name);
 
 		$result = $this->_query($query);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return;
 		}
 		$tmp = $this->_fetch($result);
 
-		if(!$tmp->name)
+		if (!$tmp->name)
 		{
 			return false;
 		}
@@ -532,7 +532,7 @@ 
 	 */
 	function createTableByXmlFile($file_name)
 	{
-		if(!file_exists($file_name))
+		if (!file_exists($file_name))
 		{
 			return;
 		}
@@ -557,22 +557,22 @@ 
 		$xml_obj = $oXml->parse($xml_doc);
 		// Create a table schema
 		$table_name = $xml_obj->table->attrs->name;
-		if($this->isTableExists($table_name))
+		if ($this->isTableExists($table_name))
 		{
 			return;
 		}
 
-		if($table_name == 'sequence')
+		if ($table_name == 'sequence')
 		{
-			$table_name = $this->prefix . $table_name;
+			$table_name = $this->prefix.$table_name;
 			$query = sprintf('create table %s ( sequence int identity(1,1), seq int )', $table_name);
 			return $this->_query($query);
 		}
 		else
 		{
-			$table_name = $this->prefix . $table_name;
+			$table_name = $this->prefix.$table_name;
 
-			if(!is_array($xml_obj->table->column))
+			if (!is_array($xml_obj->table->column))
 			{
 				$columns[] = $xml_obj->table->column;
 			}
@@ -586,7 +586,7 @@ 
 			$index_list = array();
 
 			$typeList = array('number' => 1, 'text' => 1);
-			foreach($columns as $column)
+			foreach ($columns as $column)
 			{
 				$name = $column->attrs->name;
 				$type = $column->attrs->type;
@@ -598,48 +598,48 @@ 
 				$default = $column->attrs->default;
 				$auto_increment = $column->attrs->auto_increment;
 
-				$column_schema[] = sprintf('[%s] %s%s %s %s %s', $name, $this->column_type[$type], !isset($typeList[$type]) && $size ? '(' . $size . ')' : '', isset($default) ? "default '" . $default . "'" : '', $notnull ? 'not null' : 'null', $auto_increment ? 'identity(1,1)' : '');
+				$column_schema[] = sprintf('[%s] %s%s %s %s %s', $name, $this->column_type[$type], !isset($typeList[$type]) && $size ? '('.$size.')' : '', isset($default) ? "default '".$default."'" : '', $notnull ? 'not null' : 'null', $auto_increment ? 'identity(1,1)' : '');
 
-				if($primary_key)
+				if ($primary_key)
 				{
 					$primary_list[] = $name;
 				}
-				else if($unique)
+				else if ($unique)
 				{
 					$unique_list[$unique][] = $name;
 				}
-				else if($index)
+				else if ($index)
 				{
 					$index_list[$index][] = $name;
 				}
 			}
 
-			if(count($primary_list))
+			if (count($primary_list))
 			{
-				$column_schema[] = sprintf("primary key (%s)", '"' . implode($primary_list, '","') . '"');
+				$column_schema[] = sprintf("primary key (%s)", '"'.implode($primary_list, '","').'"');
 			}
 
 			$schema = sprintf('create table [%s] (%s%s)', $this->addQuotes($table_name), "\n", implode($column_schema, ",\n"));
 			$output = $this->_query($schema);
-			if(!$output)
+			if (!$output)
 			{
 				return false;
 			}
 
-			if(count($unique_list))
+			if (count($unique_list))
 			{
-				foreach($unique_list as $key => $val)
+				foreach ($unique_list as $key => $val)
 				{
-					$query = sprintf("create unique index %s on %s (%s);", $key, $table_name, '[' . implode('],[', $val) . ']');
+					$query = sprintf("create unique index %s on %s (%s);", $key, $table_name, '['.implode('],[', $val).']');
 					$this->_query($query);
 				}
 			}
 
-			if(count($index_list))
+			if (count($index_list))
 			{
-				foreach($index_list as $key => $val)
+				foreach ($index_list as $key => $val)
 				{
-					$query = sprintf("create index %s on %s (%s);", $key, $table_name, '[' . implode('],[', $val) . ']');
+					$query = sprintf("create index %s on %s (%s);", $key, $table_name, '['.implode('],[', $val).']');
 					$this->_query($query);
 				}
 			}
@@ -682,34 +682,34 @@ 
 	function getUpdateSql($query, $with_values = true, $with_priority = false)
 	{
 		$columnsList = $query->getUpdateString($with_values);
-		if($columnsList == '')
+		if ($columnsList == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
 
 		$tables = $query->getTables();
 		$alias_list = '';
-		foreach($tables as $table)
+		foreach ($tables as $table)
 		{
 			$alias_list .= $table->getAlias();
 		}
 		implode(',', explode(' ', $alias_list));
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$priority = $with_priority ? $query->getPriority() : '';
 
-		return "UPDATE $priority $alias_list SET $columnsList FROM " . $from . $where;
+		return "UPDATE $priority $alias_list SET $columnsList FROM ".$from.$where;
 	}
 
 	/**
@@ -730,7 +730,7 @@ 
 	 * @param boolean $with_values
 	 * @return string
 	 */
-	function getSelectSql($query, $with_values = TRUE, $connection=NULL)
+	function getSelectSql($query, $with_values = TRUE, $connection = NULL)
 	{
 		$with_values = false;
 
@@ -740,75 +740,75 @@ 
 		$limit = '';
 		$limitCount = '';
 		$limitQueryPart = $query->getLimit();
-		if($limitQueryPart)
+		if ($limitQueryPart)
 		{
 			$limitCount = $limitQueryPart->getLimit();
 		}
-		if($limitCount != '')
+		if ($limitCount != '')
 		{
-			$limit = 'SELECT TOP ' . $limitCount;
+			$limit = 'SELECT TOP '.$limitCount;
 		}
 
 		$select = $query->getSelectString($with_values);
-		if($select == '')
+		if ($select == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		if($limit != '')
+		if ($limit != '')
 		{
-			$select = $limit . ' ' . $select;
+			$select = $limit.' '.$select;
 		}
 		else
 		{
-			$select = 'SELECT ' . $select;
+			$select = 'SELECT '.$select;
 		}
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$from = ' FROM ' . $from;
+		$from = ' FROM '.$from;
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$groupBy = $query->getGroupByString();
-		if($groupBy != '')
+		if ($groupBy != '')
 		{
-			$groupBy = ' GROUP BY ' . $groupBy;
+			$groupBy = ' GROUP BY '.$groupBy;
 		}
 
 		$orderBy = $query->getOrderByString();
-		if($orderBy != '')
+		if ($orderBy != '')
 		{
-			$orderBy = ' ORDER BY ' . $orderBy;
+			$orderBy = ' ORDER BY '.$orderBy;
 		}
 
-		if($limitCount != '' && $query->limit->start > 0)
+		if ($limitCount != '' && $query->limit->start > 0)
 		{
 			$order = $query->getOrder();
 			$first_columns = array();
-			foreach($order as $val)
+			foreach ($order as $val)
 			{
 				$tmpColumnName = $val->getPureColumnName();
-				$first_columns[] = sprintf('%s(%s) as %s', $val->getPureSortOrder()=='asc'?'max':'min', $tmpColumnName, $tmpColumnName);
+				$first_columns[] = sprintf('%s(%s) as %s', $val->getPureSortOrder() == 'asc' ? 'max' : 'min', $tmpColumnName, $tmpColumnName);
 				$first_sub_columns[] = $tmpColumnName;
 			}
 
-			$first_query = sprintf("select %s from (select top %d %s %s %s %s %s) xet", implode(',',$first_columns),  $query->limit->start, implode(',',$first_sub_columns), $from, $where, $groupBy, $orderBy);
+			$first_query = sprintf("select %s from (select top %d %s %s %s %s %s) xet", implode(',', $first_columns), $query->limit->start, implode(',', $first_sub_columns), $from, $where, $groupBy, $orderBy);
 			$this->param = $query->getArguments();
 			$result = $this->__query($first_query, $connection);
 			$tmp = $this->_fetch($result);
 
 			$sub_cond = array();
-			foreach($order as $k => $v)
+			foreach ($order as $k => $v)
 			{
 				//for example... use Document
-				if(get_class($v->sort_order) == 'SortArgument')
+				if (get_class($v->sort_order) == 'SortArgument')
 				{
 					$sort_order = $v->sort_order->value;
 				}
@@ -818,19 +818,19 @@ 
 					$sort_order = $v->sort_order;
 				}
 
-				$sub_cond[] = sprintf("%s %s '%s'", $v->getPureColumnName(), $sort_order=='asc'?'>':'<', $tmp->{$v->getPureColumnName()});
+				$sub_cond[] = sprintf("%s %s '%s'", $v->getPureColumnName(), $sort_order == 'asc' ? '>' : '<', $tmp->{$v->getPureColumnName()});
 			}
 
-			if(!$where)
+			if (!$where)
 			{
-				$sub_condition = ' WHERE ( '.implode(' and ',$sub_cond).' )';
+				$sub_condition = ' WHERE ( '.implode(' and ', $sub_cond).' )';
 			}
 			else
 			{
-				$sub_condition = ' and ( '.implode(' and ',$sub_cond).' )';
+				$sub_condition = ' and ( '.implode(' and ', $sub_cond).' )';
 			}
 		}
-		return $select . ' ' . $from . ' ' . $where .$sub_condition. ' ' . $groupBy . ' ' . $orderBy;
+		return $select.' '.$from.' '.$where.$sub_condition.' '.$groupBy.' '.$orderBy;
 	}
 
 	/**
@@ -845,7 +845,7 @@ 
 	{
 		$query = $this->getSelectSql($queryObject, true, $connection);
 
-		if(strpos($query, "substr"))
+		if (strpos($query, "substr"))
 		{
 			$query = str_replace("substr", "substring", $query);
 		}
@@ -853,10 +853,10 @@ 
 		// TODO Decide if we continue to pass parameters like this
 		$this->param = $queryObject->getArguments();
 
-		$query .= (__DEBUG_QUERY__ & 1 && $output->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $output->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 		$result = $this->_query($query, $connection);
 
-		if($this->isError())
+		if ($this->isError())
 		{
 			return $this->queryError($queryObject);
 		}
@@ -884,7 +884,7 @@ 
 	function queryError($queryObject)
 	{
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			$buff = new BaseObject();
 			$buff->total_count = 0;
@@ -910,52 +910,52 @@ 
 	function queryPageLimit($queryObject, $result, $connection)
 	{
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			// Total count
 			$temp_where = $queryObject->getWhereString(true, false);
-			$count_query = sprintf('select count(*) as "count" %s %s', 'FROM ' . $queryObject->getFromString(), ($temp_where === '' ? '' : ' WHERE ' . $temp_where));
+			$count_query = sprintf('select count(*) as "count" %s %s', 'FROM '.$queryObject->getFromString(), ($temp_where === '' ? '' : ' WHERE '.$temp_where));
 
 			// Check for distinct query and if found update count query structure
 			$temp_select = $queryObject->getSelectString(true);
 			$uses_distinct = stripos($temp_select, "distinct") !== false;
 			$uses_groupby = $queryObject->getGroupByString() != '';
-			if($uses_distinct || $uses_groupby)
+			if ($uses_distinct || $uses_groupby)
 			{
 				$count_query = sprintf('select %s %s %s %s'
 						, $temp_select
-						, 'FROM ' . $queryObject->getFromString(true)
-						, ($temp_where === '' ? '' : ' WHERE ' . $temp_where)
-						, ($uses_groupby ? ' GROUP BY ' . $queryObject->getGroupByString() : '')
+						, 'FROM '.$queryObject->getFromString(true)
+						, ($temp_where === '' ? '' : ' WHERE '.$temp_where)
+						, ($uses_groupby ? ' GROUP BY '.$queryObject->getGroupByString() : '')
 				);
 
 				// If query uses grouping or distinct, count from original select
 				$count_query = sprintf('select count(*) as "count" from (%s) xet', $count_query);
 			}
 
-			$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+			$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 			$this->param = $queryObject->getArguments();
 			$result_count = $this->_query($count_query, $connection);
 			$count_output = $this->_fetch($result_count);
 			$total_count = (int) $count_output->count;
 
 			$list_count = $limit->list_count->getValue();
-			if(!$list_count)
+			if (!$list_count)
 			{
 				$list_count = 20;
 			}
 			$page_count = $limit->page_count->getValue();
-			if(!$page_count)
+			if (!$page_count)
 			{
 				$page_count = 10;
 			}
 			$page = $limit->page->getValue();
-			if(!$page || $page < 1)
+			if (!$page || $page < 1)
 			{
 				$page = 1;
 			}
 			// Total pages
-			if($total_count)
+			if ($total_count)
 			{
 				$total_page = (int) (($total_count - 1) / $list_count) + 1;
 			}
@@ -965,7 +965,7 @@ 
 			}
 
 			// check the page variables
-			if($page > $total_page)
+			if ($page > $total_page)
 			{
 				// If requested page is bigger than total number of pages, return empty list
 
@@ -977,7 +977,7 @@ 
 				$buff->page_navigation = new PageHandler($total_count, $total_page, $page, $page_count);
 				return $buff;
 
-				if($queryObject->usesClickCount())
+				if ($queryObject->usesClickCount())
 				{
 					$update_query = $this->getClickCountQuery($queryObject);
 					$this->_executeUpdateAct($update_query);

Braces +24 added lines, -43 removed lines

@@ -45,7 +45,9 @@ 
 	function DBMssql($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if($auto_connect) {
+			$this->_connect();
+		}
 	}
 
 	/**
@@ -123,8 +125,7 @@ 
 			{
 				return;
 			}
-		}
-		else
+		} else
 		{
 			$this->_query("SAVE TRANS SP" . $transactionLevel, $connection);
 		}
@@ -145,8 +146,7 @@ 
 		if($point)
 		{
 			$this->_query("ROLLBACK TRANS SP" . $point, $connection);
-		}
-		else
+		} else
 		{
 			sqlsrv_rollback($connection);
 		}
@@ -190,13 +190,11 @@ 
 					if(is_array($value))
 					{
 						$_param = array_merge($_param, $value);
-					}
-					else
+					} else
 					{
 						$_param[] = $o->getUnescapedValue();
 					}
-				}
-				else
+				} else
 				{
 					$value = $o->getUnescapedValue();
 					if(is_array($value))
@@ -205,8 +203,7 @@ 
 						{
 							$_param[] = array($v, SQLSRV_PARAM_IN, SQLSRV_PHPTYPE_STRING('utf-8'));
 						}
-					}
-					else
+					} else
 					{
 						$_param[] = array($value, SQLSRV_PARAM_IN, SQLSRV_PHPTYPE_STRING('utf-8'));
 					}
@@ -220,8 +217,7 @@ 
 		{
 			$args = $this->_getParametersByReference($_param);
 			$stmt = sqlsrv_prepare($connection, $query, $args);
-		}
-		else
+		} else
 		{
 			$stmt = sqlsrv_prepare($connection, $query);
 		}
@@ -229,8 +225,7 @@ 
 		if(!$stmt)
 		{
 			$result = false;
-		}
-		else
+		} else
 		{
 			$result = sqlsrv_execute($stmt);
 		}
@@ -268,8 +263,7 @@ 
 				$value_arg[] = &$value_copy[0];
 				$value_arg[] = $value_copy[1];
 				$value_arg[] = $value_copy[2];
-			}
-			else
+			} else
 			{
 				$value_arg = $value;
 			}
@@ -310,8 +304,7 @@ 
 			if($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $row;
-			}
-			else
+			} else
 			{
 				$output[] = $row;
 			}
@@ -322,8 +315,7 @@ 
 			if(isset($arrayIndexEndValue))
 			{
 				return $output;
-			}
-			else
+			} else
 			{
 				return $output[0];
 			}
@@ -393,8 +385,7 @@ 
 		if($size)
 		{
 			$query .= sprintf(" %s(%s) ", $type, $size);
-		}
-		else
+		} else
 		{
 			$query .= sprintf(" %s ", $type);
 		}
@@ -567,16 +558,14 @@ 
 			$table_name = $this->prefix . $table_name;
 			$query = sprintf('create table %s ( sequence int identity(1,1), seq int )', $table_name);
 			return $this->_query($query);
-		}
-		else
+		} else
 		{
 			$table_name = $this->prefix . $table_name;
 
 			if(!is_array($xml_obj->table->column))
 			{
 				$columns[] = $xml_obj->table->column;
-			}
-			else
+			} else
 			{
 				$columns = $xml_obj->table->column;
 			}
@@ -603,12 +592,10 @@ 
 				if($primary_key)
 				{
 					$primary_list[] = $name;
-				}
-				else if($unique)
+				} else if($unique)
 				{
 					$unique_list[$unique][] = $name;
-				}
-				else if($index)
+				} else if($index)
 				{
 					$index_list[$index][] = $name;
 				}
@@ -757,8 +744,7 @@ 
 		if($limit != '')
 		{
 			$select = $limit . ' ' . $select;
-		}
-		else
+		} else
 		{
 			$select = 'SELECT ' . $select;
 		}
@@ -824,8 +810,7 @@ 
 			if(!$where)
 			{
 				$sub_condition = ' WHERE ( '.implode(' and ',$sub_cond).' )';
-			}
-			else
+			} else
 			{
 				$sub_condition = ' and ( '.implode(' and ',$sub_cond).' )';
 			}
@@ -859,8 +844,7 @@ 
 		if($this->isError())
 		{
 			return $this->queryError($queryObject);
-		}
-		else
+		} else
 		{
 			return $this->queryPageLimit($queryObject, $result, $connection);
 		}
@@ -893,8 +877,7 @@ 
 			$buff->data = array();
 			$buff->page_navigation = new PageHandler(/* $total_count */0, /* $total_page */1, /* $page */1, /* $page_count */10); //default page handler values
 			return $buff;
-		}
-		else
+		} else
 		{
 			return;
 		}
@@ -958,8 +941,7 @@ 
 			if($total_count)
 			{
 				$total_page = (int) (($total_count - 1) / $list_count) + 1;
-			}
-			else
+			} else
 			{
 				$total_page = 1;
 			}
@@ -995,8 +977,7 @@ 
 			$buff->page = $page;
 			$buff->data = $data;
 			$buff->page_navigation = new PageHandler($total_count, $total_page, $page, $page_count);
-		}
-		else
+		} else
 		{
 			$data = $this->_fetch($result);
 			$buff = new BaseObject();

classes/db/DBMysql.class.php

Doc Comments +7 added lines, -7 removed lines

@@ -297,7 +297,7 @@ 
 	 * @param int $size column size
 	 * @param string|int $default default value
 	 * @param boolean $notnull not null status, default value is false
-	 * @return void
+	 * @return resource|null
 	 */
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = false)
 	{
@@ -344,7 +344,7 @@ 
 	 * Check column exist status of the table
 	 * @param string $table_name table name
 	 * @param string $column_name column name
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function isColumnExists($table_name, $column_name)
 	{
@@ -408,7 +408,7 @@ 
 	 * Check index status of the table
 	 * @param string $table_name table name
 	 * @param string $index_name index name
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function isIndexExists($table_name, $index_name)
 	{
@@ -442,7 +442,7 @@ 
 	/**
 	 * Creates a table by using xml contents
 	 * @param string $xml_doc xml schema contents
-	 * @return void|object
+	 * @return null|false
 	 */
 	function createTableByXml($xml_doc)
 	{
@@ -452,7 +452,7 @@ 
 	/**
 	 * Creates a table by using xml file path
 	 * @param string $file_name xml schema file path
-	 * @return void|object
+	 * @return null|false
 	 */
 	function createTableByXmlFile($file_name)
 	{
@@ -472,7 +472,7 @@ 
 	 * opt : notnull, default, size\n
 	 * index : primary key, index, unique\n
 	 * @param string $xml_doc xml schema contents
-	 * @return void|object
+	 * @return null|false
 	 */
 	function _createTable($xml_doc)
 	{
@@ -824,7 +824,7 @@ 
 
 	/**
 	 * If select query execute, return paging sql
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @param int $start_count
 	 * @param int $list_count

Spacing +90 added lines, -90 removed lines

@@ -46,7 +46,7 @@ 
 	function DBMysql($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if ($auto_connect) $this->_connect();
 	}
 
 	/**
@@ -67,32 +67,32 @@ 
 	function __connect($connection)
 	{
 		// Ignore if no DB information exists
-		if(strpos($connection["db_hostname"], ':') === false && $connection["db_port"])
+		if (strpos($connection["db_hostname"], ':') === false && $connection["db_port"])
 		{
-			$connection["db_hostname"] .= ':' . $connection["db_port"];
+			$connection["db_hostname"] .= ':'.$connection["db_port"];
 		}
 
 		// Attempt to connect
 		$result = @mysql_connect($connection["db_hostname"], $connection["db_userid"], $connection["db_password"]);
-		if(!$result)
+		if (!$result)
 		{
 			exit('XE cannot connect to DB.');
 		}
 
-		if(mysql_error())
+		if (mysql_error())
 		{
 			$this->setError(mysql_errno(), mysql_error());
 			return;
 		}
 		// Error appears if the version is lower than 4.1
-		if(version_compare(mysql_get_server_info($result), '4.1', '<'))
+		if (version_compare(mysql_get_server_info($result), '4.1', '<'))
 		{
-			$this->setError(-1, 'XE cannot be installed under the version of mysql 4.1. Current mysql version is ' . mysql_get_server_info());
+			$this->setError(-1, 'XE cannot be installed under the version of mysql 4.1. Current mysql version is '.mysql_get_server_info());
 			return;
 		}
 		// select db
 		@mysql_select_db($connection["db_database"], $result);
-		if(mysql_error())
+		if (mysql_error())
 		{
 			$this->setError(mysql_errno(), mysql_error());
 			return;
@@ -131,11 +131,11 @@ 
 	 */
 	function addQuotes($string)
 	{
-		if(version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
+		if (version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
 		{
 			$string = stripslashes(str_replace("\\", "\\\\", $string));
 		}
-		if(!is_numeric($string))
+		if (!is_numeric($string))
 		{
 			$string = @mysql_real_escape_string($string);
 		}
@@ -181,14 +181,14 @@ 
 	 */
 	function __query($query, $connection)
 	{
-		if(!$connection)
+		if (!$connection)
 		{
 			exit('XE cannot handle DB connection.');
 		}
 		// Run the query statement
 		$result = mysql_query($query, $connection);
 		// Error Check
-		if(mysql_error($connection))
+		if (mysql_error($connection))
 		{
 			$this->setError(mysql_errno($connection), mysql_error($connection));
 		}
@@ -205,13 +205,13 @@ 
 	function _fetch($result, $arrayIndexEndValue = NULL)
 	{
 		$output = array();
-		if(!$this->isConnected() || $this->isError() || !$result)
+		if (!$this->isConnected() || $this->isError() || !$result)
 		{
 			return $output;
 		}
-		while($tmp = $this->db_fetch_object($result))
+		while ($tmp = $this->db_fetch_object($result))
 		{
-			if($arrayIndexEndValue)
+			if ($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $tmp;
 			}
@@ -220,9 +220,9 @@ 
 				$output[] = $tmp;
 			}
 		}
-		if(count($output) == 1)
+		if (count($output) == 1)
 		{
-			if(isset($arrayIndexEndValue))
+			if (isset($arrayIndexEndValue))
 			{
 				return $output;
 			}
@@ -245,7 +245,7 @@ 
 		$query = sprintf("insert into `%ssequence` (seq) values ('0')", $this->prefix);
 		$this->_query($query);
 		$sequence = $this->db_insert_id();
-		if($sequence % 10000 == 0)
+		if ($sequence % 10000 == 0)
 		{
 			$query = sprintf("delete from  `%ssequence` where seq < %d", $this->prefix, $sequence);
 			$this->_query($query);
@@ -265,7 +265,7 @@ 
 		$query = sprintf("select password('%s') as password, old_password('%s') as old_password", $this->addQuotes($password), $this->addQuotes($password));
 		$result = $this->_query($query);
 		$tmp = $this->_fetch($result);
-		if($tmp->password === $saved_password || $tmp->old_password === $saved_password)
+		if ($tmp->password === $saved_password || $tmp->old_password === $saved_password)
 		{
 			return true;
 		}
@@ -282,7 +282,7 @@ 
 		$query = sprintf("show tables like '%s%s'", $this->prefix, $this->addQuotes($target_name));
 		$result = $this->_query($query);
 		$tmp = $this->_fetch($result);
-		if(!$tmp)
+		if (!$tmp)
 		{
 			return false;
 		}
@@ -302,13 +302,13 @@ 
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = false)
 	{
 		$type = $this->column_type[$type];
-		if(strtoupper($type) == 'INTEGER')
+		if (strtoupper($type) == 'INTEGER')
 		{
 			$size = '';
 		}
 
 		$query = sprintf("alter table `%s%s` add `%s` ", $this->prefix, $table_name, $column_name);
-		if($size)
+		if ($size)
 		{
 			$query .= sprintf(" %s(%s) ", $type, $size);
 		}
@@ -316,11 +316,11 @@ 
 		{
 			$query .= sprintf(" %s ", $type);
 		}
-		if(isset($default))
+		if (isset($default))
 		{
 			$query .= sprintf(" default '%s' ", $default);
 		}
-		if($notnull)
+		if ($notnull)
 		{
 			$query .= " not null ";
 		}
@@ -350,18 +350,18 @@ 
 	{
 		$query = sprintf("show fields from `%s%s`", $this->prefix, $table_name);
 		$result = $this->_query($query);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return;
 		}
 		$output = $this->_fetch($result);
-		if($output)
+		if ($output)
 		{
 			$column_name = strtolower($column_name);
-			foreach($output as $key => $val)
+			foreach ($output as $key => $val)
 			{
 				$name = strtolower($val->Field);
-				if($column_name == $name)
+				if ($column_name == $name)
 				{
 					return true;
 				}
@@ -382,7 +382,7 @@ 
 	 */
 	function addIndex($table_name, $index_name, $target_columns, $is_unique = false)
 	{
-		if(!is_array($target_columns))
+		if (!is_array($target_columns))
 		{
 			$target_columns = array($target_columns);
 		}
@@ -415,23 +415,23 @@ 
 		//$query = sprintf("show indexes from %s%s where key_name = '%s' ", $this->prefix, $table_name, $index_name);
 		$query = sprintf("show indexes from `%s%s`", $this->prefix, $table_name);
 		$result = $this->_query($query);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return;
 		}
 		$output = $this->_fetch($result);
-		if(!$output)
+		if (!$output)
 		{
 			return;
 		}
-		if(!is_array($output))
+		if (!is_array($output))
 		{
 			$output = array($output);
 		}
 
-		for($i = 0; $i < count($output); $i++)
+		for ($i = 0; $i < count($output); $i++)
 		{
-			if($output[$i]->Key_name == $index_name)
+			if ($output[$i]->Key_name == $index_name)
 			{
 				return true;
 			}
@@ -456,7 +456,7 @@ 
 	 */
 	function createTableByXmlFile($file_name)
 	{
-		if(!file_exists($file_name))
+		if (!file_exists($file_name))
 		{
 			return;
 		}
@@ -481,13 +481,13 @@ 
 		$xml_obj = $oXml->parse($xml_doc);
 		// Create a table schema
 		$table_name = $xml_obj->table->attrs->name;
-		if($this->isTableExists($table_name))
+		if ($this->isTableExists($table_name))
 		{
 			return;
 		}
-		$table_name = $this->prefix . $table_name;
+		$table_name = $this->prefix.$table_name;
 
-		if(!is_array($xml_obj->table->column))
+		if (!is_array($xml_obj->table->column))
 		{
 			$columns[] = $xml_obj->table->column;
 		}
@@ -500,7 +500,7 @@ 
 		$unique_list = array();
 		$index_list = array();
 
-		foreach($columns as $column)
+		foreach ($columns as $column)
 		{
 			$name = $column->attrs->name;
 			$type = $column->attrs->type;
@@ -512,47 +512,47 @@ 
 			$default = $column->attrs->default;
 			$auto_increment = $column->attrs->auto_increment;
 
-			$column_schema[] = sprintf('`%s` %s%s %s %s %s', $name, $this->column_type[$type], $size ? '(' . $size . ')' : '', isset($default) ? "default '" . $default . "'" : '', $notnull ? 'not null' : '', $auto_increment ? 'auto_increment' : '');
+			$column_schema[] = sprintf('`%s` %s%s %s %s %s', $name, $this->column_type[$type], $size ? '('.$size.')' : '', isset($default) ? "default '".$default."'" : '', $notnull ? 'not null' : '', $auto_increment ? 'auto_increment' : '');
 
-			if($primary_key)
+			if ($primary_key)
 			{
 				$primary_list[] = $name;
 			}
-			else if($unique)
+			else if ($unique)
 			{
 				$unique_list[$unique][] = $name;
 			}
-			else if($index)
+			else if ($index)
 			{
 				$index_list[$index][] = $name;
 			}
 		}
 
-		if(count($primary_list))
+		if (count($primary_list))
 		{
-			$column_schema[] = sprintf("primary key (%s)", '`' . implode($primary_list, '`,`') . '`');
+			$column_schema[] = sprintf("primary key (%s)", '`'.implode($primary_list, '`,`').'`');
 		}
 
-		if(count($unique_list))
+		if (count($unique_list))
 		{
-			foreach($unique_list as $key => $val)
+			foreach ($unique_list as $key => $val)
 			{
-				$column_schema[] = sprintf("unique %s (%s)", $key, '`' . implode($val, '`,`') . '`');
+				$column_schema[] = sprintf("unique %s (%s)", $key, '`'.implode($val, '`,`').'`');
 			}
 		}
 
-		if(count($index_list))
+		if (count($index_list))
 		{
-			foreach($index_list as $key => $val)
+			foreach ($index_list as $key => $val)
 			{
-				$column_schema[] = sprintf("index %s (%s)", $key, '`' . implode($val, '`,`') . '`');
+				$column_schema[] = sprintf("index %s (%s)", $key, '`'.implode($val, '`,`').'`');
 			}
 		}
 
 		$schema = sprintf('create table `%s` (%s%s) %s;', $this->addQuotes($table_name), "\n", implode($column_schema, ",\n"), "ENGINE = MYISAM  CHARACTER SET utf8 COLLATE utf8_general_ci");
 
 		$output = $this->_query($schema);
-		if(!$output)
+		if (!$output)
 			return false;
 	}
 
@@ -565,8 +565,8 @@ 
 	function _executeInsertAct($queryObject, $with_values = true)
 	{
 		$query = $this->getInsertSql($queryObject, $with_values, true);
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
-		if(is_a($query, 'BaseObject'))
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
+		if (is_a($query, 'BaseObject'))
 		{
 			return;
 		}
@@ -582,13 +582,13 @@ 
 	function _executeUpdateAct($queryObject, $with_values = true)
 	{
 		$query = $this->getUpdateSql($queryObject, $with_values, true);
-		if(is_a($query, 'BaseObject'))
+		if (is_a($query, 'BaseObject'))
 		{
-			if(!$query->toBool()) return $query;
+			if (!$query->toBool()) return $query;
 			else return;
 		}
 
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 
 
 		return $this->_query($query);
@@ -603,8 +603,8 @@ 
 	function _executeDeleteAct($queryObject, $with_values = true)
 	{
 		$query = $this->getDeleteSql($queryObject, $with_values, true);
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
-		if(is_a($query, 'BaseObject'))
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
+		if (is_a($query, 'BaseObject'))
 		{
 			return;
 		}
@@ -624,21 +624,21 @@ 
 	{
 		$limit = $queryObject->getLimit();
 		$result = NULL;
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			return $this->queryPageLimit($queryObject, $result, $connection, $with_values);
 		}
 		else
 		{
 			$query = $this->getSelectSql($queryObject, $with_values);
-			if(is_a($query, 'BaseObject'))
+			if (is_a($query, 'BaseObject'))
 			{
 				return;
 			}
-			$query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' ' . $this->comment_syntax, $queryObject->queryID) : '';
+			$query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' '.$this->comment_syntax, $queryObject->queryID) : '';
 
 			$result = $this->_query($query, $connection);
-			if($this->isError())
+			if ($this->isError())
 			{
 				return $this->queryError($queryObject);
 			}
@@ -647,7 +647,7 @@ 
 			$buff = new BaseObject();
 			$buff->data = $data;
 
-			if($queryObject->usesClickCount())
+			if ($queryObject->usesClickCount())
 			{
 				$update_query = $this->getClickCountQuery($queryObject);
 				$this->_executeUpdateAct($update_query, $with_values);
@@ -708,7 +708,7 @@ 
 	function queryError($queryObject)
 	{
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			$buff = new BaseObject();
 			$buff->total_count = 0;
@@ -737,48 +737,48 @@ 
 		$limit = $queryObject->getLimit();
 		// Total count
 		$temp_where = $queryObject->getWhereString($with_values, false);
-		$count_query = sprintf('select count(*) as "count" %s %s', 'FROM ' . $queryObject->getFromString($with_values), ($temp_where === '' ? '' : ' WHERE ' . $temp_where));
+		$count_query = sprintf('select count(*) as "count" %s %s', 'FROM '.$queryObject->getFromString($with_values), ($temp_where === '' ? '' : ' WHERE '.$temp_where));
 
 		// Check for distinct query and if found update count query structure
 		$temp_select = $queryObject->getSelectString($with_values);
 		$uses_distinct = stripos($temp_select, "distinct") !== false;
 		$uses_groupby = $queryObject->getGroupByString() != '';
-		if($uses_distinct || $uses_groupby)
+		if ($uses_distinct || $uses_groupby)
 		{
 			$count_query = sprintf('select %s %s %s %s'
 					, $temp_select == '*' ? '1' : $temp_select
-					, 'FROM ' . $queryObject->getFromString($with_values)
-					, ($temp_where === '' ? '' : ' WHERE ' . $temp_where)
-					, ($uses_groupby ? ' GROUP BY ' . $queryObject->getGroupByString() : '')
+					, 'FROM '.$queryObject->getFromString($with_values)
+					, ($temp_where === '' ? '' : ' WHERE '.$temp_where)
+					, ($uses_groupby ? ' GROUP BY '.$queryObject->getGroupByString() : '')
 			);
 
 			// If query uses grouping or distinct, count from original select
 			$count_query = sprintf('select count(*) as "count" from (%s) xet', $count_query);
 		}
 
-		$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' ' . $this->comment_syntax, $queryObject->queryID) : '';
+		$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' '.$this->comment_syntax, $queryObject->queryID) : '';
 		$result_count = $this->_query($count_query, $connection);
 		$count_output = $this->_fetch($result_count);
 		$total_count = (int) (isset($count_output->count) ? $count_output->count : NULL);
 
 		$list_count = $limit->list_count->getValue();
-		if(!$list_count)
+		if (!$list_count)
 		{
 			$list_count = 20;
 		}
 		$page_count = $limit->page_count->getValue();
-		if(!$page_count)
+		if (!$page_count)
 		{
 			$page_count = 10;
 		}
 		$page = $limit->page->getValue();
-		if(!$page || $page < 1)
+		if (!$page || $page < 1)
 		{
 			$page = 1;
 		}
 
 		// total pages
-		if($total_count)
+		if ($total_count)
 		{
 			$total_page = (int) (($total_count - 1) / $list_count) + 1;
 		}
@@ -788,7 +788,7 @@ 
 		}
 
 		// check the page variables
-		if($page > $total_page)
+		if ($page > $total_page)
 		{
 			// If requested page is bigger than total number of pages, return empty list
 			$buff = new BaseObject();
@@ -803,9 +803,9 @@ 
 
 		$query = $this->getSelectPageSql($queryObject, $with_values, $start_count, $list_count);
 
-		$query .= (__DEBUG_QUERY__ & 1 && $queryObject->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $queryObject->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 		$result = $this->_query($query, $connection);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return $this->queryError($queryObject);
 		}
@@ -833,44 +833,44 @@ 
 	function getSelectPageSql($query, $with_values = true, $start_count = 0, $list_count = 0)
 	{
 		$select = $query->getSelectString($with_values);
-		if($select == '')
+		if ($select == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$select = 'SELECT ' . $select;
+		$select = 'SELECT '.$select;
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$from = ' FROM ' . $from;
+		$from = ' FROM '.$from;
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$groupBy = $query->getGroupByString();
-		if($groupBy != '')
+		if ($groupBy != '')
 		{
-			$groupBy = ' GROUP BY ' . $groupBy;
+			$groupBy = ' GROUP BY '.$groupBy;
 		}
 
 		$orderBy = $query->getOrderByString();
-		if($orderBy != '')
+		if ($orderBy != '')
 		{
-			$orderBy = ' ORDER BY ' . $orderBy;
+			$orderBy = ' ORDER BY '.$orderBy;
 		}
 
 		$limit = $query->getLimitString();
-		if($limit != '')
+		if ($limit != '')
 		{
 			$limit = sprintf(' LIMIT %d, %d', $start_count, $list_count);
 		}
 
-		return $select . ' ' . $from . ' ' . $where . ' ' . $groupBy . ' ' . $orderBy . ' ' . $limit;
+		return $select.' '.$from.' '.$where.' '.$groupBy.' '.$orderBy.' '.$limit;
 	}
 
 }

Braces +20 added lines, -23 removed lines

@@ -46,7 +46,9 @@ 
 	function DBMysql($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if($auto_connect) {
+			$this->_connect();
+		}
 	}
 
 	/**
@@ -214,8 +216,7 @@ 
 			if($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $tmp;
-			}
-			else
+			} else
 			{
 				$output[] = $tmp;
 			}
@@ -225,8 +226,7 @@ 
 			if(isset($arrayIndexEndValue))
 			{
 				return $output;
-			}
-			else
+			} else
 			{
 				return $output[0];
 			}
@@ -311,8 +311,7 @@ 
 		if($size)
 		{
 			$query .= sprintf(" %s(%s) ", $type, $size);
-		}
-		else
+		} else
 		{
 			$query .= sprintf(" %s ", $type);
 		}
@@ -490,8 +489,7 @@ 
 		if(!is_array($xml_obj->table->column))
 		{
 			$columns[] = $xml_obj->table->column;
-		}
-		else
+		} else
 		{
 			$columns = $xml_obj->table->column;
 		}
@@ -517,12 +515,10 @@ 
 			if($primary_key)
 			{
 				$primary_list[] = $name;
-			}
-			else if($unique)
+			} else if($unique)
 			{
 				$unique_list[$unique][] = $name;
-			}
-			else if($index)
+			} else if($index)
 			{
 				$index_list[$index][] = $name;
 			}
@@ -552,8 +548,9 @@ 
 		$schema = sprintf('create table `%s` (%s%s) %s;', $this->addQuotes($table_name), "\n", implode($column_schema, ",\n"), "ENGINE = MYISAM  CHARACTER SET utf8 COLLATE utf8_general_ci");
 
 		$output = $this->_query($schema);
-		if(!$output)
-			return false;
+		if(!$output) {
+					return false;
+		}
 	}
 
 	/**
@@ -584,8 +581,11 @@ 
 		$query = $this->getUpdateSql($queryObject, $with_values, true);
 		if(is_a($query, 'BaseObject'))
 		{
-			if(!$query->toBool()) return $query;
-			else return;
+			if(!$query->toBool()) {
+				return $query;
+			} else {
+				return;
+			}
 		}
 
 		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
@@ -627,8 +627,7 @@ 
 		if($limit && $limit->isPageHandler())
 		{
 			return $this->queryPageLimit($queryObject, $result, $connection, $with_values);
-		}
-		else
+		} else
 		{
 			$query = $this->getSelectSql($queryObject, $with_values);
 			if(is_a($query, 'BaseObject'))
@@ -717,8 +716,7 @@ 
 			$buff->data = array();
 			$buff->page_navigation = new PageHandler(/* $total_count */0, /* $total_page */1, /* $page */1, /* $page_count */10); //default page handler values
 			return $buff;
-		}
-		else
+		} else
 		{
 			return;
 		}
@@ -781,8 +779,7 @@ 
 		if($total_count)
 		{
 			$total_page = (int) (($total_count - 1) / $list_count) + 1;
-		}
-		else
+		} else
 		{
 			$total_page = 1;
 		}

classes/object/BaseObject.class.php

Doc Comments +2 added lines, -2 removed lines

@@ -166,7 +166,7 @@ 
 	/**
 	 * Method to retrieve an object containing a key/value pairs
 	 *
-	 * @return BaseObject Returns an object containing key/value pairs
+	 * @return stdClass Returns an object containing key/value pairs
 	 */
 	function gets()
 	{
@@ -192,7 +192,7 @@ 
 	/**
 	 * Method to retrieve an object of key/value pairs
 	 *
-	 * @return BaseObject
+	 * @return stdClass
 	 */
 	function getObjectVars()
 	{

Braces +1 added lines, -2 removed lines

@@ -99,8 +99,7 @@
 		if($str = Context::getLang($message))
 		{
 			$this->message = $str;
-		}
-		else
+		} else
 		{
 			$this->message = $message;
 		}

Spacing +7 added lines, -7 removed lines

@@ -95,7 +95,7 @@ 
 	 */
 	function setMessage($message = 'success', $type = NULL)
 	{
-		if($str = Context::getLang($message))
+		if ($str = Context::getLang($message))
 		{
 			$this->message = $str;
 		}
@@ -138,14 +138,14 @@ 
 	 */
 	function adds($object)
 	{
-		if(is_object($object))
+		if (is_object($object))
 		{
 			$object = get_object_vars($object);
 		}
 
-		if(is_array($object))
+		if (is_array($object))
 		{
-			foreach($object as $key => $val)
+			foreach ($object as $key => $val)
 			{
 				$this->variables[$key] = $val;
 			}
@@ -172,7 +172,7 @@ 
 	{
 		$args = func_get_args();
 		$output = new stdClass();
-		foreach($args as $arg)
+		foreach ($args as $arg)
 		{
 			$output->{$arg} = $this->get($arg);
 		}
@@ -197,7 +197,7 @@ 
 	function getObjectVars()
 	{
 		$output = new stdClass();
-		foreach($this->variables as $key => $val)
+		foreach ($this->variables as $key => $val)
 		{
 			$output->{$key} = $val;
 		}
@@ -226,7 +226,7 @@ 
 	}
 }
 
-if(version_compare(PHP_VERSION, '7.2', '<') && !class_exists('Object', false))
+if (version_compare(PHP_VERSION, '7.2', '<') && !class_exists('Object', false))
 {
 	class_alias('BaseObject', 'Object');
 }

modules/admin/admin.admin.controller.php

Doc Comments +11 added lines, -3 removed lines

@@ -13,7 +13,7 @@ 
 
 	/**
 	 * initialization
-	 * @return void
+	 * @return ModuleObject|null
 	 */
 	function init()
 	{
@@ -52,7 +52,7 @@ 
 
 	/**
 	 * Regenerate all cache files
-	 * @return void
+	 * @return BaseObject|null
 	 */
 	function procAdminRecompileCacheFile()
 	{
@@ -156,6 +156,9 @@ 
 		return $this->setRedirectUrl(Context::get('error_return_url'), $output);
 	}
 
+	/**
+	 * @param BaseObject $vars
+	 */
 	public function updateDefaultDesignInfo($vars)
 	{
 		$siteDesignPath = _XE_PATH_ . 'files/site_design/';
@@ -207,6 +210,9 @@ 
 		return new BaseObject();
 	}
 
+	/**
+	 * @param stdClass $designInfo
+	 */
 	function makeDefaultDesignFile($designInfo, $site_srl = 0)
 	{
 		$buff = array();
@@ -433,6 +439,8 @@ 
 
 	/**
 	 * Insert favorite
+	 * @param string $siteSrl
+	 * @param string $module
 	 * @return object query result
 	 */
 	function _insertFavorite($siteSrl, $module, $type = 'module')
@@ -471,7 +479,7 @@ 
 
 	/**
 	 * Remove admin icon
-	 * @return object|void
+	 * @return BaseObject|null
 	 */
 	function procAdminRemoveIcons()
 	{

Braces +15 added lines, -15 removed lines

@@ -181,8 +181,7 @@ 
 		if(is_readable($siteDesignFile))
 		{
 			include($siteDesignFile);
-		}
-		else
+		} else
 		{
 			$designInfo = new stdClass();
 		}
@@ -198,7 +197,9 @@ 
 				$moduleName = 'page';
 			}
 
-			if(!isset($designInfo->module->{$moduleName})) $designInfo->module->{$moduleName} = new stdClass();
+			if(!isset($designInfo->module->{$moduleName})) {
+				$designInfo->module->{$moduleName} = new stdClass();
+			}
 			$designInfo->module->{$moduleName}->{$skinTarget} = $skinName;
 		}
 
@@ -337,8 +338,7 @@ 
 		if($isAgree == 'true')
 		{
 			$_SESSION['enviroment_gather'] = 'Y';
-		}
-		else
+		} else
 		{
 			$_SESSION['enviroment_gather'] = 'N';
 		}
@@ -374,12 +374,10 @@ 
 			if($type == 3)
 			{
 				$ext = 'png';
-			}
-			elseif($type == 2)
+			} elseif($type == 2)
 			{
 				$ext = 'jpg';
-			}
-			else
+			} else
 			{
 				$ext = 'gif';
 			}
@@ -392,8 +390,7 @@ 
 		if($adminTitle)
 		{
 			$oAdminConfig->adminTitle = strip_tags($adminTitle);
-		}
-		else
+		} else
 		{
 			unset($oAdminConfig->adminTitle);
 		}
@@ -488,8 +485,7 @@ 
 		if($file_exist)
 		{
 			@FileHandler::removeFile(_XE_PATH_ . 'files/attach/xeicon/' . $virtual_site . $iconname);
-		}
-		else
+		} else
 		{
 			return new BaseObject(-1, 'fail_to_delete');
 		}
@@ -533,7 +529,9 @@ 
 		if(!in_array(Context::getRequestMethod(), array('XMLRPC','JSON')))
 		{
 			$returnUrl = Context::get('success_return_url');
-			if(!$returnUrl) $returnUrl = getNotEncodedUrl('', 'act', 'dispAdminConfigGeneral');
+			if(!$returnUrl) {
+				$returnUrl = getNotEncodedUrl('', 'act', 'dispAdminConfigGeneral');
+			}
 			header('location:' . $returnUrl);
 			return;
 		}
@@ -577,7 +575,9 @@ 
 		if(!in_array(Context::getRequestMethod(), array('XMLRPC','JSON')))
 		{
 			$returnUrl = Context::get('success_return_url');
-			if(!$returnUrl) $returnUrl = getNotEncodedUrl('', 'act', 'dispAdminConfigGeneral');
+			if(!$returnUrl) {
+				$returnUrl = getNotEncodedUrl('', 'act', 'dispAdminConfigGeneral');
+			}
 			header('location:' . $returnUrl);
 			return;
 		}

Spacing +77 added lines, -77 removed lines

@@ -20,7 +20,7 @@ 
 		// forbit access if the user is not an administrator
 		$oMemberModel = getModel('member');
 		$logged_info = $oMemberModel->getLoggedInfo();
-		if($logged_info->is_admin != 'Y')
+		if ($logged_info->is_admin != 'Y')
 		{
 			return $this->stop("msg_is_not_administrator");
 		}
@@ -33,20 +33,20 @@ 
 	function procAdminMenuReset()
 	{
 		$menuSrl = Context::get('menu_srl');
-		if(!$menuSrl)
+		if (!$menuSrl)
 		{
 			return $this->stop('msg_invalid_request');
 		}
 
 		$oMenuAdminController = getAdminController('menu');
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
-			$cache_key = 'admin_menu_langs:' . Context::getLangType();
+			$cache_key = 'admin_menu_langs:'.Context::getLangType();
 			$oCacheHandler->delete($cache_key);
 		}
 		$output = $oMenuAdminController->deleteMenu($menuSrl);
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			return $output;
 		}
@@ -63,30 +63,30 @@ 
 	function procAdminRecompileCacheFile()
 	{
 		// rename cache dir
-		$temp_cache_dir = './files/cache_' . $_SERVER['REQUEST_TIME'];
+		$temp_cache_dir = './files/cache_'.$_SERVER['REQUEST_TIME'];
 		FileHandler::rename('./files/cache', $temp_cache_dir);
 		FileHandler::makeDir('./files/cache');
 
 		// remove module extend cache
-		FileHandler::removeFile(_XE_PATH_ . 'files/config/module_extend.php');
+		FileHandler::removeFile(_XE_PATH_.'files/config/module_extend.php');
 
 		// remove debug files
-		FileHandler::removeFile(_XE_PATH_ . 'files/_debug_message.php');
-		FileHandler::removeFile(_XE_PATH_ . 'files/_debug_db_query.php');
-		FileHandler::removeFile(_XE_PATH_ . 'files/_slowlog_query.php');
-		FileHandler::removeFile(_XE_PATH_ . 'files/_slowlog_trigger.php');
-		FileHandler::removeFile(_XE_PATH_ . 'files/_slowlog_addon.php');
-		FileHandler::removeFile(_XE_PATH_ . 'files/_slowlog_widget.php');
+		FileHandler::removeFile(_XE_PATH_.'files/_debug_message.php');
+		FileHandler::removeFile(_XE_PATH_.'files/_debug_db_query.php');
+		FileHandler::removeFile(_XE_PATH_.'files/_slowlog_query.php');
+		FileHandler::removeFile(_XE_PATH_.'files/_slowlog_trigger.php');
+		FileHandler::removeFile(_XE_PATH_.'files/_slowlog_addon.php');
+		FileHandler::removeFile(_XE_PATH_.'files/_slowlog_widget.php');
 
 		$oModuleModel = getModel('module');
 		$module_list = $oModuleModel->getModuleList();
 
 		// call recompileCache for each module
-		foreach($module_list as $module)
+		foreach ($module_list as $module)
 		{
 			$oModule = NULL;
 			$oModule = getClass($module->module);
-			if(method_exists($oModule, 'recompileCache'))
+			if (method_exists($oModule, 'recompileCache'))
 			{
 				$oModule->recompileCache();
 			}
@@ -97,37 +97,37 @@ 
 		$oObjectCacheHandler = CacheHandler::getInstance('object');
 		$oTemplateCacheHandler = CacheHandler::getInstance('template');
 
-		if($oObjectCacheHandler->isSupport())
+		if ($oObjectCacheHandler->isSupport())
 		{
 			$truncated[] = $oObjectCacheHandler->truncate();
 		}
 
-		if($oTemplateCacheHandler->isSupport())
+		if ($oTemplateCacheHandler->isSupport())
 		{
 			$truncated[] = $oTemplateCacheHandler->truncate();
 		}
 
-		if(count($truncated) && in_array(FALSE, $truncated))
+		if (count($truncated) && in_array(FALSE, $truncated))
 		{
 			return new BaseObject(-1, 'msg_self_restart_cache_engine');
 		}
 
 		// remove cache dir
 		$tmp_cache_list = FileHandler::readDir('./files', '/(^cache_[0-9]+)/');
-		if($tmp_cache_list)
+		if ($tmp_cache_list)
 		{
-			foreach($tmp_cache_list as $tmp_dir)
+			foreach ($tmp_cache_list as $tmp_dir)
 			{
-				if($tmp_dir)
+				if ($tmp_dir)
 				{
-					FileHandler::removeDir('./files/' . $tmp_dir);
+					FileHandler::removeDir('./files/'.$tmp_dir);
 				}
 			}
 		}
 
 		// remove duplicate indexes (only for CUBRID)
 		$db_type = Context::getDBType();
-		if($db_type == 'cubrid')
+		if ($db_type == 'cubrid')
 		{
 			$db = DB::getInstance();
 			$db->deleteDuplicateIndexes();
@@ -149,13 +149,13 @@ 
 		$oMemberController = getController('member');
 		$oMemberController->procMemberLogout();
 
-		header('Location: ' . getNotEncodedUrl('', 'module', 'admin'));
+		header('Location: '.getNotEncodedUrl('', 'module', 'admin'));
 	}
 
 	public function procAdminInsertDefaultDesignInfo()
 	{
 		$vars = Context::getRequestVars();
-		if(!$vars->site_srl)
+		if (!$vars->site_srl)
 		{
 			$vars->site_srl = 0;
 		}
@@ -167,27 +167,27 @@ 
 
 	public function updateDefaultDesignInfo($vars)
 	{
-		$siteDesignPath = _XE_PATH_ . 'files/site_design/';
+		$siteDesignPath = _XE_PATH_.'files/site_design/';
 
 		$vars->module_skin = json_decode($vars->module_skin);
 
-		if(!is_dir($siteDesignPath))
+		if (!is_dir($siteDesignPath))
 		{
 			FileHandler::makeDir($siteDesignPath);
 		}
 
-		$siteDesignFile = _XE_PATH_ . 'files/site_design/design_' . $vars->site_srl . '.php';
+		$siteDesignFile = _XE_PATH_.'files/site_design/design_'.$vars->site_srl.'.php';
 
 		$layoutTarget = 'layout_srl';
 		$skinTarget = 'skin';
 
-		if($vars->target_type == 'M')
+		if ($vars->target_type == 'M')
 		{
 			$layoutTarget = 'mlayout_srl';
 			$skinTarget = 'mskin';
 		}
 
-		if(is_readable($siteDesignFile))
+		if (is_readable($siteDesignFile))
 		{
 			include($siteDesignFile);
 		}
@@ -200,14 +200,14 @@ 
 
 		$designInfo->{$layoutTarget} = $layoutSrl;
 
-		foreach($vars->module_skin as $moduleName => $skinName)
+		foreach ($vars->module_skin as $moduleName => $skinName)
 		{
-			if($moduleName == 'ARTICLE')
+			if ($moduleName == 'ARTICLE')
 			{
 				$moduleName = 'page';
 			}
 
-			if(!isset($designInfo->module->{$moduleName})) $designInfo->module->{$moduleName} = new stdClass();
+			if (!isset($designInfo->module->{$moduleName})) $designInfo->module->{$moduleName} = new stdClass();
 			$designInfo->module->{$moduleName}->{$skinTarget} = $skinName;
 		}
 
@@ -222,28 +222,28 @@ 
 		$buff[] = '<?php if(!defined("__XE__")) exit();';
 		$buff[] = '$designInfo = new stdClass;';
 
-		if($designInfo->layout_srl)
+		if ($designInfo->layout_srl)
 		{
 			$buff[] = sprintf('$designInfo->layout_srl = %s; ', $designInfo->layout_srl);
 		}
 
-		if($designInfo->mlayout_srl)
+		if ($designInfo->mlayout_srl)
 		{
 			$buff[] = sprintf('$designInfo->mlayout_srl = %s;', $designInfo->mlayout_srl);
 		}
 
 		$buff[] = '$designInfo->module = new stdClass;';
 
-		foreach($designInfo->module as $moduleName => $skinInfo)
+		foreach ($designInfo->module as $moduleName => $skinInfo)
 		{
 			$buff[] = sprintf('$designInfo->module->%s = new stdClass;', $moduleName);
-			foreach($skinInfo as $target => $skinName)
+			foreach ($skinInfo as $target => $skinName)
 			{
 				$buff[] = sprintf('$designInfo->module->%s->%s = \'%s\';', $moduleName, $target, $skinName);
 			}
 		}
 
-		$siteDesignFile = _XE_PATH_ . 'files/site_design/design_' . $site_srl . '.php';
+		$siteDesignFile = _XE_PATH_.'files/site_design/design_'.$site_srl.'.php';
 		FileHandler::writeFile($siteDesignFile, implode(PHP_EOL, $buff));
 	}
 
@@ -259,13 +259,13 @@ 
 		// check favorite exists
 		$oModel = getAdminModel('admin');
 		$output = $oModel->isExistsFavorite($siteSrl, $moduleName);
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			return $output;
 		}
 
 		// if exists, delete favorite
-		if($output->get('result'))
+		if ($output->get('result'))
 		{
 			$favoriteSrl = $output->get('favoriteSrl');
 			$output = $this->_deleteFavorite($favoriteSrl);
@@ -278,7 +278,7 @@ 
 			$result = 'on';
 		}
 
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			return $output;
 		}
@@ -296,31 +296,31 @@ 
 	{
 		$oModel = getAdminModel('admin');
 		$output = $oModel->getFavoriteList();
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			return $output;
 		}
 
 		$favoriteList = $output->get('favoriteList');
-		if(!$favoriteList)
+		if (!$favoriteList)
 		{
 			return new BaseObject();
 		}
 
 		$deleteTargets = array();
-		foreach($favoriteList as $favorite)
+		foreach ($favoriteList as $favorite)
 		{
-			if($favorite->type == 'module')
+			if ($favorite->type == 'module')
 			{
-				$modulePath = _XE_PATH_ . 'modules/' . $favorite->module;
-				if(!is_dir($modulePath))
+				$modulePath = _XE_PATH_.'modules/'.$favorite->module;
+				if (!is_dir($modulePath))
 				{
 					$deleteTargets[] = $favorite->admin_favorite_srl;
 				}
 			}
 		}
 
-		if(!count($deleteTargets))
+		if (!count($deleteTargets))
 		{
 			return new BaseObject();
 		}
@@ -328,7 +328,7 @@ 
 		$args = new stdClass();
 		$args->admin_favorite_srls = $deleteTargets;
 		$output = executeQuery('admin.deleteFavorites', $args);
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			return $output;
 		}
@@ -343,7 +343,7 @@ 
 	function procAdminEnviromentGatheringAgreement()
 	{
 		$isAgree = Context::get('is_agree');
-		if($isAgree == 'true')
+		if ($isAgree == 'true')
 		{
 			$_SESSION['enviroment_gather'] = 'Y';
 		}
@@ -368,23 +368,23 @@ 
 		$oModuleModel = getModel('module');
 		$oAdminConfig = $oModuleModel->getModuleConfig('admin');
 
-		if(!is_object($oAdminConfig))
+		if (!is_object($oAdminConfig))
 		{
 			$oAdminConfig = new stdClass();
 		}
 
-		if($file['tmp_name'])
+		if ($file['tmp_name'])
 		{
 			$target_path = 'files/attach/images/admin/';
 			FileHandler::makeDir($target_path);
 
 			// Get file information
 			list($width, $height, $type, $attrs) = @getimagesize($file['tmp_name']);
-			if($type == 3)
+			if ($type == 3)
 			{
 				$ext = 'png';
 			}
-			elseif($type == 2)
+			elseif ($type == 2)
 			{
 				$ext = 'jpg';
 			}
@@ -398,7 +398,7 @@ 
 
 			$oAdminConfig->adminLogo = $target_filename;
 		}
-		if($adminTitle)
+		if ($adminTitle)
 		{
 			$oAdminConfig->adminTitle = strip_tags($adminTitle);
 		}
@@ -407,7 +407,7 @@ 
 			unset($oAdminConfig->adminTitle);
 		}
 
-		if($oAdminConfig)
+		if ($oAdminConfig)
 		{
 			$oModuleController = getController('module');
 			$oModuleController->insertModuleConfig('admin', $oAdminConfig);
@@ -428,7 +428,7 @@ 
 		$oModuleModel = getModel('module');
 		$oAdminConfig = $oModuleModel->getModuleConfig('admin');
 
-		FileHandler::removeFile(_XE_PATH_ . $oAdminConfig->adminLogo);
+		FileHandler::removeFile(_XE_PATH_.$oAdminConfig->adminLogo);
 		unset($oAdminConfig->adminLogo);
 
 		$oModuleController = getController('module');
@@ -487,16 +487,16 @@ 
 
 		$site_info = Context::get('site_module_info');
 		$virtual_site = '';
-		if($site_info->site_srl) 
+		if ($site_info->site_srl) 
 		{
-			$virtual_site = $site_info->site_srl . '/';
+			$virtual_site = $site_info->site_srl.'/';
 		}
 
 		$iconname = Context::get('iconname');
-		$file_exist = FileHandler::readFile(_XE_PATH_ . 'files/attach/xeicon/' . $virtual_site . $iconname);
-		if($file_exist)
+		$file_exist = FileHandler::readFile(_XE_PATH_.'files/attach/xeicon/'.$virtual_site.$iconname);
+		if ($file_exist)
 		{
-			@FileHandler::removeFile(_XE_PATH_ . 'files/attach/xeicon/' . $virtual_site . $iconname);
+			@FileHandler::removeFile(_XE_PATH_.'files/attach/xeicon/'.$virtual_site.$iconname);
 		}
 		else
 		{
@@ -517,33 +517,33 @@ 
 		$db_info->sitelock_message = $vars->sitelock_message;
 
 		$whitelist = $vars->sitelock_whitelist;
-		$whitelist = preg_replace("/[\r|\n|\r\n]+/",",",$whitelist);
-		$whitelist = preg_replace("/\s+/","",$whitelist);
-		if(preg_match('/(<\?|<\?php|\?>)/xsm', $whitelist))
+		$whitelist = preg_replace("/[\r|\n|\r\n]+/", ",", $whitelist);
+		$whitelist = preg_replace("/\s+/", "", $whitelist);
+		if (preg_match('/(<\?|<\?php|\?>)/xsm', $whitelist))
 		{
 			$whitelist = '';
 		}
-		$whitelist .= ',127.0.0.1,' . $_SERVER['REMOTE_ADDR'];
-		$whitelist = explode(',',trim($whitelist, ','));
+		$whitelist .= ',127.0.0.1,'.$_SERVER['REMOTE_ADDR'];
+		$whitelist = explode(',', trim($whitelist, ','));
 		$whitelist = array_unique($whitelist);
 
-		if(!IpFilter::validate($whitelist)) {
+		if (!IpFilter::validate($whitelist)) {
 			return new BaseObject(-1, 'msg_invalid_ip');
 		}
 
 		$db_info->sitelock_whitelist = $whitelist;
 
 		$oInstallController = getController('install');
-		if(!$oInstallController->makeConfigFile())
+		if (!$oInstallController->makeConfigFile())
 		{
 			return new BaseObject(-1, 'msg_invalid_request');
 		}
 
-		if(!in_array(Context::getRequestMethod(), array('XMLRPC','JSON')))
+		if (!in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON')))
 		{
 			$returnUrl = Context::get('success_return_url');
-			if(!$returnUrl) $returnUrl = getNotEncodedUrl('', 'act', 'dispAdminConfigGeneral');
-			header('location:' . $returnUrl);
+			if (!$returnUrl) $returnUrl = getNotEncodedUrl('', 'act', 'dispAdminConfigGeneral');
+			header('location:'.$returnUrl);
 			return;
 		}
 	}
@@ -574,20 +574,20 @@ 
 		$db_info->embed_white_iframe = $white_iframe;
 
 		$oInstallController = getController('install');
-		if(!$oInstallController->makeConfigFile())
+		if (!$oInstallController->makeConfigFile())
 		{
 			return new BaseObject(-1, 'msg_invalid_request');
 		}
 
-		require_once(_XE_PATH_ . 'classes/security/EmbedFilter.class.php');
+		require_once(_XE_PATH_.'classes/security/EmbedFilter.class.php');
 		$oEmbedFilter = EmbedFilter::getInstance();
 		$oEmbedFilter->_makeWhiteDomainList($whitelist);
 
-		if(!in_array(Context::getRequestMethod(), array('XMLRPC','JSON')))
+		if (!in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON')))
 		{
 			$returnUrl = Context::get('success_return_url');
-			if(!$returnUrl) $returnUrl = getNotEncodedUrl('', 'act', 'dispAdminConfigGeneral');
-			header('location:' . $returnUrl);
+			if (!$returnUrl) $returnUrl = getNotEncodedUrl('', 'act', 'dispAdminConfigGeneral');
+			header('location:'.$returnUrl);
 			return;
 		}
 	}