FrontEndFileHandler - Code Metrics - Inspection of "Merge branch 'hotfix/1.8.45'" - xpressengine/xe-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 78ace2...4b54c6 )

by gyeong-won

created 2017-09-12 14:42 UTC

FrontEndFileHandler C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	450
Duplicated Lines	5.11 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

Metric	Value
dl	23
loc	450
rs	5.7474
c	0
b	0
f	0
wmc	66
lcom	2
cbo	3

11 Methods

Rating	Name	Duplication	Size	Complexity
A	isSsl()	0	12	2
D	loadFile()	13	45	9
C	getFileInfo()	0	64	10
B	unloadFile()	0	26	5
B	unloadAllFiles()	0	16	5
C	getCssFileList()	0	35	8
C	getJsFileList()	10	53	13
A	_sortMap()	0	4	1
B	_normalizeFilePath()	0	20	6
B	_getAbsFileUrl()	0	23	5
A	_arrangeCssIndex()	0	13	2

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like FrontEndFileHandler often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use FrontEndFileHandler, and based on these observations, apply Extract Interface, too.

<?php
/* Copyright (C) NAVER <http://www.navercorp.com> */

/**
 * Handle front end files
 * @author NAVER ([email protected])
 * */
class FrontEndFileHandler extends Handler
{

	static $isSSL = null;

	/**
	 * Map for css
	 * @var array
	 */
	var $cssMap = array();

	/**
	 * Map for Javascript at head
	 * @var array
	 */
	var $jsHeadMap = array();

	/**
	 * Map for Javascript at body
	 * @var array
	 */
	var $jsBodyMap = array();

	/**
	 * Index for css
	 * @var array
	 */
	var $cssMapIndex = array();

	/**
	 * Index for javascript at head
	 * @var array
	 */
	var $jsHeadMapIndex = array();

	/**
	 * Index for javascript at body
	 * @var array
	 */
	var $jsBodyMapIndex = array();

	/**
	 * Check SSL
	 *
	 * @return bool If using ssl returns true, otherwise returns false.
     * @deprecated
	 */
	function isSsl()
	{
		if(!is_null(self::$isSSL))
		{
			return self::$isSSL;
		}

		$url_info = parse_url(Context::getRequestUrl());
		self::$isSSL = ($url_info['scheme'] == 'https');

		return self::$isSSL;
	}

	/**
	 * Load front end file
	 *
	 * The $args is use as below. File type(js, css) is detected by file extension.
	 *
	 * <pre>
	 * case js
	 * 		$args[0]: file name
	 * 		$args[1]: type (head | body)
	 * 		$args[2]: target IE
	 * 		$args[3]: index
	 * case css
	 * 		$args[0]: file name
	 * 		$args[1]: media
	 * 		$args[2]: target IE
	 * 		$args[3]: index
	 * </pre>
	 *
	 * @param array $args Arguments
	 * @return void
	 * */
	function loadFile($args)
	{
		if(!is_array($args))
		{
			$args = array($args);
		}
		$file = $this->getFileInfo($args[0], $args[2], $args[1]);

		$availableExtension = array('css' => 1, 'js' => 1);
		if(!isset($availableExtension[$file->fileExtension]))
		{
			return;
		}

		$file->index = (int) $args[3];

		if($file->fileExtension == 'css')
		{
			$map = &$this->cssMap;
			$mapIndex = &$this->cssMapIndex;

			$this->_arrangeCssIndex($pathInfo['dirname'], $file);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}
		else if($file->fileExtension == 'js')
		{
			if($args[1] == 'body')
			{
				$map = &$this->jsBodyMap;
				$mapIndex = &$this->jsBodyMapIndex;
			}
			else
			{
				$map = &$this->jsHeadMap;
				$mapIndex = &$this->jsHeadMapIndex;
			}
		}

		(is_null($file->index)) ? $file->index = 0 : $file->index = $file->index;
		if(!isset($mapIndex[$file->key]) || $mapIndex[$file->key] > $file->index)
		{
			$this->unloadFile($args[0], $args[2], $args[1]);
			$map[$file->index][$file->key] = $file;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			$mapIndex[$file->key] = $file->index;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}
	}

	/**
	 * Get file information
	 *
	 * @param string $fileName The file name
	 * @param string $targetIe Target IE of file
	 * @param string $media Media of file
	 * @return stdClass The file information
	 */
	private function getFileInfo($fileName, $targetIe = '', $media = 'all')
	{
		static $existsInfo = array();

		if(isset($existsInfo[$existsKey]))
		{
			return $existsInfo[$existsKey];

		}

		$fileName = preg_replace('/(?:[\/]{3,})(.*)/', '//$1', $fileName);
		$url_info = parse_url($fileName);
		$pathInfo = pathinfo(str_replace('?' . $url_info['query'], '', $fileName));

		$file = new stdClass();
		$file->fileName = basename($url_info['path']);
		$file->filePath = $this->_getAbsFileUrl($pathInfo['dirname']);
		$file->fileRealPath = FileHandler::getRealPath($pathInfo['dirname']);
		$file->fileExtension = strtolower($pathInfo['extension']);
		$file->fileNameNoExt = preg_replace('/\.min$/', '', $pathInfo['filename']);
		$file->query = $url_info['query'];
		$file->external = !!$url_info['host'];
		$file->keyName = implode('.', array($file->fileNameNoExt, $file->fileExtension));
		$file->cdnPath = $this->_normalizeFilePath($pathInfo['dirname']);

		if(!$file->external)
		{
			if(!__DEBUG__ && __XE_VERSION_STABLE__)
			{
				// if no debug mode, load minifed file
				$minifiedFileName = implode('.', array($file->fileNameNoExt, 'min', $file->fileExtension));
				$minifiedRealPath = implode('/', array($file->fileRealPath, $minifiedFileName));
				if(file_exists($minifiedRealPath))
				{
					$file->fileName = $minifiedFileName;
				}
			}
			else
			{
				// Remove .min
				if(file_exists(implode('/', array($file->fileRealPath, $file->keyName))))
				{
					$file->fileName = $file->keyName;
				}
			}
		}

		$file->targetIe = $targetIe;

		if($file->fileExtension == 'css')
		{
			$file->media = $media;
			if(!$file->media)
			{
				$file->media = 'all';
			}
			$file->key = $file->filePath . $file->keyName . "\t" . $file->targetIe . "\t" . $file->media;
		}
		else if($file->fileExtension == 'js')
		{
			$file->key = $file->filePath . $file->keyName . "\t" . $file->targetIe;
		}

		return $file;
	}

	/**
	 * Unload front end file
	 *
	 * @param string $fileName The file name to unload
	 * @param string $targetIe Target IE of file to unload
	 * @param string $media Media of file to unload. Only use when file is css.
	 * @return void
	 */
	function unloadFile($fileName, $targetIe = '', $media = 'all')
	{
		$file = $this->getFileInfo($fileName, $targetIe, $media);

		if($file->fileExtension == 'css')
		{
			if(isset($this->cssMapIndex[$file->key]))
			{
				$index = $this->cssMapIndex[$file->key];
				unset($this->cssMap[$index][$file->key], $this->cssMapIndex[$file->key]);
			}
		}
		else
		{
			if(isset($this->jsHeadMapIndex[$file->key]))
			{
				$index = $this->jsHeadMapIndex[$file->key];
				unset($this->jsHeadMap[$index][$file->key], $this->jsHeadMapIndex[$file->key]);
			}
			if(isset($this->jsBodyMapIndex[$file->key]))
			{
				$index = $this->jsBodyMapIndex[$file->key];
				unset($this->jsBodyMap[$index][$file->key], $this->jsBodyMapIndex[$file->key]);
			}
		}
	}

	/**
	 * Unload all front end file
	 *
	 * @param string $type Type to unload. all, css, js
	 * @return void
	 */
	function unloadAllFiles($type = 'all')
	{
		if($type == 'css' || $type == 'all')
		{
			$this->cssMap = array();
			$this->cssMapIndex = array();
		}

		if($type == 'js' || $type == 'all')
		{
			$this->jsHeadMap = array();
			$this->jsBodyMap = array();
			$this->jsHeadMapIndex = array();
			$this->jsBodyMapIndex = array();
		}
	}

	/**
	 * Get css file list
	 *
	 * @return array Returns css file list. Array contains file, media, targetie.
	 */
	function getCssFileList()
	{
		$map = &$this->cssMap;
		$mapIndex = &$this->cssMapIndex;

		$this->_sortMap($map, $mapIndex);

		$result = array();
		foreach($map as $indexedMap)
		{
			foreach($indexedMap as $file)
			{
				$query = '';
				if(!$file->external && is_readable($file->cdnPath . '/' . $file->fileName))
				{
					$query = date('YmdHis', filemtime($file->cdnPath . '/' . $file->fileName));
				}
				if($file->query)
				{
					if($query) $query .= '&';
					$query .= $file->query;
				}
				$query = ($query) ? '?' . $query : '';

				$fullFilePath = $file->filePath . '/' . $file->fileName . $query;
				$result[] = array(
					'file' => $fullFilePath,
					'media' => $file->media,
					'targetie' => $file->targetIe
				);
			}
		}

		return $result;
	}

	/**
	 * Get javascript file list
	 *
	 * @param string $type Type of javascript. head, body
	 * @return array Returns javascript file list. Array contains file, targetie.
	 */
	function getJsFileList($type = 'head')
	{

		$ignore = array('modernizr.js', 'common.js', 'js_app.js', 'xml2json.js', 'xml_handler.js', 'xml_js_filter.js');

		if($type == 'head')
		{
			$map = &$this->jsHeadMap;
			$mapIndex = &$this->jsHeadMapIndex;
		}
		else
		{
			$map = &$this->jsBodyMap;
			$mapIndex = &$this->jsBodyMapIndex;
		}

		$this->_sortMap($map, $mapIndex);

		$result = array();
		foreach($map as $indexedMap)
		{
			foreach($indexedMap as $file)
			{
				if((!__DEBUG__ && __XE_VERSION_STABLE__) && $file->filePath === '/common/js')
				{
					if(in_array($file->fileName, $ignore))
					{
						continue;
					}
				}

				$query = '';
				if(!$file->external && is_readable($file->cdnPath . '/' . $file->fileName))
				{
					$query = date('YmdHis', filemtime($file->cdnPath . '/' . $file->fileName));
				}
				if($file->query)
				{
					if($query) $query .= '&';
					$query .= $file->query;
				}
				$query = ($query) ? '?' . $query : '';

				$fullFilePath = $file->filePath . '/' . $file->fileName . $query;
				$result[] = array(
					'file' => $fullFilePath,
					'targetie' => $file->targetIe
				);
			}
		}

		return $result;
	}

	/**
	 * Sort a map
	 *
	 * @param array $map Array to sort
	 * @param array $index Not used
	 * @return void
	 */
	function _sortMap(&$map, &$index)

	{
		ksort($map);
	}

	/**
	 * Normalize File path
	 *
	 * @param string $path Path to normalize
	 * @return string Normalized path
	 */
	function _normalizeFilePath($path)
	{
		if(strpos($path, '://') === FALSE && $path{0} != '/' && $path{0} != '.')
		{
			$path = './' . $path;
		}
		elseif(!strncmp($path, '//', 2))
		{
			return preg_replace('#^//+#', '//', $path);
		}

		$path = preg_replace('@/\./|(?<!:)\/\/@', '/', $path);

		while(strpos($path, '/../'))
		{
			$path = preg_replace('/\/([^\/]+)\/\.\.\//s', '/', $path, 1);
		}

		return $path;
	}

	/**
	 * Get absolute file url
	 *
	 * @param string $path Path to get absolute url
	 * @return string Absolute url
	 */
	function _getAbsFileUrl($path)
	{
		$path = $this->_normalizeFilePath($path);
		$script_path = getScriptPath();

		if(strpos($path, './') === 0)
		{
			if($script_path == '/' || $script_path == '\\')
			{
				$path = '/' . substr($path, 2);
			}
			else
			{
				$path = $script_path . substr($path, 2);
			}
		}
		else if(strpos($file, '../') === 0)

		{
			$path = $this->_normalizeFilePath($script_path . $path);
		}

		return $path;
	}

	/**
	 * Arrage css index
	 *
	 * @param string $dirName First directory  name of css path
	 * @param array $file file info.
	 * @return void
	 */
	function _arrangeCssIndex($dirName, &$file)
	{
		if($file->index !== 0)
		{
			return;
		}

		$dirName = str_replace('./', '', $dirName);
		$tmp = explode('/', $dirName);

		$cssSortList = array('common' => -100000, 'layouts' => -90000, 'modules' => -80000, 'widgets' => -70000, 'addons' => -60000);
		$file->index = $cssSortList[$tmp[0]];
	}

}
/* End of file FrontEndFileHandler.class.php */
/* Location: ./classes/frontendfile/FrontEndFileHandler.class.php */


GitHub Access Token became invalid

Push — master ( 78ace2...4b54c6 )

FrontEndFileHandler C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

1		<?php
2		/* Copyright (C) NAVER <http://www.navercorp.com> */
3
4		/**
5		* Handle front end files
6		* @author NAVER ([email protected])
7		* */
8		class FrontEndFileHandler extends Handler
9		{
10
11		static $isSSL = null;
12
13		/**
14		* Map for css
15		* @var array
16		*/
17		var $cssMap = array();
18
19		/**
20		* Map for Javascript at head
21		* @var array
22		*/
23		var $jsHeadMap = array();
24
25		/**
26		* Map for Javascript at body
27		* @var array
28		*/
29		var $jsBodyMap = array();
30
31		/**
32		* Index for css
33		* @var array
34		*/
35		var $cssMapIndex = array();
36
37		/**
38		* Index for javascript at head
39		* @var array
40		*/
41		var $jsHeadMapIndex = array();
42
43		/**
44		* Index for javascript at body
45		* @var array
46		*/
47		var $jsBodyMapIndex = array();
48
49		/**
50		* Check SSL
51		*
52		* @return bool If using ssl returns true, otherwise returns false.
53		* @deprecated
54		*/
55		function isSsl()
56		{
57		if(!is_null(self::$isSSL))
58		{
59		return self::$isSSL;
60		}
61
62		$url_info = parse_url(Context::getRequestUrl());
63		self::$isSSL = ($url_info['scheme'] == 'https');
64
65		return self::$isSSL;
66		}
67
68		/**
69		* Load front end file
70		*
71		* The $args is use as below. File type(js, css) is detected by file extension.
72		*
73		* <pre>
74		* case js
75		* $args[0]: file name
76		* $args[1]: type (head \| body)
77		* $args[2]: target IE
78		* $args[3]: index
79		* case css
80		* $args[0]: file name
81		* $args[1]: media
82		* $args[2]: target IE
83		* $args[3]: index
84		* </pre>
85		*
86		* @param array $args Arguments
87		* @return void
88		* */
89		function loadFile($args)
90		{
91		if(!is_array($args))
92		{
93		$args = array($args);
94		}
95		$file = $this->getFileInfo($args[0], $args[2], $args[1]);
96
97		$availableExtension = array('css' => 1, 'js' => 1);
98		if(!isset($availableExtension[$file->fileExtension]))
99		{
100		return;
101		}
102
103		$file->index = (int) $args[3];
104
105		if($file->fileExtension == 'css')
106		{
107		$map = &$this->cssMap;
108		$mapIndex = &$this->cssMapIndex;
109
110		$this->_arrangeCssIndex($pathInfo['dirname'], $file);
		0 ignored issues – show Bug introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report The variable `$pathInfo` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Documentation introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report `$file` is of type `object<stdClass>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
111		}
112	View Code Duplication	else if($file->fileExtension == 'js')
113		{
114		if($args[1] == 'body')
115		{
116		$map = &$this->jsBodyMap;
117		$mapIndex = &$this->jsBodyMapIndex;
118		}
119		else
120		{
121		$map = &$this->jsHeadMap;
122		$mapIndex = &$this->jsHeadMapIndex;
123		}
124		}
125
126		(is_null($file->index)) ? $file->index = 0 : $file->index = $file->index;
127		if(!isset($mapIndex[$file->key]) \|\| $mapIndex[$file->key] > $file->index)
128		{
129		$this->unloadFile($args[0], $args[2], $args[1]);
130		$map[$file->index][$file->key] = $file;
		0 ignored issues – show Bug introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report The variable `$map` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
131		$mapIndex[$file->key] = $file->index;
		0 ignored issues – show Bug introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report The variable `$mapIndex` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
132		}
133		}
134
135		/**
136		* Get file information
137		*
138		* @param string $fileName The file name
139		* @param string $targetIe Target IE of file
140		* @param string $media Media of file
141		* @return stdClass The file information
142		*/
143		private function getFileInfo($fileName, $targetIe = '', $media = 'all')
144		{
145		static $existsInfo = array();
146
147		if(isset($existsInfo[$existsKey]))
148		{
149		return $existsInfo[$existsKey];
		0 ignored issues – show Bug introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report The variable `$existsKey` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
150		}
151
152		$fileName = preg_replace('/(?:[\/]{3,})(.*)/', '//$1', $fileName);
153		$url_info = parse_url($fileName);
154		$pathInfo = pathinfo(str_replace('?' . $url_info['query'], '', $fileName));
155
156		$file = new stdClass();
157		$file->fileName = basename($url_info['path']);
158		$file->filePath = $this->_getAbsFileUrl($pathInfo['dirname']);
159		$file->fileRealPath = FileHandler::getRealPath($pathInfo['dirname']);
160		$file->fileExtension = strtolower($pathInfo['extension']);
161		$file->fileNameNoExt = preg_replace('/\.min$/', '', $pathInfo['filename']);
162		$file->query = $url_info['query'];
163		$file->external = !!$url_info['host'];
164		$file->keyName = implode('.', array($file->fileNameNoExt, $file->fileExtension));
165		$file->cdnPath = $this->_normalizeFilePath($pathInfo['dirname']);
166
167		if(!$file->external)
168		{
169		if(!__DEBUG__ && __XE_VERSION_STABLE__)
170		{
171		// if no debug mode, load minifed file
172		$minifiedFileName = implode('.', array($file->fileNameNoExt, 'min', $file->fileExtension));
173		$minifiedRealPath = implode('/', array($file->fileRealPath, $minifiedFileName));
174		if(file_exists($minifiedRealPath))
175		{
176		$file->fileName = $minifiedFileName;
177		}
178		}
179		else
180		{
181		// Remove .min
182		if(file_exists(implode('/', array($file->fileRealPath, $file->keyName))))
183		{
184		$file->fileName = $file->keyName;
185		}
186		}
187		}
188
189		$file->targetIe = $targetIe;
190
191		if($file->fileExtension == 'css')
192		{
193		$file->media = $media;
194		if(!$file->media)
195		{
196		$file->media = 'all';
197		}
198		$file->key = $file->filePath . $file->keyName . "\t" . $file->targetIe . "\t" . $file->media;
199		}
200		else if($file->fileExtension == 'js')
201		{
202		$file->key = $file->filePath . $file->keyName . "\t" . $file->targetIe;
203		}
204
205		return $file;
206		}
207
208		/**
209		* Unload front end file
210		*
211		* @param string $fileName The file name to unload
212		* @param string $targetIe Target IE of file to unload
213		* @param string $media Media of file to unload. Only use when file is css.
214		* @return void
215		*/
216		function unloadFile($fileName, $targetIe = '', $media = 'all')
217		{
218		$file = $this->getFileInfo($fileName, $targetIe, $media);
219
220		if($file->fileExtension == 'css')
221		{
222		if(isset($this->cssMapIndex[$file->key]))
223		{
224		$index = $this->cssMapIndex[$file->key];
225		unset($this->cssMap[$index][$file->key], $this->cssMapIndex[$file->key]);
226		}
227		}
228		else
229		{
230		if(isset($this->jsHeadMapIndex[$file->key]))
231		{
232		$index = $this->jsHeadMapIndex[$file->key];
233		unset($this->jsHeadMap[$index][$file->key], $this->jsHeadMapIndex[$file->key]);
234		}
235		if(isset($this->jsBodyMapIndex[$file->key]))
236		{
237		$index = $this->jsBodyMapIndex[$file->key];
238		unset($this->jsBodyMap[$index][$file->key], $this->jsBodyMapIndex[$file->key]);
239		}
240		}
241		}
242
243		/**
244		* Unload all front end file
245		*
246		* @param string $type Type to unload. all, css, js
247		* @return void
248		*/
249		function unloadAllFiles($type = 'all')
250		{
251		if($type == 'css' \|\| $type == 'all')
252		{
253		$this->cssMap = array();
254		$this->cssMapIndex = array();
255		}
256
257		if($type == 'js' \|\| $type == 'all')
258		{
259		$this->jsHeadMap = array();
260		$this->jsBodyMap = array();
261		$this->jsHeadMapIndex = array();
262		$this->jsBodyMapIndex = array();
263		}
264		}
265
266		/**
267		* Get css file list
268		*
269		* @return array Returns css file list. Array contains file, media, targetie.
270		*/
271		function getCssFileList()
272		{
273		$map = &$this->cssMap;
274		$mapIndex = &$this->cssMapIndex;
275
276		$this->_sortMap($map, $mapIndex);
277
278		$result = array();
279		foreach($map as $indexedMap)
280		{
281		foreach($indexedMap as $file)
282		{
283		$query = '';
284		if(!$file->external && is_readable($file->cdnPath . '/' . $file->fileName))
285		{
286		$query = date('YmdHis', filemtime($file->cdnPath . '/' . $file->fileName));
287		}
288		if($file->query)
289		{
290		if($query) $query .= '&';
291		$query .= $file->query;
292		}
293		$query = ($query) ? '?' . $query : '';
294
295		$fullFilePath = $file->filePath . '/' . $file->fileName . $query;
296		$result[] = array(
297		'file' => $fullFilePath,
298		'media' => $file->media,
299		'targetie' => $file->targetIe
300		);
301		}
302		}
303
304		return $result;
305		}
306
307		/**
308		* Get javascript file list
309		*
310		* @param string $type Type of javascript. head, body
311		* @return array Returns javascript file list. Array contains file, targetie.
312		*/
313		function getJsFileList($type = 'head')
314		{
315
316		$ignore = array('modernizr.js', 'common.js', 'js_app.js', 'xml2json.js', 'xml_handler.js', 'xml_js_filter.js');
317
318	View Code Duplication	if($type == 'head')
319		{
320		$map = &$this->jsHeadMap;
321		$mapIndex = &$this->jsHeadMapIndex;
322		}
323		else
324		{
325		$map = &$this->jsBodyMap;
326		$mapIndex = &$this->jsBodyMapIndex;
327		}
328
329		$this->_sortMap($map, $mapIndex);
330
331		$result = array();
332		foreach($map as $indexedMap)
333		{
334		foreach($indexedMap as $file)
335		{
336		if((!__DEBUG__ && __XE_VERSION_STABLE__) && $file->filePath === '/common/js')
337		{
338		if(in_array($file->fileName, $ignore))
339		{
340		continue;
341		}
342		}
343
344		$query = '';
345		if(!$file->external && is_readable($file->cdnPath . '/' . $file->fileName))
346		{
347		$query = date('YmdHis', filemtime($file->cdnPath . '/' . $file->fileName));
348		}
349		if($file->query)
350		{
351		if($query) $query .= '&';
352		$query .= $file->query;
353		}
354		$query = ($query) ? '?' . $query : '';
355
356		$fullFilePath = $file->filePath . '/' . $file->fileName . $query;
357		$result[] = array(
358		'file' => $fullFilePath,
359		'targetie' => $file->targetIe
360		);
361		}
362		}
363
364		return $result;
365		}
366
367		/**
368		* Sort a map
369		*
370		* @param array $map Array to sort
371		* @param array $index Not used
372		* @return void
373		*/
374		function _sortMap(&$map, &$index)
		0 ignored issues – show Unused Code introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report The parameter `$index` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
375		{
376		ksort($map);
377		}
378
379		/**
380		* Normalize File path
381		*
382		* @param string $path Path to normalize
383		* @return string Normalized path
384		*/
385		function _normalizeFilePath($path)
386		{
387		if(strpos($path, '://') === FALSE && $path{0} != '/' && $path{0} != '.')
388		{
389		$path = './' . $path;
390		}
391		elseif(!strncmp($path, '//', 2))
392		{
393		return preg_replace('#^//+#', '//', $path);
394		}
395
396		$path = preg_replace('@/\./\|(?<!:)\/\/@', '/', $path);
397
398		while(strpos($path, '/../'))
399		{
400		$path = preg_replace('/\/([^\/]+)\/\.\.\//s', '/', $path, 1);
401		}
402
403		return $path;
404		}
405
406		/**
407		* Get absolute file url
408		*
409		* @param string $path Path to get absolute url
410		* @return string Absolute url
411		*/
412		function _getAbsFileUrl($path)
413		{
414		$path = $this->_normalizeFilePath($path);
415		$script_path = getScriptPath();
416
417		if(strpos($path, './') === 0)
418		{
419		if($script_path == '/' \|\| $script_path == '\\')
420		{
421		$path = '/' . substr($path, 2);
422		}
423		else
424		{
425		$path = $script_path . substr($path, 2);
426		}
427		}
428		else if(strpos($file, '../') === 0)
		0 ignored issues – show Bug introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report The variable `$file` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
429		{
430		$path = $this->_normalizeFilePath($script_path . $path);
431		}
432
433		return $path;
434		}
435
436		/**
437		* Arrage css index
438		*
439		* @param string $dirName First directory name of css path
440		* @param array $file file info.
441		* @return void
442		*/
443		function _arrangeCssIndex($dirName, &$file)
444		{
445		if($file->index !== 0)
446		{
447		return;
448		}
449
450		$dirName = str_replace('./', '', $dirName);
451		$tmp = explode('/', $dirName);
452
453		$cssSortList = array('common' => -100000, 'layouts' => -90000, 'modules' => -80000, 'widgets' => -70000, 'addons' => -60000);
454		$file->index = $cssSortList[$tmp[0]];
455		}
456
457		}
458		/* End of file FrontEndFileHandler.class.php */
459		/* Location: ./classes/frontendfile/FrontEndFileHandler.class.php */
460

xpressengine / xe-core

GitHub Access Token became invalid

Push — master ( 78ace2...4b54c6 )

FrontEndFileHandler C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like