xpressengine / xe-core

classes/security/htmlpurifier/library/HTMLPurifier/ChildDef/Empty.php

Indentation +6 added lines, -6 removed lines

@@ -9,12 +9,12 @@
  */
 class HTMLPurifier_ChildDef_Empty extends HTMLPurifier_ChildDef
 {
-    public $allow_empty = true;
-    public $type = 'empty';
-    public function __construct() {}
-    public function validateChildren($tokens_of_children, $config, $context) {
-        return array();
-    }
+	public $allow_empty = true;
+	public $type = 'empty';
+	public function __construct() {}
+	public function validateChildren($tokens_of_children, $config, $context) {
+		return array();
+	}
 }
 
 // vim: et sw=4 sts=4

classes/security/htmlpurifier/library/HTMLPurifier/ChildDef/List.php

Indentation +100 added lines, -100 removed lines

@@ -5,116 +5,116 @@
  */
 class HTMLPurifier_ChildDef_List extends HTMLPurifier_ChildDef
 {
-    public $type = 'list';
-    // lying a little bit, so that we can handle ul and ol ourselves
-    // XXX: This whole business with 'wrap' is all a bit unsatisfactory
-    public $elements = array('li' => true, 'ul' => true, 'ol' => true);
-    public function validateChildren($tokens_of_children, $config, $context) {
-        // Flag for subclasses
-        $this->whitespace = false;
+	public $type = 'list';
+	// lying a little bit, so that we can handle ul and ol ourselves
+	// XXX: This whole business with 'wrap' is all a bit unsatisfactory
+	public $elements = array('li' => true, 'ul' => true, 'ol' => true);
+	public function validateChildren($tokens_of_children, $config, $context) {
+		// Flag for subclasses
+		$this->whitespace = false;
 
-        // if there are no tokens, delete parent node
-        if (empty($tokens_of_children)) return false;
+		// if there are no tokens, delete parent node
+		if (empty($tokens_of_children)) return false;
 
-        // the new set of children
-        $result = array();
+		// the new set of children
+		$result = array();
 
-        // current depth into the nest
-        $nesting = 0;
+		// current depth into the nest
+		$nesting = 0;
 
-        // a little sanity check to make sure it's not ALL whitespace
-        $all_whitespace = true;
+		// a little sanity check to make sure it's not ALL whitespace
+		$all_whitespace = true;
 
-        $seen_li = false;
-        $need_close_li = false;
+		$seen_li = false;
+		$need_close_li = false;
 
-        foreach ($tokens_of_children as $token) {
-            if (!empty($token->is_whitespace)) {
-                $result[] = $token;
-                continue;
-            }
-            $all_whitespace = false; // phew, we're not talking about whitespace
+		foreach ($tokens_of_children as $token) {
+			if (!empty($token->is_whitespace)) {
+				$result[] = $token;
+				continue;
+			}
+			$all_whitespace = false; // phew, we're not talking about whitespace
 
-            if ($nesting == 1 && $need_close_li) {
-                $result[] = new HTMLPurifier_Token_End('li');
-                $nesting--;
-                $need_close_li = false;
-            }
+			if ($nesting == 1 && $need_close_li) {
+				$result[] = new HTMLPurifier_Token_End('li');
+				$nesting--;
+				$need_close_li = false;
+			}
 
-            $is_child = ($nesting == 0);
+			$is_child = ($nesting == 0);
 
-            if ($token instanceof HTMLPurifier_Token_Start) {
-                $nesting++;
-            } elseif ($token instanceof HTMLPurifier_Token_End) {
-                $nesting--;
-            }
+			if ($token instanceof HTMLPurifier_Token_Start) {
+				$nesting++;
+			} elseif ($token instanceof HTMLPurifier_Token_End) {
+				$nesting--;
+			}
 
-            if ($is_child) {
-                if ($token->name === 'li') {
-                    // good
-                    $seen_li = true;
-                } elseif ($token->name === 'ul' || $token->name === 'ol') {
-                    // we want to tuck this into the previous li
-                    $need_close_li = true;
-                    $nesting++;
-                    if (!$seen_li) {
-                        // create a new li element
-                        $result[] = new HTMLPurifier_Token_Start('li');
-                    } else {
-                        // backtrack until </li> found
-                        while(true) {
-                            $t = array_pop($result);
-                            if ($t instanceof HTMLPurifier_Token_End) {
-                                // XXX actually, these invariants could very plausibly be violated
-                                // if we are doing silly things with modifying the set of allowed elements.
-                                // FORTUNATELY, it doesn't make a difference, since the allowed
-                                // elements are hard-coded here!
-                                if ($t->name !== 'li') {
-                                    trigger_error("Only li present invariant violated in List ChildDef", E_USER_ERROR);
-                                    return false;
-                                }
-                                break;
-                            } elseif ($t instanceof HTMLPurifier_Token_Empty) { // bleagh
-                                if ($t->name !== 'li') {
-                                    trigger_error("Only li present invariant violated in List ChildDef", E_USER_ERROR);
-                                    return false;
-                                }
-                                // XXX this should have a helper for it...
-                                $result[] = new HTMLPurifier_Token_Start('li', $t->attr, $t->line, $t->col, $t->armor);
-                                break;
-                            } else {
-                                if (!$t->is_whitespace) {
-                                    trigger_error("Only whitespace present invariant violated in List ChildDef", E_USER_ERROR);
-                                    return false;
-                                }
-                            }
-                        }
-                    }
-                } else {
-                    // start wrapping (this doesn't precisely mimic
-                    // browser behavior, but what browsers do is kind of
-                    // hard to mimic in a standards compliant way
-                    // XXX Actually, this has no impact in practice,
-                    // because this gets handled earlier. Arguably,
-                    // we should rip out all of that processing
-                    $result[] = new HTMLPurifier_Token_Start('li');
-                    $nesting++;
-                    $seen_li = true;
-                    $need_close_li = true;
-                }
-            }
-            $result[] = $token;
-        }
-        if ($need_close_li) {
-            $result[] = new HTMLPurifier_Token_End('li');
-        }
-        if (empty($result)) return false;
-        if ($all_whitespace) {
-            return false;
-        }
-        if ($tokens_of_children == $result) return true;
-        return $result;
-    }
+			if ($is_child) {
+				if ($token->name === 'li') {
+					// good
+					$seen_li = true;
+				} elseif ($token->name === 'ul' || $token->name === 'ol') {
+					// we want to tuck this into the previous li
+					$need_close_li = true;
+					$nesting++;
+					if (!$seen_li) {
+						// create a new li element
+						$result[] = new HTMLPurifier_Token_Start('li');
+					} else {
+						// backtrack until </li> found
+						while(true) {
+							$t = array_pop($result);
+							if ($t instanceof HTMLPurifier_Token_End) {
+								// XXX actually, these invariants could very plausibly be violated
+								// if we are doing silly things with modifying the set of allowed elements.
+								// FORTUNATELY, it doesn't make a difference, since the allowed
+								// elements are hard-coded here!
+								if ($t->name !== 'li') {
+									trigger_error("Only li present invariant violated in List ChildDef", E_USER_ERROR);
+									return false;
+								}
+								break;
+							} elseif ($t instanceof HTMLPurifier_Token_Empty) { // bleagh
+								if ($t->name !== 'li') {
+									trigger_error("Only li present invariant violated in List ChildDef", E_USER_ERROR);
+									return false;
+								}
+								// XXX this should have a helper for it...
+								$result[] = new HTMLPurifier_Token_Start('li', $t->attr, $t->line, $t->col, $t->armor);
+								break;
+							} else {
+								if (!$t->is_whitespace) {
+									trigger_error("Only whitespace present invariant violated in List ChildDef", E_USER_ERROR);
+									return false;
+								}
+							}
+						}
+					}
+				} else {
+					// start wrapping (this doesn't precisely mimic
+					// browser behavior, but what browsers do is kind of
+					// hard to mimic in a standards compliant way
+					// XXX Actually, this has no impact in practice,
+					// because this gets handled earlier. Arguably,
+					// we should rip out all of that processing
+					$result[] = new HTMLPurifier_Token_Start('li');
+					$nesting++;
+					$seen_li = true;
+					$need_close_li = true;
+				}
+			}
+			$result[] = $token;
+		}
+		if ($need_close_li) {
+			$result[] = new HTMLPurifier_Token_End('li');
+		}
+		if (empty($result)) return false;
+		if ($all_whitespace) {
+			return false;
+		}
+		if ($tokens_of_children == $result) return true;
+		return $result;
+	}
 }
 
 // vim: et sw=4 sts=4

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
                         $result[] = new HTMLPurifier_Token_Start('li');
                     } else {
                         // backtrack until </li> found
-                        while(true) {
+                        while (true) {
                             $t = array_pop($result);
                             if ($t instanceof HTMLPurifier_Token_End) {
                                 // XXX actually, these invariants could very plausibly be violated

Braces +9 added lines, -3 removed lines

@@ -14,7 +14,9 @@ 
         $this->whitespace = false;
 
         // if there are no tokens, delete parent node
-        if (empty($tokens_of_children)) return false;
+        if (empty($tokens_of_children)) {
+        	return false;
+        }
 
         // the new set of children
         $result = array();
@@ -108,11 +110,15 @@ 
         if ($need_close_li) {
             $result[] = new HTMLPurifier_Token_End('li');
         }
-        if (empty($result)) return false;
+        if (empty($result)) {
+        	return false;
+        }
         if ($all_whitespace) {
             return false;
         }
-        if ($tokens_of_children == $result) return true;
+        if ($tokens_of_children == $result) {
+        	return true;
+        }
         return $result;
     }
 }

classes/security/htmlpurifier/library/HTMLPurifier/ChildDef/Optional.php

Indentation +12 added lines, -12 removed lines

@@ -9,18 +9,18 @@
  */
 class HTMLPurifier_ChildDef_Optional extends HTMLPurifier_ChildDef_Required
 {
-    public $allow_empty = true;
-    public $type = 'optional';
-    public function validateChildren($tokens_of_children, $config, $context) {
-        $result = parent::validateChildren($tokens_of_children, $config, $context);
-        // we assume that $tokens_of_children is not modified
-        if ($result === false) {
-            if (empty($tokens_of_children)) return true;
-            elseif ($this->whitespace) return $tokens_of_children;
-            else return array();
-        }
-        return $result;
-    }
+	public $allow_empty = true;
+	public $type = 'optional';
+	public function validateChildren($tokens_of_children, $config, $context) {
+		$result = parent::validateChildren($tokens_of_children, $config, $context);
+		// we assume that $tokens_of_children is not modified
+		if ($result === false) {
+			if (empty($tokens_of_children)) return true;
+			elseif ($this->whitespace) return $tokens_of_children;
+			else return array();
+		}
+		return $result;
+	}
 }
 
 // vim: et sw=4 sts=4

Braces +7 added lines, -3 removed lines

@@ -15,9 +15,13 @@
         $result = parent::validateChildren($tokens_of_children, $config, $context);
         // we assume that $tokens_of_children is not modified
         if ($result === false) {
-            if (empty($tokens_of_children)) return true;
-            elseif ($this->whitespace) return $tokens_of_children;
-            else return array();
+            if (empty($tokens_of_children)) {
+            	return true;
+            } elseif ($this->whitespace) {
+            	return $tokens_of_children;
+            } else {
+            	return array();
+            }
         }
         return $result;
     }

classes/security/htmlpurifier/library/HTMLPurifier/ChildDef/Required.php

Indentation +95 added lines, -95 removed lines

@@ -5,113 +5,113 @@
  */
 class HTMLPurifier_ChildDef_Required extends HTMLPurifier_ChildDef
 {
-    /**
-     * Lookup table of allowed elements.
-     * @public
-     */
-    public $elements = array();
-    /**
-     * Whether or not the last passed node was all whitespace.
-     */
-    protected $whitespace = false;
-    /**
-     * @param $elements List of allowed element names (lowercase).
-     */
-    public function __construct($elements) {
-        if (is_string($elements)) {
-            $elements = str_replace(' ', '', $elements);
-            $elements = explode('|', $elements);
-        }
-        $keys = array_keys($elements);
-        if ($keys == array_keys($keys)) {
-            $elements = array_flip($elements);
-            foreach ($elements as $i => $x) {
-                $elements[$i] = true;
-                if (empty($i)) unset($elements[$i]); // remove blank
-            }
-        }
-        $this->elements = $elements;
-    }
-    public $allow_empty = false;
-    public $type = 'required';
-    public function validateChildren($tokens_of_children, $config, $context) {
-        // Flag for subclasses
-        $this->whitespace = false;
+	/**
+	 * Lookup table of allowed elements.
+	 * @public
+	 */
+	public $elements = array();
+	/**
+	 * Whether or not the last passed node was all whitespace.
+	 */
+	protected $whitespace = false;
+	/**
+	 * @param $elements List of allowed element names (lowercase).
+	 */
+	public function __construct($elements) {
+		if (is_string($elements)) {
+			$elements = str_replace(' ', '', $elements);
+			$elements = explode('|', $elements);
+		}
+		$keys = array_keys($elements);
+		if ($keys == array_keys($keys)) {
+			$elements = array_flip($elements);
+			foreach ($elements as $i => $x) {
+				$elements[$i] = true;
+				if (empty($i)) unset($elements[$i]); // remove blank
+			}
+		}
+		$this->elements = $elements;
+	}
+	public $allow_empty = false;
+	public $type = 'required';
+	public function validateChildren($tokens_of_children, $config, $context) {
+		// Flag for subclasses
+		$this->whitespace = false;
 
-        // if there are no tokens, delete parent node
-        if (empty($tokens_of_children)) return false;
+		// if there are no tokens, delete parent node
+		if (empty($tokens_of_children)) return false;
 
-        // the new set of children
-        $result = array();
+		// the new set of children
+		$result = array();
 
-        // current depth into the nest
-        $nesting = 0;
+		// current depth into the nest
+		$nesting = 0;
 
-        // whether or not we're deleting a node
-        $is_deleting = false;
+		// whether or not we're deleting a node
+		$is_deleting = false;
 
-        // whether or not parsed character data is allowed
-        // this controls whether or not we silently drop a tag
-        // or generate escaped HTML from it
-        $pcdata_allowed = isset($this->elements['#PCDATA']);
+		// whether or not parsed character data is allowed
+		// this controls whether or not we silently drop a tag
+		// or generate escaped HTML from it
+		$pcdata_allowed = isset($this->elements['#PCDATA']);
 
-        // a little sanity check to make sure it's not ALL whitespace
-        $all_whitespace = true;
+		// a little sanity check to make sure it's not ALL whitespace
+		$all_whitespace = true;
 
-        // some configuration
-        $escape_invalid_children = $config->get('Core.EscapeInvalidChildren');
+		// some configuration
+		$escape_invalid_children = $config->get('Core.EscapeInvalidChildren');
 
-        // generator
-        $gen = new HTMLPurifier_Generator($config, $context);
+		// generator
+		$gen = new HTMLPurifier_Generator($config, $context);
 
-        foreach ($tokens_of_children as $token) {
-            if (!empty($token->is_whitespace)) {
-                $result[] = $token;
-                continue;
-            }
-            $all_whitespace = false; // phew, we're not talking about whitespace
+		foreach ($tokens_of_children as $token) {
+			if (!empty($token->is_whitespace)) {
+				$result[] = $token;
+				continue;
+			}
+			$all_whitespace = false; // phew, we're not talking about whitespace
 
-            $is_child = ($nesting == 0);
+			$is_child = ($nesting == 0);
 
-            if ($token instanceof HTMLPurifier_Token_Start) {
-                $nesting++;
-            } elseif ($token instanceof HTMLPurifier_Token_End) {
-                $nesting--;
-            }
+			if ($token instanceof HTMLPurifier_Token_Start) {
+				$nesting++;
+			} elseif ($token instanceof HTMLPurifier_Token_End) {
+				$nesting--;
+			}
 
-            if ($is_child) {
-                $is_deleting = false;
-                if (!isset($this->elements[$token->name])) {
-                    $is_deleting = true;
-                    if ($pcdata_allowed && $token instanceof HTMLPurifier_Token_Text) {
-                        $result[] = $token;
-                    } elseif ($pcdata_allowed && $escape_invalid_children) {
-                        $result[] = new HTMLPurifier_Token_Text(
-                            $gen->generateFromToken($token)
-                        );
-                    }
-                    continue;
-                }
-            }
-            if (!$is_deleting || ($pcdata_allowed && $token instanceof HTMLPurifier_Token_Text)) {
-                $result[] = $token;
-            } elseif ($pcdata_allowed && $escape_invalid_children) {
-                $result[] =
-                    new HTMLPurifier_Token_Text(
-                        $gen->generateFromToken($token)
-                    );
-            } else {
-                // drop silently
-            }
-        }
-        if (empty($result)) return false;
-        if ($all_whitespace) {
-            $this->whitespace = true;
-            return false;
-        }
-        if ($tokens_of_children == $result) return true;
-        return $result;
-    }
+			if ($is_child) {
+				$is_deleting = false;
+				if (!isset($this->elements[$token->name])) {
+					$is_deleting = true;
+					if ($pcdata_allowed && $token instanceof HTMLPurifier_Token_Text) {
+						$result[] = $token;
+					} elseif ($pcdata_allowed && $escape_invalid_children) {
+						$result[] = new HTMLPurifier_Token_Text(
+							$gen->generateFromToken($token)
+						);
+					}
+					continue;
+				}
+			}
+			if (!$is_deleting || ($pcdata_allowed && $token instanceof HTMLPurifier_Token_Text)) {
+				$result[] = $token;
+			} elseif ($pcdata_allowed && $escape_invalid_children) {
+				$result[] =
+					new HTMLPurifier_Token_Text(
+						$gen->generateFromToken($token)
+					);
+			} else {
+				// drop silently
+			}
+		}
+		if (empty($result)) return false;
+		if ($all_whitespace) {
+			$this->whitespace = true;
+			return false;
+		}
+		if ($tokens_of_children == $result) return true;
+		return $result;
+	}
 }
 
 // vim: et sw=4 sts=4

Braces +13 added lines, -4 removed lines

@@ -27,7 +27,10 @@ 
             $elements = array_flip($elements);
             foreach ($elements as $i => $x) {
                 $elements[$i] = true;
-                if (empty($i)) unset($elements[$i]); // remove blank
+                if (empty($i)) {
+                	unset($elements[$i]);
+                }
+                // remove blank
             }
         }
         $this->elements = $elements;
@@ -39,7 +42,9 @@ 
         $this->whitespace = false;
 
         // if there are no tokens, delete parent node
-        if (empty($tokens_of_children)) return false;
+        if (empty($tokens_of_children)) {
+        	return false;
+        }
 
         // the new set of children
         $result = array();
@@ -104,12 +109,16 @@ 
                 // drop silently
             }
         }
-        if (empty($result)) return false;
+        if (empty($result)) {
+        	return false;
+        }
         if ($all_whitespace) {
             $this->whitespace = true;
             return false;
         }
-        if ($tokens_of_children == $result) return true;
+        if ($tokens_of_children == $result) {
+        	return true;
+        }
         return $result;
     }
 }

classes/security/htmlpurifier/library/HTMLPurifier/ChildDef/StrictBlockquote.php

Indentation +70 added lines, -70 removed lines

@@ -5,84 +5,84 @@
  */
 class HTMLPurifier_ChildDef_StrictBlockquote extends HTMLPurifier_ChildDef_Required
 {
-    protected $real_elements;
-    protected $fake_elements;
-    public $allow_empty = true;
-    public $type = 'strictblockquote';
-    protected $init = false;
+	protected $real_elements;
+	protected $fake_elements;
+	public $allow_empty = true;
+	public $type = 'strictblockquote';
+	protected $init = false;
 
-    /**
-     * @note We don't want MakeWellFormed to auto-close inline elements since
-     *       they might be allowed.
-     */
-    public function getAllowedElements($config) {
-        $this->init($config);
-        return $this->fake_elements;
-    }
+	/**
+	 * @note We don't want MakeWellFormed to auto-close inline elements since
+	 *       they might be allowed.
+	 */
+	public function getAllowedElements($config) {
+		$this->init($config);
+		return $this->fake_elements;
+	}
 
-    public function validateChildren($tokens_of_children, $config, $context) {
+	public function validateChildren($tokens_of_children, $config, $context) {
 
-        $this->init($config);
+		$this->init($config);
 
-        // trick the parent class into thinking it allows more
-        $this->elements = $this->fake_elements;
-        $result = parent::validateChildren($tokens_of_children, $config, $context);
-        $this->elements = $this->real_elements;
+		// trick the parent class into thinking it allows more
+		$this->elements = $this->fake_elements;
+		$result = parent::validateChildren($tokens_of_children, $config, $context);
+		$this->elements = $this->real_elements;
 
-        if ($result === false) return array();
-        if ($result === true) $result = $tokens_of_children;
+		if ($result === false) return array();
+		if ($result === true) $result = $tokens_of_children;
 
-        $def = $config->getHTMLDefinition();
-        $block_wrap_start = new HTMLPurifier_Token_Start($def->info_block_wrapper);
-        $block_wrap_end   = new HTMLPurifier_Token_End(  $def->info_block_wrapper);
-        $is_inline = false;
-        $depth = 0;
-        $ret = array();
+		$def = $config->getHTMLDefinition();
+		$block_wrap_start = new HTMLPurifier_Token_Start($def->info_block_wrapper);
+		$block_wrap_end   = new HTMLPurifier_Token_End(  $def->info_block_wrapper);
+		$is_inline = false;
+		$depth = 0;
+		$ret = array();
 
-        // assuming that there are no comment tokens
-        foreach ($result as $i => $token) {
-            $token = $result[$i];
-            // ifs are nested for readability
-            if (!$is_inline) {
-                if (!$depth) {
-                     if (
-                        ($token instanceof HTMLPurifier_Token_Text && !$token->is_whitespace) ||
-                        (!$token instanceof HTMLPurifier_Token_Text && !isset($this->elements[$token->name]))
-                     ) {
-                        $is_inline = true;
-                        $ret[] = $block_wrap_start;
-                     }
-                }
-            } else {
-                if (!$depth) {
-                    // starting tokens have been inline text / empty
-                    if ($token instanceof HTMLPurifier_Token_Start || $token instanceof HTMLPurifier_Token_Empty) {
-                        if (isset($this->elements[$token->name])) {
-                            // ended
-                            $ret[] = $block_wrap_end;
-                            $is_inline = false;
-                        }
-                    }
-                }
-            }
-            $ret[] = $token;
-            if ($token instanceof HTMLPurifier_Token_Start) $depth++;
-            if ($token instanceof HTMLPurifier_Token_End)   $depth--;
-        }
-        if ($is_inline) $ret[] = $block_wrap_end;
-        return $ret;
-    }
+		// assuming that there are no comment tokens
+		foreach ($result as $i => $token) {
+			$token = $result[$i];
+			// ifs are nested for readability
+			if (!$is_inline) {
+				if (!$depth) {
+					 if (
+						($token instanceof HTMLPurifier_Token_Text && !$token->is_whitespace) ||
+						(!$token instanceof HTMLPurifier_Token_Text && !isset($this->elements[$token->name]))
+					 ) {
+						$is_inline = true;
+						$ret[] = $block_wrap_start;
+					 }
+				}
+			} else {
+				if (!$depth) {
+					// starting tokens have been inline text / empty
+					if ($token instanceof HTMLPurifier_Token_Start || $token instanceof HTMLPurifier_Token_Empty) {
+						if (isset($this->elements[$token->name])) {
+							// ended
+							$ret[] = $block_wrap_end;
+							$is_inline = false;
+						}
+					}
+				}
+			}
+			$ret[] = $token;
+			if ($token instanceof HTMLPurifier_Token_Start) $depth++;
+			if ($token instanceof HTMLPurifier_Token_End)   $depth--;
+		}
+		if ($is_inline) $ret[] = $block_wrap_end;
+		return $ret;
+	}
 
-    private function init($config) {
-        if (!$this->init) {
-            $def = $config->getHTMLDefinition();
-            // allow all inline elements
-            $this->real_elements = $this->elements;
-            $this->fake_elements = $def->info_content_sets['Flow'];
-            $this->fake_elements['#PCDATA'] = true;
-            $this->init = true;
-        }
-    }
+	private function init($config) {
+		if (!$this->init) {
+			$def = $config->getHTMLDefinition();
+			// allow all inline elements
+			$this->real_elements = $this->elements;
+			$this->fake_elements = $def->info_content_sets['Flow'];
+			$this->fake_elements['#PCDATA'] = true;
+			$this->init = true;
+		}
+	}
 }
 
 // vim: et sw=4 sts=4

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
         $def = $config->getHTMLDefinition();
         $block_wrap_start = new HTMLPurifier_Token_Start($def->info_block_wrapper);
-        $block_wrap_end   = new HTMLPurifier_Token_End(  $def->info_block_wrapper);
+        $block_wrap_end   = new HTMLPurifier_Token_End($def->info_block_wrapper);
         $is_inline = false;
         $depth = 0;
         $ret = array();

Braces +15 added lines, -5 removed lines

@@ -29,8 +29,12 @@ 
         $result = parent::validateChildren($tokens_of_children, $config, $context);
         $this->elements = $this->real_elements;
 
-        if ($result === false) return array();
-        if ($result === true) $result = $tokens_of_children;
+        if ($result === false) {
+        	return array();
+        }
+        if ($result === true) {
+        	$result = $tokens_of_children;
+        }
 
         $def = $config->getHTMLDefinition();
         $block_wrap_start = new HTMLPurifier_Token_Start($def->info_block_wrapper);
@@ -66,10 +70,16 @@ 
                 }
             }
             $ret[] = $token;
-            if ($token instanceof HTMLPurifier_Token_Start) $depth++;
-            if ($token instanceof HTMLPurifier_Token_End)   $depth--;
+            if ($token instanceof HTMLPurifier_Token_Start) {
+            	$depth++;
+            }
+            if ($token instanceof HTMLPurifier_Token_End) {
+            	$depth--;
+            }
+        }
+        if ($is_inline) {
+        	$ret[] = $block_wrap_end;
         }
-        if ($is_inline) $ret[] = $block_wrap_end;
         return $ret;
     }
 

classes/security/htmlpurifier/library/HTMLPurifier/ChildDef/Table.php

Indentation +191 added lines, -191 removed lines

@@ -31,197 +31,197 @@
  */
 class HTMLPurifier_ChildDef_Table extends HTMLPurifier_ChildDef
 {
-    public $allow_empty = false;
-    public $type = 'table';
-    public $elements = array('tr' => true, 'tbody' => true, 'thead' => true,
-        'tfoot' => true, 'caption' => true, 'colgroup' => true, 'col' => true);
-    public function __construct() {}
-    public function validateChildren($tokens_of_children, $config, $context) {
-        if (empty($tokens_of_children)) return false;
-
-        // this ensures that the loop gets run one last time before closing
-        // up. It's a little bit of a hack, but it works! Just make sure you
-        // get rid of the token later.
-        $tokens_of_children[] = false;
-
-        // only one of these elements is allowed in a table
-        $caption = false;
-        $thead   = false;
-        $tfoot   = false;
-
-        // as many of these as you want
-        $cols    = array();
-        $content = array();
-
-        $nesting = 0; // current depth so we can determine nodes
-        $is_collecting = false; // are we globbing together tokens to package
-                                // into one of the collectors?
-        $collection = array(); // collected nodes
-        $tag_index = 0; // the first node might be whitespace,
-                            // so this tells us where the start tag is
-        $tbody_mode = false; // if true, then we need to wrap any stray
-                             // <tr>s with a <tbody>.
-
-        foreach ($tokens_of_children as $token) {
-            $is_child = ($nesting == 0);
-
-            if ($token === false) {
-                // terminating sequence started
-            } elseif ($token instanceof HTMLPurifier_Token_Start) {
-                $nesting++;
-            } elseif ($token instanceof HTMLPurifier_Token_End) {
-                $nesting--;
-            }
-
-            // handle node collection
-            if ($is_collecting) {
-                if ($is_child) {
-                    // okay, let's stash the tokens away
-                    // first token tells us the type of the collection
-                    switch ($collection[$tag_index]->name) {
-                        case 'tbody':
-                            $tbody_mode = true;
-                        case 'tr':
-                            $content[] = $collection;
-                            break;
-                        case 'caption':
-                            if ($caption !== false) break;
-                            $caption = $collection;
-                            break;
-                        case 'thead':
-                        case 'tfoot':
-                            $tbody_mode = true;
-                            // XXX This breaks rendering properties with
-                            // Firefox, which never floats a <thead> to
-                            // the top. Ever. (Our scheme will float the
-                            // first <thead> to the top.)  So maybe
-                            // <thead>s that are not first should be
-                            // turned into <tbody>? Very tricky, indeed.
-
-                            // access the appropriate variable, $thead or $tfoot
-                            $var = $collection[$tag_index]->name;
-                            if ($$var === false) {
-                                $$var = $collection;
-                            } else {
-                                // Oops, there's a second one! What
-                                // should we do?  Current behavior is to
-                                // transmutate the first and last entries into
-                                // tbody tags, and then put into content.
-                                // Maybe a better idea is to *attach
-                                // it* to the existing thead or tfoot?
-                                // We don't do this, because Firefox
-                                // doesn't float an extra tfoot to the
-                                // bottom like it does for the first one.
-                                $collection[$tag_index]->name = 'tbody';
-                                $collection[count($collection)-1]->name = 'tbody';
-                                $content[] = $collection;
-                            }
-                            break;
-                         case 'colgroup':
-                            $cols[] = $collection;
-                            break;
-                    }
-                    $collection = array();
-                    $is_collecting = false;
-                    $tag_index = 0;
-                } else {
-                    // add the node to the collection
-                    $collection[] = $token;
-                }
-            }
-
-            // terminate
-            if ($token === false) break;
-
-            if ($is_child) {
-                // determine what we're dealing with
-                if ($token->name == 'col') {
-                    // the only empty tag in the possie, we can handle it
-                    // immediately
-                    $cols[] = array_merge($collection, array($token));
-                    $collection = array();
-                    $tag_index = 0;
-                    continue;
-                }
-                switch($token->name) {
-                    case 'caption':
-                    case 'colgroup':
-                    case 'thead':
-                    case 'tfoot':
-                    case 'tbody':
-                    case 'tr':
-                        $is_collecting = true;
-                        $collection[] = $token;
-                        continue;
-                    default:
-                        if (!empty($token->is_whitespace)) {
-                            $collection[] = $token;
-                            $tag_index++;
-                        }
-                        continue;
-                }
-            }
-        }
-
-        if (empty($content)) return false;
-
-        $ret = array();
-        if ($caption !== false) $ret = array_merge($ret, $caption);
-        if ($cols !== false)    foreach ($cols as $token_array) $ret = array_merge($ret, $token_array);
-        if ($thead !== false)   $ret = array_merge($ret, $thead);
-        if ($tfoot !== false)   $ret = array_merge($ret, $tfoot);
-
-        if ($tbody_mode) {
-            // a little tricky, since the start of the collection may be
-            // whitespace
-            $inside_tbody = false;
-            foreach ($content as $token_array) {
-                // find the starting token
-                foreach ($token_array as $t) {
-                    if ($t->name === 'tr' || $t->name === 'tbody') {
-                        break;
-                    }
-                } // iterator variable carries over
-                if ($t->name === 'tr') {
-                    if ($inside_tbody) {
-                        $ret = array_merge($ret, $token_array);
-                    } else {
-                        $ret[] = new HTMLPurifier_Token_Start('tbody');
-                        $ret = array_merge($ret, $token_array);
-                        $inside_tbody = true;
-                    }
-                } elseif ($t->name === 'tbody') {
-                    if ($inside_tbody) {
-                        $ret[] = new HTMLPurifier_Token_End('tbody');
-                        $inside_tbody = false;
-                        $ret = array_merge($ret, $token_array);
-                    } else {
-                        $ret = array_merge($ret, $token_array);
-                    }
-                } else {
-                    trigger_error("tr/tbody in content invariant failed in Table ChildDef", E_USER_ERROR);
-                }
-            }
-            if ($inside_tbody) {
-                $ret[] = new HTMLPurifier_Token_End('tbody');
-            }
-        } else {
-            foreach ($content as $token_array) {
-                // invariant: everything in here is <tr>s
-                $ret = array_merge($ret, $token_array);
-            }
-        }
-
-        if (!empty($collection) && $is_collecting == false){
-            // grab the trailing space
-            $ret = array_merge($ret, $collection);
-        }
-
-        array_pop($tokens_of_children); // remove phantom token
-
-        return ($ret === $tokens_of_children) ? true : $ret;
-
-    }
+	public $allow_empty = false;
+	public $type = 'table';
+	public $elements = array('tr' => true, 'tbody' => true, 'thead' => true,
+		'tfoot' => true, 'caption' => true, 'colgroup' => true, 'col' => true);
+	public function __construct() {}
+	public function validateChildren($tokens_of_children, $config, $context) {
+		if (empty($tokens_of_children)) return false;
+
+		// this ensures that the loop gets run one last time before closing
+		// up. It's a little bit of a hack, but it works! Just make sure you
+		// get rid of the token later.
+		$tokens_of_children[] = false;
+
+		// only one of these elements is allowed in a table
+		$caption = false;
+		$thead   = false;
+		$tfoot   = false;
+
+		// as many of these as you want
+		$cols    = array();
+		$content = array();
+
+		$nesting = 0; // current depth so we can determine nodes
+		$is_collecting = false; // are we globbing together tokens to package
+								// into one of the collectors?
+		$collection = array(); // collected nodes
+		$tag_index = 0; // the first node might be whitespace,
+							// so this tells us where the start tag is
+		$tbody_mode = false; // if true, then we need to wrap any stray
+							 // <tr>s with a <tbody>.
+
+		foreach ($tokens_of_children as $token) {
+			$is_child = ($nesting == 0);
+
+			if ($token === false) {
+				// terminating sequence started
+			} elseif ($token instanceof HTMLPurifier_Token_Start) {
+				$nesting++;
+			} elseif ($token instanceof HTMLPurifier_Token_End) {
+				$nesting--;
+			}
+
+			// handle node collection
+			if ($is_collecting) {
+				if ($is_child) {
+					// okay, let's stash the tokens away
+					// first token tells us the type of the collection
+					switch ($collection[$tag_index]->name) {
+						case 'tbody':
+							$tbody_mode = true;
+						case 'tr':
+							$content[] = $collection;
+							break;
+						case 'caption':
+							if ($caption !== false) break;
+							$caption = $collection;
+							break;
+						case 'thead':
+						case 'tfoot':
+							$tbody_mode = true;
+							// XXX This breaks rendering properties with
+							// Firefox, which never floats a <thead> to
+							// the top. Ever. (Our scheme will float the
+							// first <thead> to the top.)  So maybe
+							// <thead>s that are not first should be
+							// turned into <tbody>? Very tricky, indeed.
+
+							// access the appropriate variable, $thead or $tfoot
+							$var = $collection[$tag_index]->name;
+							if ($$var === false) {
+								$$var = $collection;
+							} else {
+								// Oops, there's a second one! What
+								// should we do?  Current behavior is to
+								// transmutate the first and last entries into
+								// tbody tags, and then put into content.
+								// Maybe a better idea is to *attach
+								// it* to the existing thead or tfoot?
+								// We don't do this, because Firefox
+								// doesn't float an extra tfoot to the
+								// bottom like it does for the first one.
+								$collection[$tag_index]->name = 'tbody';
+								$collection[count($collection)-1]->name = 'tbody';
+								$content[] = $collection;
+							}
+							break;
+						 case 'colgroup':
+							$cols[] = $collection;
+							break;
+					}
+					$collection = array();
+					$is_collecting = false;
+					$tag_index = 0;
+				} else {
+					// add the node to the collection
+					$collection[] = $token;
+				}
+			}
+
+			// terminate
+			if ($token === false) break;
+
+			if ($is_child) {
+				// determine what we're dealing with
+				if ($token->name == 'col') {
+					// the only empty tag in the possie, we can handle it
+					// immediately
+					$cols[] = array_merge($collection, array($token));
+					$collection = array();
+					$tag_index = 0;
+					continue;
+				}
+				switch($token->name) {
+					case 'caption':
+					case 'colgroup':
+					case 'thead':
+					case 'tfoot':
+					case 'tbody':
+					case 'tr':
+						$is_collecting = true;
+						$collection[] = $token;
+						continue;
+					default:
+						if (!empty($token->is_whitespace)) {
+							$collection[] = $token;
+							$tag_index++;
+						}
+						continue;
+				}
+			}
+		}
+
+		if (empty($content)) return false;
+
+		$ret = array();
+		if ($caption !== false) $ret = array_merge($ret, $caption);
+		if ($cols !== false)    foreach ($cols as $token_array) $ret = array_merge($ret, $token_array);
+		if ($thead !== false)   $ret = array_merge($ret, $thead);
+		if ($tfoot !== false)   $ret = array_merge($ret, $tfoot);
+
+		if ($tbody_mode) {
+			// a little tricky, since the start of the collection may be
+			// whitespace
+			$inside_tbody = false;
+			foreach ($content as $token_array) {
+				// find the starting token
+				foreach ($token_array as $t) {
+					if ($t->name === 'tr' || $t->name === 'tbody') {
+						break;
+					}
+				} // iterator variable carries over
+				if ($t->name === 'tr') {
+					if ($inside_tbody) {
+						$ret = array_merge($ret, $token_array);
+					} else {
+						$ret[] = new HTMLPurifier_Token_Start('tbody');
+						$ret = array_merge($ret, $token_array);
+						$inside_tbody = true;
+					}
+				} elseif ($t->name === 'tbody') {
+					if ($inside_tbody) {
+						$ret[] = new HTMLPurifier_Token_End('tbody');
+						$inside_tbody = false;
+						$ret = array_merge($ret, $token_array);
+					} else {
+						$ret = array_merge($ret, $token_array);
+					}
+				} else {
+					trigger_error("tr/tbody in content invariant failed in Table ChildDef", E_USER_ERROR);
+				}
+			}
+			if ($inside_tbody) {
+				$ret[] = new HTMLPurifier_Token_End('tbody');
+			}
+		} else {
+			foreach ($content as $token_array) {
+				// invariant: everything in here is <tr>s
+				$ret = array_merge($ret, $token_array);
+			}
+		}
+
+		if (!empty($collection) && $is_collecting == false){
+			// grab the trailing space
+			$ret = array_merge($ret, $collection);
+		}
+
+		array_pop($tokens_of_children); // remove phantom token
+
+		return ($ret === $tokens_of_children) ? true : $ret;
+
+	}
 }
 
 // vim: et sw=4 sts=4

Spacing +3 added lines, -3 removed lines

@@ -113,7 +113,7 @@ 
                                 // doesn't float an extra tfoot to the
                                 // bottom like it does for the first one.
                                 $collection[$tag_index]->name = 'tbody';
-                                $collection[count($collection)-1]->name = 'tbody';
+                                $collection[count($collection) - 1]->name = 'tbody';
                                 $content[] = $collection;
                             }
                             break;
@@ -143,7 +143,7 @@ 
                     $tag_index = 0;
                     continue;
                 }
-                switch($token->name) {
+                switch ($token->name) {
                     case 'caption':
                     case 'colgroup':
                     case 'thead':
@@ -212,7 +212,7 @@ 
             }
         }
 
-        if (!empty($collection) && $is_collecting == false){
+        if (!empty($collection) && $is_collecting == false) {
             // grab the trailing space
             $ret = array_merge($ret, $collection);
         }

Braces +24 added lines, -8 removed lines

@@ -37,7 +37,9 @@ 
         'tfoot' => true, 'caption' => true, 'colgroup' => true, 'col' => true);
     public function __construct() {}
     public function validateChildren($tokens_of_children, $config, $context) {
-        if (empty($tokens_of_children)) return false;
+        if (empty($tokens_of_children)) {
+        	return false;
+        }
 
         // this ensures that the loop gets run one last time before closing
         // up. It's a little bit of a hack, but it works! Just make sure you
@@ -85,7 +87,9 @@ 
                             $content[] = $collection;
                             break;
                         case 'caption':
-                            if ($caption !== false) break;
+                            if ($caption !== false) {
+                            	break;
+                            }
                             $caption = $collection;
                             break;
                         case 'thead':
@@ -131,7 +135,9 @@ 
             }
 
             // terminate
-            if ($token === false) break;
+            if ($token === false) {
+            	break;
+            }
 
             if ($is_child) {
                 // determine what we're dealing with
@@ -163,13 +169,23 @@ 
             }
         }
 
-        if (empty($content)) return false;
+        if (empty($content)) {
+        	return false;
+        }
 
         $ret = array();
-        if ($caption !== false) $ret = array_merge($ret, $caption);
-        if ($cols !== false)    foreach ($cols as $token_array) $ret = array_merge($ret, $token_array);
-        if ($thead !== false)   $ret = array_merge($ret, $thead);
-        if ($tfoot !== false)   $ret = array_merge($ret, $tfoot);
+        if ($caption !== false) {
+        	$ret = array_merge($ret, $caption);
+        }
+        if ($cols !== false) {
+        	foreach ($cols as $token_array) $ret = array_merge($ret, $token_array);
+        }
+        if ($thead !== false) {
+        	$ret = array_merge($ret, $thead);
+        }
+        if ($tfoot !== false) {
+        	$ret = array_merge($ret, $tfoot);
+        }
 
         if ($tbody_mode) {
             // a little tricky, since the start of the collection may be

classes/security/htmlpurifier/library/HTMLPurifier/Config.php

Indentation +686 added lines, -686 removed lines

@@ -17,692 +17,692 @@
 class HTMLPurifier_Config
 {
 
-    /**
-     * HTML Purifier's version
-     */
-    public $version = '4.4.0';
-
-    /**
-     * Bool indicator whether or not to automatically finalize
-     * the object if a read operation is done
-     */
-    public $autoFinalize = true;
-
-    // protected member variables
-
-    /**
-     * Namespace indexed array of serials for specific namespaces (see
-     * getSerial() for more info).
-     */
-    protected $serials = array();
-
-    /**
-     * Serial for entire configuration object
-     */
-    protected $serial;
-
-    /**
-     * Parser for variables
-     */
-    protected $parser = null;
-
-    /**
-     * Reference HTMLPurifier_ConfigSchema for value checking
-     * @note This is public for introspective purposes. Please don't
-     *       abuse!
-     */
-    public $def;
-
-    /**
-     * Indexed array of definitions
-     */
-    protected $definitions;
-
-    /**
-     * Bool indicator whether or not config is finalized
-     */
-    protected $finalized = false;
-
-    /**
-     * Property list containing configuration directives.
-     */
-    protected $plist;
-
-    /**
-     * Whether or not a set is taking place due to an
-     * alias lookup.
-     */
-    private $aliasMode;
-
-    /**
-     * Set to false if you do not want line and file numbers in errors
-     * (useful when unit testing).  This will also compress some errors
-     * and exceptions.
-     */
-    public $chatty = true;
-
-    /**
-     * Current lock; only gets to this namespace are allowed.
-     */
-    private $lock;
-
-    /**
-     * @param $definition HTMLPurifier_ConfigSchema that defines what directives
-     *                    are allowed.
-     */
-    public function __construct($definition, $parent = null) {
-        $parent = $parent ? $parent : $definition->defaultPlist;
-        $this->plist = new HTMLPurifier_PropertyList($parent);
-        $this->def = $definition; // keep a copy around for checking
-        $this->parser = new HTMLPurifier_VarParser_Flexible();
-    }
-
-    /**
-     * Convenience constructor that creates a config object based on a mixed var
-     * @param mixed $config Variable that defines the state of the config
-     *                      object. Can be: a HTMLPurifier_Config() object,
-     *                      an array of directives based on loadArray(),
-     *                      or a string filename of an ini file.
-     * @param HTMLPurifier_ConfigSchema Schema object
-     * @return Configured HTMLPurifier_Config object
-     */
-    public static function create($config, $schema = null) {
-        if ($config instanceof HTMLPurifier_Config) {
-            // pass-through
-            return $config;
-        }
-        if (!$schema) {
-            $ret = HTMLPurifier_Config::createDefault();
-        } else {
-            $ret = new HTMLPurifier_Config($schema);
-        }
-        if (is_string($config)) $ret->loadIni($config);
-        elseif (is_array($config)) $ret->loadArray($config);
-        return $ret;
-    }
-
-    /**
-     * Creates a new config object that inherits from a previous one.
-     * @param HTMLPurifier_Config $config Configuration object to inherit
-     *        from.
-     * @return HTMLPurifier_Config object with $config as its parent.
-     */
-    public static function inherit(HTMLPurifier_Config $config) {
-        return new HTMLPurifier_Config($config->def, $config->plist);
-    }
-
-    /**
-     * Convenience constructor that creates a default configuration object.
-     * @return Default HTMLPurifier_Config object.
-     */
-    public static function createDefault() {
-        $definition = HTMLPurifier_ConfigSchema::instance();
-        $config = new HTMLPurifier_Config($definition);
-        return $config;
-    }
-
-    /**
-     * Retreives a value from the configuration.
-     * @param $key String key
-     */
-    public function get($key, $a = null) {
-        if ($a !== null) {
-            $this->triggerError("Using deprecated API: use \$config->get('$key.$a') instead", E_USER_WARNING);
-            $key = "$key.$a";
-        }
-        if (!$this->finalized) $this->autoFinalize();
-        if (!isset($this->def->info[$key])) {
-            // can't add % due to SimpleTest bug
-            $this->triggerError('Cannot retrieve value of undefined directive ' . htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
-                E_USER_WARNING);
-            return;
-        }
-        if (isset($this->def->info[$key]->isAlias)) {
-            $d = $this->def->info[$key];
-            $this->triggerError('Cannot get value from aliased directive, use real name ' . $d->key,
-                E_USER_ERROR);
-            return;
-        }
-        if ($this->lock) {
-            list($ns) = explode('.', $key);
-            if ($ns !== $this->lock) {
-                $this->triggerError('Cannot get value of namespace ' . $ns . ' when lock for ' . $this->lock . ' is active, this probably indicates a Definition setup method is accessing directives that are not within its namespace', E_USER_ERROR);
-                return;
-            }
-        }
-        return $this->plist->get($key);
-    }
-
-    /**
-     * Retreives an array of directives to values from a given namespace
-     * @param $namespace String namespace
-     */
-    public function getBatch($namespace) {
-        if (!$this->finalized) $this->autoFinalize();
-        $full = $this->getAll();
-        if (!isset($full[$namespace])) {
-            $this->triggerError('Cannot retrieve undefined namespace ' . htmlspecialchars($namespace, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
-                E_USER_WARNING);
-            return;
-        }
-        return $full[$namespace];
-    }
-
-    /**
-     * Returns a md5 signature of a segment of the configuration object
-     * that uniquely identifies that particular configuration
-     * @note Revision is handled specially and is removed from the batch
-     *       before processing!
-     * @param $namespace Namespace to get serial for
-     */
-    public function getBatchSerial($namespace) {
-        if (empty($this->serials[$namespace])) {
-            $batch = $this->getBatch($namespace);
-            unset($batch['DefinitionRev']);
-            $this->serials[$namespace] = md5(serialize($batch));
-        }
-        return $this->serials[$namespace];
-    }
-
-    /**
-     * Returns a md5 signature for the entire configuration object
-     * that uniquely identifies that particular configuration
-     */
-    public function getSerial() {
-        if (empty($this->serial)) {
-            $this->serial = md5(serialize($this->getAll()));
-        }
-        return $this->serial;
-    }
-
-    /**
-     * Retrieves all directives, organized by namespace
-     * @warning This is a pretty inefficient function, avoid if you can
-     */
-    public function getAll() {
-        if (!$this->finalized) $this->autoFinalize();
-        $ret = array();
-        foreach ($this->plist->squash() as $name => $value) {
-            list($ns, $key) = explode('.', $name, 2);
-            $ret[$ns][$key] = $value;
-        }
-        return $ret;
-    }
-
-    /**
-     * Sets a value to configuration.
-     * @param $key String key
-     * @param $value Mixed value
-     */
-    public function set($key, $value, $a = null) {
-        if (strpos($key, '.') === false) {
-            $namespace = $key;
-            $directive = $value;
-            $value = $a;
-            $key = "$key.$directive";
-            $this->triggerError("Using deprecated API: use \$config->set('$key', ...) instead", E_USER_NOTICE);
-        } else {
-            list($namespace) = explode('.', $key);
-        }
-        if ($this->isFinalized('Cannot set directive after finalization')) return;
-        if (!isset($this->def->info[$key])) {
-            $this->triggerError('Cannot set undefined directive ' . htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false) . ' to value',
-                E_USER_WARNING);
-            return;
-        }
-        $def = $this->def->info[$key];
-
-        if (isset($def->isAlias)) {
-            if ($this->aliasMode) {
-                $this->triggerError('Double-aliases not allowed, please fix '.
-                    'ConfigSchema bug with' . $key, E_USER_ERROR);
-                return;
-            }
-            $this->aliasMode = true;
-            $this->set($def->key, $value);
-            $this->aliasMode = false;
-            $this->triggerError("$key is an alias, preferred directive name is {$def->key}", E_USER_NOTICE);
-            return;
-        }
-
-        // Raw type might be negative when using the fully optimized form
-        // of stdclass, which indicates allow_null == true
-        $rtype = is_int($def) ? $def : $def->type;
-        if ($rtype < 0) {
-            $type = -$rtype;
-            $allow_null = true;
-        } else {
-            $type = $rtype;
-            $allow_null = isset($def->allow_null);
-        }
-
-        try {
-            $value = $this->parser->parse($value, $type, $allow_null);
-        } catch (HTMLPurifier_VarParserException $e) {
-            $this->triggerError('Value for ' . $key . ' is of invalid type, should be ' . HTMLPurifier_VarParser::getTypeName($type), E_USER_WARNING);
-            return;
-        }
-        if (is_string($value) && is_object($def)) {
-            // resolve value alias if defined
-            if (isset($def->aliases[$value])) {
-                $value = $def->aliases[$value];
-            }
-            // check to see if the value is allowed
-            if (isset($def->allowed) && !isset($def->allowed[$value])) {
-                $this->triggerError('Value not supported, valid values are: ' .
-                    $this->_listify($def->allowed), E_USER_WARNING);
-                return;
-            }
-        }
-        $this->plist->set($key, $value);
-
-        // reset definitions if the directives they depend on changed
-        // this is a very costly process, so it's discouraged
-        // with finalization
-        if ($namespace == 'HTML' || $namespace == 'CSS' || $namespace == 'URI') {
-            $this->definitions[$namespace] = null;
-        }
-
-        $this->serials[$namespace] = false;
-    }
-
-    /**
-     * Convenience function for error reporting
-     */
-    private function _listify($lookup) {
-        $list = array();
-        foreach ($lookup as $name => $b) $list[] = $name;
-        return implode(', ', $list);
-    }
-
-    /**
-     * Retrieves object reference to the HTML definition.
-     * @param $raw Return a copy that has not been setup yet. Must be
-     *             called before it's been setup, otherwise won't work.
-     * @param $optimized If true, this method may return null, to
-     *             indicate that a cached version of the modified
-     *             definition object is available and no further edits
-     *             are necessary.  Consider using
-     *             maybeGetRawHTMLDefinition, which is more explicitly
-     *             named, instead.
-     */
-    public function getHTMLDefinition($raw = false, $optimized = false) {
-        return $this->getDefinition('HTML', $raw, $optimized);
-    }
-
-    /**
-     * Retrieves object reference to the CSS definition
-     * @param $raw Return a copy that has not been setup yet. Must be
-     *             called before it's been setup, otherwise won't work.
-     * @param $optimized If true, this method may return null, to
-     *             indicate that a cached version of the modified
-     *             definition object is available and no further edits
-     *             are necessary.  Consider using
-     *             maybeGetRawCSSDefinition, which is more explicitly
-     *             named, instead.
-     */
-    public function getCSSDefinition($raw = false, $optimized = false) {
-        return $this->getDefinition('CSS', $raw, $optimized);
-    }
-
-    /**
-     * Retrieves object reference to the URI definition
-     * @param $raw Return a copy that has not been setup yet. Must be
-     *             called before it's been setup, otherwise won't work.
-     * @param $optimized If true, this method may return null, to
-     *             indicate that a cached version of the modified
-     *             definition object is available and no further edits
-     *             are necessary.  Consider using
-     *             maybeGetRawURIDefinition, which is more explicitly
-     *             named, instead.
-     */
-    public function getURIDefinition($raw = false, $optimized = false) {
-        return $this->getDefinition('URI', $raw, $optimized);
-    }
-
-    /**
-     * Retrieves a definition
-     * @param $type Type of definition: HTML, CSS, etc
-     * @param $raw  Whether or not definition should be returned raw
-     * @param $optimized Only has an effect when $raw is true.  Whether
-     *        or not to return null if the result is already present in
-     *        the cache.  This is off by default for backwards
-     *        compatibility reasons, but you need to do things this
-     *        way in order to ensure that caching is done properly.
-     *        Check out enduser-customize.html for more details.
-     *        We probably won't ever change this default, as much as the
-     *        maybe semantics is the "right thing to do."
-     */
-    public function getDefinition($type, $raw = false, $optimized = false) {
-        if ($optimized && !$raw) {
-            throw new HTMLPurifier_Exception("Cannot set optimized = true when raw = false");
-        }
-        if (!$this->finalized) $this->autoFinalize();
-        // temporarily suspend locks, so we can handle recursive definition calls
-        $lock = $this->lock;
-        $this->lock = null;
-        $factory = HTMLPurifier_DefinitionCacheFactory::instance();
-        $cache = $factory->create($type, $this);
-        $this->lock = $lock;
-        if (!$raw) {
-            // full definition
-            // ---------------
-            // check if definition is in memory
-            if (!empty($this->definitions[$type])) {
-                $def = $this->definitions[$type];
-                // check if the definition is setup
-                if ($def->setup) {
-                    return $def;
-                } else {
-                    $def->setup($this);
-                    if ($def->optimized) $cache->add($def, $this);
-                    return $def;
-                }
-            }
-            // check if definition is in cache
-            $def = $cache->get($this);
-            if ($def) {
-                // definition in cache, save to memory and return it
-                $this->definitions[$type] = $def;
-                return $def;
-            }
-            // initialize it
-            $def = $this->initDefinition($type);
-            // set it up
-            $this->lock = $type;
-            $def->setup($this);
-            $this->lock = null;
-            // save in cache
-            $cache->add($def, $this);
-            // return it
-            return $def;
-        } else {
-            // raw definition
-            // --------------
-            // check preconditions
-            $def = null;
-            if ($optimized) {
-                if (is_null($this->get($type . '.DefinitionID'))) {
-                    // fatally error out if definition ID not set
-                    throw new HTMLPurifier_Exception("Cannot retrieve raw version without specifying %$type.DefinitionID");
-                }
-            }
-            if (!empty($this->definitions[$type])) {
-                $def = $this->definitions[$type];
-                if ($def->setup && !$optimized) {
-                    $extra = $this->chatty ? " (try moving this code block earlier in your initialization)" : "";
-                    throw new HTMLPurifier_Exception("Cannot retrieve raw definition after it has already been setup" . $extra);
-                }
-                if ($def->optimized === null) {
-                    $extra = $this->chatty ? " (try flushing your cache)" : "";
-                    throw new HTMLPurifier_Exception("Optimization status of definition is unknown" . $extra);
-                }
-                if ($def->optimized !== $optimized) {
-                    $msg = $optimized ? "optimized" : "unoptimized";
-                    $extra = $this->chatty ? " (this backtrace is for the first inconsistent call, which was for a $msg raw definition)" : "";
-                    throw new HTMLPurifier_Exception("Inconsistent use of optimized and unoptimized raw definition retrievals" . $extra);
-                }
-            }
-            // check if definition was in memory
-            if ($def) {
-                if ($def->setup) {
-                    // invariant: $optimized === true (checked above)
-                    return null;
-                } else {
-                    return $def;
-                }
-            }
-            // if optimized, check if definition was in cache
-            // (because we do the memory check first, this formulation
-            // is prone to cache slamming, but I think
-            // guaranteeing that either /all/ of the raw
-            // setup code or /none/ of it is run is more important.)
-            if ($optimized) {
-                // This code path only gets run once; once we put
-                // something in $definitions (which is guaranteed by the
-                // trailing code), we always short-circuit above.
-                $def = $cache->get($this);
-                if ($def) {
-                    // save the full definition for later, but don't
-                    // return it yet
-                    $this->definitions[$type] = $def;
-                    return null;
-                }
-            }
-            // check invariants for creation
-            if (!$optimized) {
-                if (!is_null($this->get($type . '.DefinitionID'))) {
-                    if ($this->chatty) {
-                        $this->triggerError("Due to a documentation error in previous version of HTML Purifier, your definitions are not being cached.  If this is OK, you can remove the %$type.DefinitionRev and %$type.DefinitionID declaration.  Otherwise, modify your code to use maybeGetRawDefinition, and test if the returned value is null before making any edits (if it is null, that means that a cached version is available, and no raw operations are necessary).  See <a href='http://htmlpurifier.org/docs/enduser-customize.html#optimized'>Customize</a> for more details", E_USER_WARNING);
-                    } else {
-                        $this->triggerError("Useless DefinitionID declaration", E_USER_WARNING);
-                    }
-                }
-            }
-            // initialize it
-            $def = $this->initDefinition($type);
-            $def->optimized = $optimized;
-            return $def;
-        }
-        throw new HTMLPurifier_Exception("The impossible happened!");
-    }
-
-    private function initDefinition($type) {
-        // quick checks failed, let's create the object
-        if ($type == 'HTML') {
-            $def = new HTMLPurifier_HTMLDefinition();
-        } elseif ($type == 'CSS') {
-            $def = new HTMLPurifier_CSSDefinition();
-        } elseif ($type == 'URI') {
-            $def = new HTMLPurifier_URIDefinition();
-        } else {
-            throw new HTMLPurifier_Exception("Definition of $type type not supported");
-        }
-        $this->definitions[$type] = $def;
-        return $def;
-    }
-
-    public function maybeGetRawDefinition($name) {
-        return $this->getDefinition($name, true, true);
-    }
-
-    public function maybeGetRawHTMLDefinition() {
-        return $this->getDefinition('HTML', true, true);
-    }
-
-    public function maybeGetRawCSSDefinition() {
-        return $this->getDefinition('CSS', true, true);
-    }
-
-    public function maybeGetRawURIDefinition() {
-        return $this->getDefinition('URI', true, true);
-    }
-
-    /**
-     * Loads configuration values from an array with the following structure:
-     * Namespace.Directive => Value
-     * @param $config_array Configuration associative array
-     */
-    public function loadArray($config_array) {
-        if ($this->isFinalized('Cannot load directives after finalization')) return;
-        foreach ($config_array as $key => $value) {
-            $key = str_replace('_', '.', $key);
-            if (strpos($key, '.') !== false) {
-                $this->set($key, $value);
-            } else {
-                $namespace = $key;
-                $namespace_values = $value;
-                foreach ($namespace_values as $directive => $value) {
-                    $this->set($namespace .'.'. $directive, $value);
-                }
-            }
-        }
-    }
-
-    /**
-     * Returns a list of array(namespace, directive) for all directives
-     * that are allowed in a web-form context as per an allowed
-     * namespaces/directives list.
-     * @param $allowed List of allowed namespaces/directives
-     */
-    public static function getAllowedDirectivesForForm($allowed, $schema = null) {
-        if (!$schema) {
-            $schema = HTMLPurifier_ConfigSchema::instance();
-        }
-        if ($allowed !== true) {
-             if (is_string($allowed)) $allowed = array($allowed);
-             $allowed_ns = array();
-             $allowed_directives = array();
-             $blacklisted_directives = array();
-             foreach ($allowed as $ns_or_directive) {
-                 if (strpos($ns_or_directive, '.') !== false) {
-                     // directive
-                     if ($ns_or_directive[0] == '-') {
-                         $blacklisted_directives[substr($ns_or_directive, 1)] = true;
-                     } else {
-                         $allowed_directives[$ns_or_directive] = true;
-                     }
-                 } else {
-                     // namespace
-                     $allowed_ns[$ns_or_directive] = true;
-                 }
-             }
-        }
-        $ret = array();
-        foreach ($schema->info as $key => $def) {
-            list($ns, $directive) = explode('.', $key, 2);
-            if ($allowed !== true) {
-                if (isset($blacklisted_directives["$ns.$directive"])) continue;
-                if (!isset($allowed_directives["$ns.$directive"]) && !isset($allowed_ns[$ns])) continue;
-            }
-            if (isset($def->isAlias)) continue;
-            if ($directive == 'DefinitionID' || $directive == 'DefinitionRev') continue;
-            $ret[] = array($ns, $directive);
-        }
-        return $ret;
-    }
-
-    /**
-     * Loads configuration values from $_GET/$_POST that were posted
-     * via ConfigForm
-     * @param $array $_GET or $_POST array to import
-     * @param $index Index/name that the config variables are in
-     * @param $allowed List of allowed namespaces/directives
-     * @param $mq_fix Boolean whether or not to enable magic quotes fix
-     * @param $schema Instance of HTMLPurifier_ConfigSchema to use, if not global copy
-     */
-    public static function loadArrayFromForm($array, $index = false, $allowed = true, $mq_fix = true, $schema = null) {
-        $ret = HTMLPurifier_Config::prepareArrayFromForm($array, $index, $allowed, $mq_fix, $schema);
-        $config = HTMLPurifier_Config::create($ret, $schema);
-        return $config;
-    }
-
-    /**
-     * Merges in configuration values from $_GET/$_POST to object. NOT STATIC.
-     * @note Same parameters as loadArrayFromForm
-     */
-    public function mergeArrayFromForm($array, $index = false, $allowed = true, $mq_fix = true) {
-         $ret = HTMLPurifier_Config::prepareArrayFromForm($array, $index, $allowed, $mq_fix, $this->def);
-         $this->loadArray($ret);
-    }
-
-    /**
-     * Prepares an array from a form into something usable for the more
-     * strict parts of HTMLPurifier_Config
-     */
-    public static function prepareArrayFromForm($array, $index = false, $allowed = true, $mq_fix = true, $schema = null) {
-        if ($index !== false) $array = (isset($array[$index]) && is_array($array[$index])) ? $array[$index] : array();
-        $mq = $mq_fix && function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc();
-
-        $allowed = HTMLPurifier_Config::getAllowedDirectivesForForm($allowed, $schema);
-        $ret = array();
-        foreach ($allowed as $key) {
-            list($ns, $directive) = $key;
-            $skey = "$ns.$directive";
-            if (!empty($array["Null_$skey"])) {
-                $ret[$ns][$directive] = null;
-                continue;
-            }
-            if (!isset($array[$skey])) continue;
-            $value = $mq ? stripslashes($array[$skey]) : $array[$skey];
-            $ret[$ns][$directive] = $value;
-        }
-        return $ret;
-    }
-
-    /**
-     * Loads configuration values from an ini file
-     * @param $filename Name of ini file
-     */
-    public function loadIni($filename) {
-        if ($this->isFinalized('Cannot load directives after finalization')) return;
-        $array = parse_ini_file($filename, true);
-        $this->loadArray($array);
-    }
-
-    /**
-     * Checks whether or not the configuration object is finalized.
-     * @param $error String error message, or false for no error
-     */
-    public function isFinalized($error = false) {
-        if ($this->finalized && $error) {
-            $this->triggerError($error, E_USER_ERROR);
-        }
-        return $this->finalized;
-    }
-
-    /**
-     * Finalizes configuration only if auto finalize is on and not
-     * already finalized
-     */
-    public function autoFinalize() {
-        if ($this->autoFinalize) {
-            $this->finalize();
-        } else {
-            $this->plist->squash(true);
-        }
-    }
-
-    /**
-     * Finalizes a configuration object, prohibiting further change
-     */
-    public function finalize() {
-        $this->finalized = true;
-        $this->parser = null;
-    }
-
-    /**
-     * Produces a nicely formatted error message by supplying the
-     * stack frame information OUTSIDE of HTMLPurifier_Config.
-     */
-    protected function triggerError($msg, $no) {
-        // determine previous stack frame
-        $extra = '';
-        if ($this->chatty) {
-            $trace = debug_backtrace();
-            // zip(tail(trace), trace) -- but PHP is not Haskell har har
-            for ($i = 0, $c = count($trace); $i < $c - 1; $i++) {
-                if ($trace[$i + 1]['class'] === 'HTMLPurifier_Config') {
-                    continue;
-                }
-                $frame = $trace[$i];
-                $extra = " invoked on line {$frame['line']} in file {$frame['file']}";
-                break;
-            }
-        }
-        trigger_error($msg . $extra, $no);
-    }
-
-    /**
-     * Returns a serialized form of the configuration object that can
-     * be reconstituted.
-     */
-    public function serialize() {
-        $this->getDefinition('HTML');
-        $this->getDefinition('CSS');
-        $this->getDefinition('URI');
-        return serialize($this);
-    }
+	/**
+	 * HTML Purifier's version
+	 */
+	public $version = '4.4.0';
+
+	/**
+	 * Bool indicator whether or not to automatically finalize
+	 * the object if a read operation is done
+	 */
+	public $autoFinalize = true;
+
+	// protected member variables
+
+	/**
+	 * Namespace indexed array of serials for specific namespaces (see
+	 * getSerial() for more info).
+	 */
+	protected $serials = array();
+
+	/**
+	 * Serial for entire configuration object
+	 */
+	protected $serial;
+
+	/**
+	 * Parser for variables
+	 */
+	protected $parser = null;
+
+	/**
+	 * Reference HTMLPurifier_ConfigSchema for value checking
+	 * @note This is public for introspective purposes. Please don't
+	 *       abuse!
+	 */
+	public $def;
+
+	/**
+	 * Indexed array of definitions
+	 */
+	protected $definitions;
+
+	/**
+	 * Bool indicator whether or not config is finalized
+	 */
+	protected $finalized = false;
+
+	/**
+	 * Property list containing configuration directives.
+	 */
+	protected $plist;
+
+	/**
+	 * Whether or not a set is taking place due to an
+	 * alias lookup.
+	 */
+	private $aliasMode;
+
+	/**
+	 * Set to false if you do not want line and file numbers in errors
+	 * (useful when unit testing).  This will also compress some errors
+	 * and exceptions.
+	 */
+	public $chatty = true;
+
+	/**
+	 * Current lock; only gets to this namespace are allowed.
+	 */
+	private $lock;
+
+	/**
+	 * @param $definition HTMLPurifier_ConfigSchema that defines what directives
+	 *                    are allowed.
+	 */
+	public function __construct($definition, $parent = null) {
+		$parent = $parent ? $parent : $definition->defaultPlist;
+		$this->plist = new HTMLPurifier_PropertyList($parent);
+		$this->def = $definition; // keep a copy around for checking
+		$this->parser = new HTMLPurifier_VarParser_Flexible();
+	}
+
+	/**
+	 * Convenience constructor that creates a config object based on a mixed var
+	 * @param mixed $config Variable that defines the state of the config
+	 *                      object. Can be: a HTMLPurifier_Config() object,
+	 *                      an array of directives based on loadArray(),
+	 *                      or a string filename of an ini file.
+	 * @param HTMLPurifier_ConfigSchema Schema object
+	 * @return Configured HTMLPurifier_Config object
+	 */
+	public static function create($config, $schema = null) {
+		if ($config instanceof HTMLPurifier_Config) {
+			// pass-through
+			return $config;
+		}
+		if (!$schema) {
+			$ret = HTMLPurifier_Config::createDefault();
+		} else {
+			$ret = new HTMLPurifier_Config($schema);
+		}
+		if (is_string($config)) $ret->loadIni($config);
+		elseif (is_array($config)) $ret->loadArray($config);
+		return $ret;
+	}
+
+	/**
+	 * Creates a new config object that inherits from a previous one.
+	 * @param HTMLPurifier_Config $config Configuration object to inherit
+	 *        from.
+	 * @return HTMLPurifier_Config object with $config as its parent.
+	 */
+	public static function inherit(HTMLPurifier_Config $config) {
+		return new HTMLPurifier_Config($config->def, $config->plist);
+	}
+
+	/**
+	 * Convenience constructor that creates a default configuration object.
+	 * @return Default HTMLPurifier_Config object.
+	 */
+	public static function createDefault() {
+		$definition = HTMLPurifier_ConfigSchema::instance();
+		$config = new HTMLPurifier_Config($definition);
+		return $config;
+	}
+
+	/**
+	 * Retreives a value from the configuration.
+	 * @param $key String key
+	 */
+	public function get($key, $a = null) {
+		if ($a !== null) {
+			$this->triggerError("Using deprecated API: use \$config->get('$key.$a') instead", E_USER_WARNING);
+			$key = "$key.$a";
+		}
+		if (!$this->finalized) $this->autoFinalize();
+		if (!isset($this->def->info[$key])) {
+			// can't add % due to SimpleTest bug
+			$this->triggerError('Cannot retrieve value of undefined directive ' . htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
+				E_USER_WARNING);
+			return;
+		}
+		if (isset($this->def->info[$key]->isAlias)) {
+			$d = $this->def->info[$key];
+			$this->triggerError('Cannot get value from aliased directive, use real name ' . $d->key,
+				E_USER_ERROR);
+			return;
+		}
+		if ($this->lock) {
+			list($ns) = explode('.', $key);
+			if ($ns !== $this->lock) {
+				$this->triggerError('Cannot get value of namespace ' . $ns . ' when lock for ' . $this->lock . ' is active, this probably indicates a Definition setup method is accessing directives that are not within its namespace', E_USER_ERROR);
+				return;
+			}
+		}
+		return $this->plist->get($key);
+	}
+
+	/**
+	 * Retreives an array of directives to values from a given namespace
+	 * @param $namespace String namespace
+	 */
+	public function getBatch($namespace) {
+		if (!$this->finalized) $this->autoFinalize();
+		$full = $this->getAll();
+		if (!isset($full[$namespace])) {
+			$this->triggerError('Cannot retrieve undefined namespace ' . htmlspecialchars($namespace, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
+				E_USER_WARNING);
+			return;
+		}
+		return $full[$namespace];
+	}
+
+	/**
+	 * Returns a md5 signature of a segment of the configuration object
+	 * that uniquely identifies that particular configuration
+	 * @note Revision is handled specially and is removed from the batch
+	 *       before processing!
+	 * @param $namespace Namespace to get serial for
+	 */
+	public function getBatchSerial($namespace) {
+		if (empty($this->serials[$namespace])) {
+			$batch = $this->getBatch($namespace);
+			unset($batch['DefinitionRev']);
+			$this->serials[$namespace] = md5(serialize($batch));
+		}
+		return $this->serials[$namespace];
+	}
+
+	/**
+	 * Returns a md5 signature for the entire configuration object
+	 * that uniquely identifies that particular configuration
+	 */
+	public function getSerial() {
+		if (empty($this->serial)) {
+			$this->serial = md5(serialize($this->getAll()));
+		}
+		return $this->serial;
+	}
+
+	/**
+	 * Retrieves all directives, organized by namespace
+	 * @warning This is a pretty inefficient function, avoid if you can
+	 */
+	public function getAll() {
+		if (!$this->finalized) $this->autoFinalize();
+		$ret = array();
+		foreach ($this->plist->squash() as $name => $value) {
+			list($ns, $key) = explode('.', $name, 2);
+			$ret[$ns][$key] = $value;
+		}
+		return $ret;
+	}
+
+	/**
+	 * Sets a value to configuration.
+	 * @param $key String key
+	 * @param $value Mixed value
+	 */
+	public function set($key, $value, $a = null) {
+		if (strpos($key, '.') === false) {
+			$namespace = $key;
+			$directive = $value;
+			$value = $a;
+			$key = "$key.$directive";
+			$this->triggerError("Using deprecated API: use \$config->set('$key', ...) instead", E_USER_NOTICE);
+		} else {
+			list($namespace) = explode('.', $key);
+		}
+		if ($this->isFinalized('Cannot set directive after finalization')) return;
+		if (!isset($this->def->info[$key])) {
+			$this->triggerError('Cannot set undefined directive ' . htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false) . ' to value',
+				E_USER_WARNING);
+			return;
+		}
+		$def = $this->def->info[$key];
+
+		if (isset($def->isAlias)) {
+			if ($this->aliasMode) {
+				$this->triggerError('Double-aliases not allowed, please fix '.
+					'ConfigSchema bug with' . $key, E_USER_ERROR);
+				return;
+			}
+			$this->aliasMode = true;
+			$this->set($def->key, $value);
+			$this->aliasMode = false;
+			$this->triggerError("$key is an alias, preferred directive name is {$def->key}", E_USER_NOTICE);
+			return;
+		}
+
+		// Raw type might be negative when using the fully optimized form
+		// of stdclass, which indicates allow_null == true
+		$rtype = is_int($def) ? $def : $def->type;
+		if ($rtype < 0) {
+			$type = -$rtype;
+			$allow_null = true;
+		} else {
+			$type = $rtype;
+			$allow_null = isset($def->allow_null);
+		}
+
+		try {
+			$value = $this->parser->parse($value, $type, $allow_null);
+		} catch (HTMLPurifier_VarParserException $e) {
+			$this->triggerError('Value for ' . $key . ' is of invalid type, should be ' . HTMLPurifier_VarParser::getTypeName($type), E_USER_WARNING);
+			return;
+		}
+		if (is_string($value) && is_object($def)) {
+			// resolve value alias if defined
+			if (isset($def->aliases[$value])) {
+				$value = $def->aliases[$value];
+			}
+			// check to see if the value is allowed
+			if (isset($def->allowed) && !isset($def->allowed[$value])) {
+				$this->triggerError('Value not supported, valid values are: ' .
+					$this->_listify($def->allowed), E_USER_WARNING);
+				return;
+			}
+		}
+		$this->plist->set($key, $value);
+
+		// reset definitions if the directives they depend on changed
+		// this is a very costly process, so it's discouraged
+		// with finalization
+		if ($namespace == 'HTML' || $namespace == 'CSS' || $namespace == 'URI') {
+			$this->definitions[$namespace] = null;
+		}
+
+		$this->serials[$namespace] = false;
+	}
+
+	/**
+	 * Convenience function for error reporting
+	 */
+	private function _listify($lookup) {
+		$list = array();
+		foreach ($lookup as $name => $b) $list[] = $name;
+		return implode(', ', $list);
+	}
+
+	/**
+	 * Retrieves object reference to the HTML definition.
+	 * @param $raw Return a copy that has not been setup yet. Must be
+	 *             called before it's been setup, otherwise won't work.
+	 * @param $optimized If true, this method may return null, to
+	 *             indicate that a cached version of the modified
+	 *             definition object is available and no further edits
+	 *             are necessary.  Consider using
+	 *             maybeGetRawHTMLDefinition, which is more explicitly
+	 *             named, instead.
+	 */
+	public function getHTMLDefinition($raw = false, $optimized = false) {
+		return $this->getDefinition('HTML', $raw, $optimized);
+	}
+
+	/**
+	 * Retrieves object reference to the CSS definition
+	 * @param $raw Return a copy that has not been setup yet. Must be
+	 *             called before it's been setup, otherwise won't work.
+	 * @param $optimized If true, this method may return null, to
+	 *             indicate that a cached version of the modified
+	 *             definition object is available and no further edits
+	 *             are necessary.  Consider using
+	 *             maybeGetRawCSSDefinition, which is more explicitly
+	 *             named, instead.
+	 */
+	public function getCSSDefinition($raw = false, $optimized = false) {
+		return $this->getDefinition('CSS', $raw, $optimized);
+	}
+
+	/**
+	 * Retrieves object reference to the URI definition
+	 * @param $raw Return a copy that has not been setup yet. Must be
+	 *             called before it's been setup, otherwise won't work.
+	 * @param $optimized If true, this method may return null, to
+	 *             indicate that a cached version of the modified
+	 *             definition object is available and no further edits
+	 *             are necessary.  Consider using
+	 *             maybeGetRawURIDefinition, which is more explicitly
+	 *             named, instead.
+	 */
+	public function getURIDefinition($raw = false, $optimized = false) {
+		return $this->getDefinition('URI', $raw, $optimized);
+	}
+
+	/**
+	 * Retrieves a definition
+	 * @param $type Type of definition: HTML, CSS, etc
+	 * @param $raw  Whether or not definition should be returned raw
+	 * @param $optimized Only has an effect when $raw is true.  Whether
+	 *        or not to return null if the result is already present in
+	 *        the cache.  This is off by default for backwards
+	 *        compatibility reasons, but you need to do things this
+	 *        way in order to ensure that caching is done properly.
+	 *        Check out enduser-customize.html for more details.
+	 *        We probably won't ever change this default, as much as the
+	 *        maybe semantics is the "right thing to do."
+	 */
+	public function getDefinition($type, $raw = false, $optimized = false) {
+		if ($optimized && !$raw) {
+			throw new HTMLPurifier_Exception("Cannot set optimized = true when raw = false");
+		}
+		if (!$this->finalized) $this->autoFinalize();
+		// temporarily suspend locks, so we can handle recursive definition calls
+		$lock = $this->lock;
+		$this->lock = null;
+		$factory = HTMLPurifier_DefinitionCacheFactory::instance();
+		$cache = $factory->create($type, $this);
+		$this->lock = $lock;
+		if (!$raw) {
+			// full definition
+			// ---------------
+			// check if definition is in memory
+			if (!empty($this->definitions[$type])) {
+				$def = $this->definitions[$type];
+				// check if the definition is setup
+				if ($def->setup) {
+					return $def;
+				} else {
+					$def->setup($this);
+					if ($def->optimized) $cache->add($def, $this);
+					return $def;
+				}
+			}
+			// check if definition is in cache
+			$def = $cache->get($this);
+			if ($def) {
+				// definition in cache, save to memory and return it
+				$this->definitions[$type] = $def;
+				return $def;
+			}
+			// initialize it
+			$def = $this->initDefinition($type);
+			// set it up
+			$this->lock = $type;
+			$def->setup($this);
+			$this->lock = null;
+			// save in cache
+			$cache->add($def, $this);
+			// return it
+			return $def;
+		} else {
+			// raw definition
+			// --------------
+			// check preconditions
+			$def = null;
+			if ($optimized) {
+				if (is_null($this->get($type . '.DefinitionID'))) {
+					// fatally error out if definition ID not set
+					throw new HTMLPurifier_Exception("Cannot retrieve raw version without specifying %$type.DefinitionID");
+				}
+			}
+			if (!empty($this->definitions[$type])) {
+				$def = $this->definitions[$type];
+				if ($def->setup && !$optimized) {
+					$extra = $this->chatty ? " (try moving this code block earlier in your initialization)" : "";
+					throw new HTMLPurifier_Exception("Cannot retrieve raw definition after it has already been setup" . $extra);
+				}
+				if ($def->optimized === null) {
+					$extra = $this->chatty ? " (try flushing your cache)" : "";
+					throw new HTMLPurifier_Exception("Optimization status of definition is unknown" . $extra);
+				}
+				if ($def->optimized !== $optimized) {
+					$msg = $optimized ? "optimized" : "unoptimized";
+					$extra = $this->chatty ? " (this backtrace is for the first inconsistent call, which was for a $msg raw definition)" : "";
+					throw new HTMLPurifier_Exception("Inconsistent use of optimized and unoptimized raw definition retrievals" . $extra);
+				}
+			}
+			// check if definition was in memory
+			if ($def) {
+				if ($def->setup) {
+					// invariant: $optimized === true (checked above)
+					return null;
+				} else {
+					return $def;
+				}
+			}
+			// if optimized, check if definition was in cache
+			// (because we do the memory check first, this formulation
+			// is prone to cache slamming, but I think
+			// guaranteeing that either /all/ of the raw
+			// setup code or /none/ of it is run is more important.)
+			if ($optimized) {
+				// This code path only gets run once; once we put
+				// something in $definitions (which is guaranteed by the
+				// trailing code), we always short-circuit above.
+				$def = $cache->get($this);
+				if ($def) {
+					// save the full definition for later, but don't
+					// return it yet
+					$this->definitions[$type] = $def;
+					return null;
+				}
+			}
+			// check invariants for creation
+			if (!$optimized) {
+				if (!is_null($this->get($type . '.DefinitionID'))) {
+					if ($this->chatty) {
+						$this->triggerError("Due to a documentation error in previous version of HTML Purifier, your definitions are not being cached.  If this is OK, you can remove the %$type.DefinitionRev and %$type.DefinitionID declaration.  Otherwise, modify your code to use maybeGetRawDefinition, and test if the returned value is null before making any edits (if it is null, that means that a cached version is available, and no raw operations are necessary).  See <a href='http://htmlpurifier.org/docs/enduser-customize.html#optimized'>Customize</a> for more details", E_USER_WARNING);
+					} else {
+						$this->triggerError("Useless DefinitionID declaration", E_USER_WARNING);
+					}
+				}
+			}
+			// initialize it
+			$def = $this->initDefinition($type);
+			$def->optimized = $optimized;
+			return $def;
+		}
+		throw new HTMLPurifier_Exception("The impossible happened!");
+	}
+
+	private function initDefinition($type) {
+		// quick checks failed, let's create the object
+		if ($type == 'HTML') {
+			$def = new HTMLPurifier_HTMLDefinition();
+		} elseif ($type == 'CSS') {
+			$def = new HTMLPurifier_CSSDefinition();
+		} elseif ($type == 'URI') {
+			$def = new HTMLPurifier_URIDefinition();
+		} else {
+			throw new HTMLPurifier_Exception("Definition of $type type not supported");
+		}
+		$this->definitions[$type] = $def;
+		return $def;
+	}
+
+	public function maybeGetRawDefinition($name) {
+		return $this->getDefinition($name, true, true);
+	}
+
+	public function maybeGetRawHTMLDefinition() {
+		return $this->getDefinition('HTML', true, true);
+	}
+
+	public function maybeGetRawCSSDefinition() {
+		return $this->getDefinition('CSS', true, true);
+	}
+
+	public function maybeGetRawURIDefinition() {
+		return $this->getDefinition('URI', true, true);
+	}
+
+	/**
+	 * Loads configuration values from an array with the following structure:
+	 * Namespace.Directive => Value
+	 * @param $config_array Configuration associative array
+	 */
+	public function loadArray($config_array) {
+		if ($this->isFinalized('Cannot load directives after finalization')) return;
+		foreach ($config_array as $key => $value) {
+			$key = str_replace('_', '.', $key);
+			if (strpos($key, '.') !== false) {
+				$this->set($key, $value);
+			} else {
+				$namespace = $key;
+				$namespace_values = $value;
+				foreach ($namespace_values as $directive => $value) {
+					$this->set($namespace .'.'. $directive, $value);
+				}
+			}
+		}
+	}
+
+	/**
+	 * Returns a list of array(namespace, directive) for all directives
+	 * that are allowed in a web-form context as per an allowed
+	 * namespaces/directives list.
+	 * @param $allowed List of allowed namespaces/directives
+	 */
+	public static function getAllowedDirectivesForForm($allowed, $schema = null) {
+		if (!$schema) {
+			$schema = HTMLPurifier_ConfigSchema::instance();
+		}
+		if ($allowed !== true) {
+			 if (is_string($allowed)) $allowed = array($allowed);
+			 $allowed_ns = array();
+			 $allowed_directives = array();
+			 $blacklisted_directives = array();
+			 foreach ($allowed as $ns_or_directive) {
+				 if (strpos($ns_or_directive, '.') !== false) {
+					 // directive
+					 if ($ns_or_directive[0] == '-') {
+						 $blacklisted_directives[substr($ns_or_directive, 1)] = true;
+					 } else {
+						 $allowed_directives[$ns_or_directive] = true;
+					 }
+				 } else {
+					 // namespace
+					 $allowed_ns[$ns_or_directive] = true;
+				 }
+			 }
+		}
+		$ret = array();
+		foreach ($schema->info as $key => $def) {
+			list($ns, $directive) = explode('.', $key, 2);
+			if ($allowed !== true) {
+				if (isset($blacklisted_directives["$ns.$directive"])) continue;
+				if (!isset($allowed_directives["$ns.$directive"]) && !isset($allowed_ns[$ns])) continue;
+			}
+			if (isset($def->isAlias)) continue;
+			if ($directive == 'DefinitionID' || $directive == 'DefinitionRev') continue;
+			$ret[] = array($ns, $directive);
+		}
+		return $ret;
+	}
+
+	/**
+	 * Loads configuration values from $_GET/$_POST that were posted
+	 * via ConfigForm
+	 * @param $array $_GET or $_POST array to import
+	 * @param $index Index/name that the config variables are in
+	 * @param $allowed List of allowed namespaces/directives
+	 * @param $mq_fix Boolean whether or not to enable magic quotes fix
+	 * @param $schema Instance of HTMLPurifier_ConfigSchema to use, if not global copy
+	 */
+	public static function loadArrayFromForm($array, $index = false, $allowed = true, $mq_fix = true, $schema = null) {
+		$ret = HTMLPurifier_Config::prepareArrayFromForm($array, $index, $allowed, $mq_fix, $schema);
+		$config = HTMLPurifier_Config::create($ret, $schema);
+		return $config;
+	}
+
+	/**
+	 * Merges in configuration values from $_GET/$_POST to object. NOT STATIC.
+	 * @note Same parameters as loadArrayFromForm
+	 */
+	public function mergeArrayFromForm($array, $index = false, $allowed = true, $mq_fix = true) {
+		 $ret = HTMLPurifier_Config::prepareArrayFromForm($array, $index, $allowed, $mq_fix, $this->def);
+		 $this->loadArray($ret);
+	}
+
+	/**
+	 * Prepares an array from a form into something usable for the more
+	 * strict parts of HTMLPurifier_Config
+	 */
+	public static function prepareArrayFromForm($array, $index = false, $allowed = true, $mq_fix = true, $schema = null) {
+		if ($index !== false) $array = (isset($array[$index]) && is_array($array[$index])) ? $array[$index] : array();
+		$mq = $mq_fix && function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc();
+
+		$allowed = HTMLPurifier_Config::getAllowedDirectivesForForm($allowed, $schema);
+		$ret = array();
+		foreach ($allowed as $key) {
+			list($ns, $directive) = $key;
+			$skey = "$ns.$directive";
+			if (!empty($array["Null_$skey"])) {
+				$ret[$ns][$directive] = null;
+				continue;
+			}
+			if (!isset($array[$skey])) continue;
+			$value = $mq ? stripslashes($array[$skey]) : $array[$skey];
+			$ret[$ns][$directive] = $value;
+		}
+		return $ret;
+	}
+
+	/**
+	 * Loads configuration values from an ini file
+	 * @param $filename Name of ini file
+	 */
+	public function loadIni($filename) {
+		if ($this->isFinalized('Cannot load directives after finalization')) return;
+		$array = parse_ini_file($filename, true);
+		$this->loadArray($array);
+	}
+
+	/**
+	 * Checks whether or not the configuration object is finalized.
+	 * @param $error String error message, or false for no error
+	 */
+	public function isFinalized($error = false) {
+		if ($this->finalized && $error) {
+			$this->triggerError($error, E_USER_ERROR);
+		}
+		return $this->finalized;
+	}
+
+	/**
+	 * Finalizes configuration only if auto finalize is on and not
+	 * already finalized
+	 */
+	public function autoFinalize() {
+		if ($this->autoFinalize) {
+			$this->finalize();
+		} else {
+			$this->plist->squash(true);
+		}
+	}
+
+	/**
+	 * Finalizes a configuration object, prohibiting further change
+	 */
+	public function finalize() {
+		$this->finalized = true;
+		$this->parser = null;
+	}
+
+	/**
+	 * Produces a nicely formatted error message by supplying the
+	 * stack frame information OUTSIDE of HTMLPurifier_Config.
+	 */
+	protected function triggerError($msg, $no) {
+		// determine previous stack frame
+		$extra = '';
+		if ($this->chatty) {
+			$trace = debug_backtrace();
+			// zip(tail(trace), trace) -- but PHP is not Haskell har har
+			for ($i = 0, $c = count($trace); $i < $c - 1; $i++) {
+				if ($trace[$i + 1]['class'] === 'HTMLPurifier_Config') {
+					continue;
+				}
+				$frame = $trace[$i];
+				$extra = " invoked on line {$frame['line']} in file {$frame['file']}";
+				break;
+			}
+		}
+		trigger_error($msg . $extra, $no);
+	}
+
+	/**
+	 * Returns a serialized form of the configuration object that can
+	 * be reconstituted.
+	 */
+	public function serialize() {
+		$this->getDefinition('HTML');
+		$this->getDefinition('CSS');
+		$this->getDefinition('URI');
+		return serialize($this);
+	}
 
 }
 

Braces +53 added lines, -18 removed lines

@@ -116,8 +116,11 @@ 
         } else {
             $ret = new HTMLPurifier_Config($schema);
         }
-        if (is_string($config)) $ret->loadIni($config);
-        elseif (is_array($config)) $ret->loadArray($config);
+        if (is_string($config)) {
+        	$ret->loadIni($config);
+        } elseif (is_array($config)) {
+        	$ret->loadArray($config);
+        }
         return $ret;
     }
 
@@ -150,7 +153,9 @@ 
             $this->triggerError("Using deprecated API: use \$config->get('$key.$a') instead", E_USER_WARNING);
             $key = "$key.$a";
         }
-        if (!$this->finalized) $this->autoFinalize();
+        if (!$this->finalized) {
+        	$this->autoFinalize();
+        }
         if (!isset($this->def->info[$key])) {
             // can't add % due to SimpleTest bug
             $this->triggerError('Cannot retrieve value of undefined directive ' . htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
@@ -178,7 +183,9 @@ 
      * @param $namespace String namespace
      */
     public function getBatch($namespace) {
-        if (!$this->finalized) $this->autoFinalize();
+        if (!$this->finalized) {
+        	$this->autoFinalize();
+        }
         $full = $this->getAll();
         if (!isset($full[$namespace])) {
             $this->triggerError('Cannot retrieve undefined namespace ' . htmlspecialchars($namespace, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
@@ -220,7 +227,9 @@ 
      * @warning This is a pretty inefficient function, avoid if you can
      */
     public function getAll() {
-        if (!$this->finalized) $this->autoFinalize();
+        if (!$this->finalized) {
+        	$this->autoFinalize();
+        }
         $ret = array();
         foreach ($this->plist->squash() as $name => $value) {
             list($ns, $key) = explode('.', $name, 2);
@@ -244,7 +253,9 @@ 
         } else {
             list($namespace) = explode('.', $key);
         }
-        if ($this->isFinalized('Cannot set directive after finalization')) return;
+        if ($this->isFinalized('Cannot set directive after finalization')) {
+        	return;
+        }
         if (!isset($this->def->info[$key])) {
             $this->triggerError('Cannot set undefined directive ' . htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false) . ' to value',
                 E_USER_WARNING);
@@ -311,7 +322,9 @@ 
      */
     private function _listify($lookup) {
         $list = array();
-        foreach ($lookup as $name => $b) $list[] = $name;
+        foreach ($lookup as $name => $b) {
+        	$list[] = $name;
+        }
         return implode(', ', $list);
     }
 
@@ -377,7 +390,9 @@ 
         if ($optimized && !$raw) {
             throw new HTMLPurifier_Exception("Cannot set optimized = true when raw = false");
         }
-        if (!$this->finalized) $this->autoFinalize();
+        if (!$this->finalized) {
+        	$this->autoFinalize();
+        }
         // temporarily suspend locks, so we can handle recursive definition calls
         $lock = $this->lock;
         $this->lock = null;
@@ -395,7 +410,9 @@ 
                     return $def;
                 } else {
                     $def->setup($this);
-                    if ($def->optimized) $cache->add($def, $this);
+                    if ($def->optimized) {
+                    	$cache->add($def, $this);
+                    }
                     return $def;
                 }
             }
@@ -524,7 +541,9 @@ 
      * @param $config_array Configuration associative array
      */
     public function loadArray($config_array) {
-        if ($this->isFinalized('Cannot load directives after finalization')) return;
+        if ($this->isFinalized('Cannot load directives after finalization')) {
+        	return;
+        }
         foreach ($config_array as $key => $value) {
             $key = str_replace('_', '.', $key);
             if (strpos($key, '.') !== false) {
@@ -550,7 +569,9 @@ 
             $schema = HTMLPurifier_ConfigSchema::instance();
         }
         if ($allowed !== true) {
-             if (is_string($allowed)) $allowed = array($allowed);
+             if (is_string($allowed)) {
+             	$allowed = array($allowed);
+             }
              $allowed_ns = array();
              $allowed_directives = array();
              $blacklisted_directives = array();
@@ -572,11 +593,19 @@ 
         foreach ($schema->info as $key => $def) {
             list($ns, $directive) = explode('.', $key, 2);
             if ($allowed !== true) {
-                if (isset($blacklisted_directives["$ns.$directive"])) continue;
-                if (!isset($allowed_directives["$ns.$directive"]) && !isset($allowed_ns[$ns])) continue;
+                if (isset($blacklisted_directives["$ns.$directive"])) {
+                	continue;
+                }
+                if (!isset($allowed_directives["$ns.$directive"]) && !isset($allowed_ns[$ns])) {
+                	continue;
+                }
+            }
+            if (isset($def->isAlias)) {
+            	continue;
+            }
+            if ($directive == 'DefinitionID' || $directive == 'DefinitionRev') {
+            	continue;
             }
-            if (isset($def->isAlias)) continue;
-            if ($directive == 'DefinitionID' || $directive == 'DefinitionRev') continue;
             $ret[] = array($ns, $directive);
         }
         return $ret;
@@ -611,7 +640,9 @@ 
      * strict parts of HTMLPurifier_Config
      */
     public static function prepareArrayFromForm($array, $index = false, $allowed = true, $mq_fix = true, $schema = null) {
-        if ($index !== false) $array = (isset($array[$index]) && is_array($array[$index])) ? $array[$index] : array();
+        if ($index !== false) {
+        	$array = (isset($array[$index]) && is_array($array[$index])) ? $array[$index] : array();
+        }
         $mq = $mq_fix && function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc();
 
         $allowed = HTMLPurifier_Config::getAllowedDirectivesForForm($allowed, $schema);
@@ -623,7 +654,9 @@ 
                 $ret[$ns][$directive] = null;
                 continue;
             }
-            if (!isset($array[$skey])) continue;
+            if (!isset($array[$skey])) {
+            	continue;
+            }
             $value = $mq ? stripslashes($array[$skey]) : $array[$skey];
             $ret[$ns][$directive] = $value;
         }
@@ -635,7 +668,9 @@ 
      * @param $filename Name of ini file
      */
     public function loadIni($filename) {
-        if ($this->isFinalized('Cannot load directives after finalization')) return;
+        if ($this->isFinalized('Cannot load directives after finalization')) {
+        	return;
+        }
         $array = parse_ini_file($filename, true);
         $this->loadArray($array);
     }

Spacing +15 added lines, -15 removed lines

@@ -153,20 +153,20 @@ 
         if (!$this->finalized) $this->autoFinalize();
         if (!isset($this->def->info[$key])) {
             // can't add % due to SimpleTest bug
-            $this->triggerError('Cannot retrieve value of undefined directive ' . htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
+            $this->triggerError('Cannot retrieve value of undefined directive '.htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
                 E_USER_WARNING);
             return;
         }
         if (isset($this->def->info[$key]->isAlias)) {
             $d = $this->def->info[$key];
-            $this->triggerError('Cannot get value from aliased directive, use real name ' . $d->key,
+            $this->triggerError('Cannot get value from aliased directive, use real name '.$d->key,
                 E_USER_ERROR);
             return;
         }
         if ($this->lock) {
             list($ns) = explode('.', $key);
             if ($ns !== $this->lock) {
-                $this->triggerError('Cannot get value of namespace ' . $ns . ' when lock for ' . $this->lock . ' is active, this probably indicates a Definition setup method is accessing directives that are not within its namespace', E_USER_ERROR);
+                $this->triggerError('Cannot get value of namespace '.$ns.' when lock for '.$this->lock.' is active, this probably indicates a Definition setup method is accessing directives that are not within its namespace', E_USER_ERROR);
                 return;
             }
         }
@@ -181,7 +181,7 @@ 
         if (!$this->finalized) $this->autoFinalize();
         $full = $this->getAll();
         if (!isset($full[$namespace])) {
-            $this->triggerError('Cannot retrieve undefined namespace ' . htmlspecialchars($namespace, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
+            $this->triggerError('Cannot retrieve undefined namespace '.htmlspecialchars($namespace, ENT_COMPAT | ENT_HTML401, 'UTF-8', false),
                 E_USER_WARNING);
             return;
         }
@@ -246,7 +246,7 @@ 
         }
         if ($this->isFinalized('Cannot set directive after finalization')) return;
         if (!isset($this->def->info[$key])) {
-            $this->triggerError('Cannot set undefined directive ' . htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false) . ' to value',
+            $this->triggerError('Cannot set undefined directive '.htmlspecialchars($key, ENT_COMPAT | ENT_HTML401, 'UTF-8', false).' to value',
                 E_USER_WARNING);
             return;
         }
@@ -255,7 +255,7 @@ 
         if (isset($def->isAlias)) {
             if ($this->aliasMode) {
                 $this->triggerError('Double-aliases not allowed, please fix '.
-                    'ConfigSchema bug with' . $key, E_USER_ERROR);
+                    'ConfigSchema bug with'.$key, E_USER_ERROR);
                 return;
             }
             $this->aliasMode = true;
@@ -279,7 +279,7 @@ 
         try {
             $value = $this->parser->parse($value, $type, $allow_null);
         } catch (HTMLPurifier_VarParserException $e) {
-            $this->triggerError('Value for ' . $key . ' is of invalid type, should be ' . HTMLPurifier_VarParser::getTypeName($type), E_USER_WARNING);
+            $this->triggerError('Value for '.$key.' is of invalid type, should be '.HTMLPurifier_VarParser::getTypeName($type), E_USER_WARNING);
             return;
         }
         if (is_string($value) && is_object($def)) {
@@ -289,7 +289,7 @@ 
             }
             // check to see if the value is allowed
             if (isset($def->allowed) && !isset($def->allowed[$value])) {
-                $this->triggerError('Value not supported, valid values are: ' .
+                $this->triggerError('Value not supported, valid values are: '.
                     $this->_listify($def->allowed), E_USER_WARNING);
                 return;
             }
@@ -422,7 +422,7 @@ 
             // check preconditions
             $def = null;
             if ($optimized) {
-                if (is_null($this->get($type . '.DefinitionID'))) {
+                if (is_null($this->get($type.'.DefinitionID'))) {
                     // fatally error out if definition ID not set
                     throw new HTMLPurifier_Exception("Cannot retrieve raw version without specifying %$type.DefinitionID");
                 }
@@ -431,16 +431,16 @@ 
                 $def = $this->definitions[$type];
                 if ($def->setup && !$optimized) {
                     $extra = $this->chatty ? " (try moving this code block earlier in your initialization)" : "";
-                    throw new HTMLPurifier_Exception("Cannot retrieve raw definition after it has already been setup" . $extra);
+                    throw new HTMLPurifier_Exception("Cannot retrieve raw definition after it has already been setup".$extra);
                 }
                 if ($def->optimized === null) {
                     $extra = $this->chatty ? " (try flushing your cache)" : "";
-                    throw new HTMLPurifier_Exception("Optimization status of definition is unknown" . $extra);
+                    throw new HTMLPurifier_Exception("Optimization status of definition is unknown".$extra);
                 }
                 if ($def->optimized !== $optimized) {
                     $msg = $optimized ? "optimized" : "unoptimized";
                     $extra = $this->chatty ? " (this backtrace is for the first inconsistent call, which was for a $msg raw definition)" : "";
-                    throw new HTMLPurifier_Exception("Inconsistent use of optimized and unoptimized raw definition retrievals" . $extra);
+                    throw new HTMLPurifier_Exception("Inconsistent use of optimized and unoptimized raw definition retrievals".$extra);
                 }
             }
             // check if definition was in memory
@@ -471,7 +471,7 @@ 
             }
             // check invariants for creation
             if (!$optimized) {
-                if (!is_null($this->get($type . '.DefinitionID'))) {
+                if (!is_null($this->get($type.'.DefinitionID'))) {
                     if ($this->chatty) {
                         $this->triggerError("Due to a documentation error in previous version of HTML Purifier, your definitions are not being cached.  If this is OK, you can remove the %$type.DefinitionRev and %$type.DefinitionID declaration.  Otherwise, modify your code to use maybeGetRawDefinition, and test if the returned value is null before making any edits (if it is null, that means that a cached version is available, and no raw operations are necessary).  See <a href='http://htmlpurifier.org/docs/enduser-customize.html#optimized'>Customize</a> for more details", E_USER_WARNING);
                     } else {
@@ -533,7 +533,7 @@ 
                 $namespace = $key;
                 $namespace_values = $value;
                 foreach ($namespace_values as $directive => $value) {
-                    $this->set($namespace .'.'. $directive, $value);
+                    $this->set($namespace.'.'.$directive, $value);
                 }
             }
         }
@@ -690,7 +690,7 @@ 
                 break;
             }
         }
-        trigger_error($msg . $extra, $no);
+        trigger_error($msg.$extra, $no);
     }
 
     /**

Doc Comments +7 added lines, -6 removed lines

@@ -89,6 +89,7 @@ 
     /**
      * @param $definition HTMLPurifier_ConfigSchema that defines what directives
      *                    are allowed.
+     * @param HTMLPurifier_PropertyList $parent
      */
     public function __construct($definition, $parent = null) {
         $parent = $parent ? $parent : $definition->defaultPlist;
@@ -104,7 +105,7 @@ 
      *                      an array of directives based on loadArray(),
      *                      or a string filename of an ini file.
      * @param HTMLPurifier_ConfigSchema Schema object
-     * @return Configured HTMLPurifier_Config object
+     * @return HTMLPurifier_Config HTMLPurifier_Config object
      */
     public static function create($config, $schema = null) {
         if ($config instanceof HTMLPurifier_Config) {
@@ -133,7 +134,7 @@ 
 
     /**
      * Convenience constructor that creates a default configuration object.
-     * @return Default HTMLPurifier_Config object.
+     * @return HTMLPurifier_Config HTMLPurifier_Config object.
      */
     public static function createDefault() {
         $definition = HTMLPurifier_ConfigSchema::instance();
@@ -143,7 +144,7 @@ 
 
     /**
      * Retreives a value from the configuration.
-     * @param $key String key
+     * @param string $key String key
      */
     public function get($key, $a = null) {
         if ($a !== null) {
@@ -543,7 +544,7 @@ 
      * Returns a list of array(namespace, directive) for all directives
      * that are allowed in a web-form context as per an allowed
      * namespaces/directives list.
-     * @param $allowed List of allowed namespaces/directives
+     * @param boolean $allowed List of allowed namespaces/directives
      */
     public static function getAllowedDirectivesForForm($allowed, $schema = null) {
         if (!$schema) {
@@ -585,7 +586,6 @@ 
     /**
      * Loads configuration values from $_GET/$_POST that were posted
      * via ConfigForm
-     * @param $array $_GET or $_POST array to import
      * @param $index Index/name that the config variables are in
      * @param $allowed List of allowed namespaces/directives
      * @param $mq_fix Boolean whether or not to enable magic quotes fix
@@ -632,7 +632,7 @@ 
 
     /**
      * Loads configuration values from an ini file
-     * @param $filename Name of ini file
+     * @param string $filename Name of ini file
      */
     public function loadIni($filename) {
         if ($this->isFinalized('Cannot load directives after finalization')) return;
@@ -674,6 +674,7 @@ 
     /**
      * Produces a nicely formatted error message by supplying the
      * stack frame information OUTSIDE of HTMLPurifier_Config.
+     * @param integer $no
      */
     protected function triggerError($msg, $no) {
         // determine previous stack frame

classes/security/htmlpurifier/library/HTMLPurifier/ConfigSchema.php

Indentation +142 added lines, -142 removed lines

@@ -5,159 +5,159 @@
  */
 class HTMLPurifier_ConfigSchema {
 
-    /**
-     * Defaults of the directives and namespaces.
-     * @note This shares the exact same structure as HTMLPurifier_Config::$conf
-     */
-    public $defaults = array();
+	/**
+	 * Defaults of the directives and namespaces.
+	 * @note This shares the exact same structure as HTMLPurifier_Config::$conf
+	 */
+	public $defaults = array();
 
-    /**
-     * The default property list. Do not edit this property list.
-     */
-    public $defaultPlist;
+	/**
+	 * The default property list. Do not edit this property list.
+	 */
+	public $defaultPlist;
 
-    /**
-     * Definition of the directives. The structure of this is:
-     *
-     *  array(
-     *      'Namespace' => array(
-     *          'Directive' => new stdclass(),
-     *      )
-     *  )
-     *
-     * The stdclass may have the following properties:
-     *
-     *  - If isAlias isn't set:
-     *      - type: Integer type of directive, see HTMLPurifier_VarParser for definitions
-     *      - allow_null: If set, this directive allows null values
-     *      - aliases: If set, an associative array of value aliases to real values
-     *      - allowed: If set, a lookup array of allowed (string) values
-     *  - If isAlias is set:
-     *      - namespace: Namespace this directive aliases to
-     *      - name: Directive name this directive aliases to
-     *
-     * In certain degenerate cases, stdclass will actually be an integer. In
-     * that case, the value is equivalent to an stdclass with the type
-     * property set to the integer. If the integer is negative, type is
-     * equal to the absolute value of integer, and allow_null is true.
-     *
-     * This class is friendly with HTMLPurifier_Config. If you need introspection
-     * about the schema, you're better of using the ConfigSchema_Interchange,
-     * which uses more memory but has much richer information.
-     */
-    public $info = array();
+	/**
+	 * Definition of the directives. The structure of this is:
+	 *
+	 *  array(
+	 *      'Namespace' => array(
+	 *          'Directive' => new stdclass(),
+	 *      )
+	 *  )
+	 *
+	 * The stdclass may have the following properties:
+	 *
+	 *  - If isAlias isn't set:
+	 *      - type: Integer type of directive, see HTMLPurifier_VarParser for definitions
+	 *      - allow_null: If set, this directive allows null values
+	 *      - aliases: If set, an associative array of value aliases to real values
+	 *      - allowed: If set, a lookup array of allowed (string) values
+	 *  - If isAlias is set:
+	 *      - namespace: Namespace this directive aliases to
+	 *      - name: Directive name this directive aliases to
+	 *
+	 * In certain degenerate cases, stdclass will actually be an integer. In
+	 * that case, the value is equivalent to an stdclass with the type
+	 * property set to the integer. If the integer is negative, type is
+	 * equal to the absolute value of integer, and allow_null is true.
+	 *
+	 * This class is friendly with HTMLPurifier_Config. If you need introspection
+	 * about the schema, you're better of using the ConfigSchema_Interchange,
+	 * which uses more memory but has much richer information.
+	 */
+	public $info = array();
 
-    /**
-     * Application-wide singleton
-     */
-    static protected $singleton;
+	/**
+	 * Application-wide singleton
+	 */
+	static protected $singleton;
 
-    public function __construct() {
-        $this->defaultPlist = new HTMLPurifier_PropertyList();
-    }
+	public function __construct() {
+		$this->defaultPlist = new HTMLPurifier_PropertyList();
+	}
 
-    /**
-     * Unserializes the default ConfigSchema.
-     */
-    public static function makeFromSerial() {
-        $contents = file_get_contents(HTMLPURIFIER_PREFIX . '/HTMLPurifier/ConfigSchema/schema.ser');
-        $r = unserialize($contents);
-        if (!$r) {
-            $hash = sha1($contents);
-            trigger_error("Unserialization of configuration schema failed, sha1 of file was $hash", E_USER_ERROR);
-        }
-        return $r;
-    }
+	/**
+	 * Unserializes the default ConfigSchema.
+	 */
+	public static function makeFromSerial() {
+		$contents = file_get_contents(HTMLPURIFIER_PREFIX . '/HTMLPurifier/ConfigSchema/schema.ser');
+		$r = unserialize($contents);
+		if (!$r) {
+			$hash = sha1($contents);
+			trigger_error("Unserialization of configuration schema failed, sha1 of file was $hash", E_USER_ERROR);
+		}
+		return $r;
+	}
 
-    /**
-     * Retrieves an instance of the application-wide configuration definition.
-     */
-    public static function instance($prototype = null) {
-        if ($prototype !== null) {
-            HTMLPurifier_ConfigSchema::$singleton = $prototype;
-        } elseif (HTMLPurifier_ConfigSchema::$singleton === null || $prototype === true) {
-            HTMLPurifier_ConfigSchema::$singleton = HTMLPurifier_ConfigSchema::makeFromSerial();
-        }
-        return HTMLPurifier_ConfigSchema::$singleton;
-    }
+	/**
+	 * Retrieves an instance of the application-wide configuration definition.
+	 */
+	public static function instance($prototype = null) {
+		if ($prototype !== null) {
+			HTMLPurifier_ConfigSchema::$singleton = $prototype;
+		} elseif (HTMLPurifier_ConfigSchema::$singleton === null || $prototype === true) {
+			HTMLPurifier_ConfigSchema::$singleton = HTMLPurifier_ConfigSchema::makeFromSerial();
+		}
+		return HTMLPurifier_ConfigSchema::$singleton;
+	}
 
-    /**
-     * Defines a directive for configuration
-     * @warning Will fail of directive's namespace is defined.
-     * @warning This method's signature is slightly different from the legacy
-     *          define() static method! Beware!
-     * @param $namespace Namespace the directive is in
-     * @param $name Key of directive
-     * @param $default Default value of directive
-     * @param $type Allowed type of the directive. See
-     *      HTMLPurifier_DirectiveDef::$type for allowed values
-     * @param $allow_null Whether or not to allow null values
-     */
-    public function add($key, $default, $type, $allow_null) {
-        $obj = new stdclass();
-        $obj->type = is_int($type) ? $type : HTMLPurifier_VarParser::$types[$type];
-        if ($allow_null) $obj->allow_null = true;
-        $this->info[$key] = $obj;
-        $this->defaults[$key] = $default;
-        $this->defaultPlist->set($key, $default);
-    }
+	/**
+	 * Defines a directive for configuration
+	 * @warning Will fail of directive's namespace is defined.
+	 * @warning This method's signature is slightly different from the legacy
+	 *          define() static method! Beware!
+	 * @param $namespace Namespace the directive is in
+	 * @param $name Key of directive
+	 * @param $default Default value of directive
+	 * @param $type Allowed type of the directive. See
+	 *      HTMLPurifier_DirectiveDef::$type for allowed values
+	 * @param $allow_null Whether or not to allow null values
+	 */
+	public function add($key, $default, $type, $allow_null) {
+		$obj = new stdclass();
+		$obj->type = is_int($type) ? $type : HTMLPurifier_VarParser::$types[$type];
+		if ($allow_null) $obj->allow_null = true;
+		$this->info[$key] = $obj;
+		$this->defaults[$key] = $default;
+		$this->defaultPlist->set($key, $default);
+	}
 
-    /**
-     * Defines a directive value alias.
-     *
-     * Directive value aliases are convenient for developers because it lets
-     * them set a directive to several values and get the same result.
-     * @param $namespace Directive's namespace
-     * @param $name Name of Directive
-     * @param $aliases Hash of aliased values to the real alias
-     */
-    public function addValueAliases($key, $aliases) {
-        if (!isset($this->info[$key]->aliases)) {
-            $this->info[$key]->aliases = array();
-        }
-        foreach ($aliases as $alias => $real) {
-            $this->info[$key]->aliases[$alias] = $real;
-        }
-    }
+	/**
+	 * Defines a directive value alias.
+	 *
+	 * Directive value aliases are convenient for developers because it lets
+	 * them set a directive to several values and get the same result.
+	 * @param $namespace Directive's namespace
+	 * @param $name Name of Directive
+	 * @param $aliases Hash of aliased values to the real alias
+	 */
+	public function addValueAliases($key, $aliases) {
+		if (!isset($this->info[$key]->aliases)) {
+			$this->info[$key]->aliases = array();
+		}
+		foreach ($aliases as $alias => $real) {
+			$this->info[$key]->aliases[$alias] = $real;
+		}
+	}
 
-    /**
-     * Defines a set of allowed values for a directive.
-     * @warning This is slightly different from the corresponding static
-     *          method definition.
-     * @param $namespace Namespace of directive
-     * @param $name Name of directive
-     * @param $allowed Lookup array of allowed values
-     */
-    public function addAllowedValues($key, $allowed) {
-        $this->info[$key]->allowed = $allowed;
-    }
+	/**
+	 * Defines a set of allowed values for a directive.
+	 * @warning This is slightly different from the corresponding static
+	 *          method definition.
+	 * @param $namespace Namespace of directive
+	 * @param $name Name of directive
+	 * @param $allowed Lookup array of allowed values
+	 */
+	public function addAllowedValues($key, $allowed) {
+		$this->info[$key]->allowed = $allowed;
+	}
 
-    /**
-     * Defines a directive alias for backwards compatibility
-     * @param $namespace
-     * @param $name Directive that will be aliased
-     * @param $new_namespace
-     * @param $new_name Directive that the alias will be to
-     */
-    public function addAlias($key, $new_key) {
-        $obj = new stdclass;
-        $obj->key = $new_key;
-        $obj->isAlias = true;
-        $this->info[$key] = $obj;
-    }
+	/**
+	 * Defines a directive alias for backwards compatibility
+	 * @param $namespace
+	 * @param $name Directive that will be aliased
+	 * @param $new_namespace
+	 * @param $new_name Directive that the alias will be to
+	 */
+	public function addAlias($key, $new_key) {
+		$obj = new stdclass;
+		$obj->key = $new_key;
+		$obj->isAlias = true;
+		$this->info[$key] = $obj;
+	}
 
-    /**
-     * Replaces any stdclass that only has the type property with type integer.
-     */
-    public function postProcess() {
-        foreach ($this->info as $key => $v) {
-            if (count((array) $v) == 1) {
-                $this->info[$key] = $v->type;
-            } elseif (count((array) $v) == 2 && isset($v->allow_null)) {
-                $this->info[$key] = -$v->type;
-            }
-        }
-    }
+	/**
+	 * Replaces any stdclass that only has the type property with type integer.
+	 */
+	public function postProcess() {
+		foreach ($this->info as $key => $v) {
+			if (count((array) $v) == 1) {
+				$this->info[$key] = $v->type;
+			} elseif (count((array) $v) == 2 && isset($v->allow_null)) {
+				$this->info[$key] = -$v->type;
+			}
+		}
+	}
 
 }
 

Braces +3 added lines, -1 removed lines

@@ -96,7 +96,9 @@
     public function add($key, $default, $type, $allow_null) {
         $obj = new stdclass();
         $obj->type = is_int($type) ? $type : HTMLPurifier_VarParser::$types[$type];
-        if ($allow_null) $obj->allow_null = true;
+        if ($allow_null) {
+        	$obj->allow_null = true;
+        }
         $this->info[$key] = $obj;
         $this->defaults[$key] = $default;
         $this->defaultPlist->set($key, $default);

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      * Unserializes the default ConfigSchema.
      */
     public static function makeFromSerial() {
-        $contents = file_get_contents(HTMLPURIFIER_PREFIX . '/HTMLPurifier/ConfigSchema/schema.ser');
+        $contents = file_get_contents(HTMLPURIFIER_PREFIX.'/HTMLPurifier/ConfigSchema/schema.ser');
         $r = unserialize($contents);
         if (!$r) {
             $hash = sha1($contents);

classes/security/htmlpurifier/library/HTMLPurifier/ConfigSchema/Builder/ConfigSchema.php

Indentation +31 added lines, -31 removed lines

@@ -7,37 +7,37 @@
 class HTMLPurifier_ConfigSchema_Builder_ConfigSchema
 {
 
-    public function build($interchange) {
-        $schema = new HTMLPurifier_ConfigSchema();
-        foreach ($interchange->directives as $d) {
-            $schema->add(
-                $d->id->key,
-                $d->default,
-                $d->type,
-                $d->typeAllowsNull
-            );
-            if ($d->allowed !== null) {
-                $schema->addAllowedValues(
-                    $d->id->key,
-                    $d->allowed
-                );
-            }
-            foreach ($d->aliases as $alias) {
-                $schema->addAlias(
-                    $alias->key,
-                    $d->id->key
-                );
-            }
-            if ($d->valueAliases !== null) {
-                $schema->addValueAliases(
-                    $d->id->key,
-                    $d->valueAliases
-                );
-            }
-        }
-        $schema->postProcess();
-        return $schema;
-    }
+	public function build($interchange) {
+		$schema = new HTMLPurifier_ConfigSchema();
+		foreach ($interchange->directives as $d) {
+			$schema->add(
+				$d->id->key,
+				$d->default,
+				$d->type,
+				$d->typeAllowsNull
+			);
+			if ($d->allowed !== null) {
+				$schema->addAllowedValues(
+					$d->id->key,
+					$d->allowed
+				);
+			}
+			foreach ($d->aliases as $alias) {
+				$schema->addAlias(
+					$alias->key,
+					$d->id->key
+				);
+			}
+			if ($d->valueAliases !== null) {
+				$schema->addValueAliases(
+					$d->id->key,
+					$d->valueAliases
+				);
+			}
+		}
+		$schema->postProcess();
+		return $schema;
+	}
 
 }