xpressengine / xe-core

addons/captcha_member/captcha_member.addon.php

Spacing +44 added lines, -44 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 
-if(!defined("__XE__")) exit();
+if (!defined("__XE__")) exit();
 
 /**
  * @file captcha.addon.php
@@ -9,7 +9,7 @@ 
  * @brief Captcha for a particular action
  * English alphabets and voice verification added
  * */
-if(!class_exists('AddonMemberCaptcha', false))
+if (!class_exists('AddonMemberCaptcha', false))
 {
 	class AddonMemberCaptcha
 	{
@@ -32,7 +32,7 @@ 
 		function before_module_init(&$ModuleHandler)
 		{
 			$logged_info = Context::get('logged_info');
-			if($logged_info->is_admin == 'Y' || $logged_info->is_site_admin)
+			if ($logged_info->is_admin == 'Y' || $logged_info->is_site_admin)
 			{
 				return false;
 			}
@@ -40,11 +40,11 @@ 
 			// {
 			// 	return false;
 			// }
-			if($_SESSION['XE_VALIDATOR_ERROR'] == -1)
+			if ($_SESSION['XE_VALIDATOR_ERROR'] == -1)
 			{
 				$_SESSION['member_captcha_authed'] = false;
 			}
-			if($_SESSION['member_captcha_authed'])
+			if ($_SESSION['member_captcha_authed'])
 			{
 				return false;
 			}
@@ -52,26 +52,26 @@ 
 			$type = Context::get('captchaType');
 
 			$this->target_acts = array();
-			if($this->addon_info->apply_find_account == 'apply')
+			if ($this->addon_info->apply_find_account == 'apply')
 			{
 				$this->target_acts[] = 'procMemberFindAccount';
 			}
-			if($this->addon_info->apply_resend_auth_mail == 'apply')
+			if ($this->addon_info->apply_resend_auth_mail == 'apply')
 			{
 				$this->target_acts[] = 'procMemberResendAuthMail';
 			}
-			if($this->addon_info->apply_signup == 'apply')
+			if ($this->addon_info->apply_signup == 'apply')
 			{
 				$this->target_acts[] = 'procMemberInsert';
 			}
 
-			if(Context::getRequestMethod() != 'XMLRPC' && Context::getRequestMethod() !== 'JSON')
+			if (Context::getRequestMethod() != 'XMLRPC' && Context::getRequestMethod() !== 'JSON')
 			{
-				if($type == 'inline')
+				if ($type == 'inline')
 				{
-					if(!$this->compareCaptcha())
+					if (!$this->compareCaptcha())
 					{
-						Context::loadLang(_XE_PATH_ . 'addons/captcha_member/lang');
+						Context::loadLang(_XE_PATH_.'addons/captcha_member/lang');
 						$_SESSION['XE_VALIDATOR_ERROR'] = -1;
 						$_SESSION['XE_VALIDATOR_MESSAGE'] = Context::getLang('captcha_denied');
 						$_SESSION['XE_VALIDATOR_MESSAGE_TYPE'] = 'error';
@@ -83,16 +83,16 @@ 
 				{
 					Context::addHtmlHeader('<script>
 						if(!captchaTargetAct) {var captchaTargetAct = [];}
-						captchaTargetAct.push("' . implode('","', $this->target_acts) . '");
+						captchaTargetAct.push("' . implode('","', $this->target_acts).'");
 						</script>');
 					Context::loadFile(array('./addons/captcha_member/captcha.min.js', 'body', '', null), true);
 				}
 			}
 
 			// compare session when calling actions such as writing a post or a comment on the board/issue tracker module
-			if(!$_SESSION['member_captcha_authed'] && in_array(Context::get('act'), $this->target_acts))
+			if (!$_SESSION['member_captcha_authed'] && in_array(Context::get('act'), $this->target_acts))
 			{
-				Context::loadLang(_XE_PATH_ . 'addons/captcha_member/lang');
+				Context::loadLang(_XE_PATH_.'addons/captcha_member/lang');
 				$ModuleHandler->error = "captcha_denied";
 			}
 
@@ -102,7 +102,7 @@ 
 		function createKeyword()
 		{
 			$type = Context::get('captchaType');
-			if($type == 'inline' && $_SESSION['captcha_keyword'])
+			if ($type == 'inline' && $_SESSION['captcha_keyword'])
 			{
 				return;
 			}
@@ -115,19 +115,19 @@ 
 
 		function before_module_init_setCaptchaSession()
 		{
-			if($_SESSION['member_captcha_authed'])
+			if ($_SESSION['member_captcha_authed'])
 			{
 				return false;
 			}
 			// Load language files
-			Context::loadLang(_XE_PATH_ . 'addons/captcha_member/lang');
+			Context::loadLang(_XE_PATH_.'addons/captcha_member/lang');
 			// Generate keywords
 			$this->createKeyword();
 
 			$target = Context::getLang('target_captcha');
 			header("Content-Type: text/xml; charset=UTF-8");
 			header("Expires: Mon, 26 Jul 1997 05:00:00 GMT");
-			header("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
+			header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
 			header("Cache-Control: no-store, no-cache, must-revalidate");
 			header("Cache-Control: post-check=0, pre-check=0", false);
 			header("Pragma: no-cache");
@@ -144,11 +144,11 @@ 
 
 		function before_module_init_captchaImage()
 		{
-			if($_SESSION['member_captcha_authed'])
+			if ($_SESSION['member_captcha_authed'])
 			{
 				return false;
 			}
-			if(Context::get('renew'))
+			if (Context::get('renew'))
 			{
 				$this->createKeyword();
 			}
@@ -170,7 +170,7 @@ 
 		function createCaptchaImage($string)
 		{
 			$arr = array();
-			for($i = 0, $c = strlen($string); $i < $c; $i++)
+			for ($i = 0, $c = strlen($string); $i < $c; $i++)
 			{
 				$arr[] = $string{$i};
 			}
@@ -192,7 +192,7 @@ 
 			shuffle($deg);
 
 			// Create an image for each letter
-			foreach($arr as $i => $str)
+			foreach ($arr as $i => $str)
 			{
 				$im[$i + 1] = @imagecreate($w, $h);
 				$background_color = imagecolorallocate($im[$i + 1], 255, 255, 255);
@@ -202,7 +202,7 @@ 
 				$ran = range(1, 20);
 				shuffle($ran);
 
-				if(function_exists('imagerotate'))
+				if (function_exists('imagerotate'))
 				{
 					imagestring($im[$i + 1], (array_pop($ran) % 3) + 3, 2, (array_pop($ran) % 8), $str, $text_color);
 					$im[$i + 1] = imagerotate($im[$i + 1], array_pop($deg), 0);
@@ -217,7 +217,7 @@ 
 			}
 
 			// Combine images of each character
-			for($i = 1; $i < count($im); $i++)
+			for ($i = 1; $i < count($im); $i++)
 			{
 				imagecopy($im[0], $im[$i], (($w + 2) * ($i - 1)), 0, 0, 0, $w, $h);
 				imagedestroy($im[$i]);
@@ -229,7 +229,7 @@ 
 			imagecopyresized($big, $im[0], 0, 0, 0, 0, ($w + 2) * $big_count * $c, $h * $big_count, ($w + 2) * $c, $h);
 			imagedestroy($im[0]);
 
-			if(function_exists('imageantialias'))
+			if (function_exists('imageantialias'))
 			{
 				imageantialias($big, true);
 			}
@@ -241,7 +241,7 @@ 
 			$h = $h * $big_count;
 			$d = array_pop($deg);
 
-			for($i = -abs($d); $i < $h + abs($d); $i = $i + 7)
+			for ($i = -abs($d); $i < $h + abs($d); $i = $i + 7)
 			{
 				imageline($big, 0, $i + $d, $w, $i, $line_color);
 			}
@@ -249,7 +249,7 @@ 
 			$x = range(0, ($w - 10));
 			shuffle($x);
 
-			for($i = 0; $i < 200; $i++)
+			for ($i = 0; $i < 200; $i++)
 			{
 				imagesetpixel($big, $x[$i] % $w, $x[$i + 1] % $h, $line_color);
 			}
@@ -259,7 +259,7 @@ 
 
 		function before_module_init_captchaAudio()
 		{
-			if($_SESSION['member_captcha_authed'])
+			if ($_SESSION['member_captcha_authed'])
 			{
 				return false;
 			}
@@ -271,8 +271,8 @@ 
 			header("Content-Disposition: attachment; filename=\"captcha_audio.mp3\"");
 			header('Cache-Control: no-store, no-cache, must-revalidate');
 			header('Expires: Sun, 1 Jan 2000 12:00:00 GMT');
-			header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . 'GMT');
-			header('Content-Length: ' . strlen($data));
+			header('Last-Modified: '.gmdate('D, d M Y H:i:s').'GMT');
+			header('Content-Length: '.strlen($data));
 
 			echo $data;
 			Context::close();
@@ -283,17 +283,17 @@ 
 		{
 			$data = '';
 			$_audio = './addons/captcha_member/audio/F_%s.mp3';
-			for($i = 0, $c = strlen($string); $i < $c; $i++)
+			for ($i = 0, $c = strlen($string); $i < $c; $i++)
 			{
 				$_data = FileHandler::readFile(sprintf($_audio, $string{$i}));
 
 				$start = rand(5, 68); // Random start in 4-byte header and 64 byte data
 				$datalen = strlen($_data) - $start - 256; // Last unchanged 256 bytes
 
-				for($j = $start; $j < $datalen; $j+=64)
+				for ($j = $start; $j < $datalen; $j += 64)
 				{
 					$ch = ord($_data{$j});
-					if($ch < 9 || $ch > 119)
+					if ($ch < 9 || $ch > 119)
 					{
 						continue;
 					}
@@ -308,14 +308,14 @@ 
 
 		function compareCaptcha()
 		{
-			if(!in_array(Context::get('act'), $this->target_acts)) return true;
+			if (!in_array(Context::get('act'), $this->target_acts)) return true;
 
-			if($_SESSION['member_captcha_authed'])
+			if ($_SESSION['member_captcha_authed'])
 			{
 				return true;
 			}
 
-			if(strtoupper($_SESSION['captcha_keyword']) == strtoupper(Context::get('secret_text')))
+			if (strtoupper($_SESSION['captcha_keyword']) == strtoupper(Context::get('secret_text')))
 			{
 				$_SESSION['member_captcha_authed'] = true;
 				return true;
@@ -328,14 +328,14 @@ 
 
 		function before_module_init_captchaCompare()
 		{
-			if(!$this->compareCaptcha())
+			if (!$this->compareCaptcha())
 			{
 				return false;
 			}
 
 			header("Content-Type: text/xml; charset=UTF-8");
 			header("Expires: Mon, 26 Jul 1997 05:00:00 GMT");
-			header("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
+			header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
 			header("Cache-Control: no-store, no-cache, must-revalidate");
 			header("Cache-Control: post-check=0, pre-check=0", false);
 			header("Pragma: no-cache");
@@ -350,7 +350,7 @@ 
 			unset($_SESSION['member_captcha_authed']);
 			$this->createKeyword();
 
-			$swfURL = getUrl() . 'addons/captcha_member/swf/play.swf';
+			$swfURL = getUrl().'addons/captcha_member/swf/play.swf';
 			Context::unloadFile('./addons/captcha_member/captcha.min.js');
 			Context::loadFile(array('./addons/captcha_member/inline_captcha.js', 'body'));
 
@@ -388,18 +388,18 @@ 
 
 $oAddonMemberCaptcha = &$GLOBALS['__AddonMemberCaptcha__'];
 
-if(method_exists($oAddonMemberCaptcha, $called_position))
+if (method_exists($oAddonMemberCaptcha, $called_position))
 {
-	if(!call_user_func_array(array(&$oAddonMemberCaptcha, $called_position), array(&$this)))
+	if (!call_user_func_array(array(&$oAddonMemberCaptcha, $called_position), array(&$this)))
 	{
 		return false;
 	}
 }
 
 $addon_act = Context::get('captcha_action');
-if($addon_act && method_exists($oAddonMemberCaptcha, $called_position . '_' . $addon_act))
+if ($addon_act && method_exists($oAddonMemberCaptcha, $called_position.'_'.$addon_act))
 {
-	if(!call_user_func_array(array(&$oAddonMemberCaptcha, $called_position . '_' . $addon_act), array(&$this)))
+	if (!call_user_func_array(array(&$oAddonMemberCaptcha, $called_position.'_'.$addon_act), array(&$this)))
 	{
 		return false;
 	}

addons/captcha/captcha.addon.php

Spacing +43 added lines, -43 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 
-if(!defined("__XE__")) exit();
+if (!defined("__XE__")) exit();
 
 /**
  * @file captcha.addon.php
@@ -9,7 +9,7 @@ 
  * @brief Captcha for a particular action
  * English alphabets and voice verification added
  * */
-if(!class_exists('AddonCaptcha', false))
+if (!class_exists('AddonCaptcha', false))
 {
 	class AddonCaptcha
 	{
@@ -24,7 +24,7 @@ 
 
 		function before_module_proc()
 		{
-			if($this->addon_info->act_type == 'everytime' && $_SESSION['captcha_authed'])
+			if ($this->addon_info->act_type == 'everytime' && $_SESSION['captcha_authed'])
 			{
 				unset($_SESSION['captcha_authed']);
 			}
@@ -33,19 +33,19 @@ 
 		function before_module_init(&$ModuleHandler)
 		{
 			$logged_info = Context::get('logged_info');
-			if($logged_info->is_admin == 'Y' || $logged_info->is_site_admin)
+			if ($logged_info->is_admin == 'Y' || $logged_info->is_site_admin)
 			{
 				return false;
 			}
-			if($this->addon_info->target != 'all' && Context::get('is_logged'))
+			if ($this->addon_info->target != 'all' && Context::get('is_logged'))
 			{
 				return false;
 			}
-			if($_SESSION['XE_VALIDATOR_ERROR'] == -1)
+			if ($_SESSION['XE_VALIDATOR_ERROR'] == -1)
 			{
 				$_SESSION['captcha_authed'] = false;
 			}
-			if($_SESSION['captcha_authed'])
+			if ($_SESSION['captcha_authed'])
 			{
 				return false;
 			}
@@ -54,13 +54,13 @@ 
 
 			$this->target_acts = array('procBoardInsertDocument', 'procBoardInsertComment', 'procIssuetrackerInsertIssue', 'procIssuetrackerInsertHistory', 'procTextyleInsertComment');
 
-			if(Context::getRequestMethod() != 'XMLRPC' && Context::getRequestMethod() !== 'JSON')
+			if (Context::getRequestMethod() != 'XMLRPC' && Context::getRequestMethod() !== 'JSON')
 			{
-				if($type == 'inline')
+				if ($type == 'inline')
 				{
-					if(!$this->compareCaptcha())
+					if (!$this->compareCaptcha())
 					{
-						Context::loadLang(_XE_PATH_ . 'addons/captcha/lang');
+						Context::loadLang(_XE_PATH_.'addons/captcha/lang');
 						$_SESSION['XE_VALIDATOR_ERROR'] = -1;
 						$_SESSION['XE_VALIDATOR_MESSAGE'] = Context::getLang('captcha_denied');
 						$_SESSION['XE_VALIDATOR_MESSAGE_TYPE'] = 'error';
@@ -72,16 +72,16 @@ 
 				{
 					Context::addHtmlHeader('<script>
 						if(!captchaTargetAct) {var captchaTargetAct = [];}
-						captchaTargetAct.push("' . implode('","', $this->target_acts) . '");
+						captchaTargetAct.push("' . implode('","', $this->target_acts).'");
 						</script>');
 					Context::loadFile(array('./addons/captcha/captcha.min.js', 'body', '', null), true);
 				}
 			}
 
 			// compare session when calling actions such as writing a post or a comment on the board/issue tracker module
-			if(!$_SESSION['captcha_authed'] && in_array(Context::get('act'), $this->target_acts))
+			if (!$_SESSION['captcha_authed'] && in_array(Context::get('act'), $this->target_acts))
 			{
-				Context::loadLang(_XE_PATH_ . 'addons/captcha/lang');
+				Context::loadLang(_XE_PATH_.'addons/captcha/lang');
 				$ModuleHandler->error = "captcha_denied";
 			}
 
@@ -91,7 +91,7 @@ 
 		function createKeyword()
 		{
 			$type = Context::get('captchaType');
-			if($type == 'inline' && $_SESSION['captcha_keyword'])
+			if ($type == 'inline' && $_SESSION['captcha_keyword'])
 			{
 				return;
 			}
@@ -104,19 +104,19 @@ 
 
 		function before_module_init_setCaptchaSession()
 		{
-			if($_SESSION['captcha_authed'])
+			if ($_SESSION['captcha_authed'])
 			{
 				return false;
 			}
 			// Load language files
-			Context::loadLang(_XE_PATH_ . 'addons/captcha/lang');
+			Context::loadLang(_XE_PATH_.'addons/captcha/lang');
 			// Generate keywords
 			$this->createKeyword();
 
 			$target = Context::getLang('target_captcha');
 			header("Content-Type: text/xml; charset=UTF-8");
 			header("Expires: Mon, 26 Jul 1997 05:00:00 GMT");
-			header("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
+			header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
 			header("Cache-Control: no-store, no-cache, must-revalidate");
 			header("Cache-Control: post-check=0, pre-check=0", false);
 			header("Pragma: no-cache");
@@ -133,11 +133,11 @@ 
 
 		function before_module_init_captchaImage()
 		{
-			if($_SESSION['captcha_authed'])
+			if ($_SESSION['captcha_authed'])
 			{
 				return false;
 			}
-			if(Context::get('renew'))
+			if (Context::get('renew'))
 			{
 				$this->createKeyword();
 			}
@@ -159,7 +159,7 @@ 
 		function createCaptchaImage($string)
 		{
 			$arr = array();
-			for($i = 0, $c = strlen($string); $i < $c; $i++)
+			for ($i = 0, $c = strlen($string); $i < $c; $i++)
 			{
 				$arr[] = $string{$i};
 			}
@@ -181,7 +181,7 @@ 
 			shuffle($deg);
 
 			// Create an image for each letter
-			foreach($arr as $i => $str)
+			foreach ($arr as $i => $str)
 			{
 				$im[$i + 1] = @imagecreate($w, $h);
 				$background_color = imagecolorallocate($im[$i + 1], 255, 255, 255);
@@ -191,7 +191,7 @@ 
 				$ran = range(1, 20);
 				shuffle($ran);
 
-				if(function_exists('imagerotate'))
+				if (function_exists('imagerotate'))
 				{
 					imagestring($im[$i + 1], (array_pop($ran) % 3) + 3, 2, (array_pop($ran) % 8), $str, $text_color);
 					$im[$i + 1] = imagerotate($im[$i + 1], array_pop($deg), 0);
@@ -206,7 +206,7 @@ 
 			}
 
 			// Combine images of each character
-			for($i = 1, $c = count($im); $i<$c; $i++)
+			for ($i = 1, $c = count($im); $i < $c; $i++)
 			{
 				imagecopy($im[0], $im[$i], (($w + 2) * ($i - 1)), 0, 0, 0, $w, $h);
 				imagedestroy($im[$i]);
@@ -218,7 +218,7 @@ 
 			imagecopyresized($big, $im[0], 0, 0, 0, 0, ($w + 2) * $big_count * $c, $h * $big_count, ($w + 2) * $c, $h);
 			imagedestroy($im[0]);
 
-			if(function_exists('imageantialias'))
+			if (function_exists('imageantialias'))
 			{
 				imageantialias($big, true);
 			}
@@ -230,7 +230,7 @@ 
 			$h = $h * $big_count;
 			$d = array_pop($deg);
 
-			for($i = -abs($d); $i < $h + abs($d); $i = $i + 7)
+			for ($i = -abs($d); $i < $h + abs($d); $i = $i + 7)
 			{
 				imageline($big, 0, $i + $d, $w, $i, $line_color);
 			}
@@ -238,7 +238,7 @@ 
 			$x = range(0, ($w - 10));
 			shuffle($x);
 
-			for($i = 0; $i < 200; $i++)
+			for ($i = 0; $i < 200; $i++)
 			{
 				imagesetpixel($big, $x[$i] % $w, $x[$i + 1] % $h, $line_color);
 			}
@@ -248,7 +248,7 @@ 
 
 		function before_module_init_captchaAudio()
 		{
-			if($_SESSION['captcha_authed'])
+			if ($_SESSION['captcha_authed'])
 			{
 				return false;
 			}
@@ -260,8 +260,8 @@ 
 			header("Content-Disposition: attachment; filename=\"captcha_audio.mp3\"");
 			header('Cache-Control: no-store, no-cache, must-revalidate');
 			header('Expires: Sun, 1 Jan 2000 12:00:00 GMT');
-			header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . 'GMT');
-			header('Content-Length: ' . strlen($data));
+			header('Last-Modified: '.gmdate('D, d M Y H:i:s').'GMT');
+			header('Content-Length: '.strlen($data));
 
 			echo $data;
 			Context::close();
@@ -272,17 +272,17 @@ 
 		{
 			$data = '';
 			$_audio = './addons/captcha/audio/F_%s.mp3';
-			for($i = 0, $c = strlen($string); $i < $c; $i++)
+			for ($i = 0, $c = strlen($string); $i < $c; $i++)
 			{
 				$_data = FileHandler::readFile(sprintf($_audio, $string{$i}));
 
 				$start = rand(5, 68); // Random start in 4-byte header and 64 byte data
 				$datalen = strlen($_data) - $start - 256; // Last unchanged 256 bytes
 
-				for($j = $start; $j < $datalen; $j+=64)
+				for ($j = $start; $j < $datalen; $j += 64)
 				{
 					$ch = ord($_data{$j});
-					if($ch < 9 || $ch > 119)
+					if ($ch < 9 || $ch > 119)
 					{
 						continue;
 					}
@@ -297,14 +297,14 @@ 
 
 		function compareCaptcha()
 		{
-			if(!in_array(Context::get('act'), $this->target_acts)) return true;
+			if (!in_array(Context::get('act'), $this->target_acts)) return true;
 
-			if($_SESSION['captcha_authed'])
+			if ($_SESSION['captcha_authed'])
 			{
 				return true;
 			}
 
-			if(strtoupper($_SESSION['captcha_keyword']) == strtoupper(Context::get('secret_text')))
+			if (strtoupper($_SESSION['captcha_keyword']) == strtoupper(Context::get('secret_text')))
 			{
 				$_SESSION['captcha_authed'] = true;
 				return true;
@@ -317,14 +317,14 @@ 
 
 		function before_module_init_captchaCompare()
 		{
-			if(!$this->compareCaptcha())
+			if (!$this->compareCaptcha())
 			{
 				return false;
 			}
 
 			header("Content-Type: text/xml; charset=UTF-8");
 			header("Expires: Mon, 26 Jul 1997 05:00:00 GMT");
-			header("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
+			header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
 			header("Cache-Control: no-store, no-cache, must-revalidate");
 			header("Cache-Control: post-check=0, pre-check=0", false);
 			header("Pragma: no-cache");
@@ -339,7 +339,7 @@ 
 			unset($_SESSION['captcha_authed']);
 			$this->createKeyword();
 
-			$swfURL = getUrl() . 'addons/captcha/swf/play.swf';
+			$swfURL = getUrl().'addons/captcha/swf/play.swf';
 			Context::unloadFile('./addons/captcha/captcha.min.js');
 			Context::loadFile(array('./addons/captcha/inline_captcha.js', 'body'));
 
@@ -377,18 +377,18 @@ 
 
 $oAddonCaptcha = &$GLOBALS['__AddonCaptcha__'];
 
-if(method_exists($oAddonCaptcha, $called_position))
+if (method_exists($oAddonCaptcha, $called_position))
 {
-	if(!call_user_func_array(array(&$oAddonCaptcha, $called_position), array(&$this)))
+	if (!call_user_func_array(array(&$oAddonCaptcha, $called_position), array(&$this)))
 	{
 		return false;
 	}
 }
 
 $addon_act = Context::get('captcha_action');
-if($addon_act && method_exists($oAddonCaptcha, $called_position . '_' . $addon_act))
+if ($addon_act && method_exists($oAddonCaptcha, $called_position.'_'.$addon_act))
 {
-	if(!call_user_func_array(array(&$oAddonCaptcha, $called_position . '_' . $addon_act), array(&$this)))
+	if (!call_user_func_array(array(&$oAddonCaptcha, $called_position.'_'.$addon_act), array(&$this)))
 	{
 		return false;
 	}

addons/autolink/autolink.addon.php

Spacing +2 added lines, -2 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 
-if(!defined('__XE__'))
+if (!defined('__XE__'))
 	exit();
 
 /**
@@ -9,7 +9,7 @@ 
  * @author NAVER (developers@xpressengine.com)
  * @brief Automatic link add-on
  */
-if($called_position == 'after_module_proc' && Context::getResponseMethod() == "HTML")
+if ($called_position == 'after_module_proc' && Context::getResponseMethod() == "HTML")
 {
 	Context::loadFile(array('./addons/autolink/autolink.js', 'body', '', null), true);
 }

widgets/mcontent/mcontent.class.php

Spacing +145 added lines, -145 removed lines

@@ -18,32 +18,32 @@ 
 	function proc($args)
 	{
 		// Targets to sort
-		if(!in_array($args->order_target, array('list_order','update_order'))) $args->order_target = 'list_order';
+		if (!in_array($args->order_target, array('list_order', 'update_order'))) $args->order_target = 'list_order';
 		// Sort order
-		if(!in_array($args->order_type, array('asc','desc'))) $args->order_type = 'asc';
+		if (!in_array($args->order_type, array('asc', 'desc'))) $args->order_type = 'asc';
 		// The number of displayed lists
-		$args->list_count = (int)$args->list_count;
-		if(!$args->list_count) $args->list_count = 5;
+		$args->list_count = (int) $args->list_count;
+		if (!$args->list_count) $args->list_count = 5;
 		// Cut the length of the title
-		if(!$args->subject_cut_size) $args->subject_cut_size = 0;
+		if (!$args->subject_cut_size) $args->subject_cut_size = 0;
 		// Cut the length of contents
-		if(!$args->content_cut_size) $args->content_cut_size = 100;
+		if (!$args->content_cut_size) $args->content_cut_size = 100;
 		// Viewing options
-		$args->option_view_arr = explode(',',$args->option_view);
+		$args->option_view_arr = explode(',', $args->option_view);
 		// markup options
-		if(!$args->markup_type) $args->markup_type = 'list';
+		if (!$args->markup_type) $args->markup_type = 'list';
 		// Set variables for internal use
 		$oModuleModel = getModel('module');
 		$module_srls = $args->modules_info = $args->module_srls_info = $args->mid_lists = array();
 		$site_module_info = Context::get('site_module_info');
 		// List URLs if a type is RSS
-		if($args->content_type == 'rss')
+		if ($args->content_type == 'rss')
 		{
 			$args->rss_urls = array();
-			$rss_urls = array_unique(array($args->rss_url0,$args->rss_url1,$args->rss_url2,$args->rss_url3,$args->rss_url4));
-			for($i=0,$c=count($rss_urls);$i<$c;$i++)
+			$rss_urls = array_unique(array($args->rss_url0, $args->rss_url1, $args->rss_url2, $args->rss_url3, $args->rss_url4));
+			for ($i = 0, $c = count($rss_urls); $i < $c; $i++)
 			{
-				if($rss_urls[$i]) $args->rss_urls[] = $rss_urls[$i];
+				if ($rss_urls[$i]) $args->rss_urls[] = $rss_urls[$i];
 			}
 			// Get module information after listing module_srls if the module is not RSS
 		}
@@ -51,13 +51,13 @@ 
 		{
 			$obj = new stdClass();
 			// Apply to all modules in the site if a target module is not specified
-			if(!$args->module_srls)
+			if (!$args->module_srls)
 			{
-				$obj->site_srl = (int)$site_module_info->site_srl;
+				$obj->site_srl = (int) $site_module_info->site_srl;
 				$output = executeQueryArray('widgets.content.getMids', $obj);
-				if($output->data)
+				if ($output->data)
 				{
-					foreach($output->data as $key => $val)
+					foreach ($output->data as $key => $val)
 					{
 						$args->modules_info[$val->mid] = $val;
 						$args->module_srls_info[$val->module_srl] = $val;
@@ -73,35 +73,35 @@ 
 			{
 				$obj->module_srls = $args->module_srls;
 				$output = executeQueryArray('widgets.content.getMids', $obj);
-				if($output->data)
+				if ($output->data)
 				{
-					foreach($output->data as $key => $val)
+					foreach ($output->data as $key => $val)
 					{
 						$args->modules_info[$val->mid] = $val;
 						$args->module_srls_info[$val->module_srl] = $val;
 						$module_srls[] = $val->module_srl;
 					}
-					$idx = explode(',',$args->module_srls);
-					for($i=0,$c=count($idx);$i<$c;$i++)
+					$idx = explode(',', $args->module_srls);
+					for ($i = 0, $c = count($idx); $i < $c; $i++)
 					{
 						$srl = $idx[$i];
-						if(!$args->module_srls_info[$srl]) continue;
+						if (!$args->module_srls_info[$srl]) continue;
 						$args->mid_lists[$srl] = $args->module_srls_info[$srl]->mid;
 					}
 				}
 			}
 			// Exit if no module is found
-			if(!count($args->modules_info)) return Context::get('msg_not_founded');
-			$args->module_srl = implode(',',$module_srls);
+			if (!count($args->modules_info)) return Context::get('msg_not_founded');
+			$args->module_srl = implode(',', $module_srls);
 		}
 
 		/**
 		 * Method is separately made because content extraction, articles, comments, trackbacks, RSS and other elements exist
 		 */
 		// tab mode
-		if($args->tab_type == 'none' || $args->tab_type == '')
+		if ($args->tab_type == 'none' || $args->tab_type == '')
 		{
-			switch($args->content_type)
+			switch ($args->content_type)
 			{
 				case 'comment':
 					$content_items = $this->_getCommentItems($args);
@@ -125,17 +125,17 @@ 
 		{
 			$content_items = array();
 
-			switch($args->content_type)
+			switch ($args->content_type)
 			{
 				case 'comment':
-					foreach($args->mid_lists as $module_srl => $mid)
+					foreach ($args->mid_lists as $module_srl => $mid)
 					{
 						$args->module_srl = $module_srl;
 						$content_items[$module_srl] = $this->_getCommentItems($args);
 					}
 					break;
 				case 'image':
-					foreach($args->mid_lists as $module_srl => $mid)
+					foreach ($args->mid_lists as $module_srl => $mid)
 					{
 						$args->module_srl = $module_srl;
 						$content_items[$module_srl] = $this->_getImageItems($args);
@@ -145,13 +145,13 @@ 
 					$content_items = $this->getRssItems($args);
 					break;
 				case 'trackback':
-					foreach($args->mid_lists as $module_srl => $mid){
+					foreach ($args->mid_lists as $module_srl => $mid) {
 						$args->module_srl = $module_srl;
 						$content_items[$module_srl] = $this->_getTrackbackItems($args);
 					}
 					break;
 				default:
-					foreach($args->mid_lists as $module_srl => $mid)
+					foreach ($args->mid_lists as $module_srl => $mid)
 					{
 						$args->module_srl = $module_srl;
 						$content_items[$module_srl] = $this->_getDocumentItems($args);
@@ -160,7 +160,7 @@ 
 			}
 		}
 
-		$output = $this->_compile($args,$content_items);
+		$output = $this->_compile($args, $content_items);
 		return $output;
 	}
 
@@ -180,14 +180,14 @@ 
 
 		$content_items = array();
 
-		if(!count($output)) return;
+		if (!count($output)) return;
 
-		foreach($output as $key => $oComment)
+		foreach ($output as $key => $oComment)
 		{
 			$attribute = $oComment->getObjectVars();
 			$title = $oComment->getSummary($args->content_cut_size);
 			$thumbnail = $oComment->getThumbnail();
-			$url = sprintf("%s#comment_%s",getUrl('', 'mid', $args->mid_lists[$attribute->module_srl], 'document_srl',$oComment->get('document_srl')),$oComment->get('comment_srl'));
+			$url = sprintf("%s#comment_%s", getUrl('', 'mid', $args->mid_lists[$attribute->module_srl], 'document_srl', $oComment->get('document_srl')), $oComment->get('comment_srl'));
 
 			$attribute->mid = $args->mid_lists[$attribute->module_srl];
 			$browser_title = $args->module_srls_info[$attribute->module_srl]->browser_title;
@@ -212,10 +212,10 @@ 
 		// Get categories
 		$obj = new stdClass();
 		$obj->module_srl = $args->module_srl;
-		$output = executeQueryArray('widgets.content.getCategories',$obj);
-		if($output->toBool() && $output->data)
+		$output = executeQueryArray('widgets.content.getCategories', $obj);
+		if ($output->toBool() && $output->data)
 		{
-			foreach($output->data as $key => $val)
+			foreach ($output->data as $key => $val)
 			{
 				$category_lists[$val->module_srl][$val->category_srl] = $val;
 			}
@@ -223,17 +223,17 @@ 
 		// Get a list of documents
 		$obj->module_srl = $args->module_srl;
 		$obj->sort_index = $args->order_target;
-		$obj->order_type = $args->order_type=="desc"?"asc":"desc";
+		$obj->order_type = $args->order_type == "desc" ? "asc" : "desc";
 		$obj->list_count = $args->list_count;
 		$obj->statusList = array('PUBLIC');
 		$output = executeQueryArray('widgets.content.getNewestDocuments', $obj);
-		if(!$output->toBool() || !$output->data) return;
+		if (!$output->toBool() || !$output->data) return;
 		// If the result exists, make each document as an object
 		$content_items = array();
 		$first_thumbnail_idx = -1;
-		if(count($output->data))
+		if (count($output->data))
 		{
-			foreach($output->data as $key => $attribute)
+			foreach ($output->data as $key => $attribute)
 			{
 				$oDocument = new documentItem();
 				$oDocument->setAttribute($attribute, false);
@@ -242,23 +242,23 @@ 
 			}
 			$oDocumentModel->setToAllDocumentExtraVars();
 
-			for($i=0,$c=count($document_srls);$i<$c;$i++)
+			for ($i = 0, $c = count($document_srls); $i < $c; $i++)
 			{
 				$oDocument = $GLOBALS['XE_DOCUMENT_LIST'][$document_srls[$i]];
 				$document_srl = $oDocument->document_srl;
 				$module_srl = $oDocument->get('module_srl');
 				$category_srl = $oDocument->get('category_srl');
 				$thumbnail = $oDocument->getThumbnail();
-				$content_item = new mcontentItem( $args->module_srls_info[$module_srl]->browser_title );
+				$content_item = new mcontentItem($args->module_srls_info[$module_srl]->browser_title);
 				$content_item->adds($oDocument->getObjectVars());
 				$content_item->setTitle($oDocument->getTitleText());
-				$content_item->setCategory( $category_lists[$module_srl][$category_srl]->title );
-				$content_item->setDomain( $args->module_srls_info[$module_srl]->domain );
+				$content_item->setCategory($category_lists[$module_srl][$category_srl]->title);
+				$content_item->setDomain($args->module_srls_info[$module_srl]->domain);
 				$content_item->setContent($oDocument->getSummary($args->content_cut_size));
-				$content_item->setLink( getSiteUrl($domain,'', 'mid',$args->mid_lists[$module_srl], 'document_srl',$document_srl) );
+				$content_item->setLink(getSiteUrl($domain, '', 'mid', $args->mid_lists[$module_srl], 'document_srl', $document_srl));
 				$content_item->setThumbnail($thumbnail);
 				$content_item->add('mid', $args->mid_lists[$module_srl]);
-				if($first_thumbnail_idx==-1 && $thumbnail) $first_thumbnail_idx = $i;
+				if ($first_thumbnail_idx == -1 && $thumbnail) $first_thumbnail_idx = $i;
 				$content_items[] = $content_item;
 			}
 
@@ -276,10 +276,10 @@ 
 		$obj->direct_download = 'Y';
 		$obj->isvalid = 'Y';
 		// Get categories
-		$output = executeQueryArray('widgets.content.getCategories',$obj);
-		if($output->toBool() && $output->data)
+		$output = executeQueryArray('widgets.content.getCategories', $obj);
+		if ($output->toBool() && $output->data)
 		{
-			foreach($output->data as $key => $val)
+			foreach ($output->data as $key => $val)
 			{
 				$category_lists[$val->module_srl][$val->category_srl] = $val;
 			}
@@ -288,24 +288,24 @@ 
 		$obj->list_count = $args->list_count;
 		$files_output = executeQueryArray("file.getOneFileInDocument", $obj);
 		$files_count = count($files_output->data);
-		if(!$files_count) return;
+		if (!$files_count) return;
 
 		$content_items = array();
 
-		for($i=0;$i<$files_count;$i++) $document_srl_list[] = $files_output->data[$i]->document_srl;
+		for ($i = 0; $i < $files_count; $i++) $document_srl_list[] = $files_output->data[$i]->document_srl;
 
 		$tmp_document_list = $oDocumentModel->getDocuments($document_srl_list);
 
-		if(!count($tmp_document_list)) return;
+		if (!count($tmp_document_list)) return;
 
-		foreach($tmp_document_list as $oDocument)
+		foreach ($tmp_document_list as $oDocument)
 		{
 			$attribute = $oDocument->getObjectVars();
 			$browser_title = $args->module_srls_info[$attribute->module_srl]->browser_title;
 			$domain = $args->module_srls_info[$attribute->module_srl]->domain;
 			$category = $category_lists[$attribute->module_srl]->text;
 			$content = $oDocument->getSummary($args->content_cut_size);
-			$url = sprintf("%s#%s",$oDocument->getPermanentUrl() ,$oDocument->getCommentCount());
+			$url = sprintf("%s#%s", $oDocument->getPermanentUrl(), $oDocument->getCommentCount());
 			$thumbnail = $oDocument->getThumbnail();
 			$content_item = new mcontentItem($browser_title);
 			$content_item->adds($attribute);
@@ -327,11 +327,11 @@ 
 		$content_items = array();
 		$args->mid_lists = array();
 
-		foreach($args->rss_urls as $key => $rss)
+		foreach ($args->rss_urls as $key => $rss)
 		{
 			$args->rss_url = $rss;
 			$content_item = $this->_getRssItems($args);
-			if(count($content_item) > 0)
+			if (count($content_item) > 0)
 			{
 				$browser_title = $content_item[0]->getBrowserTitle();
 				$args->mid_lists[] = $browser_title;
@@ -339,40 +339,40 @@ 
 			}
 		}
 
-		if($args->tab_type == 'none' || $args->tab_type == '')
+		if ($args->tab_type == 'none' || $args->tab_type == '')
 		{
 			$items = array();
-			foreach($content_items as $key => $val)
+			foreach ($content_items as $key => $val)
 			{
-				foreach($val as $k => $v)
+				foreach ($val as $k => $v)
 				{
 					$date = $v->get('regdate');
-					$i=0;
-					while(array_key_exists(sprintf('%s%02d',$date,$i), $items)) $i++;
-					$items[sprintf('%s%02d',$date,$i)] = $v;
+					$i = 0;
+					while (array_key_exists(sprintf('%s%02d', $date, $i), $items)) $i++;
+					$items[sprintf('%s%02d', $date, $i)] = $v;
 				}
 			}
-			if($args->order_type =='asc') ksort($items);
+			if ($args->order_type == 'asc') ksort($items);
 			else krsort($items);
-			$content_items = array_slice(array_values($items),0,$args->list_count);
+			$content_items = array_slice(array_values($items), 0, $args->list_count);
 		} return $content_items;
 	}
 
 	function _getRssBody($value)
 	{
-		if(!$value || is_string($value)) return $value;
-		if(is_object($value)) $value = get_object_vars($value);
+		if (!$value || is_string($value)) return $value;
+		if (is_object($value)) $value = get_object_vars($value);
 		$body = null;
-		if(!count($value)) return;
-		foreach($value as $key => $val)
+		if (!count($value)) return;
+		foreach ($value as $key => $val)
 		{
-			if($key == 'body')
+			if ($key == 'body')
 			{
 				$body = $val;
 				continue;
 			}
-			if(is_object($val)||is_array($val)) $body = $this->_getRssBody($val);
-			if($body !== null) return $body;
+			if (is_object($val) || is_array($val)) $body = $this->_getRssBody($val);
+			if ($body !== null) return $body;
 		}
 		return $body;
 	}
@@ -383,17 +383,17 @@ 
 		// Replace tags such as </p> , </div> , </li> and others to a whitespace
 		$content = str_replace(array('</p>', '</div>', '</li>'), ' ', $content);
 		// Remove Tag
-		$content = preg_replace('!<([^>]*?)>!is','', $content);
+		$content = preg_replace('!<([^>]*?)>!is', '', $content);
 		// Replace tags to < , > , " 
-		$content = str_replace(array('&lt;','&gt;','&quot;','&nbsp;'), array('<','>','"',' '), $content);
+		$content = str_replace(array('&lt;', '&gt;', '&quot;', '&nbsp;'), array('<', '>', '"', ' '), $content);
 		// Delete a series of whitespaces
 		$content = preg_replace('/ ( +)/is', ' ', $content);
 		// Truncate string
 		$content = trim(cut_str($content, $str_size, $tail));
 		// Replace back < , > , "  to theoriginal tags
-		$content = str_replace(array('<','>','"'),array('&lt;','&gt;','&quot;'), $content);
+		$content = str_replace(array('<', '>', '"'), array('&lt;', '&gt;', '&quot;'), $content);
 		// Fixed a newline bug on a set of consecutive English letters 
-		$content = preg_replace('/([a-z0-9\+:\/\.\~,\|\!\@\#\$\%\^\&\*\(\)\_]){20}/is',"$0-",$content);
+		$content = preg_replace('/([a-z0-9\+:\/\.\~,\|\!\@\#\$\%\^\&\*\(\)\_]){20}/is', "$0-", $content);
 		return $content; 
 	}
 
@@ -404,7 +404,7 @@ 
 	 */
 	function requestFeedContents($rss_url)
 	{
-		$rss_url = str_replace('&amp;','&',Context::convertEncodingStr($rss_url));
+		$rss_url = str_replace('&amp;', '&', Context::convertEncodingStr($rss_url));
 		return FileHandler::getRemoteResource($rss_url, null, 3, 'GET', 'application/xml');
 	}
 
@@ -416,52 +416,52 @@ 
 		$buff = $this->requestFeedContents($args->rss_url);
 
 		$encoding = preg_match("/<\?xml.*encoding=\"(.+)\".*\?>/i", $buff, $matches);
-		if($encoding && stripos($matches[1], "UTF-8") === FALSE) $buff = Context::convertEncodingStr($buff);
+		if ($encoding && stripos($matches[1], "UTF-8") === FALSE) $buff = Context::convertEncodingStr($buff);
 
 		$buff = preg_replace("/<\?xml.*\?>/i", "", $buff);
 
 		$oXmlParser = new XmlParser();
 		$xml_doc = $oXmlParser->parse($buff);
 		$rss = new stdClass();
-		if($xml_doc->rss)
+		if ($xml_doc->rss)
 		{
 			$rss->title = $xml_doc->rss->channel->title->body;
 			$rss->link = $xml_doc->rss->channel->link->body;
 
 			$items = $xml_doc->rss->channel->item;
 
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if (!$items) return;
+			if ($items && !is_array($items)) $items = array($items);
 
 			$content_items = array();
 
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if ($key >= $args->list_count) break;
 				unset($item);
 				$item = new stdClass();
 
-				foreach($value as $key2 => $value2)
+				foreach ($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if (is_array($value2)) $value2 = array_shift($value2);
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 
 				$content_item = new mcontentItem($rss->title);
 				$content_item->setContentsLink($rss->link);
 				$content_item->setTitle($item->title);
-				$content_item->setNickName(max($item->author,$item->{'dc:creator'}));
+				$content_item->setNickName(max($item->author, $item->{'dc:creator'}));
 				//$content_item->setCategory($item->category);
-				$item->description = preg_replace('!<a href=!is','<a target="_blank" rel="noopener" href=', $item->description);
+				$item->description = preg_replace('!<a href=!is', '<a target="_blank" rel="noopener" href=', $item->description);
 				$content_item->setContent($this->_getSummary($item->description, $args->content_cut_size));
 				$content_item->setLink($item->link);
-				$date = date('YmdHis', strtotime(max($item->pubdate,$item->pubDate,$item->{'dc:date'})));
+				$date = date('YmdHis', strtotime(max($item->pubdate, $item->pubDate, $item->{'dc:date'})));
 				$content_item->setRegdate($date);
 
 				$content_items[] = $content_item;
 			}
 		}
-		else if($xml_doc->{'rdf:rdf'})
+		else if ($xml_doc->{'rdf:rdf'})
 		{
 			// rss1.0 supported (XE's XML is case-insensitive because XML parser converts all to small letters) Fixed by misol
 			$rss->title = $xml_doc->{'rdf:rdf'}->channel->title->body;
@@ -469,102 +469,102 @@ 
 
 			$items = $xml_doc->{'rdf:rdf'}->item;
 
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if (!$items) return;
+			if ($items && !is_array($items)) $items = array($items);
 
 			$content_items = array();
 
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if ($key >= $args->list_count) break;
 				unset($item);
 				$item = new stdClass();
 
-				foreach($value as $key2 => $value2)
+				foreach ($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if (is_array($value2)) $value2 = array_shift($value2);
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 
 				$content_item = new mcontentItem($rss->title);
 				$content_item->setContentsLink($rss->link);
 				$content_item->setTitle($item->title);
-				$content_item->setNickName(max($item->author,$item->{'dc:creator'}));
+				$content_item->setNickName(max($item->author, $item->{'dc:creator'}));
 				//$content_item->setCategory($item->category);
-				$item->description = preg_replace('!<a href=!is','<a target="_blank" rel="noopener" href=', $item->description);
+				$item->description = preg_replace('!<a href=!is', '<a target="_blank" rel="noopener" href=', $item->description);
 				$content_item->setContent($this->_getSummary($item->description, $args->content_cut_size));
 				$content_item->setLink($item->link);
-				$date = date('YmdHis', strtotime(max($item->pubdate,$item->pubDate,$item->{'dc:date'})));
+				$date = date('YmdHis', strtotime(max($item->pubdate, $item->pubDate, $item->{'dc:date'})));
 				$content_item->setRegdate($date);
 
 				$content_items[] = $content_item;
 			}
 		}
-		else if($xml_doc->feed && $xml_doc->feed->attrs->xmlns == 'http://www.w3.org/2005/Atom') 
+		else if ($xml_doc->feed && $xml_doc->feed->attrs->xmlns == 'http://www.w3.org/2005/Atom') 
 			{
 			// Atom 1.0 spec supported by misol
 			$rss->title = $xml_doc->feed->title->body;
 			$links = $xml_doc->feed->link;
-			if(is_array($links))
+			if (is_array($links))
 			{
 				foreach ($links as $value)
 				{
-					if($value->attrs->rel == 'alternate')
+					if ($value->attrs->rel == 'alternate')
 					{
 						$rss->link = $value->attrs->href;
 						break;
 					}
 				}
 			}
-			else if($links->attrs->rel == 'alternate') $rss->link = $links->attrs->href;
+			else if ($links->attrs->rel == 'alternate') $rss->link = $links->attrs->href;
 	
 			$items = $xml_doc->feed->entry;
 	
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if (!$items) return;
+			if ($items && !is_array($items)) $items = array($items);
 	
 			$content_items = array();
 	
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if ($key >= $args->list_count) break;
 				unset($item);
 	
-				foreach($value as $key2 => $value2)
+				foreach ($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if (is_array($value2)) $value2 = array_shift($value2);
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 	
 				$content_item = new mcontentItem($rss->title);
 				$links = $value->link;
-				if(is_array($links))
+				if (is_array($links))
 				{
 					foreach ($links as $val)
 					{
-						if($val->attrs->rel == 'alternate')
+						if ($val->attrs->rel == 'alternate')
 						{
 							$item->link = $val->attrs->href;
 							break;
 						}
 					}
 				}
-				else if($links->attrs->rel == 'alternate') $item->link = $links->attrs->href;
+				else if ($links->attrs->rel == 'alternate') $item->link = $links->attrs->href;
 	
 				$content_item->setContentsLink($rss->link);
-				if($item->title)
+				if ($item->title)
 				{
-					if(stripos($value->title->attrs->type, "html") === FALSE) $item->title = $value->title->body;
+					if (stripos($value->title->attrs->type, "html") === FALSE) $item->title = $value->title->body;
 				}
 				$content_item->setTitle($item->title);
-				$content_item->setNickName(max($item->author,$item->{'dc:creator'}));
+				$content_item->setNickName(max($item->author, $item->{'dc:creator'}));
 				$content_item->setAuthorSite($value->author->uri->body);
 	
 				//$content_item->setCategory($item->category);
 				$item->description = ($item->content) ? $item->content : $item->description = $item->summary;
-				$item->description = preg_replace('!<a href=!is','<a target="_blank" rel="noopener" href=', $item->description);
+				$item->description = preg_replace('!<a href=!is', '<a target="_blank" rel="noopener" href=', $item->description);
 	
-				if(($item->content && stripos($value->content->attrs->type, "html") === FALSE) || (!$item->content && stripos($value->summary->attrs->type, "html") === FALSE))
+				if (($item->content && stripos($value->content->attrs->type, "html") === FALSE) || (!$item->content && stripos($value->summary->attrs->type, "html") === FALSE))
 				{
 					$item->description = htmlspecialchars($item->description, ENT_COMPAT | ENT_HTML401, 'UTF-8', false);
 	
@@ -572,7 +572,7 @@ 
 	
 				$content_item->setContent($this->_getSummary($item->description, $args->content_cut_size));
 				$content_item->setLink($item->link);
-				$date = date('YmdHis', strtotime(max($item->published,$item->updated,$item->{'dc:date'})));
+				$date = date('YmdHis', strtotime(max($item->published, $item->updated, $item->{'dc:date'})));
 				$content_item->setRegdate($date);
 	
 				$content_items[] = $content_item;
@@ -581,12 +581,12 @@ 
 		return $content_items;
 	}
 
-	function _getTrackbackItems($args){
+	function _getTrackbackItems($args) {
 		// Get categories
-		$output = executeQueryArray('widgets.content.getCategories',$obj);
-		if($output->toBool() && $output->data)
+		$output = executeQueryArray('widgets.content.getCategories', $obj);
+		if ($output->toBool() && $output->data)
 		{
-			foreach($output->data as $key => $val) {
+			foreach ($output->data as $key => $val) {
 				$category_lists[$val->module_srl][$val->category_srl] = $val;
 			}
 		}
@@ -598,14 +598,14 @@ 
 		$oTrackbackModel = getModel('trackback');
 		$output = $oTrackbackModel->getNewestTrackbackList($obj);
 		// If an error occurs, just ignore it.
-		if(!$output->toBool() || !$output->data) return;
+		if (!$output->toBool() || !$output->data) return;
 		// If the result exists, make each document as an object
 		$content_items = array();
-		foreach($output->data as $key => $item)
+		foreach ($output->data as $key => $item)
 		{
 			$domain = $args->module_srls_info[$item->module_srl]->domain;
 			$category = $category_lists[$item->module_srl]->text;
-			$url = getSiteUrl($domain,'','mid', $args->mid_lists[$item->module_srl],'document_srl',$item->document_srl);
+			$url = getSiteUrl($domain, '', 'mid', $args->mid_lists[$item->module_srl], 'document_srl', $item->document_srl);
 			$browser_title = $args->module_srls_info[$item->module_srl]->browser_title;
 
 			$content_item = new mcontentItem($browser_title);
@@ -613,8 +613,8 @@ 
 			$content_item->setTitle($item->title);
 			$content_item->setCategory($category);
 			$content_item->setNickName($item->blog_name);
-			$content_item->setContent($item->excerpt);  ///<<
-			$content_item->setDomain($domain);  ///<<
+			$content_item->setContent($item->excerpt); ///<<
+			$content_item->setDomain($domain); ///<<
 			$content_item->setLink($url);
 			$content_item->add('mid', $args->mid_lists[$item->module_srl]);
 			$content_item->setRegdate($item->regdate);
@@ -623,7 +623,7 @@ 
 		return $content_items;
 	}
 
-	function _compile($args,$content_items)
+	function _compile($args, $content_items)
 	{
 		$oTemplate = &TemplateHandler::getInstance();
 		// Set variables for widget
@@ -671,7 +671,7 @@ 
 	var $contents_link = null;
 	var $domain = null;
 
-	function mcontentItem($browser_title='')
+	function mcontentItem($browser_title = '')
 	{
 		$this->browser_title = $browser_title;
 	}
@@ -681,58 +681,58 @@ 
 	}
 	function setFirstThumbnailIdx($first_thumbnail_idx)
 	{
-		if(is_null($this->first_thumbnail) && $first_thumbnail_idx>-1) {
+		if (is_null($this->first_thumbnail) && $first_thumbnail_idx > -1) {
 			$this->has_first_thumbnail_idx = true;
-			$this->first_thumbnail_idx= $first_thumbnail_idx;
+			$this->first_thumbnail_idx = $first_thumbnail_idx;
 		}
 	}
 	function setExtraImages($extra_images)
 	{
-		$this->add('extra_images',$extra_images);
+		$this->add('extra_images', $extra_images);
 	}
 	function setDomain($domain)
 	{
 		static $default_domain = null;
-		if(!$domain)
+		if (!$domain)
 		{
-			if(is_null($default_domain)) $default_domain = Context::getDefaultUrl();
+			if (is_null($default_domain)) $default_domain = Context::getDefaultUrl();
 			$domain = $default_domain;
 		}
 		$this->domain = $domain;
 	}
 	function setLink($url)
 	{
-		$this->add('url',$url);
+		$this->add('url', $url);
 	}
 	function setTitle($title)
 	{
-		$this->add('title',$title);
+		$this->add('title', $title);
 	}
 
 	function setThumbnail($thumbnail)
 	{
-		$this->add('thumbnail',$thumbnail);
+		$this->add('thumbnail', $thumbnail);
 	}
 	function setContent($content)
 	{
-		$this->add('content',$content);
+		$this->add('content', $content);
 	}
 	function setRegdate($regdate)
 	{
-		$this->add('regdate',$regdate);
+		$this->add('regdate', $regdate);
 	}
 	function setNickName($nick_name)
 	{
-		$this->add('nick_name',$nick_name);
+		$this->add('nick_name', $nick_name);
 	}
 	// Save author's homepage url by misol
 	function setAuthorSite($site_url)
 	{
-		$this->add('author_site',$site_url);
+		$this->add('author_site', $site_url);
 	}
 	function setCategory($category)
 	{
-		$this->add('category',$category);
+		$this->add('category', $category);
 	}
 	function getBrowserTitle()
 	{
@@ -760,17 +760,17 @@ 
 	{
 		return $this->get('module_srl');
 	}
-	function getTitle($cut_size = 0, $tail='...')
+	function getTitle($cut_size = 0, $tail = '...')
 	{
 		$title = strip_tags($this->get('title'));
 
-		if($cut_size) $title = cut_str($title, $cut_size, $tail);
+		if ($cut_size) $title = cut_str($title, $cut_size, $tail);
 
 		$attrs = array();
-		if($this->get('title_bold') == 'Y') $attrs[] = 'font-weight:bold';
-		if($this->get('title_color') && $this->get('title_color') != 'N') $attrs[] = 'color:#'.$this->get('title_color');
+		if ($this->get('title_bold') == 'Y') $attrs[] = 'font-weight:bold';
+		if ($this->get('title_color') && $this->get('title_color') != 'N') $attrs[] = 'color:#'.$this->get('title_color');
 
-		if(count($attrs)) $title = sprintf("<span style=\"%s\">%s</span>", implode(';', $attrs), htmlspecialchars($title));
+		if (count($attrs)) $title = sprintf("<span style=\"%s\">%s</span>", implode(';', $attrs), htmlspecialchars($title));
 
 		return $title;
 	}
@@ -793,12 +793,12 @@ 
 	function getCommentCount()
 	{
 		$comment_count = $this->get('comment_count');
-		return $comment_count>0 ? $comment_count : '';
+		return $comment_count > 0 ? $comment_count : '';
 	}
 	function getTrackbackCount()
 	{
 		$trackback_count = $this->get('trackback_count');
-		return $trackback_count>0 ? $trackback_count : '';
+		return $trackback_count > 0 ? $trackback_count : '';
 	}
 	function getRegdate($format = 'Y.m.d H:i:s')
 	{

Braces +137 added lines, -55 removed lines

@@ -18,20 +18,32 @@ 
 	function proc($args)
 	{
 		// Targets to sort
-		if(!in_array($args->order_target, array('list_order','update_order'))) $args->order_target = 'list_order';
+		if(!in_array($args->order_target, array('list_order','update_order'))) {
+			$args->order_target = 'list_order';
+		}
 		// Sort order
-		if(!in_array($args->order_type, array('asc','desc'))) $args->order_type = 'asc';
+		if(!in_array($args->order_type, array('asc','desc'))) {
+			$args->order_type = 'asc';
+		}
 		// The number of displayed lists
 		$args->list_count = (int)$args->list_count;
-		if(!$args->list_count) $args->list_count = 5;
+		if(!$args->list_count) {
+			$args->list_count = 5;
+		}
 		// Cut the length of the title
-		if(!$args->subject_cut_size) $args->subject_cut_size = 0;
+		if(!$args->subject_cut_size) {
+			$args->subject_cut_size = 0;
+		}
 		// Cut the length of contents
-		if(!$args->content_cut_size) $args->content_cut_size = 100;
+		if(!$args->content_cut_size) {
+			$args->content_cut_size = 100;
+		}
 		// Viewing options
 		$args->option_view_arr = explode(',',$args->option_view);
 		// markup options
-		if(!$args->markup_type) $args->markup_type = 'list';
+		if(!$args->markup_type) {
+			$args->markup_type = 'list';
+		}
 		// Set variables for internal use
 		$oModuleModel = getModel('module');
 		$module_srls = $args->modules_info = $args->module_srls_info = $args->mid_lists = array();
@@ -43,11 +55,12 @@ 
 			$rss_urls = array_unique(array($args->rss_url0,$args->rss_url1,$args->rss_url2,$args->rss_url3,$args->rss_url4));
 			for($i=0,$c=count($rss_urls);$i<$c;$i++)
 			{
-				if($rss_urls[$i]) $args->rss_urls[] = $rss_urls[$i];
+				if($rss_urls[$i]) {
+					$args->rss_urls[] = $rss_urls[$i];
+				}
 			}
 			// Get module information after listing module_srls if the module is not RSS
-		}
-		else
+		} else
 		{
 			$obj = new stdClass();
 			// Apply to all modules in the site if a target module is not specified
@@ -68,8 +81,7 @@ 
 
 				$args->modules_info = $oModuleModel->getMidList($obj);
 				// Apply to the module only if a target module is specified
-			}
-			else
+			} else
 			{
 				$obj->module_srls = $args->module_srls;
 				$output = executeQueryArray('widgets.content.getMids', $obj);
@@ -85,13 +97,17 @@ 
 					for($i=0,$c=count($idx);$i<$c;$i++)
 					{
 						$srl = $idx[$i];
-						if(!$args->module_srls_info[$srl]) continue;
+						if(!$args->module_srls_info[$srl]) {
+							continue;
+						}
 						$args->mid_lists[$srl] = $args->module_srls_info[$srl]->mid;
 					}
 				}
 			}
 			// Exit if no module is found
-			if(!count($args->modules_info)) return Context::get('msg_not_founded');
+			if(!count($args->modules_info)) {
+				return Context::get('msg_not_founded');
+			}
 			$args->module_srl = implode(',',$module_srls);
 		}
 
@@ -120,8 +136,7 @@ 
 					break;
 			}
 			// If not a tab type
-		}
-		else
+		} else
 		{
 			$content_items = array();
 
@@ -180,7 +195,9 @@ 
 
 		$content_items = array();
 
-		if(!count($output)) return;
+		if(!count($output)) {
+			return;
+		}
 
 		foreach($output as $key => $oComment)
 		{
@@ -227,7 +244,9 @@ 
 		$obj->list_count = $args->list_count;
 		$obj->statusList = array('PUBLIC');
 		$output = executeQueryArray('widgets.content.getNewestDocuments', $obj);
-		if(!$output->toBool() || !$output->data) return;
+		if(!$output->toBool() || !$output->data) {
+			return;
+		}
 		// If the result exists, make each document as an object
 		$content_items = array();
 		$first_thumbnail_idx = -1;
@@ -258,7 +277,9 @@ 
 				$content_item->setLink( getSiteUrl($domain,'', 'mid',$args->mid_lists[$module_srl], 'document_srl',$document_srl) );
 				$content_item->setThumbnail($thumbnail);
 				$content_item->add('mid', $args->mid_lists[$module_srl]);
-				if($first_thumbnail_idx==-1 && $thumbnail) $first_thumbnail_idx = $i;
+				if($first_thumbnail_idx==-1 && $thumbnail) {
+					$first_thumbnail_idx = $i;
+				}
 				$content_items[] = $content_item;
 			}
 
@@ -288,15 +309,21 @@ 
 		$obj->list_count = $args->list_count;
 		$files_output = executeQueryArray("file.getOneFileInDocument", $obj);
 		$files_count = count($files_output->data);
-		if(!$files_count) return;
+		if(!$files_count) {
+			return;
+		}
 
 		$content_items = array();
 
-		for($i=0;$i<$files_count;$i++) $document_srl_list[] = $files_output->data[$i]->document_srl;
+		for($i=0;$i<$files_count;$i++) {
+			$document_srl_list[] = $files_output->data[$i]->document_srl;
+		}
 
 		$tmp_document_list = $oDocumentModel->getDocuments($document_srl_list);
 
-		if(!count($tmp_document_list)) return;
+		if(!count($tmp_document_list)) {
+			return;
+		}
 
 		foreach($tmp_document_list as $oDocument)
 		{
@@ -348,22 +375,33 @@ 
 				{
 					$date = $v->get('regdate');
 					$i=0;
-					while(array_key_exists(sprintf('%s%02d',$date,$i), $items)) $i++;
+					while(array_key_exists(sprintf('%s%02d',$date,$i), $items)) {
+						$i++;
+					}
 					$items[sprintf('%s%02d',$date,$i)] = $v;
 				}
 			}
-			if($args->order_type =='asc') ksort($items);
-			else krsort($items);
+			if($args->order_type =='asc') {
+				ksort($items);
+			} else {
+				krsort($items);
+			}
 			$content_items = array_slice(array_values($items),0,$args->list_count);
 		} return $content_items;
 	}
 
 	function _getRssBody($value)
 	{
-		if(!$value || is_string($value)) return $value;
-		if(is_object($value)) $value = get_object_vars($value);
+		if(!$value || is_string($value)) {
+			return $value;
+		}
+		if(is_object($value)) {
+			$value = get_object_vars($value);
+		}
 		$body = null;
-		if(!count($value)) return;
+		if(!count($value)) {
+			return;
+		}
 		foreach($value as $key => $val)
 		{
 			if($key == 'body')
@@ -371,8 +409,12 @@ 
 				$body = $val;
 				continue;
 			}
-			if(is_object($val)||is_array($val)) $body = $this->_getRssBody($val);
-			if($body !== null) return $body;
+			if(is_object($val)||is_array($val)) {
+				$body = $this->_getRssBody($val);
+			}
+			if($body !== null) {
+				return $body;
+			}
 		}
 		return $body;
 	}
@@ -416,7 +458,9 @@ 
 		$buff = $this->requestFeedContents($args->rss_url);
 
 		$encoding = preg_match("/<\?xml.*encoding=\"(.+)\".*\?>/i", $buff, $matches);
-		if($encoding && stripos($matches[1], "UTF-8") === FALSE) $buff = Context::convertEncodingStr($buff);
+		if($encoding && stripos($matches[1], "UTF-8") === FALSE) {
+			$buff = Context::convertEncodingStr($buff);
+		}
 
 		$buff = preg_replace("/<\?xml.*\?>/i", "", $buff);
 
@@ -430,20 +474,28 @@ 
 
 			$items = $xml_doc->rss->channel->item;
 
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if(!$items) {
+				return;
+			}
+			if($items && !is_array($items)) {
+				$items = array($items);
+			}
 
 			$content_items = array();
 
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if($key >= $args->list_count) {
+					break;
+				}
 				unset($item);
 				$item = new stdClass();
 
 				foreach($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if(is_array($value2)) {
+						$value2 = array_shift($value2);
+					}
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 
@@ -460,8 +512,7 @@ 
 
 				$content_items[] = $content_item;
 			}
-		}
-		else if($xml_doc->{'rdf:rdf'})
+		} else if($xml_doc->{'rdf:rdf'})
 		{
 			// rss1.0 supported (XE's XML is case-insensitive because XML parser converts all to small letters) Fixed by misol
 			$rss->title = $xml_doc->{'rdf:rdf'}->channel->title->body;
@@ -469,20 +520,28 @@ 
 
 			$items = $xml_doc->{'rdf:rdf'}->item;
 
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if(!$items) {
+				return;
+			}
+			if($items && !is_array($items)) {
+				$items = array($items);
+			}
 
 			$content_items = array();
 
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if($key >= $args->list_count) {
+					break;
+				}
 				unset($item);
 				$item = new stdClass();
 
 				foreach($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if(is_array($value2)) {
+						$value2 = array_shift($value2);
+					}
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 
@@ -499,8 +558,7 @@ 
 
 				$content_items[] = $content_item;
 			}
-		}
-		else if($xml_doc->feed && $xml_doc->feed->attrs->xmlns == 'http://www.w3.org/2005/Atom') 
+		} else if($xml_doc->feed && $xml_doc->feed->attrs->xmlns == 'http://www.w3.org/2005/Atom') 
 			{
 			// Atom 1.0 spec supported by misol
 			$rss->title = $xml_doc->feed->title->body;
@@ -515,24 +573,33 @@ 
 						break;
 					}
 				}
+			} else if($links->attrs->rel == 'alternate') {
+				$rss->link = $links->attrs->href;
 			}
-			else if($links->attrs->rel == 'alternate') $rss->link = $links->attrs->href;
 	
 			$items = $xml_doc->feed->entry;
 	
-			if(!$items) return;
-			if($items && !is_array($items)) $items = array($items);
+			if(!$items) {
+				return;
+			}
+			if($items && !is_array($items)) {
+				$items = array($items);
+			}
 	
 			$content_items = array();
 	
 			foreach ($items as $key => $value)
 			{
-				if($key >= $args->list_count) break;
+				if($key >= $args->list_count) {
+					break;
+				}
 				unset($item);
 	
 				foreach($value as $key2 => $value2)
 				{
-					if(is_array($value2)) $value2 = array_shift($value2);
+					if(is_array($value2)) {
+						$value2 = array_shift($value2);
+					}
 					$item->{$key2} = $this->_getRssBody($value2);
 				}
 	
@@ -548,13 +615,16 @@ 
 							break;
 						}
 					}
+				} else if($links->attrs->rel == 'alternate') {
+					$item->link = $links->attrs->href;
 				}
-				else if($links->attrs->rel == 'alternate') $item->link = $links->attrs->href;
 	
 				$content_item->setContentsLink($rss->link);
 				if($item->title)
 				{
-					if(stripos($value->title->attrs->type, "html") === FALSE) $item->title = $value->title->body;
+					if(stripos($value->title->attrs->type, "html") === FALSE) {
+						$item->title = $value->title->body;
+					}
 				}
 				$content_item->setTitle($item->title);
 				$content_item->setNickName(max($item->author,$item->{'dc:creator'}));
@@ -598,7 +668,9 @@ 
 		$oTrackbackModel = getModel('trackback');
 		$output = $oTrackbackModel->getNewestTrackbackList($obj);
 		// If an error occurs, just ignore it.
-		if(!$output->toBool() || !$output->data) return;
+		if(!$output->toBool() || !$output->data) {
+			return;
+		}
 		// If the result exists, make each document as an object
 		$content_items = array();
 		foreach($output->data as $key => $item)
@@ -695,7 +767,9 @@ 
 		static $default_domain = null;
 		if(!$domain)
 		{
-			if(is_null($default_domain)) $default_domain = Context::getDefaultUrl();
+			if(is_null($default_domain)) {
+				$default_domain = Context::getDefaultUrl();
+			}
 			$domain = $default_domain;
 		}
 		$this->domain = $domain;
@@ -764,13 +838,21 @@ 
 	{
 		$title = strip_tags($this->get('title'));
 
-		if($cut_size) $title = cut_str($title, $cut_size, $tail);
+		if($cut_size) {
+			$title = cut_str($title, $cut_size, $tail);
+		}
 
 		$attrs = array();
-		if($this->get('title_bold') == 'Y') $attrs[] = 'font-weight:bold';
-		if($this->get('title_color') && $this->get('title_color') != 'N') $attrs[] = 'color:#'.$this->get('title_color');
+		if($this->get('title_bold') == 'Y') {
+			$attrs[] = 'font-weight:bold';
+		}
+		if($this->get('title_color') && $this->get('title_color') != 'N') {
+			$attrs[] = 'color:#'.$this->get('title_color');
+		}
 
-		if(count($attrs)) $title = sprintf("<span style=\"%s\">%s</span>", implode(';', $attrs), htmlspecialchars($title));
+		if(count($attrs)) {
+			$title = sprintf("<span style=\"%s\">%s</span>", implode(';', $attrs), htmlspecialchars($title));
+		}
 
 		return $title;
 	}

classes/db/DB.class.php

Doc Comments +8 added lines, -8 removed lines

@@ -490,7 +490,7 @@ 
 
 	/**
 	 * Returns object of error info
-	 * @return object object of error
+	 * @return BaseObject object of error
 	 */
 	function getError()
 	{
@@ -667,7 +667,7 @@ 
 	 * Returns counter cache data
 	 * @param array|string $tables tables to get data
 	 * @param string $condition condition to get data
-	 * @return int count of cache data
+	 * @return boolean count of cache data
 	 */
 	function getCountCache($tables, $condition)
 	{
@@ -727,7 +727,7 @@ 
 	 * @param array|string $tables tables to save data
 	 * @param string $condition condition to save data
 	 * @param int $count count of cache data to save
-	 * @return void
+	 * @return boolean
 	 */
 	function putCountCache($tables, $condition, $count = 0)
 	{
@@ -809,7 +809,7 @@ 
 
 	/**
 	 * Return select query string
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @return string
 	 */
@@ -903,7 +903,7 @@ 
 
 	/**
 	 * Return delete query string
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @param boolean $with_priority
 	 * @return string
@@ -935,7 +935,7 @@ 
 
 	/**
 	 * Return update query string
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @param boolean $with_priority
 	 * @return string
@@ -967,7 +967,7 @@ 
 
 	/**
 	 * Return insert query string
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @param boolean $with_priority
 	 * @return string
@@ -1238,7 +1238,7 @@ 
 	 * DB Connect
 	 * this method is protected
 	 * @param array $connection
-	 * @return void
+	 * @return resource
 	 */
 	function __connect($connection)
 	{

Spacing +110 added lines, -110 removed lines

@@ -141,24 +141,24 @@ 
 	 */
 	function getInstance($db_type = NULL)
 	{
-		if(!$db_type)
+		if (!$db_type)
 		{
 			$db_type = Context::getDBType();
 		}
-		if(!$db_type && Context::isInstalled())
+		if (!$db_type && Context::isInstalled())
 		{
 			return new BaseObject(-1, 'msg_db_not_setted');
 		}
 
-		if(!isset($GLOBALS['__DB__']))
+		if (!isset($GLOBALS['__DB__']))
 		{
 			$GLOBALS['__DB__'] = array();
 		}
-		if(!isset($GLOBALS['__DB__'][$db_type]))
+		if (!isset($GLOBALS['__DB__'][$db_type]))
 		{
-			$class_name = 'DB' . ucfirst($db_type);
-			$class_file = _XE_PATH_ . "classes/db/$class_name.class.php";
-			if(!file_exists($class_file))
+			$class_name = 'DB'.ucfirst($db_type);
+			$class_file = _XE_PATH_."classes/db/$class_name.class.php";
+			if (!file_exists($class_file))
 			{
 				return new BaseObject(-1, 'msg_db_not_setted');
 			}
@@ -187,8 +187,8 @@ 
 	 */
 	function DB()
 	{
-		$this->count_cache_path = _XE_PATH_ . $this->count_cache_path;
-		$this->cache_file = _XE_PATH_ . $this->cache_file;
+		$this->count_cache_path = _XE_PATH_.$this->count_cache_path;
+		$this->cache_file = _XE_PATH_.$this->cache_file;
 	}
 
 	/**
@@ -210,18 +210,18 @@ 
 	 */
 	public static function getEnableList()
 	{
-		if(!self::$supported_list)
+		if (!self::$supported_list)
 		{
 			$oDB = new DB();
 			self::$supported_list = $oDB->_getSupportedList();
 		}
 
 		$enableList = array();
-		if(is_array(self::$supported_list))
+		if (is_array(self::$supported_list))
 		{
-			foreach(self::$supported_list AS $key => $value)
+			foreach (self::$supported_list AS $key => $value)
 			{
-				if($value->enable)
+				if ($value->enable)
 				{
 					$enableList[] = $value;
 				}
@@ -237,18 +237,18 @@ 
 	 */
 	public static function getDisableList()
 	{
-		if(!self::$supported_list)
+		if (!self::$supported_list)
 		{
 			$oDB = new DB();
 			self::$supported_list = $oDB->_getSupportedList();
 		}
 
 		$disableList = array();
-		if(is_array(self::$supported_list))
+		if (is_array(self::$supported_list))
 		{
-			foreach(self::$supported_list AS $key => $value)
+			foreach (self::$supported_list AS $key => $value)
 			{
-				if(!$value->enable)
+				if (!$value->enable)
 				{
 					$disableList[] = $value;
 				}
@@ -265,24 +265,24 @@ 
 	function _getSupportedList()
 	{
 		static $get_supported_list = '';
-		if(is_array($get_supported_list))
+		if (is_array($get_supported_list))
 		{
 			self::$supported_list = $get_supported_list;
 			return self::$supported_list;
 		}
 		$get_supported_list = array();
-		$db_classes_path = _XE_PATH_ . "classes/db/";
+		$db_classes_path = _XE_PATH_."classes/db/";
 		$filter = "/^DB([^\.]+)\.class\.php/i";
 		$supported_list = FileHandler::readDir($db_classes_path, $filter, TRUE);
 
 		// after creating instance of class, check is supported
-		for($i = 0; $i < count($supported_list); $i++)
+		for ($i = 0; $i < count($supported_list); $i++)
 		{
 			$db_type = $supported_list[$i];
 
 			$class_name = sprintf("DB%s%s", strtoupper(substr($db_type, 0, 1)), strtolower(substr($db_type, 1)));
-			$class_file = sprintf(_XE_PATH_ . "classes/db/%s.class.php", $class_name);
-			if(!file_exists($class_file))
+			$class_file = sprintf(_XE_PATH_."classes/db/%s.class.php", $class_name);
+			if (!file_exists($class_file))
 			{
 				continue;
 			}
@@ -291,7 +291,7 @@ 
 			require_once($class_file);
 			$oDB = new $class_name(FALSE);
 
-			if(!$oDB)
+			if (!$oDB)
 			{
 				continue;
 			}
@@ -315,7 +315,7 @@ 
 	 */
 	function _sortDBMS($a, $b)
 	{
-		if(!isset($this->priority_dbms[$a->db_type]))
+		if (!isset($this->priority_dbms[$a->db_type]))
 		{
 			$priority_a = 0;
 		}
@@ -324,7 +324,7 @@ 
 			$priority_a = $this->priority_dbms[$a->db_type];
 		}
 
-		if(!isset($this->priority_dbms[$b->db_type]))
+		if (!isset($this->priority_dbms[$b->db_type]))
 		{
 			$priority_b = 0;
 		}
@@ -333,7 +333,7 @@ 
 			$priority_b = $this->priority_dbms[$b->db_type];
 		}
 
-		if($priority_a == $priority_b)
+		if ($priority_a == $priority_b)
 		{
 			return 0;
 		}
@@ -359,7 +359,7 @@ 
 	 */
 	function isConnected($type = 'master', $indx = 0)
 	{
-		if($type == 'master')
+		if ($type == 'master')
 		{
 			return $this->master_db["is_connected"] ? TRUE : FALSE;
 		}
@@ -388,7 +388,7 @@ 
 	 */
 	function actFinish()
 	{
-		if(!$this->query)
+		if (!$this->query)
 		{
 			return;
 		}
@@ -409,14 +409,14 @@ 
 
 		$bt = version_compare(PHP_VERSION, '5.3.6', '>=') ? debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS) : debug_backtrace();
 
-		foreach($bt as $no => $call)
+		foreach ($bt as $no => $call)
 		{
-			if($call['function'] == 'executeQuery' || $call['function'] == 'executeQueryArray')
+			if ($call['function'] == 'executeQuery' || $call['function'] == 'executeQueryArray')
 			{
 				$call_no = $no;
 				$call_no++;
 				$log['called_file'] = $bt[$call_no]['file'].':'.$bt[$call_no]['line'];
-				$log['called_file'] = str_replace(_XE_PATH_ , '', $log['called_file']);
+				$log['called_file'] = str_replace(_XE_PATH_, '', $log['called_file']);
 				$call_no++;
 				$log['called_method'] = $bt[$call_no]['class'].$bt[$call_no]['type'].$bt[$call_no]['function'];
 				break;
@@ -424,22 +424,22 @@ 
 		}
 
 		// leave error log if an error occured (if __DEBUG_DB_OUTPUT__ is defined)
-		if($this->isError())
+		if ($this->isError())
 		{
 			$log['result'] = 'Failed';
 			$log['errno'] = $this->errno;
 			$log['errstr'] = $this->errstr;
 
-			if(__DEBUG_DB_OUTPUT__ == 1)
+			if (__DEBUG_DB_OUTPUT__ == 1)
 			{
-				$debug_file = _XE_PATH_ . "files/_debug_db_query.php";
+				$debug_file = _XE_PATH_."files/_debug_db_query.php";
 				$buff = array();
-				if(!file_exists($debug_file))
+				if (!file_exists($debug_file))
 				{
-					$buff[] = '<?php exit(); ?' . '>';
+					$buff[] = '<?php exit(); ?'.'>';
 				}
 				$buff[] = print_r($log, TRUE);
-				@file_put_contents($log_file, implode("\n", $buff) . "\n\n", FILE_APPEND|LOCK_EX);
+				@file_put_contents($log_file, implode("\n", $buff)."\n\n", FILE_APPEND | LOCK_EX);
 			}
 		}
 		else
@@ -452,7 +452,7 @@ 
 		$log_args = new stdClass;
 		$log_args->query = $this->query;
 		$log_args->query_id = $this->query_id;
-		$log_args->caller = $log['called_method'] . '() in ' . $log['called_file'];
+		$log_args->caller = $log['called_method'].'() in '.$log['called_file'];
 		$log_args->connection = $log['connection'];
 		writeSlowlog('query', $elapsed_time, $log_args);
 	}
@@ -510,11 +510,11 @@ 
 	{
 		static $cache_file = array();
 
-		if(!$query_id)
+		if (!$query_id)
 		{
 			return new BaseObject(-1, 'msg_invalid_queryid');
 		}
-		if(!$this->db_type)
+		if (!$this->db_type)
 		{
 			return;
 		}
@@ -523,20 +523,20 @@ 
 
 		$this->query_id = $query_id;
 
-		if(!isset($cache_file[$query_id]) || !file_exists($cache_file[$query_id]))
+		if (!isset($cache_file[$query_id]) || !file_exists($cache_file[$query_id]))
 		{
 			$id_args = explode('.', $query_id);
-			if(count($id_args) == 2)
+			if (count($id_args) == 2)
 			{
 				$target = 'modules';
 				$module = $id_args[0];
 				$id = $id_args[1];
 			}
-			elseif(count($id_args) == 3)
+			elseif (count($id_args) == 3)
 			{
 				$target = $id_args[0];
 				$typeList = array('addons' => 1, 'widgets' => 1);
-				if(!isset($typeList[$target]))
+				if (!isset($typeList[$target]))
 				{
 					$this->actDBClassFinish();
 					return;
@@ -544,14 +544,14 @@ 
 				$module = $id_args[1];
 				$id = $id_args[2];
 			}
-			if(!$target || !$module || !$id)
+			if (!$target || !$module || !$id)
 			{
 				$this->actDBClassFinish();
 				return new BaseObject(-1, 'msg_invalid_queryid');
 			}
 
 			$xml_file = sprintf('%s%s/%s/queries/%s.xml', _XE_PATH_, $target, $module, $id);
-			if(!file_exists($xml_file))
+			if (!file_exists($xml_file))
 			{
 				$this->actDBClassFinish();
 				return new BaseObject(-1, 'msg_invalid_queryid');
@@ -579,13 +579,13 @@ 
 		$cache_file = sprintf('%s%s%s.%s.%s.cache.php', _XE_PATH_, $this->cache_file, $query_id, __ZBXE_VERSION__, $this->db_type);
 
 		$cache_time = -1;
-		if(file_exists($cache_file))
+		if (file_exists($cache_file))
 		{
 			$cache_time = filemtime($cache_file);
 		}
 
 		// if there is no cache file or is not new, find original xml query file and parse it
-		if($cache_time < filemtime($xml_file) || $cache_time < filemtime(_XE_PATH_ . 'classes/db/DB.class.php') || $cache_time < filemtime(_XE_PATH_ . 'classes/xml/XmlQueryParser.class.php'))
+		if ($cache_time < filemtime($xml_file) || $cache_time < filemtime(_XE_PATH_.'classes/db/DB.class.php') || $cache_time < filemtime(_XE_PATH_.'classes/xml/XmlQueryParser.class.php'))
 		{
 			$oParser = new XmlQueryParser();
 			$oParser->parse($query_id, $xml_file, $cache_file);
@@ -606,27 +606,27 @@ 
 	{
 		global $lang;
 		
-		if(!in_array($type, array('master','slave'))) $type = 'slave';
+		if (!in_array($type, array('master', 'slave'))) $type = 'slave';
 
-		if(!file_exists($cache_file))
+		if (!file_exists($cache_file))
 		{
 			return new BaseObject(-1, 'msg_invalid_queryid');
 		}
 
-		if($source_args)
+		if ($source_args)
 		{
 			$args = clone $source_args;
 		}
 
 		$output = include($cache_file);
 
-		if((is_a($output, 'BaseObject') || is_subclass_of($output, 'BaseObject')) && !$output->toBool())
+		if ((is_a($output, 'BaseObject') || is_subclass_of($output, 'BaseObject')) && !$output->toBool())
 		{
 			return $output;
 		}
 
 		// execute appropriate query
-		switch($output->getAction())
+		switch ($output->getAction())
 		{
 			case 'insert' :
 			case 'insert-select' :
@@ -649,11 +649,11 @@ 
 				break;
 		}
 
-		if($this->isError())
+		if ($this->isError())
 		{
 			$output = $this->getError();
 		}
-		else if(!is_a($output, 'BaseObject') && !is_subclass_of($output, 'BaseObject'))
+		else if (!is_a($output, 'BaseObject') && !is_subclass_of($output, 'BaseObject'))
 		{
 			$output = new BaseObject();
 		}
@@ -799,7 +799,7 @@ 
 	 */
 	function dropTable($table_name)
 	{
-		if(!$table_name)
+		if (!$table_name)
 		{
 			return;
 		}
@@ -816,59 +816,59 @@ 
 	function getSelectSql($query, $with_values = TRUE)
 	{
 		$select = $query->getSelectString($with_values);
-		if($select == '')
+		if ($select == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$select = 'SELECT ' . $select;
+		$select = 'SELECT '.$select;
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$from = ' FROM ' . $from;
+		$from = ' FROM '.$from;
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$tableObjects = $query->getTables();
 		$index_hint_list = '';
-		foreach($tableObjects as $tableObject)
+		foreach ($tableObjects as $tableObject)
 		{
-			if(is_a($tableObject, 'CubridTableWithHint'))
+			if (is_a($tableObject, 'CubridTableWithHint'))
 			{
-				$index_hint_list .= $tableObject->getIndexHintString() . ', ';
+				$index_hint_list .= $tableObject->getIndexHintString().', ';
 			}
 		}
 		$index_hint_list = substr($index_hint_list, 0, -2);
-		if($index_hint_list != '')
+		if ($index_hint_list != '')
 		{
-			$index_hint_list = 'USING INDEX ' . $index_hint_list;
+			$index_hint_list = 'USING INDEX '.$index_hint_list;
 		}
 
 		$groupBy = $query->getGroupByString();
-		if($groupBy != '')
+		if ($groupBy != '')
 		{
-			$groupBy = ' GROUP BY ' . $groupBy;
+			$groupBy = ' GROUP BY '.$groupBy;
 		}
 
 		$orderBy = $query->getOrderByString();
-		if($orderBy != '')
+		if ($orderBy != '')
 		{
-			$orderBy = ' ORDER BY ' . $orderBy;
+			$orderBy = ' ORDER BY '.$orderBy;
 		}
 
 		$limit = $query->getLimitString();
-		if($limit != '')
+		if ($limit != '')
 		{
-			$limit = ' LIMIT ' . $limit;
+			$limit = ' LIMIT '.$limit;
 		}
 
-		return $select . ' ' . $from . ' ' . $where . ' ' . $index_hint_list . ' ' . $groupBy . ' ' . $orderBy . ' ' . $limit;
+		return $select.' '.$from.' '.$where.' '.$index_hint_list.' '.$groupBy.' '.$orderBy.' '.$limit;
 	}
 
 	/**
@@ -886,7 +886,7 @@ 
 	{
 		$new_update_columns = array();
 		$click_count_columns = $queryObject->getClickCountColumns();
-		foreach($click_count_columns as $click_count_column)
+		foreach ($click_count_columns as $click_count_column)
 		{
 			$click_count_column_name = $click_count_column->column_name;
 
@@ -918,16 +918,16 @@ 
 		$sql .= $tables[0]->getAlias();
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$sql .= ' FROM ' . $from;
+		$sql .= ' FROM '.$from;
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$sql .= ' WHERE ' . $where;
+			$sql .= ' WHERE '.$where;
 		}
 
 		return $sql;
@@ -943,26 +943,26 @@ 
 	function getUpdateSql($query, $with_values = TRUE, $with_priority = FALSE)
 	{
 		$columnsList = $query->getUpdateString($with_values);
-		if($columnsList == '')
+		if ($columnsList == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
 
 		$tables = $query->getFromString($with_values);
-		if($tables == '')
+		if ($tables == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$priority = $with_priority ? $query->getPriority() : '';
 
-		return "UPDATE $priority $tables SET $columnsList " . $where;
+		return "UPDATE $priority $tables SET $columnsList ".$where;
 	}
 
 	/**
@@ -1000,27 +1000,27 @@ 
 	 */
 	function _getConnection($type = 'master', $indx = NULL)
 	{
-		if($type == 'master')
+		if ($type == 'master')
 		{
-			if(!$this->master_db['is_connected'])
+			if (!$this->master_db['is_connected'])
 			{
 				$this->_connect($type);
 			}
-			$this->connection = 'Master ' . $this->master_db['db_hostname'];
+			$this->connection = 'Master '.$this->master_db['db_hostname'];
 			return $this->master_db["resource"];
 		}
 
-		if($indx === NULL)
+		if ($indx === NULL)
 		{
 			$indx = $this->_getSlaveConnectionStringIndex($type);
 		}
 
-		if(!$this->slave_db[$indx]['is_connected'])
+		if (!$this->slave_db[$indx]['is_connected'])
 		{
 			$this->_connect($type, $indx);
 		}
 
-		$this->connection = 'Slave ' . $this->slave_db[$indx]['db_hostname'];
+		$this->connection = 'Slave '.$this->slave_db[$indx]['db_hostname'];
 		return $this->slave_db[$indx]["resource"];
 	}
 
@@ -1030,11 +1030,11 @@ 
 	 */
 	function _dbInfoExists()
 	{
-		if(!$this->master_db)
+		if (!$this->master_db)
 		{
 			return FALSE;
 		}
-		if(count($this->slave_db) === 0)
+		if (count($this->slave_db) === 0)
 		{
 			return FALSE;
 		}
@@ -1060,12 +1060,12 @@ 
 	 */
 	function close($type = 'master', $indx = 0)
 	{
-		if(!$this->isConnected($type, $indx))
+		if (!$this->isConnected($type, $indx))
 		{
 			return;
 		}
 
-		if($type == 'master')
+		if ($type == 'master')
 		{
 			$connection = &$this->master_db;
 		}
@@ -1096,12 +1096,12 @@ 
 	 */
 	function begin()
 	{
-		if(!$this->isConnected())
+		if (!$this->isConnected())
 		{
 			return;
 		}
 
-		if($this->_begin($this->transactionNestedLevel))
+		if ($this->_begin($this->transactionNestedLevel))
 		{
 			$this->transaction_started = TRUE;
 			$this->transactionNestedLevel++;
@@ -1124,15 +1124,15 @@ 
 	 */
 	function rollback()
 	{
-		if(!$this->isConnected() || !$this->transaction_started)
+		if (!$this->isConnected() || !$this->transaction_started)
 		{
 			return;
 		}
-		if($this->_rollback($this->transactionNestedLevel))
+		if ($this->_rollback($this->transactionNestedLevel))
 		{
 			$this->transactionNestedLevel--;
 
-			if(!$this->transactionNestedLevel)
+			if (!$this->transactionNestedLevel)
 			{
 				$this->transaction_started = FALSE;
 			}
@@ -1156,11 +1156,11 @@ 
 	 */
 	function commit($force = FALSE)
 	{
-		if(!$force && (!$this->isConnected() || !$this->transaction_started))
+		if (!$force && (!$this->isConnected() || !$this->transaction_started))
 		{
 			return;
 		}
-		if($this->transactionNestedLevel == 1 && $this->_commit())
+		if ($this->transactionNestedLevel == 1 && $this->_commit())
 		{
 			$this->transaction_started = FALSE;
 			$this->transactionNestedLevel = 0;
@@ -1192,7 +1192,7 @@ 
 	 */
 	function _query($query, $connection = NULL)
 	{
-		if($connection == NULL)
+		if ($connection == NULL)
 		{
 			$connection = $this->_getConnection('master');
 		}
@@ -1217,7 +1217,7 @@ 
 	{
 		$db_info = Context::getDBInfo();
 		$this->master_db = $db_info->master_db;
-		if($db_info->master_db["db_hostname"] == $db_info->slave_db[0]["db_hostname"]
+		if ($db_info->master_db["db_hostname"] == $db_info->slave_db[0]["db_hostname"]
 				&& $db_info->master_db["db_port"] == $db_info->slave_db[0]["db_port"]
 				&& $db_info->master_db["db_userid"] == $db_info->slave_db[0]["db_userid"]
 				&& $db_info->master_db["db_password"] == $db_info->slave_db[0]["db_password"]
@@ -1265,18 +1265,18 @@ 
 	 */
 	function _connect($type = 'master', $indx = 0)
 	{
-		if($this->isConnected($type, $indx))
+		if ($this->isConnected($type, $indx))
 		{
 			return;
 		}
 
 		// Ignore if no DB information exists
-		if(!$this->_dbInfoExists())
+		if (!$this->_dbInfoExists())
 		{
 			return;
 		}
 
-		if($type == 'master')
+		if ($type == 'master')
 		{
 			$connection = &$this->master_db;
 		}
@@ -1286,7 +1286,7 @@ 
 		}
 
 		$result = $this->__connect($connection);
-		if($result === NULL || $result === FALSE)
+		if ($result === NULL || $result === FALSE)
 		{
 			$connection["is_connected"] = FALSE;
 			return;
@@ -1297,7 +1297,7 @@ 
 		$connection["is_connected"] = TRUE;
 
 		// Save connection info for db logs
-		$this->connection = ucfirst($type) . ' ' . $connection["db_hostname"];
+		$this->connection = ucfirst($type).' '.$connection["db_hostname"];
 
 		// regist $this->close callback
 		register_shutdown_function(array($this, "close"));
@@ -1322,7 +1322,7 @@ 
 	 */
 	function actDBClassFinish()
 	{
-		if(!$this->query)
+		if (!$this->query)
 		{
 			return;
 		}
@@ -1345,7 +1345,7 @@ 
 	function getParser($force = FALSE)
 	{
 		static $dbParser = NULL;
-		if(!$dbParser || $force)
+		if (!$dbParser || $force)
 		{
 			$oDB = DB::getInstance();
 			$dbParser = $oDB->getParser();

Braces +13 added lines, -21 removed lines

@@ -318,8 +318,7 @@ 
 		if(!isset($this->priority_dbms[$a->db_type]))
 		{
 			$priority_a = 0;
-		}
-		else
+		} else
 		{
 			$priority_a = $this->priority_dbms[$a->db_type];
 		}
@@ -327,8 +326,7 @@ 
 		if(!isset($this->priority_dbms[$b->db_type]))
 		{
 			$priority_b = 0;
-		}
-		else
+		} else
 		{
 			$priority_b = $this->priority_dbms[$b->db_type];
 		}
@@ -362,8 +360,7 @@ 
 		if($type == 'master')
 		{
 			return $this->master_db["is_connected"] ? TRUE : FALSE;
-		}
-		else
+		} else
 		{
 			return $this->slave_db[$indx]["is_connected"] ? TRUE : FALSE;
 		}
@@ -441,8 +438,7 @@ 
 				$buff[] = print_r($log, TRUE);
 				@file_put_contents($log_file, implode("\n", $buff) . "\n\n", FILE_APPEND|LOCK_EX);
 			}
-		}
-		else
+		} else
 		{
 			$log['result'] = 'Success';
 		}
@@ -531,8 +527,7 @@ 
 				$target = 'modules';
 				$module = $id_args[0];
 				$id = $id_args[1];
-			}
-			elseif(count($id_args) == 3)
+			} elseif(count($id_args) == 3)
 			{
 				$target = $id_args[0];
 				$typeList = array('addons' => 1, 'widgets' => 1);
@@ -606,7 +601,9 @@ 
 	{
 		global $lang;
 		
-		if(!in_array($type, array('master','slave'))) $type = 'slave';
+		if(!in_array($type, array('master','slave'))) {
+			$type = 'slave';
+		}
 
 		if(!file_exists($cache_file))
 		{
@@ -652,8 +649,7 @@ 
 		if($this->isError())
 		{
 			$output = $this->getError();
-		}
-		else if(!is_a($output, 'BaseObject') && !is_subclass_of($output, 'BaseObject'))
+		} else if(!is_a($output, 'BaseObject') && !is_subclass_of($output, 'BaseObject'))
 		{
 			$output = new BaseObject();
 		}
@@ -1068,8 +1064,7 @@ 
 		if($type == 'master')
 		{
 			$connection = &$this->master_db;
-		}
-		else
+		} else
 		{
 			$connection = &$this->slave_db[$indx];
 		}
@@ -1164,8 +1159,7 @@ 
 		{
 			$this->transaction_started = FALSE;
 			$this->transactionNestedLevel = 0;
-		}
-		else
+		} else
 		{
 			$this->transactionNestedLevel--;
 		}
@@ -1225,8 +1219,7 @@ 
 		)
 		{
 			$this->slave_db[0] = &$this->master_db;
-		}
-		else
+		} else
 		{
 			$this->slave_db = $db_info->slave_db;
 		}
@@ -1279,8 +1272,7 @@ 
 		if($type == 'master')
 		{
 			$connection = &$this->master_db;
-		}
-		else
+		} else
 		{
 			$connection = &$this->slave_db[$indx];
 		}

classes/db/DBCubrid.class.php

Doc Comments +5 added lines, -5 removed lines

@@ -477,7 +477,7 @@ 
 	 * @param int $size column size
 	 * @param string|int $default default value
 	 * @param boolean $notnull not null status, default value is false
-	 * @return void
+	 * @return resource|null
 	 */
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = FALSE)
 	{
@@ -693,7 +693,7 @@ 
 	/**
 	 * Creates a table by using xml contents
 	 * @param string $xml_doc xml schema contents
-	 * @return void|object
+	 * @return null|resource
 	 */
 	function createTableByXml($xml_doc)
 	{
@@ -703,7 +703,7 @@ 
 	/**
 	 * Creates a table by using xml file path
 	 * @param string $file_name xml schema file path
-	 * @return void|object
+	 * @return null|resource
 	 */
 	function createTableByXmlFile($file_name)
 	{
@@ -723,7 +723,7 @@ 
 	 * opt : notnull, default, size\n
 	 * index : primary key, index, unique\n
 	 * @param string $xml_doc xml schema contents
-	 * @return void|object
+	 * @return null|resource
 	 */
 	function _createTable($xml_doc)
 	{
@@ -1125,7 +1125,7 @@ 
 
 	/**
 	 * If select query execute, return paging sql
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @param int $start_count
 	 * @param int $list_count

Spacing +141 added lines, -141 removed lines

@@ -52,7 +52,7 @@ 
 	function DBCubrid($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if ($auto_connect) $this->_connect();
 	}
 
 	/**
@@ -76,21 +76,21 @@ 
 		$result = @cubrid_connect($connection["db_hostname"], $connection["db_port"], $connection["db_database"], $connection["db_userid"], $connection["db_password"]);
 
 		// check connections
-		if(!$result)
+		if (!$result)
 		{
 			$this->setError(-1, 'database connect fail');
 			return;
 		}
 
-		if(!defined('__CUBRID_VERSION__'))
+		if (!defined('__CUBRID_VERSION__'))
 		{
 			$cubrid_version = cubrid_get_server_info($result);
 			$cubrid_version_elem = explode('.', $cubrid_version);
-			$cubrid_version = $cubrid_version_elem[0] . '.' . $cubrid_version_elem[1] . '.' . $cubrid_version_elem[2];
+			$cubrid_version = $cubrid_version_elem[0].'.'.$cubrid_version_elem[1].'.'.$cubrid_version_elem[2];
 			define('__CUBRID_VERSION__', $cubrid_version);
 		}
 
-		if(__CUBRID_VERSION__ >= '8.4.0')
+		if (__CUBRID_VERSION__ >= '8.4.0')
 			cubrid_set_autocommit($result, CUBRID_AUTOCOMMIT_TRUE);
 
 		return $result;
@@ -116,13 +116,13 @@ 
 	 */
 	function addQuotes($string)
 	{
-		if(version_compare(PHP_VERSION, "5.4.0", "<") &&
+		if (version_compare(PHP_VERSION, "5.4.0", "<") &&
 				get_magic_quotes_gpc())
 		{
 			$string = stripslashes(str_replace("\\", "\\\\", $string));
 		}
 
-		if(!is_numeric($string))
+		if (!is_numeric($string))
 		{
 			/*
 			  if ($this->isConnected()) {
@@ -146,17 +146,17 @@ 
 	 */
 	function _begin($transactionLevel = 0)
 	{
-		if(__CUBRID_VERSION__ >= '8.4.0')
+		if (__CUBRID_VERSION__ >= '8.4.0')
 		{
 			$connection = $this->_getConnection('master');
 
-			if(!$transactionLevel)
+			if (!$transactionLevel)
 			{
 				cubrid_set_autocommit($connection, CUBRID_AUTOCOMMIT_FALSE);
 			}
 			else
 			{
-				$this->_query("SAVEPOINT SP" . $transactionLevel, $connection);
+				$this->_query("SAVEPOINT SP".$transactionLevel, $connection);
 			}
 		}
 		return TRUE;
@@ -173,9 +173,9 @@ 
 
 		$point = $transactionLevel - 1;
 
-		if($point)
+		if ($point)
 		{
-			$this->_query("ROLLBACK TO SP" . $point, $connection);
+			$this->_query("ROLLBACK TO SP".$point, $connection);
 		}
 		else
 		{
@@ -206,29 +206,29 @@ 
 	 */
 	function __query($query, $connection)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$req = @cubrid_prepare($connection, $query);
-			if(!$req)
+			if (!$req)
 			{
 				$this->_setError();
 				return false;
 			}
 
 			$position = 0;
-			if($this->param)
+			if ($this->param)
 			{
-				foreach($this->param as $param)
+				foreach ($this->param as $param)
 				{
 					$value = $param->getUnescapedValue();
 					$type = $param->getType();
 
-					if($param->isColumnName())
+					if ($param->isColumnName())
 					{
 						continue;
 					}
 
-					switch($type)
+					switch ($type)
 					{
 						case 'number' :
 							$bind_type = 'numeric';
@@ -240,12 +240,12 @@ 
 							$bind_type = 'string';
 					}
 
-					if(is_array($value))
+					if (is_array($value))
 					{
-						foreach($value as $v)
+						foreach ($value as $v)
 						{
 							$bound = @cubrid_bind($req, ++$position, $v, $bind_type);
-							if(!$bound)
+							if (!$bound)
 							{
 								$this->_setError();
 								return false;
@@ -255,7 +255,7 @@ 
 					else
 					{
 						$bound = @cubrid_bind($req, ++$position, $value, $bind_type);
-						if(!$bound)
+						if (!$bound)
 						{
 							$this->_setError();
 							return false;
@@ -265,7 +265,7 @@ 
 			}
 
 			$result = @cubrid_execute($req);
-			if(!$result)
+			if (!$result)
 			{
 				$this->_setError();
 				return false;
@@ -275,7 +275,7 @@ 
 		// Execute the query
 		$result = @cubrid_execute($connection, $query);
 		// error check
-		if(!$result)
+		if (!$result)
 		{
 			$this->_setError();
 			return false;
@@ -306,12 +306,12 @@ 
 	function _fetch($result, $arrayIndexEndValue = NULL)
 	{
 		$output = array();
-		if(!$this->isConnected() || $this->isError() || !$result)
+		if (!$this->isConnected() || $this->isError() || !$result)
 		{
 			return array();
 		}
 
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 
 		}
@@ -322,25 +322,25 @@ 
 		$col_names = cubrid_column_names($result);
 		$max = count($col_types);
 
-		for($count = 0; $count < $max; $count++)
+		for ($count = 0; $count < $max; $count++)
 		{
-			if(preg_match("/^char/", $col_types[$count]) > 0)
+			if (preg_match("/^char/", $col_types[$count]) > 0)
 			{
 				$char_type_fields[] = $col_names[$count];
 			}
 		}
 
-		while($tmp = cubrid_fetch($result, CUBRID_OBJECT))
+		while ($tmp = cubrid_fetch($result, CUBRID_OBJECT))
 		{
-			if(is_array($char_type_fields))
+			if (is_array($char_type_fields))
 			{
-				foreach($char_type_fields as $val)
+				foreach ($char_type_fields as $val)
 				{
 					$tmp->{$val} = rtrim($tmp->{$val});
 				}
 			}
 
-			if($arrayIndexEndValue)
+			if ($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $tmp;
 			}
@@ -352,15 +352,15 @@ 
 
 		unset($char_type_fields);
 
-		if($result)
+		if ($result)
 		{
 			cubrid_close_request($result);
 		}
 
-		if(count($output) == 1)
+		if (count($output) == 1)
 		{
 			// If call is made for pagination, always return array
-			if(isset($arrayIndexEndValue))
+			if (isset($arrayIndexEndValue))
 			{
 				return $output;
 			}
@@ -395,7 +395,7 @@ 
 	 */
 	function _makeSequence()
 	{
-		if($_GLOBALS['XE_EXISTS_SEQUENCE'])
+		if ($_GLOBALS['XE_EXISTS_SEQUENCE'])
 			return;
 
 		// check cubrid serial
@@ -404,21 +404,21 @@ 
 		$output = $this->_fetch($result);
 
 		// if do not create serial
-		if($output->count == 0)
-		{
-			$query = sprintf('select max("a"."srl") as "srl" from ' .
-					'( select max("document_srl") as "srl" from ' .
-					'"%sdocuments" UNION ' .
-					'select max("comment_srl") as "srl" from ' .
-					'"%scomments" UNION ' .
-					'select max("member_srl") as "srl" from ' .
-					'"%smember"' .
+		if ($output->count == 0)
+		{
+			$query = sprintf('select max("a"."srl") as "srl" from '.
+					'( select max("document_srl") as "srl" from '.
+					'"%sdocuments" UNION '.
+					'select max("comment_srl") as "srl" from '.
+					'"%scomments" UNION '.
+					'select max("member_srl") as "srl" from '.
+					'"%smember"'.
 					') as "a"', $this->prefix, $this->prefix, $this->prefix);
 
 			$result = $this->_query($query);
 			$output = $this->_fetch($result);
 			$srl = $output->srl;
-			if($srl < 1)
+			if ($srl < 1)
 			{
 				$start = 1;
 			}
@@ -442,7 +442,7 @@ 
 	 */
 	function isTableExists($target_name)
 	{
-		if($target_name == 'sequence')
+		if ($target_name == 'sequence')
 		{
 			$query = sprintf("select \"name\" from \"db_serial\" where \"name\" = '%s%s'", $this->prefix, $target_name);
 		}
@@ -452,7 +452,7 @@ 
 		}
 
 		$result = $this->_query($query);
-		if(cubrid_num_rows($result) > 0)
+		if (cubrid_num_rows($result) > 0)
 		{
 			$output = TRUE;
 		}
@@ -461,7 +461,7 @@ 
 			$output = FALSE;
 		}
 
-		if($result)
+		if ($result)
 		{
 			cubrid_close_request($result);
 		}
@@ -482,22 +482,22 @@ 
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = FALSE)
 	{
 		$type = strtoupper($this->column_type[$type]);
-		if($type == 'INTEGER')
+		if ($type == 'INTEGER')
 		{
 			$size = '';
 		}
 
 		$query = sprintf("alter class \"%s%s\" add \"%s\" ", $this->prefix, $table_name, $column_name);
 
-		if($type == 'char' || $type == 'varchar')
+		if ($type == 'char' || $type == 'varchar')
 		{
-			if($size)
+			if ($size)
 			{
 				$size = $size * 3;
 			}
 		}
 
-		if($size)
+		if ($size)
 		{
 			$query .= sprintf("%s(%s) ", $type, $size);
 		}
@@ -506,9 +506,9 @@ 
 			$query .= sprintf("%s ", $type);
 		}
 
-		if(isset($default))
+		if (isset($default))
 		{
-			if($type == 'INTEGER' || $type == 'BIGINT' || $type == 'INT')
+			if ($type == 'INTEGER' || $type == 'BIGINT' || $type == 'INT')
 			{
 				$query .= sprintf("default %d ", $default);
 			}
@@ -518,7 +518,7 @@ 
 			}
 		}
 
-		if($notnull)
+		if ($notnull)
 		{
 			$query .= "not null ";
 		}
@@ -547,10 +547,10 @@ 
 	 */
 	function isColumnExists($table_name, $column_name)
 	{
-		$query = sprintf("select \"attr_name\" from \"db_attribute\" where " . "\"attr_name\" ='%s' and \"class_name\" = '%s%s'", $column_name, $this->prefix, $table_name);
+		$query = sprintf("select \"attr_name\" from \"db_attribute\" where "."\"attr_name\" ='%s' and \"class_name\" = '%s%s'", $column_name, $this->prefix, $table_name);
 		$result = $this->_query($query);
 
-		if(cubrid_num_rows($result) > 0)
+		if (cubrid_num_rows($result) > 0)
 		{
 			$output = TRUE;
 		}
@@ -559,7 +559,7 @@ 
 			$output = FALSE;
 		}
 
-		if($result)
+		if ($result)
 		{
 			cubrid_close_request($result);
 		}
@@ -579,12 +579,12 @@ 
 	 */
 	function addIndex($table_name, $index_name, $target_columns, $is_unique = FALSE)
 	{
-		if(!is_array($target_columns))
+		if (!is_array($target_columns))
 		{
 			$target_columns = array($target_columns);
 		}
 
-		$query = sprintf("create %s index \"%s\" on \"%s%s\" (%s);", $is_unique ? 'unique' : '', $index_name, $this->prefix, $table_name, '"' . implode('","', $target_columns) . '"');
+		$query = sprintf("create %s index \"%s\" on \"%s%s\" (%s);", $is_unique ? 'unique' : '', $index_name, $this->prefix, $table_name, '"'.implode('","', $target_columns).'"');
 
 		$this->_query($query);
 	}
@@ -611,17 +611,17 @@ 
 	 */
 	function isIndexExists($table_name, $index_name)
 	{
-		$query = sprintf("select \"index_name\" from \"db_index\" where " . "\"class_name\" = '%s%s' and (\"index_name\" = '%s' or \"index_name\" = '%s') ", $this->prefix, $table_name, $this->prefix . $index_name, $index_name);
+		$query = sprintf("select \"index_name\" from \"db_index\" where "."\"class_name\" = '%s%s' and (\"index_name\" = '%s' or \"index_name\" = '%s') ", $this->prefix, $table_name, $this->prefix.$index_name, $index_name);
 		$result = $this->_query($query);
 
-		if($this->isError())
+		if ($this->isError())
 		{
 			return FALSE;
 		}
 
 		$output = $this->_fetch($result);
 
-		if(!$output)
+		if (!$output)
 		{
 			return FALSE;
 		}
@@ -653,25 +653,25 @@ 
 				", strlen($this->prefix)
 				, $this->prefix
 				, strlen($this->prefix) + 1
-				, "'" . $this->prefix . '%' . "'"
+				, "'".$this->prefix.'%'."'"
 				, strlen($this->prefix)
 				, $this->prefix
 				, strlen($this->prefix) + 1
 		);
 		$result = $this->_query($query);
 
-		if($this->isError())
+		if ($this->isError())
 		{
 			return FALSE;
 		}
 
 		$output = $this->_fetch($result);
-		if(!$output)
+		if (!$output)
 		{
 			return FALSE;
 		}
 
-		if(!is_array($output))
+		if (!is_array($output))
 		{
 			$indexes_to_be_deleted = array($output);
 		}
@@ -680,10 +680,10 @@ 
 			$indexes_to_be_deleted = $output;
 		}
 
-		foreach($indexes_to_be_deleted as $index)
+		foreach ($indexes_to_be_deleted as $index)
 		{
 			$this->dropIndex(substr($index->class_name, strlen($this->prefix))
-					, $this->prefix . $index->unprefixed_index_name
+					, $this->prefix.$index->unprefixed_index_name
 					, $index->is_unique == 'YES' ? TRUE : FALSE);
 		}
 
@@ -707,7 +707,7 @@ 
 	 */
 	function createTableByXmlFile($file_name)
 	{
-		if(!file_exists($file_name))
+		if (!file_exists($file_name))
 		{
 			return;
 		}
@@ -734,28 +734,28 @@ 
 		$table_name = $xml_obj->table->attrs->name;
 
 		// if the table already exists exit function
-		if($this->isTableExists($table_name))
+		if ($this->isTableExists($table_name))
 		{
 			return;
 		}
 
 		// If the table name is sequence, it creates a serial
-		if($table_name == 'sequence')
+		if ($table_name == 'sequence')
 		{
-			$query = sprintf('create serial "%s" start with 1 increment by 1' .
-					' minvalue 1 ' .
-					'maxvalue 10000000000000000000000000000000000000' . ' nocycle;', $this->prefix . $table_name);
+			$query = sprintf('create serial "%s" start with 1 increment by 1'.
+					' minvalue 1 '.
+					'maxvalue 10000000000000000000000000000000000000'.' nocycle;', $this->prefix.$table_name);
 
 			return $this->_query($query);
 		}
 
 
-		$table_name = $this->prefix . $table_name;
+		$table_name = $this->prefix.$table_name;
 
 		$query = sprintf('create class "%s";', $table_name);
 		$this->_query($query);
 
-		if(!is_array($xml_obj->table->column))
+		if (!is_array($xml_obj->table->column))
 		{
 			$columns[] = $xml_obj->table->column;
 		}
@@ -770,7 +770,7 @@ 
 		$unique_list = array();
 		$index_list = array();
 
-		foreach($columns as $column)
+		foreach ($columns as $column)
 		{
 			$name = $column->attrs->name;
 			$type = $column->attrs->type;
@@ -781,7 +781,7 @@ 
 			$unique = $column->attrs->unique;
 			$default = $column->attrs->default;
 
-			switch($this->column_type[$type])
+			switch ($this->column_type[$type])
 			{
 				case 'integer' :
 					$size = NULL;
@@ -791,58 +791,58 @@ 
 					break;
 			}
 
-			if(isset($default) && ($type == 'varchar' || $type == 'char' ||
+			if (isset($default) && ($type == 'varchar' || $type == 'char' ||
 					$type == 'text' || $type == 'tinytext' || $type == 'bigtext'))
 			{
 				$default = sprintf("'%s'", $default);
 			}
 
-			if($type == 'varchar' || $type == 'char')
+			if ($type == 'varchar' || $type == 'char')
 			{
-				if($size)
+				if ($size)
 					$size = $size * 3;
 			}
 
 
-			$column_schema[] = sprintf('"%s" %s%s %s %s', $name, $this->column_type[$type], $size ? '(' . $size . ')' : '', isset($default) ? "default " . $default : '', $notnull ? 'not null' : '');
+			$column_schema[] = sprintf('"%s" %s%s %s %s', $name, $this->column_type[$type], $size ? '('.$size.')' : '', isset($default) ? "default ".$default : '', $notnull ? 'not null' : '');
 
-			if($primary_key)
+			if ($primary_key)
 			{
 				$primary_list[] = $name;
 			}
-			else if($unique)
+			else if ($unique)
 			{
 				$unique_list[$unique][] = $name;
 			}
-			else if($index)
+			else if ($index)
 			{
 				$index_list[$index][] = $name;
 			}
 		}
 
-		$query .= implode(',', $column_schema) . ';';
+		$query .= implode(',', $column_schema).';';
 		$this->_query($query);
 
-		if(count($primary_list))
+		if (count($primary_list))
 		{
-			$query = sprintf("alter class \"%s\" add attribute constraint " . "\"pkey_%s\" PRIMARY KEY(%s);", $table_name, $table_name, '"' . implode('","', $primary_list) . '"');
+			$query = sprintf("alter class \"%s\" add attribute constraint "."\"pkey_%s\" PRIMARY KEY(%s);", $table_name, $table_name, '"'.implode('","', $primary_list).'"');
 			$this->_query($query);
 		}
 
-		if(count($unique_list))
+		if (count($unique_list))
 		{
-			foreach($unique_list as $key => $val)
+			foreach ($unique_list as $key => $val)
 			{
-				$query = sprintf("create unique index \"%s\" on \"%s\" " . "(%s);", $key, $table_name, '"' . implode('","', $val) . '"');
+				$query = sprintf("create unique index \"%s\" on \"%s\" "."(%s);", $key, $table_name, '"'.implode('","', $val).'"');
 				$this->_query($query);
 			}
 		}
 
-		if(count($index_list))
+		if (count($index_list))
 		{
-			foreach($index_list as $key => $val)
+			foreach ($index_list as $key => $val)
 			{
-				$query = sprintf("create index \"%s\" on \"%s\" (%s);", $key, $table_name, '"' . implode('","', $val) . '"');
+				$query = sprintf("create index \"%s\" on \"%s\" (%s);", $key, $table_name, '"'.implode('","', $val).'"');
 				$this->_query($query);
 			}
 		}
@@ -856,22 +856,22 @@ 
 	 */
 	function _executeInsertAct($queryObject, $with_values = TRUE)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$this->param = $queryObject->getArguments();
 			$with_values = FALSE;
 		}
 		$query = $this->getInsertSql($queryObject, $with_values);
-		if(is_a($query, 'BaseObject'))
+		if (is_a($query, 'BaseObject'))
 		{
 			unset($this->param);
 			return;
 		}
 
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 
 		$result = $this->_query($query);
-		if($result && !$this->transaction_started)
+		if ($result && !$this->transaction_started)
 		{
 			$this->_commit();
 		}
@@ -887,23 +887,23 @@ 
 	 */
 	function _executeUpdateAct($queryObject, $with_values = TRUE)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$this->param = $queryObject->getArguments();
 			$with_values = FALSE;
 		}
 		$query = $this->getUpdateSql($queryObject, $with_values);
-		if(is_a($query, 'BaseObject'))
+		if (is_a($query, 'BaseObject'))
 		{
 			unset($this->param);
 			return;
 		}
 
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 
 		$result = $this->_query($query);
 
-		if($result && !$this->transaction_started)
+		if ($result && !$this->transaction_started)
 		{
 			$this->_commit();
 		}
@@ -919,23 +919,23 @@ 
 	 */
 	function _executeDeleteAct($queryObject, $with_values = TRUE)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$this->param = $queryObject->getArguments();
 			$with_values = FALSE;
 		}
 		$query = $this->getDeleteSql($queryObject, $with_values);
-		if(is_a($query, 'BaseObject'))
+		if (is_a($query, 'BaseObject'))
 		{
 			unset($this->param);
 			return;
 		}
 
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 
 		$result = $this->_query($query);
 
-		if($result && !$this->transaction_started)
+		if ($result && !$this->transaction_started)
 		{
 			$this->_commit();
 		}
@@ -955,29 +955,29 @@ 
 	 */
 	function _executeSelectAct($queryObject, $connection = NULL, $with_values = TRUE)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			$this->param = $queryObject->getArguments();
 			$with_values = FALSE;
 		}
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			return $this->queryPageLimit($queryObject, $connection, $with_values);
 		}
 		else
 		{
 			$query = $this->getSelectSql($queryObject, $with_values);
-			if(is_a($query, 'BaseObject'))
+			if (is_a($query, 'BaseObject'))
 			{
 				unset($this->param);
 				return;
 			}
 
-			$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+			$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 			$result = $this->_query($query, $connection);
 
-			if($this->isError())
+			if ($this->isError())
 			{
 				unset($this->param);
 				return $this->queryError($queryObject);
@@ -1000,16 +1000,16 @@ 
 	function queryError($queryObject)
 	{
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
-			$buff = new BaseObject ();
+			$buff = new BaseObject();
 			$buff->total_count = 0;
 			$buff->total_page = 0;
 			$buff->page = 1;
 			$buff->data = array();
 			$buff->page_navigation = new PageHandler(/* $total_count */0, /* $total_page */1, /* $page */1, /* $page_count */10); //default page handler values
 			return $buff;
-		}else
+		} else
 			return;
 	}
 
@@ -1025,48 +1025,48 @@ 
 		$limit = $queryObject->getLimit();
 		// Total count
 		$temp_where = $queryObject->getWhereString($with_values, FALSE);
-		$count_query = sprintf('select count(*) as "count" %s %s', 'FROM ' . $queryObject->getFromString($with_values), ($temp_where === '' ? '' : ' WHERE ' . $temp_where));
+		$count_query = sprintf('select count(*) as "count" %s %s', 'FROM '.$queryObject->getFromString($with_values), ($temp_where === '' ? '' : ' WHERE '.$temp_where));
 
 		// Check for distinct query and if found update count query structure
 		$temp_select = $queryObject->getSelectString($with_values);
 		$uses_distinct = stripos($temp_select, "distinct") !== FALSE;
 		$uses_groupby = $queryObject->getGroupByString() != '';
-		if($uses_distinct || $uses_groupby)
+		if ($uses_distinct || $uses_groupby)
 		{
 			$count_query = sprintf('select %s %s %s %s'
 					, $temp_select
-					, 'FROM ' . $queryObject->getFromString($with_values)
-					, ($temp_where === '' ? '' : ' WHERE ' . $temp_where)
-					, ($uses_groupby ? ' GROUP BY ' . $queryObject->getGroupByString() : '')
+					, 'FROM '.$queryObject->getFromString($with_values)
+					, ($temp_where === '' ? '' : ' WHERE '.$temp_where)
+					, ($uses_groupby ? ' GROUP BY '.$queryObject->getGroupByString() : '')
 			);
 
 			// If query uses grouping or distinct, count from original select
 			$count_query = sprintf('select count(*) as "count" from (%s) xet', $count_query);
 		}
 
-		$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' ' . $this->comment_syntax, $queryObject->queryID) : '';
+		$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' '.$this->comment_syntax, $queryObject->queryID) : '';
 		$result = $this->_query($count_query, $connection);
 		$count_output = $this->_fetch($result);
 		$total_count = (int) (isset($count_output->count) ? $count_output->count : NULL);
 
 		$list_count = $limit->list_count->getValue();
-		if(!$list_count)
+		if (!$list_count)
 		{
 			$list_count = 20;
 		}
 		$page_count = $limit->page_count->getValue();
-		if(!$page_count)
+		if (!$page_count)
 		{
 			$page_count = 10;
 		}
 		$page = $limit->page->getValue();
-		if(!$page || $page < 1)
+		if (!$page || $page < 1)
 		{
 			$page = 1;
 		}
 
 		// total pages
-		if($total_count)
+		if ($total_count)
 		{
 			$total_page = (int) (($total_count - 1) / $list_count) + 1;
 		}
@@ -1076,7 +1076,7 @@ 
 		}
 
 		// check the page variables
-		if($page > $total_page)
+		if ($page > $total_page)
 		{
 			// If requested page is bigger than total number of pages, return empty list
 
@@ -1092,9 +1092,9 @@ 
 		$start_count = ($page - 1) * $list_count;
 
 		$query = $this->getSelectPageSql($queryObject, $with_values, $start_count, $list_count);
-		$query .= (__DEBUG_QUERY__ & 1 && $queryObject->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $queryObject->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 		$result = $this->_query($query, $connection);
-		if($this->isError())
+		if ($this->isError())
 		{
 			unset($this->param);
 			return $this->queryError($queryObject);
@@ -1135,44 +1135,44 @@ 
 	{
 
 		$select = $query->getSelectString($with_values);
-		if($select == '')
+		if ($select == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$select = 'SELECT ' . $select;
+		$select = 'SELECT '.$select;
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$from = ' FROM ' . $from;
+		$from = ' FROM '.$from;
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$groupBy = $query->getGroupByString();
-		if($groupBy != '')
+		if ($groupBy != '')
 		{
-			$groupBy = ' GROUP BY ' . $groupBy;
+			$groupBy = ' GROUP BY '.$groupBy;
 		}
 
 		$orderBy = $query->getOrderByString();
-		if($orderBy != '')
+		if ($orderBy != '')
 		{
-			$orderBy = ' ORDER BY ' . $orderBy;
+			$orderBy = ' ORDER BY '.$orderBy;
 		}
 
 		$limit = $query->getLimitString();
-		if($limit != '')
+		if ($limit != '')
 		{
 			$limit = sprintf(' LIMIT %d, %d', $start_count, $list_count);
 		}
 
-		return $select . ' ' . $from . ' ' . $where . ' ' . $groupBy . ' ' . $orderBy . ' ' . $limit;
+		return $select.' '.$from.' '.$where.' '.$groupBy.' '.$orderBy.' '.$limit;
 	}
 
 }

Braces +31 added lines, -41 removed lines

@@ -52,7 +52,9 @@ 
 	function DBCubrid($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if($auto_connect) {
+			$this->_connect();
+		}
 	}
 
 	/**
@@ -90,8 +92,9 @@ 
 			define('__CUBRID_VERSION__', $cubrid_version);
 		}
 
-		if(__CUBRID_VERSION__ >= '8.4.0')
-			cubrid_set_autocommit($result, CUBRID_AUTOCOMMIT_TRUE);
+		if(__CUBRID_VERSION__ >= '8.4.0') {
+					cubrid_set_autocommit($result, CUBRID_AUTOCOMMIT_TRUE);
+		}
 
 		return $result;
 	}
@@ -153,8 +156,7 @@ 
 			if(!$transactionLevel)
 			{
 				cubrid_set_autocommit($connection, CUBRID_AUTOCOMMIT_FALSE);
-			}
-			else
+			} else
 			{
 				$this->_query("SAVEPOINT SP" . $transactionLevel, $connection);
 			}
@@ -176,8 +178,7 @@ 
 		if($point)
 		{
 			$this->_query("ROLLBACK TO SP" . $point, $connection);
-		}
-		else
+		} else
 		{
 			@cubrid_rollback($connection);
 		}
@@ -251,8 +252,7 @@ 
 								return false;
 							}
 						}
-					}
-					else
+					} else
 					{
 						$bound = @cubrid_bind($req, ++$position, $value, $bind_type);
 						if(!$bound)
@@ -343,8 +343,7 @@ 
 			if($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $tmp;
-			}
-			else
+			} else
 			{
 				$output[] = $tmp;
 			}
@@ -395,8 +394,9 @@ 
 	 */
 	function _makeSequence()
 	{
-		if($_GLOBALS['XE_EXISTS_SEQUENCE'])
-			return;
+		if($_GLOBALS['XE_EXISTS_SEQUENCE']) {
+					return;
+		}
 
 		// check cubrid serial
 		$query = sprintf('select count(*) as "count" from "db_serial" where name=\'%ssequence\'', $this->prefix);
@@ -421,8 +421,7 @@ 
 			if($srl < 1)
 			{
 				$start = 1;
-			}
-			else
+			} else
 			{
 				$start = $srl + 1000000;
 			}
@@ -445,8 +444,7 @@ 
 		if($target_name == 'sequence')
 		{
 			$query = sprintf("select \"name\" from \"db_serial\" where \"name\" = '%s%s'", $this->prefix, $target_name);
-		}
-		else
+		} else
 		{
 			$query = sprintf("select \"class_name\" from \"db_class\" where \"class_name\" = '%s%s'", $this->prefix, $target_name);
 		}
@@ -455,8 +453,7 @@ 
 		if(cubrid_num_rows($result) > 0)
 		{
 			$output = TRUE;
-		}
-		else
+		} else
 		{
 			$output = FALSE;
 		}
@@ -500,8 +497,7 @@ 
 		if($size)
 		{
 			$query .= sprintf("%s(%s) ", $type, $size);
-		}
-		else
+		} else
 		{
 			$query .= sprintf("%s ", $type);
 		}
@@ -511,8 +507,7 @@ 
 			if($type == 'INTEGER' || $type == 'BIGINT' || $type == 'INT')
 			{
 				$query .= sprintf("default %d ", $default);
-			}
-			else
+			} else
 			{
 				$query .= sprintf("default '%s' ", $default);
 			}
@@ -553,8 +548,7 @@ 
 		if(cubrid_num_rows($result) > 0)
 		{
 			$output = TRUE;
-		}
-		else
+		} else
 		{
 			$output = FALSE;
 		}
@@ -674,8 +668,7 @@ 
 		if(!is_array($output))
 		{
 			$indexes_to_be_deleted = array($output);
-		}
-		else
+		} else
 		{
 			$indexes_to_be_deleted = $output;
 		}
@@ -758,8 +751,7 @@ 
 		if(!is_array($xml_obj->table->column))
 		{
 			$columns[] = $xml_obj->table->column;
-		}
-		else
+		} else
 		{
 			$columns = $xml_obj->table->column;
 		}
@@ -799,8 +791,9 @@ 
 
 			if($type == 'varchar' || $type == 'char')
 			{
-				if($size)
-					$size = $size * 3;
+				if($size) {
+									$size = $size * 3;
+				}
 			}
 
 
@@ -809,12 +802,10 @@ 
 			if($primary_key)
 			{
 				$primary_list[] = $name;
-			}
-			else if($unique)
+			} else if($unique)
 			{
 				$unique_list[$unique][] = $name;
-			}
-			else if($index)
+			} else if($index)
 			{
 				$index_list[$index][] = $name;
 			}
@@ -964,8 +955,7 @@ 
 		if($limit && $limit->isPageHandler())
 		{
 			return $this->queryPageLimit($queryObject, $connection, $with_values);
-		}
-		else
+		} else
 		{
 			$query = $this->getSelectSql($queryObject, $with_values);
 			if(is_a($query, 'BaseObject'))
@@ -1009,8 +999,9 @@ 
 			$buff->data = array();
 			$buff->page_navigation = new PageHandler(/* $total_count */0, /* $total_page */1, /* $page */1, /* $page_count */10); //default page handler values
 			return $buff;
-		}else
-			return;
+		} else {
+					return;
+		}
 	}
 
 	/**
@@ -1069,8 +1060,7 @@ 
 		if($total_count)
 		{
 			$total_page = (int) (($total_count - 1) / $list_count) + 1;
-		}
-		else
+		} else
 		{
 			$total_page = 1;
 		}

classes/db/DBMssql.class.php

Doc Comments +8 added lines, -7 removed lines

@@ -111,7 +111,7 @@ 
 	/**
 	 * DB transaction start
 	 * this method is private
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function _begin($transactionLevel = 0)
 	{
@@ -170,7 +170,7 @@ 
 	 * this method is private
 	 * @param string $query
 	 * @param resource $connection
-	 * @return resource|boolean Returns a statement resource on success and FALSE if an error occurred.
+	 * @return resource Returns a statement resource on success and FALSE if an error occurred.
 	 */
 	function __query($query, $connection)
 	{
@@ -375,7 +375,7 @@ 
 	 * @param int $size column size
 	 * @param string|int $default default value
 	 * @param boolean $notnull not null status, default value is false
-	 * @return void
+	 * @return null|resource
 	 */
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = false)
 	{
@@ -431,7 +431,7 @@ 
 	 * Check column exist status of the table
 	 * @param string $table_name table name
 	 * @param string $column_name column name
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function isColumnExists($table_name, $column_name)
 	{
@@ -495,7 +495,7 @@ 
 	 * Check index status of the table
 	 * @param string $table_name table name
 	 * @param string $index_name index name
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function isIndexExists($table_name, $index_name)
 	{
@@ -674,7 +674,7 @@ 
 
 	/**
 	 * Return update query string
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @param boolean $with_priority
 	 * @return string
@@ -726,8 +726,9 @@ 
 
 	/**
 	 * Return select query string
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
+	 * @param resource $connection
 	 * @return string
 	 */
 	function getSelectSql($query, $with_values = TRUE, $connection=NULL)

Spacing +112 added lines, -112 removed lines

@@ -45,7 +45,7 @@ 
 	function DBMssql($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if ($auto_connect) $this->_connect();
 	}
 
 	/**
@@ -70,10 +70,10 @@ 
 		//sqlsrv_configure( 'LogSubsystems', SQLSRV_LOG_SYSTEM_ALL );
 		$result = @sqlsrv_connect($connection["db_hostname"], array('Database' => $connection["db_database"], 'UID' => $connection["db_userid"], 'PWD' => $connection["db_password"]));
 
-		if(!$result)
+		if (!$result)
 		{
 			$errors = print_r(sqlsrv_errors(), true);
-			$this->setError(-1, 'database connect fail' . PHP_EOL . $errors);
+			$this->setError(-1, 'database connect fail'.PHP_EOL.$errors);
 			return;
 		}
 		return $result;
@@ -99,7 +99,7 @@ 
 	 */
 	function addQuotes($string)
 	{
-		if(version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
+		if (version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
 		{
 			$string = stripslashes(str_replace("\\", "\\\\", $string));
 		}
@@ -117,16 +117,16 @@ 
 	{
 		$connection = $this->_getConnection('master');
 
-		if(!$transactionLevel)
+		if (!$transactionLevel)
 		{
-			if(sqlsrv_begin_transaction($connection) === false)
+			if (sqlsrv_begin_transaction($connection) === false)
 			{
 				return;
 			}
 		}
 		else
 		{
-			$this->_query("SAVE TRANS SP" . $transactionLevel, $connection);
+			$this->_query("SAVE TRANS SP".$transactionLevel, $connection);
 		}
 		return true;
 	}
@@ -142,9 +142,9 @@ 
 
 		$point = $transactionLevel - 1;
 
-		if($point)
+		if ($point)
 		{
-			$this->_query("ROLLBACK TRANS SP" . $point, $connection);
+			$this->_query("ROLLBACK TRANS SP".$point, $connection);
 		}
 		else
 		{
@@ -176,18 +176,18 @@ 
 	{
 		$_param = array();
 
-		if(count($this->param))
+		if (count($this->param))
 		{
-			foreach($this->param as $k => $o)
+			foreach ($this->param as $k => $o)
 			{
-				if($o->isColumnName())
+				if ($o->isColumnName())
 				{
 					continue;
 				}
-				if($o->getType() == 'number')
+				if ($o->getType() == 'number')
 				{
 					$value = $o->getUnescapedValue();
-					if(is_array($value))
+					if (is_array($value))
 					{
 						$_param = array_merge($_param, $value);
 					}
@@ -199,9 +199,9 @@ 
 				else
 				{
 					$value = $o->getUnescapedValue();
-					if(is_array($value))
+					if (is_array($value))
 					{
-						foreach($value as $v)
+						foreach ($value as $v)
 						{
 							$_param[] = array($v, SQLSRV_PARAM_IN, SQLSRV_PHPTYPE_STRING('utf-8'));
 						}
@@ -216,7 +216,7 @@ 
 
 		// Run the query statement
 		$result = false;
-		if(count($_param))
+		if (count($_param))
 		{
 			$args = $this->_getParametersByReference($_param);
 			$stmt = sqlsrv_prepare($connection, $query, $args);
@@ -226,7 +226,7 @@ 
 			$stmt = sqlsrv_prepare($connection, $query);
 		}
 
-		if(!$stmt)
+		if (!$stmt)
 		{
 			$result = false;
 		}
@@ -236,7 +236,7 @@ 
 		}
 
 		// Error Check
-		if(!$result)
+		if (!$result)
 		{
 			$this->setError(print_r(sqlsrv_errors(), true));
 		}
@@ -259,9 +259,9 @@ 
 		$copy = array();
 		$args = array();
 		$i = 0;
-		foreach($_param as $key => $value)
+		foreach ($_param as $key => $value)
 		{
-			if(is_array($value))
+			if (is_array($value))
 			{
 				$value_copy = $value;
 				$value_arg = array();
@@ -288,7 +288,7 @@ 
 	function _fetch($result, $arrayIndexEndValue = NULL)
 	{
 		$output = array();
-		if(!$this->isConnected() || $this->isError() || !$result)
+		if (!$this->isConnected() || $this->isError() || !$result)
 		{
 			return $output;
 		}
@@ -296,18 +296,18 @@ 
 		$c = sqlsrv_num_fields($result);
 		$m = null;
 
-		while(sqlsrv_fetch($result))
+		while (sqlsrv_fetch($result))
 		{
-			if(!$m)
+			if (!$m)
 			{
 				$m = sqlsrv_field_metadata($result);
 			}
 			unset($row);
-			for($i = 0; $i < $c; $i++)
+			for ($i = 0; $i < $c; $i++)
 			{
 				$row->{$m[$i]['Name']} = sqlsrv_get_field($result, $i, SQLSRV_PHPTYPE_STRING('utf-8'));
 			}
-			if($arrayIndexEndValue)
+			if ($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $row;
 			}
@@ -317,9 +317,9 @@ 
 			}
 		}
 
-		if(count($output) == 1)
+		if (count($output) == 1)
 		{
-			if(isset($arrayIndexEndValue))
+			if (isset($arrayIndexEndValue))
 			{
 				return $output;
 			}
@@ -360,7 +360,7 @@ 
 		$result = $this->_query($query);
 		$tmp = $this->_fetch($result);
 
-		if(!$tmp)
+		if (!$tmp)
 		{
 			return false;
 		}
@@ -379,18 +379,18 @@ 
 	 */
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = false)
 	{
-		if($this->isColumnExists($table_name, $column_name))
+		if ($this->isColumnExists($table_name, $column_name))
 		{
 			return;
 		}
 		$type = $this->column_type[$type];
-		if(strtoupper($type) == 'INTEGER')
+		if (strtoupper($type) == 'INTEGER')
 		{
 			$size = '';
 		}
 
 		$query = sprintf("alter table %s%s add \"%s\" ", $this->prefix, $table_name, $column_name);
-		if($size)
+		if ($size)
 		{
 			$query .= sprintf(" %s(%s) ", $type, $size);
 		}
@@ -399,11 +399,11 @@ 
 			$query .= sprintf(" %s ", $type);
 		}
 
-		if(isset($default))
+		if (isset($default))
 		{
 			$query .= sprintf(" default '%s' ", $default);
 		}
-		if($notnull)
+		if ($notnull)
 		{
 			$query .= " not null ";
 		}
@@ -419,7 +419,7 @@ 
 	 */
 	function dropColumn($table_name, $column_name)
 	{
-		if(!$this->isColumnExists($table_name, $column_name))
+		if (!$this->isColumnExists($table_name, $column_name))
 		{
 			return;
 		}
@@ -437,12 +437,12 @@ 
 	{
 		$query = sprintf("select syscolumns.name as name from syscolumns, sysobjects where sysobjects.name = '%s%s' and sysobjects.id = syscolumns.id and syscolumns.name = '%s'", $this->prefix, $table_name, $column_name);
 		$result = $this->_query($query);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return;
 		}
 		$tmp = $this->_fetch($result);
-		if(!$tmp->name)
+		if (!$tmp->name)
 		{
 			return false;
 		}
@@ -461,11 +461,11 @@ 
 	 */
 	function addIndex($table_name, $index_name, $target_columns, $is_unique = false)
 	{
-		if($this->isIndexExists($table_name, $index_name))
+		if ($this->isIndexExists($table_name, $index_name))
 		{
 			return;
 		}
-		if(!is_array($target_columns))
+		if (!is_array($target_columns))
 		{
 			$target_columns = array($target_columns);
 		}
@@ -483,7 +483,7 @@ 
 	 */
 	function dropIndex($table_name, $index_name, $is_unique = false)
 	{
-		if(!$this->isIndexExists($table_name, $index_name))
+		if (!$this->isIndexExists($table_name, $index_name))
 		{
 			return;
 		}
@@ -502,13 +502,13 @@ 
 		$query = sprintf("select sysindexes.name as name from sysindexes, sysobjects where sysobjects.name = '%s%s' and sysobjects.id = sysindexes.id and sysindexes.name = '%s'", $this->prefix, $table_name, $index_name);
 
 		$result = $this->_query($query);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return;
 		}
 		$tmp = $this->_fetch($result);
 
-		if(!$tmp->name)
+		if (!$tmp->name)
 		{
 			return false;
 		}
@@ -532,7 +532,7 @@ 
 	 */
 	function createTableByXmlFile($file_name)
 	{
-		if(!file_exists($file_name))
+		if (!file_exists($file_name))
 		{
 			return;
 		}
@@ -557,22 +557,22 @@ 
 		$xml_obj = $oXml->parse($xml_doc);
 		// Create a table schema
 		$table_name = $xml_obj->table->attrs->name;
-		if($this->isTableExists($table_name))
+		if ($this->isTableExists($table_name))
 		{
 			return;
 		}
 
-		if($table_name == 'sequence')
+		if ($table_name == 'sequence')
 		{
-			$table_name = $this->prefix . $table_name;
+			$table_name = $this->prefix.$table_name;
 			$query = sprintf('create table %s ( sequence int identity(1,1), seq int )', $table_name);
 			return $this->_query($query);
 		}
 		else
 		{
-			$table_name = $this->prefix . $table_name;
+			$table_name = $this->prefix.$table_name;
 
-			if(!is_array($xml_obj->table->column))
+			if (!is_array($xml_obj->table->column))
 			{
 				$columns[] = $xml_obj->table->column;
 			}
@@ -586,7 +586,7 @@ 
 			$index_list = array();
 
 			$typeList = array('number' => 1, 'text' => 1);
-			foreach($columns as $column)
+			foreach ($columns as $column)
 			{
 				$name = $column->attrs->name;
 				$type = $column->attrs->type;
@@ -598,48 +598,48 @@ 
 				$default = $column->attrs->default;
 				$auto_increment = $column->attrs->auto_increment;
 
-				$column_schema[] = sprintf('[%s] %s%s %s %s %s', $name, $this->column_type[$type], !isset($typeList[$type]) && $size ? '(' . $size . ')' : '', isset($default) ? "default '" . $default . "'" : '', $notnull ? 'not null' : 'null', $auto_increment ? 'identity(1,1)' : '');
+				$column_schema[] = sprintf('[%s] %s%s %s %s %s', $name, $this->column_type[$type], !isset($typeList[$type]) && $size ? '('.$size.')' : '', isset($default) ? "default '".$default."'" : '', $notnull ? 'not null' : 'null', $auto_increment ? 'identity(1,1)' : '');
 
-				if($primary_key)
+				if ($primary_key)
 				{
 					$primary_list[] = $name;
 				}
-				else if($unique)
+				else if ($unique)
 				{
 					$unique_list[$unique][] = $name;
 				}
-				else if($index)
+				else if ($index)
 				{
 					$index_list[$index][] = $name;
 				}
 			}
 
-			if(count($primary_list))
+			if (count($primary_list))
 			{
-				$column_schema[] = sprintf("primary key (%s)", '"' . implode($primary_list, '","') . '"');
+				$column_schema[] = sprintf("primary key (%s)", '"'.implode($primary_list, '","').'"');
 			}
 
 			$schema = sprintf('create table [%s] (%s%s)', $this->addQuotes($table_name), "\n", implode($column_schema, ",\n"));
 			$output = $this->_query($schema);
-			if(!$output)
+			if (!$output)
 			{
 				return false;
 			}
 
-			if(count($unique_list))
+			if (count($unique_list))
 			{
-				foreach($unique_list as $key => $val)
+				foreach ($unique_list as $key => $val)
 				{
-					$query = sprintf("create unique index %s on %s (%s);", $key, $table_name, '[' . implode('],[', $val) . ']');
+					$query = sprintf("create unique index %s on %s (%s);", $key, $table_name, '['.implode('],[', $val).']');
 					$this->_query($query);
 				}
 			}
 
-			if(count($index_list))
+			if (count($index_list))
 			{
-				foreach($index_list as $key => $val)
+				foreach ($index_list as $key => $val)
 				{
-					$query = sprintf("create index %s on %s (%s);", $key, $table_name, '[' . implode('],[', $val) . ']');
+					$query = sprintf("create index %s on %s (%s);", $key, $table_name, '['.implode('],[', $val).']');
 					$this->_query($query);
 				}
 			}
@@ -682,34 +682,34 @@ 
 	function getUpdateSql($query, $with_values = true, $with_priority = false)
 	{
 		$columnsList = $query->getUpdateString($with_values);
-		if($columnsList == '')
+		if ($columnsList == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
 
 		$tables = $query->getTables();
 		$alias_list = '';
-		foreach($tables as $table)
+		foreach ($tables as $table)
 		{
 			$alias_list .= $table->getAlias();
 		}
 		implode(',', explode(' ', $alias_list));
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$priority = $with_priority ? $query->getPriority() : '';
 
-		return "UPDATE $priority $alias_list SET $columnsList FROM " . $from . $where;
+		return "UPDATE $priority $alias_list SET $columnsList FROM ".$from.$where;
 	}
 
 	/**
@@ -730,7 +730,7 @@ 
 	 * @param boolean $with_values
 	 * @return string
 	 */
-	function getSelectSql($query, $with_values = TRUE, $connection=NULL)
+	function getSelectSql($query, $with_values = TRUE, $connection = NULL)
 	{
 		$with_values = false;
 
@@ -740,75 +740,75 @@ 
 		$limit = '';
 		$limitCount = '';
 		$limitQueryPart = $query->getLimit();
-		if($limitQueryPart)
+		if ($limitQueryPart)
 		{
 			$limitCount = $limitQueryPart->getLimit();
 		}
-		if($limitCount != '')
+		if ($limitCount != '')
 		{
-			$limit = 'SELECT TOP ' . $limitCount;
+			$limit = 'SELECT TOP '.$limitCount;
 		}
 
 		$select = $query->getSelectString($with_values);
-		if($select == '')
+		if ($select == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		if($limit != '')
+		if ($limit != '')
 		{
-			$select = $limit . ' ' . $select;
+			$select = $limit.' '.$select;
 		}
 		else
 		{
-			$select = 'SELECT ' . $select;
+			$select = 'SELECT '.$select;
 		}
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$from = ' FROM ' . $from;
+		$from = ' FROM '.$from;
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$groupBy = $query->getGroupByString();
-		if($groupBy != '')
+		if ($groupBy != '')
 		{
-			$groupBy = ' GROUP BY ' . $groupBy;
+			$groupBy = ' GROUP BY '.$groupBy;
 		}
 
 		$orderBy = $query->getOrderByString();
-		if($orderBy != '')
+		if ($orderBy != '')
 		{
-			$orderBy = ' ORDER BY ' . $orderBy;
+			$orderBy = ' ORDER BY '.$orderBy;
 		}
 
-		if($limitCount != '' && $query->limit->start > 0)
+		if ($limitCount != '' && $query->limit->start > 0)
 		{
 			$order = $query->getOrder();
 			$first_columns = array();
-			foreach($order as $val)
+			foreach ($order as $val)
 			{
 				$tmpColumnName = $val->getPureColumnName();
-				$first_columns[] = sprintf('%s(%s) as %s', $val->getPureSortOrder()=='asc'?'max':'min', $tmpColumnName, $tmpColumnName);
+				$first_columns[] = sprintf('%s(%s) as %s', $val->getPureSortOrder() == 'asc' ? 'max' : 'min', $tmpColumnName, $tmpColumnName);
 				$first_sub_columns[] = $tmpColumnName;
 			}
 
-			$first_query = sprintf("select %s from (select top %d %s %s %s %s %s) xet", implode(',',$first_columns),  $query->limit->start, implode(',',$first_sub_columns), $from, $where, $groupBy, $orderBy);
+			$first_query = sprintf("select %s from (select top %d %s %s %s %s %s) xet", implode(',', $first_columns), $query->limit->start, implode(',', $first_sub_columns), $from, $where, $groupBy, $orderBy);
 			$this->param = $query->getArguments();
 			$result = $this->__query($first_query, $connection);
 			$tmp = $this->_fetch($result);
 
 			$sub_cond = array();
-			foreach($order as $k => $v)
+			foreach ($order as $k => $v)
 			{
 				//for example... use Document
-				if(get_class($v->sort_order) == 'SortArgument')
+				if (get_class($v->sort_order) == 'SortArgument')
 				{
 					$sort_order = $v->sort_order->value;
 				}
@@ -818,19 +818,19 @@ 
 					$sort_order = $v->sort_order;
 				}
 
-				$sub_cond[] = sprintf("%s %s '%s'", $v->getPureColumnName(), $sort_order=='asc'?'>':'<', $tmp->{$v->getPureColumnName()});
+				$sub_cond[] = sprintf("%s %s '%s'", $v->getPureColumnName(), $sort_order == 'asc' ? '>' : '<', $tmp->{$v->getPureColumnName()});
 			}
 
-			if(!$where)
+			if (!$where)
 			{
-				$sub_condition = ' WHERE ( '.implode(' and ',$sub_cond).' )';
+				$sub_condition = ' WHERE ( '.implode(' and ', $sub_cond).' )';
 			}
 			else
 			{
-				$sub_condition = ' and ( '.implode(' and ',$sub_cond).' )';
+				$sub_condition = ' and ( '.implode(' and ', $sub_cond).' )';
 			}
 		}
-		return $select . ' ' . $from . ' ' . $where .$sub_condition. ' ' . $groupBy . ' ' . $orderBy;
+		return $select.' '.$from.' '.$where.$sub_condition.' '.$groupBy.' '.$orderBy;
 	}
 
 	/**
@@ -845,7 +845,7 @@ 
 	{
 		$query = $this->getSelectSql($queryObject, true, $connection);
 
-		if(strpos($query, "substr"))
+		if (strpos($query, "substr"))
 		{
 			$query = str_replace("substr", "substring", $query);
 		}
@@ -853,10 +853,10 @@ 
 		// TODO Decide if we continue to pass parameters like this
 		$this->param = $queryObject->getArguments();
 
-		$query .= (__DEBUG_QUERY__ & 1 && $output->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $output->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 		$result = $this->_query($query, $connection);
 
-		if($this->isError())
+		if ($this->isError())
 		{
 			return $this->queryError($queryObject);
 		}
@@ -884,7 +884,7 @@ 
 	function queryError($queryObject)
 	{
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			$buff = new BaseObject();
 			$buff->total_count = 0;
@@ -910,52 +910,52 @@ 
 	function queryPageLimit($queryObject, $result, $connection)
 	{
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			// Total count
 			$temp_where = $queryObject->getWhereString(true, false);
-			$count_query = sprintf('select count(*) as "count" %s %s', 'FROM ' . $queryObject->getFromString(), ($temp_where === '' ? '' : ' WHERE ' . $temp_where));
+			$count_query = sprintf('select count(*) as "count" %s %s', 'FROM '.$queryObject->getFromString(), ($temp_where === '' ? '' : ' WHERE '.$temp_where));
 
 			// Check for distinct query and if found update count query structure
 			$temp_select = $queryObject->getSelectString(true);
 			$uses_distinct = stripos($temp_select, "distinct") !== false;
 			$uses_groupby = $queryObject->getGroupByString() != '';
-			if($uses_distinct || $uses_groupby)
+			if ($uses_distinct || $uses_groupby)
 			{
 				$count_query = sprintf('select %s %s %s %s'
 						, $temp_select
-						, 'FROM ' . $queryObject->getFromString(true)
-						, ($temp_where === '' ? '' : ' WHERE ' . $temp_where)
-						, ($uses_groupby ? ' GROUP BY ' . $queryObject->getGroupByString() : '')
+						, 'FROM '.$queryObject->getFromString(true)
+						, ($temp_where === '' ? '' : ' WHERE '.$temp_where)
+						, ($uses_groupby ? ' GROUP BY '.$queryObject->getGroupByString() : '')
 				);
 
 				// If query uses grouping or distinct, count from original select
 				$count_query = sprintf('select count(*) as "count" from (%s) xet', $count_query);
 			}
 
-			$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+			$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 			$this->param = $queryObject->getArguments();
 			$result_count = $this->_query($count_query, $connection);
 			$count_output = $this->_fetch($result_count);
 			$total_count = (int) $count_output->count;
 
 			$list_count = $limit->list_count->getValue();
-			if(!$list_count)
+			if (!$list_count)
 			{
 				$list_count = 20;
 			}
 			$page_count = $limit->page_count->getValue();
-			if(!$page_count)
+			if (!$page_count)
 			{
 				$page_count = 10;
 			}
 			$page = $limit->page->getValue();
-			if(!$page || $page < 1)
+			if (!$page || $page < 1)
 			{
 				$page = 1;
 			}
 			// Total pages
-			if($total_count)
+			if ($total_count)
 			{
 				$total_page = (int) (($total_count - 1) / $list_count) + 1;
 			}
@@ -965,7 +965,7 @@ 
 			}
 
 			// check the page variables
-			if($page > $total_page)
+			if ($page > $total_page)
 			{
 				// If requested page is bigger than total number of pages, return empty list
 
@@ -977,7 +977,7 @@ 
 				$buff->page_navigation = new PageHandler($total_count, $total_page, $page, $page_count);
 				return $buff;
 
-				if($queryObject->usesClickCount())
+				if ($queryObject->usesClickCount())
 				{
 					$update_query = $this->getClickCountQuery($queryObject);
 					$this->_executeUpdateAct($update_query);

Braces +24 added lines, -43 removed lines

@@ -45,7 +45,9 @@ 
 	function DBMssql($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if($auto_connect) {
+			$this->_connect();
+		}
 	}
 
 	/**
@@ -123,8 +125,7 @@ 
 			{
 				return;
 			}
-		}
-		else
+		} else
 		{
 			$this->_query("SAVE TRANS SP" . $transactionLevel, $connection);
 		}
@@ -145,8 +146,7 @@ 
 		if($point)
 		{
 			$this->_query("ROLLBACK TRANS SP" . $point, $connection);
-		}
-		else
+		} else
 		{
 			sqlsrv_rollback($connection);
 		}
@@ -190,13 +190,11 @@ 
 					if(is_array($value))
 					{
 						$_param = array_merge($_param, $value);
-					}
-					else
+					} else
 					{
 						$_param[] = $o->getUnescapedValue();
 					}
-				}
-				else
+				} else
 				{
 					$value = $o->getUnescapedValue();
 					if(is_array($value))
@@ -205,8 +203,7 @@ 
 						{
 							$_param[] = array($v, SQLSRV_PARAM_IN, SQLSRV_PHPTYPE_STRING('utf-8'));
 						}
-					}
-					else
+					} else
 					{
 						$_param[] = array($value, SQLSRV_PARAM_IN, SQLSRV_PHPTYPE_STRING('utf-8'));
 					}
@@ -220,8 +217,7 @@ 
 		{
 			$args = $this->_getParametersByReference($_param);
 			$stmt = sqlsrv_prepare($connection, $query, $args);
-		}
-		else
+		} else
 		{
 			$stmt = sqlsrv_prepare($connection, $query);
 		}
@@ -229,8 +225,7 @@ 
 		if(!$stmt)
 		{
 			$result = false;
-		}
-		else
+		} else
 		{
 			$result = sqlsrv_execute($stmt);
 		}
@@ -268,8 +263,7 @@ 
 				$value_arg[] = &$value_copy[0];
 				$value_arg[] = $value_copy[1];
 				$value_arg[] = $value_copy[2];
-			}
-			else
+			} else
 			{
 				$value_arg = $value;
 			}
@@ -310,8 +304,7 @@ 
 			if($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $row;
-			}
-			else
+			} else
 			{
 				$output[] = $row;
 			}
@@ -322,8 +315,7 @@ 
 			if(isset($arrayIndexEndValue))
 			{
 				return $output;
-			}
-			else
+			} else
 			{
 				return $output[0];
 			}
@@ -393,8 +385,7 @@ 
 		if($size)
 		{
 			$query .= sprintf(" %s(%s) ", $type, $size);
-		}
-		else
+		} else
 		{
 			$query .= sprintf(" %s ", $type);
 		}
@@ -567,16 +558,14 @@ 
 			$table_name = $this->prefix . $table_name;
 			$query = sprintf('create table %s ( sequence int identity(1,1), seq int )', $table_name);
 			return $this->_query($query);
-		}
-		else
+		} else
 		{
 			$table_name = $this->prefix . $table_name;
 
 			if(!is_array($xml_obj->table->column))
 			{
 				$columns[] = $xml_obj->table->column;
-			}
-			else
+			} else
 			{
 				$columns = $xml_obj->table->column;
 			}
@@ -603,12 +592,10 @@ 
 				if($primary_key)
 				{
 					$primary_list[] = $name;
-				}
-				else if($unique)
+				} else if($unique)
 				{
 					$unique_list[$unique][] = $name;
-				}
-				else if($index)
+				} else if($index)
 				{
 					$index_list[$index][] = $name;
 				}
@@ -757,8 +744,7 @@ 
 		if($limit != '')
 		{
 			$select = $limit . ' ' . $select;
-		}
-		else
+		} else
 		{
 			$select = 'SELECT ' . $select;
 		}
@@ -824,8 +810,7 @@ 
 			if(!$where)
 			{
 				$sub_condition = ' WHERE ( '.implode(' and ',$sub_cond).' )';
-			}
-			else
+			} else
 			{
 				$sub_condition = ' and ( '.implode(' and ',$sub_cond).' )';
 			}
@@ -859,8 +844,7 @@ 
 		if($this->isError())
 		{
 			return $this->queryError($queryObject);
-		}
-		else
+		} else
 		{
 			return $this->queryPageLimit($queryObject, $result, $connection);
 		}
@@ -893,8 +877,7 @@ 
 			$buff->data = array();
 			$buff->page_navigation = new PageHandler(/* $total_count */0, /* $total_page */1, /* $page */1, /* $page_count */10); //default page handler values
 			return $buff;
-		}
-		else
+		} else
 		{
 			return;
 		}
@@ -958,8 +941,7 @@ 
 			if($total_count)
 			{
 				$total_page = (int) (($total_count - 1) / $list_count) + 1;
-			}
-			else
+			} else
 			{
 				$total_page = 1;
 			}
@@ -995,8 +977,7 @@ 
 			$buff->page = $page;
 			$buff->data = $data;
 			$buff->page_navigation = new PageHandler($total_count, $total_page, $page, $page_count);
-		}
-		else
+		} else
 		{
 			$data = $this->_fetch($result);
 			$buff = new BaseObject();

classes/db/DBMysql.class.php

Doc Comments +7 added lines, -7 removed lines

@@ -297,7 +297,7 @@ 
 	 * @param int $size column size
 	 * @param string|int $default default value
 	 * @param boolean $notnull not null status, default value is false
-	 * @return void
+	 * @return resource|null
 	 */
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = false)
 	{
@@ -344,7 +344,7 @@ 
 	 * Check column exist status of the table
 	 * @param string $table_name table name
 	 * @param string $column_name column name
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function isColumnExists($table_name, $column_name)
 	{
@@ -408,7 +408,7 @@ 
 	 * Check index status of the table
 	 * @param string $table_name table name
 	 * @param string $index_name index name
-	 * @return boolean
+	 * @return null|boolean
 	 */
 	function isIndexExists($table_name, $index_name)
 	{
@@ -442,7 +442,7 @@ 
 	/**
 	 * Creates a table by using xml contents
 	 * @param string $xml_doc xml schema contents
-	 * @return void|object
+	 * @return null|false
 	 */
 	function createTableByXml($xml_doc)
 	{
@@ -452,7 +452,7 @@ 
 	/**
 	 * Creates a table by using xml file path
 	 * @param string $file_name xml schema file path
-	 * @return void|object
+	 * @return null|false
 	 */
 	function createTableByXmlFile($file_name)
 	{
@@ -472,7 +472,7 @@ 
 	 * opt : notnull, default, size\n
 	 * index : primary key, index, unique\n
 	 * @param string $xml_doc xml schema contents
-	 * @return void|object
+	 * @return null|false
 	 */
 	function _createTable($xml_doc)
 	{
@@ -824,7 +824,7 @@ 
 
 	/**
 	 * If select query execute, return paging sql
-	 * @param object $query
+	 * @param BaseObject $query
 	 * @param boolean $with_values
 	 * @param int $start_count
 	 * @param int $list_count

Spacing +90 added lines, -90 removed lines

@@ -46,7 +46,7 @@ 
 	function DBMysql($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if ($auto_connect) $this->_connect();
 	}
 
 	/**
@@ -67,32 +67,32 @@ 
 	function __connect($connection)
 	{
 		// Ignore if no DB information exists
-		if(strpos($connection["db_hostname"], ':') === false && $connection["db_port"])
+		if (strpos($connection["db_hostname"], ':') === false && $connection["db_port"])
 		{
-			$connection["db_hostname"] .= ':' . $connection["db_port"];
+			$connection["db_hostname"] .= ':'.$connection["db_port"];
 		}
 
 		// Attempt to connect
 		$result = @mysql_connect($connection["db_hostname"], $connection["db_userid"], $connection["db_password"]);
-		if(!$result)
+		if (!$result)
 		{
 			exit('XE cannot connect to DB.');
 		}
 
-		if(mysql_error())
+		if (mysql_error())
 		{
 			$this->setError(mysql_errno(), mysql_error());
 			return;
 		}
 		// Error appears if the version is lower than 4.1
-		if(version_compare(mysql_get_server_info($result), '4.1', '<'))
+		if (version_compare(mysql_get_server_info($result), '4.1', '<'))
 		{
-			$this->setError(-1, 'XE cannot be installed under the version of mysql 4.1. Current mysql version is ' . mysql_get_server_info());
+			$this->setError(-1, 'XE cannot be installed under the version of mysql 4.1. Current mysql version is '.mysql_get_server_info());
 			return;
 		}
 		// select db
 		@mysql_select_db($connection["db_database"], $result);
-		if(mysql_error())
+		if (mysql_error())
 		{
 			$this->setError(mysql_errno(), mysql_error());
 			return;
@@ -131,11 +131,11 @@ 
 	 */
 	function addQuotes($string)
 	{
-		if(version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
+		if (version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
 		{
 			$string = stripslashes(str_replace("\\", "\\\\", $string));
 		}
-		if(!is_numeric($string))
+		if (!is_numeric($string))
 		{
 			$string = @mysql_real_escape_string($string);
 		}
@@ -181,14 +181,14 @@ 
 	 */
 	function __query($query, $connection)
 	{
-		if(!$connection)
+		if (!$connection)
 		{
 			exit('XE cannot handle DB connection.');
 		}
 		// Run the query statement
 		$result = mysql_query($query, $connection);
 		// Error Check
-		if(mysql_error($connection))
+		if (mysql_error($connection))
 		{
 			$this->setError(mysql_errno($connection), mysql_error($connection));
 		}
@@ -205,13 +205,13 @@ 
 	function _fetch($result, $arrayIndexEndValue = NULL)
 	{
 		$output = array();
-		if(!$this->isConnected() || $this->isError() || !$result)
+		if (!$this->isConnected() || $this->isError() || !$result)
 		{
 			return $output;
 		}
-		while($tmp = $this->db_fetch_object($result))
+		while ($tmp = $this->db_fetch_object($result))
 		{
-			if($arrayIndexEndValue)
+			if ($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $tmp;
 			}
@@ -220,9 +220,9 @@ 
 				$output[] = $tmp;
 			}
 		}
-		if(count($output) == 1)
+		if (count($output) == 1)
 		{
-			if(isset($arrayIndexEndValue))
+			if (isset($arrayIndexEndValue))
 			{
 				return $output;
 			}
@@ -245,7 +245,7 @@ 
 		$query = sprintf("insert into `%ssequence` (seq) values ('0')", $this->prefix);
 		$this->_query($query);
 		$sequence = $this->db_insert_id();
-		if($sequence % 10000 == 0)
+		if ($sequence % 10000 == 0)
 		{
 			$query = sprintf("delete from  `%ssequence` where seq < %d", $this->prefix, $sequence);
 			$this->_query($query);
@@ -265,7 +265,7 @@ 
 		$query = sprintf("select password('%s') as password, old_password('%s') as old_password", $this->addQuotes($password), $this->addQuotes($password));
 		$result = $this->_query($query);
 		$tmp = $this->_fetch($result);
-		if($tmp->password === $saved_password || $tmp->old_password === $saved_password)
+		if ($tmp->password === $saved_password || $tmp->old_password === $saved_password)
 		{
 			return true;
 		}
@@ -282,7 +282,7 @@ 
 		$query = sprintf("show tables like '%s%s'", $this->prefix, $this->addQuotes($target_name));
 		$result = $this->_query($query);
 		$tmp = $this->_fetch($result);
-		if(!$tmp)
+		if (!$tmp)
 		{
 			return false;
 		}
@@ -302,13 +302,13 @@ 
 	function addColumn($table_name, $column_name, $type = 'number', $size = '', $default = null, $notnull = false)
 	{
 		$type = $this->column_type[$type];
-		if(strtoupper($type) == 'INTEGER')
+		if (strtoupper($type) == 'INTEGER')
 		{
 			$size = '';
 		}
 
 		$query = sprintf("alter table `%s%s` add `%s` ", $this->prefix, $table_name, $column_name);
-		if($size)
+		if ($size)
 		{
 			$query .= sprintf(" %s(%s) ", $type, $size);
 		}
@@ -316,11 +316,11 @@ 
 		{
 			$query .= sprintf(" %s ", $type);
 		}
-		if(isset($default))
+		if (isset($default))
 		{
 			$query .= sprintf(" default '%s' ", $default);
 		}
-		if($notnull)
+		if ($notnull)
 		{
 			$query .= " not null ";
 		}
@@ -350,18 +350,18 @@ 
 	{
 		$query = sprintf("show fields from `%s%s`", $this->prefix, $table_name);
 		$result = $this->_query($query);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return;
 		}
 		$output = $this->_fetch($result);
-		if($output)
+		if ($output)
 		{
 			$column_name = strtolower($column_name);
-			foreach($output as $key => $val)
+			foreach ($output as $key => $val)
 			{
 				$name = strtolower($val->Field);
-				if($column_name == $name)
+				if ($column_name == $name)
 				{
 					return true;
 				}
@@ -382,7 +382,7 @@ 
 	 */
 	function addIndex($table_name, $index_name, $target_columns, $is_unique = false)
 	{
-		if(!is_array($target_columns))
+		if (!is_array($target_columns))
 		{
 			$target_columns = array($target_columns);
 		}
@@ -415,23 +415,23 @@ 
 		//$query = sprintf("show indexes from %s%s where key_name = '%s' ", $this->prefix, $table_name, $index_name);
 		$query = sprintf("show indexes from `%s%s`", $this->prefix, $table_name);
 		$result = $this->_query($query);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return;
 		}
 		$output = $this->_fetch($result);
-		if(!$output)
+		if (!$output)
 		{
 			return;
 		}
-		if(!is_array($output))
+		if (!is_array($output))
 		{
 			$output = array($output);
 		}
 
-		for($i = 0; $i < count($output); $i++)
+		for ($i = 0; $i < count($output); $i++)
 		{
-			if($output[$i]->Key_name == $index_name)
+			if ($output[$i]->Key_name == $index_name)
 			{
 				return true;
 			}
@@ -456,7 +456,7 @@ 
 	 */
 	function createTableByXmlFile($file_name)
 	{
-		if(!file_exists($file_name))
+		if (!file_exists($file_name))
 		{
 			return;
 		}
@@ -481,13 +481,13 @@ 
 		$xml_obj = $oXml->parse($xml_doc);
 		// Create a table schema
 		$table_name = $xml_obj->table->attrs->name;
-		if($this->isTableExists($table_name))
+		if ($this->isTableExists($table_name))
 		{
 			return;
 		}
-		$table_name = $this->prefix . $table_name;
+		$table_name = $this->prefix.$table_name;
 
-		if(!is_array($xml_obj->table->column))
+		if (!is_array($xml_obj->table->column))
 		{
 			$columns[] = $xml_obj->table->column;
 		}
@@ -500,7 +500,7 @@ 
 		$unique_list = array();
 		$index_list = array();
 
-		foreach($columns as $column)
+		foreach ($columns as $column)
 		{
 			$name = $column->attrs->name;
 			$type = $column->attrs->type;
@@ -512,47 +512,47 @@ 
 			$default = $column->attrs->default;
 			$auto_increment = $column->attrs->auto_increment;
 
-			$column_schema[] = sprintf('`%s` %s%s %s %s %s', $name, $this->column_type[$type], $size ? '(' . $size . ')' : '', isset($default) ? "default '" . $default . "'" : '', $notnull ? 'not null' : '', $auto_increment ? 'auto_increment' : '');
+			$column_schema[] = sprintf('`%s` %s%s %s %s %s', $name, $this->column_type[$type], $size ? '('.$size.')' : '', isset($default) ? "default '".$default."'" : '', $notnull ? 'not null' : '', $auto_increment ? 'auto_increment' : '');
 
-			if($primary_key)
+			if ($primary_key)
 			{
 				$primary_list[] = $name;
 			}
-			else if($unique)
+			else if ($unique)
 			{
 				$unique_list[$unique][] = $name;
 			}
-			else if($index)
+			else if ($index)
 			{
 				$index_list[$index][] = $name;
 			}
 		}
 
-		if(count($primary_list))
+		if (count($primary_list))
 		{
-			$column_schema[] = sprintf("primary key (%s)", '`' . implode($primary_list, '`,`') . '`');
+			$column_schema[] = sprintf("primary key (%s)", '`'.implode($primary_list, '`,`').'`');
 		}
 
-		if(count($unique_list))
+		if (count($unique_list))
 		{
-			foreach($unique_list as $key => $val)
+			foreach ($unique_list as $key => $val)
 			{
-				$column_schema[] = sprintf("unique %s (%s)", $key, '`' . implode($val, '`,`') . '`');
+				$column_schema[] = sprintf("unique %s (%s)", $key, '`'.implode($val, '`,`').'`');
 			}
 		}
 
-		if(count($index_list))
+		if (count($index_list))
 		{
-			foreach($index_list as $key => $val)
+			foreach ($index_list as $key => $val)
 			{
-				$column_schema[] = sprintf("index %s (%s)", $key, '`' . implode($val, '`,`') . '`');
+				$column_schema[] = sprintf("index %s (%s)", $key, '`'.implode($val, '`,`').'`');
 			}
 		}
 
 		$schema = sprintf('create table `%s` (%s%s) %s;', $this->addQuotes($table_name), "\n", implode($column_schema, ",\n"), "ENGINE = MYISAM  CHARACTER SET utf8 COLLATE utf8_general_ci");
 
 		$output = $this->_query($schema);
-		if(!$output)
+		if (!$output)
 			return false;
 	}
 
@@ -565,8 +565,8 @@ 
 	function _executeInsertAct($queryObject, $with_values = true)
 	{
 		$query = $this->getInsertSql($queryObject, $with_values, true);
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
-		if(is_a($query, 'BaseObject'))
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
+		if (is_a($query, 'BaseObject'))
 		{
 			return;
 		}
@@ -582,13 +582,13 @@ 
 	function _executeUpdateAct($queryObject, $with_values = true)
 	{
 		$query = $this->getUpdateSql($queryObject, $with_values, true);
-		if(is_a($query, 'BaseObject'))
+		if (is_a($query, 'BaseObject'))
 		{
-			if(!$query->toBool()) return $query;
+			if (!$query->toBool()) return $query;
 			else return;
 		}
 
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 
 
 		return $this->_query($query);
@@ -603,8 +603,8 @@ 
 	function _executeDeleteAct($queryObject, $with_values = true)
 	{
 		$query = $this->getDeleteSql($queryObject, $with_values, true);
-		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
-		if(is_a($query, 'BaseObject'))
+		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
+		if (is_a($query, 'BaseObject'))
 		{
 			return;
 		}
@@ -624,21 +624,21 @@ 
 	{
 		$limit = $queryObject->getLimit();
 		$result = NULL;
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			return $this->queryPageLimit($queryObject, $result, $connection, $with_values);
 		}
 		else
 		{
 			$query = $this->getSelectSql($queryObject, $with_values);
-			if(is_a($query, 'BaseObject'))
+			if (is_a($query, 'BaseObject'))
 			{
 				return;
 			}
-			$query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' ' . $this->comment_syntax, $queryObject->queryID) : '';
+			$query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' '.$this->comment_syntax, $queryObject->queryID) : '';
 
 			$result = $this->_query($query, $connection);
-			if($this->isError())
+			if ($this->isError())
 			{
 				return $this->queryError($queryObject);
 			}
@@ -647,7 +647,7 @@ 
 			$buff = new BaseObject();
 			$buff->data = $data;
 
-			if($queryObject->usesClickCount())
+			if ($queryObject->usesClickCount())
 			{
 				$update_query = $this->getClickCountQuery($queryObject);
 				$this->_executeUpdateAct($update_query, $with_values);
@@ -708,7 +708,7 @@ 
 	function queryError($queryObject)
 	{
 		$limit = $queryObject->getLimit();
-		if($limit && $limit->isPageHandler())
+		if ($limit && $limit->isPageHandler())
 		{
 			$buff = new BaseObject();
 			$buff->total_count = 0;
@@ -737,48 +737,48 @@ 
 		$limit = $queryObject->getLimit();
 		// Total count
 		$temp_where = $queryObject->getWhereString($with_values, false);
-		$count_query = sprintf('select count(*) as "count" %s %s', 'FROM ' . $queryObject->getFromString($with_values), ($temp_where === '' ? '' : ' WHERE ' . $temp_where));
+		$count_query = sprintf('select count(*) as "count" %s %s', 'FROM '.$queryObject->getFromString($with_values), ($temp_where === '' ? '' : ' WHERE '.$temp_where));
 
 		// Check for distinct query and if found update count query structure
 		$temp_select = $queryObject->getSelectString($with_values);
 		$uses_distinct = stripos($temp_select, "distinct") !== false;
 		$uses_groupby = $queryObject->getGroupByString() != '';
-		if($uses_distinct || $uses_groupby)
+		if ($uses_distinct || $uses_groupby)
 		{
 			$count_query = sprintf('select %s %s %s %s'
 					, $temp_select == '*' ? '1' : $temp_select
-					, 'FROM ' . $queryObject->getFromString($with_values)
-					, ($temp_where === '' ? '' : ' WHERE ' . $temp_where)
-					, ($uses_groupby ? ' GROUP BY ' . $queryObject->getGroupByString() : '')
+					, 'FROM '.$queryObject->getFromString($with_values)
+					, ($temp_where === '' ? '' : ' WHERE '.$temp_where)
+					, ($uses_groupby ? ' GROUP BY '.$queryObject->getGroupByString() : '')
 			);
 
 			// If query uses grouping or distinct, count from original select
 			$count_query = sprintf('select count(*) as "count" from (%s) xet', $count_query);
 		}
 
-		$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' ' . $this->comment_syntax, $queryObject->queryID) : '';
+		$count_query .= (__DEBUG_QUERY__ & 1 && $queryObject->queryID) ? sprintf(' '.$this->comment_syntax, $queryObject->queryID) : '';
 		$result_count = $this->_query($count_query, $connection);
 		$count_output = $this->_fetch($result_count);
 		$total_count = (int) (isset($count_output->count) ? $count_output->count : NULL);
 
 		$list_count = $limit->list_count->getValue();
-		if(!$list_count)
+		if (!$list_count)
 		{
 			$list_count = 20;
 		}
 		$page_count = $limit->page_count->getValue();
-		if(!$page_count)
+		if (!$page_count)
 		{
 			$page_count = 10;
 		}
 		$page = $limit->page->getValue();
-		if(!$page || $page < 1)
+		if (!$page || $page < 1)
 		{
 			$page = 1;
 		}
 
 		// total pages
-		if($total_count)
+		if ($total_count)
 		{
 			$total_page = (int) (($total_count - 1) / $list_count) + 1;
 		}
@@ -788,7 +788,7 @@ 
 		}
 
 		// check the page variables
-		if($page > $total_page)
+		if ($page > $total_page)
 		{
 			// If requested page is bigger than total number of pages, return empty list
 			$buff = new BaseObject();
@@ -803,9 +803,9 @@ 
 
 		$query = $this->getSelectPageSql($queryObject, $with_values, $start_count, $list_count);
 
-		$query .= (__DEBUG_QUERY__ & 1 && $queryObject->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
+		$query .= (__DEBUG_QUERY__ & 1 && $queryObject->query_id) ? sprintf(' '.$this->comment_syntax, $this->query_id) : '';
 		$result = $this->_query($query, $connection);
-		if($this->isError())
+		if ($this->isError())
 		{
 			return $this->queryError($queryObject);
 		}
@@ -833,44 +833,44 @@ 
 	function getSelectPageSql($query, $with_values = true, $start_count = 0, $list_count = 0)
 	{
 		$select = $query->getSelectString($with_values);
-		if($select == '')
+		if ($select == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$select = 'SELECT ' . $select;
+		$select = 'SELECT '.$select;
 
 		$from = $query->getFromString($with_values);
-		if($from == '')
+		if ($from == '')
 		{
 			return new BaseObject(-1, "Invalid query");
 		}
-		$from = ' FROM ' . $from;
+		$from = ' FROM '.$from;
 
 		$where = $query->getWhereString($with_values);
-		if($where != '')
+		if ($where != '')
 		{
-			$where = ' WHERE ' . $where;
+			$where = ' WHERE '.$where;
 		}
 
 		$groupBy = $query->getGroupByString();
-		if($groupBy != '')
+		if ($groupBy != '')
 		{
-			$groupBy = ' GROUP BY ' . $groupBy;
+			$groupBy = ' GROUP BY '.$groupBy;
 		}
 
 		$orderBy = $query->getOrderByString();
-		if($orderBy != '')
+		if ($orderBy != '')
 		{
-			$orderBy = ' ORDER BY ' . $orderBy;
+			$orderBy = ' ORDER BY '.$orderBy;
 		}
 
 		$limit = $query->getLimitString();
-		if($limit != '')
+		if ($limit != '')
 		{
 			$limit = sprintf(' LIMIT %d, %d', $start_count, $list_count);
 		}
 
-		return $select . ' ' . $from . ' ' . $where . ' ' . $groupBy . ' ' . $orderBy . ' ' . $limit;
+		return $select.' '.$from.' '.$where.' '.$groupBy.' '.$orderBy.' '.$limit;
 	}
 
 }

Braces +20 added lines, -23 removed lines

@@ -46,7 +46,9 @@ 
 	function DBMysql($auto_connect = TRUE)
 	{
 		$this->_setDBInfo();
-		if($auto_connect) $this->_connect();
+		if($auto_connect) {
+			$this->_connect();
+		}
 	}
 
 	/**
@@ -214,8 +216,7 @@ 
 			if($arrayIndexEndValue)
 			{
 				$output[$arrayIndexEndValue--] = $tmp;
-			}
-			else
+			} else
 			{
 				$output[] = $tmp;
 			}
@@ -225,8 +226,7 @@ 
 			if(isset($arrayIndexEndValue))
 			{
 				return $output;
-			}
-			else
+			} else
 			{
 				return $output[0];
 			}
@@ -311,8 +311,7 @@ 
 		if($size)
 		{
 			$query .= sprintf(" %s(%s) ", $type, $size);
-		}
-		else
+		} else
 		{
 			$query .= sprintf(" %s ", $type);
 		}
@@ -490,8 +489,7 @@ 
 		if(!is_array($xml_obj->table->column))
 		{
 			$columns[] = $xml_obj->table->column;
-		}
-		else
+		} else
 		{
 			$columns = $xml_obj->table->column;
 		}
@@ -517,12 +515,10 @@ 
 			if($primary_key)
 			{
 				$primary_list[] = $name;
-			}
-			else if($unique)
+			} else if($unique)
 			{
 				$unique_list[$unique][] = $name;
-			}
-			else if($index)
+			} else if($index)
 			{
 				$index_list[$index][] = $name;
 			}
@@ -552,8 +548,9 @@ 
 		$schema = sprintf('create table `%s` (%s%s) %s;', $this->addQuotes($table_name), "\n", implode($column_schema, ",\n"), "ENGINE = MYISAM  CHARACTER SET utf8 COLLATE utf8_general_ci");
 
 		$output = $this->_query($schema);
-		if(!$output)
-			return false;
+		if(!$output) {
+					return false;
+		}
 	}
 
 	/**
@@ -584,8 +581,11 @@ 
 		$query = $this->getUpdateSql($queryObject, $with_values, true);
 		if(is_a($query, 'BaseObject'))
 		{
-			if(!$query->toBool()) return $query;
-			else return;
+			if(!$query->toBool()) {
+				return $query;
+			} else {
+				return;
+			}
 		}
 
 		$query .= (__DEBUG_QUERY__ & 1 && $this->query_id) ? sprintf(' ' . $this->comment_syntax, $this->query_id) : '';
@@ -627,8 +627,7 @@ 
 		if($limit && $limit->isPageHandler())
 		{
 			return $this->queryPageLimit($queryObject, $result, $connection, $with_values);
-		}
-		else
+		} else
 		{
 			$query = $this->getSelectSql($queryObject, $with_values);
 			if(is_a($query, 'BaseObject'))
@@ -717,8 +716,7 @@ 
 			$buff->data = array();
 			$buff->page_navigation = new PageHandler(/* $total_count */0, /* $total_page */1, /* $page */1, /* $page_count */10); //default page handler values
 			return $buff;
-		}
-		else
+		} else
 		{
 			return;
 		}
@@ -781,8 +779,7 @@ 
 		if($total_count)
 		{
 			$total_page = (int) (($total_count - 1) / $list_count) + 1;
-		}
-		else
+		} else
 		{
 			$total_page = 1;
 		}

classes/db/DBMysqli_innodb.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
 	 * opt : notnull, default, size\n
 	 * index : primary key, index, unique\n
 	 * @param string $xml_doc xml schema contents
-	 * @return void|object
+	 * @return null|false
 	 */
 	function _createTable($xml_doc)
 	{