+global\member::moduleUpdate()

Complexity

Conditions	28
Paths	> 20000

Size

Total Lines	160
Code Lines	87

Duplication

Lines	19
Ratio	11.88 %

Importance

Changes

0

<?php
	function moduleUpdate()
	{
		$oDB = &DB::getInstance();
		$oModuleModel = getModel('module');
		$oModuleController = getController('module');
		$oMemberAdminController = getAdminController('member');
		$config = $oModuleModel->getModuleConfig('member');
		$version_update_id = implode('.', array(__CLASS__, __XE_VERSION__, 'updated'));
		if($oModuleModel->needUpdate($version_update_id))
		{
			// Check member directory
			FileHandler::makeDir('./files/member_extra_info/image_name');
			FileHandler::makeDir('./files/member_extra_info/image_mark');
			FileHandler::makeDir('./files/member_extra_info/signature');
			FileHandler::makeDir('./files/member_extra_info/profile_image');
			// Add a column
			if(!$oDB->isColumnExists("member_auth_mail", "is_register"))
			{
				$oDB->addColumn("member_auth_mail", "is_register", "char", 1, "N", true);
			}
			// Add a column(site_srl) to "member_group_member" table (11/15/2008)
			if(!$oDB->isColumnExists("member_group_member", "site_srl"))
			{
				$oDB->addColumn("member_group_member", "site_srl", "number", 11, 0, true);
				$oDB->addIndex("member_group_member", "idx_site_srl", "site_srl", false);
			}
			if(!$oDB->isColumnExists("member_group", "site_srl"))
			{
				$oDB->addColumn("member_group", "site_srl", "number", 11, 0, true);
				$oDB->addIndex("member_group","idx_site_title", array("site_srl","title"),true);
			}
			if($oDB->isIndexExists("member_group","uni_member_group_title"))
			{
				$oDB->dropIndex("member_group","uni_member_group_title",true);
			}

			// Add a column(list_order) to "member_group" table (05/18/2011)
			if(!$oDB->isColumnExists("member_group", "list_order"))
			{
				$oDB->addColumn("member_group", "list_order", "number", 11, '', true);
				$oDB->addIndex("member_group","idx_list_order", "list_order",false);
				$output = executeQuery('member.updateAllMemberGroupListOrder');

$output is not used, you could remove the assignment.

			}
			// Add a column for image_mark (02/14/2009)
			if(!$oDB->isColumnExists("member_group", "image_mark"))
			{
				$oDB->addColumn("member_group", "image_mark", "text");
			}
			// Add a column for password expiration date
			if(!$oDB->isColumnExists("member", "change_password_date"))
			{
				$oDB->addColumn("member", "change_password_date", "date");
				executeQuery('member.updateAllChangePasswordDate');
			}

			// Add columns of question and answer to verify a password
			if(!$oDB->isColumnExists("member", "find_account_question"))
			{
				$oDB->addColumn("member", "find_account_question", "number", 11);
			}
			if(!$oDB->isColumnExists("member", "find_account_answer"))
			{
				$oDB->addColumn("member", "find_account_answer", "varchar", 250);
			}

			if(!$oDB->isColumnExists("member", "list_order"))
			{
				$oDB->addColumn("member", "list_order", "number", 11);
				@set_time_limit(0);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

				$args->list_order = 'member_srl';

The variable $args does not exist. Did you forget to declare it?

				executeQuery('member.updateMemberListOrderAll',$args);
				executeQuery('member.updateMemberListOrderAll');
			}
			if(!$oDB->isIndexExists("member","idx_list_order"))
			{
				$oDB->addIndex("member","idx_list_order", array("list_order"));
			}

			$config = $oModuleModel->getModuleConfig('member');

			// check agreement value exist
			if($config->agreement)
			{
				$agreement_file = _XE_PATH_.'files/member_extra_info/agreement_' . Context::get('lang_type') . '.txt';
				$output = FileHandler::writeFile($agreement_file, $config->agreement);

Are you sure the assignment to $output is correct as \FileHandler::writeFile($agreement_file, $config->agreement) (which targets FileHandler::writeFile()) seems to always return null.

$output is not used, you could remove the assignment.

				$config->agreement = NULL;
				$output = $oModuleController->updateModuleConfig('member', $config);

$output is not used, you could remove the assignment.

			}

			// check signup form ordering info
			if(!$config->signupForm || !is_array($config->signupForm))
			{
				$identifier = 'email_address';

				$config->signupForm = $oMemberAdminController->createSignupForm($identifier);
				$config->identifier = $identifier;
				unset($config->agreement);
			}

			// 회원정보에서 이메일 노출 제거
			// @see https://github.com/xpressengine/xe-core/issues/2177
			foreach($config->signupForm as $form)
			{
				if($form->name === 'email_address')
				{
					$form->isPublic = 'N';
					break;
				}
			}
			$oModuleController->updateModuleConfig('member', $config);

			if($config->skin)
			{
				$config_parse = explode('.', $config->skin);
				if (count($config_parse) > 1)
				{
					$template_path = sprintf('./themes/%s/modules/member/', $config_parse[0]);
					if(is_dir($template_path))
					{
						$config->skin = implode('|@|', $config_parse);
						$oModuleController = getController('module');
						$oModuleController->updateModuleConfig('member', $config);
					}
				}
			}
			
			// 2013. 11. 22 add menu when popup document menu called
			if(!$oModuleModel->getTrigger('document.getDocumentMenu', 'member', 'controller', 'triggerGetDocumentMenu', 'after'))
				$oModuleController->insertTrigger('document.getDocumentMenu', 'member', 'controller', 'triggerGetDocumentMenu', 'after');
			if(!$oModuleModel->getTrigger('comment.getCommentMenu', 'member', 'controller', 'triggerGetCommentMenu', 'after'))
				$oModuleController->insertTrigger('comment.getCommentMenu', 'member', 'controller', 'triggerGetCommentMenu', 'after');

			if(is_readable('./files/member_extra_info/agreement.txt'))
			{
				$source_file = _XE_PATH_.'files/member_extra_info/agreement.txt';
				$target_file = _XE_PATH_.'files/member_extra_info/agreement_' . Context::get('lang_type') . '.txt';

				FileHandler::rename($source_file, $target_file);
			}

			$oModuleController->insertUpdatedLog($version_update_id);
		}

		FileHandler::makeDir('./files/ruleset');
		if(!is_readable('./files/ruleset/insertMember.xml'))
			$oMemberAdminController->_createSignupRuleset($config->signupForm);
		if(!is_readable('./files/ruleset/login.xml'))
			$oMemberAdminController->_createLoginRuleset($config->identifier);
		if(!is_readable('./files/ruleset/find_member_account_by_question.xml'))
			$oMemberAdminController->_createFindAccountByQuestion($config->identifier);

		if($oModuleModel->needUpdate('member.1.8.43.recreate_signup_ruleset'))
		{
			$oMemberAdminController->_createSignupRuleset($config->signupForm);
			$oModuleController->insertUpdatedLog('member.1.8.43.recreate_signup_ruleset');
		}

		return new BaseObject(0, 'success_updated');
	}