+global\fileModel::getFileList()

Complexity

Conditions	17
Paths	28

Size

Total Lines	93
Code Lines	57

Duplication

Lines	8
Ratio	8.6 %

Importance

Changes

0

<?php
	function getFileList()
	{
		$oModuleModel = getModel('module');

		$mid = Context::get('mid');

$mid is not used, you could remove the assignment.

		$editor_sequence = Context::get('editor_sequence');
		$upload_target_srl = Context::get('upload_target_srl');
		if(!$upload_target_srl) $upload_target_srl = $_SESSION['upload_info'][$editor_sequence]->upload_target_srl;

		if($upload_target_srl)
		{
			$oDocumentModel = getModel('document');
			$oCommentModel = getModel('comment');
			$logged_info = Context::get('logged_info');

			$oDocument = $oDocumentModel->getDocument($upload_target_srl);

			// comment 권한 확인
			if(!$oDocument->isExists())
			{
				$oComment = $oCommentModel->getComment($upload_target_srl);
				if($oComment->isExists() && $oComment->isSecret() && !$oComment->isGranted())
				{
					return new Object(-1, 'msg_not_permitted');
				}

				$oDocument = $oDocumentModel->getDocument($oComment->get('document_srl'));
			}

			// document 권한 확인
			if($oDocument->isExists() && $oDocument->isSecret() && !$oDocument->isGranted())
			{
				return new Object(-1, 'msg_not_permitted');
			}

			// 모듈 권한 확인
			if($oDocument->isExists())
			{
				$grant = $oModuleModel->getGrant($oModuleModel->getModuleInfoByModuleSrl($oDocument->get('module_srl')), $logged_info);
				if(!$grant->access)
				{
					return new Object(-1, 'msg_not_permitted');
				}
			}

			$tmp_files = $this->getFiles($upload_target_srl);
			if(!$tmp_files) $tmp_files = array();

The expression $tmp_files of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			foreach($tmp_files as $file_info)
			{
				if(!$file_info->file_srl) continue;

				$obj = new stdClass;
				$obj->file_srl = $file_info->file_srl;
				$obj->source_filename = $file_info->source_filename;
				$obj->file_size = $file_info->file_size;
				$obj->disp_file_size = FileHandler::filesize($file_info->file_size);
				if($file_info->direct_download=='N') $obj->download_url = $this->getDownloadUrl($file_info->file_srl, $file_info->sid, $file_info->module_srl);
				else $obj->download_url = str_replace('./', '', $file_info->uploaded_filename);
				$obj->direct_download = $file_info->direct_download;
				$obj->cover_image = ($file_info->cover_image === 'Y') ? true : false;
				$files[] = $obj;

$files was never initialized. Although not strictly required by PHP, it is generally a good practice to add $files = array(); before regardless.

				$attached_size += $file_info->file_size;

The variable $attached_size does not seem to be defined for all execution paths leading up to this point.

			}
		}
		else
		{
			$upload_target_srl = 0;
			$attached_size = 0;
			$files = array();
		}
		// Display upload status
		$upload_status = $this->getUploadStatus($attached_size);
		// Check remained file size until upload complete
		//$config = $oModuleModel->getModuleInfoByMid($mid);	//perhaps config varialbles not used

		$file_config = $this->getUploadConfig();
		$left_size = $file_config->allowed_attach_size*1024*1024 - $attached_size;
		// Settings of required information
		$attached_size = FileHandler::filesize($attached_size);
		$allowed_attach_size = FileHandler::filesize($file_config->allowed_attach_size*1024*1024);
		$allowed_filesize = FileHandler::filesize($file_config->allowed_filesize*1024*1024);
		$allowed_filetypes = $file_config->allowed_filetypes;
		$this->add("files",$files);

The variable $files does not seem to be defined for all execution paths leading up to this point.

		$this->add("editor_sequence",$editor_sequence);
		$this->add("upload_target_srl",$upload_target_srl);
		$this->add("upload_status",$upload_status);
		$this->add("left_size",$left_size);
		$this->add('attached_size', $attached_size);
		$this->add('allowed_attach_size', $allowed_attach_size);
		$this->add('allowed_filesize', $allowed_filesize);
		$this->add('allowed_filetypes', $allowed_filetypes);
	}