session::serializeSession() - Code Metrics - Inspection of "Merge branch 'release/1.8.43'" - xpressengine/xe-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 423fe8...f48289 )

by gyeong-won

created 2017-08-17 05:56 UTC

session::serializeSession() A

↳ Parent: session

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	1
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php
/* Copyright (C) NAVER <http://www.navercorp.com> */
/**
 * @class  session
 * @author NAVER ([email protected])
 * @brief session module's high class
 * @version 0.1
 *
 * The session management class
 */
class session extends ModuleObject
{
	var $lifetime = 18000;
	var $session_started = false;

	function session()

	{
		if(Context::isInstalled()) $this->session_started= true;
	}

	/**
	 * @brief Additional tasks required to accomplish during the installation
	 */
	function moduleInstall()
	{
		$oDB = &DB::getInstance();
		$oDB->addIndex("session","idx_session_update_mid", array("member_srl","last_update","cur_mid"));

		return new Object();
	}

	/**
	 * @brief A method to check if the installation has been successful
	 */
	function checkUpdate()

	{
		$oDB = &DB::getInstance();
		$oModuleModel = getModel('module');
		$oModuleController = getController('module');
		$version_update_id = implode('.', array(__CLASS__, __XE_VERSION__, 'updated'));
		if($oModuleModel->needUpdate($version_update_id))
		{
			if(!$oDB->isTableExists('session')) return true;
			if(!$oDB->isColumnExists("session","cur_mid")) return true;
			if(!$oDB->isIndexExists("session","idx_session_update_mid")) return true;

			$oModuleController->insertUpdatedLog($version_update_id);
		}

		return false;
	}

	/**
	 * @brief Execute update
	 */
	function moduleUpdate()
	{
		$oDB = &DB::getInstance();
		$oModuleModel = getModel('module');
		$oModuleController = getController('module');
		$version_update_id = implode('.', array(__CLASS__, __XE_VERSION__, 'updated'));
		if($oModuleModel->needUpdate($version_update_id))
		{
			if(!$oDB->isTableExists('session'))
			{
				$oDB->createTableByXmlFile($this->module_path.'schemas/session.xml');

			}
			if(!$oDB->isColumnExists("session","cur_mid"))
			{
				$oDB->addColumn('session',"cur_mid","varchar",128);
			}
			if(!$oDB->isIndexExists("session","idx_session_update_mid"))
			{
				$oDB->addIndex("session","idx_session_update_mid", array("member_srl","last_update","cur_mid"));
			}

			$oModuleController->insertUpdatedLog($version_update_id);
		}

		return new Object(0, 'success_updated');
	}

	/**
	 * @brief session string decode
	 */
	function unSerializeSession($val)
	{
		$vars = preg_split('/([a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff^|]*)\|/', $val,-1,PREG_SPLIT_NO_EMPTY | PREG_SPLIT_DELIM_CAPTURE);
		for($i=0; $vars[$i]; $i++) $result[$vars[$i++]] = unserialize($vars[$i]);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		return $result;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
	}

	/**
	 * @brief session string encode
	 */
	function serializeSession($data)
	{
		if(!count($data)) return;

		$str = '';
		foreach($data as $key => $val) $str .= $key.'|'.serialize($val);
		return substr($str, 0, strlen($str)-1).'}';
	}

	/**
	 * @brief Re-generate the cache file
	 */
	function recompileCache()
	{
	}
}
/* End of file session.class.php */
/* Location: ./modules/session/session.class.php */


1		<?php
2		/* Copyright (C) NAVER <http://www.navercorp.com> */
3		/**
4		* @class session
5		* @author NAVER ([email protected])
6		* @brief session module's high class
7		* @version 0.1
8		*
9		* The session management class
10		*/
11		class session extends ModuleObject
12		{
13		var $lifetime = 18000;
14		var $session_started = false;
15
16		function session()
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report Please use `__construct()` instead of a PHP4-style constructor that is named after the class. Loading history...
17		{
18		if(Context::isInstalled()) $this->session_started= true;
19		}
20
21		/**
22		* @brief Additional tasks required to accomplish during the installation
23		*/
24		function moduleInstall()
25		{
26		$oDB = &DB::getInstance();
27		$oDB->addIndex("session","idx_session_update_mid", array("member_srl","last_update","cur_mid"));
28
29		return new Object();
30		}
31
32		/**
33		* @brief A method to check if the installation has been successful
34		*/
35	View Code Duplication	function checkUpdate()
		0 ignored issues – show Duplication introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$oDB = &DB::getInstance();
38		$oModuleModel = getModel('module');
39		$oModuleController = getController('module');
40		$version_update_id = implode('.', array(__CLASS__, __XE_VERSION__, 'updated'));
41		if($oModuleModel->needUpdate($version_update_id))
42		{
43		if(!$oDB->isTableExists('session')) return true;
44		if(!$oDB->isColumnExists("session","cur_mid")) return true;
45		if(!$oDB->isIndexExists("session","idx_session_update_mid")) return true;
46
47		$oModuleController->insertUpdatedLog($version_update_id);
48		}
49
50		return false;
51		}
52
53		/**
54		* @brief Execute update
55		*/
56		function moduleUpdate()
57		{
58		$oDB = &DB::getInstance();
59		$oModuleModel = getModel('module');
60		$oModuleController = getController('module');
61		$version_update_id = implode('.', array(__CLASS__, __XE_VERSION__, 'updated'));
62		if($oModuleModel->needUpdate($version_update_id))
63		{
64		if(!$oDB->isTableExists('session'))
65		{
66		$oDB->createTableByXmlFile($this->module_path.'schemas/session.xml');
		0 ignored issues – show Bug introduced 2017-08-16 08:06 UTC by Report Bug Copy Issue Report The method `createTableByXmlFile()` does not exist on `DB`. Did you maybe mean `create()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
67		}
68		if(!$oDB->isColumnExists("session","cur_mid"))
69		{
70		$oDB->addColumn('session',"cur_mid","varchar",128);
71		}
72		if(!$oDB->isIndexExists("session","idx_session_update_mid"))
73		{
74		$oDB->addIndex("session","idx_session_update_mid", array("member_srl","last_update","cur_mid"));
75		}
76
77		$oModuleController->insertUpdatedLog($version_update_id);
78		}
79
80		return new Object(0, 'success_updated');
81		}
82
83		/**
84		* @brief session string decode
85		*/
86		function unSerializeSession($val)
87		{
88		$vars = preg_split('/([a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff^\|]*)\\|/', $val,-1,PREG_SPLIT_NO_EMPTY \| PREG_SPLIT_DELIM_CAPTURE);
89		for($i=0; $vars[$i]; $i++) $result[$vars[$i++]] = unserialize($vars[$i]);
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report `$result` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$result = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
90		return $result;
		0 ignored issues – show Bug introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report The variable `$result` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
91		}
92
93		/**
94		* @brief session string encode
95		*/
96		function serializeSession($data)
97		{
98		if(!count($data)) return;
99
100		$str = '';
101		foreach($data as $key => $val) $str .= $key.'\|'.serialize($val);
102		return substr($str, 0, strlen($str)-1).'}';
103		}
104
105		/**
106		* @brief Re-generate the cache file
107		*/
108		function recompileCache()
109		{
110		}
111		}
112		/* End of file session.class.php */
113		/* Location: ./modules/session/session.class.php */
114

xpressengine / xe-core

GitHub Access Token became invalid

Push — master ( 423fe8...f48289 )

session::serializeSession() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like