layout::checkUpdate() - Code Metrics - Inspection of "Merge branch 'release/1.8.43'" - xpressengine/xe-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 423fe8...f48289 )

by gyeong-won

created 2017-08-17 05:56 UTC

layout::checkUpdate() C

↳ Parent: layout

Complexity

Conditions	11
Paths	7

Size

Total Lines	38
Code Lines	22

Duplication

Lines	9
Ratio	23.68 %

Importance

Changes

Metric	Value
cc	11
eloc	22
nc	7
nop	0
dl	9
loc	38
rs	5.2653
c	0
b	0
f	0

How to fix Complexity

<?php
/* Copyright (C) NAVER <http://www.navercorp.com> */
/**
 * @class  layout
 * @author NAVER ([email protected])
 * high class of the layout module
 */
class layout extends ModuleObject
{
	/**
	 * Implement if additional tasks are necessary when installing
	 * @return Object
	 */
	function moduleInstall()
	{
		// Create a directory to be used in the layout
		FileHandler::makeDir('./files/cache/layout');

		return new Object();
	}

	/**
	 * a method to check if successfully installed
	 * @return boolean
	 */
	function checkUpdate()
	{
		$oDB = &DB::getInstance();
		$oModuleModel = getModel('module');
		$oModuleController = getController('module');
		$version_update_id = implode('.', array(__CLASS__, __XE_VERSION__, 'updated'));
		if($oModuleModel->needUpdate($version_update_id))
		{
			// 2009. 02. 11 Add site_srl to layout table
			if(!$oDB->isColumnExists('layouts', 'site_srl')) return true;
			// 2009. 02. 26 Move the previous layout for faceoff
			$files = FileHandler::readDir('./files/cache/layout');
			for($i=0,$c=count($files);$i<$c;$i++)
			{
				$filename = $files[$i];
				if(preg_match('/([0-9]+)\.html/i',$filename)) return true;
			}

			if(!$oDB->isColumnExists('layouts', 'layout_type')) return true;

			$args = new stdClass();
			$args->layout = '.';
			$output = executeQueryArray('layout.getLayoutDotList', $args);
			if($output->data && count($output->data) > 0)
			{
				foreach($output->data as $layout)
				{
					$layout_path = explode('.', $layout->layout);
					if(count($layout_path) != 2) continue;
					if(is_dir(sprintf(_XE_PATH_ . 'themes/%s/layouts/%s', $layout_path[0], $layout_path[1]))) return true;
				}
			}

			$oModuleController->insertUpdatedLog($version_update_id);
		}

		return false;
	}

	/**
	 * Execute update
	 * @return Object
	 */
	function moduleUpdate()
	{
		$oDB = &DB::getInstance();
		$oModuleModel = getModel('module');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$oModuleController = getController('module');
		$version_update_id = implode('.', array(__CLASS__, __XE_VERSION__, 'updated'));
		{
			// 2009. 02. 11 Add site_srl to menu table
			if(!$oDB->isColumnExists('layouts', 'site_srl'))
			{
				$oDB->addColumn('layouts','site_srl','number',11,0,true);
			}
			// 2009. 02. 26 Move the previous layout for faceoff
			$oLayoutModel = getModel('layout');
			$files = FileHandler::readDir('./files/cache/layout');
			for($i=0,$c=count($files);$i<$c;$i++)
			{
				$filename = $files[$i];
				if(!preg_match('/([0-9]+)\.html/i',$filename,$match)) continue;
				$layout_srl = $match[1];
				if(!$layout_srl) continue;
				$path = $oLayoutModel->getUserLayoutPath($layout_srl);
				if(!is_dir($path)) FileHandler::makeDir($path);
				FileHandler::copyFile('./files/cache/layout/'.$filename, $path.'layout.html');
				@unlink('./files/cache/layout/'.$filename);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
			}

			if(!$oDB->isColumnExists('layouts', 'layout_type'))
			{
				$oDB->addColumn('layouts','layout_type','char',1,'P',true);
			}

			$args->layout = '.';

			$output = executeQueryArray('layout.getLayoutDotList', $args);
			if($output->data && count($output->data) > 0)
			{
				foreach($output->data as $layout)
				{
					$layout_path = explode('.', $layout->layout);
					if(count($layout_path) != 2) continue;
					if(is_dir(sprintf(_XE_PATH_ . 'themes/%s/layouts/%s', $layout_path[0], $layout_path[1])))
					{
						$args->layout = implode('|@|', $layout_path);
						$args->layout_srl = $layout->layout_srl;
						$output = executeQuery('layout.updateLayout', $args);
					}
				}
			}

			$oModuleController->insertUpdatedLog($version_update_id);
		}
		return new Object(0, 'success_updated');
	}

	/**
	 * Re-generate the cache file
	 * @return void
	 */
	function recompileCache()
	{
		$path = './files/cache/layout';
		if(!is_dir($path))
		{
			FileHandler::makeDir($path);
			return;
		}
	}
}
/* End of file layout.class.php */
/* Location: ./modules/layout/layout.class.php */


1		<?php
2		/* Copyright (C) NAVER <http://www.navercorp.com> */
3		/**
4		* @class layout
5		* @author NAVER ([email protected])
6		* high class of the layout module
7		*/
8		class layout extends ModuleObject
9		{
10		/**
11		* Implement if additional tasks are necessary when installing
12		* @return Object
13		*/
14		function moduleInstall()
15		{
16		// Create a directory to be used in the layout
17		FileHandler::makeDir('./files/cache/layout');
18
19		return new Object();
20		}
21
22		/**
23		* a method to check if successfully installed
24		* @return boolean
25		*/
26		function checkUpdate()
27		{
28		$oDB = &DB::getInstance();
29		$oModuleModel = getModel('module');
30		$oModuleController = getController('module');
31		$version_update_id = implode('.', array(__CLASS__, __XE_VERSION__, 'updated'));
32		if($oModuleModel->needUpdate($version_update_id))
33		{
34		// 2009. 02. 11 Add site_srl to layout table
35		if(!$oDB->isColumnExists('layouts', 'site_srl')) return true;
36		// 2009. 02. 26 Move the previous layout for faceoff
37		$files = FileHandler::readDir('./files/cache/layout');
38		for($i=0,$c=count($files);$i<$c;$i++)
39		{
40		$filename = $files[$i];
41		if(preg_match('/([0-9]+)\.html/i',$filename)) return true;
42		}
43
44		if(!$oDB->isColumnExists('layouts', 'layout_type')) return true;
45
46		$args = new stdClass();
47		$args->layout = '.';
48		$output = executeQueryArray('layout.getLayoutDotList', $args);
49	View Code Duplication	if($output->data && count($output->data) > 0)
50		{
51		foreach($output->data as $layout)
52		{
53		$layout_path = explode('.', $layout->layout);
54		if(count($layout_path) != 2) continue;
55		if(is_dir(sprintf(_XE_PATH_ . 'themes/%s/layouts/%s', $layout_path[0], $layout_path[1]))) return true;
56		}
57		}
58
59		$oModuleController->insertUpdatedLog($version_update_id);
60		}
61
62		return false;
63		}
64
65		/**
66		* Execute update
67		* @return Object
68		*/
69		function moduleUpdate()
70		{
71		$oDB = &DB::getInstance();
72		$oModuleModel = getModel('module');
		0 ignored issues – show Unused Code introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report `$oModuleModel` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
73		$oModuleController = getController('module');
74		$version_update_id = implode('.', array(__CLASS__, __XE_VERSION__, 'updated'));
75		{
76		// 2009. 02. 11 Add site_srl to menu table
77		if(!$oDB->isColumnExists('layouts', 'site_srl'))
78		{
79		$oDB->addColumn('layouts','site_srl','number',11,0,true);
80		}
81		// 2009. 02. 26 Move the previous layout for faceoff
82		$oLayoutModel = getModel('layout');
83		$files = FileHandler::readDir('./files/cache/layout');
84		for($i=0,$c=count($files);$i<$c;$i++)
85		{
86		$filename = $files[$i];
87		if(!preg_match('/([0-9]+)\.html/i',$filename,$match)) continue;
88		$layout_srl = $match[1];
89		if(!$layout_srl) continue;
90		$path = $oLayoutModel->getUserLayoutPath($layout_srl);
91		if(!is_dir($path)) FileHandler::makeDir($path);
92		FileHandler::copyFile('./files/cache/layout/'.$filename, $path.'layout.html');
93		@unlink('./files/cache/layout/'.$filename);
		0 ignored issues – show Security Best Practice introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
94		}
95
96		if(!$oDB->isColumnExists('layouts', 'layout_type'))
97		{
98		$oDB->addColumn('layouts','layout_type','char',1,'P',true);
99		}
100
101		$args->layout = '.';
		0 ignored issues – show Bug introduced 2015-11-22 14:33 UTC by Report Bug Copy Issue Report The variable `$args` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
102		$output = executeQueryArray('layout.getLayoutDotList', $args);
103	View Code Duplication	if($output->data && count($output->data) > 0)
104		{
105		foreach($output->data as $layout)
106		{
107		$layout_path = explode('.', $layout->layout);
108		if(count($layout_path) != 2) continue;
109		if(is_dir(sprintf(_XE_PATH_ . 'themes/%s/layouts/%s', $layout_path[0], $layout_path[1])))
110		{
111		$args->layout = implode('\|@\|', $layout_path);
112		$args->layout_srl = $layout->layout_srl;
113		$output = executeQuery('layout.updateLayout', $args);
114		}
115		}
116		}
117
118		$oModuleController->insertUpdatedLog($version_update_id);
119		}
120		return new Object(0, 'success_updated');
121		}
122
123		/**
124		* Re-generate the cache file
125		* @return void
126		*/
127		function recompileCache()
128		{
129		$path = './files/cache/layout';
130		if(!is_dir($path))
131		{
132		FileHandler::makeDir($path);
133		return;
134		}
135		}
136		}
137		/* End of file layout.class.php */
138		/* Location: ./modules/layout/layout.class.php */
139

GitHub Access Token became invalid

Push — master ( 423fe8...f48289 )

layout::checkUpdate() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

xpressengine / xe-core

GitHub Access Token became invalid

Push — master ( 423fe8...f48289 )

layout::checkUpdate() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like