Query - Code Metrics - Inspection of "PHP 7.2에서 배열이 아닌 것에 count()를 사용하여 발생하는 오류 수정" - xpressengine/xe-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#2377)

unknown

created 2019-05-10 04:36 UTC

Query F

↳ Parent: Project

Complexity

Total Complexity

120

Size/Duplication

Total Lines	667
Duplicated Lines	11.39 %

Coupling/Cohesion

Components	4
Dependencies	6

Importance

Changes

Metric	Value
dl	76
loc	667
rs	1.933
c	0
b	0
f	0
wmc	120
lcom	4
cbo	6

36 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	4	1
A	setQueryId()	0	4	1
A	setAction()	0	4	1
A	setPriority()	0	4	1
A	setSubquery()	0	4	1
A	getOrder()	0	4	1
A	setLimit()	0	8	2
A	select()	0	6	1
A	from()	0	5	1
A	where()	0	5	1
A	groupBy()	0	5	1
A	orderBy()	0	5	1
A	limit()	0	5	1
A	getAction()	0	4	1
A	getPriority()	0	4	2
A	usesClickCount()	0	4	1
A	getClickCountColumns()	0	12	4
A	getSelectString()	0	18	4
A	getUpdateString()	0	13	4
A	getInsertString()	0	30	5
A	getTables()	0	4	1
B	getFromString()	0	28	7
B	getWhereString()	0	43	11
A	getGroupByString()	0	12	3
A	getLimit()	0	4	1
A	getLimitString()	0	10	2
A	getFirstTableName()	0	4	1
A	__construct()	0	26	2
A	setColumnList()	0	17	4
A	setColumns()	0	15	5
A	setTables()	0	16	5
B	setConditions()	0	20	7
A	setGroups()	13	13	5
A	setOrder()	13	13	5
A	getOrderByString()	0	18	5
D	getArguments()	50	67	21

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Query often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Query, and based on these observations, apply Extract Interface, too.

<?php
/* Copyright (C) NAVER <http://www.navercorp.com> */

/**
 * @author NAVER ([email protected])
 * @package /classes/db/queryparts
 * @version 0.1
 */
class Query extends BaseObject
{

	/**
	 * Query id, defined in query xml file
	 * @var string
	 */
	var $queryID;

	/**
	 * DML type, ex) INSERT, DELETE, UPDATE, SELECT
	 * @var string
	 */
	var $action;

	/**
	 * priority level ex)LOW_PRIORITY, HIGHT_PRIORITY
	 * @var string
	 */
	var $priority;

	/**
	 * column list
	 * @var string|array
	 */
	var $columns;

	/**
	 * table list
	 * @var string|array
	 */
	var $tables;

	/**
	 * condition list
	 * @var string|array
	 */
	var $conditions;

	/**
	 * group list
	 * @var string|array
	 */
	var $groups;

	/**
	 * order list
	 * @var array
	 */
	var $orderby;

	/**
	 * limit count
	 * @var int
	 */
	var $limit;

	/**
	 * argument list
	 * @var array
	 */
	var $arguments = NULL;

	/**
	 * column list
	 * @var array
	 */
	var $columnList = NULL;

	/**
	 * order by text
	 * @var string
	 */
	var $_orderByString;

	/**
	 * constructor
	 * @param string $queryID
	 * @param string $action
	 * @param string|array $columns
	 * @param string|array $tables
	 * @param string|array $conditions
	 * @param string|array $groups
	 * @param string|array $orderby
	 * @param int $limit
	 * @param string $priority
	 * @return void

	 */
	function __construct($queryID = NULL
	, $action = NULL
	, $columns = NULL
	, $tables = NULL
	, $conditions = NULL
	, $groups = NULL
	, $orderby = NULL
	, $limit = NULL
	, $priority = NULL)
	{
		$this->queryID = $queryID;
		$this->action = $action;
		$this->priority = $priority;

		if(!isset($tables))
		{
			return;
		}

		$this->columns = $this->setColumns($columns);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
		$this->tables = $this->setTables($tables);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
		$this->conditions = $this->setConditions($conditions);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
		$this->groups = $this->setGroups($groups);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
		$this->orderby = $this->setOrder($orderby);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
		$this->limit = $this->setLimit($limit);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
	}

	function show()
	{
		return TRUE;
	}

	function setQueryId($queryID)
	{
		$this->queryID = $queryID;
	}

	function setAction($action)
	{
		$this->action = $action;
	}

	function setPriority($priority)
	{
		$this->priority = $priority;
	}

	function setColumnList($columnList)
	{
		$this->columnList = $columnList;
		if(is_array($this->columnList) && count($this->columnList) > 0)
		{
			$selectColumns = array();
			$dbParser = DB::getParser();

			foreach($this->columnList as $columnName)
			{
				$columnName = $dbParser->escapeColumn($columnName);
				$selectColumns[] = new SelectExpression($columnName);
			}
			unset($this->columns);
			$this->columns = $selectColumns;
		}
	}

	function setColumns($columns)
	{
		if(!isset($columns) || (is_array($columns) && count($columns) === 0))
		{
			$this->columns = array(new StarExpression());
			return;
		}

		if(!is_array($columns))
		{
			$columns = array($columns);
		}

		$this->columns = $columns;
	}

	function setTables($tables)
	{
		if(!isset($tables) || (is_array($tables) && count($tables) === 0))
		{
			$this->setError(TRUE);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$this->setMessage("You must provide at least one table for the query.");
			return;
		}

		if(!is_array($tables))
		{
			$tables = array($tables);
		}

		$this->tables = $tables;
	}

	function setSubquery($subquery)
	{
		$this->subquery = $subquery;
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	function setConditions($conditions)
	{
		$this->conditions = array();
		if(!isset($conditions) || (is_array($conditions) && count($conditions) === 0))
		{
			return;
		}
		if(!is_array($conditions))
		{
			$conditions = array($conditions);
		}

		foreach($conditions as $conditionGroup)
		{
			if($conditionGroup->show())
			{
				$this->conditions[] = $conditionGroup;
			}
		}
	}

	function setGroups($groups)

	{
		if(!isset($groups) || (is_array($groups) && count($groups) === 0))
		{
			return;
		}
		if(!is_array($groups))
		{
			$groups = array($groups);
		}

		$this->groups = $groups;
	}

	function setOrder($order)

	{
		if(!isset($order) || (is_array($order) && count($order) === 0))
		{
			return;
		}
		if(!is_array($order))
		{
			$order = array($order);
		}

		$this->orderby = $order;
	}

	function getOrder()
	{
		return $this->orderby;
	}

	function setLimit($limit = NULL)
	{
		if(!isset($limit))
		{
			return;
		}
		$this->limit = $limit;
	}

	// START Fluent interface
	/**
	 * seleect set
	 * @param string|array $columns
	 * @return Query return Query instance
	 */
	function select($columns = NULL)
	{
		$this->action = 'select';
		$this->setColumns($columns);
		return $this;
	}

	/**
	 * from set
	 * @param string|array $tables
	 * @return Query return Query instance
	 */
	function from($tables)
	{
		$this->setTables($tables);
		return $this;
	}

	/**
	 * where set
	 * @param string|array $conditions
	 * @return Query return Query instance
	 */
	function where($conditions)
	{
		$this->setConditions($conditions);
		return $this;
	}

	/**
	 * groupBy set
	 * @param string|array $groups
	 * @return Query return Query instance
	 */
	function groupBy($groups)
	{
		$this->setGroups($groups);
		return $this;
	}

	/**
	 * orderBy set
	 * @param string|array $order
	 * @return Query return Query instance
	 */
	function orderBy($order)
	{
		$this->setOrder($order);
		return $this;
	}

	/**
	 * limit set
	 * @param int $limit
	 * @return Query return Query instance
	 */
	function limit($limit)
	{
		$this->setLimit($limit);
		return $this;
	}

	// END Fluent interface

	function getAction()
	{
		return $this->action;
	}

	function getPriority()
	{
		return $this->priority ? 'LOW_PRIORITY' : '';
	}

	/**
	 * Check if current query uses the click count attribute
	 * For CUBRID, this statement uses the click count feature.
	 * For the other databases, using this attribute causes a query
	 * to produce both a select and an update
	 */
	function usesClickCount()
	{
		return count($this->getClickCountColumns()) > 0;
	}

	function getClickCountColumns()
	{
		$click_count_columns = array();
		foreach($this->columns as $column)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
		{
			if($column->show() && is_a($column, 'ClickCountExpression'))
			{
				$click_count_columns[] = $column;
			}
		}
		return $click_count_columns;
	}

	/**
	 * Return select sql
	 * @param boolean $with_values
	 * @return string
	 */
	function getSelectString($with_values = TRUE)
	{
		foreach($this->columns as $column)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
		{
			if($column->show())
			{
				if($column->isSubquery())
				{
					$select[] = $column->toString($with_values) . ' as ' . $column->getAlias();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
				}
				else
				{
					$select[] = $column->getExpression($with_values);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
				}
			}
		}
		return trim(implode($select, ', '));
	}

	/**
	 * Return update sql
	 * @param boolean $with_values
	 * @return string
	 */
	function getUpdateString($with_values = TRUE)
	{
		foreach($this->columns as $column)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
		{
			if($column->show())
			{
				$update[] = $column->getExpression($with_values);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			}
		}

		if(!$update) return;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		return trim(implode($update, ', '));
	}

	/**
	 * Return insert sql
	 * @param boolean $with_values
	 * @return string
	 */
	function getInsertString($with_values = TRUE)
	{
		$columnsList = '';
		// means we have insert-select
		if($this->subquery)
		{
			foreach($this->columns as $column)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
			{
				$columnsList .= $column->getColumnName() . ', ';
			}
			$columnsList = substr($columnsList, 0, -2);
			$selectStatement = $this->subquery->toString($with_values);
			$selectStatement = substr($selectStatement, 1, -1);
			return "($columnsList) \n $selectStatement";
		}

		$valuesList = '';
		foreach($this->columns as $column)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
		{
			if($column->show())
			{
				$columnsList .= $column->getColumnName() . ', ';
				$valuesList .= $column->getValue($with_values) . ', ';
			}
		}
		$columnsList = substr($columnsList, 0, -2);
		$valuesList = substr($valuesList, 0, -2);

		return "($columnsList) \n VALUES ($valuesList)";
	}

	function getTables()
	{
		return $this->tables;
	}

	/**
	 * from table_a
	 * from table_a inner join table_b on x=y
	 * from (select * from table a) as x
	 * from (select * from table t) as x inner join table y on y.x
	 * @param boolean $with_values
	 * @return string
	 */
	function getFromString($with_values = TRUE)
	{
		$from = '';
		$simple_table_count = 0;
		foreach($this->tables as $table)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
		{
			if($table->isJoinTable() || !$simple_table_count)
			{
				$from .= $table->toString($with_values) . ' ';
			}
			else
			{
				$from .= ', ' . $table->toString($with_values) . ' ';
			}

			if(is_a($table, 'Subquery'))
			{
				$from .= $table->getAlias() ? ' as ' . $table->getAlias() . ' ' : ' ';
			}

			$simple_table_count++;
		}
		if(trim($from) == '')
		{
			return '';
		}
		return $from;
	}

	/**
	 * Return where sql
	 * @param boolean $with_values
	 * @param boolean $with_optimization
	 * @return string
	 */
	function getWhereString($with_values = TRUE, $with_optimization = TRUE)
	{
		$where = '';
		$condition_count = 0;

		foreach($this->conditions as $conditionGroup)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
		{
			if($condition_count === 0)
			{
				$conditionGroup->setPipe("");
			}
			$condition_string = $conditionGroup->toString($with_values);
			$where .= $condition_string;
			$condition_count++;
		}

		if($with_optimization &&
				(strstr($this->getOrderByString(), 'list_order') || strstr($this->getOrderByString(), 'update_order')))
		{

			if($condition_count !== 0)
			{
				$where = '(' . $where . ') ';
			}

			foreach($this->orderby as $order)
			{
				$colName = $order->getColumnName();
				if(strstr($colName, 'list_order') || strstr($colName, 'update_order'))
				{
					$opt_condition = new ConditionWithoutArgument($colName, 2100000000, 'less', 'and');
					if($condition_count === 0)
					{
						$opt_condition->setPipe("");
					}
					$where .= $opt_condition->toString($with_values) . ' ';
					$condition_count++;
				}
			}
		}

		return trim($where);
	}

	/**
	 * Return groupby sql
	 * @return string
	 */
	function getGroupByString()
	{
		$groupBy = '';
		if($this->groups)
		{
			if($this->groups[0] !== "")
			{
				$groupBy = implode(', ', $this->groups);
			}
		}
		return $groupBy;
	}

	/**
	 * Return orderby sql
	 * @return string
	 */
	function getOrderByString()
	{
		if(!$this->_orderByString)
		{
			if(!is_array($this->orderby) || count($this->orderby) === 0)
			{
				return '';
			}
			$orderBy = '';
			foreach($this->orderby as $order)
			{
				$orderBy .= $order->toString() . ', ';
			}
			$orderBy = substr($orderBy, 0, -2);
			$this->_orderByString = $orderBy;
		}
		return $this->_orderByString;
	}

	function getLimit()
	{
		return $this->limit;
	}

	/**
	 * Return limit sql
	 * @return string
	 */
	function getLimitString()
	{
		$limit = '';
		if($this->limit)
		{
			$limit = '';
			$limit .= $this->limit->toString();

		}
		return $limit;
	}

	function getFirstTableName()
	{
		return $this->tables[0]->getName();
	}

	/**
	 * Return argument list
	 * @return array
	 */
	function getArguments()
	{
		if(!isset($this->arguments))
		{
			$this->arguments = array();

			// Join table arguments
			if(is_array($this->tables) && count($this->tables) > 0)
			{
				foreach($this->tables as $table)
				{
					if($table->isJoinTable() || is_a($table, 'Subquery'))
					{
						$args = $table->getArguments();
						if($args)
						{
							$this->arguments = array_merge($this->arguments, $args);
						}
					}
				}
			}

			// Column arguments
			// The if is for delete statements, all others must have columns
			if(is_array($this->columns) && count($this->columns) > 0)
			{
				foreach($this->columns as $column)
				{
					if($column->show())
					{
						$args = $column->getArguments();
						if($args)
						{
							$this->arguments = array_merge($this->arguments, $args);
						}
					}
				}
			}

			// Condition arguments
			if(is_array($this->conditions) && count($this->conditions) > 0)
			{
				foreach($this->conditions as $conditionGroup)
				{
					$args = $conditionGroup->getArguments();
					if(count($args) > 0)
					{
						$this->arguments = array_merge($this->arguments, $args);
					}
				}
			}

			// Navigation arguments
			if(is_array($this->orderby) && count($this->orderby) > 0)
			{
				foreach($this->orderby as $order)
				{
					$args = $order->getArguments();
					if(count($args) > 0)
					{
						$this->arguments = array_merge($this->arguments, $args);
					}
				}
			}
		}
		return $this->arguments;
	}

}
/* End of file Query.class.php */
/* Location: ./classes/db/queryparts/Query.class.php */


GitHub Access Token became invalid

Pull Request — develop (#2377)

Query F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

36 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

1			<?php
2			/* Copyright (C) NAVER <http://www.navercorp.com> */
3
4			/**
5			* @author NAVER ([email protected])
6			* @package /classes/db/queryparts
7			* @version 0.1
8			*/
9			class Query extends BaseObject
10			{
11
12			/**
13			* Query id, defined in query xml file
14			* @var string
15			*/
16			var $queryID;
17
18			/**
19			* DML type, ex) INSERT, DELETE, UPDATE, SELECT
20			* @var string
21			*/
22			var $action;
23
24			/**
25			* priority level ex)LOW_PRIORITY, HIGHT_PRIORITY
26			* @var string
27			*/
28			var $priority;
29
30			/**
31			* column list
32			* @var string\|array
33			*/
34			var $columns;
35
36			/**
37			* table list
38			* @var string\|array
39			*/
40			var $tables;

xpressengine / xe-core

GitHub Access Token became invalid

Pull Request — develop (#2377)

Query F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

36 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like