xpressengine / xe-core

classes/cache/CacheWincache.class.php

Spacing +6 added lines, -6 removed lines

@@ -20,7 +20,7 @@ 
 	 */
 	function getInstance($opt = null)
 	{
-		if(!$GLOBALS['__CacheWincache__'])
+		if (!$GLOBALS['__CacheWincache__'])
 		{
 			$GLOBALS['__CacheWincache__'] = new CacheWincache();
 		}
@@ -59,7 +59,7 @@ 
 	 */
 	function put($key, $buff, $valid_time = 0)
 	{
-		if($valid_time == 0)
+		if ($valid_time == 0)
 		{
 			$valid_time = $this->valid_time;
 		}
@@ -78,13 +78,13 @@ 
 	{
 		$_key = md5(_XE_PATH_ . $key);
 		$obj = wincache_ucache_get($_key, $success);
-		if(!$success || !is_array($obj))
+		if (!$success || !is_array($obj))
 		{
 			return false;
 		}
 		unset($obj[1]);
 
-		if($modified_time > 0 && $modified_time > $obj[0])
+		if ($modified_time > 0 && $modified_time > $obj[0])
 		{
 			$this->_delete($_key);
 			return false;
@@ -105,12 +105,12 @@ 
 	{
 		$_key = md5(_XE_PATH_ . $key);
 		$obj = wincache_ucache_get($_key, $success);
-		if(!$success || !is_array($obj))
+		if (!$success || !is_array($obj))
 		{
 			return false;
 		}
 
-		if($modified_time > 0 && $modified_time > $obj[0])
+		if ($modified_time > 0 && $modified_time > $obj[0])
 		{
 			$this->_delete($_key);
 			return false;

classes/db/DBMysqli.class.php

Spacing +35 added lines, -35 removed lines

@@ -44,7 +44,7 @@ 
 	function __connect($connection)
 	{
 		// Attempt to connect
-		if($connection["db_port"])
+		if ($connection["db_port"])
 		{
 			$result = @mysqli_connect($connection["db_hostname"]
 							, $connection["db_userid"]
@@ -60,7 +60,7 @@ 
 							, $connection["db_database"]);
 		}
 		$error = mysqli_connect_errno();
-		if($error)
+		if ($error)
 		{
 			$this->setError($error, mysqli_connect_error());
 			return;
@@ -87,11 +87,11 @@ 
 	 */
 	function addQuotes($string)
 	{
-		if(version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
+		if (version_compare(PHP_VERSION, "5.4.0", "<") && get_magic_quotes_gpc())
 		{
 			$string = stripslashes(str_replace("\\", "\\\\", $string));
 		}
-		if(!is_numeric($string))
+		if (!is_numeric($string))
 		{
 			$connection = $this->_getConnection('master');
 			$string = mysqli_escape_string($connection, $string);
@@ -108,23 +108,23 @@ 
 	 */
 	function __query($query, $connection)
 	{
-		if($this->use_prepared_statements == 'Y')
+		if ($this->use_prepared_statements == 'Y')
 		{
 			// 1. Prepare query
 			$stmt = mysqli_prepare($connection, $query);
-			if($stmt)
+			if ($stmt)
 			{
 				$types = '';
 				$params = array();
 				$this->_prepareQueryParameters($types, $params);
 
-				if(!empty($params))
+				if (!empty($params))
 				{
 					$args[0] = $stmt;
 					$args[1] = $types;
 
 					$i = 2;
-					foreach($params as $key => $param)
+					foreach ($params as $key => $param)
 					{
 						$copy[$key] = $param;
 						$args[$i++] = &$copy[$key];
@@ -132,7 +132,7 @@ 
 
 					// 2. Bind parameters
 					$status = call_user_func_array('mysqli_stmt_bind_param', $args);
-					if(!$status)
+					if (!$status)
 					{
 						$this->setError(-1, "Invalid arguments: $query" . mysqli_error($connection) . PHP_EOL . print_r($args, true));
 					}
@@ -141,7 +141,7 @@ 
 				// 3. Execute query
 				$status = mysqli_stmt_execute($stmt);
 
-				if(!$status)
+				if (!$status)
 				{
 					$this->setError(-1, "Prepared statement failed: $query" . mysqli_error($connection) . PHP_EOL . print_r($args, true));
 				}
@@ -155,7 +155,7 @@ 
 		$result = mysqli_query($connection, $query);
 		// Error Check
 		$error = mysqli_error($connection);
-		if($error)
+		if ($error)
 		{
 			$this->setError(mysqli_errno($connection), $error);
 		}
@@ -174,23 +174,23 @@ 
 	{
 		$types = '';
 		$params = array();
-		if(!$this->param)
+		if (!$this->param)
 		{
 			return;
 		}
 
-		foreach($this->param as $k => $o)
+		foreach ($this->param as $k => $o)
 		{
 			$value = $o->getUnescapedValue();
 			$type = $o->getType();
 
 			// Skip column names -> this should be concatenated to query string
-			if($o->isColumnName())
+			if ($o->isColumnName())
 			{
 				continue;
 			}
 
-			switch($type)
+			switch ($type)
 			{
 				case 'number' :
 					$type = 'i';
@@ -202,9 +202,9 @@ 
 					$type = 's';
 			}
 
-			if(is_array($value))
+			if (is_array($value))
 			{
-				foreach($value as $v)
+				foreach ($value as $v)
 				{
 					$params[] = $v;
 					$types .= $type;
@@ -226,12 +226,12 @@ 
 	 */
 	function _fetch($result, $arrayIndexEndValue = NULL)
 	{
-		if($this->use_prepared_statements != 'Y')
+		if ($this->use_prepared_statements != 'Y')
 		{
 			return parent::_fetch($result, $arrayIndexEndValue);
 		}
 		$output = array();
-		if(!$this->isConnected() || $this->isError() || !$result)
+		if (!$this->isConnected() || $this->isError() || !$result)
 		{
 			return $output;
 		}
@@ -247,9 +247,9 @@ 
 		 * MYSQLI_TYPE for longtext is 252
 		 */
 		$longtext_exists = false;
-		foreach($fields as $field)
+		foreach ($fields as $field)
 		{
-			if(isset($resultArray[$field->name])) // When joined tables are used and the same column name appears twice, we should add it separately, otherwise bind_result fails
+			if (isset($resultArray[$field->name])) // When joined tables are used and the same column name appears twice, we should add it separately, otherwise bind_result fails
 			{
 				$field->name = 'repeat_' . $field->name;
 			}
@@ -258,14 +258,14 @@ 
 			$row[$field->name] = "";
 			$resultArray[$field->name] = &$row[$field->name];
 
-			if($field->type == 252)
+			if ($field->type == 252)
 			{
 				$longtext_exists = true;
 			}
 		}
 		$resultArray = array_merge(array($stmt), $resultArray);
 
-		if($longtext_exists)
+		if ($longtext_exists)
 		{
 			mysqli_stmt_store_result($stmt);
 		}
@@ -273,17 +273,17 @@ 
 		call_user_func_array('mysqli_stmt_bind_result', $resultArray);
 
 		$rows = array();
-		while(mysqli_stmt_fetch($stmt))
+		while (mysqli_stmt_fetch($stmt))
 		{
 			$resultObject = new stdClass();
 
-			foreach($resultArray as $key => $value)
+			foreach ($resultArray as $key => $value)
 			{
-				if($key === 0)
+				if ($key === 0)
 				{
 					continue; // Skip stmt object
 				}
-				if(strpos($key, 'repeat_'))
+				if (strpos($key, 'repeat_'))
 				{
 					$key = substr($key, 6);
 				}
@@ -295,9 +295,9 @@ 
 
 		mysqli_stmt_close($stmt);
 
-		if($arrayIndexEndValue)
+		if ($arrayIndexEndValue)
 		{
-			foreach($rows as $row)
+			foreach ($rows as $row)
 			{
 				$output[$arrayIndexEndValue--] = $row;
 			}
@@ -307,9 +307,9 @@ 
 			$output = $rows;
 		}
 
-		if(count($output) == 1)
+		if (count($output) == 1)
 		{
-			if(isset($arrayIndexEndValue))
+			if (isset($arrayIndexEndValue))
 			{
 				return $output;
 			}
@@ -330,7 +330,7 @@ 
 	 */
 	function _executeInsertAct($queryObject, $with_values = false)
 	{
-		if($this->use_prepared_statements != 'Y')
+		if ($this->use_prepared_statements != 'Y')
 		{
 			return parent::_executeInsertAct($queryObject);
 		}
@@ -348,7 +348,7 @@ 
 	 */
 	function _executeUpdateAct($queryObject, $with_values = false)
 	{
-		if($this->use_prepared_statements != 'Y')
+		if ($this->use_prepared_statements != 'Y')
 		{
 			return parent::_executeUpdateAct($queryObject);
 		}
@@ -366,7 +366,7 @@ 
 	 */
 	function _executeDeleteAct($queryObject, $with_values = false)
 	{
-		if($this->use_prepared_statements != 'Y')
+		if ($this->use_prepared_statements != 'Y')
 		{
 			return parent::_executeDeleteAct($queryObject);
 		}
@@ -387,7 +387,7 @@ 
 	 */
 	function _executeSelectAct($queryObject, $connection = null, $with_values = false)
 	{
-		if($this->use_prepared_statements != 'Y')
+		if ($this->use_prepared_statements != 'Y')
 		{
 			return parent::_executeSelectAct($queryObject, $connection);
 		}

Braces +7 added lines, -9 removed lines

@@ -51,8 +51,7 @@ 
 							, $connection["db_password"]
 							, $connection["db_database"]
 							, $connection["db_port"]);
-		}
-		else
+		} else
 		{
 			$result = @mysqli_connect($connection["db_hostname"]
 							, $connection["db_userid"]
@@ -209,8 +208,7 @@ 
 					$params[] = $v;
 					$types .= $type;
 				}
-			}
-			else
+			} else
 			{
 				$params[] = $value;
 				$types .= $type;
@@ -249,10 +247,12 @@ 
 		$longtext_exists = false;
 		foreach($fields as $field)
 		{
-			if(isset($resultArray[$field->name])) // When joined tables are used and the same column name appears twice, we should add it separately, otherwise bind_result fails
+			if(isset($resultArray[$field->name])) {
+				// When joined tables are used and the same column name appears twice, we should add it separately, otherwise bind_result fails
 			{
 				$field->name = 'repeat_' . $field->name;
 			}
+			}
 
 			// Array passed needs to contain references, not values
 			$row[$field->name] = "";
@@ -301,8 +301,7 @@ 
 			{
 				$output[$arrayIndexEndValue--] = $row;
 			}
-		}
-		else
+		} else
 		{
 			$output = $rows;
 		}
@@ -312,8 +311,7 @@ 
 			if(isset($arrayIndexEndValue))
 			{
 				return $output;
-			}
-			else
+			} else
 			{
 				return $output[0];
 			}

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 	/**
 	 * Search Result
 	 *
-	 * @return Object
+	 * @return Object|null
 	 */
 	function IS()
 	{

classes/db/queryparts/Subquery.class.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
 

 	function isJoinTable()

 	{

-		if($this->join_type)

+		if ($this->join_type)

 		{

 			return true;

 		}

classes/db/queryparts/condition/ConditionGroup.class.php

Spacing +10 added lines, -10 removed lines

@@ -32,14 +32,14 @@ 
 	function ConditionGroup($conditions, $pipe = "")

 	{

 		$this->conditions = array();

-		foreach($conditions as $condition)

+		foreach ($conditions as $condition)

 		{

-			if($condition->show())

+			if ($condition->show())

 			{

 				$this->conditions[] = $condition;

 			}

 		}

-		if(count($this->conditions) === 0)

+		if (count($this->conditions) === 0)

 		{

 			$this->_show = false;

 		}

@@ -58,7 +58,7 @@ 
 

 	function setPipe($pipe)

 	{

-		if($this->pipe !== $pipe)

+		if ($this->pipe !== $pipe)

 		{

 			$this->_group = null;

 		}

@@ -72,14 +72,14 @@ 
 	 */

 	function toString($with_value = true)

 	{

-		if(!isset($this->_group))

+		if (!isset($this->_group))

 		{

 			$cond_indx = 0;

 			$group = '';

 

-			foreach($this->conditions as $condition)

+			foreach ($this->conditions as $condition)

 			{

-				if($cond_indx === 0)

+				if ($cond_indx === 0)

 				{

 					$condition->setPipe("");

 				}

@@ -87,7 +87,7 @@ 
 				$cond_indx++;

 			}

 

-			if($this->pipe !== "" && trim($group) !== '')

+			if ($this->pipe !== "" && trim($group) !== '')

 			{

 				$group = $this->pipe . ' (' . $group . ')';

 			}

@@ -104,10 +104,10 @@ 
 	function getArguments()

 	{

 		$args = array();

-		foreach($this->conditions as $condition)

+		foreach ($this->conditions as $condition)

 		{

 			$arg = $condition->getArgument();

-			if($arg)

+			if ($arg)

 			{

 				$args[] = $arg;

 			}

Braces +1 added lines, -2 removed lines

@@ -111,8 +111,7 @@
 		if($this->limit)

 		{

 			return $this->limit->toString();

-		}

-		else

+		} else

 		{

 			return "";

 		}

classes/db/queryparts/condition/ConditionWithArgument.class.php

Spacing +10 added lines, -10 removed lines

@@ -19,7 +19,7 @@ 
 	 */

 	function ConditionWithArgument($column_name, $argument, $operation, $pipe = "")

 	{

-		if($argument === null)

+		if ($argument === null)

 		{

 			$this->_show = false;

 			return;

@@ -30,7 +30,7 @@ 
 

 	function getArgument()

 	{

-		if(!$this->show())

+		if (!$this->show())

 			return;

 		return $this->argument;

 	}

@@ -43,14 +43,14 @@ 
 	{

 		$value = $this->argument->getUnescapedValue();

 

-		if(is_array($value))

+		if (is_array($value))

 		{

 			$q = '';

-			foreach($value as $v)

+			foreach ($value as $v)

 			{

 				$q .= '?,';

 			}

-			if($q !== '')

+			if ($q !== '')

 			{

 				$q = substr($q, 0, -1);

 			}

@@ -59,7 +59,7 @@ 
 		else

 		{

 			// Prepared statements: column names should not be sent as query arguments, but instead concatenated to query string

-			if($this->argument->isColumnName())

+			if ($this->argument->isColumnName())

 			{

 				$q = $value;

 			}

@@ -76,17 +76,17 @@ 
 	 */

 	function show()

 	{

-		if(!isset($this->_show))

+		if (!isset($this->_show))

 		{

-			if(!$this->argument->isValid())

+			if (!$this->argument->isValid())

 			{

 				$this->_show = false;

 			}

-			if($this->_value === '\'\'')

+			if ($this->_value === '\'\'')

 			{

 				$this->_show = false;

 			}

-			if(!isset($this->_show))

+			if (!isset($this->_show))

 			{

 				return parent::show();

 			}

Braces +5 added lines, -6 removed lines

@@ -30,8 +30,9 @@ 
 

 	function getArgument()

 	{

-		if(!$this->show())

-			return;

+		if(!$this->show()) {
+					return;
+		}
 		return $this->argument;

 	}

 

@@ -55,15 +56,13 @@ 
 				$q = substr($q, 0, -1);

 			}

 			$q = '(' . $q . ')';

-		}

-		else

+		} else

 		{

 			// Prepared statements: column names should not be sent as query arguments, but instead concatenated to query string

 			if($this->argument->isColumnName())

 			{

 				$q = $value;

-			}

-			else

+			} else

 			{

 				$q = '?';

 			}

classes/db/queryparts/expression/ClickCountExpression.class.php

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
 	{

 		parent::SelectExpression($column_name, $alias);

 

-		if(!is_bool($click_count))

+		if (!is_bool($click_count))

 		{

 			// error_log("Click_count value for $column_name was not boolean", 0);

 			$this->click_count = false;

@@ -47,7 +47,7 @@ 
 	function getExpression()

 	{

 		$db_type = Context::getDBType();

-		if($db_type == 'cubrid')

+		if ($db_type == 'cubrid')

 		{

 			return "INCR($this->column_name)";

 		}

Braces +1 added lines, -2 removed lines

@@ -111,8 +111,7 @@
 		if($this->limit)

 		{

 			return $this->limit->toString();

-		}

-		else

+		} else

 		{

 			return "";

 		}

classes/db/queryparts/expression/DeleteExpression.class.php

Spacing +2 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
 	function getValue()

 	{

 		// TODO Escape value according to column type instead of variable type

-		if(!is_numeric($this->value))

+		if (!is_numeric($this->value))

 		{

 			return "'" . $this->value . "'";

 		}

@@ -51,7 +51,7 @@ 
 

 	function show()

 	{

-		if(!$this->value)

+		if (!$this->value)

 		{

 			return false;

 		}

classes/db/queryparts/expression/InsertExpression.class.php

Spacing +4 added lines, -4 removed lines

@@ -31,7 +31,7 @@ 
 

 	function getValue($with_values = true)

 	{

-		if($with_values)

+		if ($with_values)

 		{

 			return $this->argument->getValue();

 		}

@@ -40,12 +40,12 @@ 
 

 	function show()

 	{

-		if(!$this->argument)

+		if (!$this->argument)

 		{

 			return false;

 		}

 		$value = $this->argument->getValue();

-		if(!isset($value))

+		if (!isset($value))

 		{

 			return false;

 		}

@@ -59,7 +59,7 @@ 
 

 	function getArguments()

 	{

-		if($this->argument)

+		if ($this->argument)

 		{

 			return array($this->argument);

 		}

Braces +1 added lines, -2 removed lines

@@ -111,8 +111,7 @@
 		if($this->limit)

 		{

 			return $this->limit->toString();

-		}

-		else

+		} else

 		{

 			return "";

 		}

classes/db/queryparts/expression/UpdateExpressionWithoutArgument.class.php

Spacing +3 added lines, -3 removed lines

@@ -38,7 +38,7 @@ 
 	{

 		// TODO Escape value according to column type instead of variable type

 		$value = $this->argument;

-		if(!is_numeric($value))

+		if (!is_numeric($value))

 		{

 			return "'" . $value . "'";

 		}

@@ -47,12 +47,12 @@ 
 

 	function show()

 	{

-		if(!$this->argument)

+		if (!$this->argument)

 		{

 			return false;

 		}

 		$value = $this->argument;

-		if(!isset($value))

+		if (!isset($value))

 		{

 			return false;

 		}