xpressengine /
xe-core
| Conditions | 9 |
| Paths | 36 |
| Total Lines | 70 |
| Code Lines | 44 |
| Lines | 9 |
| Ratio | 12.86 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 4 | function procSeoAdminSaveSetting() |
||
| 5 | { |
||
| 6 | $oModuleController = getController('module'); |
||
| 7 | |||
| 8 | $vars = Context::getRequestVars(); |
||
| 9 | $config = $this->getConfig(); |
||
| 10 | |||
| 11 | if ($vars->setting_section == 'general') { |
||
| 12 | // 기본 설정 |
||
| 13 | $config->enable = ($vars->enable === 'Y') ? 'Y' : 'N'; |
||
|
|
|||
| 14 | $config->use_optimize_title = $vars->use_optimize_title; |
||
| 15 | $config->site_name = $vars->site_name; |
||
| 16 | $config->site_slogan = $vars->site_slogan; |
||
| 17 | $config->site_description = $vars->site_description; |
||
| 18 | $config->site_keywords = $vars->site_keywords; |
||
| 19 | |||
| 20 | if ($vars->site_image) { |
||
| 21 | $path = _XE_PATH_ . 'files/attach/site_image/'; |
||
| 22 | $ext = strtolower(array_pop(explode('.', $vars->site_image['name']))); |
||
| 23 | $timestamp = time(); |
||
| 24 | $filename = "site_image.{$timestamp}.{$ext}"; |
||
| 25 | FileHandler::copyFile($vars->site_image['tmp_name'], $path . $filename); |
||
| 26 | $config->site_image = $filename; |
||
| 27 | |||
| 28 | $oCacheHandler = CacheHandler::getInstance('object', NULL, TRUE); |
||
| 29 | View Code Duplication | if($oCacheHandler->isSupport()) { |
|
| 30 | list($width, $height) = @getimagesize($path . $filename); |
||
| 31 | $site_image_dimension = array( |
||
| 32 | 'width' => $width, |
||
| 33 | 'height' => $height |
||
| 34 | ); |
||
| 35 | $cache_key = 'seo:site_image'; |
||
| 36 | $oCacheHandler->put($cache_key, $site_image_dimension); |
||
| 37 | } |
||
| 38 | } |
||
| 39 | } elseif ($vars->setting_section == 'analytics') { |
||
| 40 | // analytics |
||
| 41 | |||
| 42 | |||
| 43 | $config->ga_id = trim($vars->ga_id); |
||
| 44 | $config->ga_except_admin = $vars->ga_except_admin; |
||
| 45 | |||
| 46 | // Naver |
||
| 47 | $config->na_id = trim($vars->na_id); |
||
| 48 | $config->na_except_admin = $vars->na_except_admin; |
||
| 49 | } elseif ($vars->setting_section == 'miscellaneous') { |
||
| 50 | // miscellaneous |
||
| 51 | |||
| 52 | |||
| 53 | $config->fb_app_id = trim($vars->fb_app_id); |
||
| 54 | $config->fb_admins = trim($vars->fb_admins); |
||
| 55 | } |
||
| 56 | |||
| 57 | $config->site_image_url = NULL; |
||
| 58 | |||
| 59 | $oModuleController->updateModuleConfig('seo', $config); |
||
| 60 | |||
| 61 | if($config->enable === 'Y') { |
||
| 62 | $this->moduleUpdate(); |
||
| 63 | } else { |
||
| 64 | // Delete Triggers |
||
| 65 | $oModuleController = getController('module'); |
||
| 66 | $oModuleController->deleteModuleTriggers('seo'); |
||
| 67 | } |
||
| 68 | |||
| 69 | $this->setMessage('success_updated'); |
||
| 70 | if (Context::get('success_return_url')) { |
||
| 71 | $this->setRedirectUrl(Context::get('success_return_url')); |
||
| 72 | } |
||
| 73 | } |
||
| 74 | } |
||
| 76 |
Loading history...
An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.
If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.