xpressengine / xe-core

classes/editor/EditorHandler.class.php

Spacing +2 added lines, -2 removed lines

@@ -20,12 +20,12 @@
 	{
 		Context::set('component_info', $info);
 
-		if(!$info->extra_vars)
+		if (!$info->extra_vars)
 		{
 			return;
 		}
 
-		foreach($info->extra_vars as $key => $val)
+		foreach ($info->extra_vars as $key => $val)
 		{
 			$this->{$key} = trim($val->value);
 		}

classes/extravar/Extravar.class.php

Spacing +48 added lines, -48 removed lines

@@ -51,12 +51,12 @@ 
 	 */
 	function setExtraVarKeys($extra_keys)
 	{
-		if(!is_array($extra_keys) || count($extra_keys) < 1)
+		if (!is_array($extra_keys) || count($extra_keys) < 1)
 		{
 			return;
 		}
 
-		foreach($extra_keys as $val)
+		foreach ($extra_keys as $val)
 		{
 			$obj = new ExtraItem($val->module_srl, $val->idx, $val->name, $val->type, $val->default, $val->desc, $val->is_required, $val->search, $val->value, $val->eid);
 			$this->keys[$val->idx] = $obj;
@@ -159,7 +159,7 @@ 
 	 */
 	function ExtraItem($module_srl, $idx, $name, $type = 'text', $default = null, $desc = '', $is_required = 'N', $search = 'N', $value = null, $eid = '')
 	{
-		if(!$idx)
+		if (!$idx)
 		{
 			return;
 		}
@@ -197,36 +197,36 @@ 
 	function _getTypeValue($type, $value)
 	{
 		$value = trim($value);
-		if(!isset($value))
+		if (!isset($value))
 		{
 			return;
 		}
 
-		switch($type)
+		switch ($type)
 		{
 			case 'homepage' :
-				if($value && !preg_match('/^([a-z]+):\/\//i', $value))
+				if ($value && !preg_match('/^([a-z]+):\/\//i', $value))
 				{
 					$value = 'http://' . $value;
 				}
 				return htmlspecialchars($value, ENT_COMPAT | ENT_HTML401, 'UTF-8', false);
 
 			case 'tel' :
-				if(is_array($value))
+				if (is_array($value))
 				{
 					$values = $value;
 				}
-				elseif(strpos($value, '|@|') !== FALSE)
+				elseif (strpos($value, '|@|') !== FALSE)
 				{
 					$values = explode('|@|', $value);
 				}
-				elseif(strpos($value, ',') !== FALSE)
+				elseif (strpos($value, ',') !== FALSE)
 				{
 					$values = explode(',', $value);
 				}
 
 				$values = array_values($values);
-				for($i = 0, $c = count($values); $i < $c; $i++)
+				for ($i = 0, $c = count($values); $i < $c; $i++)
 				{
 					$values[$i] = trim(htmlspecialchars($values[$i], ENT_COMPAT | ENT_HTML401, 'UTF-8', false));
 				}
@@ -235,15 +235,15 @@ 
 			case 'checkbox' :
 			case 'radio' :
 			case 'select' :
-				if(is_array($value))
+				if (is_array($value))
 				{
 					$values = $value;
 				}
-				elseif(strpos($value, '|@|') !== FALSE)
+				elseif (strpos($value, '|@|') !== FALSE)
 				{
 					$values = explode('|@|', $value);
 				}
-				elseif(strpos($value, ',') !== FALSE)
+				elseif (strpos($value, ',') !== FALSE)
 				{
 					$values = explode(',', $value);
 				}
@@ -253,18 +253,18 @@ 
 				}
 
 				$values = array_values($values);
-				for($i = 0, $c = count($values); $i < $c; $i++)
+				for ($i = 0, $c = count($values); $i < $c; $i++)
 				{
 					$values[$i] = trim(htmlspecialchars($values[$i], ENT_COMPAT | ENT_HTML401, 'UTF-8', false));
 				}
 				return $values;
 
 			case 'kr_zip' :
-				if(is_array($value))
+				if (is_array($value))
 				{
 					$values = $value;
 				}
-				elseif(strpos($value, '|@|') !== false)
+				elseif (strpos($value, '|@|') !== false)
 				{
 					$values = explode('|@|', $value);
 				}
@@ -274,7 +274,7 @@ 
 				}
 
 				$values = array_values($values);
-				for($i = 0, $c = count($values); $i < $c; $i++)
+				for ($i = 0, $c = count($values); $i < $c; $i++)
 				{
 					$values[$i] = trim(htmlspecialchars($values[$i], ENT_COMPAT | ENT_HTML401, 'UTF-8', false));
 				}
@@ -308,7 +308,7 @@ 
 	{
 		$value = $this->_getTypeValue($this->type, $this->value);
 
-		switch($this->type)
+		switch ($this->type)
 		{
 			case 'homepage' :
 				return ($value) ? (sprintf('<a href="%s" target="_blank">%s</a>', $value, strlen($value) > 60 ? substr($value, 0, 40) . '...' . substr($value, -10) : $value)) : "";
@@ -328,14 +328,14 @@ 
 			case 'checkbox' :
 			case 'select' :
 			case 'radio' :
-				if(is_array($value))
+				if (is_array($value))
 				{
 					return implode(',', $value);
 				}
 				return $value;
 
 			case 'kr_zip' :
-				if(is_array($value))
+				if (is_array($value))
 				{
 					return implode(' ', $value);
 				}
@@ -364,7 +364,7 @@ 
 		$tmp_id = $column_name . '-' . $id_num++;
 
 		$buff = array();
-		switch($type)
+		switch ($type)
 		{
 			// Homepage
 			case 'homepage' :
@@ -387,10 +387,10 @@ 
 			// multiple choice
 			case 'checkbox' :
 				$buff[] = '<ul>';
-				foreach($default as $v)
+				foreach ($default as $v)
 				{
 					$checked = '';
-					if($value && in_array(trim($v), $value))
+					if ($value && in_array(trim($v), $value))
 					{
 						$checked = ' checked="checked"';
 					}
@@ -398,17 +398,17 @@ 
 					// Temporary ID for labeling
 					$tmp_id = $column_name . '-' . $id_num++;
 
-					$buff[] ='  <li><input type="checkbox" name="' . $column_name . '[]" id="' . $tmp_id . '" value="' . htmlspecialchars($v, ENT_COMPAT | ENT_HTML401, 'UTF-8', false) . '" ' . $checked . ' /><label for="' . $tmp_id . '">' . $v . '</label></li>';
+					$buff[] = '  <li><input type="checkbox" name="' . $column_name . '[]" id="' . $tmp_id . '" value="' . htmlspecialchars($v, ENT_COMPAT | ENT_HTML401, 'UTF-8', false) . '" ' . $checked . ' /><label for="' . $tmp_id . '">' . $v . '</label></li>';
 				}
 				$buff[] = '</ul>';
 				break;
 			// single choice
 			case 'select' :
 				$buff[] = '<select name="' . $column_name . '" class="select">';
-				foreach($default as $v)
+				foreach ($default as $v)
 				{
 					$selected = '';
-					if($value && in_array(trim($v), $value))
+					if ($value && in_array(trim($v), $value))
 					{
 						$selected = ' selected="selected"';
 					}
@@ -419,10 +419,10 @@ 
 			// radio
 			case 'radio' :
 				$buff[] = '<ul>';
-				foreach($default as $v)
+				foreach ($default as $v)
 				{
 					$checked = '';
-					if($value && in_array(trim($v), $value))
+					if ($value && in_array(trim($v), $value))
 					{
 						$checked = ' checked="checked"';
 					}
@@ -440,38 +440,38 @@ 
 				Context::loadJavascriptPlugin('ui.datepicker');
 
 				$buff[] = '<input type="hidden" name="' . $column_name . '" value="' . $value . '" />'; 
-				$buff[] =	'<input type="text" id="date_' . $column_name . '" value="' . zdate($value, 'Y-m-d') . '" class="date" />';
-				$buff[] =	'<input type="button" value="' . Context::getLang('cmd_delete') . '" class="btn" id="dateRemover_' . $column_name . '" />';
-				$buff[] =	'<script type="text/javascript">';
+				$buff[] = '<input type="text" id="date_' . $column_name . '" value="' . zdate($value, 'Y-m-d') . '" class="date" />';
+				$buff[] = '<input type="button" value="' . Context::getLang('cmd_delete') . '" class="btn" id="dateRemover_' . $column_name . '" />';
+				$buff[] = '<script type="text/javascript">';
 				$buff[] = '//<![CDATA[';
-				$buff[] =	'(function($){';
-				$buff[] =	'$(function(){';
-				$buff[] =	'  var option = { dateFormat: "yy-mm-dd", changeMonth:true, changeYear:true, gotoCurrent:false, yearRange:\'-100:+10\', onSelect:function(){';
-				$buff[] =	'    $(this).prev(\'input[type="hidden"]\').val(this.value.replace(/-/g,""))}';
-				$buff[] =	'  };';
-				$buff[] =	'  $.extend(option,$.datepicker.regional[\'' . Context::getLangType() . '\']);';
-				$buff[] =	'  $("#date_' . $column_name . '").datepicker(option);';
-				$buff[] =	'  $("#dateRemover_' . $column_name . '").click(function(){';
-				$buff[] =	'    $(this).siblings("input").val("");';
-				$buff[] =	'    return false;';
-				$buff[] =	'  })';
-				$buff[] =	'});';
-				$buff[] =	'})(jQuery);';
+				$buff[] = '(function($){';
+				$buff[] = '$(function(){';
+				$buff[] = '  var option = { dateFormat: "yy-mm-dd", changeMonth:true, changeYear:true, gotoCurrent:false, yearRange:\'-100:+10\', onSelect:function(){';
+				$buff[] = '    $(this).prev(\'input[type="hidden"]\').val(this.value.replace(/-/g,""))}';
+				$buff[] = '  };';
+				$buff[] = '  $.extend(option,$.datepicker.regional[\'' . Context::getLangType() . '\']);';
+				$buff[] = '  $("#date_' . $column_name . '").datepicker(option);';
+				$buff[] = '  $("#dateRemover_' . $column_name . '").click(function(){';
+				$buff[] = '    $(this).siblings("input").val("");';
+				$buff[] = '    return false;';
+				$buff[] = '  })';
+				$buff[] = '});';
+				$buff[] = '})(jQuery);';
 				$buff[] = '//]]>';
 				$buff[] = '</script>';
 				break;
 			// address
 			case "kr_zip" :
-				if(($oKrzipModel = getModel('krzip')) && method_exists($oKrzipModel , 'getKrzipCodeSearchHtml' ))
+				if (($oKrzipModel = getModel('krzip')) && method_exists($oKrzipModel, 'getKrzipCodeSearchHtml'))
 				{
-					$buff[] =  $oKrzipModel->getKrzipCodeSearchHtml($column_name, $value);
+					$buff[] = $oKrzipModel->getKrzipCodeSearchHtml($column_name, $value);
 				}
 				break;
 			// General text
 			default :
-				$buff[] =' <input type="text" name="' . $column_name . '" value="' . ($value ? $value : $default) . '" class="text" />';
+				$buff[] = ' <input type="text" name="' . $column_name . '" value="' . ($value ? $value : $default) . '" class="text" />';
 		}
-		if($this->desc)
+		if ($this->desc)
 		{
 			$oModuleController = getController('module');
 			$oModuleController->replaceDefinedLangCode($this->desc);

Braces +7 added lines, -14 removed lines

@@ -215,12 +215,10 @@ 
 				if(is_array($value))
 				{
 					$values = $value;
-				}
-				elseif(strpos($value, '|@|') !== FALSE)
+				} elseif(strpos($value, '|@|') !== FALSE)
 				{
 					$values = explode('|@|', $value);
-				}
-				elseif(strpos($value, ',') !== FALSE)
+				} elseif(strpos($value, ',') !== FALSE)
 				{
 					$values = explode(',', $value);
 				}
@@ -238,16 +236,13 @@ 
 				if(is_array($value))
 				{
 					$values = $value;
-				}
-				elseif(strpos($value, '|@|') !== FALSE)
+				} elseif(strpos($value, '|@|') !== FALSE)
 				{
 					$values = explode('|@|', $value);
-				}
-				elseif(strpos($value, ',') !== FALSE)
+				} elseif(strpos($value, ',') !== FALSE)
 				{
 					$values = explode(',', $value);
-				}
-				else
+				} else
 				{
 					$values = array($value);
 				}
@@ -263,12 +258,10 @@ 
 				if(is_array($value))
 				{
 					$values = $value;
-				}
-				elseif(strpos($value, '|@|') !== false)
+				} elseif(strpos($value, '|@|') !== false)
 				{
 					$values = explode('|@|', $value);
-				}
-				else
+				} else
 				{
 					$values = array($value);
 				}

classes/file/FileObject.class.php

Spacing +8 added lines, -8 removed lines

@@ -36,7 +36,7 @@ 
 	 */
 	function FileObject($path, $mode)
 	{
-		if($path != NULL)
+		if ($path != NULL)
 		{
 			$this->Open($path, $mode);
 		}
@@ -51,7 +51,7 @@ 
 	function append($file_name)
 	{
 		$target = new FileObject($file_name, "r");
-		while(!$target->feof())
+		while (!$target->feof())
 		{
 			$readstr = $target->read();
 			$this->write($readstr);
@@ -89,11 +89,11 @@ 
 	function write($str)
 	{
 		$len = strlen($str);
-		if(!$str || $len <= 0)
+		if (!$str || $len <= 0)
 		{
 			return FALSE;
 		}
-		if(!$this->fp)
+		if (!$this->fp)
 		{
 			return FALSE;
 		}
@@ -112,12 +112,12 @@ 
 	 */
 	function open($path, $mode)
 	{
-		if($this->fp != NULL)
+		if ($this->fp != NULL)
 		{
 			$this->close();
 		}
 		$this->fp = fopen($path, $mode);
-		if(!is_resource($this->fp))
+		if (!is_resource($this->fp))
 		{
 			$this->fp = NULL;
 			return FALSE;
@@ -133,7 +133,7 @@ 
 	 */
 	function getPath()
 	{
-		if($this->fp != NULL)
+		if ($this->fp != NULL)
 		{
 			return $this->path;
 		}
@@ -150,7 +150,7 @@ 
 	 */
 	function close()
 	{
-		if($this->fp != NULL)
+		if ($this->fp != NULL)
 		{
 			fclose($this->fp);
 			$this->fp = NULL;

Braces +1 added lines, -2 removed lines

@@ -136,8 +136,7 @@
 		if($this->fp != NULL)
 		{
 			return $this->path;
-		}
-		else
+		} else
 		{
 			return NULL;
 		}

classes/mobile/Mobile.class.php

Spacing +28 added lines, -28 removed lines

@@ -23,7 +23,7 @@ 
 	function &getInstance()
 	{
 		static $theInstance;
-		if(!isset($theInstance))
+		if (!isset($theInstance))
 		{
 			$theInstance = new Mobile();
 		}
@@ -48,11 +48,11 @@ 
 	 */
 	function _isFromMobilePhone()
 	{
-		if($this->ismobile !== NULL)
+		if ($this->ismobile !== NULL)
 		{
 			return $this->ismobile;
 		}
-		if(Mobile::isMobileEnabled() === false || Context::get('full_browse') || $_COOKIE["FullBrowse"])
+		if (Mobile::isMobileEnabled() === false || Context::get('full_browse') || $_COOKIE["FullBrowse"])
 		{
 			return ($this->ismobile = false);
 		}
@@ -63,22 +63,22 @@ 
 		$this->ismobile = FALSE;
 
 		$m = Context::get('m');
-		if(strlen($m) == 1)
+		if (strlen($m) == 1)
 		{
-			if($m == "1")
+			if ($m == "1")
 			{
 				$this->ismobile = TRUE;
 			}
-			elseif($m == "0")
+			elseif ($m == "0")
 			{
 				$this->ismobile = FALSE;
 			}
 		}
-		elseif(isset($_COOKIE['mobile']))
+		elseif (isset($_COOKIE['mobile']))
 		{
-			if($_COOKIE['user-agent'] == md5($_SERVER['HTTP_USER_AGENT']))
+			if ($_COOKIE['user-agent'] == md5($_SERVER['HTTP_USER_AGENT']))
 			{
-				if($_COOKIE['mobile'] == 'true')
+				if ($_COOKIE['mobile'] == 'true')
 				{
 					$this->ismobile = TRUE;
 				}
@@ -92,7 +92,7 @@ 
 				$this->ismobile = FALSE;
 				setcookie("mobile", FALSE, 0, $xe_web_path);
 				setcookie("user-agent", FALSE, 0, $xe_web_path);
-				if(!$this->isMobilePadCheckByAgent() && $this->isMobileCheckByAgent())
+				if (!$this->isMobilePadCheckByAgent() && $this->isMobileCheckByAgent())
 				{
 					$this->ismobile = TRUE;
 				}
@@ -100,36 +100,36 @@ 
 		}
 		else
 		{
-			if($this->isMobilePadCheckByAgent())
+			if ($this->isMobilePadCheckByAgent())
 			{
 				$this->ismobile = FALSE;
 			}
 			else
 			{
-				if($this->isMobileCheckByAgent())
+				if ($this->isMobileCheckByAgent())
 				{
 					$this->ismobile = TRUE;
 				}
 			}
 		}
 
-		if($this->ismobile !== NULL)
+		if ($this->ismobile !== NULL)
 		{
-			if($this->ismobile == TRUE)
+			if ($this->ismobile == TRUE)
 			{
-				if($_COOKIE['mobile'] != 'true')
+				if ($_COOKIE['mobile'] != 'true')
 				{
 					$_COOKIE['mobile'] = 'true';
 					setcookie("mobile", 'true', 0, $xe_web_path);
 				}
 			}
-			elseif($_COOKIE['mobile'] != 'false')
+			elseif ($_COOKIE['mobile'] != 'false')
 			{
 				$_COOKIE['mobile'] = 'false';
 				setcookie("mobile", 'false', 0, $xe_web_path);
 			}
 
-			if($_COOKIE['user-agent'] != md5($_SERVER['HTTP_USER_AGENT']))
+			if ($_COOKIE['user-agent'] != md5($_SERVER['HTTP_USER_AGENT']))
 			{
 				setcookie("user-agent", md5($_SERVER['HTTP_USER_AGENT']), 0, $xe_web_path);
 			}
@@ -146,7 +146,7 @@ 
 	function isMobileCheckByAgent()
 	{
 		static $UACheck;
-		if(isset($UACheck))
+		if (isset($UACheck))
 		{
 			return $UACheck;
 		}
@@ -154,15 +154,15 @@ 
 		$oMobile = Mobile::getInstance();
 		$mobileAgent = array('iPod', 'iPhone', 'Android', 'BlackBerry', 'SymbianOS', 'Bada', 'Tizen', 'Kindle', 'Wii', 'SCH-', 'SPH-', 'CANU-', 'Windows Phone', 'Windows CE', 'POLARIS', 'Palm', 'Dorothy Browser', 'Mobile', 'Opera Mobi', 'Opera Mini', 'Minimo', 'AvantGo', 'NetFront', 'Nokia', 'LGPlayer', 'SonyEricsson', 'HTC');
 
-		if($oMobile->isMobilePadCheckByAgent())
+		if ($oMobile->isMobilePadCheckByAgent())
 		{
 			$UACheck = TRUE;
 			return TRUE;
 		}
 
-		foreach($mobileAgent as $agent)
+		foreach ($mobileAgent as $agent)
 		{
-			if(stripos($_SERVER['HTTP_USER_AGENT'], $agent) !== FALSE)
+			if (stripos($_SERVER['HTTP_USER_AGENT'], $agent) !== FALSE)
 			{
 				$UACheck = TRUE;
 				return TRUE;
@@ -180,7 +180,7 @@ 
 	function isMobilePadCheckByAgent()
 	{
 		static $UACheck;
-		if(isset($UACheck))
+		if (isset($UACheck))
 		{
 			return $UACheck;
 		}
@@ -190,21 +190,21 @@ 
 		// $exceptionAgent[0] contains exception agents for all exceptions.
 		$exceptionAgent = array(0 => array('Opera Mini', 'Opera Mobi'), 'Android' => 'Mobile');
 
-		foreach($padAgent as $agent)
+		foreach ($padAgent as $agent)
 		{
-			if(strpos($_SERVER['HTTP_USER_AGENT'], $agent) !== FALSE)
+			if (strpos($_SERVER['HTTP_USER_AGENT'], $agent) !== FALSE)
 			{
-				if(!isset($exceptionAgent[$agent]))
+				if (!isset($exceptionAgent[$agent]))
 				{
 					$UACheck = TRUE;
 					return TRUE;
 				}
-				elseif(strpos($_SERVER['HTTP_USER_AGENT'], $exceptionAgent[$agent]) === FALSE)
+				elseif (strpos($_SERVER['HTTP_USER_AGENT'], $exceptionAgent[$agent]) === FALSE)
 				{
 					// If the agent is the Android, that can be either tablet and mobile phone.
-					foreach($exceptionAgent[0] as $val)
+					foreach ($exceptionAgent[0] as $val)
 					{
-						if(strpos($_SERVER['HTTP_USER_AGENT'], $val) !== FALSE)
+						if (strpos($_SERVER['HTTP_USER_AGENT'], $val) !== FALSE)
 						{
 							$UACheck = FALSE;
 							return FALSE;

Braces +8 added lines, -16 removed lines

@@ -68,26 +68,22 @@ 
 			if($m == "1")
 			{
 				$this->ismobile = TRUE;
-			}
-			elseif($m == "0")
+			} elseif($m == "0")
 			{
 				$this->ismobile = FALSE;
 			}
-		}
-		elseif(isset($_COOKIE['mobile']))
+		} elseif(isset($_COOKIE['mobile']))
 		{
 			if($_COOKIE['user-agent'] == md5($_SERVER['HTTP_USER_AGENT']))
 			{
 				if($_COOKIE['mobile'] == 'true')
 				{
 					$this->ismobile = TRUE;
-				}
-				else
+				} else
 				{
 					$this->ismobile = FALSE;
 				}
-			}
-			else
+			} else
 			{
 				$this->ismobile = FALSE;
 				setcookie("mobile", FALSE, 0, $xe_web_path);
@@ -97,14 +93,12 @@ 
 					$this->ismobile = TRUE;
 				}
 			}
-		}
-		else
+		} else
 		{
 			if($this->isMobilePadCheckByAgent())
 			{
 				$this->ismobile = FALSE;
-			}
-			else
+			} else
 			{
 				if($this->isMobileCheckByAgent())
 				{
@@ -122,8 +116,7 @@ 
 					$_COOKIE['mobile'] = 'true';
 					setcookie("mobile", 'true', 0, $xe_web_path);
 				}
-			}
-			elseif($_COOKIE['mobile'] != 'false')
+			} elseif($_COOKIE['mobile'] != 'false')
 			{
 				$_COOKIE['mobile'] = 'false';
 				setcookie("mobile", 'false', 0, $xe_web_path);
@@ -198,8 +191,7 @@ 
 				{
 					$UACheck = TRUE;
 					return TRUE;
-				}
-				elseif(strpos($_SERVER['HTTP_USER_AGENT'], $exceptionAgent[$agent]) === FALSE)
+				} elseif(strpos($_SERVER['HTTP_USER_AGENT'], $exceptionAgent[$agent]) === FALSE)
 				{
 					// If the agent is the Android, that can be either tablet and mobile phone.
 					foreach($exceptionAgent[0] as $val)

classes/page/PageHandler.class.php

Spacing +5 added lines, -5 removed lines

@@ -39,18 +39,18 @@ 
 		$this->point = 0;
 
 		$first_page = $cur_page - (int) ($page_count / 2);
-		if($first_page < 1)
+		if ($first_page < 1)
 		{
 			$first_page = 1;
 		}
 
-		if($total_page > $page_count && $first_page + $page_count - 1 > $total_page)
+		if ($total_page > $page_count && $first_page + $page_count - 1 > $total_page)
 		{
 			$first_page -= $first_page + $page_count - 1 - $total_page;
 		}
 
 		$last_page = $total_page;
-		if($last_page > $total_page)
+		if ($last_page > $total_page)
 		{
 			$last_page = $total_page;
 		}
@@ -58,7 +58,7 @@ 
 		$this->first_page = $first_page;
 		$this->last_page = $last_page;
 
-		if($total_page < $this->page_count)
+		if ($total_page < $this->page_count)
 		{
 			$this->page_count = $total_page;
 		}
@@ -71,7 +71,7 @@ 
 	function getNextPage()
 	{
 		$page = $this->first_page + $this->point++;
-		if($this->point > $this->page_count || $page > $this->last_page)
+		if ($this->point > $this->page_count || $page > $this->last_page)
 		{
 			$page = 0;
 		}

classes/security/IpFilter.class.php

Spacing +10 added lines, -10 removed lines

@@ -5,24 +5,24 @@ 
 {
 	public function filter($ip_list, $ip = NULL)
 	{
-		if(!$ip) $ip = $_SERVER['REMOTE_ADDR'];
+		if (!$ip) $ip = $_SERVER['REMOTE_ADDR'];
 		$long_ip = ip2long($ip);
-		foreach($ip_list as $filter_ip)
+		foreach ($ip_list as $filter_ip)
 		{	
 			$range = explode('-', $filter_ip);
-			if(!$range[1]) // single address type
+			if (!$range[1]) // single address type
 			{
 				$star_pos = strpos($filter_ip, '*');
-				if($star_pos !== FALSE ) // wild card exist 
+				if ($star_pos !== FALSE) // wild card exist 
 				{
-					if(strncmp($filter_ip, $ip, $star_pos)===0) return true;
+					if (strncmp($filter_ip, $ip, $star_pos) === 0) return true;
 				}
-				else if(strcmp($filter_ip, $ip)===0)
+				else if (strcmp($filter_ip, $ip) === 0)
 				{
 					return true;
 				}
 			}
-			else if(ip2long($range[0]) <= $long_ip && ip2long($range[1]) >= $long_ip)
+			else if (ip2long($range[0]) <= $long_ip && ip2long($range[1]) >= $long_ip)
 			{
 				return true;
 			}
@@ -74,12 +74,12 @@ 
 					)
 				)
 			$/";
-		$regex = str_replace(array("\r\n", "\n", "\r","\t"," "), '', $regex);
+		$regex = str_replace(array("\r\n", "\n", "\r", "\t", " "), '', $regex);
 		
-		foreach($ip_list as $i => $ip)
+		foreach ($ip_list as $i => $ip)
 		{
 			preg_match($regex, $ip, $matches);
-			if(!count($matches)) return false;
+			if (!count($matches)) return false;
 		}
 		
 		return true;

Braces +13 added lines, -7 removed lines

@@ -5,24 +5,28 @@ 
 {
 	public function filter($ip_list, $ip = NULL)
 	{
-		if(!$ip) $ip = $_SERVER['REMOTE_ADDR'];
+		if(!$ip) {
+			$ip = $_SERVER['REMOTE_ADDR'];
+		}
 		$long_ip = ip2long($ip);
 		foreach($ip_list as $filter_ip)
 		{	
 			$range = explode('-', $filter_ip);
-			if(!$range[1]) // single address type
+			if(!$range[1]) {
+				// single address type
 			{
 				$star_pos = strpos($filter_ip, '*');
-				if($star_pos !== FALSE ) // wild card exist 
+			}
+				if($star_pos !== FALSE ) {
+					// wild card exist 
 				{
 					if(strncmp($filter_ip, $ip, $star_pos)===0) return true;
 				}
-				else if(strcmp($filter_ip, $ip)===0)
+				} else if(strcmp($filter_ip, $ip)===0)
 				{
 					return true;
 				}
-			}
-			else if(ip2long($range[0]) <= $long_ip && ip2long($range[1]) >= $long_ip)
+			} else if(ip2long($range[0]) <= $long_ip && ip2long($range[1]) >= $long_ip)
 			{
 				return true;
 			}
@@ -79,7 +83,9 @@ 
 		foreach($ip_list as $i => $ip)
 		{
 			preg_match($regex, $ip, $matches);
-			if(!count($matches)) return false;
+			if(!count($matches)) {
+				return false;
+			}
 		}
 		
 		return true;

classes/security/Password.class.php

Spacing +42 added lines, -42 removed lines

@@ -19,11 +19,11 @@ 
 	public function getSupportedAlgorithms()
 	{
 		$retval = array();
-		if(function_exists('hash_hmac') && in_array('sha256', hash_algos()))
+		if (function_exists('hash_hmac') && in_array('sha256', hash_algos()))
 		{
 			$retval['pbkdf2'] = 'pbkdf2';
 		}
-		if(version_compare(PHP_VERSION, '5.3.7', '>=') && defined('CRYPT_BLOWFISH'))
+		if (version_compare(PHP_VERSION, '5.3.7', '>=') && defined('CRYPT_BLOWFISH'))
 		{
 			$retval['bcrypt'] = 'bcrypt';
 		}
@@ -47,13 +47,13 @@ 
 	 */
 	public function getCurrentlySelectedAlgorithm()
 	{
-		if(function_exists('getModel'))
+		if (function_exists('getModel'))
 		{
 			$config = getModel('member')->getMemberConfig();
 			$algorithm = $config->password_hashing_algorithm;
-			if(strval($algorithm) === '')
+			if (strval($algorithm) === '')
 			{
-				$algorithm = 'md5';  // Historical default for XE
+				$algorithm = 'md5'; // Historical default for XE
 			}
 		}
 		else
@@ -69,13 +69,13 @@ 
 	 */
 	public function getWorkFactor()
 	{
-		if(function_exists('getModel'))
+		if (function_exists('getModel'))
 		{
 			$config = getModel('member')->getMemberConfig();
 			$work_factor = $config->password_hashing_work_factor;
-			if(!$work_factor || $work_factor < 4 || $work_factor > 31)
+			if (!$work_factor || $work_factor < 4 || $work_factor > 31)
 			{
-				$work_factor = 8;  // Reasonable default
+				$work_factor = 8; // Reasonable default
 			}
 		}
 		else
@@ -93,18 +93,18 @@ 
 	 */
 	public function createHash($password, $algorithm = null)
 	{
-		if($algorithm === null)
+		if ($algorithm === null)
 		{
 			$algorithm = $this->getCurrentlySelectedAlgorithm();
 		}
-		if(!array_key_exists($algorithm, $this->getSupportedAlgorithms()))
+		if (!array_key_exists($algorithm, $this->getSupportedAlgorithms()))
 		{
 			return false;
 		}
 
 		$password = trim($password);
 
-		switch($algorithm)
+		switch ($algorithm)
 		{
 			case 'md5':
 				return md5($password);
@@ -113,7 +113,7 @@ 
 				$iterations = pow(2, $this->getWorkFactor() + 5);
 				$salt = $this->createSecureSalt(12, 'alnum');
 				$hash = base64_encode($this->pbkdf2($password, $salt, 'sha256', $iterations, 24));
-				return 'sha256:'.sprintf('%07d', $iterations).':'.$salt.':'.$hash;
+				return 'sha256:' . sprintf('%07d', $iterations) . ':' . $salt . ':' . $hash;
 
 			case 'bcrypt':
 				return $this->bcrypt($password);
@@ -132,14 +132,14 @@ 
 	 */
 	public function checkPassword($password, $hash, $algorithm = null)
 	{
-		if($algorithm === null)
+		if ($algorithm === null)
 		{
 			$algorithm = $this->checkAlgorithm($hash);
 		}
 
 		$password = trim($password);
 
-		switch($algorithm)
+		switch ($algorithm)
 		{
 			case 'md5':
 				return md5($password) === $hash || md5(sha1(md5($password))) === $hash;
@@ -173,23 +173,23 @@ 
 	 */
 	function checkAlgorithm($hash)
 	{
-		if(preg_match('/^\$2[axy]\$([0-9]{2})\$/', $hash, $matches))
+		if (preg_match('/^\$2[axy]\$([0-9]{2})\$/', $hash, $matches))
 		{
 			return 'bcrypt';
 		}
-		elseif(preg_match('/^sha[0-9]+:([0-9]+):/', $hash, $matches))
+		elseif (preg_match('/^sha[0-9]+:([0-9]+):/', $hash, $matches))
 		{
 			return 'pbkdf2';
 		}
-		elseif(strlen($hash) === 32 && ctype_xdigit($hash))
+		elseif (strlen($hash) === 32 && ctype_xdigit($hash))
 		{
 			return 'md5';
 		}
-		elseif(strlen($hash) === 16 && ctype_xdigit($hash))
+		elseif (strlen($hash) === 16 && ctype_xdigit($hash))
 		{
 			return 'mysql_old_password';
 		}
-		elseif(strlen($hash) === 41 && $hash[0] === '*')
+		elseif (strlen($hash) === 41 && $hash[0] === '*')
 		{
 			return 'mysql_password';
 		}
@@ -206,11 +206,11 @@ 
 	 */
 	function checkWorkFactor($hash)
 	{
-		if(preg_match('/^\$2[axy]\$([0-9]{2})\$/', $hash, $matches))
+		if (preg_match('/^\$2[axy]\$([0-9]{2})\$/', $hash, $matches))
 		{
 			return intval($matches[1], 10);
 		}
-		elseif(preg_match('/^sha[0-9]+:([0-9]+):/', $hash, $matches))
+		elseif (preg_match('/^sha[0-9]+:([0-9]+):/', $hash, $matches))
 		{
 			return max(0, round(log($matches[1], 2)) - 5);
 		}
@@ -229,7 +229,7 @@ 
 	public function createSecureSalt($length, $format = 'hex')
 	{
 		// Find out how many bytes of entropy we really need
-		switch($format)
+		switch ($format)
 		{
 			case 'hex':
 				$entropy_required_bytes = ceil($length / 2);
@@ -247,19 +247,19 @@ 
 
 		// Find and use the most secure way to generate a random string
 		$is_windows = (defined('PHP_OS') && strtoupper(substr(PHP_OS, 0, 3)) === 'WIN');
-		if(function_exists('openssl_random_pseudo_bytes') && (!$is_windows || version_compare(PHP_VERSION, '5.4', '>=')))
+		if (function_exists('openssl_random_pseudo_bytes') && (!$is_windows || version_compare(PHP_VERSION, '5.4', '>=')))
 		{
 			$entropy = openssl_random_pseudo_bytes($entropy_capped_bytes);
 		}
-		elseif(function_exists('mcrypt_create_iv') && (!$is_windows || version_compare(PHP_VERSION, '5.3.7', '>=')))
+		elseif (function_exists('mcrypt_create_iv') && (!$is_windows || version_compare(PHP_VERSION, '5.3.7', '>=')))
 		{
 			$entropy = mcrypt_create_iv($entropy_capped_bytes, MCRYPT_DEV_URANDOM);
 		}
-		elseif(function_exists('mcrypt_create_iv') && $is_windows)
+		elseif (function_exists('mcrypt_create_iv') && $is_windows)
 		{
 			$entropy = mcrypt_create_iv($entropy_capped_bytes, MCRYPT_RAND);
 		}
-		elseif(!$is_windows && @is_readable('/dev/urandom'))
+		elseif (!$is_windows && @is_readable('/dev/urandom'))
 		{
 			$fp = fopen('/dev/urandom', 'rb');
 			$entropy = fread($fp, $entropy_capped_bytes);
@@ -268,7 +268,7 @@ 
 		else
 		{
 			$entropy = '';
-			for($i = 0; $i < $entropy_capped_bytes; $i += 2)
+			for ($i = 0; $i < $entropy_capped_bytes; $i += 2)
 			{
 				$entropy .= pack('S', rand(0, 65536) ^ mt_rand(0, 65535));
 			}
@@ -276,13 +276,13 @@ 
 
 		// Mixing (see RFC 4086 section 5)
 		$output = '';
-		for($i = 0; $i < $entropy_required_bytes; $i += 32)
+		for ($i = 0; $i < $entropy_required_bytes; $i += 32)
 		{
 			$output .= hash('sha256', $entropy . $i . rand(), true);
 		}
 
 		// Encode and return the random string
-		switch($format)
+		switch ($format)
 		{
 			case 'hex':
 				return substr(bin2hex($output), 0, $length);
@@ -290,7 +290,7 @@ 
 				return substr($output, 0, $length);
 			case 'printable':
 				$salt = '';
-				for($i = 0; $i < $length; $i++)
+				for ($i = 0; $i < $length; $i++)
 				{
 					$salt .= chr(33 + (crc32(sha1($i . $output)) % 94));
 				}
@@ -310,15 +310,15 @@ 
 	 */
 	public function createTemporaryPassword($length = 16)
 	{
-		while(true)
+		while (true)
 		{
 			$source = base64_encode($this->createSecureSalt(64, 'binary'));
 			$source = strtr($source, 'iIoOjl10/', '@#$%&*-!?');
 			$source_length = strlen($source);
-			for($i = 0; $i < $source_length - $length; $i++)
+			for ($i = 0; $i < $source_length - $length; $i++)
 			{
 				$candidate = substr($source, $i, $length);
-				if(preg_match('/[a-z]/', $candidate) && preg_match('/[A-Z]/', $candidate) &&
+				if (preg_match('/[a-z]/', $candidate) && preg_match('/[A-Z]/', $candidate) &&
 					preg_match('/[0-9]/', $candidate) && preg_match('/[^a-zA-Z0-9]/', $candidate))
 				{
 					return $candidate;
@@ -338,19 +338,19 @@ 
 	 */
 	public function pbkdf2($password, $salt, $algorithm = 'sha256', $iterations = 8192, $length = 24)
 	{
-		if(function_exists('hash_pbkdf2'))
+		if (function_exists('hash_pbkdf2'))
 		{
 			return hash_pbkdf2($algorithm, $password, $salt, $iterations, $length, true);
 		}
 		else
 		{
 			$output = '';
-			$block_count = ceil($length / strlen(hash($algorithm, '', true)));  // key length divided by the length of one hash
-			for($i = 1; $i <= $block_count; $i++)
+			$block_count = ceil($length / strlen(hash($algorithm, '', true))); // key length divided by the length of one hash
+			for ($i = 1; $i <= $block_count; $i++)
 			{
-				$last = $salt . pack('N', $i);  // $i encoded as 4 bytes, big endian
-				$last = $xorsum = hash_hmac($algorithm, $last, $password, true);  // first iteration
-				for($j = 1; $j < $iterations; $j++)  // The other $count - 1 iterations
+				$last = $salt . pack('N', $i); // $i encoded as 4 bytes, big endian
+				$last = $xorsum = hash_hmac($algorithm, $last, $password, true); // first iteration
+				for ($j = 1; $j < $iterations; $j++)  // The other $count - 1 iterations
 				{
 					$xorsum ^= ($last = hash_hmac($algorithm, $last, $password, true));
 				}
@@ -368,9 +368,9 @@ 
 	 */
 	public function bcrypt($password, $salt = null)
 	{
-		if($salt === null)
+		if ($salt === null)
 		{
-			$salt = '$2y$'.sprintf('%02d', $this->getWorkFactor()).'$'.$this->createSecureSalt(22, 'alnum');
+			$salt = '$2y$' . sprintf('%02d', $this->getWorkFactor()) . '$' . $this->createSecureSalt(22, 'alnum');
 		}
 		return crypt($password, $salt);
 	}
@@ -385,7 +385,7 @@ 
 	{
 		$diff = strlen($a) ^ strlen($b);
 		$maxlen = min(strlen($a), strlen($b));
-		for($i = 0; $i < $maxlen; $i++)
+		for ($i = 0; $i < $maxlen; $i++)
 		{
 			$diff |= ord($a[$i]) ^ ord($b[$i]);
 		}

Braces +17 added lines, -29 removed lines

@@ -55,8 +55,7 @@ 
 			{
 				$algorithm = 'md5';  // Historical default for XE
 			}
-		}
-		else
+		} else
 		{
 			$algorithm = 'md5';
 		}
@@ -77,8 +76,7 @@ 
 			{
 				$work_factor = 8;  // Reasonable default
 			}
-		}
-		else
+		} else
 		{
 			$work_factor = 8;
 		}
@@ -176,24 +174,19 @@ 
 		if(preg_match('/^\$2[axy]\$([0-9]{2})\$/', $hash, $matches))
 		{
 			return 'bcrypt';
-		}
-		elseif(preg_match('/^sha[0-9]+:([0-9]+):/', $hash, $matches))
+		} elseif(preg_match('/^sha[0-9]+:([0-9]+):/', $hash, $matches))
 		{
 			return 'pbkdf2';
-		}
-		elseif(strlen($hash) === 32 && ctype_xdigit($hash))
+		} elseif(strlen($hash) === 32 && ctype_xdigit($hash))
 		{
 			return 'md5';
-		}
-		elseif(strlen($hash) === 16 && ctype_xdigit($hash))
+		} elseif(strlen($hash) === 16 && ctype_xdigit($hash))
 		{
 			return 'mysql_old_password';
-		}
-		elseif(strlen($hash) === 41 && $hash[0] === '*')
+		} elseif(strlen($hash) === 41 && $hash[0] === '*')
 		{
 			return 'mysql_password';
-		}
-		else
+		} else
 		{
 			return false;
 		}
@@ -209,12 +202,10 @@ 
 		if(preg_match('/^\$2[axy]\$([0-9]{2})\$/', $hash, $matches))
 		{
 			return intval($matches[1], 10);
-		}
-		elseif(preg_match('/^sha[0-9]+:([0-9]+):/', $hash, $matches))
+		} elseif(preg_match('/^sha[0-9]+:([0-9]+):/', $hash, $matches))
 		{
 			return max(0, round(log($matches[1], 2)) - 5);
-		}
-		else
+		} else
 		{
 			return false;
 		}
@@ -250,22 +241,18 @@ 
 		if(function_exists('openssl_random_pseudo_bytes') && (!$is_windows || version_compare(PHP_VERSION, '5.4', '>=')))
 		{
 			$entropy = openssl_random_pseudo_bytes($entropy_capped_bytes);
-		}
-		elseif(function_exists('mcrypt_create_iv') && (!$is_windows || version_compare(PHP_VERSION, '5.3.7', '>=')))
+		} elseif(function_exists('mcrypt_create_iv') && (!$is_windows || version_compare(PHP_VERSION, '5.3.7', '>=')))
 		{
 			$entropy = mcrypt_create_iv($entropy_capped_bytes, MCRYPT_DEV_URANDOM);
-		}
-		elseif(function_exists('mcrypt_create_iv') && $is_windows)
+		} elseif(function_exists('mcrypt_create_iv') && $is_windows)
 		{
 			$entropy = mcrypt_create_iv($entropy_capped_bytes, MCRYPT_RAND);
-		}
-		elseif(!$is_windows && @is_readable('/dev/urandom'))
+		} elseif(!$is_windows && @is_readable('/dev/urandom'))
 		{
 			$fp = fopen('/dev/urandom', 'rb');
 			$entropy = fread($fp, $entropy_capped_bytes);
 			fclose($fp);
-		}
-		else
+		} else
 		{
 			$entropy = '';
 			for($i = 0; $i < $entropy_capped_bytes; $i += 2)
@@ -341,8 +328,7 @@ 
 		if(function_exists('hash_pbkdf2'))
 		{
 			return hash_pbkdf2($algorithm, $password, $salt, $iterations, $length, true);
-		}
-		else
+		} else
 		{
 			$output = '';
 			$block_count = ceil($length / strlen(hash($algorithm, '', true)));  // key length divided by the length of one hash
@@ -350,10 +336,12 @@ 
 			{
 				$last = $salt . pack('N', $i);  // $i encoded as 4 bytes, big endian
 				$last = $xorsum = hash_hmac($algorithm, $last, $password, true);  // first iteration
-				for($j = 1; $j < $iterations; $j++)  // The other $count - 1 iterations
+				for($j = 1; $j < $iterations; $j++) {
+					// The other $count - 1 iterations
 				{
 					$xorsum ^= ($last = hash_hmac($algorithm, $last, $password, true));
 				}
+				}
 				$output .= $xorsum;
 			}
 			return substr($output, 0, $length);

classes/security/Purifier.class.php

Spacing +18 added lines, -18 removed lines

@@ -22,7 +22,7 @@ 
 
 	public function getInstance()
 	{
-		if(!isset($GLOBALS['__PURIFIER_INSTANCE__']))
+		if (!isset($GLOBALS['__PURIFIER_INSTANCE__']))
 		{
 			$GLOBALS['__PURIFIER_INSTANCE__'] = new Purifier();
 		}
@@ -52,9 +52,9 @@ 
 	{
 		// add attribute for edit component
 		$editComponentAttrs = $this->_searchEditComponent($content);
-		if(is_array($editComponentAttrs))
+		if (is_array($editComponentAttrs))
 		{
-			foreach($editComponentAttrs AS $k => $v)
+			foreach ($editComponentAttrs AS $k => $v)
 			{
 				$this->_def->addAttribute('img', $v, 'CDATA');
 				$this->_def->addAttribute('div', $v, 'CDATA');
@@ -63,9 +63,9 @@ 
 
 		// add attribute for widget component
 		$widgetAttrs = $this->_searchWidget($content);
-		if(is_array($widgetAttrs))
+		if (is_array($widgetAttrs))
 		{
-			foreach($widgetAttrs AS $k => $v)
+			foreach ($widgetAttrs AS $k => $v)
 			{
 				$this->_def->addAttribute('img', $v, 'CDATA');
 			}
@@ -82,19 +82,19 @@ 
 		preg_match_all('!<(?:(div)|img)([^>]*)editor_component=([^>]*)>(?(1)(.*?)</div>)!is', $content, $m);
 
 		$attributeList = array();
-		if(is_array($m[2]))
+		if (is_array($m[2]))
 		{
-			foreach($m[2] as $key => $value)
+			foreach ($m[2] as $key => $value)
 			{
 				unset($script, $m2);
 				$script = " {$m[2][$key]} editor_component={$m[3][$key]}";
 
-				if(preg_match_all('/([a-z0-9_-]+)="([^"]+)"/is', $script, $m2))
+				if (preg_match_all('/([a-z0-9_-]+)="([^"]+)"/is', $script, $m2))
 				{
-					foreach($m2[1] as $value2)
+					foreach ($m2[1] as $value2)
 					{
 						//SECISSUE check style attr
-						if($value2 == 'style')
+						if ($value2 == 'style')
 						{
 							continue;
 						}
@@ -117,18 +117,18 @@ 
 		preg_match_all('!<(?:(div)|img)([^>]*)class="zbxe_widget_output"([^>]*)>(?(1)(.*?)</div>)!is', $content, $m);
 
 		$attributeList = array();
-		if(is_array($m[3]))
+		if (is_array($m[3]))
 		{
 			$content = str_replace('<img class="zbxe_widget_output"', '<img src="" class="zbxe_widget_output"', $content);
 
-			foreach($m[3] as $key => $value)
+			foreach ($m[3] as $key => $value)
 			{
 				if (preg_match_all('/([a-z0-9_-]+)="([^"]+)"/is', $m[3][$key], $m2))
 				{
-					foreach($m2[1] as $value2)
+					foreach ($m2[1] as $value2)
 					{
 						//SECISSUE check style attr
-						if($value2 == 'style')
+						if ($value2 == 'style')
 						{
 							continue;
 						}
@@ -149,14 +149,14 @@ 
 		$whiteDomainRegex = '%^(';
 		$whiteDomainCount = count($whiteIframeUrlList);
 
-		$i=1;
-		if(is_array($whiteIframeUrlList))
+		$i = 1;
+		if (is_array($whiteIframeUrlList))
 		{
-			foreach($whiteIframeUrlList as $value)
+			foreach ($whiteIframeUrlList as $value)
 			{
 				$whiteDomainRegex .= $value;
 
-				if($i < $whiteDomainCount)
+				if ($i < $whiteDomainCount)
 				{
 					$whiteDomainRegex .= '|';
 				}

classes/security/htmlpurifier/library/HTMLPurifier.auto.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
  * This is a stub include that automatically configures the include path.
  */
 
-set_include_path(dirname(__FILE__) . PATH_SEPARATOR . get_include_path() );
+set_include_path(dirname(__FILE__) . PATH_SEPARATOR . get_include_path());
 require_once 'HTMLPurifier/Bootstrap.php';
 require_once 'HTMLPurifier.autoload.php';