xpressengine / xe-core

modules/install/install.admin.controller.php

Doc Comments +12 added lines

@@ -294,6 +294,7 @@ 
 
 	/**
 	 * @brief Supported languages (was procInstallAdminSaveLangSelected)
+	 * @param string $selected_lang
 	 */
 	function saveLangSelected($selected_lang)
 	{
@@ -311,6 +312,10 @@ 
 	}
 
 	/* 썸내일 보여주기 방식 변경.*/
+
+	/**
+	 * @param stdClass $config
+	 */
 	function setModulesConfig($config)
 	{
 		$args = new stdClass();
@@ -331,6 +336,10 @@ 
 		return $output;
 	}
 
+	/**
+	 * @param string $icon
+	 * @param string $iconname
+	 */
 	private function saveIconTmp($icon, $iconname)
 	{
 
@@ -377,6 +386,9 @@ 
 		return $relative_filename;
 	}
 
+	/**
+	 * @param string $iconname
+	 */
 	private function updateIcon($iconname, $deleteIcon = false) {
 
 		$site_info = Context::get('site_module_info');

Indentation +4 added lines, -4 removed lines

@@ -1,10 +1,10 @@
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 /**
- * @class  installAdminController
- * @author NAVER (developers@xpressengine.com)
- * @brief admin controller class of the install module
- */
+	 * @class  installAdminController
+	 * @author NAVER (developers@xpressengine.com)
+	 * @brief admin controller class of the install module
+	 */
 class installAdminController extends install
 {
 	/**

Spacing +74 added lines, -74 removed lines

@@ -20,10 +20,10 @@ 
 	function procInstallAdminInstall()
 	{
 		$module_name = Context::get('module_name');
-		if(!$module_name) return new object(-1, 'invalid_request');
+		if (!$module_name) return new object(-1, 'invalid_request');
 
 		$oInstallController = getController('install');
-		$oInstallController->installModule($module_name, './modules/'.$module_name);
+		$oInstallController->installModule($module_name, './modules/' . $module_name);
 
 		$this->setMessage('success_installed');
 	}
@@ -35,10 +35,10 @@ 
 	{
 		@set_time_limit(0);
 		$module_name = Context::get('module_name');
-		if(!$module_name) return new object(-1, 'invalid_request');
+		if (!$module_name) return new object(-1, 'invalid_request');
 
 		$oModule = getModule($module_name, 'class');
-		if($oModule) $output = $oModule->moduleUpdate();
+		if ($oModule) $output = $oModule->moduleUpdate();
 		else $output = new Object(-1, 'invalid_request');
 
 		return $output;
@@ -53,25 +53,25 @@ 
 
 		$admin_ip_list = Context::get('admin_ip_list');
 
-		if($admin_ip_list)
+		if ($admin_ip_list)
 		{
-			$admin_ip_list = preg_replace("/[\r|\n|\r\n]+/",",",$admin_ip_list);
-			$admin_ip_list = preg_replace("/\s+/","",$admin_ip_list);
-			if(preg_match('/(<\?|<\?php|\?>)/xsm', $admin_ip_list))
+			$admin_ip_list = preg_replace("/[\r|\n|\r\n]+/", ",", $admin_ip_list);
+			$admin_ip_list = preg_replace("/\s+/", "", $admin_ip_list);
+			if (preg_match('/(<\?|<\?php|\?>)/xsm', $admin_ip_list))
 			{
 				$admin_ip_list = '';
 			}
 			$admin_ip_list .= ',127.0.0.1,' . $_SERVER['REMOTE_ADDR'];
-			$admin_ip_list = explode(',',trim($admin_ip_list, ','));
+			$admin_ip_list = explode(',', trim($admin_ip_list, ','));
 			$admin_ip_list = array_unique($admin_ip_list);
-			if(!IpFilter::validate($admin_ip_list)) {
+			if (!IpFilter::validate($admin_ip_list)) {
 				return new Object(-1, 'msg_invalid_ip');
 			}
 		}
 		
 		$default_url = Context::get('default_url');
-		if($default_url && strncasecmp('http://', $default_url, 7) !== 0 && strncasecmp('https://', $default_url, 8) !== 0) $default_url = 'http://'.$default_url;
-		if($default_url && substr($default_url, -1) !== '/') $default_url = $default_url.'/';
+		if ($default_url && strncasecmp('http://', $default_url, 7) !== 0 && strncasecmp('https://', $default_url, 8) !== 0) $default_url = 'http://' . $default_url;
+		if ($default_url && substr($default_url, -1) !== '/') $default_url = $default_url . '/';
 
 		/* convert NON Alphabet URL to punycode URL - Alphabet URL will not be changed */
 		require_once(_XE_PATH_ . 'libs/idna_convert/idna_convert.class.php');
@@ -79,25 +79,25 @@ 
 		$default_url = $IDN->encode($default_url);
 
 		$use_ssl = Context::get('use_ssl');
-		if(!$use_ssl) $use_ssl = 'none';
+		if (!$use_ssl) $use_ssl = 'none';
 
 		$http_port = Context::get('http_port');
 		$https_port = Context::get('https_port');
 
 		$use_rewrite = Context::get('use_rewrite');
-		if($use_rewrite!='Y') $use_rewrite = 'N';
+		if ($use_rewrite != 'Y') $use_rewrite = 'N';
 
 		$use_sso = Context::get('use_sso');
-		if($use_sso !='Y') $use_sso = 'N';
+		if ($use_sso != 'Y') $use_sso = 'N';
 
 		$use_db_session = Context::get('use_db_session');
-		if($use_db_session!='Y') $use_db_session = 'N';
+		if ($use_db_session != 'Y') $use_db_session = 'N';
 
 		$qmail_compatibility = Context::get('qmail_compatibility');
-		if($qmail_compatibility!='Y') $qmail_compatibility = 'N';
+		if ($qmail_compatibility != 'Y') $qmail_compatibility = 'N';
 
 		$use_html5 = Context::get('use_html5');
-		if(!$use_html5) $use_html5 = 'N';
+		if (!$use_html5) $use_html5 = 'N';
 
 		$db_info->default_url = $default_url;
 		$db_info->qmail_compatibility = $qmail_compatibility;
@@ -108,23 +108,23 @@ 
 		$db_info->use_html5 = $use_html5;
 		$db_info->admin_ip_list = $admin_ip_list;
 
-		if($http_port) $db_info->http_port = (int) $http_port;
-		else if($db_info->http_port) unset($db_info->http_port);
+		if ($http_port) $db_info->http_port = (int) $http_port;
+		else if ($db_info->http_port) unset($db_info->http_port);
 
-		if($https_port) $db_info->https_port = (int) $https_port;
-		else if($db_info->https_port) unset($db_info->https_port);
+		if ($https_port) $db_info->https_port = (int) $https_port;
+		else if ($db_info->https_port) unset($db_info->https_port);
 
 		unset($db_info->lang_type);
 
 		$oInstallController = getController('install');
-		if(!$oInstallController->makeConfigFile())
+		if (!$oInstallController->makeConfigFile())
 		{
 			return new Object(-1, 'msg_invalid_request');
 		}
 		else
 		{
 			Context::setDBInfo($db_info);
-			if($default_url)
+			if ($default_url)
 			{
 				$site_args = new stdClass;
 				$site_args->site_srl = 0;
@@ -138,7 +138,7 @@ 
 
 	function procInstallAdminUpdateIndexModule()
 	{
-		if(!Context::get('index_module_srl') || !Context::get('menu_item_srl'))
+		if (!Context::get('index_module_srl') || !Context::get('menu_item_srl'))
 		{
 			return new Object(-1, 'msg_invalid_request');
 		}
@@ -157,12 +157,12 @@ 
 		// update homeSitemap.php cache file
 		$oMenuAdminController = getAdminController('menu');
 		$homeMenuCacheFile = $oMenuAdminController->getHomeMenuCacheFile();
-		if(file_exists($homeMenuCacheFile))
+		if (file_exists($homeMenuCacheFile))
 		{
 			include($homeMenuCacheFile);
 		}
 
-		if(!$homeMenuSrl || $homeMenuSrl != $output->menu_srl)
+		if (!$homeMenuSrl || $homeMenuSrl != $output->menu_srl)
 		{
 			$oMenuAdminController->makeHomemenuCacheFile($output->menu_srl);
 		}
@@ -173,8 +173,8 @@ 
 	function procInstallAdminRemoveFTPInfo()
 	{
 		$ftp_config_file = Context::getFTPConfigFile();
-		if(file_exists($ftp_config_file)) unlink($ftp_config_file);
-		if($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
+		if (file_exists($ftp_config_file)) unlink($ftp_config_file);
+		if ($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
 		$this->setMessage('success_deleted');
 	}
 
@@ -185,38 +185,38 @@ 
 		$ftp_info->ftp_port = Context::get('ftp_port');
 		$ftp_info->ftp_host = Context::get('ftp_host');
 		$ftp_info->ftp_pasv = Context::get('ftp_pasv');
-		if(!$ftp_info->ftp_pasv) $ftp_info->ftp_pasv = "N";
+		if (!$ftp_info->ftp_pasv) $ftp_info->ftp_pasv = "N";
 		$ftp_info->sftp = Context::get('sftp');
 
 		$ftp_root_path = Context::get('ftp_root_path');
-		if(substr($ftp_root_path, strlen($ftp_root_path)-1) == "/")
+		if (substr($ftp_root_path, strlen($ftp_root_path) - 1) == "/")
 		{
 			$ftp_info->ftp_root_path = $ftp_root_path;
 		}
 		else
 		{
-			$ftp_info->ftp_root_path = $ftp_root_path.'/';
+			$ftp_info->ftp_root_path = $ftp_root_path . '/';
 		}
 
-		if(ini_get('safe_mode'))
+		if (ini_get('safe_mode'))
 		{
 			$ftp_info->ftp_password = Context::get('ftp_password');
 		}
 
-		$buff = '<?php if(!defined("__XE__")) exit();'."\n\$ftp_info = new stdClass;\n";
-		foreach($ftp_info as $key => $val)
+		$buff = '<?php if(!defined("__XE__")) exit();' . "\n\$ftp_info = new stdClass;\n";
+		foreach ($ftp_info as $key => $val)
 		{
-			if(!$val) continue;
-			if(preg_match('/(<\?|<\?php|\?>|fputs|fopen|fwrite|fgets|fread|file_get_contents|file_put_contents|exec|proc_open|popen|passthru|show_source|phpinfo|system|\/\*|\*\/|chr\()/xsm', preg_replace('/\s/', '', $val)))
+			if (!$val) continue;
+			if (preg_match('/(<\?|<\?php|\?>|fputs|fopen|fwrite|fgets|fread|file_get_contents|file_put_contents|exec|proc_open|popen|passthru|show_source|phpinfo|system|\/\*|\*\/|chr\()/xsm', preg_replace('/\s/', '', $val)))
 			{
 				continue;
 			}
-			$buff .= sprintf("\$ftp_info->%s = '%s';\n", $key, str_replace("'","\\'",$val));
+			$buff .= sprintf("\$ftp_info->%s = '%s';\n", $key, str_replace("'", "\\'", $val));
 		}
 		$buff .= "?>";
 		$config_file = Context::getFTPConfigFile();
 		FileHandler::WriteFile($config_file, $buff);
-		if($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
+		if ($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
 
 		$this->setMessage('success_updated');
 		$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'module', 'admin', 'act', 'dispAdminConfigFtp');
@@ -226,7 +226,7 @@ 
 	function procInstallAdminConfig()
 	{
 		$use_mobile_view = Context::get('use_mobile_view');
-		if($use_mobile_view!='Y') $use_mobile_view = 'N';
+		if ($use_mobile_view != 'Y') $use_mobile_view = 'N';
 
 		$time_zone = Context::get('time_zone');
 
@@ -237,15 +237,15 @@ 
 		unset($db_info->lang_type);
 		Context::setDBInfo($db_info);
 		$oInstallController = getController('install');
-		if(!$oInstallController->makeConfigFile())
+		if (!$oInstallController->makeConfigFile())
 		{
 			return new Object(-1, 'msg_invalid_request');
 		}
 
 		$site_args = new stdClass();
 		$site_args->site_srl = 0;
-		$site_args->index_module_srl = Context::get('index_module_srl');//
-		$site_args->default_language = Context::get('change_lang_type');//
+		$site_args->index_module_srl = Context::get('index_module_srl'); //
+		$site_args->default_language = Context::get('change_lang_type'); //
 		$oModuleController = getController('module');
 		$oModuleController->updateSite($site_args);
 
@@ -257,8 +257,8 @@ 
 		$deleteFavicon = Context::get('is_delete_favicon');
 		$deleteMobicon = Context::get('is_delete_mobicon');
 
-		$this->updateIcon('favicon.ico',$deleteFavicon);
-		$this->updateIcon('mobicon.png',$deleteMobicon);
+		$this->updateIcon('favicon.ico', $deleteFavicon);
+		$this->updateIcon('mobicon.png', $deleteMobicon);
 
 		//모듈 설정 저장(썸네일, 풋터스크립트)
 		$config = new stdClass();
@@ -271,25 +271,25 @@ 
 	}
 
 	public function procInstallAdminConfigIconUpload() {
-		$this->setTemplatePath($this->module_path.'tpl');
+		$this->setTemplatePath($this->module_path . 'tpl');
 		$this->setTemplateFile("after_upload_config_image.html");
 
 		$favicon = Context::get('favicon');
 		$mobicon = Context::get('mobicon');
-		if(!$favicon && !$mobicon) {
+		if (!$favicon && !$mobicon) {
 			Context::set('msg', Context::getLang("msg_invalid_format"));
 			return;
 		}
-		if($favicon) {
+		if ($favicon) {
 			$name = 'favicon';
-			$tmpFileName = $this->saveIconTmp($favicon,'favicon.ico');
+			$tmpFileName = $this->saveIconTmp($favicon, 'favicon.ico');
 		} else {
 			$name = 'mobicon';
-			$tmpFileName = $this->saveIconTmp($mobicon,'mobicon.png');
+			$tmpFileName = $this->saveIconTmp($mobicon, 'mobicon.png');
 		}
 
 		Context::set('name', $name);
-		Context::set('tmpFileName', $tmpFileName.'?'.$_SERVER['REQUEST_TIME']);
+		Context::set('tmpFileName', $tmpFileName . '?' . $_SERVER['REQUEST_TIME']);
 	}
 
 	/**
@@ -301,12 +301,12 @@ 
 
 		$lang_supported = Context::loadLangSupported();
 		$buff = null;
-		for($i=0;$i<count($langs);$i++)
+		for ($i = 0; $i < count($langs); $i++)
 		{
 			$buff .= sprintf("%s,%s\n", $langs[$i], $lang_supported[$langs[$i]]);
 
 		}
-		FileHandler::writeFile(_XE_PATH_.'files/config/lang_selected.info', trim($buff));
+		FileHandler::writeFile(_XE_PATH_ . 'files/config/lang_selected.info', trim($buff));
 		//$this->setMessage('success_updated');
 	}
 
@@ -315,18 +315,18 @@ 
 	{
 		$args = new stdClass();
 
-		if(!$config->thumbnail_type || $config->thumbnail_type != 'ratio' ) $args->thumbnail_type = 'crop';
+		if (!$config->thumbnail_type || $config->thumbnail_type != 'ratio') $args->thumbnail_type = 'crop';
 		else $args->thumbnail_type = 'ratio';
 
 		$oModuleController = getController('module');
-		$oModuleController->insertModuleConfig('document',$args);
+		$oModuleController->insertModuleConfig('document', $args);
 
 		unset($args);
 
 		$args = new stdClass;
 		$args->htmlFooter = $config->htmlFooter;
 		$args->siteTitle = $config->siteTitle;
-		$oModuleController->updateModuleConfig('module',$args);
+		$oModuleController->updateModuleConfig('module', $args);
 
 		return $output;
 	}
@@ -336,32 +336,32 @@ 
 
 		$site_info = Context::get('site_module_info');
 		$virtual_site = '';
-		if($site_info->site_srl) 
+		if ($site_info->site_srl) 
 		{
 			$virtual_site = $site_info->site_srl . '/';
 		}
 
 		$target_file = $icon['tmp_name'];
 		$type = $icon['type'];
-		$relative_filename = 'files/attach/xeicon/'.$virtual_site.'tmp/'.$iconname;
-		$target_filename = _XE_PATH_.$relative_filename;
+		$relative_filename = 'files/attach/xeicon/' . $virtual_site . 'tmp/' . $iconname;
+		$target_filename = _XE_PATH_ . $relative_filename;
 
 		list($width, $height, $type_no, $attrs) = @getimagesize($target_file);
-		if($iconname == 'favicon.ico')
+		if ($iconname == 'favicon.ico')
 		{
-			if(!preg_match('/^.*(x-icon|\.icon)$/i',$type)) {
-				Context::set('msg', '*.ico '.Context::getLang('msg_possible_only_file'));
+			if (!preg_match('/^.*(x-icon|\.icon)$/i', $type)) {
+				Context::set('msg', '*.ico ' . Context::getLang('msg_possible_only_file'));
 				return;
 			}
 		}
-		else if($iconname == 'mobicon.png')
+		else if ($iconname == 'mobicon.png')
 		{
-			if(!preg_match('/^.*(png).*$/',$type)) {
-				Context::set('msg', '*.png '.Context::getLang('msg_possible_only_file'));
+			if (!preg_match('/^.*(png).*$/', $type)) {
+				Context::set('msg', '*.png ' . Context::getLang('msg_possible_only_file'));
 				return;
 			}
-			if(!(($height == '57' && $width == '57') || ($height == '114' && $width == '114'))) {
-				Context::set('msg', Context::getLang('msg_invalid_format').' (size : 57x57, 114x114)');
+			if (!(($height == '57' && $width == '57') || ($height == '114' && $width == '114'))) {
+				Context::set('msg', Context::getLang('msg_invalid_format') . ' (size : 57x57, 114x114)');
 				return;
 			}
 		}
@@ -381,21 +381,21 @@ 
 
 		$site_info = Context::get('site_module_info');
 		$virtual_site = '';
-		if($site_info->site_srl) 
+		if ($site_info->site_srl) 
 		{
 			$virtual_site = $site_info->site_srl . '/';
 		}
 
-		$image_filepath = _XE_PATH_.'files/attach/xeicon/' . $virtual_site;
+		$image_filepath = _XE_PATH_ . 'files/attach/xeicon/' . $virtual_site;
 
-		if($deleteIcon) {
-			FileHandler::removeFile($image_filepath.$iconname);
+		if ($deleteIcon) {
+			FileHandler::removeFile($image_filepath . $iconname);
 			return;
 		}
 
-		$tmpicon_filepath = $image_filepath.'tmp/'.$iconname;
-		$icon_filepath = $image_filepath.$iconname;
-		if(file_exists($tmpicon_filepath))
+		$tmpicon_filepath = $image_filepath . 'tmp/' . $iconname;
+		$icon_filepath = $image_filepath . $iconname;
+		if (file_exists($tmpicon_filepath))
 		{
 			FileHandler::moveFile($tmpicon_filepath, $icon_filepath);
 		}

Braces +72 added lines, -32 removed lines

@@ -20,7 +20,9 @@ 
 	function procInstallAdminInstall()
 	{
 		$module_name = Context::get('module_name');
-		if(!$module_name) return new object(-1, 'invalid_request');
+		if(!$module_name) {
+			return new object(-1, 'invalid_request');
+		}
 
 		$oInstallController = getController('install');
 		$oInstallController->installModule($module_name, './modules/'.$module_name);
@@ -35,11 +37,16 @@ 
 	{
 		@set_time_limit(0);
 		$module_name = Context::get('module_name');
-		if(!$module_name) return new object(-1, 'invalid_request');
+		if(!$module_name) {
+			return new object(-1, 'invalid_request');
+		}
 
 		$oModule = getModule($module_name, 'class');
-		if($oModule) $output = $oModule->moduleUpdate();
-		else $output = new Object(-1, 'invalid_request');
+		if($oModule) {
+			$output = $oModule->moduleUpdate();
+		} else {
+			$output = new Object(-1, 'invalid_request');
+		}
 
 		return $output;
 	}
@@ -70,8 +77,12 @@ 
 		}
 		
 		$default_url = Context::get('default_url');
-		if($default_url && strncasecmp('http://', $default_url, 7) !== 0 && strncasecmp('https://', $default_url, 8) !== 0) $default_url = 'http://'.$default_url;
-		if($default_url && substr($default_url, -1) !== '/') $default_url = $default_url.'/';
+		if($default_url && strncasecmp('http://', $default_url, 7) !== 0 && strncasecmp('https://', $default_url, 8) !== 0) {
+			$default_url = 'http://'.$default_url;
+		}
+		if($default_url && substr($default_url, -1) !== '/') {
+			$default_url = $default_url.'/';
+		}
 
 		/* convert NON Alphabet URL to punycode URL - Alphabet URL will not be changed */
 		require_once(_XE_PATH_ . 'libs/idna_convert/idna_convert.class.php');
@@ -79,25 +90,37 @@ 
 		$default_url = $IDN->encode($default_url);
 
 		$use_ssl = Context::get('use_ssl');
-		if(!$use_ssl) $use_ssl = 'none';
+		if(!$use_ssl) {
+			$use_ssl = 'none';
+		}
 
 		$http_port = Context::get('http_port');
 		$https_port = Context::get('https_port');
 
 		$use_rewrite = Context::get('use_rewrite');
-		if($use_rewrite!='Y') $use_rewrite = 'N';
+		if($use_rewrite!='Y') {
+			$use_rewrite = 'N';
+		}
 
 		$use_sso = Context::get('use_sso');
-		if($use_sso !='Y') $use_sso = 'N';
+		if($use_sso !='Y') {
+			$use_sso = 'N';
+		}
 
 		$use_db_session = Context::get('use_db_session');
-		if($use_db_session!='Y') $use_db_session = 'N';
+		if($use_db_session!='Y') {
+			$use_db_session = 'N';
+		}
 
 		$qmail_compatibility = Context::get('qmail_compatibility');
-		if($qmail_compatibility!='Y') $qmail_compatibility = 'N';
+		if($qmail_compatibility!='Y') {
+			$qmail_compatibility = 'N';
+		}
 
 		$use_html5 = Context::get('use_html5');
-		if(!$use_html5) $use_html5 = 'N';
+		if(!$use_html5) {
+			$use_html5 = 'N';
+		}
 
 		$db_info->default_url = $default_url;
 		$db_info->qmail_compatibility = $qmail_compatibility;
@@ -108,11 +131,17 @@ 
 		$db_info->use_html5 = $use_html5;
 		$db_info->admin_ip_list = $admin_ip_list;
 
-		if($http_port) $db_info->http_port = (int) $http_port;
-		else if($db_info->http_port) unset($db_info->http_port);
+		if($http_port) {
+			$db_info->http_port = (int) $http_port;
+		} else if($db_info->http_port) {
+			unset($db_info->http_port);
+		}
 
-		if($https_port) $db_info->https_port = (int) $https_port;
-		else if($db_info->https_port) unset($db_info->https_port);
+		if($https_port) {
+			$db_info->https_port = (int) $https_port;
+		} else if($db_info->https_port) {
+			unset($db_info->https_port);
+		}
 
 		unset($db_info->lang_type);
 
@@ -120,8 +149,7 @@ 
 		if(!$oInstallController->makeConfigFile())
 		{
 			return new Object(-1, 'msg_invalid_request');
-		}
-		else
+		} else
 		{
 			Context::setDBInfo($db_info);
 			if($default_url)
@@ -173,8 +201,12 @@ 
 	function procInstallAdminRemoveFTPInfo()
 	{
 		$ftp_config_file = Context::getFTPConfigFile();
-		if(file_exists($ftp_config_file)) unlink($ftp_config_file);
-		if($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
+		if(file_exists($ftp_config_file)) {
+			unlink($ftp_config_file);
+		}
+		if($_SESSION['ftp_password']) {
+			unset($_SESSION['ftp_password']);
+		}
 		$this->setMessage('success_deleted');
 	}
 
@@ -185,15 +217,16 @@ 
 		$ftp_info->ftp_port = Context::get('ftp_port');
 		$ftp_info->ftp_host = Context::get('ftp_host');
 		$ftp_info->ftp_pasv = Context::get('ftp_pasv');
-		if(!$ftp_info->ftp_pasv) $ftp_info->ftp_pasv = "N";
+		if(!$ftp_info->ftp_pasv) {
+			$ftp_info->ftp_pasv = "N";
+		}
 		$ftp_info->sftp = Context::get('sftp');
 
 		$ftp_root_path = Context::get('ftp_root_path');
 		if(substr($ftp_root_path, strlen($ftp_root_path)-1) == "/")
 		{
 			$ftp_info->ftp_root_path = $ftp_root_path;
-		}
-		else
+		} else
 		{
 			$ftp_info->ftp_root_path = $ftp_root_path.'/';
 		}
@@ -206,7 +239,9 @@ 
 		$buff = '<?php if(!defined("__XE__")) exit();'."\n\$ftp_info = new stdClass;\n";
 		foreach($ftp_info as $key => $val)
 		{
-			if(!$val) continue;
+			if(!$val) {
+				continue;
+			}
 			if(preg_match('/(<\?|<\?php|\?>|fputs|fopen|fwrite|fgets|fread|file_get_contents|file_put_contents|exec|proc_open|popen|passthru|show_source|phpinfo|system|\/\*|\*\/|chr\()/xsm', preg_replace('/\s/', '', $val)))
 			{
 				continue;
@@ -216,7 +251,9 @@ 
 		$buff .= "?>";
 		$config_file = Context::getFTPConfigFile();
 		FileHandler::WriteFile($config_file, $buff);
-		if($_SESSION['ftp_password']) unset($_SESSION['ftp_password']);
+		if($_SESSION['ftp_password']) {
+			unset($_SESSION['ftp_password']);
+		}
 
 		$this->setMessage('success_updated');
 		$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'module', 'admin', 'act', 'dispAdminConfigFtp');
@@ -226,7 +263,9 @@ 
 	function procInstallAdminConfig()
 	{
 		$use_mobile_view = Context::get('use_mobile_view');
-		if($use_mobile_view!='Y') $use_mobile_view = 'N';
+		if($use_mobile_view!='Y') {
+			$use_mobile_view = 'N';
+		}
 
 		$time_zone = Context::get('time_zone');
 
@@ -315,8 +354,11 @@ 
 	{
 		$args = new stdClass();
 
-		if(!$config->thumbnail_type || $config->thumbnail_type != 'ratio' ) $args->thumbnail_type = 'crop';
-		else $args->thumbnail_type = 'ratio';
+		if(!$config->thumbnail_type || $config->thumbnail_type != 'ratio' ) {
+			$args->thumbnail_type = 'crop';
+		} else {
+			$args->thumbnail_type = 'ratio';
+		}
 
 		$oModuleController = getController('module');
 		$oModuleController->insertModuleConfig('document',$args);
@@ -353,8 +395,7 @@ 
 				Context::set('msg', '*.ico '.Context::getLang('msg_possible_only_file'));
 				return;
 			}
-		}
-		else if($iconname == 'mobicon.png')
+		} else if($iconname == 'mobicon.png')
 		{
 			if(!preg_match('/^.*(png).*$/',$type)) {
 				Context::set('msg', '*.png '.Context::getLang('msg_possible_only_file'));
@@ -364,8 +405,7 @@ 
 				Context::set('msg', Context::getLang('msg_invalid_format').' (size : 57x57, 114x114)');
 				return;
 			}
-		}
-		else
+		} else
 		{
 			Context::set('msg', Context::getLang('msg_invalid_format'));
 			return;

modules/install/install.controller.php

Doc Comments +2 added lines

@@ -545,6 +545,7 @@ 
 
 	/**
 	 * @brief Install an each module
+	 * @param string $module_path
 	 */
 	function installModule($module, $module_path)
 	{
@@ -614,6 +615,7 @@ 
 	/**
 	 * @brief Create etc config file
 	 * Create the config file when all settings are completed
+	 * @param stdClass $config_info
 	 */
 	function makeEtcConfigFile($config_info)
 	{

Indentation +5 added lines, -5 removed lines

@@ -1,10 +1,10 @@ 
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 /**
- * @class  installController
- * @author NAVER (developers@xpressengine.com)
- * @brief install module of the Controller class
- */
+	 * @class  installController
+	 * @author NAVER (developers@xpressengine.com)
+	 * @brief install module of the Controller class
+	 */
 class installController extends install
 {
 	var $db_tmp_config_file = '';
@@ -413,7 +413,7 @@ 
 	 * make a file to files/config and check url approach by ".htaccess" rules
 	 *
 	 * @return bool
-	*/
+	 */
 	function checkRewriteUsable() {
 		$checkString = "isApproached";
 		$checkFilePath = 'files/config/tmpRewriteCheck.txt';

Spacing +118 added lines, -118 removed lines

@@ -17,13 +17,13 @@ 
 	function init()
 	{
 		// Error occurs if already installed
-		if(Context::isInstalled())
+		if (Context::isInstalled())
 		{
 			return new Object(-1, 'msg_already_installed');
 		}
 
-		$this->db_tmp_config_file = _XE_PATH_.'files/config/tmpDB.config.php';
-		$this->etc_tmp_config_file = _XE_PATH_.'files/config/tmpEtc.config.php';
+		$this->db_tmp_config_file = _XE_PATH_ . 'files/config/tmpDB.config.php';
+		$this->etc_tmp_config_file = _XE_PATH_ . 'files/config/tmpEtc.config.php';
 	}
 
 	/**
@@ -86,7 +86,7 @@ 
 	function _procDBSetting()
 	{
 		// Get DB-related variables
-		$con_string = Context::gets('db_type','db_port','db_hostname','db_userid','db_password','db_database','db_table_prefix');
+		$con_string = Context::gets('db_type', 'db_port', 'db_hostname', 'db_userid', 'db_password', 'db_database', 'db_table_prefix');
 
 		$db_info = new stdClass();
 		$db_info->master_db = get_object_vars($con_string);
@@ -101,16 +101,16 @@ 
 		// Check if available to connect to the DB
 		$oDB = &DB::getInstance();
 		$output = $oDB->getError();
-		if(!$output->toBool()) return $output;
-		if(!$oDB->isConnected()) return $oDB->getError();
+		if (!$output->toBool()) return $output;
+		if (!$oDB->isConnected()) return $oDB->getError();
 
 		// Create a db temp config file
-		if(!$this->makeDBConfigFile()) return new Object(-1, 'msg_install_failed');
+		if (!$this->makeDBConfigFile()) return new Object(-1, 'msg_install_failed');
 
-		if(!in_array(Context::getRequestMethod(),array('XMLRPC','JSON')))
+		if (!in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON')))
 		{
 			$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'act', 'dispInstallConfigForm');
-			header('location:'.$returnUrl);
+			header('location:' . $returnUrl);
 			return;
 		}
 	}
@@ -121,16 +121,16 @@ 
 	function procConfigSetting()
 	{
 		// Get variables
-		$config_info = Context::gets('use_rewrite','time_zone');
-		if($config_info->use_rewrite!='Y') $config_info->use_rewrite = 'N';
+		$config_info = Context::gets('use_rewrite', 'time_zone');
+		if ($config_info->use_rewrite != 'Y') $config_info->use_rewrite = 'N';
 
 		// Create a db temp config file
-		if(!$this->makeEtcConfigFile($config_info)) return new Object(-1, 'msg_install_failed');
+		if (!$this->makeEtcConfigFile($config_info)) return new Object(-1, 'msg_install_failed');
 
-		if(!in_array(Context::getRequestMethod(),array('XMLRPC','JSON')))
+		if (!in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON')))
 		{
 			$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'act', 'dispInstallManagerForm');
-			header('location:'.$returnUrl);
+			header('location:' . $returnUrl);
 			return;
 		}
 	}
@@ -141,7 +141,7 @@ 
 	function procInstall()
 	{
 		// Check if it is already installed
-		if(Context::isInstalled()) return new Object(-1, 'msg_already_installed');
+		if (Context::isInstalled()) return new Object(-1, 'msg_already_installed');
 
 		// Assign a temporary administrator when installing
 		$logged_info = new stdClass();
@@ -149,15 +149,15 @@ 
 		Context::set('logged_info', $logged_info);
 
 		// check install config
-		if(Context::get('install_config'))
+		if (Context::get('install_config'))
 		{
 			$db_info = $this->_makeDbInfoByInstallConfig();
 		}
 		// install by default XE UI
 		else
 		{
-			if(FileHandler::exists($this->db_tmp_config_file)) include $this->db_tmp_config_file;
-			if(FileHandler::exists($this->etc_tmp_config_file)) include $this->etc_tmp_config_file;
+			if (FileHandler::exists($this->db_tmp_config_file)) include $this->db_tmp_config_file;
+			if (FileHandler::exists($this->etc_tmp_config_file)) include $this->etc_tmp_config_file;
 		}
 
 		// Set DB type and information
@@ -165,27 +165,27 @@ 
 		// Create DB Instance
 		$oDB = &DB::getInstance();
 		// Check if available to connect to the DB
-		if(!$oDB->isConnected()) return $oDB->getError();
+		if (!$oDB->isConnected()) return $oDB->getError();
 
 		// Install all the modules
 		try {
 			$oDB->begin();
 			$this->installDownloadedModule();
 			$oDB->commit();
-		} catch(Exception $e) {
+		} catch (Exception $e) {
 			$oDB->rollback();
 			return new Object(-1, $e->getMessage());
 		}
 
 		// Create a config file
-		if(!$this->makeConfigFile()) return new Object(-1, 'msg_install_failed');
+		if (!$this->makeConfigFile()) return new Object(-1, 'msg_install_failed');
 
 		// load script
 		$scripts = FileHandler::readDir(_XE_PATH_ . 'modules/install/script', '/(\.php)$/');
-		if(count($scripts)>0)
+		if (count($scripts) > 0)
 		{
 			sort($scripts);
-			foreach($scripts as $script)
+			foreach ($scripts as $script)
 			{
 				$script_path = FileHandler::getRealPath('./modules/install/script/');
 				$output = include($script_path . $script);
@@ -201,10 +201,10 @@ 
 
 		unset($_SESSION['use_rewrite']);
 
-		if(!in_array(Context::getRequestMethod(),array('XMLRPC','JSON')))
+		if (!in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON')))
 		{
 			$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('');
-			header('location:'.$returnUrl);
+			header('location:' . $returnUrl);
 			return new Object();
 		}
 	}
@@ -239,57 +239,57 @@ 
 	 */
 	function procInstallFTP()
 	{
-		if(Context::isInstalled()) return new Object(-1, 'msg_already_installed');
-		$ftp_info = Context::gets('ftp_host', 'ftp_user','ftp_password','ftp_port','ftp_root_path');
-		$ftp_info->ftp_port = (int)$ftp_info->ftp_port;
-		if(!$ftp_info->ftp_port) $ftp_info->ftp_port = 21;
-		if(!$ftp_info->ftp_host) $ftp_info->ftp_host = '127.0.0.1';
-		if(!$ftp_info->ftp_root_path) $ftp_info->ftp_root_path = '/';
+		if (Context::isInstalled()) return new Object(-1, 'msg_already_installed');
+		$ftp_info = Context::gets('ftp_host', 'ftp_user', 'ftp_password', 'ftp_port', 'ftp_root_path');
+		$ftp_info->ftp_port = (int) $ftp_info->ftp_port;
+		if (!$ftp_info->ftp_port) $ftp_info->ftp_port = 21;
+		if (!$ftp_info->ftp_host) $ftp_info->ftp_host = '127.0.0.1';
+		if (!$ftp_info->ftp_root_path) $ftp_info->ftp_root_path = '/';
 
 		$buff = array('<?php if(!defined("__XE__")) exit();');
 		$buff[] = "\$ftp_info = new stdClass();";
-		foreach($ftp_info as $key => $val)
+		foreach ($ftp_info as $key => $val)
 		{
-			$buff[] = sprintf("\$ftp_info->%s='%s';", $key, str_replace("'","\\'",$val));
+			$buff[] = sprintf("\$ftp_info->%s='%s';", $key, str_replace("'", "\\'", $val));
 		}
 
 		// If safe_mode
-		if(ini_get('safe_mode'))
+		if (ini_get('safe_mode'))
 		{
-			if(!$ftp_info->ftp_user || !$ftp_info->ftp_password) return new Object(-1,'msg_safe_mode_ftp_needed');
+			if (!$ftp_info->ftp_user || !$ftp_info->ftp_password) return new Object(-1, 'msg_safe_mode_ftp_needed');
 
-			require_once(_XE_PATH_.'libs/ftp.class.php');
+			require_once(_XE_PATH_ . 'libs/ftp.class.php');
 			$oFtp = new ftp();
-			if(!$oFtp->ftp_connect($ftp_info->ftp_host, $ftp_info->ftp_port)) return new Object(-1, sprintf(Context::getLang('msg_ftp_not_connected'), $ftp_info->ftp_host));
+			if (!$oFtp->ftp_connect($ftp_info->ftp_host, $ftp_info->ftp_port)) return new Object(-1, sprintf(Context::getLang('msg_ftp_not_connected'), $ftp_info->ftp_host));
 
-			if(!$oFtp->ftp_login($ftp_info->ftp_user, $ftp_info->ftp_password))
+			if (!$oFtp->ftp_login($ftp_info->ftp_user, $ftp_info->ftp_password))
 			{
 				$oFtp->ftp_quit();
-				return new Object(-1,'msg_ftp_invalid_auth_info');
+				return new Object(-1, 'msg_ftp_invalid_auth_info');
 			}
 
-			if(!is_dir(_XE_PATH_.'files') && !$oFtp->ftp_mkdir($ftp_info->ftp_root_path.'files'))
+			if (!is_dir(_XE_PATH_ . 'files') && !$oFtp->ftp_mkdir($ftp_info->ftp_root_path . 'files'))
 			{
 				$oFtp->ftp_quit();
-				return new Object(-1,'msg_ftp_mkdir_fail');
+				return new Object(-1, 'msg_ftp_mkdir_fail');
 			}
 
-			if(!$oFtp->ftp_site("CHMOD 777 ".$ftp_info->ftp_root_path.'files'))
+			if (!$oFtp->ftp_site("CHMOD 777 " . $ftp_info->ftp_root_path . 'files'))
 			{
 				$oFtp->ftp_quit();
-				return new Object(-1,'msg_ftp_chmod_fail');
+				return new Object(-1, 'msg_ftp_chmod_fail');
 			}
 
-			if(!is_dir(_XE_PATH_.'files/config') && !$oFtp->ftp_mkdir($ftp_info->ftp_root_path.'files/config'))
+			if (!is_dir(_XE_PATH_ . 'files/config') && !$oFtp->ftp_mkdir($ftp_info->ftp_root_path . 'files/config'))
 			{
 				$oFtp->ftp_quit();
-				return new Object(-1,'msg_ftp_mkdir_fail');
+				return new Object(-1, 'msg_ftp_mkdir_fail');
 			}
 
-			if(!$oFtp->ftp_site("CHMOD 777 ".$ftp_info->ftp_root_path.'files/config'))
+			if (!$oFtp->ftp_site("CHMOD 777 " . $ftp_info->ftp_root_path . 'files/config'))
 			{
 				$oFtp->ftp_quit();
-				return new Object(-1,'msg_ftp_chmod_fail');
+				return new Object(-1, 'msg_ftp_chmod_fail');
 			}
 
 			$oFtp->ftp_quit();
@@ -300,31 +300,31 @@ 
 
 	function procInstallCheckFtp()
 	{
-		$ftp_info = Context::gets('ftp_user','ftp_password','ftp_port','sftp');
-		$ftp_info->ftp_port = (int)$ftp_info->ftp_port;
-		if(!$ftp_info->ftp_port) $ftp_info->ftp_port = 21;
-		if(!$ftp_info->sftp) $ftp_info->sftp = 'N';
+		$ftp_info = Context::gets('ftp_user', 'ftp_password', 'ftp_port', 'sftp');
+		$ftp_info->ftp_port = (int) $ftp_info->ftp_port;
+		if (!$ftp_info->ftp_port) $ftp_info->ftp_port = 21;
+		if (!$ftp_info->sftp) $ftp_info->sftp = 'N';
 
-		if(!$ftp_info->ftp_user || !$ftp_info->ftp_password) return new Object(-1,'msg_safe_mode_ftp_needed');
+		if (!$ftp_info->ftp_user || !$ftp_info->ftp_password) return new Object(-1, 'msg_safe_mode_ftp_needed');
 
-		if($ftp_info->sftp == 'Y')
+		if ($ftp_info->sftp == 'Y')
 		{
 			$connection = ssh2_connect('localhost', $ftp_info->ftp_port);
-			if(!ssh2_auth_password($connection, $ftp_info->ftp_user, $ftp_info->ftp_password))
+			if (!ssh2_auth_password($connection, $ftp_info->ftp_user, $ftp_info->ftp_password))
 			{
-				return new Object(-1,'msg_ftp_invalid_auth_info');
+				return new Object(-1, 'msg_ftp_invalid_auth_info');
 			}
 		}
 		else
 		{
-			require_once(_XE_PATH_.'libs/ftp.class.php');
+			require_once(_XE_PATH_ . 'libs/ftp.class.php');
 			$oFtp = new ftp();
-			if(!$oFtp->ftp_connect('127.0.0.1', $ftp_info->ftp_port)) return new Object(-1, sprintf(Context::getLang('msg_ftp_not_connected'), 'localhost'));
+			if (!$oFtp->ftp_connect('127.0.0.1', $ftp_info->ftp_port)) return new Object(-1, sprintf(Context::getLang('msg_ftp_not_connected'), 'localhost'));
 
-			if(!$oFtp->ftp_login($ftp_info->ftp_user, $ftp_info->ftp_password))
+			if (!$oFtp->ftp_login($ftp_info->ftp_user, $ftp_info->ftp_password))
 			{
 				$oFtp->ftp_quit();
-				return new Object(-1,'msg_ftp_invalid_auth_info');
+				return new Object(-1, 'msg_ftp_invalid_auth_info');
 			}
 			$oFtp->ftp_quit();
 		}
@@ -341,36 +341,36 @@ 
 		$checklist = array();
 		// 0. check your version of php (5.2.4 or higher)
 		$checklist['php_version'] = true;
-		if(version_compare(PHP_VERSION, __XE_MIN_PHP_VERSION__, '<'))
+		if (version_compare(PHP_VERSION, __XE_MIN_PHP_VERSION__, '<'))
 		{
 			$checklist['php_version'] = false;
 		}
 
-		if(version_compare(PHP_VERSION, __XE_RECOMMEND_PHP_VERSION__, '<'))
+		if (version_compare(PHP_VERSION, __XE_RECOMMEND_PHP_VERSION__, '<'))
 		{
 			Context::set('phpversion_warning', true);
 		}
 
 		// 1. Check permission
-		if(is_writable('./')||is_writable('./files')) $checklist['permission'] = true;
+		if (is_writable('./') || is_writable('./files')) $checklist['permission'] = true;
 		else $checklist['permission'] = false;
 		// 2. Check if xml_parser_create exists
-		if(function_exists('xml_parser_create')) $checklist['xml'] = true;
+		if (function_exists('xml_parser_create')) $checklist['xml'] = true;
 		else $checklist['xml'] = false;
 		// 3. Check if ini_get (session.auto_start) == 1
-		if(ini_get('session.auto_start')!=1) $checklist['session'] = true;
+		if (ini_get('session.auto_start') != 1) $checklist['session'] = true;
 		else $checklist['session'] = false;
 		// 4. Check if iconv exists
-		if(function_exists('iconv')) $checklist['iconv'] = true;
+		if (function_exists('iconv')) $checklist['iconv'] = true;
 		else $checklist['iconv'] = false;
 		// 5. Check gd(imagecreatefromgif function)
-		if(function_exists('imagecreatefromgif')) $checklist['gd'] = true;
+		if (function_exists('imagecreatefromgif')) $checklist['gd'] = true;
 		else $checklist['gd'] = false;
 		// 6. Check DB
-		if(DB::getEnableList()) $checklist['db'] = true;
+		if (DB::getEnableList()) $checklist['db'] = true;
 		else $checklist['db'] = false;
 
-		if(!$checklist['php_version'] || !$checklist['permission'] || !$checklist['xml'] || !$checklist['session'] || !$checklist['db']) $install_enable = false;
+		if (!$checklist['php_version'] || !$checklist['permission'] || !$checklist['xml'] || !$checklist['session'] || !$checklist['db']) $install_enable = false;
 		else $install_enable = true;
 
 		// Save the checked result to the Context
@@ -390,7 +390,7 @@ 
 
 		$license_agreement = ($vars->license_agreement == 'Y') ? true : false;
 
-		if($license_agreement)
+		if ($license_agreement)
 		{
 			$currentTime = $_SERVER['REQUEST_TIME'];
 			FileHandler::writeFile($this->flagLicenseAgreement, $currentTime);
@@ -401,7 +401,7 @@ 
 			return new Object(-1, 'msg_must_accept_license_agreement');
 		}
 
-		if(!in_array(Context::getRequestMethod(),array('XMLRPC','JSON')))
+		if (!in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON')))
 		{
 			$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'act', 'dispInstallCheckEnv');
 			$this->setRedirectUrl($returnUrl);
@@ -418,13 +418,13 @@ 
 		$checkString = "isApproached";
 		$checkFilePath = 'files/config/tmpRewriteCheck.txt';
 
-		FileHandler::writeFile(_XE_PATH_.$checkFilePath, trim($checkString));
+		FileHandler::writeFile(_XE_PATH_ . $checkFilePath, trim($checkString));
 
 		$scheme = ($_SERVER['HTTPS'] === 'on') ? 'https' : 'http';
 		$hostname = $_SERVER['SERVER_NAME'];
 		$port = $_SERVER['SERVER_PORT'];
 		$str_port = '';
-		if($port)
+		if ($port)
 		{
 			$str_port = ':' . $port;
 		}
@@ -432,7 +432,7 @@ 
 		$tmpPath = $_SERVER['DOCUMENT_ROOT'];
 
 		//if DIRECTORY_SEPARATOR is not /(IIS)
-		if(DIRECTORY_SEPARATOR !== '/')
+		if (DIRECTORY_SEPARATOR !== '/')
 		{
 			//change to slash for compare
 			$tmpPath = str_replace(DIRECTORY_SEPARATOR, '/', $_SERVER['DOCUMENT_ROOT']);
@@ -440,7 +440,7 @@ 
 
 		$query = "/JUST/CHECK/REWRITE/" . $checkFilePath;
 		$currentPath = str_replace($tmpPath, "", _XE_PATH_);
-		if($currentPath != "")
+		if ($currentPath != "")
 		{
 			$query = $currentPath . $query;
 		}
@@ -449,7 +449,7 @@ 
 		$requestConfig['ssl_verify_peer'] = false;
 		$buff = FileHandler::getRemoteResource($requestUrl, null, 3, 'GET', null, array(), array(), array(), $requestConfig);
 
-		FileHandler::removeFile(_XE_PATH_.$checkFilePath);
+		FileHandler::removeFile(_XE_PATH_ . $checkFilePath);
 
 		return (trim($buff) == $checkString);
 	}
@@ -467,7 +467,7 @@ 
 			'./files/cache/template_compiled',
 		);
 
-		foreach($directory_list as $dir)
+		foreach ($directory_list as $dir)
 		{
 			FileHandler::makeDir($dir);
 		}
@@ -483,57 +483,57 @@ 
 		$oModuleModel = getModel('module');
 		// Create a table ny finding schemas/*.xml file in each module
 		$module_list = FileHandler::readDir('./modules/', NULL, false, true);
-		foreach($module_list as $module_path)
+		foreach ($module_list as $module_path)
 		{
 			// Get module name
-			$tmp_arr = explode('/',$module_path);
-			$module = $tmp_arr[count($tmp_arr)-1];
+			$tmp_arr = explode('/', $module_path);
+			$module = $tmp_arr[count($tmp_arr) - 1];
 
 			$xml_info = $oModuleModel->getModuleInfoXml($module);
-			if(!$xml_info) continue;
+			if (!$xml_info) continue;
 			$modules[$xml_info->category][] = $module;
 		}
 		// Install "module" module in advance
-		$this->installModule('module','./modules/module');
+		$this->installModule('module', './modules/module');
 		$oModule = getClass('module');
-		if($oModule->checkUpdate()) $oModule->moduleUpdate();
+		if ($oModule->checkUpdate()) $oModule->moduleUpdate();
 		// Determine the order of module installation depending on category
-		$install_step = array('system','content','member');
+		$install_step = array('system', 'content', 'member');
 		// Install all the remaining modules
-		foreach($install_step as $category)
+		foreach ($install_step as $category)
 		{
-			if(count($modules[$category]))
+			if (count($modules[$category]))
 			{
-				foreach($modules[$category] as $module)
+				foreach ($modules[$category] as $module)
 				{
-					if($module == 'module') continue;
+					if ($module == 'module') continue;
 					$this->installModule($module, sprintf('./modules/%s', $module));
 
 					$oModule = getClass($module);
-					if(is_object($oModule) && method_exists($oModule, 'checkUpdate'))
+					if (is_object($oModule) && method_exists($oModule, 'checkUpdate'))
 					{
-						if($oModule->checkUpdate()) $oModule->moduleUpdate();
+						if ($oModule->checkUpdate()) $oModule->moduleUpdate();
 					}
 				}
 				unset($modules[$category]);
 			}
 		}
 		// Install all the remaining modules
-		if(count($modules))
+		if (count($modules))
 		{
-			foreach($modules as $category => $module_list)
+			foreach ($modules as $category => $module_list)
 			{
-				if(count($module_list))
+				if (count($module_list))
 				{
-					foreach($module_list as $module)
+					foreach ($module_list as $module)
 					{
-						if($module == 'module') continue;
+						if ($module == 'module') continue;
 						$this->installModule($module, sprintf('./modules/%s', $module));
 
 						$oModule = getClass($module);
-						if($oModule && method_exists($oModule, 'checkUpdate') && method_exists($oModule, 'moduleUpdate'))
+						if ($oModule && method_exists($oModule, 'checkUpdate') && method_exists($oModule, 'moduleUpdate'))
 						{
-							if($oModule->checkUpdate()) $oModule->moduleUpdate();
+							if ($oModule->checkUpdate()) $oModule->moduleUpdate();
 						}
 					}
 				}
@@ -555,31 +555,31 @@ 
 		$schema_files = FileHandler::readDir($schema_dir, NULL, false, true);
 
 		$file_cnt = count($schema_files);
-		for($i=0;$i<$file_cnt;$i++)
+		for ($i = 0; $i < $file_cnt; $i++)
 		{
 			$file = trim($schema_files[$i]);
-			if(!$file || substr($file,-4)!='.xml') continue;
+			if (!$file || substr($file, -4) != '.xml') continue;
 			$output = $oDB->createTableByXmlFile($file);
-			if($output === false)
+			if ($output === false)
 				throw new Exception('msg_create_table_failed');
 		}
 		// Create a table and module instance and then execute install() method
 		unset($oModule);
 		$oModule = getClass($module);
-		if(method_exists($oModule, 'moduleInstall')) $oModule->moduleInstall();
+		if (method_exists($oModule, 'moduleInstall')) $oModule->moduleInstall();
 		return new Object();
 	}
 
 	function _getDBConfigFileContents($db_info)
 	{
-		if(substr($db_info->master_db['db_table_prefix'], -1) != '_')
+		if (substr($db_info->master_db['db_table_prefix'], -1) != '_')
 		{
 			$db_info->master_db['db_table_prefix'] .= '_';
 		}
 
-		foreach($db_info->slave_db as &$slave)
+		foreach ($db_info->slave_db as &$slave)
 		{
-			if(substr($slave['db_table_prefix'], -1) != '_')
+			if (substr($slave['db_table_prefix'], -1) != '_')
 			{
 				$slave['db_table_prefix'] .= '_';
 			}
@@ -601,13 +601,13 @@ 
 		$db_tmp_config_file = $this->db_tmp_config_file;
 
 		$db_info = Context::getDbInfo();
-		if(!$db_info) return;
+		if (!$db_info) return;
 
 		$buff = $this->_getDBConfigFileContents($db_info);
 
 		FileHandler::writeFile($db_tmp_config_file, $buff);
 
-		if(@file_exists($db_tmp_config_file)) return true;
+		if (@file_exists($db_tmp_config_file)) return true;
 		return false;
 	}
 
@@ -619,15 +619,15 @@ 
 	{
 		$etc_tmp_config_file = $this->etc_tmp_config_file;
 
-		$buff = '<?php if(!defined("__XE__")) exit();'."\n";
-		foreach($config_info as $key => $val)
+		$buff = '<?php if(!defined("__XE__")) exit();' . "\n";
+		foreach ($config_info as $key => $val)
 		{
-			$buff .= sprintf("\$db_info->%s = '%s';\n", $key, str_replace("'","\\'",$val));
+			$buff .= sprintf("\$db_info->%s = '%s';\n", $key, str_replace("'", "\\'", $val));
 		}
 
 		FileHandler::writeFile($etc_tmp_config_file, $buff);
 
-		if(@file_exists($etc_tmp_config_file)) return true;
+		if (@file_exists($etc_tmp_config_file)) return true;
 		return false;
 	}
 
@@ -642,13 +642,13 @@ 
 			//if(file_exists($config_file)) return;
 
 			$db_info = Context::getDbInfo();
-			if(!$db_info) return;
+			if (!$db_info) return;
 
 			$buff = $this->_getDBConfigFileContents($db_info);
 
 			FileHandler::writeFile($config_file, $buff);
 
-			if(@file_exists($config_file))
+			if (@file_exists($config_file))
 			{
 				FileHandler::removeFile($this->db_tmp_config_file);
 				FileHandler::removeFile($this->etc_tmp_config_file);
@@ -663,7 +663,7 @@ 
 	function installByConfig($install_config_file)
 	{
 		include $install_config_file;
-		if(!is_array($auto_config)) return false;
+		if (!is_array($auto_config)) return false;
 
 		$auto_config['module'] = 'install';
 		$auto_config['act'] = 'procInstall';
@@ -671,22 +671,22 @@ 
 		$fstr = "<%s><![CDATA[%s]]></%s>\r\n";
 		$fheader = "POST %s HTTP/1.1\r\nHost: %s\r\nContent-Type: application/xml\r\nContent-Length: %s\r\n\r\n%s\r\n";
 		$body = "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\r\n<methodCall>\r\n<params>\r\n";
-		foreach($auto_config as $k => $v)
+		foreach ($auto_config as $k => $v)
 		{
-			if(!in_array($k,array('host','port','path'))) $body .= sprintf($fstr,$k,$v,$k);
+			if (!in_array($k, array('host', 'port', 'path'))) $body .= sprintf($fstr, $k, $v, $k);
 		}
 		$body .= "</params>\r\n</methodCall>";
 
-		$header = sprintf($fheader,$auto_config['path'],$auto_config['host'],strlen($body),$body);
+		$header = sprintf($fheader, $auto_config['path'], $auto_config['host'], strlen($body), $body);
 		$fp = @fsockopen($auto_config['host'], $auto_config['port'], $errno, $errstr, 5);
 
-		if($fp)
+		if ($fp)
 		{
 			fputs($fp, $header);
-			while(!feof($fp))
+			while (!feof($fp))
 			{
 				$line = trim(fgets($fp, 4096));
-				if(strncmp('<error>', $line, 7) === 0)
+				if (strncmp('<error>', $line, 7) === 0)
 				{
 					fclose($fp);
 					return false;

Braces +142 added lines, -54 removed lines

@@ -101,11 +101,17 @@ 
 		// Check if available to connect to the DB
 		$oDB = &DB::getInstance();
 		$output = $oDB->getError();
-		if(!$output->toBool()) return $output;
-		if(!$oDB->isConnected()) return $oDB->getError();
+		if(!$output->toBool()) {
+			return $output;
+		}
+		if(!$oDB->isConnected()) {
+			return $oDB->getError();
+		}
 
 		// Create a db temp config file
-		if(!$this->makeDBConfigFile()) return new Object(-1, 'msg_install_failed');
+		if(!$this->makeDBConfigFile()) {
+			return new Object(-1, 'msg_install_failed');
+		}
 
 		if(!in_array(Context::getRequestMethod(),array('XMLRPC','JSON')))
 		{
@@ -122,10 +128,14 @@ 
 	{
 		// Get variables
 		$config_info = Context::gets('use_rewrite','time_zone');
-		if($config_info->use_rewrite!='Y') $config_info->use_rewrite = 'N';
+		if($config_info->use_rewrite!='Y') {
+			$config_info->use_rewrite = 'N';
+		}
 
 		// Create a db temp config file
-		if(!$this->makeEtcConfigFile($config_info)) return new Object(-1, 'msg_install_failed');
+		if(!$this->makeEtcConfigFile($config_info)) {
+			return new Object(-1, 'msg_install_failed');
+		}
 
 		if(!in_array(Context::getRequestMethod(),array('XMLRPC','JSON')))
 		{
@@ -141,7 +151,9 @@ 
 	function procInstall()
 	{
 		// Check if it is already installed
-		if(Context::isInstalled()) return new Object(-1, 'msg_already_installed');
+		if(Context::isInstalled()) {
+			return new Object(-1, 'msg_already_installed');
+		}
 
 		// Assign a temporary administrator when installing
 		$logged_info = new stdClass();
@@ -156,8 +168,12 @@ 
 		// install by default XE UI
 		else
 		{
-			if(FileHandler::exists($this->db_tmp_config_file)) include $this->db_tmp_config_file;
-			if(FileHandler::exists($this->etc_tmp_config_file)) include $this->etc_tmp_config_file;
+			if(FileHandler::exists($this->db_tmp_config_file)) {
+				include $this->db_tmp_config_file;
+			}
+			if(FileHandler::exists($this->etc_tmp_config_file)) {
+				include $this->etc_tmp_config_file;
+			}
 		}
 
 		// Set DB type and information
@@ -165,7 +181,9 @@ 
 		// Create DB Instance
 		$oDB = &DB::getInstance();
 		// Check if available to connect to the DB
-		if(!$oDB->isConnected()) return $oDB->getError();
+		if(!$oDB->isConnected()) {
+			return $oDB->getError();
+		}
 
 		// Install all the modules
 		try {
@@ -178,7 +196,9 @@ 
 		}
 
 		// Create a config file
-		if(!$this->makeConfigFile()) return new Object(-1, 'msg_install_failed');
+		if(!$this->makeConfigFile()) {
+			return new Object(-1, 'msg_install_failed');
+		}
 
 		// load script
 		$scripts = FileHandler::readDir(_XE_PATH_ . 'modules/install/script', '/(\.php)$/');
@@ -239,12 +259,20 @@ 
 	 */
 	function procInstallFTP()
 	{
-		if(Context::isInstalled()) return new Object(-1, 'msg_already_installed');
+		if(Context::isInstalled()) {
+			return new Object(-1, 'msg_already_installed');
+		}
 		$ftp_info = Context::gets('ftp_host', 'ftp_user','ftp_password','ftp_port','ftp_root_path');
 		$ftp_info->ftp_port = (int)$ftp_info->ftp_port;
-		if(!$ftp_info->ftp_port) $ftp_info->ftp_port = 21;
-		if(!$ftp_info->ftp_host) $ftp_info->ftp_host = '127.0.0.1';
-		if(!$ftp_info->ftp_root_path) $ftp_info->ftp_root_path = '/';
+		if(!$ftp_info->ftp_port) {
+			$ftp_info->ftp_port = 21;
+		}
+		if(!$ftp_info->ftp_host) {
+			$ftp_info->ftp_host = '127.0.0.1';
+		}
+		if(!$ftp_info->ftp_root_path) {
+			$ftp_info->ftp_root_path = '/';
+		}
 
 		$buff = array('<?php if(!defined("__XE__")) exit();');
 		$buff[] = "\$ftp_info = new stdClass();";
@@ -256,11 +284,15 @@ 
 		// If safe_mode
 		if(ini_get('safe_mode'))
 		{
-			if(!$ftp_info->ftp_user || !$ftp_info->ftp_password) return new Object(-1,'msg_safe_mode_ftp_needed');
+			if(!$ftp_info->ftp_user || !$ftp_info->ftp_password) {
+				return new Object(-1,'msg_safe_mode_ftp_needed');
+			}
 
 			require_once(_XE_PATH_.'libs/ftp.class.php');
 			$oFtp = new ftp();
-			if(!$oFtp->ftp_connect($ftp_info->ftp_host, $ftp_info->ftp_port)) return new Object(-1, sprintf(Context::getLang('msg_ftp_not_connected'), $ftp_info->ftp_host));
+			if(!$oFtp->ftp_connect($ftp_info->ftp_host, $ftp_info->ftp_port)) {
+				return new Object(-1, sprintf(Context::getLang('msg_ftp_not_connected'), $ftp_info->ftp_host));
+			}
 
 			if(!$oFtp->ftp_login($ftp_info->ftp_user, $ftp_info->ftp_password))
 			{
@@ -302,10 +334,16 @@ 
 	{
 		$ftp_info = Context::gets('ftp_user','ftp_password','ftp_port','sftp');
 		$ftp_info->ftp_port = (int)$ftp_info->ftp_port;
-		if(!$ftp_info->ftp_port) $ftp_info->ftp_port = 21;
-		if(!$ftp_info->sftp) $ftp_info->sftp = 'N';
+		if(!$ftp_info->ftp_port) {
+			$ftp_info->ftp_port = 21;
+		}
+		if(!$ftp_info->sftp) {
+			$ftp_info->sftp = 'N';
+		}
 
-		if(!$ftp_info->ftp_user || !$ftp_info->ftp_password) return new Object(-1,'msg_safe_mode_ftp_needed');
+		if(!$ftp_info->ftp_user || !$ftp_info->ftp_password) {
+			return new Object(-1,'msg_safe_mode_ftp_needed');
+		}
 
 		if($ftp_info->sftp == 'Y')
 		{
@@ -314,12 +352,13 @@ 
 			{
 				return new Object(-1,'msg_ftp_invalid_auth_info');
 			}
-		}
-		else
+		} else
 		{
 			require_once(_XE_PATH_.'libs/ftp.class.php');
 			$oFtp = new ftp();
-			if(!$oFtp->ftp_connect('127.0.0.1', $ftp_info->ftp_port)) return new Object(-1, sprintf(Context::getLang('msg_ftp_not_connected'), 'localhost'));
+			if(!$oFtp->ftp_connect('127.0.0.1', $ftp_info->ftp_port)) {
+				return new Object(-1, sprintf(Context::getLang('msg_ftp_not_connected'), 'localhost'));
+			}
 
 			if(!$oFtp->ftp_login($ftp_info->ftp_user, $ftp_info->ftp_password))
 			{
@@ -352,26 +391,47 @@ 
 		}
 
 		// 1. Check permission
-		if(is_writable('./')||is_writable('./files')) $checklist['permission'] = true;
-		else $checklist['permission'] = false;
+		if(is_writable('./')||is_writable('./files')) {
+			$checklist['permission'] = true;
+		} else {
+			$checklist['permission'] = false;
+		}
 		// 2. Check if xml_parser_create exists
-		if(function_exists('xml_parser_create')) $checklist['xml'] = true;
-		else $checklist['xml'] = false;
+		if(function_exists('xml_parser_create')) {
+			$checklist['xml'] = true;
+		} else {
+			$checklist['xml'] = false;
+		}
 		// 3. Check if ini_get (session.auto_start) == 1
-		if(ini_get('session.auto_start')!=1) $checklist['session'] = true;
-		else $checklist['session'] = false;
+		if(ini_get('session.auto_start')!=1) {
+			$checklist['session'] = true;
+		} else {
+			$checklist['session'] = false;
+		}
 		// 4. Check if iconv exists
-		if(function_exists('iconv')) $checklist['iconv'] = true;
-		else $checklist['iconv'] = false;
+		if(function_exists('iconv')) {
+			$checklist['iconv'] = true;
+		} else {
+			$checklist['iconv'] = false;
+		}
 		// 5. Check gd(imagecreatefromgif function)
-		if(function_exists('imagecreatefromgif')) $checklist['gd'] = true;
-		else $checklist['gd'] = false;
+		if(function_exists('imagecreatefromgif')) {
+			$checklist['gd'] = true;
+		} else {
+			$checklist['gd'] = false;
+		}
 		// 6. Check DB
-		if(DB::getEnableList()) $checklist['db'] = true;
-		else $checklist['db'] = false;
+		if(DB::getEnableList()) {
+			$checklist['db'] = true;
+		} else {
+			$checklist['db'] = false;
+		}
 
-		if(!$checklist['php_version'] || !$checklist['permission'] || !$checklist['xml'] || !$checklist['session'] || !$checklist['db']) $install_enable = false;
-		else $install_enable = true;
+		if(!$checklist['php_version'] || !$checklist['permission'] || !$checklist['xml'] || !$checklist['session'] || !$checklist['db']) {
+			$install_enable = false;
+		} else {
+			$install_enable = true;
+		}
 
 		// Save the checked result to the Context
 		Context::set('checklist', $checklist);
@@ -394,8 +454,7 @@ 
 		{
 			$currentTime = $_SERVER['REQUEST_TIME'];
 			FileHandler::writeFile($this->flagLicenseAgreement, $currentTime);
-		}
-		else
+		} else
 		{
 			FileHandler::removeFile($this->flagLicenseAgreement);
 			return new Object(-1, 'msg_must_accept_license_agreement');
@@ -490,13 +549,17 @@ 
 			$module = $tmp_arr[count($tmp_arr)-1];
 
 			$xml_info = $oModuleModel->getModuleInfoXml($module);
-			if(!$xml_info) continue;
+			if(!$xml_info) {
+				continue;
+			}
 			$modules[$xml_info->category][] = $module;
 		}
 		// Install "module" module in advance
 		$this->installModule('module','./modules/module');
 		$oModule = getClass('module');
-		if($oModule->checkUpdate()) $oModule->moduleUpdate();
+		if($oModule->checkUpdate()) {
+			$oModule->moduleUpdate();
+		}
 		// Determine the order of module installation depending on category
 		$install_step = array('system','content','member');
 		// Install all the remaining modules
@@ -506,13 +569,17 @@ 
 			{
 				foreach($modules[$category] as $module)
 				{
-					if($module == 'module') continue;
+					if($module == 'module') {
+						continue;
+					}
 					$this->installModule($module, sprintf('./modules/%s', $module));
 
 					$oModule = getClass($module);
 					if(is_object($oModule) && method_exists($oModule, 'checkUpdate'))
 					{
-						if($oModule->checkUpdate()) $oModule->moduleUpdate();
+						if($oModule->checkUpdate()) {
+							$oModule->moduleUpdate();
+						}
 					}
 				}
 				unset($modules[$category]);
@@ -527,13 +594,17 @@ 
 				{
 					foreach($module_list as $module)
 					{
-						if($module == 'module') continue;
+						if($module == 'module') {
+							continue;
+						}
 						$this->installModule($module, sprintf('./modules/%s', $module));
 
 						$oModule = getClass($module);
 						if($oModule && method_exists($oModule, 'checkUpdate') && method_exists($oModule, 'moduleUpdate'))
 						{
-							if($oModule->checkUpdate()) $oModule->moduleUpdate();
+							if($oModule->checkUpdate()) {
+								$oModule->moduleUpdate();
+							}
 						}
 					}
 				}
@@ -558,15 +629,20 @@ 
 		for($i=0;$i<$file_cnt;$i++)
 		{
 			$file = trim($schema_files[$i]);
-			if(!$file || substr($file,-4)!='.xml') continue;
+			if(!$file || substr($file,-4)!='.xml') {
+				continue;
+			}
 			$output = $oDB->createTableByXmlFile($file);
-			if($output === false)
-				throw new Exception('msg_create_table_failed');
+			if($output === false) {
+							throw new Exception('msg_create_table_failed');
+			}
 		}
 		// Create a table and module instance and then execute install() method
 		unset($oModule);
 		$oModule = getClass($module);
-		if(method_exists($oModule, 'moduleInstall')) $oModule->moduleInstall();
+		if(method_exists($oModule, 'moduleInstall')) {
+			$oModule->moduleInstall();
+		}
 		return new Object();
 	}
 
@@ -601,13 +677,17 @@ 
 		$db_tmp_config_file = $this->db_tmp_config_file;
 
 		$db_info = Context::getDbInfo();
-		if(!$db_info) return;
+		if(!$db_info) {
+			return;
+		}
 
 		$buff = $this->_getDBConfigFileContents($db_info);
 
 		FileHandler::writeFile($db_tmp_config_file, $buff);
 
-		if(@file_exists($db_tmp_config_file)) return true;
+		if(@file_exists($db_tmp_config_file)) {
+			return true;
+		}
 		return false;
 	}
 
@@ -627,7 +707,9 @@ 
 
 		FileHandler::writeFile($etc_tmp_config_file, $buff);
 
-		if(@file_exists($etc_tmp_config_file)) return true;
+		if(@file_exists($etc_tmp_config_file)) {
+			return true;
+		}
 		return false;
 	}
 
@@ -642,7 +724,9 @@ 
 			//if(file_exists($config_file)) return;
 
 			$db_info = Context::getDbInfo();
-			if(!$db_info) return;
+			if(!$db_info) {
+				return;
+			}
 
 			$buff = $this->_getDBConfigFileContents($db_info);
 
@@ -663,7 +747,9 @@ 
 	function installByConfig($install_config_file)
 	{
 		include $install_config_file;
-		if(!is_array($auto_config)) return false;
+		if(!is_array($auto_config)) {
+			return false;
+		}
 
 		$auto_config['module'] = 'install';
 		$auto_config['act'] = 'procInstall';
@@ -673,7 +759,9 @@ 
 		$body = "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\r\n<methodCall>\r\n<params>\r\n";
 		foreach($auto_config as $k => $v)
 		{
-			if(!in_array($k,array('host','port','path'))) $body .= sprintf($fstr,$k,$v,$k);
+			if(!in_array($k,array('host','port','path'))) {
+				$body .= sprintf($fstr,$k,$v,$k);
+			}
 		}
 		$body .= "</params>\r\n</methodCall>";
 

modules/integration_search/integration_search.view.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 	/**
 	 * Search Result
 	 *
-	 * @return Object
+	 * @return Object|null
 	 */
 	function IS()
 	{

Indentation +4 added lines, -4 removed lines

@@ -1,10 +1,10 @@
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 /**
- * The view class of the integration_search module
- *
- * @author NAVER (developers@xpressengine.com)
- */
+	 * The view class of the integration_search module
+	 *
+	 * @author NAVER (developers@xpressengine.com)
+	 */
 class integration_searchView extends integration_search
 {
 	/**

Spacing +14 added lines, -14 removed lines

@@ -39,11 +39,11 @@ 
 		$logged_info = Context::get('logged_info');
 
 		// Check permissions
-		if(!$this->grant->access) return new Object(-1,'msg_not_permitted');
+		if (!$this->grant->access) return new Object(-1, 'msg_not_permitted');
 
 		$config = $oModuleModel->getModuleConfig('integration_search');
-		if(!$config) $config = new stdClass;
-		if(!$config->skin)
+		if (!$config) $config = new stdClass;
+		if (!$config->skin)
 		{
 			$config->skin = 'default';
 			$template_path = sprintf('%sskins/%s', $this->module_path, $config->skin);
@@ -67,16 +67,16 @@ 
 		Context::set('module_info', $skin_vars);
 
 		$target = $config->target;
-		if(!$target) $target = 'include';
+		if (!$target) $target = 'include';
 
-		if(empty($config->target_module_srl))
+		if (empty($config->target_module_srl))
 			$module_srl_list = array();
 		else
-			$module_srl_list = explode(',',$config->target_module_srl);
+			$module_srl_list = explode(',', $config->target_module_srl);
 
 		// https://github.com/xpressengine/xe-core/issues/1522
 		// 검색 대상을 지정하지 않았을 때 검색 제한
-		if($target === 'include' && !count($module_srl_list))
+		if ($target === 'include' && !count($module_srl_list))
 		{
 			$oMessageObject = ModuleHandler::getModuleInstance('message');
 			$oMessageObject->setError(-1);
@@ -90,19 +90,19 @@ 
 		// Set a variable for search keyword
 		$is_keyword = Context::get('is_keyword');
 		// Set page variables
-		$page = (int)Context::get('page');
-		if(!$page) $page = 1;
+		$page = (int) Context::get('page');
+		if (!$page) $page = 1;
 		// Search by search tab
 		$where = Context::get('where');
 		// Create integration search model object
-		if($is_keyword)
+		if ($is_keyword)
 		{
 			$oIS = getModel('integration_search');
-			switch($where)
+			switch ($where)
 			{
 				case 'document' :
 					$search_target = Context::get('search_target');
-					if(!in_array($search_target, array('title','content','title_content','tag'))) $search_target = 'title';
+					if (!in_array($search_target, array('title', 'content', 'title_content', 'tag'))) $search_target = 'title';
 					Context::set('search_target', $search_target);
 
 					$output = $oIS->getDocuments($target, $module_srl_list, $search_target, $is_keyword, $page, 10);
@@ -116,7 +116,7 @@ 
 					break;
 				case 'trackback' :
 					$search_target = Context::get('search_target');
-					if(!in_array($search_target, array('title','url','blog_name','excerpt'))) $search_target = 'title';
+					if (!in_array($search_target, array('title', 'url', 'blog_name', 'excerpt'))) $search_target = 'title';
 					Context::set('search_target', $search_target);
 
 					$output = $oIS->getTrackbacks($target, $module_srl_list, $search_target, $is_keyword, $page, 10);
@@ -124,7 +124,7 @@ 
 					$this->setTemplateFile("trackback", $page);
 					break;
 				case 'multimedia' :
-					$output = $oIS->getImages($target, $module_srl_list, $is_keyword, $page,20);
+					$output = $oIS->getImages($target, $module_srl_list, $is_keyword, $page, 20);
 					Context::set('output', $output);
 					$this->setTemplateFile("multimedia", $page);
 					break;

Braces +26 added lines, -16 removed lines

@@ -39,24 +39,26 @@ 
 		$logged_info = Context::get('logged_info');
 
 		// Check permissions
-		if(!$this->grant->access) return new Object(-1,'msg_not_permitted');
+		if(!$this->grant->access) {
+			return new Object(-1,'msg_not_permitted');
+		}
 
 		$config = $oModuleModel->getModuleConfig('integration_search');
-		if(!$config) $config = new stdClass;
+		if(!$config) {
+			$config = new stdClass;
+		}
 		if(!$config->skin)
 		{
 			$config->skin = 'default';
 			$template_path = sprintf('%sskins/%s', $this->module_path, $config->skin);
-		}
-		else
+		} else
 		{
 			//check theme
 			$config_parse = explode('|@|', $config->skin);
 			if (count($config_parse) > 1)
 			{
 				$template_path = sprintf('./themes/%s/modules/integration_search/', $config_parse[0]);
-			}
-			else
+			} else
 			{
 				$template_path = sprintf('%sskins/%s', $this->module_path, $config->skin);
 			}
@@ -67,12 +69,15 @@ 
 		Context::set('module_info', $skin_vars);
 
 		$target = $config->target;
-		if(!$target) $target = 'include';
+		if(!$target) {
+			$target = 'include';
+		}
 
-		if(empty($config->target_module_srl))
-			$module_srl_list = array();
-		else
-			$module_srl_list = explode(',',$config->target_module_srl);
+		if(empty($config->target_module_srl)) {
+					$module_srl_list = array();
+		} else {
+					$module_srl_list = explode(',',$config->target_module_srl);
+		}
 
 		// https://github.com/xpressengine/xe-core/issues/1522
 		// 검색 대상을 지정하지 않았을 때 검색 제한
@@ -91,7 +96,9 @@ 
 		$is_keyword = Context::get('is_keyword');
 		// Set page variables
 		$page = (int)Context::get('page');
-		if(!$page) $page = 1;
+		if(!$page) {
+			$page = 1;
+		}
 		// Search by search tab
 		$where = Context::get('where');
 		// Create integration search model object
@@ -102,7 +109,9 @@ 
 			{
 				case 'document' :
 					$search_target = Context::get('search_target');
-					if(!in_array($search_target, array('title','content','title_content','tag'))) $search_target = 'title';
+					if(!in_array($search_target, array('title','content','title_content','tag'))) {
+						$search_target = 'title';
+					}
 					Context::set('search_target', $search_target);
 
 					$output = $oIS->getDocuments($target, $module_srl_list, $search_target, $is_keyword, $page, 10);
@@ -116,7 +125,9 @@ 
 					break;
 				case 'trackback' :
 					$search_target = Context::get('search_target');
-					if(!in_array($search_target, array('title','url','blog_name','excerpt'))) $search_target = 'title';
+					if(!in_array($search_target, array('title','url','blog_name','excerpt'))) {
+						$search_target = 'title';
+					}
 					Context::set('search_target', $search_target);
 
 					$output = $oIS->getTrackbacks($target, $module_srl_list, $search_target, $is_keyword, $page, 10);
@@ -144,8 +155,7 @@ 
 					$this->setTemplateFile("index", $page);
 					break;
 			}
-		}
-		else
+		} else
 		{
 			$this->setTemplateFile("no_keywords");
 		}

modules/layout/layout.admin.controller.php

Doc Comments +8 added lines, -8 removed lines

@@ -338,7 +338,7 @@ 
 
 	/**
 	 * Adding Layout Code
-	 * @return void|Object (void : success, Object : fail)
+	 * @return Object|null (void : success, Object : fail)
 	 */
 	function procLayoutAdminCodeUpdate()
 	{
@@ -371,7 +371,7 @@ 
 
 	/**
 	 * Reset layout code
-	 * @return void|Object (void : success, Object : fail)
+	 * @return Object|null (void : success, Object : fail)
 	 */
 	function procLayoutAdminCodeReset()
 	{
@@ -420,7 +420,7 @@ 
 	/**
 	 * insert image into user layout
 	 * @param int $layout_srl
-	 * @param object $source file data
+	 * @param string $source file data
 	 * @return boolean (true : success, false : fail)
 	 */
 	function insertUserLayoutImage($layout_srl,$source)
@@ -475,7 +475,7 @@ 
 	 * Save layout configuration
 	 * save in "ini" format for faceoff
 	 * @deprecated
-	 * @return void|Object (void : success, Object : fail)
+	 * @return Object|null (void : success, Object : fail)
 	 */
 	function procLayoutAdminUserValueInsert()
 	{
@@ -544,7 +544,7 @@ 
 	/**
 	 * Add the widget code for faceoff into user layout file
 	 * @param int $layout_srl
-	 * @param object $arg
+	 * @param null|stdClass $arg
 	 * @param string $content
 	 * @return string
 	 */
@@ -586,7 +586,7 @@ 
 
 	/**
 	 * export user layout
-	 * @return void
+	 * @return Object|null
 	 */
 	function procLayoutAdminUserLayoutExport()
 	{
@@ -682,7 +682,7 @@ 
 	/**
 	 * faceoff import
 	 * @deprecated
-	 * @return void
+	 * @return ModuleObject|null
 	 */
 	function procLayoutAdminUserLayoutImport()
 	{
@@ -843,7 +843,7 @@ 
 	/**
 	 * Layout file copy
 	 * @param $sourceLayoutSrl origin layout number
-	 * @param $targetLayoutSrl origin layout number
+	 * @param integer $targetLayoutSrl origin layout number
 	 * @return void
 	 */
 	function _copyLayoutFile($sourceLayoutSrl, $targetLayoutSrl)

Indentation +4 added lines, -4 removed lines

@@ -1,10 +1,10 @@
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 /**
- * @class  layoutAdminController
- * @author NAVER (developers@xpressengine.com)
- * admin controller class of the layout module
- */
+	 * @class  layoutAdminController
+	 * @author NAVER (developers@xpressengine.com)
+	 * admin controller class of the layout module
+	 */
 class layoutAdminController extends layout
 {
 	/**

Spacing +135 added lines, -135 removed lines

@@ -23,20 +23,20 @@ 
 	 */
 	function procLayoutAdminInsert()
 	{
-		if(Context::get('layout') == 'faceoff') return $this->stop('not supported');
+		if (Context::get('layout') == 'faceoff') return $this->stop('not supported');
 
 		// Get information to create a layout
 		$site_module_info = Context::get('site_module_info');
-		$args->site_srl = (int)$site_module_info->site_srl;
+		$args->site_srl = (int) $site_module_info->site_srl;
 		$args->layout_srl = getNextSequence();
 		$args->layout = Context::get('layout');
 		$args->title = Context::get('title');
 		$args->layout_type = Context::get('_layout_type');
-		if(!$args->layout_type) $args->layout_type = "P";
+		if (!$args->layout_type) $args->layout_type = "P";
 
 		// Insert into the DB
 		$output = $this->insertLayout($args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
 		// initiate if it is faceoff layout
 		$this->initLayout($args->layout_srl, $args->layout);
@@ -70,9 +70,9 @@ 
 	{
 		$oLayoutModel = getModel('layout');
 		// Import a sample layout if it is faceoff
-		if($oLayoutModel->useDefaultLayout($layout_name))
+		if ($oLayoutModel->useDefaultLayout($layout_name))
 		{
-			$this->importLayout($layout_srl, $this->module_path.'tpl/faceOff_sample.tar');
+			$this->importLayout($layout_srl, $this->module_path . 'tpl/faceOff_sample.tar');
 			// Remove a directory
 		}
 		else
@@ -101,25 +101,25 @@ 
 		$is_sitemap = $extra_vars->is_sitemap;
 		unset($extra_vars->is_sitemap);
 
-		$args = Context::gets('layout_srl','title');
+		$args = Context::gets('layout_srl', 'title');
 		// Get layout information
 		$oLayoutModel = getModel('layout');
 		$oMenuAdminModel = getAdminModel('menu');
 		$layout_info = $oLayoutModel->getLayout($args->layout_srl);
 
-		if($layout_info->menu)
+		if ($layout_info->menu)
 		{
 			$menus = get_object_vars($layout_info->menu);
 		}
-		if(count($menus))
+		if (count($menus))
 		{
-			foreach($menus as $menu_id => $val)
+			foreach ($menus as $menu_id => $val)
 			{
 				$menu_srl = Context::get($menu_id);
-				if(!$menu_srl) continue;
+				if (!$menu_srl) continue;
 
 				// if menu is -1, get default menu in site
-				if($menu_srl == -1)
+				if ($menu_srl == -1)
 				{
 					$oModuleModel = getModel('module');
 					$start_module = $oModuleModel->getSiteInfo(0, $columnList);
@@ -127,7 +127,7 @@ 
 					$tmpArgs->url = $start_module->mid;
 					$tmpArgs->site_srl = 0;
 					$output = executeQuery('menu.getMenuItemByUrl', $tmpArgs);
-					if(!$output->toBool())
+					if (!$output->toBool())
 					{
 						return new Object(-1, 'fail_to_update');
 					}
@@ -143,31 +143,31 @@ 
 				$apply_layout = Context::get('apply_layout');
 				$apply_mobile_view = Context::get('apply_mobile_view');
 
-				if($apply_layout=='Y' || $apply_mobile_view=='Y')
+				if ($apply_layout == 'Y' || $apply_mobile_view == 'Y')
 				{
 					$menu_args = new stdClass();
 					$menu_args->menu_srl = $menu_srl;
 					$menu_args->site_srl = $layout_info->site_srl;
 					$output = executeQueryArray('layout.getLayoutModules', $menu_args);
-					if($output->data)
+					if ($output->data)
 					{
 						$modules = array();
-						for($i=0;$i<count($output->data);$i++)
+						for ($i = 0; $i < count($output->data); $i++)
 						{
 							$modules[] = $output->data[$i]->module_srl;
 						}
 
-						if(count($modules))
+						if (count($modules))
 						{
 							$update_args = new stdClass();
-							$update_args->module_srls = implode(',',$modules);
-							if($apply_layout == "Y")
+							$update_args->module_srls = implode(',', $modules);
+							if ($apply_layout == "Y")
 							{
 								$update_args->layout_srl = $args->layout_srl;
 							}
-							if($layout_info->layout_type == "M")
+							if ($layout_info->layout_type == "M")
 							{
-								if(Context::get('apply_mobile_view') == "Y")
+								if (Context::get('apply_mobile_view') == "Y")
 								{
 									$update_args->use_mobile = "Y";
 								}
@@ -179,7 +179,7 @@ 
 							}
 
 							$oCacheHandler = CacheHandler::getInstance('object', null, true);
-							if($oCacheHandler->isSupport())
+							if ($oCacheHandler->isSupport())
 							{
 								$oCacheHandler->invalidateGroupKey('site_and_module');
 							}
@@ -191,21 +191,21 @@ 
 
 		$tmpDir = sprintf('./files/attach/images/%s/tmp', $args->layout_srl);
 		// Separately handle if a type of extra_vars is an image
-		if($layout_info->extra_var)
+		if ($layout_info->extra_var)
 		{
-			foreach($layout_info->extra_var as $name => $vars)
+			foreach ($layout_info->extra_var as $name => $vars)
 			{
-				if($vars->type!='image') continue;
+				if ($vars->type != 'image') continue;
 
 				$fileName = $extra_vars->{$name};
-				if($vars->value == $fileName)
+				if ($vars->value == $fileName)
 				{
 					continue;
 				}
 
 				FileHandler::removeFile($vars->value);
 
-				if(!$fileName)
+				if (!$fileName)
 				{
 					continue;
 				}
@@ -213,7 +213,7 @@ 
 				$pathInfo = pathinfo($fileName);
 				$tmpFileName = sprintf('%s/tmp/%s', $pathInfo['dirname'], $pathInfo['basename']);
 
-				if(!FileHandler::moveFile($tmpFileName, $fileName))
+				if (!FileHandler::moveFile($tmpFileName, $fileName))
 				{
 					unset($extra_vars->{$name});
 				}
@@ -225,21 +225,21 @@ 
 		$oModuleController = getController('module');
 		$layout_config = new stdClass();
 		$layout_config->header_script = Context::get('header_script');
-		$oModuleController->insertModulePartConfig('layout',$args->layout_srl,$layout_config);
+		$oModuleController->insertModulePartConfig('layout', $args->layout_srl, $layout_config);
 		// Save a title of the menu
 		$extra_vars->menu_name_list = $menu_name_list;
 		// Variable setting for DB insert
 		$args->extra_vars = serialize($extra_vars);
 
 		$output = $this->updateLayout($args);
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			return $output;
 		}
 
 		FileHandler::removeDir($tmpDir);
 
-		if(!$is_sitemap)
+		if (!$is_sitemap)
 		{
 			return $this->setRedirectUrl(Context::get('error_return_url'), $output);
 		}
@@ -258,7 +258,7 @@ 
 	 */
 	function updateLayout($args) {
 		$output = executeQuery('layout.updateLayout', $args);
-		if($output->toBool())
+		if ($output->toBool())
 		{
 			$oLayoutModel = getModel('layout');
 			$cache_file = $oLayoutModel->getUserLayoutCache($args->layout_srl, Context::getLangType());
@@ -289,13 +289,13 @@ 
 	{
 		$oLayoutModel = getModel('layout');
 
-		if($force)
+		if ($force)
 		{
 			$layoutInfo = $oLayoutModel->getLayout($layout_srl);
-			if($layoutInfo)
+			if ($layoutInfo)
 			{
 				$layoutList = $oLayoutModel->getLayoutInstanceList($layoutInfo->site_srl, $layoutInfo->layout_type, $layoutInfo->layout, array('layout_srl', 'layout'));
-				if(count($layoutList) <= 1)
+				if (count($layoutList) <= 1)
 				{
 					// uninstall package
 					$path = $layoutInfo->path;
@@ -304,7 +304,7 @@ 
 					$packageSrl = $oAutoinstallModel->getPackageSrlByPath($path);
 					$oAutoinstallAdminController = getAdminController('autoinstall');
 
-					if($packageSrl)
+					if ($packageSrl)
 					{
 						$output = $oAutoinstallAdminController->uninstallPackageByPackageSrl($packageSrl);
 					}
@@ -313,7 +313,7 @@ 
 						$output = $oAutoinstallAdminController->uninstallPackageByPath($path);
 					}
 
-					if(!$output->toBool())
+					if (!$output->toBool())
 					{
 						return new Object(-1, $output->message);
 					}
@@ -331,9 +331,9 @@ 
 		$args->layout_srl = $layout_srl;
 		$output = executeQuery("layout.deleteLayout", $args);
 
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
-		return new Object(0,'success_deleted');
+		return new Object(0, 'success_deleted');
 	}
 
 	/**
@@ -353,7 +353,7 @@ 
 		$code_css   = Context::get('code_css');
 		$is_post    = ($_SERVER['REQUEST_METHOD'] == 'POST');
 
-		if(!$layout_srl || !$code || !$is_post)
+		if (!$layout_srl || !$code || !$is_post)
 		{
 			return new Object(-1, 'msg_invalid_request');
 		}
@@ -376,7 +376,7 @@ 
 	function procLayoutAdminCodeReset()
 	{
 		$layout_srl = Context::get('layout_srl');
-		if(!$layout_srl) return new Object(-1, 'msg_invalid_request');
+		if (!$layout_srl) return new Object(-1, 'msg_invalid_request');
 
 		// delete user layout file
 		$oLayoutModel = getModel('layout');
@@ -386,7 +386,7 @@ 
 		$info = $oLayoutModel->getLayout($layout_srl);
 
 		// if face off delete, tmp file
-		if($oLayoutModel->useDefaultLayout($info->layout))
+		if ($oLayoutModel->useDefaultLayout($info->layout))
 		{
 			$this->deleteUserLayoutTempFile($layout_srl);
 			$faceoff_css = $oLayoutModel->getUserLayoutFaceOffCss($layout_srl);
@@ -404,14 +404,14 @@ 
 	 */
 	function procLayoutAdminUserImageUpload()
 	{
-		if(!Context::isUploaded()) exit();
+		if (!Context::isUploaded()) exit();
 
 		$image = Context::get('user_layout_image');
 		$layout_srl = Context::get('layout_srl');
-		if(!is_uploaded_file($image['tmp_name'])) exit();
+		if (!is_uploaded_file($image['tmp_name'])) exit();
 
 		$this->insertUserLayoutImage($layout_srl, $image);
-		$this->setTemplatePath($this->module_path.'tpl');
+		$this->setTemplatePath($this->module_path . 'tpl');
 		$this->setTemplateFile("top_refresh.html");
 
 		$this->setRedirectUrl(Context::get('error_return_url'));
@@ -423,24 +423,24 @@ 
 	 * @param object $source file data
 	 * @return boolean (true : success, false : fail)
 	 */
-	function insertUserLayoutImage($layout_srl,$source)
+	function insertUserLayoutImage($layout_srl, $source)
 	{
 		$oLayoutModel = getModel('layout');
 		$path = $oLayoutModel->getUserLayoutImagePath($layout_srl);
-		if(!is_dir($path)) FileHandler::makeDir($path);
+		if (!is_dir($path)) FileHandler::makeDir($path);
 
 		$filename = strtolower($source['name']);
-		if($filename != urlencode($filename))
+		if ($filename != urlencode($filename))
 		{
-			$ext = substr(strrchr($filename,'.'),1);
+			$ext = substr(strrchr($filename, '.'), 1);
 			$filename = sprintf('%s.%s', md5($filename), $ext);
 		}
 
 		// Check uploaded file
-		if(!checkUploadedFile($source['tmp_name'])) return false;
+		if (!checkUploadedFile($source['tmp_name'])) return false;
 		
-		if(file_exists($path .'/'. $filename)) @unlink($path . $filename);
-		if(!move_uploaded_file($source['tmp_name'], $path . $filename )) return false;
+		if (file_exists($path . '/' . $filename)) @unlink($path . $filename);
+		if (!move_uploaded_file($source['tmp_name'], $path . $filename)) return false;
 		return true;
 	}
 
@@ -452,7 +452,7 @@ 
 	{
 		$filename = Context::get('filename');
 		$layout_srl = Context::get('layout_srl');
-		$this->removeUserLayoutImage($layout_srl,$filename);
+		$this->removeUserLayoutImage($layout_srl, $filename);
 		$this->setMessage('success_deleted');
 		$this->setRedirectUrl(Context::get('error_return_url'));
 	}
@@ -463,7 +463,7 @@ 
 	 * @param string $filename
 	 * @return void
 	 */
-	function removeUserLayoutImage($layout_srl,$filename)
+	function removeUserLayoutImage($layout_srl, $filename)
 	{
 		$oLayoutModel = getModel('layout');
 		$path = $oLayoutModel->getUserLayoutImagePath($layout_srl);
@@ -482,19 +482,19 @@ 
 		$oModuleModel = getModel('module');
 
 		$mid = Context::get('mid');
-		if(!$mid) return new Object(-1, 'msg_invalid_request');
+		if (!$mid) return new Object(-1, 'msg_invalid_request');
 
 		$site_module_info = Context::get('site_module_info');
 		$columnList = array('layout_srl');
 		$module_info = $oModuleModel->getModuleInfoByMid($mid, $site_module_info->site_srl, $columnList);
 		$layout_srl = $module_info->layout_srl;
-		if(!$layout_srl) return new Object(-1, 'msg_invalid_request');
+		if (!$layout_srl) return new Object(-1, 'msg_invalid_request');
 
 		$oLayoutModel = getModel('layout');
 
 		// save tmp?
 		$temp = Context::get('saveTemp');
-		if($temp =='Y')
+		if ($temp == 'Y')
 		{
 			$oLayoutModel->setUseUserLayoutTemp();
 		}
@@ -504,28 +504,28 @@ 
 			$this->deleteUserLayoutTempFile($layout_srl);
 		}
 
-		$this->add('saveTemp',$temp);
+		$this->add('saveTemp', $temp);
 
 		// write user layout
-		$extension_obj = Context::gets('e1','e2','neck','knee');
+		$extension_obj = Context::gets('e1', 'e2', 'neck', 'knee');
 
 		$file = $oLayoutModel->getUserLayoutHtml($layout_srl);
 		$content = FileHandler::readFile($file);
-		$content = $this->addExtension($layout_srl,$extension_obj,$content);
-		FileHandler::writeFile($file,$content);
+		$content = $this->addExtension($layout_srl, $extension_obj, $content);
+		FileHandler::writeFile($file, $content);
 
 		// write faceoff.css
 		$css = stripslashes(Context::get('css'));
 
 		$css_file = $oLayoutModel->getUserLayoutFaceOffCss($layout_srl);
-		FileHandler::writeFile($css_file,$css);
+		FileHandler::writeFile($css_file, $css);
 
 		// write ini
-		$obj = Context::gets('type','align','column');
-		$obj = (array)$obj;
+		$obj = Context::gets('type', 'align', 'column');
+		$obj = (array) $obj;
 		$src = $oLayoutModel->getUserLayoutIniConfig($layout_srl);
-		foreach($obj as $key => $val) $src[$key] = $val;
-		$this->insertUserLayoutValue($layout_srl,$src);
+		foreach ($obj as $key => $val) $src[$key] = $val;
+		$this->insertUserLayoutValue($layout_srl, $src);
 	}
 
 	/**
@@ -534,7 +534,7 @@ 
 	 * @param object $arr layout ini
 	 * @return void
 	 */
-	function insertUserLayoutValue($layout_srl,$arr)
+	function insertUserLayoutValue($layout_srl, $arr)
 	{
 		$oLayoutModel = getModel('layout');
 		$file = $oLayoutModel->getUserLayoutIni($layout_srl);
@@ -548,24 +548,24 @@ 
 	 * @param string $content
 	 * @return string
 	 */
-	function addExtension($layout_srl,$arg,$content)
+	function addExtension($layout_srl, $arg, $content)
 	{
 		$oLayoutModel = getModel('layout');
 		$reg = '/(<\!\-\- start\-e1 \-\->)(.*)(<\!\-\- end\-e1 \-\->)/i';
-		$extension_content =  '\1' .stripslashes($arg->e1) . '\3';
-		$content = preg_replace($reg,$extension_content,$content);
+		$extension_content = '\1' . stripslashes($arg->e1) . '\3';
+		$content = preg_replace($reg, $extension_content, $content);
 
 		$reg = '/(<\!\-\- start\-e2 \-\->)(.*)(<\!\-\- end\-e2 \-\->)/i';
-		$extension_content =  '\1' .stripslashes($arg->e2) . '\3';
-		$content = preg_replace($reg,$extension_content,$content);
+		$extension_content = '\1' . stripslashes($arg->e2) . '\3';
+		$content = preg_replace($reg, $extension_content, $content);
 
 		$reg = '/(<\!\-\- start\-neck \-\->)(.*)(<\!\-\- end\-neck \-\->)/i';
-		$extension_content =  '\1' .stripslashes($arg->neck) . '\3';
-		$content = preg_replace($reg,$extension_content,$content);
+		$extension_content = '\1' . stripslashes($arg->neck) . '\3';
+		$content = preg_replace($reg, $extension_content, $content);
 
 		$reg = '/(<\!\-\- start\-knee \-\->)(.*)(<\!\-\- end\-knee \-\->)/i';
-		$extension_content =  '\1' .stripslashes($arg->knee) . '\3';
-		$content = preg_replace($reg,$extension_content,$content);
+		$extension_content = '\1' . stripslashes($arg->knee) . '\3';
+		$content = preg_replace($reg, $extension_content, $content);
 		return $content;
 	}
 
@@ -578,7 +578,7 @@ 
 	{
 		$oLayoutModel = getModel('layout');
 		$file_list = $oLayoutModel->getUserLayoutTempFileList($layout_srl);
-		foreach($file_list as $key => $file)
+		foreach ($file_list as $key => $file)
 		{
 			FileHandler::removeFile($file);
 		}
@@ -591,9 +591,9 @@ 
 	function procLayoutAdminUserLayoutExport()
 	{
 		$layout_srl = Context::get('layout_srl');
-		if(!$layout_srl) return new Object('-1','msg_invalid_request');
+		if (!$layout_srl) return new Object('-1', 'msg_invalid_request');
 
-		require_once(_XE_PATH_.'libs/tar.class.php');
+		require_once(_XE_PATH_ . 'libs/tar.class.php');
 		$oLayoutModel = getModel('layout');
 
 		// Copy files to temp path
@@ -606,21 +606,21 @@ 
 		$file_list = $oLayoutModel->getUserLayoutFileList($layout_srl);
 		unset($file_list[2]);
 
-		foreach($file_list as $file)
+		foreach ($file_list as $file)
 		{
-			if(strncasecmp('images', $file, 6) === 0) continue;
+			if (strncasecmp('images', $file, 6) === 0) continue;
 
 			// replace path
 			$file = $target_path . $file;
 			$content = FileHandler::readFile($file);
 			$pattern = '/(http:\/\/[^ ]+)?(\.\/)?' . str_replace('/', '\/', (str_replace('./', '', $file_path))) . '/';
-			if(basename($file) == 'faceoff.css' || basename($file) == 'layout.css')
+			if (basename($file) == 'faceoff.css' || basename($file) == 'layout.css')
 				$content = preg_replace($pattern, '../', $content);
 			else
 				$content = preg_replace($pattern, './', $content);
 
 			// replace ini config
-			foreach($ini_config as $key => $value)
+			foreach ($ini_config as $key => $value)
 			{
 				$content = str_replace('{$layout_info->faceoff_ini_config[\'' . $key . '\']}', $value, $content);
 			}
@@ -658,7 +658,7 @@ 
 		$tar = new tar();
 		$user_layout_path = FileHandler::getRealPath($oLayoutModel->getUserLayoutPath(0));
 		chdir($user_layout_path);
-		foreach($file_list as $key => $file) $tar->addFile($file);
+		foreach ($file_list as $key => $file) $tar->addFile($file);
 
 		$stream = $tar->toTarStream();
 		$filename = 'faceoff_' . date('YmdHis') . '.tar';
@@ -667,7 +667,7 @@ 
 		header("Content-Type: application/x-compressed");
 		header("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
 		//            header("Content-Length: " .strlen($stream)); ?? why??
-		header('Content-Disposition: attachment; filename="'. $filename .'"');
+		header('Content-Disposition: attachment; filename="' . $filename . '"');
 		header("Content-Transfer-Encoding: binary\n");
 		echo $stream;
 		// Close Context and then exit
@@ -689,20 +689,20 @@ 
 		return $this->stop('not supported');
 
 		// check upload
-		if(!Context::isUploaded()) exit();
+		if (!Context::isUploaded()) exit();
 		$file = Context::get('file');
-		if(!is_uploaded_file($file['tmp_name']) || !checkUploadedFile($file['tmp_name'])) exit();
+		if (!is_uploaded_file($file['tmp_name']) || !checkUploadedFile($file['tmp_name'])) exit();
 
-		if(substr_compare($file['name'], '.tar', -4) !== 0) exit();
+		if (substr_compare($file['name'], '.tar', -4) !== 0) exit();
 
 		$layout_srl = Context::get('layout_srl');
-		if(!$layout_srl) exit();
+		if (!$layout_srl) exit();
 
 		$oLayoutModel = getModel('layout');
 		$user_layout_path = FileHandler::getRealPath($oLayoutModel->getUserLayoutPath($layout_srl));
-		if(!move_uploaded_file($file['tmp_name'], $user_layout_path . 'faceoff.tar')) exit();
+		if (!move_uploaded_file($file['tmp_name'], $user_layout_path . 'faceoff.tar')) exit();
 
-		$this->importLayout($layout_srl, $user_layout_path.'faceoff.tar');
+		$this->importLayout($layout_srl, $user_layout_path . 'faceoff.tar');
 
 		$this->setRedirectUrl(Context::get('error_return_url'));
 	}
@@ -714,12 +714,12 @@ 
 	function procLayoutAdminCopyLayout()
 	{
 		$sourceArgs = Context::getRequestVars();
-		if($sourceArgs->layout == 'faceoff')
+		if ($sourceArgs->layout == 'faceoff')
 		{
 			return $this->stop('not supported');
 		}
 
-		if(!$sourceArgs->layout_srl)
+		if (!$sourceArgs->layout_srl)
 		{
 			return $this->stop('msg_empty_origin_layout');
 		}
@@ -727,12 +727,12 @@ 
 		$oLayoutModel = getModel('layout');
 		$layout = $oLayoutModel->getLayout($sourceArgs->layout_srl);
 
-		if(!$sourceArgs->title)
+		if (!$sourceArgs->title)
 		{
-			$sourceArgs->title = array($layout->title.'_'.$this->_makeRandomMid());
+			$sourceArgs->title = array($layout->title . '_' . $this->_makeRandomMid());
 		}
 
-		if(!is_array($sourceArgs->title) || count($sourceArgs->title) == 0)
+		if (!is_array($sourceArgs->title) || count($sourceArgs->title) == 0)
 		{
 			return $this->stop('msg_empty_target_layout');
 		}
@@ -742,11 +742,11 @@ 
 		$args->extra_vars = $output->extra_vars;
 		$extra_vars = unserialize($args->extra_vars);
 		
-		if($layout->extra_var_count) {
+		if ($layout->extra_var_count) {
 			$reg = "/^.\/files\/attach\/images\/([0-9]+)\/(.*)/";
-			if($extra_vars) foreach($extra_vars as $key => $val) {
-				if($layout->extra_var->{$key}->type == 'image') {
-					if(!preg_match($reg,$val,$matches)) continue;
+			if ($extra_vars) foreach ($extra_vars as $key => $val) {
+				if ($layout->extra_var->{$key}->type == 'image') {
+					if (!preg_match($reg, $val, $matches)) continue;
 					$image_list[$key]->filename = $matches[2];
 					$image_list[$key]->old_file = $val;
 				}
@@ -758,19 +758,19 @@ 
 		$layout_config->header_script = $extra_vars->header_script;
 
 		// Get information to create a layout
-		$args->site_srl = (int)$layout->site_srl;
+		$args->site_srl = (int) $layout->site_srl;
 		$args->layout = $layout->layout;
 		$args->layout_type = $layout->layout_type;
-		if(!$args->layout_type) $args->layout_type = "P";
+		if (!$args->layout_type) $args->layout_type = "P";
 
 		$oDB = &DB::getInstance();
 		$oDB->begin();
 
-		if(is_array($sourceArgs->title))
+		if (is_array($sourceArgs->title))
 		{
-			foreach($sourceArgs->title AS $key=>$value)
+			foreach ($sourceArgs->title AS $key=>$value)
 			{
-				if(!trim($value))
+				if (!trim($value))
 				{
 					continue;
 				}
@@ -778,9 +778,9 @@ 
 				$args->layout_srl = getNextSequence();
 				$args->title = $value;
 
-				if(is_array($image_list)) {
-					foreach($image_list as $key=>$val) {
-						$new_file = sprintf("./files/attach/images/%s/%s", $args->layout_srl,$val->filename);
+				if (is_array($image_list)) {
+					foreach ($image_list as $key=>$val) {
+						$new_file = sprintf("./files/attach/images/%s/%s", $args->layout_srl, $val->filename);
 						FileHandler::copyFile($val->old_file, $new_file);
 						$extra_vars->{$key} = $new_file;
 					}
@@ -792,7 +792,7 @@ 
 
 				// Insert into the DB
 				$output = $this->insertLayout($args);
-				if(!$output->toBool())
+				if (!$output->toBool())
 				{
 					$oDB->rollback();
 					return $output;
@@ -815,7 +815,7 @@ 
 		$oDB->commit();
 
 		$this->setMessage('success_registed');
-		if(!in_array(Context::getRequestMethod(),array('XMLRPC','JSON'))) {
+		if (!in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON'))) {
 			global $lang;
 			htmlHeader();
 			alertScript($lang->success_registed);
@@ -831,13 +831,13 @@ 
 	{
 		$time = $_SERVER['REQUEST_TIME'];
 		$randomString = "";
-		for($i=0;$i<4;$i++)
+		for ($i = 0; $i < 4; $i++)
 		{
-			$doc = rand()%26+65;
+			$doc = rand() % 26 + 65;
 			$randomString .= chr($doc);
 		}
 
-		return $randomString.substr($time, -4);
+		return $randomString . substr($time, -4);
 	}
 
 	/**
@@ -857,14 +857,14 @@ 
 		FileHandler::makeDir($targetImagePath);
 
 		$sourceFileList = $oLayoutModel->getUserLayoutFileList($sourceLayoutSrl);
-		foreach($sourceFileList as $key => $file)
+		foreach ($sourceFileList as $key => $file)
 		{
-			if(is_readable($sourceLayoutPath.$file))
+			if (is_readable($sourceLayoutPath . $file))
 			{
-				FileHandler::copyFile($sourceLayoutPath.$file, $targetLayoutPath.$file);
-				if($file == 'layout.html' || $file == 'layout.css')
+				FileHandler::copyFile($sourceLayoutPath . $file, $targetLayoutPath . $file);
+				if ($file == 'layout.html' || $file == 'layout.css')
 				{
-					$this->_changeFilepathInSource($targetLayoutPath.$file, $sourceImagePath, $targetImagePath);
+					$this->_changeFilepathInSource($targetLayoutPath . $file, $sourceImagePath, $targetImagePath);
 				}
 			}
 		}
@@ -893,23 +893,23 @@ 
 		$oLayoutModel = getModel('layout');
 		$user_layout_path = FileHandler::getRealPath($oLayoutModel->getUserLayoutPath($layout_srl));
 		$file_list = $oLayoutModel->getUserLayoutFileList($layout_srl);
-		foreach($file_list as $key => $file)
+		foreach ($file_list as $key => $file)
 		{
 			FileHandler::removeFile($user_layout_path . $file);
 		}
 
-		require_once(_XE_PATH_.'libs/tar.class.php');
+		require_once(_XE_PATH_ . 'libs/tar.class.php');
 		$image_path = $oLayoutModel->getUserLayoutImagePath($layout_srl);
 		FileHandler::makeDir($image_path);
 		$tar = new tar();
 		$tar->openTAR($source_file);
 		// If layout.ini file does not exist
-		if(!$tar->getFile('layout.ini')) return;
+		if (!$tar->getFile('layout.ini')) return;
 
-		$replace_path = getNumberingPath($layout_srl,3);
-		foreach($tar->files as $key => $info)
+		$replace_path = getNumberingPath($layout_srl, 3);
+		foreach ($tar->files as $key => $info)
 		{
-			FileHandler::writeFile($user_layout_path . $info['name'],str_replace('__LAYOUT_PATH__',$replace_path,$info['file']));
+			FileHandler::writeFile($user_layout_path . $info['name'], str_replace('__LAYOUT_PATH__', $replace_path, $info['file']));
 		}
 		// Remove uploaded file
 		FileHandler::removeFile($source_file);
@@ -924,16 +924,16 @@ 
 		$name = Context::get('name');
 		$img = Context::get('img');
 
-		$this->setTemplatePath($this->module_path.'tpl');
+		$this->setTemplatePath($this->module_path . 'tpl');
 		$this->setTemplateFile("after_upload_config_image.html");
 
-		if(!$img['tmp_name'] || !is_uploaded_file($img['tmp_name']) || !checkUploadedFile($img['tmp_name']))
+		if (!$img['tmp_name'] || !is_uploaded_file($img['tmp_name']) || !checkUploadedFile($img['tmp_name']))
 		{
 			Context::set('msg', Context::getLang('upload failed'));
 			return;
 		}
 
-		if(!preg_match('/\.(jpg|jpeg|gif|png|swf)$/i', $img['name']))
+		if (!preg_match('/\.(jpg|jpeg|gif|png|swf)$/i', $img['name']))
 		{
 			Context::set('msg', Context::getLang('msg_layout_image_target'));
 			return;
@@ -941,18 +941,18 @@ 
 
 		$path = sprintf('./files/attach/images/%s/', $layoutSrl);
 		$tmpPath = $path . 'tmp/';
-		if(!FileHandler::makeDir($tmpPath))
+		if (!FileHandler::makeDir($tmpPath))
 		{
 			Context::set('msg', Context::getLang('make directory failed'));
 			return;
 		}
 
-		$ext = substr(strrchr($img['name'],'.'),1);
-		$_fileName = md5(crypt(rand(1000000,900000), rand(0,100))).'.'.$ext;
+		$ext = substr(strrchr($img['name'], '.'), 1);
+		$_fileName = md5(crypt(rand(1000000, 900000), rand(0, 100))) . '.' . $ext;
 		$fileName = $path . $_fileName;
 		$tmpFileName = $tmpPath . $_fileName;
 
-		if(!move_uploaded_file($img['tmp_name'], $tmpFileName))
+		if (!move_uploaded_file($img['tmp_name'], $tmpFileName))
 		{
 			Context::set('msg', Context::getLang('move file failed'));
 			return;
@@ -971,15 +971,15 @@ 
 		$layoutSrl = Context::get('layout_srl');
 		$name = Context::get('name');
 
-		$this->setTemplatePath($this->module_path.'tpl');
+		$this->setTemplatePath($this->module_path . 'tpl');
 		$this->setTemplateFile("after_delete_config_image.html");
 
 		$oModel = getModel('layout');
 		$layoutInfo = $oModel->getLayout($layoutSrl);
 
-		if($layoutInfo->extra_var_count)
+		if ($layoutInfo->extra_var_count)
 		{
-			foreach($layoutInfo->extra_var as $varId => $val)
+			foreach ($layoutInfo->extra_var as $varId => $val)
 			{
 				$newLayoutInfo->{$varId} = $val->value;
 			}
@@ -990,7 +990,7 @@ 
 		$args->layout_srl = $layoutSrl;
 		$args->extra_vars = serialize($newLayoutInfo);
 		$output = $this->updateLayout($args);
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			Context::set('msg', Context::getLang($output->getMessage()));
 			return $output;

Braces +94 added lines, -42 removed lines

@@ -23,7 +23,9 @@ 
 	 */
 	function procLayoutAdminInsert()
 	{
-		if(Context::get('layout') == 'faceoff') return $this->stop('not supported');
+		if(Context::get('layout') == 'faceoff') {
+			return $this->stop('not supported');
+		}
 
 		// Get information to create a layout
 		$site_module_info = Context::get('site_module_info');
@@ -32,11 +34,15 @@ 
 		$args->layout = Context::get('layout');
 		$args->title = Context::get('title');
 		$args->layout_type = Context::get('_layout_type');
-		if(!$args->layout_type) $args->layout_type = "P";
+		if(!$args->layout_type) {
+			$args->layout_type = "P";
+		}
 
 		// Insert into the DB
 		$output = $this->insertLayout($args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		// initiate if it is faceoff layout
 		$this->initLayout($args->layout_srl, $args->layout);
@@ -44,7 +50,9 @@ 
 		// update layout info
 		Context::set('layout_srl', $args->layout_srl);
 		$output = $this->procLayoutAdminUpdate();
-		if (!$output->toBool()) return $output;
+		if (!$output->toBool()) {
+			return $output;
+		}
 
 		return $this->setRedirectUrl(Context::get('success_return_url'), $output);
 	}
@@ -74,8 +82,7 @@ 
 		{
 			$this->importLayout($layout_srl, $this->module_path.'tpl/faceOff_sample.tar');
 			// Remove a directory
-		}
-		else
+		} else
 		{
 			FileHandler::removeDir($oLayoutModel->getUserLayoutPath($layout_srl));
 		}
@@ -116,7 +123,9 @@ 
 			foreach($menus as $menu_id => $val)
 			{
 				$menu_srl = Context::get($menu_id);
-				if(!$menu_srl) continue;
+				if(!$menu_srl) {
+					continue;
+				}
 
 				// if menu is -1, get default menu in site
 				if($menu_srl == -1)
@@ -172,8 +181,7 @@ 
 									$update_args->use_mobile = "Y";
 								}
 								$output = executeQuery('layout.updateModuleMLayout', $update_args);
-							}
-							else
+							} else
 							{
 								$output = executeQuery('layout.updateModuleLayout', $update_args);
 							}
@@ -195,7 +203,9 @@ 
 		{
 			foreach($layout_info->extra_var as $name => $vars)
 			{
-				if($vars->type!='image') continue;
+				if($vars->type!='image') {
+					continue;
+				}
 
 				$fileName = $extra_vars->{$name};
 				if($vars->value == $fileName)
@@ -242,8 +252,7 @@ 
 		if(!$is_sitemap)
 		{
 			return $this->setRedirectUrl(Context::get('error_return_url'), $output);
-		}
-		else
+		} else
 		{
 			$context = Context::getInstance();
 			$context->setRequestMethod('JSON');
@@ -307,8 +316,7 @@ 
 					if($packageSrl)
 					{
 						$output = $oAutoinstallAdminController->uninstallPackageByPackageSrl($packageSrl);
-					}
-					else
+					} else
 					{
 						$output = $oAutoinstallAdminController->uninstallPackageByPath($path);
 					}
@@ -331,7 +339,9 @@ 
 		$args->layout_srl = $layout_srl;
 		$output = executeQuery("layout.deleteLayout", $args);
 
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		return new Object(0,'success_deleted');
 	}
@@ -376,7 +386,9 @@ 
 	function procLayoutAdminCodeReset()
 	{
 		$layout_srl = Context::get('layout_srl');
-		if(!$layout_srl) return new Object(-1, 'msg_invalid_request');
+		if(!$layout_srl) {
+			return new Object(-1, 'msg_invalid_request');
+		}
 
 		// delete user layout file
 		$oLayoutModel = getModel('layout');
@@ -404,11 +416,15 @@ 
 	 */
 	function procLayoutAdminUserImageUpload()
 	{
-		if(!Context::isUploaded()) exit();
+		if(!Context::isUploaded()) {
+			exit();
+		}
 
 		$image = Context::get('user_layout_image');
 		$layout_srl = Context::get('layout_srl');
-		if(!is_uploaded_file($image['tmp_name'])) exit();
+		if(!is_uploaded_file($image['tmp_name'])) {
+			exit();
+		}
 
 		$this->insertUserLayoutImage($layout_srl, $image);
 		$this->setTemplatePath($this->module_path.'tpl');
@@ -427,7 +443,9 @@ 
 	{
 		$oLayoutModel = getModel('layout');
 		$path = $oLayoutModel->getUserLayoutImagePath($layout_srl);
-		if(!is_dir($path)) FileHandler::makeDir($path);
+		if(!is_dir($path)) {
+			FileHandler::makeDir($path);
+		}
 
 		$filename = strtolower($source['name']);
 		if($filename != urlencode($filename))
@@ -437,10 +455,16 @@ 
 		}
 
 		// Check uploaded file
-		if(!checkUploadedFile($source['tmp_name'])) return false;
+		if(!checkUploadedFile($source['tmp_name'])) {
+			return false;
+		}
 		
-		if(file_exists($path .'/'. $filename)) @unlink($path . $filename);
-		if(!move_uploaded_file($source['tmp_name'], $path . $filename )) return false;
+		if(file_exists($path .'/'. $filename)) {
+			@unlink($path . $filename);
+		}
+		if(!move_uploaded_file($source['tmp_name'], $path . $filename )) {
+			return false;
+		}
 		return true;
 	}
 
@@ -482,13 +506,17 @@ 
 		$oModuleModel = getModel('module');
 
 		$mid = Context::get('mid');
-		if(!$mid) return new Object(-1, 'msg_invalid_request');
+		if(!$mid) {
+			return new Object(-1, 'msg_invalid_request');
+		}
 
 		$site_module_info = Context::get('site_module_info');
 		$columnList = array('layout_srl');
 		$module_info = $oModuleModel->getModuleInfoByMid($mid, $site_module_info->site_srl, $columnList);
 		$layout_srl = $module_info->layout_srl;
-		if(!$layout_srl) return new Object(-1, 'msg_invalid_request');
+		if(!$layout_srl) {
+			return new Object(-1, 'msg_invalid_request');
+		}
 
 		$oLayoutModel = getModel('layout');
 
@@ -497,8 +525,7 @@ 
 		if($temp =='Y')
 		{
 			$oLayoutModel->setUseUserLayoutTemp();
-		}
-		else
+		} else
 		{
 			// delete temp files
 			$this->deleteUserLayoutTempFile($layout_srl);
@@ -524,7 +551,9 @@ 
 		$obj = Context::gets('type','align','column');
 		$obj = (array)$obj;
 		$src = $oLayoutModel->getUserLayoutIniConfig($layout_srl);
-		foreach($obj as $key => $val) $src[$key] = $val;
+		foreach($obj as $key => $val) {
+			$src[$key] = $val;
+		}
 		$this->insertUserLayoutValue($layout_srl,$src);
 	}
 
@@ -591,7 +620,9 @@ 
 	function procLayoutAdminUserLayoutExport()
 	{
 		$layout_srl = Context::get('layout_srl');
-		if(!$layout_srl) return new Object('-1','msg_invalid_request');
+		if(!$layout_srl) {
+			return new Object('-1','msg_invalid_request');
+		}
 
 		require_once(_XE_PATH_.'libs/tar.class.php');
 		$oLayoutModel = getModel('layout');
@@ -608,16 +639,19 @@ 
 
 		foreach($file_list as $file)
 		{
-			if(strncasecmp('images', $file, 6) === 0) continue;
+			if(strncasecmp('images', $file, 6) === 0) {
+				continue;
+			}
 
 			// replace path
 			$file = $target_path . $file;
 			$content = FileHandler::readFile($file);
 			$pattern = '/(http:\/\/[^ ]+)?(\.\/)?' . str_replace('/', '\/', (str_replace('./', '', $file_path))) . '/';
-			if(basename($file) == 'faceoff.css' || basename($file) == 'layout.css')
-				$content = preg_replace($pattern, '../', $content);
-			else
-				$content = preg_replace($pattern, './', $content);
+			if(basename($file) == 'faceoff.css' || basename($file) == 'layout.css') {
+							$content = preg_replace($pattern, '../', $content);
+			} else {
+							$content = preg_replace($pattern, './', $content);
+			}
 
 			// replace ini config
 			foreach($ini_config as $key => $value)
@@ -658,7 +692,9 @@ 
 		$tar = new tar();
 		$user_layout_path = FileHandler::getRealPath($oLayoutModel->getUserLayoutPath(0));
 		chdir($user_layout_path);
-		foreach($file_list as $key => $file) $tar->addFile($file);
+		foreach($file_list as $key => $file) {
+			$tar->addFile($file);
+		}
 
 		$stream = $tar->toTarStream();
 		$filename = 'faceoff_' . date('YmdHis') . '.tar';
@@ -689,18 +725,28 @@ 
 		return $this->stop('not supported');
 
 		// check upload
-		if(!Context::isUploaded()) exit();
+		if(!Context::isUploaded()) {
+			exit();
+		}
 		$file = Context::get('file');
-		if(!is_uploaded_file($file['tmp_name']) || !checkUploadedFile($file['tmp_name'])) exit();
+		if(!is_uploaded_file($file['tmp_name']) || !checkUploadedFile($file['tmp_name'])) {
+			exit();
+		}
 
-		if(substr_compare($file['name'], '.tar', -4) !== 0) exit();
+		if(substr_compare($file['name'], '.tar', -4) !== 0) {
+			exit();
+		}
 
 		$layout_srl = Context::get('layout_srl');
-		if(!$layout_srl) exit();
+		if(!$layout_srl) {
+			exit();
+		}
 
 		$oLayoutModel = getModel('layout');
 		$user_layout_path = FileHandler::getRealPath($oLayoutModel->getUserLayoutPath($layout_srl));
-		if(!move_uploaded_file($file['tmp_name'], $user_layout_path . 'faceoff.tar')) exit();
+		if(!move_uploaded_file($file['tmp_name'], $user_layout_path . 'faceoff.tar')) {
+			exit();
+		}
 
 		$this->importLayout($layout_srl, $user_layout_path.'faceoff.tar');
 
@@ -744,9 +790,11 @@ 
 		
 		if($layout->extra_var_count) {
 			$reg = "/^.\/files\/attach\/images\/([0-9]+)\/(.*)/";
-			if($extra_vars) foreach($extra_vars as $key => $val) {
+			if($extra_vars) {
+				foreach($extra_vars as $key => $val) {
 				if($layout->extra_var->{$key}->type == 'image') {
 					if(!preg_match($reg,$val,$matches)) continue;
+			}
 					$image_list[$key]->filename = $matches[2];
 					$image_list[$key]->old_file = $val;
 				}
@@ -761,7 +809,9 @@ 
 		$args->site_srl = (int)$layout->site_srl;
 		$args->layout = $layout->layout;
 		$args->layout_type = $layout->layout_type;
-		if(!$args->layout_type) $args->layout_type = "P";
+		if(!$args->layout_type) {
+			$args->layout_type = "P";
+		}
 
 		$oDB = &DB::getInstance();
 		$oDB->begin();
@@ -904,7 +954,9 @@ 
 		$tar = new tar();
 		$tar->openTAR($source_file);
 		// If layout.ini file does not exist
-		if(!$tar->getFile('layout.ini')) return;
+		if(!$tar->getFile('layout.ini')) {
+			return;
+		}
 
 		$replace_path = getNumberingPath($layout_srl,3);
 		foreach($tar->files as $key => $info)

modules/layout/layout.admin.model.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 
 	/**
 	 * get layout setting view.
-	 * @return void
+	 * @return string|null
 	 */
 	public function getLayoutAdminSetInfoView()
 	{

Indentation +4 added lines, -4 removed lines

@@ -1,10 +1,10 @@
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 /**
- * @class  layoutAdminView
- * @author NAVER (developers@xpressengine.com)
- * admin view class of the layout module
- */
+	 * @class  layoutAdminView
+	 * @author NAVER (developers@xpressengine.com)
+	 * admin view class of the layout module
+	 */
 class layoutAdminModel extends layout
 {
 	/**

Spacing +22 added lines, -22 removed lines

@@ -25,24 +25,24 @@ 
 		Context::set('is_sitemap', '1');
 		$script = '<script src="./modules/layout/tpl/js/layout_modify.js"></script>';
 		$oTemplate = TemplateHandler::getInstance();
-		$html = $oTemplate->compile($this->module_path.'tpl/', 'layout_info_view');
+		$html = $oTemplate->compile($this->module_path . 'tpl/', 'layout_info_view');
 
 		preg_match_all('/<!--#JSPLUGIN:(.*)-->/', $html, $m);
 		$pluginList = $m[1];
 
-		foreach($pluginList as $plugin)
+		foreach ($pluginList as $plugin)
 		{
 			$info = Context::getJavascriptPluginInfo($plugin);
-			if(!$info)
+			if (!$info)
 			{
 				continue;
 			}
 
-			foreach($info->jsList as $js)
+			foreach ($info->jsList as $js)
 			{
 				$script .= sprintf('<script src="%s"></script>', $js);
 			}
-			foreach($info->cssList as $css)
+			foreach ($info->cssList as $css)
 			{
 				$csss .= sprintf('<link rel="stylesheet" href="%s" />', $css);
 			}
@@ -50,7 +50,7 @@ 
 
 		$this->add('html', $csss . $script . $html);
 
-		if($isReturn)
+		if ($isReturn)
 		{
 			return $this->get('html');
 		}
@@ -65,7 +65,7 @@ 
 		$layout_info = $oLayoutModel->getLayout($layout_srl);
 
 		// Error appears if there is no layout information is registered
-		if(!$layout_info)
+		if (!$layout_info)
 		{
 			return $this->stop('msg_invalid_request');
 		}
@@ -82,14 +82,14 @@ 
 		$layout_info = $security->encodeHTML('.', 'author..', 'extra_var..');
 
 		$layout_info->description = nl2br(trim($layout_info->description));
-		if(!is_object($layout_info->extra_var))
+		if (!is_object($layout_info->extra_var))
 		{
 			$layout_info->extra_var = new StdClass();
 		}
 
-		foreach($layout_info->extra_var as $var_name => $val)
+		foreach ($layout_info->extra_var as $var_name => $val)
 		{
-			if(isset($layout_info->{$var_name}->description))
+			if (isset($layout_info->{$var_name}->description))
 			{
 				$layout_info->{$var_name}->description = nl2br(trim($val->description));
 			}
@@ -105,27 +105,27 @@ 
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayout($layout_srl);
 		// Error appears if there is no layout information is registered
-		if(!$layout_info)
+		if (!$layout_info)
 		{
 			return $this->dispLayoutAdminInstalledList();
 		}
 
 		// Get Layout Code
-		if($oLayoutModel->useDefaultLayout($layout_info->layout_srl))
+		if ($oLayoutModel->useDefaultLayout($layout_info->layout_srl))
 		{
-			$layout_file  = $oLayoutModel->getDefaultLayoutHtml($layout_info->layout);
-			$layout_css_file  = $oLayoutModel->getDefaultLayoutCss($layout_info->layout);
+			$layout_file = $oLayoutModel->getDefaultLayoutHtml($layout_info->layout);
+			$layout_css_file = $oLayoutModel->getDefaultLayoutCss($layout_info->layout);
 		}
 		else
 		{
 			$layout_file = $oLayoutModel->getUserLayoutHtml($layout_info->layout_srl);
 			$layout_css_file = $oLayoutModel->getUserLayoutCss($layout_info->layout_srl);
 
-			if(!file_exists($layout_file)) $layout_file = $layout_info->path . 'layout.html';
-			if(!file_exists($layout_css_file)) $layout_css_file = $layout_info->path . 'layout.css';
+			if (!file_exists($layout_file)) $layout_file = $layout_info->path . 'layout.html';
+			if (!file_exists($layout_css_file)) $layout_css_file = $layout_info->path . 'layout.css';
 		}
 
-		if(file_exists($layout_css_file))
+		if (file_exists($layout_css_file))
 		{
 			$layout_code_css = FileHandler::readFile($layout_css_file);
 			Context::set('layout_code_css', $layout_code_css);
@@ -159,9 +159,9 @@ 
 
 		$script = '<script src="./modules/layout/tpl/js/layout_admin_set_html.js"></script>';
 		$oTemplate = &TemplateHandler::getInstance();
-		$html = $oTemplate->compile($this->module_path.'tpl/', 'layout_html_css_view');
+		$html = $oTemplate->compile($this->module_path . 'tpl/', 'layout_html_css_view');
 
-		$this->add('html', $script.$html);
+		$this->add('html', $script . $html);
 	}
 
 	public function getLayoutAdminSiteDefaultLayout()
@@ -182,9 +182,9 @@ 
 	{
 		$target = ($viewType == 'M') ? 'mlayout_srl' : 'layout_srl';
 		$designInfoFile = sprintf(_XE_PATH_ . 'files/site_design/design_%s.php', $siteSrl);
-		if(FileHandler::exists($designInfoFile)) include($designInfoFile);
+		if (FileHandler::exists($designInfoFile)) include($designInfoFile);
 
-		if(!$designInfo || !$designInfo->{$target})
+		if (!$designInfo || !$designInfo->{$target})
 		{
 			return 0;
 		}
@@ -192,7 +192,7 @@ 
 		$oModel = getModel('layout');
 		$layout_info = $oModel->getLayout($designInfo->{$target});
 
-		if(!$layout_info)
+		if (!$layout_info)
 		{
 			return 0;
 		}

Braces +10 added lines, -5 removed lines

@@ -115,14 +115,17 @@ 
 		{
 			$layout_file  = $oLayoutModel->getDefaultLayoutHtml($layout_info->layout);
 			$layout_css_file  = $oLayoutModel->getDefaultLayoutCss($layout_info->layout);
-		}
-		else
+		} else
 		{
 			$layout_file = $oLayoutModel->getUserLayoutHtml($layout_info->layout_srl);
 			$layout_css_file = $oLayoutModel->getUserLayoutCss($layout_info->layout_srl);
 
-			if(!file_exists($layout_file)) $layout_file = $layout_info->path . 'layout.html';
-			if(!file_exists($layout_css_file)) $layout_css_file = $layout_info->path . 'layout.css';
+			if(!file_exists($layout_file)) {
+				$layout_file = $layout_info->path . 'layout.html';
+			}
+			if(!file_exists($layout_css_file)) {
+				$layout_css_file = $layout_info->path . 'layout.css';
+			}
 		}
 
 		if(file_exists($layout_css_file))
@@ -182,7 +185,9 @@ 
 	{
 		$target = ($viewType == 'M') ? 'mlayout_srl' : 'layout_srl';
 		$designInfoFile = sprintf(_XE_PATH_ . 'files/site_design/design_%s.php', $siteSrl);
-		if(FileHandler::exists($designInfoFile)) include($designInfoFile);
+		if(FileHandler::exists($designInfoFile)) {
+			include($designInfoFile);
+		}
 
 		if(!$designInfo || !$designInfo->{$target})
 		{

modules/layout/layout.admin.view.php

Doc Comments +3 added lines, -3 removed lines

@@ -132,7 +132,7 @@ 
 
 	/**
 	 * Display list of pc layout instance
-	 * @return void|Object (void : success, Object : fail)
+	 * @return ModuleObject|null (void : success, Object : fail)
 	 */
 	function dispLayoutAdminInstanceList()
 	{
@@ -161,7 +161,7 @@ 
 	/**
 	 * Layout setting page
 	 * Once select a layout with empty value in the DB, then adjust values
-	 * @return void|Object (void : success, Object : fail)
+	 * @return ModuleObject|null (void : success, Object : fail)
 	 */
 	function dispLayoutAdminInsert()
 	{
@@ -288,7 +288,7 @@ 
 
 	/**
 	 * Preview a layout
-	 * @return void|Object (void : success, Object : fail)
+	 * @return Object|null (void : success, Object : fail)
 	 */
 	function dispLayoutAdminPreview()
 	{

Indentation +4 added lines, -4 removed lines

@@ -1,10 +1,10 @@
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 /**
- * @class  layoutAdminView
- * @author NAVER (developers@xpressengine.com)
- * admin view class of the layout module
- */
+	 * @class  layoutAdminView
+	 * @author NAVER (developers@xpressengine.com)
+	 * admin view class of the layout module
+	 */
 class layoutAdminView extends layout
 {
 	/**

Spacing +48 added lines, -48 removed lines

@@ -13,7 +13,7 @@ 
 	 */
 	function init()
 	{
-		$this->setTemplatePath($this->module_path.'tpl');
+		$this->setTemplatePath($this->module_path . 'tpl');
 	}
 
 	/**
@@ -28,20 +28,20 @@ 
 		// Set a layout list
 		$oLayoutModel = getModel('layout');
 		$layout_list = $oLayoutModel->getDownloadedLayoutList($type, true);
-		if(!is_array($layout_list))
+		if (!is_array($layout_list))
 		{
 			$layout_list = array();
 		}
 
-		if($type == 'P')
+		if ($type == 'P')
 		{
 			// get Theme layout
 			$oAdminModel = getAdminModel('admin');
 			$themeList = $oAdminModel->getThemeList();
 			$themeLayoutList = array();
-			foreach($themeList as $themeInfo)
+			foreach ($themeList as $themeInfo)
 			{
-				if(strpos($themeInfo->layout_info->name, '.') === false) continue;
+				if (strpos($themeInfo->layout_info->name, '.') === false) continue;
 				$themeLayoutList[] = $oLayoutModel->getLayoutInfo($themeInfo->layout_info->name, null, 'P');
 			}
 			$layout_list = array_merge($layout_list, $themeLayoutList);
@@ -59,9 +59,9 @@ 
 
 		//Security
 		$security = new Security();
-		$security->encodeHTML('layout_list..layout','layout_list..title');
+		$security->encodeHTML('layout_list..layout', 'layout_list..title');
 
-		foreach($layout_list as $no => $layout_info)
+		foreach ($layout_list as $no => $layout_info)
 		{
 			$layout_list[$no]->description = nl2br(trim($layout_info->description));
 		}
@@ -76,7 +76,7 @@ 
 	{
 		$type = Context::get('type');
 
-		if(!in_array($type, array('P', 'M'))) $type = 'P';
+		if (!in_array($type, array('P', 'M'))) $type = 'P';
 
 		$oLayoutModel = getModel('layout');
 
@@ -89,9 +89,9 @@ 
 		$_layout_list = $oLayoutModel->getLayoutInstanceList(0, $type, null, $columnList);
 
 		$layout_list = array();
-		foreach($_layout_list as $item)
+		foreach ($_layout_list as $item)
 		{
-			if(!$layout_list[$item->layout])
+			if (!$layout_list[$item->layout])
 			{
 				$layout_list[$item->layout] = array();
 				$layout_info = $oLayoutModel->getLayoutInfo($item->layout, null, $type);
@@ -122,7 +122,7 @@ 
 		$aTitle = strtolower($a['title']);
 		$bTitle = strtolower($b['title']);
 
-		if($aTitle == $bTitle)
+		if ($aTitle == $bTitle)
 		{
 			return 0;
 		}
@@ -139,12 +139,12 @@ 
 		$type = Context::get('type');
 		$layout = Context::get('layout');
 
-		if(!in_array($type, array('P', 'M'))) $type = 'P';
-		if(!$layout) return $this->stop('msg_invalid_request');
+		if (!in_array($type, array('P', 'M'))) $type = 'P';
+		if (!$layout) return $this->stop('msg_invalid_request');
 
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayoutInfo($layout, null, $type);
-		if(!$layout_info) return $this->stop('msg_invalid_request');
+		if (!$layout_info) return $this->stop('msg_invalid_request');
 
 		Context::set('layout_info', $layout_info);
 
@@ -167,18 +167,18 @@ 
 	{
 		$oModel = getModel('layout');
 		$type = Context::get('type');
-		if(!in_array($type, array('P', 'M'))) $type = 'P';
+		if (!in_array($type, array('P', 'M'))) $type = 'P';
 
 		//Security
 		$security = new Security();
-		$security->encodeHTML('layout_list..layout','layout_list..title');
+		$security->encodeHTML('layout_list..layout', 'layout_list..title');
 
 		// Get layout info
 		$layout = Context::get('layout');
-		if($layout == 'faceoff') return $this->stop('not supported');
+		if ($layout == 'faceoff') return $this->stop('not supported');
 
 		$layout_info = $oModel->getLayoutInfo($layout, null, $type);
-		if(!$layout_info) return $this->stop('msg_invalid_request');
+		if (!$layout_info) return $this->stop('msg_invalid_request');
 
 		// get Menu list
 		$oMenuAdminModel = getAdminModel('menu');
@@ -192,10 +192,10 @@ 
 		$layout_info = $security->encodeHTML('.', 'author..', 'extra_var..', 'extra_var....');
 
 		$layout_info->description = nl2br(trim($layout_info->description));
-		if(!is_object($layout_info->extra_var)) $layout_info->extra_var = new StdClass();
-		foreach($layout_info->extra_var as $var_name => $val)
+		if (!is_object($layout_info->extra_var)) $layout_info->extra_var = new StdClass();
+		foreach ($layout_info->extra_var as $var_name => $val)
 		{
-			if(isset($layout_info->{$var_name}->description))
+			if (isset($layout_info->{$var_name}->description))
 				$layout_info->{$var_name}->description = nl2br(trim($val->description));
 		}
 		Context::set('selected_layout', $layout_info);
@@ -215,7 +215,7 @@ 
 		Context::set('is_sitemap', '0');
 		$script = '<script src="./modules/layout/tpl/js/layout_modify.js"></script>';
 		$oTemplate = &TemplateHandler::getInstance();
-		$content = $oTemplate->compile($this->module_path.'tpl/', 'layout_info_view');
+		$content = $oTemplate->compile($this->module_path . 'tpl/', 'layout_info_view');
 
 		Context::set('content', $content);
 
@@ -234,24 +234,24 @@ 
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayout($layout_srl);
 		// Error appears if there is no layout information is registered
-		if(!$layout_info) return $this->dispLayoutAdminInstalledList();
+		if (!$layout_info) return $this->dispLayoutAdminInstalledList();
 
 		// Get Layout Code
-		if($oLayoutModel->useDefaultLayout($layout_info->layout_srl))
+		if ($oLayoutModel->useDefaultLayout($layout_info->layout_srl))
 		{
-			$layout_file  = $oLayoutModel->getDefaultLayoutHtml($layout_info->layout);
-			$layout_css_file  = $oLayoutModel->getDefaultLayoutCss($layout_info->layout);
+			$layout_file = $oLayoutModel->getDefaultLayoutHtml($layout_info->layout);
+			$layout_css_file = $oLayoutModel->getDefaultLayoutCss($layout_info->layout);
 		}
 		else
 		{
 			$layout_file = $oLayoutModel->getUserLayoutHtml($layout_info->layout_srl);
 			$layout_css_file = $oLayoutModel->getUserLayoutCss($layout_info->layout_srl);
 
-			if(!file_exists($layout_file)) $layout_file = $layout_info->path . 'layout.html';
-			if(!file_exists($layout_css_file)) $layout_css_file = $layout_info->path . 'layout.css';
+			if (!file_exists($layout_file)) $layout_file = $layout_info->path . 'layout.html';
+			if (!file_exists($layout_css_file)) $layout_css_file = $layout_info->path . 'layout.css';
 		}
 
-		if(file_exists($layout_css_file))
+		if (file_exists($layout_css_file))
 		{
 			$layout_code_css = FileHandler::readFile($layout_css_file);
 			Context::set('layout_code_css', $layout_code_css);
@@ -295,30 +295,30 @@ 
 		$layout_srl = Context::get('layout_srl');
 		$code = Context::get('code');
 		$code_css = Context::get('code_css');
-		if(!$layout_srl || !$code) return new Object(-1, 'msg_invalid_request');
+		if (!$layout_srl || !$code) return new Object(-1, 'msg_invalid_request');
 		// Get the layout information
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayout($layout_srl);
-		if(!$layout_info) return new Object(-1, 'msg_invalid_request');
+		if (!$layout_info) return new Object(-1, 'msg_invalid_request');
 		// Separately handle the layout if its type is faceoff
-		if($layout_info && $layout_info->type == 'faceoff') $oLayoutModel->doActivateFaceOff($layout_info);
+		if ($layout_info && $layout_info->type == 'faceoff') $oLayoutModel->doActivateFaceOff($layout_info);
 		// Apply CSS directly
-		Context::addHtmlHeader("<style type=\"text/css\" charset=\"UTF-8\">".$code_css."</style>");
+		Context::addHtmlHeader("<style type=\"text/css\" charset=\"UTF-8\">" . $code_css . "</style>");
 		// Set names and values of extra_vars to $layout_info
-		if($layout_info->extra_var_count)
+		if ($layout_info->extra_var_count)
 		{
-			foreach($layout_info->extra_var as $var_id => $val)
+			foreach ($layout_info->extra_var as $var_id => $val)
 			{
 				$layout_info->{$var_id} = $val->value;
 			}
 		}
 		// menu in layout information becomes an argument for Context:: set
-		if($layout_info->menu_count)
+		if ($layout_info->menu_count)
 		{
-			foreach($layout_info->menu as $menu_id => $menu)
+			foreach ($layout_info->menu as $menu_id => $menu)
 			{
 				$menu->php_file = FileHandler::getRealPath($menu->php_file);
-				if(FileHandler::exists($menu->php_file)) include($menu->php_file);
+				if (FileHandler::exists($menu->php_file)) include($menu->php_file);
 				Context::set($menu_id, $menu);
 			}
 		}
@@ -336,7 +336,7 @@ 
 		$layout_file = 'layout';
 
 		$layout_tpl = $oTemplate->compile($layout_path, $layout_file, $edited_layout_file);
-		Context::set('layout','none');
+		Context::set('layout', 'none');
 		// Convert widgets and others
 		$oContext = &Context::getInstance();
 		Context::set('layout_tpl', $layout_tpl);
@@ -359,7 +359,7 @@ 
 		// Remove the remaining tmp files because of temporarily saving
 		// This part needs to be modified
 		$delete_tmp = Context::get('delete_tmp');
-		if($delete_tmp =='Y')
+		if ($delete_tmp == 'Y')
 		{
 			$oLayoutAdminController = getAdminController('layout');
 			$oLayoutAdminController->deleteUserLayoutTempFile($layout_srl);
@@ -373,24 +373,24 @@ 
 
 		$css = FileHandler::readFile($faceoffcss);
 		$match = null;
-		preg_match_all('/([^\{]+)\{([^\}]*)\}/is',$css,$match);
-		for($i=0,$c=count($match[1]);$i<$c;$i++)
+		preg_match_all('/([^\{]+)\{([^\}]*)\}/is', $css, $match);
+		for ($i = 0, $c = count($match[1]); $i < $c; $i++)
 		{
 			$name = trim($match[1][$i]);
 			$css = trim($match[2][$i]);
-			if(!$css) continue;
-			$css = str_replace('./images/',Context::getRequestUri().$oLayoutModel->getUserLayoutImagePath($layout_srl),$css);
-			$style[] .= sprintf('"%s":"%s"',$name,$css);
+			if (!$css) continue;
+			$css = str_replace('./images/', Context::getRequestUri() . $oLayoutModel->getUserLayoutImagePath($layout_srl), $css);
+			$style[] .= sprintf('"%s":"%s"', $name, $css);
 		}
 
-		if(count($style))
+		if (count($style))
 		{
-			$script = '<script type="text/javascript"> var faceOffStyle = {'.implode(',',$style).'}; </script>';
+			$script = '<script type="text/javascript"> var faceOffStyle = {' . implode(',', $style) . '}; </script>';
 			Context::addHtmlHeader($script);
 		}
 
 		$oTemplate = &TemplateHandler::getInstance();
-		Context::set('content', $oTemplate->compile($this->module_path.'tpl','about_faceoff'));
+		Context::set('content', $oTemplate->compile($this->module_path . 'tpl', 'about_faceoff'));
 		// Change widget codes in Javascript mode
 		$oWidgetController = getController('widget');
 		$oWidgetController->setWidgetCodeInJavascriptMode();

Braces +55 added lines, -21 removed lines

@@ -41,7 +41,9 @@ 
 			$themeLayoutList = array();
 			foreach($themeList as $themeInfo)
 			{
-				if(strpos($themeInfo->layout_info->name, '.') === false) continue;
+				if(strpos($themeInfo->layout_info->name, '.') === false) {
+					continue;
+				}
 				$themeLayoutList[] = $oLayoutModel->getLayoutInfo($themeInfo->layout_info->name, null, 'P');
 			}
 			$layout_list = array_merge($layout_list, $themeLayoutList);
@@ -76,7 +78,9 @@ 
 	{
 		$type = Context::get('type');
 
-		if(!in_array($type, array('P', 'M'))) $type = 'P';
+		if(!in_array($type, array('P', 'M'))) {
+			$type = 'P';
+		}
 
 		$oLayoutModel = getModel('layout');
 
@@ -139,12 +143,18 @@ 
 		$type = Context::get('type');
 		$layout = Context::get('layout');
 
-		if(!in_array($type, array('P', 'M'))) $type = 'P';
-		if(!$layout) return $this->stop('msg_invalid_request');
+		if(!in_array($type, array('P', 'M'))) {
+			$type = 'P';
+		}
+		if(!$layout) {
+			return $this->stop('msg_invalid_request');
+		}
 
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayoutInfo($layout, null, $type);
-		if(!$layout_info) return $this->stop('msg_invalid_request');
+		if(!$layout_info) {
+			return $this->stop('msg_invalid_request');
+		}
 
 		Context::set('layout_info', $layout_info);
 
@@ -167,7 +177,9 @@ 
 	{
 		$oModel = getModel('layout');
 		$type = Context::get('type');
-		if(!in_array($type, array('P', 'M'))) $type = 'P';
+		if(!in_array($type, array('P', 'M'))) {
+			$type = 'P';
+		}
 
 		//Security
 		$security = new Security();
@@ -175,10 +187,14 @@ 
 
 		// Get layout info
 		$layout = Context::get('layout');
-		if($layout == 'faceoff') return $this->stop('not supported');
+		if($layout == 'faceoff') {
+			return $this->stop('not supported');
+		}
 
 		$layout_info = $oModel->getLayoutInfo($layout, null, $type);
-		if(!$layout_info) return $this->stop('msg_invalid_request');
+		if(!$layout_info) {
+			return $this->stop('msg_invalid_request');
+		}
 
 		// get Menu list
 		$oMenuAdminModel = getAdminModel('menu');
@@ -192,11 +208,14 @@ 
 		$layout_info = $security->encodeHTML('.', 'author..', 'extra_var..', 'extra_var....');
 
 		$layout_info->description = nl2br(trim($layout_info->description));
-		if(!is_object($layout_info->extra_var)) $layout_info->extra_var = new StdClass();
+		if(!is_object($layout_info->extra_var)) {
+			$layout_info->extra_var = new StdClass();
+		}
 		foreach($layout_info->extra_var as $var_name => $val)
 		{
-			if(isset($layout_info->{$var_name}->description))
-				$layout_info->{$var_name}->description = nl2br(trim($val->description));
+			if(isset($layout_info->{$var_name}->description)) {
+							$layout_info->{$var_name}->description = nl2br(trim($val->description));
+			}
 		}
 		Context::set('selected_layout', $layout_info);
 
@@ -234,21 +253,26 @@ 
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayout($layout_srl);
 		// Error appears if there is no layout information is registered
-		if(!$layout_info) return $this->dispLayoutAdminInstalledList();
+		if(!$layout_info) {
+			return $this->dispLayoutAdminInstalledList();
+		}
 
 		// Get Layout Code
 		if($oLayoutModel->useDefaultLayout($layout_info->layout_srl))
 		{
 			$layout_file  = $oLayoutModel->getDefaultLayoutHtml($layout_info->layout);
 			$layout_css_file  = $oLayoutModel->getDefaultLayoutCss($layout_info->layout);
-		}
-		else
+		} else
 		{
 			$layout_file = $oLayoutModel->getUserLayoutHtml($layout_info->layout_srl);
 			$layout_css_file = $oLayoutModel->getUserLayoutCss($layout_info->layout_srl);
 
-			if(!file_exists($layout_file)) $layout_file = $layout_info->path . 'layout.html';
-			if(!file_exists($layout_css_file)) $layout_css_file = $layout_info->path . 'layout.css';
+			if(!file_exists($layout_file)) {
+				$layout_file = $layout_info->path . 'layout.html';
+			}
+			if(!file_exists($layout_css_file)) {
+				$layout_css_file = $layout_info->path . 'layout.css';
+			}
 		}
 
 		if(file_exists($layout_css_file))
@@ -295,13 +319,19 @@ 
 		$layout_srl = Context::get('layout_srl');
 		$code = Context::get('code');
 		$code_css = Context::get('code_css');
-		if(!$layout_srl || !$code) return new Object(-1, 'msg_invalid_request');
+		if(!$layout_srl || !$code) {
+			return new Object(-1, 'msg_invalid_request');
+		}
 		// Get the layout information
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayout($layout_srl);
-		if(!$layout_info) return new Object(-1, 'msg_invalid_request');
+		if(!$layout_info) {
+			return new Object(-1, 'msg_invalid_request');
+		}
 		// Separately handle the layout if its type is faceoff
-		if($layout_info && $layout_info->type == 'faceoff') $oLayoutModel->doActivateFaceOff($layout_info);
+		if($layout_info && $layout_info->type == 'faceoff') {
+			$oLayoutModel->doActivateFaceOff($layout_info);
+		}
 		// Apply CSS directly
 		Context::addHtmlHeader("<style type=\"text/css\" charset=\"UTF-8\">".$code_css."</style>");
 		// Set names and values of extra_vars to $layout_info
@@ -318,7 +348,9 @@ 
 			foreach($layout_info->menu as $menu_id => $menu)
 			{
 				$menu->php_file = FileHandler::getRealPath($menu->php_file);
-				if(FileHandler::exists($menu->php_file)) include($menu->php_file);
+				if(FileHandler::exists($menu->php_file)) {
+					include($menu->php_file);
+				}
 				Context::set($menu_id, $menu);
 			}
 		}
@@ -378,7 +410,9 @@ 
 		{
 			$name = trim($match[1][$i]);
 			$css = trim($match[2][$i]);
-			if(!$css) continue;
+			if(!$css) {
+				continue;
+			}
 			$css = str_replace('./images/',Context::getRequestUri().$oLayoutModel->getUserLayoutImagePath($layout_srl),$css);
 			$style[] .= sprintf('"%s":"%s"',$name,$css);
 		}

modules/layout/layout.model.php

Doc Comments +4 added lines, -5 removed lines

@@ -435,7 +435,7 @@ 
 	 * It uses caching to reduce time for xml parsing ..
 	 * @param string $layout
 	 * @param object $info
-	 * @param string $layoutType (P : PC, M : Mobile)
+	 * @param string $layout_type (P : PC, M : Mobile)
 	 * @return object info of layout
 	 */
 	function getLayoutInfo($layout, $info = null, $layout_type = "P")
@@ -737,7 +737,7 @@ 
 	/**
 	 * Return a list of images which are uploaded on the layout setting page
 	 * @param int $layout_srl
-	 * @return array image list in layout
+	 * @return string[] image list in layout
 	 */
 	function getUserLayoutImageList($layout_srl)
 	{
@@ -892,7 +892,6 @@ 
 
 	/**
 	 * layout cache
-	 * @param int $layout_srl
 	 * @param string $lang_type
 	 * @return string
 	 */
@@ -972,7 +971,7 @@ 
 	/**
 	 * Temp file list for User Layout
 	 * @param int $layout_srl
-	 * @return array temp files info
+	 * @return string[] temp files info
 	 */
 	function getUserLayoutTempFileList($layout_srl)
 	{
@@ -986,7 +985,7 @@ 
 	/**
 	 * Saved file list for User Layout
 	 * @param int $layout_srl
-	 * @return array files info
+	 * @return string[] files info
 	 */
 	function getUserLayoutFileList($layout_srl)
 	{

Indentation +5 added lines, -5 removed lines

@@ -1,11 +1,11 @@
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 /**
- * @class  layoutModel
- * @author NAVER (developers@xpressengine.com)
- * @version 0.1
- * Model class of the layout module
- */
+	 * @class  layoutModel
+	 * @author NAVER (developers@xpressengine.com)
+	 * @version 0.1
+	 * Model class of the layout module
+	 */
 class layoutModel extends layout
 {
 	/**

Spacing +148 added lines, -148 removed lines

@@ -31,21 +31,21 @@ 
 	 * @param array $columnList
 	 * @return array layout lists in site
 	 */
-	function getLayoutList($site_srl = 0, $layout_type="P", $columnList = array())
+	function getLayoutList($site_srl = 0, $layout_type = "P", $columnList = array())
 	{
-		if(!$site_srl)
+		if (!$site_srl)
 		{
 			$site_module_info = Context::get('site_module_info');
-			$site_srl = (int)$site_module_info->site_srl;
+			$site_srl = (int) $site_module_info->site_srl;
 		}
 		$args = new stdClass();
 		$args->site_srl = $site_srl;
 		$args->layout_type = $layout_type;
 		$output = executeQueryArray('layout.getLayoutList', $args, $columnList);
 
-		foreach($output->data as $no => &$val)
+		foreach ($output->data as $no => &$val)
 		{
-			if(!$this->isExistsLayoutFile($val->layout, $layout_type))
+			if (!$this->isExistsLayoutFile($val->layout, $layout_type))
 			{
 				unset($output->data[$no]);
 			}
@@ -53,7 +53,7 @@ 
 
 		$oLayoutAdminModel = getAdminModel('layout');
 		$siteDefaultLayoutSrl = $oLayoutAdminModel->getSiteDefaultLayout($layout_type, $site_srl);
-		if($siteDefaultLayoutSrl)
+		if ($siteDefaultLayoutSrl)
 		{
 			$siteDefaultLayoutInfo = $this->getlayout($siteDefaultLayoutSrl);
 			$newLayout = sprintf('%s, %s', $siteDefaultLayoutInfo->title, $siteDefaultLayoutInfo->layout);
@@ -80,24 +80,24 @@ 
 		$layoutList = $this->getLayoutInstanceList($siteSrl, $layoutType);
 		$thumbs = array();
 
-		foreach($layoutList as $key => $val)
+		foreach ($layoutList as $key => $val)
 		{
-			if($thumbs[$val->layouts])
+			if ($thumbs[$val->layouts])
 			{
 				$val->thumbnail = $thumbs[$val->layouts];
 				continue;
 			}
 
 			$token = explode('|@|', $val->layout);
-			if(count($token) == 2)
+			if (count($token) == 2)
 			{
-				$thumbnailPath = sprintf('./themes/%s/layouts/%s/thumbnail.png' , $token[0], $token[1]);
+				$thumbnailPath = sprintf('./themes/%s/layouts/%s/thumbnail.png', $token[0], $token[1]);
 			}
 			else
 			{
-				$thumbnailPath = sprintf('./layouts/%s/thumbnail.png' , $val->layout);
+				$thumbnailPath = sprintf('./layouts/%s/thumbnail.png', $val->layout);
 			}
-			if(is_readable($thumbnailPath))
+			if (is_readable($thumbnailPath))
 			{
 				$val->thumbnail = $thumbnailPath;
 			}
@@ -123,7 +123,7 @@ 
 		if (!$siteSrl)
 		{
 			$siteModuleInfo = Context::get('site_module_info');
-			$siteSrl = (int)$siteModuleInfo->site_srl;
+			$siteSrl = (int) $siteModuleInfo->site_srl;
 		}
 		$args = new stdClass();
 		$args->site_srl = $siteSrl;
@@ -133,11 +133,11 @@ 
 
 		// Create instance name list
 		$instanceList = array();
-		if(is_array($output->data))
+		if (is_array($output->data))
 		{
-			foreach($output->data as $no => $iInfo)
+			foreach ($output->data as $no => $iInfo)
 			{
-				if($this->isExistsLayoutFile($iInfo->layout, $layoutType))
+				if ($this->isExistsLayoutFile($iInfo->layout, $layoutType))
 				{
 					$instanceList[] = $iInfo->layout;
 				}
@@ -152,18 +152,18 @@ 
 		$downloadedList = array();
 		$titleList = array();
 		$_downloadedList = $this->getDownloadedLayoutList($layoutType);
-		if(is_array($_downloadedList))
+		if (is_array($_downloadedList))
 		{
-			foreach($_downloadedList as $dLayoutInfo)
+			foreach ($_downloadedList as $dLayoutInfo)
 			{
 				$downloadedList[$dLayoutInfo->layout] = $dLayoutInfo->layout;
 				$titleList[$dLayoutInfo->layout] = $dLayoutInfo->title;
 			}
 		}
 
-		if($layout)
+		if ($layout)
 		{
-			if(count($instanceList) < 1 && $downloadedList[$layout])
+			if (count($instanceList) < 1 && $downloadedList[$layout])
 			{
 				$insertArgs = new stdClass();
 				$insertArgs->site_srl = $siteSrl;
@@ -181,7 +181,7 @@ 
 		{
 			// Get downloaded name list have no instance
 			$noInstanceList = array_diff($downloadedList, $instanceList);
-			foreach($noInstanceList as $layoutName)
+			foreach ($noInstanceList as $layoutName)
 			{
 				$insertArgs = new stdClass();
 				$insertArgs->site_srl = $siteSrl;
@@ -197,15 +197,15 @@ 
 		}
 
 		// If create layout instance, reload instance list
-		if($isCreateInstance)
+		if ($isCreateInstance)
 		{
 			$output = executeQueryArray('layout.getLayoutList', $args, $columnList);
 
-			if(is_array($output->data))
+			if (is_array($output->data))
 			{
-				foreach($output->data as $no => $iInfo)
+				foreach ($output->data as $no => $iInfo)
 				{
-					if(!$this->isExistsLayoutFile($iInfo->layout, $layoutType))
+					if (!$this->isExistsLayoutFile($iInfo->layout, $layoutType))
 					{
 						unset($output->data[$no]);
 					}
@@ -226,7 +226,7 @@ 
 	function isExistsLayoutFile($layout, $layoutType)
 	{
 		//TODO If remove a support themes, remove this codes also.
-		if($layoutType == 'P')
+		if ($layoutType == 'P')
 		{
 			$pathPrefix = _XE_PATH_ . 'layouts/';
 			$themePathFormat = _XE_PATH_ . 'themes/%s/layouts/%s';
@@ -237,7 +237,7 @@ 
 			$themePathFormat = _XE_PATH_ . 'themes/%s/m.layouts/%s';
 		}
 
-		if(strpos($layout, '|@|') !== FALSE)
+		if (strpos($layout, '|@|') !== FALSE)
 		{
 			list($themeName, $layoutName) = explode('|@|', $layout);
 			$path = sprintf($themePathFormat, $themeName, $layoutName);
@@ -262,7 +262,7 @@ 
 		$args = new stdClass();
 		$args->layout_srl = $layout_srl;
 		$output = executeQuery('layout.getLayout', $args);
-		if(!$output->data) return;
+		if (!$output->data) return;
 
 		// Return xml file informaton after listing up the layout and extra_vars
 		$layout_info = $this->getLayoutInfo($layout, $output->data, $output->data->layout_type);
@@ -275,7 +275,7 @@ 
 		$args = new stdClass();
 		$args->layout_srl = $layout_srl;
 		$output = executeQuery('layout.getLayout', $args, $columnList);
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			return;
 		}
@@ -292,15 +292,15 @@ 
 	function getLayoutPath($layout_name, $layout_type = "P")
 	{
 		$layout_parse = explode('|@|', $layout_name);
-		if(count($layout_parse) > 1)
+		if (count($layout_parse) > 1)
 		{
-			$class_path = './themes/'.$layout_parse[0].'/layouts/'.$layout_parse[1].'/';
+			$class_path = './themes/' . $layout_parse[0] . '/layouts/' . $layout_parse[1] . '/';
 		}
-		else if($layout_name == 'faceoff')
+		else if ($layout_name == 'faceoff')
 		{
 			$class_path = './modules/layout/faceoff/';
 		}
-		else if($layout_type == "M")
+		else if ($layout_type == "M")
 		{
 			$class_path = sprintf("./m.layouts/%s/", $layout_name);
 		}
@@ -308,7 +308,7 @@ 
 		{
 			$class_path = sprintf('./layouts/%s/', $layout_name);
 		}
-		if(is_dir($class_path)) return $class_path;
+		if (is_dir($class_path)) return $class_path;
 		return "";
 	}
 
@@ -326,24 +326,24 @@ 
 		// Get a list of downloaded layout and installed layout
 		$searched_list = $this->_getInstalledLayoutDirectories($layout_type);
 		$searched_count = count($searched_list);
-		if(!$searched_count) return;
+		if (!$searched_count) return;
 
 		// natcasesort($searched_list);
 		// Return information for looping searched list of layouts
 		$list = array();
-		for($i=0;$i<$searched_count;$i++)
+		for ($i = 0; $i < $searched_count; $i++)
 		{
 			// Name of the layout
 			$layout = $searched_list[$i];
 			// Get information of the layout
 			$layout_info = $this->getLayoutInfo($layout, null, $layout_type);
 
-			if(!$layout_info)
+			if (!$layout_info)
 			{
 				continue;
 			}
 
-			if($withAutoinstallInfo)
+			if ($withAutoinstallInfo)
 			{
 				// get easyinstall remove url
 				$packageSrl = $oAutoinstallModel->getPackageSrlByPath($layout_info->path);
@@ -354,7 +354,7 @@ 
 				$layout_info->need_update = $package[$packageSrl]->need_update;
 
 				// get easyinstall update url
-				if($layout_info->need_update)
+				if ($layout_info->need_update)
 				{
 					$layout_info->update_url = $oAutoinstallModel->getUpdateUrlByPackageSrl($packageSrl);
 				}
@@ -371,12 +371,12 @@ 
 	 */
 	function sortLayoutByTitle($a, $b)
 	{
-		if(!$a->title)
+		if (!$a->title)
 		{
 			$a->title = $a->layout;
 		}
 
-		if(!$b->title)
+		if (!$b->title)
 		{
 			$b->title = $b->layout;
 		}
@@ -384,7 +384,7 @@ 
 		$aTitle = strtolower($a->title);
 		$bTitle = strtolower($b->title);
 
-		if($aTitle == $bTitle)
+		if ($aTitle == $bTitle)
 		{
 			return 0;
 		}
@@ -410,7 +410,7 @@ 
 	 */
 	function _getInstalledLayoutDirectories($layoutType = 'P')
 	{
-		if($layoutType == 'M')
+		if ($layoutType == 'M')
 		{
 			$directory = './m.layouts';
 			$globalValueKey = 'MOBILE_LAYOUT_DIRECTOIES';
@@ -421,7 +421,7 @@ 
 			$globalValueKey = 'PC_LAYOUT_DIRECTORIES';
 		}
 
-		if($GLOBALS[$globalValueKey]) return $GLOBALS[$globalValueKey];
+		if ($GLOBALS[$globalValueKey]) return $GLOBALS[$globalValueKey];
 
 		$searchedList = FileHandler::readDir($directory);
 		if (!$searchedList) $searchedList = array();
@@ -440,7 +440,7 @@ 
 	 */
 	function getLayoutInfo($layout, $info = null, $layout_type = "P")
 	{
-		if($info)
+		if ($info)
 		{
 			$layout_title = $info->title;
 			$layout = $info->layout;
@@ -448,35 +448,35 @@ 
 			$site_srl = $info->site_srl;
 			$vars = unserialize($info->extra_vars);
 
-			if($info->module_srl)
+			if ($info->module_srl)
 			{
-				$layout_path = preg_replace('/([a-zA-Z0-9\_\.]+)(\.html)$/','',$info->layout_path);
+				$layout_path = preg_replace('/([a-zA-Z0-9\_\.]+)(\.html)$/', '', $info->layout_path);
 				$xml_file = sprintf('%sskin.xml', $layout_path);
 			}
 		}
 
 		// Get a path of the requested module. Return if not exists.
-		if(!$layout_path) $layout_path = $this->getLayoutPath($layout, $layout_type);
-		if(!is_dir($layout_path)) return;
+		if (!$layout_path) $layout_path = $this->getLayoutPath($layout, $layout_type);
+		if (!is_dir($layout_path)) return;
 
 		// Read the xml file for module skin information
-		if(!$xml_file) $xml_file = sprintf("%sconf/info.xml", $layout_path);
-		if(!file_exists($xml_file))
+		if (!$xml_file) $xml_file = sprintf("%sconf/info.xml", $layout_path);
+		if (!file_exists($xml_file))
 		{
 			$layout_info = new stdClass;
 			$layout_info->title = $layout;
 			$layout_info->layout = $layout;
 			$layout_info->path = $layout_path;
 			$layout_info->layout_title = $layout_title;
-			if(!$layout_info->layout_type)
+			if (!$layout_info->layout_type)
 			{
-				$layout_info->layout_type =  $layout_type;
+				$layout_info->layout_type = $layout_type;
 			}
 			return $layout_info;
 		}
 
 		// Include the cache file if it is valid and then return $layout_info variable
-		if(!$layout_srl)
+		if (!$layout_srl)
 		{
 			$cache_file = $this->getLayoutCache($layout, Context::getLangType(), $layout_type);
 		}
@@ -485,22 +485,22 @@ 
 			$cache_file = $this->getUserLayoutCache($layout_srl, Context::getLangType());
 		}
 
-		if(file_exists($cache_file)&&filemtime($cache_file)>filemtime($xml_file))
+		if (file_exists($cache_file) && filemtime($cache_file) > filemtime($xml_file))
 		{
 			include($cache_file);
 
-			if($layout_info->extra_var && $vars)
+			if ($layout_info->extra_var && $vars)
 			{
-				foreach($vars as $key => $value)
+				foreach ($vars as $key => $value)
 				{
-					if(!$layout_info->extra_var->{$key} && !$layout_info->{$key})
+					if (!$layout_info->extra_var->{$key} && !$layout_info->{$key})
 					{
 						$layout_info->{$key} = $value;
 					}
 				}
 			}
 
-			if(!$layout_info->title)
+			if (!$layout_info->title)
 			{
 				$layout_info->title = $layout;
 			}
@@ -511,16 +511,16 @@ 
 		$oXmlParser = new XmlParser();
 		$tmp_xml_obj = $oXmlParser->loadXmlFile($xml_file);
 
-		if($tmp_xml_obj->layout) $xml_obj = $tmp_xml_obj->layout;
-		elseif($tmp_xml_obj->skin) $xml_obj = $tmp_xml_obj->skin;
+		if ($tmp_xml_obj->layout) $xml_obj = $tmp_xml_obj->layout;
+		elseif ($tmp_xml_obj->skin) $xml_obj = $tmp_xml_obj->skin;
 
-		if(!$xml_obj) return;
+		if (!$xml_obj) return;
 
 		$buff = array();
 		$buff[] = '$layout_info = new stdClass;';
 		$buff[] = sprintf('$layout_info->site_srl = "%s";', $site_srl);
 
-		if($xml_obj->version && $xml_obj->attrs->version == '0.2')
+		if ($xml_obj->version && $xml_obj->attrs->version == '0.2')
 		{
 			// Layout title, version and other information
 			sscanf($xml_obj->date->body, '%d-%d-%d', $date_obj->y, $date_obj->m, $date_obj->d);
@@ -540,11 +540,11 @@ 
 			$buff[] = sprintf('$layout_info->layout_type = "%s";', $layout_type);
 
 			// Author information
-			if(!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;
+			if (!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;
 			else $author_list = $xml_obj->author;
 
 			$buff[] = '$layout_info->author = array();';
-			for($i=0, $c=count($author_list); $i<$c; $i++)
+			for ($i = 0, $c = count($author_list); $i < $c; $i++)
 			{
 				$buff[] = sprintf('$layout_info->author[%d] = new stdClass;', $i);
 				$buff[] = sprintf('$layout_info->author[%d]->name = "%s";', $i, $author_list[$i]->name->body);
@@ -554,22 +554,22 @@ 
 
 			// Extra vars (user defined variables to use in a template)
 			$extra_var_groups = $xml_obj->extra_vars->group;
-			if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
-			if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
+			if (!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
+			if (!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
 
 			$buff[] = '$layout_info->extra_var = new stdClass;';
 			$extra_var_count = 0;
-			foreach($extra_var_groups as $group)
+			foreach ($extra_var_groups as $group)
 			{
 				$extra_vars = $group->var;
-				if($extra_vars)
+				if ($extra_vars)
 				{
-					if(!is_array($extra_vars)) $extra_vars = array($extra_vars);
+					if (!is_array($extra_vars)) $extra_vars = array($extra_vars);
 
 					$count = count($extra_vars);
 					$extra_var_count += $count;
 					
-					for($i=0;$i<$count;$i++)
+					for ($i = 0; $i < $count; $i++)
 					{
 						unset($var, $options);
 						$var = $extra_vars[$i];
@@ -580,26 +580,26 @@ 
 						$buff[] = sprintf('$layout_info->extra_var->%s->title = "%s";', $name, $var->title->body);
 						$buff[] = sprintf('$layout_info->extra_var->%s->type = "%s";', $name, $var->attrs->type);
 						$buff[] = sprintf('$layout_info->extra_var->%s->value = $vars->%s;', $name, $name);
-						$buff[] = sprintf('$layout_info->extra_var->%s->description = "%s";', $name, str_replace('"','\"',$var->description->body));
+						$buff[] = sprintf('$layout_info->extra_var->%s->description = "%s";', $name, str_replace('"', '\"', $var->description->body));
 
 						$options = $var->options;
-						if(!$options) continue;
-						if(!is_array($options)) $options = array($options);
+						if (!$options) continue;
+						if (!is_array($options)) $options = array($options);
 
 						$buff[] = sprintf('$layout_info->extra_var->%s->options = array();', $var->attrs->name);
 						$options_count = count($options);
 						$thumbnail_exist = false;
-						for($j=0; $j < $options_count; $j++)
+						for ($j = 0; $j < $options_count; $j++)
 						{
 							$buff[] = sprintf('$layout_info->extra_var->%s->options["%s"] = new stdClass;', $var->attrs->name, $options[$j]->attrs->value);
 							$thumbnail = $options[$j]->attrs->src;
-							if($thumbnail)
+							if ($thumbnail)
 							{
-								$thumbnail = $layout_path.$thumbnail;
-								if(file_exists($thumbnail))
+								$thumbnail = $layout_path . $thumbnail;
+								if (file_exists($thumbnail))
 								{
 									$buff[] = sprintf('$layout_info->extra_var->%s->options["%s"]->thumbnail = "%s";', $var->attrs->name, $options[$j]->attrs->value, $thumbnail);
-									if(!$thumbnail_exist)
+									if (!$thumbnail_exist)
 									{
 										$buff[] = sprintf('$layout_info->extra_var->%s->thumbnail_exist = true;', $var->attrs->name);
 										$thumbnail_exist = true;
@@ -613,26 +613,26 @@ 
 			}
 			$buff[] = sprintf('$layout_info->extra_var_count = "%s";', $extra_var_count);
 			// Menu
-			if($xml_obj->menus->menu)
+			if ($xml_obj->menus->menu)
 			{
 				$menus = $xml_obj->menus->menu;
-				if(!is_array($menus)) $menus = array($menus);
+				if (!is_array($menus)) $menus = array($menus);
 
 				$menu_count = count($menus);
 				$buff[] = sprintf('$layout_info->menu_count = "%s";', $menu_count);
 				$buff[] = '$layout_info->menu = new stdClass;';
-				for($i=0;$i<$menu_count;$i++)
+				for ($i = 0; $i < $menu_count; $i++)
 				{
 					$name = $menus[$i]->attrs->name;
-					if($menus[$i]->attrs->default == "true") $buff[] = sprintf('$layout_info->default_menu = "%s";', $name);
+					if ($menus[$i]->attrs->default == "true") $buff[] = sprintf('$layout_info->default_menu = "%s";', $name);
 					$buff[] = sprintf('$layout_info->menu->%s = new stdClass;', $name);
-					$buff[] = sprintf('$layout_info->menu->%s->name = "%s";',$name, $menus[$i]->attrs->name);
-					$buff[] = sprintf('$layout_info->menu->%s->title = "%s";',$name, $menus[$i]->title->body);
-					$buff[] = sprintf('$layout_info->menu->%s->maxdepth = "%s";',$name, $menus[$i]->attrs->maxdepth);
+					$buff[] = sprintf('$layout_info->menu->%s->name = "%s";', $name, $menus[$i]->attrs->name);
+					$buff[] = sprintf('$layout_info->menu->%s->title = "%s";', $name, $menus[$i]->title->body);
+					$buff[] = sprintf('$layout_info->menu->%s->maxdepth = "%s";', $name, $menus[$i]->attrs->maxdepth);
 
 					$buff[] = sprintf('$layout_info->menu->%s->menu_srl = $vars->%s;', $name, $name);
-					$buff[] = sprintf('$layout_info->menu->%s->xml_file = "./files/cache/menu/".$vars->%s.".xml.php";',$name, $name);
-					$buff[] = sprintf('$layout_info->menu->%s->php_file = "./files/cache/menu/".$vars->%s.".php";',$name, $name);
+					$buff[] = sprintf('$layout_info->menu->%s->xml_file = "./files/cache/menu/".$vars->%s.".xml.php";', $name, $name);
+					$buff[] = sprintf('$layout_info->menu->%s->php_file = "./files/cache/menu/".$vars->%s.".php";', $name, $name);
 				}
 			}
 		}
@@ -655,19 +655,19 @@ 
 			$buff[] = sprintf('$layout_info->author[0]->homepage = "%s";', $xml_obj->author->attrs->link);
 			// Extra vars (user defined variables to use in a template)
 			$extra_var_groups = $xml_obj->extra_vars->group;
-			if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
-			if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
-			foreach($extra_var_groups as $group)
+			if (!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
+			if (!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
+			foreach ($extra_var_groups as $group)
 			{
 				$extra_vars = $group->var;
-				if($extra_vars)
+				if ($extra_vars)
 				{
-					if(!is_array($extra_vars)) $extra_vars = array($extra_vars);
+					if (!is_array($extra_vars)) $extra_vars = array($extra_vars);
 
 					$extra_var_count = count($extra_vars);
 
 					$buff[] = sprintf('$layout_info->extra_var_count = "%s";', $extra_var_count);
-					for($i=0;$i<$extra_var_count;$i++)
+					for ($i = 0; $i < $extra_var_count; $i++)
 					{
 						unset($var, $options);
 						$var = $extra_vars[$i];
@@ -677,14 +677,14 @@ 
 						$buff[] = sprintf('$layout_info->extra_var->%s->title = "%s";', $name, $var->title->body);
 						$buff[] = sprintf('$layout_info->extra_var->%s->type = "%s";', $name, $var->attrs->type);
 						$buff[] = sprintf('$layout_info->extra_var->%s->value = $vars->%s;', $name, $name);
-						$buff[] = sprintf('$layout_info->extra_var->%s->description = "%s";', $name, str_replace('"','\"',$var->description->body));
+						$buff[] = sprintf('$layout_info->extra_var->%s->description = "%s";', $name, str_replace('"', '\"', $var->description->body));
 
 						$options = $var->options;
-						if(!$options) continue;
+						if (!$options) continue;
 
-						if(!is_array($options)) $options = array($options);
+						if (!is_array($options)) $options = array($options);
 						$options_count = count($options);
-						for($j=0;$j<$options_count;$j++)
+						for ($j = 0; $j < $options_count; $j++)
 						{
 							$buff[] = sprintf('$layout_info->extra_var->%s->options["%s"]->val = "%s";', $var->attrs->name, $options[$j]->value->body, $options[$j]->title->body);
 						}
@@ -692,23 +692,23 @@ 
 				}
 			}
 			// Menu
-			if($xml_obj->menus->menu)
+			if ($xml_obj->menus->menu)
 			{
 				$menus = $xml_obj->menus->menu;
-				if(!is_array($menus)) $menus = array($menus);
+				if (!is_array($menus)) $menus = array($menus);
 
 				$menu_count = count($menus);
 				$buff[] = sprintf('$layout_info->menu_count = "%s";', $menu_count);
-				for($i=0;$i<$menu_count;$i++)
+				for ($i = 0; $i < $menu_count; $i++)
 				{
 					$name = $menus[$i]->attrs->name;
-					if($menus[$i]->attrs->default == "true") $buff[] = sprintf('$layout_info->default_menu = "%s";', $name);
-					$buff[] = sprintf('$layout_info->menu->%s->name = "%s";',$name, $name);
-					$buff[] = sprintf('$layout_info->menu->%s->title = "%s";',$name, $menus[$i]->title->body);
-					$buff[] = sprintf('$layout_info->menu->%s->maxdepth = "%s";',$name, $menus[$i]->maxdepth->body);
+					if ($menus[$i]->attrs->default == "true") $buff[] = sprintf('$layout_info->default_menu = "%s";', $name);
+					$buff[] = sprintf('$layout_info->menu->%s->name = "%s";', $name, $name);
+					$buff[] = sprintf('$layout_info->menu->%s->title = "%s";', $name, $menus[$i]->title->body);
+					$buff[] = sprintf('$layout_info->menu->%s->maxdepth = "%s";', $name, $menus[$i]->maxdepth->body);
 					$buff[] = sprintf('$layout_info->menu->%s->menu_srl = $vars->%s;', $name, $name);
-					$buff[] = sprintf('$layout_info->menu->%s->xml_file = "./files/cache/menu/".$vars->%s.".xml.php";',$name, $name);
-					$buff[] = sprintf('$layout_info->menu->%s->php_file = "./files/cache/menu/".$vars->%s.".php";',$name, $name);
+					$buff[] = sprintf('$layout_info->menu->%s->xml_file = "./files/cache/menu/".$vars->%s.".xml.php";', $name, $name);
+					$buff[] = sprintf('$layout_info->menu->%s->php_file = "./files/cache/menu/".$vars->%s.".php";', $name, $name);
 				}
 			}
 		}
@@ -718,15 +718,15 @@ 
 		$layout_config = $oModuleModel->getModulePartConfig('layout', $layout_srl);
 		$header_script = trim($layout_config->header_script);
 
-		if($header_script)
+		if ($header_script)
 		{
-			$buff[] = sprintf(' $layout_info->header_script = "%s"; ', str_replace(array('$','"'),array('\$','\\"'),$header_script));
+			$buff[] = sprintf(' $layout_info->header_script = "%s"; ', str_replace(array('$', '"'), array('\$', '\\"'), $header_script));
 		}
 
 		FileHandler::writeFile($cache_file, '<?php if(!defined("__XE__")) exit(); ' . join(PHP_EOL, $buff));
-		if(FileHandler::exists($cache_file)) include($cache_file);
+		if (FileHandler::exists($cache_file)) include($cache_file);
 
-		if(!$layout_info->title)
+		if (!$layout_info->title)
 		{
 			$layout_info->title = $layout;
 		}
@@ -750,12 +750,12 @@ 
 	 * @param string $layout_name
 	 * @return array
 	 */
-	function getUserLayoutIniConfig($layout_srl, $layout_name=null)
+	function getUserLayoutIniConfig($layout_srl, $layout_name = null)
 	{
 		$file = $this->getUserLayoutIni($layout_srl);
-		if($layout_name && FileHandler::exists($file) === FALSE)
+		if ($layout_name && FileHandler::exists($file) === FALSE)
 		{
-			FileHandler::copyFile($this->getDefaultLayoutIni($layout_name),$this->getUserLayoutIni($layout_srl));
+			FileHandler::copyFile($this->getDefaultLayoutIni($layout_name), $this->getUserLayoutIni($layout_srl));
 		}
 
 		return FileHandler::readIniFile($file);
@@ -768,7 +768,7 @@ 
 	 */
 	function getUserLayoutPath($layout_srl)
 	{
-		return sprintf("./files/faceOff/%s", getNumberingPath($layout_srl,3));
+		return sprintf("./files/faceOff/%s", getNumberingPath($layout_srl, 3));
 	}
 
 	/**
@@ -778,7 +778,7 @@ 
 	 */
 	function getUserLayoutImagePath($layout_srl)
 	{
-		return $this->getUserLayoutPath($layout_srl). 'images/';
+		return $this->getUserLayoutPath($layout_srl) . 'images/';
 	}
 
 	/**
@@ -788,7 +788,7 @@ 
 	 */
 	function getUserLayoutCss($layout_srl)
 	{
-		return $this->getUserLayoutPath($layout_srl). 'layout.css';
+		return $this->getUserLayoutPath($layout_srl) . 'layout.css';
 	}
 
 	/**
@@ -798,7 +798,7 @@ 
 	 */
 	function getUserLayoutFaceOffCss($layout_srl)
 	{
-		if($this->useUserLayoutTemp == 'temp') return;
+		if ($this->useUserLayoutTemp == 'temp') return;
 		return $this->_getUserLayoutFaceOffCss($layout_srl);
 	}
 
@@ -809,7 +809,7 @@ 
 	 */
 	function _getUserLayoutFaceOffCss($layout_srl)
 	{
-		return $this->getUserLayoutPath($layout_srl). 'faceoff.css';
+		return $this->getUserLayoutPath($layout_srl) . 'faceoff.css';
 	}
 
 	/**
@@ -819,7 +819,7 @@ 
 	 */
 	function getUserLayoutTempFaceOffCss($layout_srl)
 	{
-		return $this->getUserLayoutPath($layout_srl). 'tmp.faceoff.css';
+		return $this->getUserLayoutPath($layout_srl) . 'tmp.faceoff.css';
 	}
 
 	/**
@@ -829,11 +829,11 @@ 
 	 */
 	function getUserLayoutHtml($layout_srl)
 	{
-		$src = $this->getUserLayoutPath($layout_srl). 'layout.html';
-		if($this->useUserLayoutTemp == 'temp')
+		$src = $this->getUserLayoutPath($layout_srl) . 'layout.html';
+		if ($this->useUserLayoutTemp == 'temp')
 		{
 			$temp = $this->getUserLayoutTempHtml($layout_srl);
-			if(FileHandler::exists($temp) === FALSE) FileHandler::copyFile($src,$temp);
+			if (FileHandler::exists($temp) === FALSE) FileHandler::copyFile($src, $temp);
 			return $temp;
 		}
 
@@ -847,7 +847,7 @@ 
 	 */
 	function getUserLayoutTempHtml($layout_srl)
 	{
-		return $this->getUserLayoutPath($layout_srl). 'tmp.layout.html';
+		return $this->getUserLayoutPath($layout_srl) . 'tmp.layout.html';
 	}
 
 	/**
@@ -857,11 +857,11 @@ 
 	 */
 	function getUserLayoutIni($layout_srl)
 	{
-		$src = $this->getUserLayoutPath($layout_srl). 'layout.ini';
-		if($this->useUserLayoutTemp == 'temp')
+		$src = $this->getUserLayoutPath($layout_srl) . 'layout.ini';
+		if ($this->useUserLayoutTemp == 'temp')
 		{
 			$temp = $this->getUserLayoutTempIni($layout_srl);
-			if(!file_exists(FileHandler::getRealPath($temp))) FileHandler::copyFile($src,$temp);
+			if (!file_exists(FileHandler::getRealPath($temp))) FileHandler::copyFile($src, $temp);
 			return $temp;
 		}
 
@@ -875,7 +875,7 @@ 
 	 */
 	function getUserLayoutTempIni($layout_srl)
 	{
-		return $this->getUserLayoutPath($layout_srl). 'tmp.layout.ini';
+		return $this->getUserLayoutPath($layout_srl) . 'tmp.layout.ini';
 	}
 
 	/**
@@ -885,9 +885,9 @@ 
 	 * @param string $lang_type
 	 * @return string
 	 */
-	function getUserLayoutCache($layout_srl,$lang_type)
+	function getUserLayoutCache($layout_srl, $lang_type)
 	{
-		return $this->getUserLayoutPath($layout_srl). "{$lang_type}.cache.php";
+		return $this->getUserLayoutPath($layout_srl) . "{$lang_type}.cache.php";
 	}
 
 	/**
@@ -896,15 +896,15 @@ 
 	 * @param string $lang_type
 	 * @return string
 	 */
-	function getLayoutCache($layout_name,$lang_type,$layout_type='P')
+	function getLayoutCache($layout_name, $lang_type, $layout_type = 'P')
 	{
-		if($layout_type=='P')
+		if ($layout_type == 'P')
 		{
-			return sprintf("%sfiles/cache/layout/%s.%s.cache.php", _XE_PATH_, $layout_name,$lang_type);
+			return sprintf("%sfiles/cache/layout/%s.%s.cache.php", _XE_PATH_, $layout_name, $lang_type);
 		}
 		else
 		{
-			return sprintf("%sfiles/cache/layout/m.%s.%s.cache.php", _XE_PATH_, $layout_name,$lang_type);
+			return sprintf("%sfiles/cache/layout/m.%s.%s.cache.php", _XE_PATH_, $layout_name, $lang_type);
 		}
 	}
 
@@ -915,7 +915,7 @@ 
 	 */
 	function getDefaultLayoutIni($layout_name)
 	{
-		return $this->getDefaultLayoutPath($layout_name). 'layout.ini';
+		return $this->getDefaultLayoutPath($layout_name) . 'layout.ini';
 	}
 
 	/**
@@ -925,7 +925,7 @@ 
 	 */
 	function getDefaultLayoutHtml($layout_name)
 	{
-		return $this->getDefaultLayoutPath($layout_name). 'layout.html';
+		return $this->getDefaultLayoutPath($layout_name) . 'layout.html';
 	}
 
 	/**
@@ -935,7 +935,7 @@ 
 	 */
 	function getDefaultLayoutCss($layout_name)
 	{
-		return $this->getDefaultLayoutPath($layout_name). 'css/layout.css';
+		return $this->getDefaultLayoutPath($layout_name) . 'css/layout.css';
 	}
 
 	/**
@@ -964,7 +964,7 @@ 
 	 * @param string $flag (default 'temp')
 	 * @return void
 	 */
-	function setUseUserLayoutTemp($flag='temp')
+	function setUseUserLayoutTemp($flag = 'temp')
 	{
 		$this->useUserLayoutTemp = $flag;
 	}
@@ -998,9 +998,9 @@ 
 		);
 
 		$image_path = $this->getUserLayoutImagePath($layout_srl);
-		$image_list = FileHandler::readDir($image_path,'/(.*(?:swf|jpg|jpeg|gif|bmp|png)$)/i');
+		$image_list = FileHandler::readDir($image_path, '/(.*(?:swf|jpg|jpeg|gif|bmp|png)$)/i');
 
-		foreach($image_list as $image)
+		foreach ($image_list as $image)
 		{
 			$file_list[] = 'images/' . $image;
 		}
@@ -1020,23 +1020,23 @@ 
 		Context::addCSSFile($this->getDefaultLayoutCss($layout_info->layout));
 		// CSS generated in the layout manager
 		$faceoff_layout_css = $this->getUserLayoutFaceOffCss($layout_info->layout_srl);
-		if($faceoff_layout_css) Context::addCSSFile($faceoff_layout_css);
+		if ($faceoff_layout_css) Context::addCSSFile($faceoff_layout_css);
 		// CSS output for the widget
-		Context::loadFile($this->module_path.'/tpl/css/widget.css', true);
-		if($layout_info->extra_var->colorset->value == 'black') Context::loadFile($this->module_path.'/tpl/css/widget@black.css', true);
-		else Context::loadFile($this->module_path.'/tpl/css/widget@white.css', true);
+		Context::loadFile($this->module_path . '/tpl/css/widget.css', true);
+		if ($layout_info->extra_var->colorset->value == 'black') Context::loadFile($this->module_path . '/tpl/css/widget@black.css', true);
+		else Context::loadFile($this->module_path . '/tpl/css/widget@white.css', true);
 		// Different page displayed upon user's permission
 		$logged_info = Context::get('logged_info');
 		// Display edit button for faceoff layout
-		if(Context::get('module')!='admin' && strpos(Context::get('act'),'Admin')===false && ($logged_info->is_admin == 'Y' || $logged_info->is_site_admin))
+		if (Context::get('module') != 'admin' && strpos(Context::get('act'), 'Admin') === false && ($logged_info->is_admin == 'Y' || $logged_info->is_site_admin))
 		{
-			Context::addHtmlFooter('<div class="faceOffManager" style="height: 23px; position: fixed; right: 3px; top: 3px;"><a href="'.getUrl('','mid',Context::get('mid'),'act','dispLayoutAdminLayoutModify','delete_tmp','Y').'">'.Context::getLang('cmd_layout_edit').'</a></div>');
+			Context::addHtmlFooter('<div class="faceOffManager" style="height: 23px; position: fixed; right: 3px; top: 3px;"><a href="' . getUrl('', 'mid', Context::get('mid'), 'act', 'dispLayoutAdminLayoutModify', 'delete_tmp', 'Y') . '">' . Context::getLang('cmd_layout_edit') . '</a></div>');
 		}
 		// Display menu when editing the faceOff page
-		if(Context::get('act')=='dispLayoutAdminLayoutModify' && ($logged_info->is_admin == 'Y' || $logged_info->is_site_admin))
+		if (Context::get('act') == 'dispLayoutAdminLayoutModify' && ($logged_info->is_admin == 'Y' || $logged_info->is_site_admin))
 		{
 			$oTemplate = &TemplateHandler::getInstance();
-			Context::addBodyHeader($oTemplate->compile($this->module_path.'/tpl', 'faceoff_layout_menu'));
+			Context::addBodyHeader($oTemplate->compile($this->module_path . '/tpl', 'faceoff_layout_menu'));
 		}
 	}
 }

Braces +115 added lines, -61 removed lines

@@ -92,16 +92,14 @@ 
 			if(count($token) == 2)
 			{
 				$thumbnailPath = sprintf('./themes/%s/layouts/%s/thumbnail.png' , $token[0], $token[1]);
-			}
-			else
+			} else
 			{
 				$thumbnailPath = sprintf('./layouts/%s/thumbnail.png' , $val->layout);
 			}
 			if(is_readable($thumbnailPath))
 			{
 				$val->thumbnail = $thumbnailPath;
-			}
-			else
+			} else
 			{
 				$val->thumbnail = sprintf('./modules/layout/tpl/img/noThumbnail.png');
 			}
@@ -140,8 +138,7 @@ 
 				if($this->isExistsLayoutFile($iInfo->layout, $layoutType))
 				{
 					$instanceList[] = $iInfo->layout;
-				}
-				else
+				} else
 				{
 					unset($output->data[$no]);
 				}
@@ -176,8 +173,7 @@ 
 				$oLayoutAdminController->insertLayout($insertArgs);
 				$isCreateInstance = TRUE;
 			}
-		}
-		else
+		} else
 		{
 			// Get downloaded name list have no instance
 			$noInstanceList = array_diff($downloadedList, $instanceList);
@@ -230,8 +226,7 @@ 
 		{
 			$pathPrefix = _XE_PATH_ . 'layouts/';
 			$themePathFormat = _XE_PATH_ . 'themes/%s/layouts/%s';
-		}
-		else
+		} else
 		{
 			$pathPrefix = _XE_PATH_ . 'm.layouts/';
 			$themePathFormat = _XE_PATH_ . 'themes/%s/m.layouts/%s';
@@ -241,8 +236,7 @@ 
 		{
 			list($themeName, $layoutName) = explode('|@|', $layout);
 			$path = sprintf($themePathFormat, $themeName, $layoutName);
-		}
-		else
+		} else
 		{
 			$path = $pathPrefix . $layout;
 		}
@@ -262,7 +256,9 @@ 
 		$args = new stdClass();
 		$args->layout_srl = $layout_srl;
 		$output = executeQuery('layout.getLayout', $args);
-		if(!$output->data) return;
+		if(!$output->data) {
+			return;
+		}
 
 		// Return xml file informaton after listing up the layout and extra_vars
 		$layout_info = $this->getLayoutInfo($layout, $output->data, $output->data->layout_type);
@@ -295,20 +291,19 @@ 
 		if(count($layout_parse) > 1)
 		{
 			$class_path = './themes/'.$layout_parse[0].'/layouts/'.$layout_parse[1].'/';
-		}
-		else if($layout_name == 'faceoff')
+		} else if($layout_name == 'faceoff')
 		{
 			$class_path = './modules/layout/faceoff/';
-		}
-		else if($layout_type == "M")
+		} else if($layout_type == "M")
 		{
 			$class_path = sprintf("./m.layouts/%s/", $layout_name);
-		}
-		else
+		} else
 		{
 			$class_path = sprintf('./layouts/%s/', $layout_name);
 		}
-		if(is_dir($class_path)) return $class_path;
+		if(is_dir($class_path)) {
+			return $class_path;
+		}
 		return "";
 	}
 
@@ -321,12 +316,16 @@ 
 	 */
 	function getDownloadedLayoutList($layout_type = "P", $withAutoinstallInfo = false)
 	{
-		if ($withAutoinstallInfo) $oAutoinstallModel = getModel('autoinstall');
+		if ($withAutoinstallInfo) {
+			$oAutoinstallModel = getModel('autoinstall');
+		}
 
 		// Get a list of downloaded layout and installed layout
 		$searched_list = $this->_getInstalledLayoutDirectories($layout_type);
 		$searched_count = count($searched_list);
-		if(!$searched_count) return;
+		if(!$searched_count) {
+			return;
+		}
 
 		// natcasesort($searched_list);
 		// Return information for looping searched list of layouts
@@ -414,17 +413,20 @@ 
 		{
 			$directory = './m.layouts';
 			$globalValueKey = 'MOBILE_LAYOUT_DIRECTOIES';
-		}
-		else
+		} else
 		{
 			$directory = './layouts';
 			$globalValueKey = 'PC_LAYOUT_DIRECTORIES';
 		}
 
-		if($GLOBALS[$globalValueKey]) return $GLOBALS[$globalValueKey];
+		if($GLOBALS[$globalValueKey]) {
+			return $GLOBALS[$globalValueKey];
+		}
 
 		$searchedList = FileHandler::readDir($directory);
-		if (!$searchedList) $searchedList = array();
+		if (!$searchedList) {
+			$searchedList = array();
+		}
 		$GLOBALS[$globalValueKey] = $searchedList;
 
 		return $searchedList;
@@ -456,11 +458,17 @@ 
 		}
 
 		// Get a path of the requested module. Return if not exists.
-		if(!$layout_path) $layout_path = $this->getLayoutPath($layout, $layout_type);
-		if(!is_dir($layout_path)) return;
+		if(!$layout_path) {
+			$layout_path = $this->getLayoutPath($layout, $layout_type);
+		}
+		if(!is_dir($layout_path)) {
+			return;
+		}
 
 		// Read the xml file for module skin information
-		if(!$xml_file) $xml_file = sprintf("%sconf/info.xml", $layout_path);
+		if(!$xml_file) {
+			$xml_file = sprintf("%sconf/info.xml", $layout_path);
+		}
 		if(!file_exists($xml_file))
 		{
 			$layout_info = new stdClass;
@@ -479,8 +487,7 @@ 
 		if(!$layout_srl)
 		{
 			$cache_file = $this->getLayoutCache($layout, Context::getLangType(), $layout_type);
-		}
-		else
+		} else
 		{
 			$cache_file = $this->getUserLayoutCache($layout_srl, Context::getLangType());
 		}
@@ -511,10 +518,15 @@ 
 		$oXmlParser = new XmlParser();
 		$tmp_xml_obj = $oXmlParser->loadXmlFile($xml_file);
 
-		if($tmp_xml_obj->layout) $xml_obj = $tmp_xml_obj->layout;
-		elseif($tmp_xml_obj->skin) $xml_obj = $tmp_xml_obj->skin;
+		if($tmp_xml_obj->layout) {
+			$xml_obj = $tmp_xml_obj->layout;
+		} elseif($tmp_xml_obj->skin) {
+			$xml_obj = $tmp_xml_obj->skin;
+		}
 
-		if(!$xml_obj) return;
+		if(!$xml_obj) {
+			return;
+		}
 
 		$buff = array();
 		$buff[] = '$layout_info = new stdClass;';
@@ -540,8 +552,11 @@ 
 			$buff[] = sprintf('$layout_info->layout_type = "%s";', $layout_type);
 
 			// Author information
-			if(!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;
-			else $author_list = $xml_obj->author;
+			if(!is_array($xml_obj->author)) {
+				$author_list[] = $xml_obj->author;
+			} else {
+				$author_list = $xml_obj->author;
+			}
 
 			$buff[] = '$layout_info->author = array();';
 			for($i=0, $c=count($author_list); $i<$c; $i++)
@@ -554,8 +569,12 @@ 
 
 			// Extra vars (user defined variables to use in a template)
 			$extra_var_groups = $xml_obj->extra_vars->group;
-			if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
-			if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
+			if(!$extra_var_groups) {
+				$extra_var_groups = $xml_obj->extra_vars;
+			}
+			if(!is_array($extra_var_groups)) {
+				$extra_var_groups = array($extra_var_groups);
+			}
 
 			$buff[] = '$layout_info->extra_var = new stdClass;';
 			$extra_var_count = 0;
@@ -564,7 +583,9 @@ 
 				$extra_vars = $group->var;
 				if($extra_vars)
 				{
-					if(!is_array($extra_vars)) $extra_vars = array($extra_vars);
+					if(!is_array($extra_vars)) {
+						$extra_vars = array($extra_vars);
+					}
 
 					$count = count($extra_vars);
 					$extra_var_count += $count;
@@ -583,8 +604,12 @@ 
 						$buff[] = sprintf('$layout_info->extra_var->%s->description = "%s";', $name, str_replace('"','\"',$var->description->body));
 
 						$options = $var->options;
-						if(!$options) continue;
-						if(!is_array($options)) $options = array($options);
+						if(!$options) {
+							continue;
+						}
+						if(!is_array($options)) {
+							$options = array($options);
+						}
 
 						$buff[] = sprintf('$layout_info->extra_var->%s->options = array();', $var->attrs->name);
 						$options_count = count($options);
@@ -616,7 +641,9 @@ 
 			if($xml_obj->menus->menu)
 			{
 				$menus = $xml_obj->menus->menu;
-				if(!is_array($menus)) $menus = array($menus);
+				if(!is_array($menus)) {
+					$menus = array($menus);
+				}
 
 				$menu_count = count($menus);
 				$buff[] = sprintf('$layout_info->menu_count = "%s";', $menu_count);
@@ -624,7 +651,9 @@ 
 				for($i=0;$i<$menu_count;$i++)
 				{
 					$name = $menus[$i]->attrs->name;
-					if($menus[$i]->attrs->default == "true") $buff[] = sprintf('$layout_info->default_menu = "%s";', $name);
+					if($menus[$i]->attrs->default == "true") {
+						$buff[] = sprintf('$layout_info->default_menu = "%s";', $name);
+					}
 					$buff[] = sprintf('$layout_info->menu->%s = new stdClass;', $name);
 					$buff[] = sprintf('$layout_info->menu->%s->name = "%s";',$name, $menus[$i]->attrs->name);
 					$buff[] = sprintf('$layout_info->menu->%s->title = "%s";',$name, $menus[$i]->title->body);
@@ -635,8 +664,7 @@ 
 					$buff[] = sprintf('$layout_info->menu->%s->php_file = "./files/cache/menu/".$vars->%s.".php";',$name, $name);
 				}
 			}
-		}
-		else
+		} else
 		{
 			// Layout title, version and other information
 			sscanf($xml_obj->author->attrs->date, '%d. %d. %d', $date_obj->y, $date_obj->m, $date_obj->d);
@@ -655,14 +683,20 @@ 
 			$buff[] = sprintf('$layout_info->author[0]->homepage = "%s";', $xml_obj->author->attrs->link);
 			// Extra vars (user defined variables to use in a template)
 			$extra_var_groups = $xml_obj->extra_vars->group;
-			if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
-			if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);
+			if(!$extra_var_groups) {
+				$extra_var_groups = $xml_obj->extra_vars;
+			}
+			if(!is_array($extra_var_groups)) {
+				$extra_var_groups = array($extra_var_groups);
+			}
 			foreach($extra_var_groups as $group)
 			{
 				$extra_vars = $group->var;
 				if($extra_vars)
 				{
-					if(!is_array($extra_vars)) $extra_vars = array($extra_vars);
+					if(!is_array($extra_vars)) {
+						$extra_vars = array($extra_vars);
+					}
 
 					$extra_var_count = count($extra_vars);
 
@@ -680,9 +714,13 @@ 
 						$buff[] = sprintf('$layout_info->extra_var->%s->description = "%s";', $name, str_replace('"','\"',$var->description->body));
 
 						$options = $var->options;
-						if(!$options) continue;
+						if(!$options) {
+							continue;
+						}
 
-						if(!is_array($options)) $options = array($options);
+						if(!is_array($options)) {
+							$options = array($options);
+						}
 						$options_count = count($options);
 						for($j=0;$j<$options_count;$j++)
 						{
@@ -695,14 +733,18 @@ 
 			if($xml_obj->menus->menu)
 			{
 				$menus = $xml_obj->menus->menu;
-				if(!is_array($menus)) $menus = array($menus);
+				if(!is_array($menus)) {
+					$menus = array($menus);
+				}
 
 				$menu_count = count($menus);
 				$buff[] = sprintf('$layout_info->menu_count = "%s";', $menu_count);
 				for($i=0;$i<$menu_count;$i++)
 				{
 					$name = $menus[$i]->attrs->name;
-					if($menus[$i]->attrs->default == "true") $buff[] = sprintf('$layout_info->default_menu = "%s";', $name);
+					if($menus[$i]->attrs->default == "true") {
+						$buff[] = sprintf('$layout_info->default_menu = "%s";', $name);
+					}
 					$buff[] = sprintf('$layout_info->menu->%s->name = "%s";',$name, $name);
 					$buff[] = sprintf('$layout_info->menu->%s->title = "%s";',$name, $menus[$i]->title->body);
 					$buff[] = sprintf('$layout_info->menu->%s->maxdepth = "%s";',$name, $menus[$i]->maxdepth->body);
@@ -724,7 +766,9 @@ 
 		}
 
 		FileHandler::writeFile($cache_file, '<?php if(!defined("__XE__")) exit(); ' . join(PHP_EOL, $buff));
-		if(FileHandler::exists($cache_file)) include($cache_file);
+		if(FileHandler::exists($cache_file)) {
+			include($cache_file);
+		}
 
 		if(!$layout_info->title)
 		{
@@ -798,7 +842,9 @@ 
 	 */
 	function getUserLayoutFaceOffCss($layout_srl)
 	{
-		if($this->useUserLayoutTemp == 'temp') return;
+		if($this->useUserLayoutTemp == 'temp') {
+			return;
+		}
 		return $this->_getUserLayoutFaceOffCss($layout_srl);
 	}
 
@@ -833,7 +879,9 @@ 
 		if($this->useUserLayoutTemp == 'temp')
 		{
 			$temp = $this->getUserLayoutTempHtml($layout_srl);
-			if(FileHandler::exists($temp) === FALSE) FileHandler::copyFile($src,$temp);
+			if(FileHandler::exists($temp) === FALSE) {
+				FileHandler::copyFile($src,$temp);
+			}
 			return $temp;
 		}
 
@@ -861,7 +909,9 @@ 
 		if($this->useUserLayoutTemp == 'temp')
 		{
 			$temp = $this->getUserLayoutTempIni($layout_srl);
-			if(!file_exists(FileHandler::getRealPath($temp))) FileHandler::copyFile($src,$temp);
+			if(!file_exists(FileHandler::getRealPath($temp))) {
+				FileHandler::copyFile($src,$temp);
+			}
 			return $temp;
 		}
 
@@ -901,8 +951,7 @@ 
 		if($layout_type=='P')
 		{
 			return sprintf("%sfiles/cache/layout/%s.%s.cache.php", _XE_PATH_, $layout_name,$lang_type);
-		}
-		else
+		} else
 		{
 			return sprintf("%sfiles/cache/layout/m.%s.%s.cache.php", _XE_PATH_, $layout_name,$lang_type);
 		}
@@ -1020,11 +1069,16 @@ 
 		Context::addCSSFile($this->getDefaultLayoutCss($layout_info->layout));
 		// CSS generated in the layout manager
 		$faceoff_layout_css = $this->getUserLayoutFaceOffCss($layout_info->layout_srl);
-		if($faceoff_layout_css) Context::addCSSFile($faceoff_layout_css);
+		if($faceoff_layout_css) {
+			Context::addCSSFile($faceoff_layout_css);
+		}
 		// CSS output for the widget
 		Context::loadFile($this->module_path.'/tpl/css/widget.css', true);
-		if($layout_info->extra_var->colorset->value == 'black') Context::loadFile($this->module_path.'/tpl/css/widget@black.css', true);
-		else Context::loadFile($this->module_path.'/tpl/css/widget@white.css', true);
+		if($layout_info->extra_var->colorset->value == 'black') {
+			Context::loadFile($this->module_path.'/tpl/css/widget@black.css', true);
+		} else {
+			Context::loadFile($this->module_path.'/tpl/css/widget@white.css', true);
+		}
 		// Different page displayed upon user's permission
 		$logged_info = Context::get('logged_info');
 		// Display edit button for faceoff layout

modules/layout/layout.view.php

Doc Comments +7 added lines, -1 removed lines

@@ -312,7 +312,7 @@ 
 
 	/**
 	 * Preview a layout
-	 * @return void|Object (void : success, Object : fail)
+	 * @return Object|null (void : success, Object : fail)
 	 */
 	function dispLayoutPreview()
 	{
@@ -376,6 +376,9 @@ 
 		$this->setTemplateFile('layout_preview');
 	}
 
+	/**
+	 * @return string
+	 */
 	private function getRealLayoutFile($layoutSrl)
 	{
 		$oLayoutModel = getModel('layout');
@@ -392,6 +395,9 @@ 
 
 	}
 
+	/**
+	 * @return string
+	 */
 	private function getRealLayoutCSS($layoutSrl)
 	{
 		$oLayoutModel = getModel('layout');

Indentation +4 added lines, -4 removed lines

@@ -1,10 +1,10 @@
 <?php
 /* Copyright (C) NAVER <http://www.navercorp.com> */
 /**
- * @class  layoutView
- * @author NAVER (developers@xpressengine.com)
- * admin view class of the layout module
- */
+	 * @class  layoutView
+	 * @author NAVER (developers@xpressengine.com)
+	 * admin view class of the layout module
+	 */
 class layoutView extends layout
 {
 	/**

Spacing +44 added lines, -44 removed lines

@@ -13,7 +13,7 @@ 
 	 */
 	function init()
 	{
-		$this->setTemplatePath($this->module_path.'tpl');
+		$this->setTemplatePath($this->module_path . 'tpl');
 	}
 
 	/**
@@ -25,7 +25,7 @@ 
 		// Get the layout information
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayoutInfo(Context::get('selected_layout'));
-		if(!$layout_info) exit();
+		if (!$layout_info) exit();
 		Context::set('layout_info', $layout_info);
 		// Set the layout to be pop-up
 		$this->setLayoutFile('popup_layout');
@@ -53,13 +53,13 @@ 
 			// admin check
 			// this act is admin view but in normal view because do not load admin css/js files
 			$logged_info = Context::get('logged_info');
-			if($logged_info->is_admin != 'Y')
+			if ($logged_info->is_admin != 'Y')
 			{
 				throw new Exception(Context::getLang('msg_invalid_request'));
 			}
 
 			// if module is 'ARTiCLE' and from site design setting, make content directly
-			if($module == 'ARTICLE' && !$mid)
+			if ($module == 'ARTICLE' && !$mid)
 			{
 				$oDocumentModel = getModel('document');
 				$oDocument = $oDocumentModel->getDocument(0, true);
@@ -67,10 +67,10 @@ 
 				$t = Context::getLang('article_preview_title');
 
 				$c = '';
-				for($i = 0; $i < 4; $i++)
+				for ($i = 0; $i < 4; $i++)
 				{
 					$c .= '<p>';
-					for($j = 0; $j < 20; $j++)
+					for ($j = 0; $j < 20; $j++)
 					{
 						$c .= Context::getLang('article_preview_content') . ' ';
 					}
@@ -108,15 +108,15 @@ 
 			Context::set('content', $content);
 
 			// find layout
-			if($layoutSrl)
+			if ($layoutSrl)
 			{
-				if($layoutSrl == -1)
+				if ($layoutSrl == -1)
 				{
 					$site_srl = ($oModule) ? $oModule->module_info->site_srl : 0;
 					$designInfoFile = sprintf(_XE_PATH_ . 'files/site_design/design_%s.php', $site_srl);
 					include($designInfoFile);
 
-					if($skinType == 'M')
+					if ($skinType == 'M')
 					{
 						$layoutSrl = $designInfo->mlayout_srl;
 					}
@@ -130,19 +130,19 @@ 
 				$layoutInfo = $oLayoutModel->getLayout($layoutSrl);
 
 				// If there is no layout, pass it.
-				if($layoutInfo)
+				if ($layoutInfo)
 				{
 					// Adhoc...
 
 					// Input extra_vars into $layout_info
-					if($layoutInfo->extra_var_count)
+					if ($layoutInfo->extra_var_count)
 					{
 
-						foreach($layoutInfo->extra_var as $var_id => $val)
+						foreach ($layoutInfo->extra_var as $var_id => $val)
 						{
-							if($val->type == 'image')
+							if ($val->type == 'image')
 							{
-								if(strncmp('./files/attach/images/', $val->value, 22) === 0)
+								if (strncmp('./files/attach/images/', $val->value, 22) === 0)
 								{
 									$val->value = Context::getRequestUri() . substr($val->value, 2);
 								}
@@ -152,22 +152,22 @@ 
 					}
 
 					// Set menus into context
-					if($layoutInfo->menu_count)
+					if ($layoutInfo->menu_count)
 					{
-						foreach($layoutInfo->menu as $menu_id => $menu)
+						foreach ($layoutInfo->menu as $menu_id => $menu)
 						{
 							// set default menu set(included home menu)
-							if(!$menu->menu_srl || $menu->menu_srl == -1)
+							if (!$menu->menu_srl || $menu->menu_srl == -1)
 							{
 								$oMenuAdminController = getAdminController('menu');
 								$homeMenuCacheFile = $oMenuAdminController->getHomeMenuCacheFile();
 
-								if(file_exists($homeMenuCacheFile))
+								if (file_exists($homeMenuCacheFile))
 								{
 									include($homeMenuCacheFile);
 								}
 
-								if(!$menu->menu_srl)
+								if (!$menu->menu_srl)
 								{
 									$menu->xml_file = str_replace('.xml.php', $homeMenuSrl . '.xml.php', $menu->xml_file);
 									$menu->php_file = str_replace('.php', $homeMenuSrl . '.php', $menu->php_file);
@@ -181,7 +181,7 @@ 
 							}
 
 							$menu->php_file = FileHandler::getRealPath($menu->php_file);
-							if(FileHandler::exists($menu->php_file))
+							if (FileHandler::exists($menu->php_file))
 							{
 								include($menu->php_file);
 							}
@@ -193,7 +193,7 @@ 
 				}
 			}
 		}
-		catch(Exception $e)
+		catch (Exception $e)
 		{
 			$content = '<div class="message error"><p id="preview_error">' . $e->getMessage() . '</p></div>';
 			Context::set('content', $content);
@@ -204,12 +204,12 @@ 
 		$oTemplate = TemplateHandler::getInstance();
 		Context::clearHtmlHeader();
 
-		if($layoutInfo)
+		if ($layoutInfo)
 		{
 			$layout_path = $layoutInfo->path;
 			$editLayoutTPL = $this->getRealLayoutFile($layoutSrl);
 			$editLayoutCSS = $this->getRealLayoutCSS($layoutSrl);
-			if($editLayoutCSS != '')
+			if ($editLayoutCSS != '')
 			{
 				Context::addCSSFile($editLayoutCSS);
 			}
@@ -225,12 +225,12 @@ 
 		}
 
 		$layout_tpl = $oTemplate->compile($layout_path, $layout_file, $editLayoutTPL);
-		Context::set('layout','none');
+		Context::set('layout', 'none');
 
 		// Convert widgets and others
 		$oContext = Context::getInstance();
 		Context::set('layout_tpl', $layout_tpl);
-		$this->setTemplatePath($this->module_path.'tpl');
+		$this->setTemplatePath($this->module_path . 'tpl');
 		$this->setTemplateFile('layout_preview');
 	}
 
@@ -246,18 +246,18 @@ 
 	private function procRealModule($module, $mid, $skin, $skinType)
 	{
 		// if form site design and preview module, find target module
-		if($module && !$mid)
+		if ($module && !$mid)
 		{
 			$args = new stdClass();
 			$args->module = $module;
 			$output = executeQuery('layout.getOneModuleInstanceByModuleName', $args);
-			if(!$output->toBool())
+			if (!$output->toBool())
 			{
 				throw new Exception($output->getMessage());
 			}
 
 			// if there is no module instance, error...
-			if(!$output->data)
+			if (!$output->data)
 			{
 				throw new Exception(Context::getLang('msg_unabled_preview'));
 			}
@@ -266,7 +266,7 @@ 
 		}
 
 		// if form site design and preview layout, find start module
-		elseif(!$module && !$mid)
+		elseif (!$module && !$mid)
 		{
 			$oModuleModel = getModel('module');
 			$columnList = array('modules.mid', 'sites.index_module_srl');
@@ -286,7 +286,7 @@ 
 		$oModuleHandler->module_info->is_skin_fix = 'Y';
 		$oModuleHandler->module_info->is_mskin_fix = 'Y';
 
-		if($skinType == 'M')
+		if ($skinType == 'M')
 		{
 			Mobile::setMobile(TRUE);
 			$oModuleHandler->module_info->mskin = $skin;
@@ -299,7 +299,7 @@ 
 
 		// Proc module
 		$oModule = $oModuleHandler->procModule();
-		if(!$oModule->toBool())
+		if (!$oModule->toBool())
 		{
 			throw new Exception(Context::getLang('not_support_layout_preview'));
 		}
@@ -319,36 +319,36 @@ 
 		// admin check
 		// this act is admin view but in normal view because do not load admin css/js files
 		$logged_info = Context::get('logged_info');
-		if($logged_info->is_admin != 'Y') return $this->stop('msg_invalid_request');
+		if ($logged_info->is_admin != 'Y') return $this->stop('msg_invalid_request');
 
 		$layout_srl = Context::get('layout_srl');
 		$code = Context::get('code');
 
 		$code_css = Context::get('code_css');
-		if(!$layout_srl || !$code) return new Object(-1, 'msg_invalid_request');
+		if (!$layout_srl || !$code) return new Object(-1, 'msg_invalid_request');
 		// Get the layout information
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayout($layout_srl);
-		if(!$layout_info) return new Object(-1, 'msg_invalid_request');
+		if (!$layout_info) return new Object(-1, 'msg_invalid_request');
 		// Separately handle the layout if its type is faceoff
-		if($layout_info && $layout_info->type == 'faceoff') $oLayoutModel->doActivateFaceOff($layout_info);
+		if ($layout_info && $layout_info->type == 'faceoff') $oLayoutModel->doActivateFaceOff($layout_info);
 		// Apply CSS directly
-		Context::addHtmlHeader("<style type=\"text/css\" charset=\"UTF-8\">".$code_css."</style>");
+		Context::addHtmlHeader("<style type=\"text/css\" charset=\"UTF-8\">" . $code_css . "</style>");
 		// Set names and values of extra_vars to $layout_info
-		if($layout_info->extra_var_count)
+		if ($layout_info->extra_var_count)
 		{
-			foreach($layout_info->extra_var as $var_id => $val)
+			foreach ($layout_info->extra_var as $var_id => $val)
 			{
 				$layout_info->{$var_id} = $val->value;
 			}
 		}
 		// menu in layout information becomes an argument for Context:: set
-		if($layout_info->menu_count)
+		if ($layout_info->menu_count)
 		{
-			foreach($layout_info->menu as $menu_id => $menu)
+			foreach ($layout_info->menu as $menu_id => $menu)
 			{
 				$menu->php_file = FileHandler::getRealPath($menu->php_file);
-				if(FileHandler::exists($menu->php_file)) include($menu->php_file);
+				if (FileHandler::exists($menu->php_file)) include($menu->php_file);
 
 				Context::set($menu_id, $menu);
 			}
@@ -367,7 +367,7 @@ 
 		$layout_file = 'layout';
 
 		$layout_tpl = $oTemplate->compile($layout_path, $layout_file, $edited_layout_file);
-		Context::set('layout','none');
+		Context::set('layout', 'none');
 		// Convert widgets and others
 		$oContext = &Context::getInstance();
 		Context::set('layout_tpl', $layout_tpl);
@@ -381,7 +381,7 @@ 
 		$oLayoutModel = getModel('layout');
 		$layoutFile = $oLayoutModel->getUserLayoutHtml($layoutSrl);
 
-		if(file_exists($layoutFile))
+		if (file_exists($layoutFile))
 		{
 			return $layoutFile;
 		}
@@ -397,7 +397,7 @@ 
 		$oLayoutModel = getModel('layout');
 		$cssFile = $oLayoutModel->getUserLayoutCss($layoutSrl);
 
-		if(file_exists($cssFile))
+		if (file_exists($cssFile))
 		{
 			return $cssFile;
 		}

Braces +26 added lines, -22 removed lines

@@ -25,7 +25,9 @@ 
 		// Get the layout information
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayoutInfo(Context::get('selected_layout'));
-		if(!$layout_info) exit();
+		if(!$layout_info) {
+			exit();
+		}
 		Context::set('layout_info', $layout_info);
 		// Set the layout to be pop-up
 		$this->setLayoutFile('popup_layout');
@@ -89,8 +91,7 @@ 
 				{
 					$templatePath = _XE_PATH_ . 'modules/page/m.skins/' . $skin;
 					$templateFile = 'mobile';
-				}
-				else
+				} else
 				{
 					$templatePath = _XE_PATH_ . 'modules/page/skins/' . $skin;
 					$templateFile = 'content';
@@ -119,8 +120,7 @@ 
 					if($skinType == 'M')
 					{
 						$layoutSrl = $designInfo->mlayout_srl;
-					}
-					else
+					} else
 					{
 						$layoutSrl = $designInfo->layout_srl;
 					}
@@ -172,8 +172,7 @@ 
 									$menu->xml_file = str_replace('.xml.php', $homeMenuSrl . '.xml.php', $menu->xml_file);
 									$menu->php_file = str_replace('.php', $homeMenuSrl . '.php', $menu->php_file);
 									$layoutInfo->menu->{$menu_id}->menu_srl = $homeMenuSrl;
-								}
-								else
+								} else
 								{
 									$menu->xml_file = str_replace($menu->menu_srl, $homeMenuSrl, $menu->xml_file);
 									$menu->php_file = str_replace($menu->menu_srl, $homeMenuSrl, $menu->php_file);
@@ -192,8 +191,7 @@ 
 					Context::set('layout_info', $layoutInfo);
 				}
 			}
-		}
-		catch(Exception $e)
+		} catch(Exception $e)
 		{
 			$content = '<div class="message error"><p id="preview_error">' . $e->getMessage() . '</p></div>';
 			Context::set('content', $content);
@@ -217,8 +215,7 @@ 
 			$oModuleModel = getModel('module');
 			$part_config = $oModuleModel->getModulePartConfig('layout', $layoutSrl);
 			Context::addHtmlHeader($part_config->header_script);
-		}
-		else
+		} else
 		{
 			$layout_path = './common/tpl';
 			$layout_file = 'default_layout';
@@ -290,8 +287,7 @@ 
 		{
 			Mobile::setMobile(TRUE);
 			$oModuleHandler->module_info->mskin = $skin;
-		}
-		else
+		} else
 		{
 			Mobile::setMobile(FALSE);
 			$oModuleHandler->module_info->skin = $skin;
@@ -319,19 +315,27 @@ 
 		// admin check
 		// this act is admin view but in normal view because do not load admin css/js files
 		$logged_info = Context::get('logged_info');
-		if($logged_info->is_admin != 'Y') return $this->stop('msg_invalid_request');
+		if($logged_info->is_admin != 'Y') {
+			return $this->stop('msg_invalid_request');
+		}
 
 		$layout_srl = Context::get('layout_srl');
 		$code = Context::get('code');
 
 		$code_css = Context::get('code_css');
-		if(!$layout_srl || !$code) return new Object(-1, 'msg_invalid_request');
+		if(!$layout_srl || !$code) {
+			return new Object(-1, 'msg_invalid_request');
+		}
 		// Get the layout information
 		$oLayoutModel = getModel('layout');
 		$layout_info = $oLayoutModel->getLayout($layout_srl);
-		if(!$layout_info) return new Object(-1, 'msg_invalid_request');
+		if(!$layout_info) {
+			return new Object(-1, 'msg_invalid_request');
+		}
 		// Separately handle the layout if its type is faceoff
-		if($layout_info && $layout_info->type == 'faceoff') $oLayoutModel->doActivateFaceOff($layout_info);
+		if($layout_info && $layout_info->type == 'faceoff') {
+			$oLayoutModel->doActivateFaceOff($layout_info);
+		}
 		// Apply CSS directly
 		Context::addHtmlHeader("<style type=\"text/css\" charset=\"UTF-8\">".$code_css."</style>");
 		// Set names and values of extra_vars to $layout_info
@@ -348,7 +352,9 @@ 
 			foreach($layout_info->menu as $menu_id => $menu)
 			{
 				$menu->php_file = FileHandler::getRealPath($menu->php_file);
-				if(FileHandler::exists($menu->php_file)) include($menu->php_file);
+				if(FileHandler::exists($menu->php_file)) {
+					include($menu->php_file);
+				}
 
 				Context::set($menu_id, $menu);
 			}
@@ -384,8 +390,7 @@ 
 		if(file_exists($layoutFile))
 		{
 			return $layoutFile;
-		}
-		else
+		} else
 		{
 			return ''; 
 		}
@@ -400,8 +405,7 @@ 
 		if(file_exists($cssFile))
 		{
 			return $cssFile;
-		}
-		else
+		} else
 		{
 			return ''; 
 		}

modules/member/member.admin.controller.php

Doc Comments +4 added lines, -1 removed lines

@@ -1114,7 +1114,7 @@ 
 
 	/**
 	 * Insert a group
-	 * @param object $args
+	 * @param null|stdClass $args
 	 * @return Object
 	 */
 	function insertGroup($args)
@@ -1311,6 +1311,9 @@ 
 		return executeQuery('member.insertDeniedID', $args);
 	}
 
+	/**
+	 * @param string $nick_name
+	 */
 	function insertDeniedNickName($nick_name, $description = '')
 	{
 		$args = new stdClass();

Indentation +1 added lines, -1 removed lines

@@ -1284,7 +1284,7 @@
 	/**
 	 * Delete cached group data
 	 * @return void
-	*/
+	 */
 	function _deleteMemberGroupCache($site_srl = 0)
 	{
 		//remove from cache

Spacing +195 added lines, -195 removed lines

@@ -24,31 +24,31 @@ 
 		// if(Context::getRequestMethod() == "GET") return new Object(-1, "msg_invalid_request");
 		// Extract the necessary information in advance
 		$logged_info = Context::get('logged_info');
-		if($logged_info->is_admin != 'Y' || !checkCSRF())
+		if ($logged_info->is_admin != 'Y' || !checkCSRF())
 		{
 			return new Object(-1, 'msg_invalid_request');
 		}
 
-		$args = Context::gets('member_srl','email_address','find_account_answer', 'allow_mailing','allow_message','denied','is_admin','description','group_srl_list','limit_date');
-		$oMemberModel = &getModel ('member');
-		$config = $oMemberModel->getMemberConfig ();
+		$args = Context::gets('member_srl', 'email_address', 'find_account_answer', 'allow_mailing', 'allow_message', 'denied', 'is_admin', 'description', 'group_srl_list', 'limit_date');
+		$oMemberModel = &getModel('member');
+		$config = $oMemberModel->getMemberConfig();
 		$getVars = array();
-		if($config->signupForm)
+		if ($config->signupForm)
 		{
-			foreach($config->signupForm as $formInfo)
+			foreach ($config->signupForm as $formInfo)
 			{
-				if($formInfo->isDefaultForm && ($formInfo->isUse || $formInfo->required || $formInfo->mustRequired))
+				if ($formInfo->isDefaultForm && ($formInfo->isUse || $formInfo->required || $formInfo->mustRequired))
 				{
 					$getVars[] = $formInfo->name;
 				}
 			}
 		}
-		foreach($getVars as $val)
+		foreach ($getVars as $val)
 		{
 			$args->{$val} = Context::get($val);
 		}
 		$args->member_srl = Context::get('member_srl');
-		if(Context::get('reset_password'))
+		if (Context::get('reset_password'))
 			$args->password = Context::get('reset_password');
 		else unset($args->password);
 
@@ -60,7 +60,7 @@ 
 		unset($all_args->error_return_url);
 		unset($all_args->success_return_url);
 		unset($all_args->ruleset);
-		if(!isset($args->limit_date)) $args->limit_date = "";
+		if (!isset($args->limit_date)) $args->limit_date = "";
 		unset($all_args->password);
 		unset($all_args->password2);
 		unset($all_args->reset_password);
@@ -68,7 +68,7 @@ 
 		$extra_vars = delObjectVars($all_args, $args);
 		$args->extra_vars = serialize($extra_vars);
 		// Check if an original member exists having the member_srl
-		if($args->member_srl)
+		if ($args->member_srl)
 		{
 			// Create a member model object
 			$oMemberModel = getModel('member');
@@ -76,14 +76,14 @@ 
 			$columnList = array('member_srl');
 			$member_info = $oMemberModel->getMemberInfoByMemberSrl($args->member_srl, 0, $columnList);
 			// If no original member exists, make a new one
-			if($member_info->member_srl != $args->member_srl) unset($args->member_srl);
+			if ($member_info->member_srl != $args->member_srl) unset($args->member_srl);
 		}
 
 		// remove whitespace
 		$checkInfos = array('user_id', 'user_name', 'nick_name', 'email_address');
-		foreach($checkInfos as $val)
+		foreach ($checkInfos as $val)
 		{
-			if(isset($args->{$val}))
+			if (isset($args->{$val}))
 			{
 				$args->{$val} = preg_replace('/[\pZ\pC]+/u', '', $args->{$val});
 			}
@@ -91,7 +91,7 @@ 
 
 		$oMemberController = getController('member');
 		// Execute insert or update depending on the value of member_srl
-		if(!$args->member_srl)
+		if (!$args->member_srl)
 		{
 			$args->password = Context::get('password');
 			$output = $oMemberController->insertMember($args);
@@ -103,7 +103,7 @@ 
 			$msg_code = 'success_updated';
 		}
 
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 		// Save Signature
 		$signature = Context::get('signature');
 		$oMemberController->putSignature($args->member_srl, $signature);
@@ -112,13 +112,13 @@ 
 		$this->setMessage($msg_code);
 
 		$profile_image = $_FILES['profile_image'];
-		if(is_uploaded_file($profile_image['tmp_name']))
+		if (is_uploaded_file($profile_image['tmp_name']))
 		{
 			$oMemberController->insertProfileImage($args->member_srl, $profile_image['tmp_name']);
 		}
 
 		$image_mark = $_FILES['image_mark'];
-		if(is_uploaded_file($image_mark['tmp_name']))
+		if (is_uploaded_file($image_mark['tmp_name']))
 		{
 			$oMemberController->insertImageMark($args->member_srl, $image_mark['tmp_name']);
 		}
@@ -144,9 +144,9 @@ 
 
 		$oMemberController = getController('member');
 		$output = $oMemberController->deleteMember($member_srl);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
-		$this->add('page',Context::get('page'));
+		$this->add('page', Context::get('page'));
 		$this->setMessage("success_deleted");
 	}
 
@@ -165,26 +165,26 @@ 
 		);
 		
 		$oPassword = new Password();
-		if(!array_key_exists($args->password_hashing_algorithm, $oPassword->getSupportedAlgorithms()))
+		if (!array_key_exists($args->password_hashing_algorithm, $oPassword->getSupportedAlgorithms()))
 		{
 			$args->password_hashing_algorithm = 'md5';
 		}
 		
 		$args->password_hashing_work_factor = intval($args->password_hashing_work_factor, 10);
-		if($args->password_hashing_work_factor < 4)
+		if ($args->password_hashing_work_factor < 4)
 		{
 			$args->password_hashing_work_factor = 4;
 		}
-		if($args->password_hashing_work_factor > 16)
+		if ($args->password_hashing_work_factor > 16)
 		{
 			$args->password_hashing_work_factor = 16;
 		}
-		if($args->password_hashing_auto_upgrade != 'Y')
+		if ($args->password_hashing_auto_upgrade != 'Y')
 		{
 			$args->password_hashing_auto_upgrade = 'N';
 		}
 
-		if((!$args->webmaster_name || !$args->webmaster_email) && $args->enable_confirm == 'Y')
+		if ((!$args->webmaster_name || !$args->webmaster_email) && $args->enable_confirm == 'Y')
 		{
 			return new Object(-1, 'msg_mail_authorization');
 		}
@@ -219,25 +219,25 @@ 
 		$usable_list = Context::get('usable_list');
 		$all_args = Context::getRequestVars();
 
-		$args->limit_day = (int)$args->limit_day;
-		if(!trim(strip_tags($args->agreement)))
+		$args->limit_day = (int) $args->limit_day;
+		if (!trim(strip_tags($args->agreement)))
 		{
-			$agreement_file = _XE_PATH_.'files/member_extra_info/agreement_' . Context::get('lang_type') . '.txt';
+			$agreement_file = _XE_PATH_ . 'files/member_extra_info/agreement_' . Context::get('lang_type') . '.txt';
 			FileHandler::removeFile($agreement_file);
 			$args->agreement = NULL;
 		}
 
-		if($args->redirect_url)
+		if ($args->redirect_url)
 		{
 			$oModuleModel = getModel('module');
 			$redirectModuleInfo = $oModuleModel->getModuleInfoByModuleSrl($args->redirect_url, array('mid'));
 
-			if(!$redirectModuleInfo)
+			if (!$redirectModuleInfo)
 			{
 				return new Object('-1', 'msg_exist_selected_module');
 			}
 
-			$args->redirect_url = Context::getDefaultUrl().$redirectModuleInfo->mid;
+			$args->redirect_url = Context::getDefaultUrl() . $redirectModuleInfo->mid;
 		}
 
 		$args->profile_image = $args->profile_image ? 'Y' : 'N';
@@ -256,43 +256,43 @@ 
 		$items = array('user_id', 'password', 'user_name', 'nick_name', 'email_address', 'find_account_question', 'homepage', 'blog', 'birthday', 'signature', 'profile_image', 'image_name', 'image_mark', 'profile_image_max_width', 'profile_image_max_height', 'image_name_max_width', 'image_name_max_height', 'image_mark_max_width', 'image_mark_max_height');
 		$mustRequireds = array('email_address', 'nick_name', 'password', 'find_account_question');
 		$extendItems = $oMemberModel->getJoinFormList();
-		foreach($list_order as $key)
+		foreach ($list_order as $key)
 		{
 			$signupItem = new stdClass();
 			$signupItem->isIdentifier = ($key == $all_args->identifier);
 			$signupItem->isDefaultForm = in_array($key, $items);
 
 			$signupItem->name = $key;
-			if(!in_array($key, $items)) $signupItem->title = $key;
+			if (!in_array($key, $items)) $signupItem->title = $key;
 			else $signupItem->title = $lang->{$key};
 			$signupItem->mustRequired = in_array($key, $mustRequireds);
 			$signupItem->imageType = (strpos($key, 'image') !== false);
 			$signupItem->required = ($all_args->{$key} == 'required') || $signupItem->mustRequired || $signupItem->isIdentifier;
 			$signupItem->isUse = in_array($key, $usable_list) || $signupItem->required;
-			$signupItem->isPublic = ($all_args->{'is_'.$key.'_public'} == 'Y' && $signupItem->isUse) ? 'Y' : 'N';
-			if($signupItem->imageType)
+			$signupItem->isPublic = ($all_args->{'is_' . $key . '_public'} == 'Y' && $signupItem->isUse) ? 'Y' : 'N';
+			if ($signupItem->imageType)
 			{
-				$signupItem->max_width = $all_args->{$key.'_max_width'};
-				$signupItem->max_height = $all_args->{$key.'_max_height'};
+				$signupItem->max_width = $all_args->{$key . '_max_width'};
+				$signupItem->max_height = $all_args->{$key . '_max_height'};
 			}
 
 			// set extends form
-			if(!$signupItem->isDefaultForm)
+			if (!$signupItem->isDefaultForm)
 			{
-				$extendItem = $extendItems[$all_args->{$key.'_member_join_form_srl'}];
+				$extendItem = $extendItems[$all_args->{$key . '_member_join_form_srl'}];
 				$signupItem->type = $extendItem->column_type;
 				$signupItem->member_join_form_srl = $extendItem->member_join_form_srl;
 				$signupItem->title = $extendItem->column_title;
 				$signupItem->description = $extendItem->description;
 
 				// check usable value change, required/option
-				if($signupItem->isUse != ($extendItem->is_active == 'Y') || $signupItem->required != ($extendItem->required == 'Y'))
+				if ($signupItem->isUse != ($extendItem->is_active == 'Y') || $signupItem->required != ($extendItem->required == 'Y'))
 				{
 					unset($update_args);
 					$update_args = new stdClass;
 					$update_args->member_join_form_srl = $extendItem->member_join_form_srl;
-					$update_args->is_active = $signupItem->isUse?'Y':'N';
-					$update_args->required = $signupItem->required?'Y':'N';
+					$update_args->is_active = $signupItem->isUse ? 'Y' : 'N';
+					$update_args->required = $signupItem->required ? 'Y' : 'N';
 
 					$update_output = executeQuery('member.updateJoinForm', $update_args);
 				}
@@ -309,9 +309,9 @@ 
 		$this->_createFindAccountByQuestion($args->identifier);
 
 		// check agreement value exist
-		if($args->agreement)
+		if ($args->agreement)
 		{
-			$agreement_file = _XE_PATH_.'files/member_extra_info/agreement_' . Context::get('lang_type') . '.txt';
+			$agreement_file = _XE_PATH_ . 'files/member_extra_info/agreement_' . Context::get('lang_type') . '.txt';
 			$output = FileHandler::writeFile($agreement_file, $args->agreement);
 
 			unset($args->agreement);
@@ -339,16 +339,16 @@ 
 			'after_logout_url'
 		);
 
-		if(!$args->change_password_date)
+		if (!$args->change_password_date)
 		{
 			$args->change_password_date = 0;
 		}
 
-		if(!trim(strip_tags($args->after_login_url)))
+		if (!trim(strip_tags($args->after_login_url)))
 		{
 			$args->after_login_url = NULL;
 		}
-		if(!trim(strip_tags($args->after_logout_url)))
+		if (!trim(strip_tags($args->after_logout_url)))
 		{
 			$args->after_logout_url = NULL;
 		}
@@ -375,17 +375,17 @@ 
 		);
 
 		$args->layout_srl = $args->layout_srl ? $args->layout_srl : NULL;
-		if(!$args->skin)
+		if (!$args->skin)
 		{
 			$args->skin = 'default';
 		}
-		if(!$args->colorset)
+		if (!$args->colorset)
 		{
 			$args->colorset = 'white';
 		}
 
 		$args->mlayout_srl = $args->mlayout_srl ? $args->mlayout_srl : NULL;
-		if(!$args->mskin)
+		if (!$args->mskin)
 		{
 			$args->mskin = 'default';
 		}
@@ -408,12 +408,12 @@ 
 		$extendItems = $oMemberModel->getJoinFormList();
 
 		$items = array('user_id', 'password', 'user_name', 'nick_name', 'email_address', 'find_account_question', 'homepage', 'blog', 'birthday', 'signature', 'profile_image', 'image_name', 'image_mark');
-		$mustRequireds = array('email_address', 'nick_name','password', 'find_account_question');
+		$mustRequireds = array('email_address', 'nick_name', 'password', 'find_account_question');
 		$orgRequireds = array('email_address', 'password', 'find_account_question', 'user_id', 'nick_name', 'user_name');
 		$orgUse = array('email_address', 'password', 'find_account_question', 'user_id', 'nick_name', 'user_name', 'homepage', 'blog', 'birthday');
 		$list_order = array();
 
-		foreach($items as $key)
+		foreach ($items as $key)
 		{
 			unset($signupItem);
 			$signupItem = new stdClass;
@@ -425,23 +425,23 @@ 
 			$signupItem->required = in_array($key, $orgRequireds);
 			$signupItem->isUse = ($config->{$key} == 'Y') || in_array($key, $orgUse);
 			$signupItem->isPublic = ($signupItem->isUse) ? 'Y' : 'N';
-			if($key == 'find_account_question' || $key == 'password')
+			if ($key == 'find_account_question' || $key == 'password')
 			{
 				$signupItem->isPublic = 'N';
 			}
 			$signupItem->isIdentifier = ($key == $identifier);
-			if ($signupItem->imageType){
-				$signupItem->max_width = $config->{$key.'_max_width'};
-				$signupItem->max_height = $config->{$key.'_max_height'};
+			if ($signupItem->imageType) {
+				$signupItem->max_width = $config->{$key . '_max_width'};
+				$signupItem->max_height = $config->{$key . '_max_height'};
 			}
-			if($signupItem->isIdentifier)
+			if ($signupItem->isIdentifier)
 				array_unshift($list_order, $signupItem);
 			else
 				$list_order[] = $signupItem;
 		}
-		if(is_array($extendItems))
+		if (is_array($extendItems))
 		{
-			foreach($extendItems as $form_srl=>$item_info)
+			foreach ($extendItems as $form_srl=>$item_info)
 			{
 				unset($signupItem);
 				$signupItem = new stdClass;
@@ -454,10 +454,10 @@ 
 				$signupItem->isUse = ($item_info->is_active == 'Y');
 				$signupItem->isPublic = ($signupItem->isUse) ? 'Y' : 'N';
 				$signupItem->description = $item_info->description;
-				if($signupItem->imageType)
+				if ($signupItem->imageType)
 				{
-					$signupItem->max_width = $config->{$key.'_max_width'};
-					$signupItem->max_height = $config->{$key.'_max_height'};
+					$signupItem->max_width = $config->{$key . '_max_width'};
+					$signupItem->max_height = $config->{$key . '_max_height'};
 				}
 				$list_order[] = $signupItem;
 			}
@@ -472,13 +472,13 @@ 
 	 * @param string $agreement
 	 * @return void
 	 */
-	function _createSignupRuleset($signupForm, $agreement = null){
+	function _createSignupRuleset($signupForm, $agreement = null) {
 		$xml_file = './files/ruleset/insertMember.xml';
-		$buff = '<?xml version="1.0" encoding="utf-8"?>' . PHP_EOL.
-			'<ruleset version="1.5.0">' . PHP_EOL.
-			'<customrules>' . PHP_EOL.
-			'</customrules>' . PHP_EOL.
-			'<fields>' . PHP_EOL . '%s' . PHP_EOL . '</fields>' . PHP_EOL.
+		$buff = '<?xml version="1.0" encoding="utf-8"?>' . PHP_EOL .
+			'<ruleset version="1.5.0">' . PHP_EOL .
+			'<customrules>' . PHP_EOL .
+			'</customrules>' . PHP_EOL .
+			'<fields>' . PHP_EOL . '%s' . PHP_EOL . '</fields>' . PHP_EOL .
 			'</ruleset>';
 
 		$fields = array();
@@ -487,41 +487,41 @@ 
 		{
 			$fields[] = '<field name="accept_agreement"><if test="$act == \'procMemberInsert\'" attr="required" value="true" /></field>';
 		}
-		foreach($signupForm as $formInfo)
+		foreach ($signupForm as $formInfo)
 		{
-			if($formInfo->required || $formInfo->mustRequired)
+			if ($formInfo->required || $formInfo->mustRequired)
 			{
-				if($formInfo->type == 'tel' || $formInfo->type == 'kr_zip')
+				if ($formInfo->type == 'tel' || $formInfo->type == 'kr_zip')
 				{
 					$fields[] = sprintf('<field name="%s[]" required="true" />', $formInfo->name);
 				}
-				else if($formInfo->name == 'password')
+				else if ($formInfo->name == 'password')
 				{
 					$fields[] = '<field name="password"><if test="$act == \'procMemberInsert\'" attr="required" value="true" /><if test="$act == \'procMemberInsert\'" attr="length" value="4:20" /></field>';
 					$fields[] = '<field name="password2"><if test="$act == \'procMemberInsert\'" attr="required" value="true" /><if test="$act == \'procMemberInsert\'" attr="equalto" value="password" /></field>';
 				}
-				else if($formInfo->name == 'find_account_question')
+				else if ($formInfo->name == 'find_account_question')
 				{
 					$fields[] = '<field name="find_account_question" required="true" />';
 					$fields[] = '<field name="find_account_answer" required="true" length=":250" />';
 				}
-				else if($formInfo->name == 'email_address')
+				else if ($formInfo->name == 'email_address')
 				{
 					$fields[] = sprintf('<field name="%s" required="true" rule="email"/>', $formInfo->name);
 				}
-				else if($formInfo->name == 'user_id')
+				else if ($formInfo->name == 'user_id')
 				{
 					$fields[] = sprintf('<field name="%s" required="true" rule="userid" length="3:20" />', $formInfo->name);
 				}
-				else if($formInfo->name == 'nick_name')
+				else if ($formInfo->name == 'nick_name')
 				{
 					$fields[] = sprintf('<field name="%s" required="true" length="2:20" />', $formInfo->name);
 				}
-				else if(strpos($formInfo->name, 'image') !== false)
+				else if (strpos($formInfo->name, 'image') !== false)
 				{
 					$fields[] = sprintf('<field name="%s"><if test="$act != \'procMemberAdminInsert\' &amp;&amp; $__%s_exist != \'true\'" attr="required" value="true" /></field>', $formInfo->name, $formInfo->name);
 				}
-				else if($formInfo->name == 'signature')
+				else if ($formInfo->name == 'signature')
 				{
 					$fields[] = '<field name="signature"><if test="$member_srl" attr="required" value="true" /></field>';
 				}
@@ -536,7 +536,7 @@ 
 		FileHandler::writeFile($xml_file, $xml_buff);
 		unset($xml_buff);
 
-		$validator   = new Validator($xml_file);
+		$validator = new Validator($xml_file);
 		$validator->setCacheDir('files/cache');
 		$validator->getJsPath();
 	}
@@ -549,11 +549,11 @@ 
 	function _createLoginRuleset($identifier)
 	{
 		$xml_file = './files/ruleset/login.xml';
-		$buff = '<?xml version="1.0" encoding="utf-8"?>'.
-			'<ruleset version="1.5.0">'.
-			'<customrules>'.
-			'</customrules>'.
-			'<fields>%s</fields>'.
+		$buff = '<?xml version="1.0" encoding="utf-8"?>' .
+			'<ruleset version="1.5.0">' .
+			'<customrules>' .
+			'</customrules>' .
+			'<fields>%s</fields>' .
 			'</ruleset>';
 
 		$fields = array();
@@ -564,7 +564,7 @@ 
 		$xml_buff = sprintf($buff, implode('', $fields));
 		Filehandler::writeFile($xml_file, $xml_buff);
 
-		$validator   = new Validator($xml_file);
+		$validator = new Validator($xml_file);
 		$validator->setCacheDir('files/cache');
 		$validator->getJsPath();
 	}
@@ -577,15 +577,15 @@ 
 	function _createFindAccountByQuestion($identifier)
 	{
 		$xml_file = './files/ruleset/find_member_account_by_question.xml';
-		$buff = '<?xml version="1.0" encoding="utf-8"?>'.
-			'<ruleset version="1.5.0">'.
-			'<customrules>'.
-			'</customrules>'.
-			'<fields>%s</fields>'.
+		$buff = '<?xml version="1.0" encoding="utf-8"?>' .
+			'<ruleset version="1.5.0">' .
+			'<customrules>' .
+			'</customrules>' .
+			'<fields>%s</fields>' .
 			'</ruleset>';
 
 		$fields = array();
-		if($identifier == 'user_id')
+		if ($identifier == 'user_id')
 			$fields[] = '<field name="user_id" required="true" rule="userid" />';
 
 		$fields[] = '<field name="email_address" required="true" rule="email" />';
@@ -595,7 +595,7 @@ 
 		$xml_buff = sprintf($buff, implode('', $fields));
 		Filehandler::writeFile($xml_file, $xml_buff);
 
-		$validator   = new Validator($xml_file);
+		$validator = new Validator($xml_file);
 		$validator->setCacheDir('files/cache');
 		$validator->getJsPath();
 	}
@@ -606,12 +606,12 @@ 
 	 */
 	function procMemberAdminInsertGroup()
 	{
-		$args = Context::gets('title','description','is_default','image_mark');
+		$args = Context::gets('title', 'description', 'is_default', 'image_mark');
 		$output = $this->insertGroup($args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
-		$this->add('group_srl','');
-		$this->add('page',Context::get('page'));
+		$this->add('group_srl', '');
+		$this->add('page', Context::get('page'));
 		$this->setMessage('success_registed');
 
 		$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'module', 'admin', 'act', 'dispMemberAdminGroupList');
@@ -626,13 +626,13 @@ 
 	{
 		$group_srl = Context::get('group_srl');
 
-		$args = Context::gets('group_srl','title','description','is_default','image_mark');
+		$args = Context::gets('group_srl', 'title', 'description', 'is_default', 'image_mark');
 		$args->site_srl = 0;
 		$output = $this->updateGroup($args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
-		$this->add('group_srl','');
-		$this->add('page',Context::get('page'));
+		$this->add('group_srl', '');
+		$this->add('page', Context::get('page'));
 		$this->setMessage('success_updated');
 
 		$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'module', 'admin', 'act', 'dispMemberAdminGroupList');
@@ -648,10 +648,10 @@ 
 		$group_srl = Context::get('group_srl');
 
 		$output = $this->deleteGroup($group_srl);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
-		$this->add('group_srl','');
-		$this->add('page',Context::get('page'));
+		$this->add('group_srl', '');
+		$this->add('page', Context::get('page'));
 		$this->setMessage('success_deleted');
 
 		$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'module', 'admin', 'act', 'dispMemberAdminGroupList');
@@ -673,10 +673,10 @@ 
 		$args->default_value = explode("\n", str_replace("\r", '', Context::get('default_value')));
 		$args->required = Context::get('required');
 		$args->is_active = (isset($args->required));
-		if(!in_array(strtoupper($args->required), array('Y','N')))$args->required = 'N';
+		if (!in_array(strtoupper($args->required), array('Y', 'N')))$args->required = 'N';
 		$args->description = Context::get('description') ? Context::get('description') : '';
 		// Default values
-		if(in_array($args->column_type, array('checkbox','select','radio')) && count($args->default_value))
+		if (in_array($args->column_type, array('checkbox', 'select', 'radio')) && count($args->default_value))
 		{
 			$args->default_value = serialize($args->default_value);
 		}
@@ -688,17 +688,17 @@ 
 		// Check ID duplicated
 		$oMemberModel = getModel('member');
 		$config = $oMemberModel->getMemberConfig();
-		foreach($config->signupForm as $item)
+		foreach ($config->signupForm as $item)
 		{
-			if($item->name == $args->column_name)
+			if ($item->name == $args->column_name)
 			{
-				if($args->member_join_form_srl && $args->member_join_form_srl == $item->member_join_form_srl) continue;
-				return new Object(-1,'msg_exists_user_id');
+				if ($args->member_join_form_srl && $args->member_join_form_srl == $item->member_join_form_srl) continue;
+				return new Object(-1, 'msg_exists_user_id');
 			}
 		}
 		// Fix if member_join_form_srl exists. Add if not exists.
 		$isInsert;
-		if(!$args->member_join_form_srl)
+		if (!$args->member_join_form_srl)
 		{
 			$isInsert = true;
 			$args->list_order = $args->member_join_form_srl = getNextSequence();
@@ -709,7 +709,7 @@ 
 			$output = executeQuery('member.updateJoinForm', $args);
 		}
 
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
 		// memberConfig update
 		$signupItem = new stdClass();
@@ -726,15 +726,15 @@ 
 		$config = $oMemberModel->getMemberConfig();
 		unset($config->agreement);
 
-		if($isInsert)
+		if ($isInsert)
 		{
 			$config->signupForm[] = $signupItem;
 		}
 		else
 		{
-			foreach($config->signupForm as $key=>$val)
+			foreach ($config->signupForm as $key=>$val)
 			{
-				if($val->member_join_form_srl == $signupItem->member_join_form_srl)
+				if ($val->member_join_form_srl == $signupItem->member_join_form_srl)
 				{
 					$config->signupForm[$key] = $signupItem;
 				}
@@ -762,9 +762,9 @@ 
 		$config = $oMemberModel->getMemberConfig();
 		unset($config->agreement);
 
-		foreach($config->signupForm as $key=>$val)
+		foreach ($config->signupForm as $key=>$val)
 		{
-			if($val->member_join_form_srl == $member_join_form_srl)
+			if ($val->member_join_form_srl == $member_join_form_srl)
 			{
 				unset($config->signupForm[$key]);
 				break;
@@ -784,7 +784,7 @@ 
 		$member_join_form_srl = Context::get('member_join_form_srl');
 		$mode = Context::get('mode');
 
-		switch($mode)
+		switch ($mode)
 		{
 			case 'up' :
 				$output = $this->moveJoinFormUp($member_join_form_srl);
@@ -801,7 +801,7 @@ 
 			case 'update' :
 				break;
 		}
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
 		$this->setMessage($msg_code);
 	}
@@ -820,40 +820,40 @@ 
 		$oDB->begin();
 
 		$oMemberController = getController('member');
-		foreach($members as $key=>$member_srl)
+		foreach ($members as $key=>$member_srl)
 		{
 			$args = new stdClass();
 			$args->member_srl = $member_srl;
-			switch($var->type)
+			switch ($var->type)
 			{
 				case 'modify':
 					{
-						if(count($groups) > 0)
+						if (count($groups) > 0)
 						{
 							$args->site_srl = 0;
 							// One of its members to delete all the group
 							$output = executeQuery('member.deleteMemberGroupMember', $args);
-							if(!$output->toBool())
+							if (!$output->toBool())
 							{
 								$oDB->rollback();
 								return $output;
 							}
 							// Enter one of the loop a
-							foreach($groups as $group_srl)
+							foreach ($groups as $group_srl)
 							{
-								$output = $oMemberController->addMemberToGroup($args->member_srl,$group_srl);
-								if(!$output->toBool())
+								$output = $oMemberController->addMemberToGroup($args->member_srl, $group_srl);
+								if (!$output->toBool())
 								{
 									$oDB->rollback();
 									return $output;
 								}
 							}
 						}
-						if($var->denied)
+						if ($var->denied)
 						{
 							$args->denied = $var->denied;
 							$output = executeQuery('member.updateMemberDeniedInfo', $args);
-							if(!$output->toBool())
+							if (!$output->toBool())
 							{
 								$oDB->rollback();
 								return $output;
@@ -866,7 +866,7 @@ 
 					{
 						$oMemberController->memberInfo = null;
 						$output = $oMemberController->deleteMember($member_srl);
-						if(!$output->toBool())
+						if (!$output->toBool())
 						{
 							$oDB->rollback();
 							return $output;
@@ -879,15 +879,15 @@ 
 
 		$message = $var->message;
 		// Send a message
-		if($message)
+		if ($message)
 		{
 			$oCommunicationController = getController('communication');
 
 			$logged_info = Context::get('logged_info');
-			$title = cut_str($message,10,'...');
+			$title = cut_str($message, 10, '...');
 			$sender_member_srl = $logged_info->member_srl;
 
-			foreach($members as $member_srl)
+			foreach ($members as $member_srl)
 			{
 				$oCommunicationController->sendMessage($sender_member_srl, $member_srl, $title, $message, false);
 			}
@@ -904,14 +904,14 @@ 
 	function procMemberAdminDeleteMembers()
 	{
 		$target_member_srls = Context::get('target_member_srls');
-		if(!$target_member_srls) return new Object(-1, 'msg_invalid_request');
+		if (!$target_member_srls) return new Object(-1, 'msg_invalid_request');
 		$member_srls = explode(',', $target_member_srls);
 		$oMemberController = getController('member');
 
-		foreach($member_srls as $member)
+		foreach ($member_srls as $member)
 		{
 			$output = $oMemberController->deleteMember($member);
-			if(!$output->toBool())
+			if (!$output->toBool())
 			{
 				$this->setMessage('failed_deleted');
 				return $output;
@@ -928,11 +928,11 @@ 
 	function procMemberAdminUpdateMembersGroup()
 	{
 		$member_srl = Context::get('member_srl');
-		if(!$member_srl) return new Object(-1,'msg_invalid_request');
-		$member_srls = explode(',',$member_srl);
+		if (!$member_srl) return new Object(-1, 'msg_invalid_request');
+		$member_srls = explode(',', $member_srl);
 
 		$group_srl = Context::get('group_srls');
-		if(!is_array($group_srl)) $group_srls = explode('|@|', $group_srl);
+		if (!is_array($group_srl)) $group_srls = explode('|@|', $group_srl);
 		else $group_srls = $group_srl;
 
 		$oDB = &DB::getInstance();
@@ -941,7 +941,7 @@ 
 		$args = new stdClass;
 		$args->member_srl = $member_srl;
 		$output = executeQuery('member.deleteMembersGroup', $args);
-		if(!$output->toBool())
+		if (!$output->toBool())
 		{
 			$oDB->rollback();
 			return $output;
@@ -949,21 +949,21 @@ 
 		// Add to a selected group
 		$group_count = count($group_srls);
 		$member_count = count($member_srls);
-		for($j=0;$j<$group_count;$j++)
+		for ($j = 0; $j < $group_count; $j++)
 		{
-			$group_srl = (int)trim($group_srls[$j]);
-			if(!$group_srl) continue;
-			for($i=0;$i<$member_count;$i++)
+			$group_srl = (int) trim($group_srls[$j]);
+			if (!$group_srl) continue;
+			for ($i = 0; $i < $member_count; $i++)
 			{
-				$member_srl = (int)trim($member_srls[$i]);
-				if(!$member_srl) continue;
+				$member_srl = (int) trim($member_srls[$i]);
+				if (!$member_srl) continue;
 
 				$args = new stdClass;
 				$args->member_srl = $member_srl;
 				$args->group_srl = $group_srl;
 
 				$output = executeQuery('member.addMemberToGroup', $args);
-				if(!$output->toBool())
+				if (!$output->toBool())
 				{
 					$oDB->rollback();
 					return $output;
@@ -976,7 +976,7 @@ 
 
 		$this->setMessage('success_updated');
 
-		if(!in_array(Context::getRequestMethod(),array('XMLRPC','JSON')))
+		if (!in_array(Context::getRequestMethod(), array('XMLRPC', 'JSON')))
 		{
 			global $lang;
 			htmlHeader();
@@ -997,19 +997,19 @@ 
 	{
 		$user_ids = Context::get('user_id');
 
-		$user_ids = explode(',',$user_ids);
+		$user_ids = explode(',', $user_ids);
 		$success_ids = array();
 
-		foreach($user_ids as $val)
+		foreach ($user_ids as $val)
 		{
 			$val = trim($val);
-			if(!$val) continue;
+			if (!$val) continue;
 
 			$output = $this->insertDeniedID($val, '');
-			if($output->toBool()) $success_ids[] = $val;
+			if ($output->toBool()) $success_ids[] = $val;
 		}
 
-		$this->add('user_ids', implode(',',$success_ids));
+		$this->add('user_ids', implode(',', $success_ids));
 
 		$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'module', 'admin', 'act', 'dispMemberAdminDeniedIDList');
 		$this->setRedirectUrl($returnUrl);
@@ -1026,10 +1026,10 @@ 
 		$mode = Context::get('mode');
 		$mode = $mode ? $mode : 'insert';
 
-		if($mode == 'delete')
+		if ($mode == 'delete')
 		{
 			$output = $this->deleteDeniedNickName($nick_name);
-			if(!$output->toBool())
+			if (!$output->toBool())
 			{
 				return $output;
 			}
@@ -1038,19 +1038,19 @@ 
 		}
 		else
 		{
-			$nick_names = explode(',',$nick_name);
+			$nick_names = explode(',', $nick_name);
 			$success_nick_names = array();
 
-			foreach($nick_names as $val)
+			foreach ($nick_names as $val)
 			{
 				$val = trim($val);
-				if(!$val) continue;
+				if (!$val) continue;
 
 				$output = $this->insertDeniedNickName($val, '');
-				if($output->toBool()) $success_nick_names[] = $val;
+				if ($output->toBool()) $success_nick_names[] = $val;
 			}
 
-			$this->add('nick_names', implode(',',$success_nick_names));
+			$this->add('nick_names', implode(',', $success_nick_names));
 		}
 	}
 
@@ -1063,16 +1063,16 @@ 
 		$user_id = Context::get('user_id');
 		$mode = Context::get('mode');
 
-		switch($mode)
+		switch ($mode)
 		{
 			case 'delete' :
 				$output = $this->deleteDeniedID($user_id);
-				if(!$output->toBool()) return $output;
+				if (!$output->toBool()) return $output;
 				$msg_code = 'success_deleted';
 				break;
 		}
 
-		$this->add('page',Context::get('page'));
+		$this->add('page', Context::get('page'));
 		$this->setMessage($msg_code);
 	}
 
@@ -1119,24 +1119,24 @@ 
 	 */
 	function insertGroup($args)
 	{
-		if(!$args->site_srl) $args->site_srl = 0;
+		if (!$args->site_srl) $args->site_srl = 0;
 		// Check the value of is_default.
-		if($args->is_default != 'Y')
+		if ($args->is_default != 'Y')
 		{
 			$args->is_default = 'N';
 		}
 		else
 		{
 			$output = executeQuery('member.updateGroupDefaultClear', $args);
-			if(!$output->toBool()) return $output;
+			if (!$output->toBool()) return $output;
 		}
 
-		if(!isset($args->list_order) || $args->list_order=='')
+		if (!isset($args->list_order) || $args->list_order == '')
 		{
 			$args->list_order = $args->group_srl;
 		}
 
-		if(!$args->group_srl) $args->group_srl = getNextSequence();
+		if (!$args->group_srl) $args->group_srl = getNextSequence();
 		$args->list_order = $args->group_srl;
 		$output = executeQuery('member.insertGroup', $args);
 		$this->_deleteMemberGroupCache($args->site_srl);
@@ -1151,17 +1151,17 @@ 
 	 */
 	function updateGroup($args)
 	{
-		if(!$args->site_srl) $args->site_srl = 0;
+		if (!$args->site_srl) $args->site_srl = 0;
 		// Check the value of is_default.
-		if(!$args->group_srl) return new Object(-1, 'lang->msg_not_founded');
-		if($args->is_default!='Y')
+		if (!$args->group_srl) return new Object(-1, 'lang->msg_not_founded');
+		if ($args->is_default != 'Y')
 		{
 			$args->is_default = 'N';
 		}
 		else
 		{
 			$output = executeQuery('member.updateGroupDefaultClear', $args);
-			if(!$output->toBool()) return $output;
+			if (!$output->toBool()) return $output;
 		}
 
 		$output = executeQuery('member.updateGroup', $args);
@@ -1184,8 +1184,8 @@ 
 		$columnList = array('group_srl', 'is_default');
 		$group_info = $oMemberModel->getGroup($group_srl, $columnList);
 
-		if(!$group_info) return new Object(-1, 'lang->msg_not_founded');
-		if($group_info->is_default == 'Y') return new Object(-1, 'msg_not_delete_default');
+		if (!$group_info) return new Object(-1, 'lang->msg_not_founded');
+		if ($group_info->is_default == 'Y') return new Object(-1, 'msg_not_delete_default');
 
 		// Get groups where is_default == 'Y'
 		$columnList = array('site_srl', 'group_srl');
@@ -1222,7 +1222,7 @@ 
 		$defaultGroup = $oMemberModel->getDefaultGroup(0);
 		$defaultGroupSrl = $defaultGroup->group_srl;
 		$group_srls = $vars->group_srls;
-		foreach($group_srls as $order=>$group_srl)
+		foreach ($group_srls as $order=>$group_srl)
 		{
 			$isInsert = false;
 			$update_args = new stdClass();
@@ -1231,9 +1231,9 @@ 
 			$update_args->image_mark = $vars->image_marks[$order];
 			$update_args->list_order = $order + 1;
 
-			if(!$update_args->title) continue;
+			if (!$update_args->title) continue;
 
-			if(is_numeric($group_srl)) {
+			if (is_numeric($group_srl)) {
 				$update_args->group_srl = $group_srl;
 				$output = $this->updateGroup($update_args);
 			}
@@ -1242,7 +1242,7 @@ 
 				$output = $this->insertGroup($update_args);
 			}
 
-			if($vars->defaultGroup == $group_srl) {
+			if ($vars->defaultGroup == $group_srl) {
 				$defaultGroupSrl = $update_args->group_srl;
 			}
 		}
@@ -1253,7 +1253,7 @@ 
 		$default_args->group_srl = $defaultGroupSrl;
 		$output = $this->updateGroup($default_args);
 
-		$this->setMessage(Context::getLang('success_updated').' ('.Context::getLang('msg_insert_group_name_detail').')');
+		$this->setMessage(Context::getLang('success_updated') . ' (' . Context::getLang('msg_insert_group_name_detail') . ')');
 
 		$returnUrl = Context::get('success_return_url') ? Context::get('success_return_url') : getNotEncodedUrl('', 'module', 'admin', 'act', 'dispMemberAdminGroupList');
 		$this->setRedirectUrl($returnUrl);
@@ -1268,7 +1268,7 @@ 
 	{
 		$vars = Context::getRequestVars();
 
-		foreach($vars->group_srls as $key => $val)
+		foreach ($vars->group_srls as $key => $val)
 		{
 			$args = new stdClass;
 			$args->group_srl = $val;
@@ -1289,7 +1289,7 @@ 
 	{
 		//remove from cache
 		$oCacheHandler = CacheHandler::getInstance('object', null, true);
-		if($oCacheHandler->isSupport())
+		if ($oCacheHandler->isSupport())
 		{
 			$oCacheHandler->invalidateGroupKey('member');
 		}
@@ -1306,7 +1306,7 @@ 
 		$args = new stdClass();
 		$args->user_id = $user_id;
 		$args->description = $description;
-		$args->list_order = -1*getNextSequence();
+		$args->list_order = -1 * getNextSequence();
 
 		return executeQuery('member.insertDeniedID', $args);
 	}
@@ -1327,7 +1327,7 @@ 
 	 */
 	function deleteDeniedID($user_id)
 	{
-		if(!$user_id) unset($user_id);
+		if (!$user_id) unset($user_id);
 
 		$args = new stdClass;
 		$args->user_id = $user_id;
@@ -1341,7 +1341,7 @@ 
 	 */
 	function deleteDeniedNickName($nick_name)
 	{
-		if(!$nick_name) unset($nick_name);
+		if (!$nick_name) unset($nick_name);
 
 		$args = new stdClass;
 		$args->nick_name = $nick_name;
@@ -1380,16 +1380,16 @@ 
 		// Get a list of all join forms
 		$join_form_list = $oMemberModel->getJoinFormList();
 		$join_form_srl_list = array_keys($join_form_list);
-		if(count($join_form_srl_list)<2) return new Object();
+		if (count($join_form_srl_list) < 2) return new Object();
 
 		$prev_member_join_form = NULL;
-		foreach($join_form_list as $key => $val)
+		foreach ($join_form_list as $key => $val)
 		{
-			if($val->member_join_form_srl == $member_join_form_srl) break;
+			if ($val->member_join_form_srl == $member_join_form_srl) break;
 			$prev_member_join_form = $val;
 		}
 		// Return if no previous join form exists
-		if(!$prev_member_join_form) return new Object();
+		if (!$prev_member_join_form) return new Object();
 		// Information of the join form
 		$cur_args = new stdClass;
 		$cur_args->member_join_form_srl = $member_join_form_srl;
@@ -1400,10 +1400,10 @@ 
 		$prev_args->list_order = $list_order;
 		// Execute Query
 		$output = executeQuery('member.updateMemberJoinFormListorder', $cur_args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
 		executeQuery('member.updateMemberJoinFormListorder', $prev_args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
 		return new Object();
 	}
@@ -1427,16 +1427,16 @@ 
 		// Get information of all join forms
 		$join_form_list = $oMemberModel->getJoinFormList();
 		$join_form_srl_list = array_keys($join_form_list);
-		if(count($join_form_srl_list)<2) return new Object();
+		if (count($join_form_srl_list) < 2) return new Object();
 
-		for($i=0;$i<count($join_form_srl_list);$i++)
+		for ($i = 0; $i < count($join_form_srl_list); $i++)
 		{
-			if($join_form_srl_list[$i]==$member_join_form_srl) break;
+			if ($join_form_srl_list[$i] == $member_join_form_srl) break;
 		}
 
-		$next_member_join_form_srl = $join_form_srl_list[$i+1];
+		$next_member_join_form_srl = $join_form_srl_list[$i + 1];
 		// Return if no previous join form exists
-		if(!$next_member_join_form_srl) return new Object();
+		if (!$next_member_join_form_srl) return new Object();
 		$next_member_join_form = $join_form_list[$next_member_join_form_srl];
 		// Information of the join form
 		$cur_args = new stdClass;
@@ -1448,10 +1448,10 @@ 
 		$next_args->list_order = $list_order;
 		// Execute Query
 		$output = executeQuery('member.updateMemberJoinFormListorder', $cur_args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
 		$output = executeQuery('member.updateMemberJoinFormListorder', $next_args);
-		if(!$output->toBool()) return $output;
+		if (!$output->toBool()) return $output;
 
 		return new Object();
 	}

Braces +162 added lines, -86 removed lines

@@ -48,9 +48,11 @@ 
 			$args->{$val} = Context::get($val);
 		}
 		$args->member_srl = Context::get('member_srl');
-		if(Context::get('reset_password'))
-			$args->password = Context::get('reset_password');
-		else unset($args->password);
+		if(Context::get('reset_password')) {
+					$args->password = Context::get('reset_password');
+		} else {
+			unset($args->password);
+		}
 
 		// Remove some unnecessary variables from all the vars
 		$all_args = Context::getRequestVars();
@@ -60,7 +62,9 @@ 
 		unset($all_args->error_return_url);
 		unset($all_args->success_return_url);
 		unset($all_args->ruleset);
-		if(!isset($args->limit_date)) $args->limit_date = "";
+		if(!isset($args->limit_date)) {
+			$args->limit_date = "";
+		}
 		unset($all_args->password);
 		unset($all_args->password2);
 		unset($all_args->reset_password);
@@ -76,7 +80,9 @@ 
 			$columnList = array('member_srl');
 			$member_info = $oMemberModel->getMemberInfoByMemberSrl($args->member_srl, 0, $columnList);
 			// If no original member exists, make a new one
-			if($member_info->member_srl != $args->member_srl) unset($args->member_srl);
+			if($member_info->member_srl != $args->member_srl) {
+				unset($args->member_srl);
+			}
 		}
 
 		// remove whitespace
@@ -96,14 +102,15 @@ 
 			$args->password = Context::get('password');
 			$output = $oMemberController->insertMember($args);
 			$msg_code = 'success_registed';
-		}
-		else
+		} else
 		{
 			$output = $oMemberController->updateMember($args);
 			$msg_code = 'success_updated';
 		}
 
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 		// Save Signature
 		$signature = Context::get('signature');
 		$oMemberController->putSignature($args->member_srl, $signature);
@@ -144,7 +151,9 @@ 
 
 		$oMemberController = getController('member');
 		$output = $oMemberController->deleteMember($member_srl);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		$this->add('page',Context::get('page'));
 		$this->setMessage("success_deleted");
@@ -263,8 +272,11 @@ 
 			$signupItem->isDefaultForm = in_array($key, $items);
 
 			$signupItem->name = $key;
-			if(!in_array($key, $items)) $signupItem->title = $key;
-			else $signupItem->title = $lang->{$key};
+			if(!in_array($key, $items)) {
+				$signupItem->title = $key;
+			} else {
+				$signupItem->title = $lang->{$key};
+			}
 			$signupItem->mustRequired = in_array($key, $mustRequireds);
 			$signupItem->imageType = (strpos($key, 'image') !== false);
 			$signupItem->required = ($all_args->{$key} == 'required') || $signupItem->mustRequired || $signupItem->isIdentifier;
@@ -434,10 +446,11 @@ 
 				$signupItem->max_width = $config->{$key.'_max_width'};
 				$signupItem->max_height = $config->{$key.'_max_height'};
 			}
-			if($signupItem->isIdentifier)
-				array_unshift($list_order, $signupItem);
-			else
-				$list_order[] = $signupItem;
+			if($signupItem->isIdentifier) {
+							array_unshift($list_order, $signupItem);
+			} else {
+							$list_order[] = $signupItem;
+			}
 		}
 		if(is_array($extendItems))
 		{
@@ -494,38 +507,30 @@ 
 				if($formInfo->type == 'tel' || $formInfo->type == 'kr_zip')
 				{
 					$fields[] = sprintf('<field name="%s[]" required="true" />', $formInfo->name);
-				}
-				else if($formInfo->name == 'password')
+				} else if($formInfo->name == 'password')
 				{
 					$fields[] = '<field name="password"><if test="$act == \'procMemberInsert\'" attr="required" value="true" /><if test="$act == \'procMemberInsert\'" attr="length" value="4:20" /></field>';
 					$fields[] = '<field name="password2"><if test="$act == \'procMemberInsert\'" attr="required" value="true" /><if test="$act == \'procMemberInsert\'" attr="equalto" value="password" /></field>';
-				}
-				else if($formInfo->name == 'find_account_question')
+				} else if($formInfo->name == 'find_account_question')
 				{
 					$fields[] = '<field name="find_account_question" required="true" />';
 					$fields[] = '<field name="find_account_answer" required="true" length=":250" />';
-				}
-				else if($formInfo->name == 'email_address')
+				} else if($formInfo->name == 'email_address')
 				{
 					$fields[] = sprintf('<field name="%s" required="true" rule="email"/>', $formInfo->name);
-				}
-				else if($formInfo->name == 'user_id')
+				} else if($formInfo->name == 'user_id')
 				{
 					$fields[] = sprintf('<field name="%s" required="true" rule="userid" length="3:20" />', $formInfo->name);
-				}
-				else if($formInfo->name == 'nick_name')
+				} else if($formInfo->name == 'nick_name')
 				{
 					$fields[] = sprintf('<field name="%s" required="true" length="2:20" />', $formInfo->name);
-				}
-				else if(strpos($formInfo->name, 'image') !== false)
+				} else if(strpos($formInfo->name, 'image') !== false)
 				{
 					$fields[] = sprintf('<field name="%s"><if test="$act != \'procMemberAdminInsert\' &amp;&amp; $__%s_exist != \'true\'" attr="required" value="true" /></field>', $formInfo->name, $formInfo->name);
-				}
-				else if($formInfo->name == 'signature')
+				} else if($formInfo->name == 'signature')
 				{
 					$fields[] = '<field name="signature"><if test="$member_srl" attr="required" value="true" /></field>';
-				}
-				else
+				} else
 				{
 					$fields[] = sprintf('<field name="%s" required="true" />', $formInfo->name);
 				}
@@ -585,8 +590,9 @@ 
 			'</ruleset>';
 
 		$fields = array();
-		if($identifier == 'user_id')
-			$fields[] = '<field name="user_id" required="true" rule="userid" />';
+		if($identifier == 'user_id') {
+					$fields[] = '<field name="user_id" required="true" rule="userid" />';
+		}
 
 		$fields[] = '<field name="email_address" required="true" rule="email" />';
 		$fields[] = '<field name="find_account_question" required="true" />';
@@ -608,7 +614,9 @@ 
 	{
 		$args = Context::gets('title','description','is_default','image_mark');
 		$output = $this->insertGroup($args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		$this->add('group_srl','');
 		$this->add('page',Context::get('page'));
@@ -629,7 +637,9 @@ 
 		$args = Context::gets('group_srl','title','description','is_default','image_mark');
 		$args->site_srl = 0;
 		$output = $this->updateGroup($args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		$this->add('group_srl','');
 		$this->add('page',Context::get('page'));
@@ -648,7 +658,9 @@ 
 		$group_srl = Context::get('group_srl');
 
 		$output = $this->deleteGroup($group_srl);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		$this->add('group_srl','');
 		$this->add('page',Context::get('page'));
@@ -673,14 +685,15 @@ 
 		$args->default_value = explode("\n", str_replace("\r", '', Context::get('default_value')));
 		$args->required = Context::get('required');
 		$args->is_active = (isset($args->required));
-		if(!in_array(strtoupper($args->required), array('Y','N')))$args->required = 'N';
+		if(!in_array(strtoupper($args->required), array('Y','N'))) {
+			$args->required = 'N';
+		}
 		$args->description = Context::get('description') ? Context::get('description') : '';
 		// Default values
 		if(in_array($args->column_type, array('checkbox','select','radio')) && count($args->default_value))
 		{
 			$args->default_value = serialize($args->default_value);
-		}
-		else
+		} else
 		{
 			$args->default_value = '';
 		}
@@ -692,7 +705,9 @@ 
 		{
 			if($item->name == $args->column_name)
 			{
-				if($args->member_join_form_srl && $args->member_join_form_srl == $item->member_join_form_srl) continue;
+				if($args->member_join_form_srl && $args->member_join_form_srl == $item->member_join_form_srl) {
+					continue;
+				}
 				return new Object(-1,'msg_exists_user_id');
 			}
 		}
@@ -703,13 +718,14 @@ 
 			$isInsert = true;
 			$args->list_order = $args->member_join_form_srl = getNextSequence();
 			$output = executeQuery('member.insertJoinForm', $args);
-		}
-		else
+		} else
 		{
 			$output = executeQuery('member.updateJoinForm', $args);
 		}
 
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		// memberConfig update
 		$signupItem = new stdClass();
@@ -729,8 +745,7 @@ 
 		if($isInsert)
 		{
 			$config->signupForm[] = $signupItem;
-		}
-		else
+		} else
 		{
 			foreach($config->signupForm as $key=>$val)
 			{
@@ -801,7 +816,9 @@ 
 			case 'update' :
 				break;
 		}
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		$this->setMessage($msg_code);
 	}
@@ -904,7 +921,9 @@ 
 	function procMemberAdminDeleteMembers()
 	{
 		$target_member_srls = Context::get('target_member_srls');
-		if(!$target_member_srls) return new Object(-1, 'msg_invalid_request');
+		if(!$target_member_srls) {
+			return new Object(-1, 'msg_invalid_request');
+		}
 		$member_srls = explode(',', $target_member_srls);
 		$oMemberController = getController('member');
 
@@ -928,12 +947,17 @@ 
 	function procMemberAdminUpdateMembersGroup()
 	{
 		$member_srl = Context::get('member_srl');
-		if(!$member_srl) return new Object(-1,'msg_invalid_request');
+		if(!$member_srl) {
+			return new Object(-1,'msg_invalid_request');
+		}
 		$member_srls = explode(',',$member_srl);
 
 		$group_srl = Context::get('group_srls');
-		if(!is_array($group_srl)) $group_srls = explode('|@|', $group_srl);
-		else $group_srls = $group_srl;
+		if(!is_array($group_srl)) {
+			$group_srls = explode('|@|', $group_srl);
+		} else {
+			$group_srls = $group_srl;
+		}
 
 		$oDB = &DB::getInstance();
 		$oDB->begin();
@@ -952,11 +976,15 @@ 
 		for($j=0;$j<$group_count;$j++)
 		{
 			$group_srl = (int)trim($group_srls[$j]);
-			if(!$group_srl) continue;
+			if(!$group_srl) {
+				continue;
+			}
 			for($i=0;$i<$member_count;$i++)
 			{
 				$member_srl = (int)trim($member_srls[$i]);
-				if(!$member_srl) continue;
+				if(!$member_srl) {
+					continue;
+				}
 
 				$args = new stdClass;
 				$args->member_srl = $member_srl;
@@ -1003,10 +1031,14 @@ 
 		foreach($user_ids as $val)
 		{
 			$val = trim($val);
-			if(!$val) continue;
+			if(!$val) {
+				continue;
+			}
 
 			$output = $this->insertDeniedID($val, '');
-			if($output->toBool()) $success_ids[] = $val;
+			if($output->toBool()) {
+				$success_ids[] = $val;
+			}
 		}
 
 		$this->add('user_ids', implode(',',$success_ids));
@@ -1035,8 +1067,7 @@ 
 			}
 			$msg_code = 'success_deleted';
 			$this->setMessage($msg_code);
-		}
-		else
+		} else
 		{
 			$nick_names = explode(',',$nick_name);
 			$success_nick_names = array();
@@ -1044,10 +1075,14 @@ 
 			foreach($nick_names as $val)
 			{
 				$val = trim($val);
-				if(!$val) continue;
+				if(!$val) {
+					continue;
+				}
 
 				$output = $this->insertDeniedNickName($val, '');
-				if($output->toBool()) $success_nick_names[] = $val;
+				if($output->toBool()) {
+					$success_nick_names[] = $val;
+				}
 			}
 
 			$this->add('nick_names', implode(',',$success_nick_names));
@@ -1067,7 +1102,9 @@ 
 		{
 			case 'delete' :
 				$output = $this->deleteDeniedID($user_id);
-				if(!$output->toBool()) return $output;
+				if(!$output->toBool()) {
+					return $output;
+				}
 				$msg_code = 'success_deleted';
 				break;
 		}
@@ -1119,16 +1156,19 @@ 
 	 */
 	function insertGroup($args)
 	{
-		if(!$args->site_srl) $args->site_srl = 0;
+		if(!$args->site_srl) {
+			$args->site_srl = 0;
+		}
 		// Check the value of is_default.
 		if($args->is_default != 'Y')
 		{
 			$args->is_default = 'N';
-		}
-		else
+		} else
 		{
 			$output = executeQuery('member.updateGroupDefaultClear', $args);
-			if(!$output->toBool()) return $output;
+			if(!$output->toBool()) {
+				return $output;
+			}
 		}
 
 		if(!isset($args->list_order) || $args->list_order=='')
@@ -1136,7 +1176,9 @@ 
 			$args->list_order = $args->group_srl;
 		}
 
-		if(!$args->group_srl) $args->group_srl = getNextSequence();
+		if(!$args->group_srl) {
+			$args->group_srl = getNextSequence();
+		}
 		$args->list_order = $args->group_srl;
 		$output = executeQuery('member.insertGroup', $args);
 		$this->_deleteMemberGroupCache($args->site_srl);
@@ -1151,17 +1193,22 @@ 
 	 */
 	function updateGroup($args)
 	{
-		if(!$args->site_srl) $args->site_srl = 0;
+		if(!$args->site_srl) {
+			$args->site_srl = 0;
+		}
 		// Check the value of is_default.
-		if(!$args->group_srl) return new Object(-1, 'lang->msg_not_founded');
+		if(!$args->group_srl) {
+			return new Object(-1, 'lang->msg_not_founded');
+		}
 		if($args->is_default!='Y')
 		{
 			$args->is_default = 'N';
-		}
-		else
+		} else
 		{
 			$output = executeQuery('member.updateGroupDefaultClear', $args);
-			if(!$output->toBool()) return $output;
+			if(!$output->toBool()) {
+				return $output;
+			}
 		}
 
 		$output = executeQuery('member.updateGroup', $args);
@@ -1184,8 +1231,12 @@ 
 		$columnList = array('group_srl', 'is_default');
 		$group_info = $oMemberModel->getGroup($group_srl, $columnList);
 
-		if(!$group_info) return new Object(-1, 'lang->msg_not_founded');
-		if($group_info->is_default == 'Y') return new Object(-1, 'msg_not_delete_default');
+		if(!$group_info) {
+			return new Object(-1, 'lang->msg_not_founded');
+		}
+		if($group_info->is_default == 'Y') {
+			return new Object(-1, 'msg_not_delete_default');
+		}
 
 		// Get groups where is_default == 'Y'
 		$columnList = array('site_srl', 'group_srl');
@@ -1231,13 +1282,14 @@ 
 			$update_args->image_mark = $vars->image_marks[$order];
 			$update_args->list_order = $order + 1;
 
-			if(!$update_args->title) continue;
+			if(!$update_args->title) {
+				continue;
+			}
 
 			if(is_numeric($group_srl)) {
 				$update_args->group_srl = $group_srl;
 				$output = $this->updateGroup($update_args);
-			}
-			else {
+			} else {
 				$update_args->group_srl = getNextSequence();
 				$output = $this->insertGroup($update_args);
 			}
@@ -1327,7 +1379,9 @@ 
 	 */
 	function deleteDeniedID($user_id)
 	{
-		if(!$user_id) unset($user_id);
+		if(!$user_id) {
+			unset($user_id);
+		}
 
 		$args = new stdClass;
 		$args->user_id = $user_id;
@@ -1341,7 +1395,9 @@ 
 	 */
 	function deleteDeniedNickName($nick_name)
 	{
-		if(!$nick_name) unset($nick_name);
+		if(!$nick_name) {
+			unset($nick_name);
+		}
 
 		$args = new stdClass;
 		$args->nick_name = $nick_name;
@@ -1380,16 +1436,22 @@ 
 		// Get a list of all join forms
 		$join_form_list = $oMemberModel->getJoinFormList();
 		$join_form_srl_list = array_keys($join_form_list);
-		if(count($join_form_srl_list)<2) return new Object();
+		if(count($join_form_srl_list)<2) {
+			return new Object();
+		}
 
 		$prev_member_join_form = NULL;
 		foreach($join_form_list as $key => $val)
 		{
-			if($val->member_join_form_srl == $member_join_form_srl) break;
+			if($val->member_join_form_srl == $member_join_form_srl) {
+				break;
+			}
 			$prev_member_join_form = $val;
 		}
 		// Return if no previous join form exists
-		if(!$prev_member_join_form) return new Object();
+		if(!$prev_member_join_form) {
+			return new Object();
+		}
 		// Information of the join form
 		$cur_args = new stdClass;
 		$cur_args->member_join_form_srl = $member_join_form_srl;
@@ -1400,10 +1462,14 @@ 
 		$prev_args->list_order = $list_order;
 		// Execute Query
 		$output = executeQuery('member.updateMemberJoinFormListorder', $cur_args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		executeQuery('member.updateMemberJoinFormListorder', $prev_args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		return new Object();
 	}
@@ -1427,16 +1493,22 @@ 
 		// Get information of all join forms
 		$join_form_list = $oMemberModel->getJoinFormList();
 		$join_form_srl_list = array_keys($join_form_list);
-		if(count($join_form_srl_list)<2) return new Object();
+		if(count($join_form_srl_list)<2) {
+			return new Object();
+		}
 
 		for($i=0;$i<count($join_form_srl_list);$i++)
 		{
-			if($join_form_srl_list[$i]==$member_join_form_srl) break;
+			if($join_form_srl_list[$i]==$member_join_form_srl) {
+				break;
+			}
 		}
 
 		$next_member_join_form_srl = $join_form_srl_list[$i+1];
 		// Return if no previous join form exists
-		if(!$next_member_join_form_srl) return new Object();
+		if(!$next_member_join_form_srl) {
+			return new Object();
+		}
 		$next_member_join_form = $join_form_list[$next_member_join_form_srl];
 		// Information of the join form
 		$cur_args = new stdClass;
@@ -1448,10 +1520,14 @@ 
 		$next_args->list_order = $list_order;
 		// Execute Query
 		$output = executeQuery('member.updateMemberJoinFormListorder', $cur_args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		$output = executeQuery('member.updateMemberJoinFormListorder', $next_args);
-		if(!$output->toBool()) return $output;
+		if(!$output->toBool()) {
+			return $output;
+		}
 
 		return new Object();
 	}