GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Push — master ( d82455...c66acf )
by gyeong-won
19:16 queued 06:46
created
classes/db/queryparts/condition/Condition.class.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -97,6 +97,9 @@
 block discarded – undo
97 97
 		return $this->pipe . ' ' . $this->getConditionPart($this->_value);
98 98
 	}
99 99
 
100
+	/**
101
+	 * @param string $pipe
102
+	 */
100 103
 	function setPipe($pipe)
101 104
 	{
102 105
 		$this->pipe = $pipe;
Please login to merge, or discard this patch.
Braces   +8 added lines, -10 removed lines patch added patch discarded remove patch
@@ -66,12 +66,10 @@  discard block
 block discarded – undo
66 66
 			if(!$this->show())
67 67
 			{
68 68
 				$this->_value_to_string = '';
69
-			}
70
-			else if($withValue)
69
+			} else if($withValue)
71 70
 			{
72 71
 				$this->_value_to_string = $this->toStringWithValue();
73
-			}
74
-			else
72
+			} else
75 73
 			{
76 74
 				$this->_value_to_string = $this->toStringWithoutValue();
77 75
 			}
@@ -112,8 +110,7 @@  discard block
 block discarded – undo
112 110
 			if(is_array($this->_value) && count($this->_value) === 1 && $this->_value[0] === '')
113 111
 			{
114 112
 				$this->_show = false;
115
-			}
116
-			else
113
+			} else
117 114
 			{
118 115
 				$this->_show = true;
119 116
 				switch($this->operation)
@@ -209,10 +206,11 @@  discard block
 block discarded – undo
209 206
 			case 'like_prefix' :
210 207
 			case 'like' :
211 208
 				if(defined('__CUBRID_VERSION__')
212
-						&& __CUBRID_VERSION__ >= '8.4.1')
213
-					return $name . ' rlike ' . $value;
214
-				else
215
-					return $name . ' like ' . $value;
209
+						&& __CUBRID_VERSION__ >= '8.4.1') {
210
+									return $name . ' rlike ' . $value;
211
+				} else {
212
+									return $name . ' like ' . $value;
213
+				}
216 214
 				break;
217 215
 			case 'notlike_tail' :
218 216
 			case 'notlike_prefix' :
Please login to merge, or discard this patch.
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
61 61
 	 */
62 62
 	function toString($withValue = true)
63 63
 	{
64
-		if(!isset($this->_value_to_string))
64
+		if (!isset($this->_value_to_string))
65 65
 		{
66
-			if(!$this->show())
66
+			if (!$this->show())
67 67
 			{
68 68
 				$this->_value_to_string = '';
69 69
 			}
70
-			else if($withValue)
70
+			else if ($withValue)
71 71
 			{
72 72
 				$this->_value_to_string = $this->toStringWithValue();
73 73
 			}
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	 */
86 86
 	function toStringWithoutValue()
87 87
 	{
88
-		return $this->pipe . ' ' . $this->getConditionPart($this->_value);
88
+		return $this->pipe.' '.$this->getConditionPart($this->_value);
89 89
 	}
90 90
 
91 91
 	/**
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 */
95 95
 	function toStringWithValue()
96 96
 	{
97
-		return $this->pipe . ' ' . $this->getConditionPart($this->_value);
97
+		return $this->pipe.' '.$this->getConditionPart($this->_value);
98 98
 	}
99 99
 
100 100
 	function setPipe($pipe)
@@ -107,16 +107,16 @@  discard block
 block discarded – undo
107 107
 	 */
108 108
 	function show()
109 109
 	{
110
-		if(!isset($this->_show))
110
+		if (!isset($this->_show))
111 111
 		{
112
-			if(is_array($this->_value) && count($this->_value) === 1 && $this->_value[0] === '')
112
+			if (is_array($this->_value) && count($this->_value) === 1 && $this->_value[0] === '')
113 113
 			{
114 114
 				$this->_show = false;
115 115
 			}
116 116
 			else
117 117
 			{
118 118
 				$this->_show = true;
119
-				switch($this->operation)
119
+				switch ($this->operation)
120 120
 				{
121 121
 					case 'equal' :
122 122
 					case 'more' :
@@ -138,30 +138,30 @@  discard block
 block discarded – undo
138 138
 					case 'not':
139 139
 					case 'notequal' :
140 140
 						// if variable is not set or is not string or number, return
141
-						if(!isset($this->_value))
141
+						if (!isset($this->_value))
142 142
 						{
143 143
 							$this->_show = false;
144 144
 							break;
145 145
 						}
146
-						if($this->_value === '')
146
+						if ($this->_value === '')
147 147
 						{
148 148
 							$this->_show = false;
149 149
 							break;
150 150
 						}
151 151
 						$tmpArray = array('string' => 1, 'integer' => 1);
152
-						if(!isset($tmpArray[gettype($this->_value)]))
152
+						if (!isset($tmpArray[gettype($this->_value)]))
153 153
 						{
154 154
 							$this->_show = false;
155 155
 							break;
156 156
 						}
157 157
 						break;
158 158
 					case 'between' :
159
-						if(!is_array($this->_value))
159
+						if (!is_array($this->_value))
160 160
 						{
161 161
 							$this->_show = false;
162 162
 							break;
163 163
 						}
164
-						if(count($this->_value) != 2)
164
+						if (count($this->_value) != 2)
165 165
 						{
166 166
 							$this->_show = false;
167 167
 							break;
@@ -188,67 +188,67 @@  discard block
 block discarded – undo
188 188
 		$name = $this->column_name;
189 189
 		$operation = $this->operation;
190 190
 
191
-		switch($operation)
191
+		switch ($operation)
192 192
 		{
193 193
 			case 'equal' :
194
-				return $name . ' = ' . $value;
194
+				return $name.' = '.$value;
195 195
 				break;
196 196
 			case 'more' :
197
-				return $name . ' >= ' . $value;
197
+				return $name.' >= '.$value;
198 198
 				break;
199 199
 			case 'excess' :
200
-				return $name . ' > ' . $value;
200
+				return $name.' > '.$value;
201 201
 				break;
202 202
 			case 'less' :
203
-				return $name . ' <= ' . $value;
203
+				return $name.' <= '.$value;
204 204
 				break;
205 205
 			case 'below' :
206
-				return $name . ' < ' . $value;
206
+				return $name.' < '.$value;
207 207
 				break;
208 208
 			case 'like_tail' :
209 209
 			case 'like_prefix' :
210 210
 			case 'like' :
211
-				if(defined('__CUBRID_VERSION__')
211
+				if (defined('__CUBRID_VERSION__')
212 212
 						&& __CUBRID_VERSION__ >= '8.4.1')
213
-					return $name . ' rlike ' . $value;
213
+					return $name.' rlike '.$value;
214 214
 				else
215
-					return $name . ' like ' . $value;
215
+					return $name.' like '.$value;
216 216
 				break;
217 217
 			case 'notlike_tail' :
218 218
 			case 'notlike_prefix' :
219 219
 			case 'notlike' :
220
-				return $name . ' not like ' . $value;
220
+				return $name.' not like '.$value;
221 221
 				break;
222 222
 			case 'in' :
223
-				return $name . ' in ' . $value;
223
+				return $name.' in '.$value;
224 224
 				break;
225 225
 			case 'notin' :
226 226
 			case 'not_in' :
227
-				return $name . ' not in ' . $value;
227
+				return $name.' not in '.$value;
228 228
 				break;
229 229
 			case 'notequal' :
230
-				return $name . ' <> ' . $value;
230
+				return $name.' <> '.$value;
231 231
 				break;
232 232
 			case 'notnull' :
233
-				return $name . ' is not null';
233
+				return $name.' is not null';
234 234
 				break;
235 235
 			case 'null' :
236
-				return $name . ' is null';
236
+				return $name.' is null';
237 237
 				break;
238 238
 			case 'and' :
239
-				return $name . ' & ' . $value;
239
+				return $name.' & '.$value;
240 240
 				break;
241 241
 			case 'or' :
242
-				return $name . ' | ' . $value;
242
+				return $name.' | '.$value;
243 243
 				break;
244 244
 			case 'xor' :
245
-				return $name . ' ^ ' . $value;
245
+				return $name.' ^ '.$value;
246 246
 				break;
247 247
 			case 'not' :
248
-				return $name . ' ~ ' . $value;
248
+				return $name.' ~ '.$value;
249 249
 				break;
250 250
 			case 'between' :
251
-				return $name . ' between ' . $value[0] . ' and ' . $value[1];
251
+				return $name.' between '.$value[0].' and '.$value[1];
252 252
 				break;
253 253
 		}
254 254
 	}
Please login to merge, or discard this patch.
classes/db/queryparts/condition/ConditionWithoutArgument.class.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,10 +12,10 @@
 block discarded – undo
12 12
 	/**
13 13
 	 * constructor
14 14
 	 * @param string $column_name
15
-	 * @param mixed $argument
15
+	 * @param integer $argument
16 16
 	 * @param string $operation
17 17
 	 * @param string $pipe
18
-	 * @return void
18
+	 * @return boolean
19 19
 	 */
20 20
 	function ConditionWithoutArgument($column_name, $argument, $operation, $pipe = "")
21 21
 	{
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,8 +111,7 @@
 block discarded – undo
111 111
 		if($this->limit)
112 112
 		{
113 113
 			return $this->limit->toString();
114
-		}
115
-		else
114
+		} else
116 115
 		{
117 116
 			return "";
118 117
 		}
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,13 +21,13 @@
 block discarded – undo
21 21
 	{
22 22
 		parent::Condition($column_name, $argument, $operation, $pipe);
23 23
 		$tmpArray = array('in' => 1, 'notin' => 1, 'not_in' => 1);
24
-		if(isset($tmpArray[$operation]))
24
+		if (isset($tmpArray[$operation]))
25 25
 		{
26
-			if(is_array($argument))
26
+			if (is_array($argument))
27 27
 			{
28 28
 				$argument = implode($argument, ',');
29 29
 			}
30
-			$this->_value = '(' . $argument . ')';
30
+			$this->_value = '('.$argument.')';
31 31
 		}
32 32
 		else
33 33
 		{
Please login to merge, or discard this patch.
classes/db/queryparts/expression/UpdateExpression.class.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 	/**
21 21
 	 * constructor
22 22
 	 * @param string $column_name
23
-	 * @param object $argument
23
+	 * @param Argument $argument
24 24
 	 * @return void
25 25
 	 */
26 26
 	function UpdateExpression($column_name, $argument)
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,8 +111,7 @@
 block discarded – undo
111 111
 		if($this->limit)
112 112
 		{
113 113
 			return $this->limit->toString();
114
-		}
115
-		else
114
+		} else
116 115
 		{
117 116
 			return "";
118 117
 		}
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	 */
36 36
 	function getExpression($with_value = true)
37 37
 	{
38
-		if($with_value)
38
+		if ($with_value)
39 39
 		{
40 40
 			return $this->getExpressionWithValue();
41 41
 		}
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 	{
51 51
 		$value = $this->argument->getValue();
52 52
 		$operation = $this->argument->getColumnOperation();
53
-		if(isset($operation))
53
+		if (isset($operation))
54 54
 		{
55 55
 			return "$this->column_name = $this->column_name $operation $value";
56 56
 		}
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 	function getExpressionWithoutValue()
66 66
 	{
67 67
 		$operation = $this->argument->getColumnOperation();
68
-		if(isset($operation))
68
+		if (isset($operation))
69 69
 		{
70 70
 			return "$this->column_name = $this->column_name $operation ?";
71 71
 		}
@@ -76,21 +76,21 @@  discard block
 block discarded – undo
76 76
 	{
77 77
 		// TODO Escape value according to column type instead of variable type
78 78
 		$value = $this->argument->getValue();
79
-		if(!is_numeric($value))
79
+		if (!is_numeric($value))
80 80
 		{
81
-			return "'" . $value . "'";
81
+			return "'".$value."'";
82 82
 		}
83 83
 		return $value;
84 84
 	}
85 85
 
86 86
 	function show()
87 87
 	{
88
-		if(!$this->argument)
88
+		if (!$this->argument)
89 89
 		{
90 90
 			return false;
91 91
 		}
92 92
 		$value = $this->argument->getValue();
93
-		if(!isset($value))
93
+		if (!isset($value))
94 94
 		{
95 95
 			return false;
96 96
 		}
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 
105 105
 	function getArguments()
106 106
 	{
107
-		if($this->argument)
107
+		if ($this->argument)
108 108
 		{
109 109
 			return array($this->argument);
110 110
 		}
Please login to merge, or discard this patch.
classes/db/queryparts/Query.class.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -251,6 +251,9 @@
 block discarded – undo
251 251
 		return $this->orderby;
252 252
 	}
253 253
 
254
+	/**
255
+	 * @param integer $limit
256
+	 */
254 257
 	function setLimit($limit = NULL)
255 258
 	{
256 259
 		if(!isset($limit))
Please login to merge, or discard this patch.
Braces   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -378,8 +378,7 @@  discard block
 block discarded – undo
378 378
 				if($column->isSubquery())
379 379
 				{
380 380
 					$select[] = $column->toString($with_values) . ' as ' . $column->getAlias();
381
-				}
382
-				else
381
+				} else
383 382
 				{
384 383
 					$select[] = $column->getExpression($with_values);
385 384
 				}
@@ -403,7 +402,9 @@  discard block
 block discarded – undo
403 402
 			}
404 403
 		}
405 404
 
406
-		if(!$update) return;
405
+		if(!$update) {
406
+			return;
407
+		}
407 408
 		return trim(implode($update, ', '));
408 409
 	}
409 410
 
@@ -465,8 +466,7 @@  discard block
 block discarded – undo
465 466
 			if($table->isJoinTable() || !$simple_table_count)
466 467
 			{
467 468
 				$from .= $table->toString($with_values) . ' ';
468
-			}
469
-			else
469
+			} else
470 470
 			{
471 471
 				$from .= ', ' . $table->toString($with_values) . ' ';
472 472
 			}
Please login to merge, or discard this patch.
Spacing   +70 added lines, -70 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 		$this->action = $action;
109 109
 		$this->priority = $priority;
110 110
 
111
-		if(!isset($tables))
111
+		if (!isset($tables))
112 112
 		{
113 113
 			return;
114 114
 		}
@@ -144,12 +144,12 @@  discard block
 block discarded – undo
144 144
 	function setColumnList($columnList)
145 145
 	{
146 146
 		$this->columnList = $columnList;
147
-		if(count($this->columnList) > 0)
147
+		if (count($this->columnList) > 0)
148 148
 		{
149 149
 			$selectColumns = array();
150 150
 			$dbParser = DB::getParser();
151 151
 
152
-			foreach($this->columnList as $columnName)
152
+			foreach ($this->columnList as $columnName)
153 153
 			{
154 154
 				$columnName = $dbParser->escapeColumn($columnName);
155 155
 				$selectColumns[] = new SelectExpression($columnName);
@@ -161,13 +161,13 @@  discard block
 block discarded – undo
161 161
 
162 162
 	function setColumns($columns)
163 163
 	{
164
-		if(!isset($columns) || count($columns) === 0)
164
+		if (!isset($columns) || count($columns) === 0)
165 165
 		{
166 166
 			$this->columns = array(new StarExpression());
167 167
 			return;
168 168
 		}
169 169
 
170
-		if(!is_array($columns))
170
+		if (!is_array($columns))
171 171
 		{
172 172
 			$columns = array($columns);
173 173
 		}
@@ -177,14 +177,14 @@  discard block
 block discarded – undo
177 177
 
178 178
 	function setTables($tables)
179 179
 	{
180
-		if(!isset($tables) || count($tables) === 0)
180
+		if (!isset($tables) || count($tables) === 0)
181 181
 		{
182 182
 			$this->setError(TRUE);
183 183
 			$this->setMessage("You must provide at least one table for the query.");
184 184
 			return;
185 185
 		}
186 186
 
187
-		if(!is_array($tables))
187
+		if (!is_array($tables))
188 188
 		{
189 189
 			$tables = array($tables);
190 190
 		}
@@ -200,18 +200,18 @@  discard block
 block discarded – undo
200 200
 	function setConditions($conditions)
201 201
 	{
202 202
 		$this->conditions = array();
203
-		if(!isset($conditions) || count($conditions) === 0)
203
+		if (!isset($conditions) || count($conditions) === 0)
204 204
 		{
205 205
 			return;
206 206
 		}
207
-		if(!is_array($conditions))
207
+		if (!is_array($conditions))
208 208
 		{
209 209
 			$conditions = array($conditions);
210 210
 		}
211 211
 
212
-		foreach($conditions as $conditionGroup)
212
+		foreach ($conditions as $conditionGroup)
213 213
 		{
214
-			if($conditionGroup->show())
214
+			if ($conditionGroup->show())
215 215
 			{
216 216
 				$this->conditions[] = $conditionGroup;
217 217
 			}
@@ -220,11 +220,11 @@  discard block
 block discarded – undo
220 220
 
221 221
 	function setGroups($groups)
222 222
 	{
223
-		if(!isset($groups) || count($groups) === 0)
223
+		if (!isset($groups) || count($groups) === 0)
224 224
 		{
225 225
 			return;
226 226
 		}
227
-		if(!is_array($groups))
227
+		if (!is_array($groups))
228 228
 		{
229 229
 			$groups = array($groups);
230 230
 		}
@@ -234,11 +234,11 @@  discard block
 block discarded – undo
234 234
 
235 235
 	function setOrder($order)
236 236
 	{
237
-		if(!isset($order) || count($order) === 0)
237
+		if (!isset($order) || count($order) === 0)
238 238
 		{
239 239
 			return;
240 240
 		}
241
-		if(!is_array($order))
241
+		if (!is_array($order))
242 242
 		{
243 243
 			$order = array($order);
244 244
 		}
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 
254 254
 	function setLimit($limit = NULL)
255 255
 	{
256
-		if(!isset($limit))
256
+		if (!isset($limit))
257 257
 		{
258 258
 			return;
259 259
 		}
@@ -354,9 +354,9 @@  discard block
 block discarded – undo
354 354
 	function getClickCountColumns()
355 355
 	{
356 356
 		$click_count_columns = array();
357
-		foreach($this->columns as $column)
357
+		foreach ($this->columns as $column)
358 358
 		{
359
-			if($column->show() && is_a($column, 'ClickCountExpression'))
359
+			if ($column->show() && is_a($column, 'ClickCountExpression'))
360 360
 			{
361 361
 				$click_count_columns[] = $column;
362 362
 			}
@@ -371,13 +371,13 @@  discard block
 block discarded – undo
371 371
 	 */
372 372
 	function getSelectString($with_values = TRUE)
373 373
 	{
374
-		foreach($this->columns as $column)
374
+		foreach ($this->columns as $column)
375 375
 		{
376
-			if($column->show())
376
+			if ($column->show())
377 377
 			{
378
-				if($column->isSubquery())
378
+				if ($column->isSubquery())
379 379
 				{
380
-					$select[] = $column->toString($with_values) . ' as ' . $column->getAlias();
380
+					$select[] = $column->toString($with_values).' as '.$column->getAlias();
381 381
 				}
382 382
 				else
383 383
 				{
@@ -395,15 +395,15 @@  discard block
 block discarded – undo
395 395
 	 */
396 396
 	function getUpdateString($with_values = TRUE)
397 397
 	{
398
-		foreach($this->columns as $column)
398
+		foreach ($this->columns as $column)
399 399
 		{
400
-			if($column->show())
400
+			if ($column->show())
401 401
 			{
402 402
 				$update[] = $column->getExpression($with_values);
403 403
 			}
404 404
 		}
405 405
 
406
-		if(!$update) return;
406
+		if (!$update) return;
407 407
 		return trim(implode($update, ', '));
408 408
 	}
409 409
 
@@ -416,11 +416,11 @@  discard block
 block discarded – undo
416 416
 	{
417 417
 		$columnsList = '';
418 418
 		// means we have insert-select
419
-		if($this->subquery)
419
+		if ($this->subquery)
420 420
 		{
421
-			foreach($this->columns as $column)
421
+			foreach ($this->columns as $column)
422 422
 			{
423
-				$columnsList .= $column->getColumnName() . ', ';
423
+				$columnsList .= $column->getColumnName().', ';
424 424
 			}
425 425
 			$columnsList = substr($columnsList, 0, -2);
426 426
 			$selectStatement = $this->subquery->toString($with_values);
@@ -429,12 +429,12 @@  discard block
 block discarded – undo
429 429
 		}
430 430
 
431 431
 		$valuesList = '';
432
-		foreach($this->columns as $column)
432
+		foreach ($this->columns as $column)
433 433
 		{
434
-			if($column->show())
434
+			if ($column->show())
435 435
 			{
436
-				$columnsList .= $column->getColumnName() . ', ';
437
-				$valuesList .= $column->getValue($with_values) . ', ';
436
+				$columnsList .= $column->getColumnName().', ';
437
+				$valuesList .= $column->getValue($with_values).', ';
438 438
 			}
439 439
 		}
440 440
 		$columnsList = substr($columnsList, 0, -2);
@@ -460,25 +460,25 @@  discard block
 block discarded – undo
460 460
 	{
461 461
 		$from = '';
462 462
 		$simple_table_count = 0;
463
-		foreach($this->tables as $table)
463
+		foreach ($this->tables as $table)
464 464
 		{
465
-			if($table->isJoinTable() || !$simple_table_count)
465
+			if ($table->isJoinTable() || !$simple_table_count)
466 466
 			{
467
-				$from .= $table->toString($with_values) . ' ';
467
+				$from .= $table->toString($with_values).' ';
468 468
 			}
469 469
 			else
470 470
 			{
471
-				$from .= ', ' . $table->toString($with_values) . ' ';
471
+				$from .= ', '.$table->toString($with_values).' ';
472 472
 			}
473 473
 
474
-			if(is_a($table, 'Subquery'))
474
+			if (is_a($table, 'Subquery'))
475 475
 			{
476
-				$from .= $table->getAlias() ? ' as ' . $table->getAlias() . ' ' : ' ';
476
+				$from .= $table->getAlias() ? ' as '.$table->getAlias().' ' : ' ';
477 477
 			}
478 478
 
479 479
 			$simple_table_count++;
480 480
 		}
481
-		if(trim($from) == '')
481
+		if (trim($from) == '')
482 482
 		{
483 483
 			return '';
484 484
 		}
@@ -496,9 +496,9 @@  discard block
 block discarded – undo
496 496
 		$where = '';
497 497
 		$condition_count = 0;
498 498
 
499
-		foreach($this->conditions as $conditionGroup)
499
+		foreach ($this->conditions as $conditionGroup)
500 500
 		{
501
-			if($condition_count === 0)
501
+			if ($condition_count === 0)
502 502
 			{
503 503
 				$conditionGroup->setPipe("");
504 504
 			}
@@ -507,26 +507,26 @@  discard block
 block discarded – undo
507 507
 			$condition_count++;
508 508
 		}
509 509
 
510
-		if($with_optimization &&
510
+		if ($with_optimization &&
511 511
 				(strstr($this->getOrderByString(), 'list_order') || strstr($this->getOrderByString(), 'update_order')))
512 512
 		{
513 513
 
514
-			if($condition_count !== 0)
514
+			if ($condition_count !== 0)
515 515
 			{
516
-				$where = '(' . $where . ') ';
516
+				$where = '('.$where.') ';
517 517
 			}
518 518
 
519
-			foreach($this->orderby as $order)
519
+			foreach ($this->orderby as $order)
520 520
 			{
521 521
 				$colName = $order->getColumnName();
522
-				if(strstr($colName, 'list_order') || strstr($colName, 'update_order'))
522
+				if (strstr($colName, 'list_order') || strstr($colName, 'update_order'))
523 523
 				{
524 524
 					$opt_condition = new ConditionWithoutArgument($colName, 2100000000, 'less', 'and');
525
-					if($condition_count === 0)
525
+					if ($condition_count === 0)
526 526
 					{
527 527
 						$opt_condition->setPipe("");
528 528
 					}
529
-					$where .= $opt_condition->toString($with_values) . ' ';
529
+					$where .= $opt_condition->toString($with_values).' ';
530 530
 					$condition_count++;
531 531
 				}
532 532
 			}
@@ -542,9 +542,9 @@  discard block
 block discarded – undo
542 542
 	function getGroupByString()
543 543
 	{
544 544
 		$groupBy = '';
545
-		if($this->groups)
545
+		if ($this->groups)
546 546
 		{
547
-			if($this->groups[0] !== "")
547
+			if ($this->groups[0] !== "")
548 548
 			{
549 549
 				$groupBy = implode(', ', $this->groups);
550 550
 			}
@@ -558,16 +558,16 @@  discard block
 block discarded – undo
558 558
 	 */
559 559
 	function getOrderByString()
560 560
 	{
561
-		if(!$this->_orderByString)
561
+		if (!$this->_orderByString)
562 562
 		{
563
-			if(count($this->orderby) === 0)
563
+			if (count($this->orderby) === 0)
564 564
 			{
565 565
 				return '';
566 566
 			}
567 567
 			$orderBy = '';
568
-			foreach($this->orderby as $order)
568
+			foreach ($this->orderby as $order)
569 569
 			{
570
-				$orderBy .= $order->toString() . ', ';
570
+				$orderBy .= $order->toString().', ';
571 571
 			}
572 572
 			$orderBy = substr($orderBy, 0, -2);
573 573
 			$this->_orderByString = $orderBy;
@@ -587,7 +587,7 @@  discard block
 block discarded – undo
587 587
 	function getLimitString()
588 588
 	{
589 589
 		$limit = '';
590
-		if(count($this->limit) > 0)
590
+		if (count($this->limit) > 0)
591 591
 		{
592 592
 			$limit = '';
593 593
 			$limit .= $this->limit->toString();
@@ -606,19 +606,19 @@  discard block
 block discarded – undo
606 606
 	 */
607 607
 	function getArguments()
608 608
 	{
609
-		if(!isset($this->arguments))
609
+		if (!isset($this->arguments))
610 610
 		{
611 611
 			$this->arguments = array();
612 612
 
613 613
 			// Join table arguments
614
-			if(count($this->tables) > 0)
614
+			if (count($this->tables) > 0)
615 615
 			{
616
-				foreach($this->tables as $table)
616
+				foreach ($this->tables as $table)
617 617
 				{
618
-					if($table->isJoinTable() || is_a($table, 'Subquery'))
618
+					if ($table->isJoinTable() || is_a($table, 'Subquery'))
619 619
 					{
620 620
 						$args = $table->getArguments();
621
-						if($args)
621
+						if ($args)
622 622
 						{
623 623
 							$this->arguments = array_merge($this->arguments, $args);
624 624
 						}
@@ -628,14 +628,14 @@  discard block
 block discarded – undo
628 628
 
629 629
 			// Column arguments
630 630
 			// The if is for delete statements, all others must have columns
631
-			if(count($this->columns) > 0)
631
+			if (count($this->columns) > 0)
632 632
 			{
633
-				foreach($this->columns as $column)
633
+				foreach ($this->columns as $column)
634 634
 				{
635
-					if($column->show())
635
+					if ($column->show())
636 636
 					{
637 637
 						$args = $column->getArguments();
638
-						if($args)
638
+						if ($args)
639 639
 						{
640 640
 							$this->arguments = array_merge($this->arguments, $args);
641 641
 						}
@@ -644,12 +644,12 @@  discard block
 block discarded – undo
644 644
 			}
645 645
 
646 646
 			// Condition arguments
647
-			if(count($this->conditions) > 0)
647
+			if (count($this->conditions) > 0)
648 648
 			{
649
-				foreach($this->conditions as $conditionGroup)
649
+				foreach ($this->conditions as $conditionGroup)
650 650
 				{
651 651
 					$args = $conditionGroup->getArguments();
652
-					if(count($args) > 0)
652
+					if (count($args) > 0)
653 653
 					{
654 654
 						$this->arguments = array_merge($this->arguments, $args);
655 655
 					}
@@ -657,12 +657,12 @@  discard block
 block discarded – undo
657 657
 			}
658 658
 
659 659
 			// Navigation arguments
660
-			if(count($this->orderby) > 0)
660
+			if (count($this->orderby) > 0)
661 661
 			{
662
-				foreach($this->orderby as $order)
662
+				foreach ($this->orderby as $order)
663 663
 				{
664 664
 					$args = $order->getArguments();
665
-					if(count($args) > 0)
665
+					if (count($args) > 0)
666 666
 					{
667 667
 						$this->arguments = array_merge($this->arguments, $args);
668 668
 					}
Please login to merge, or discard this patch.
classes/display/DisplayHandler.class.php 3 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 	 * Print debugging message to designated output source depending on the value set to __DEBUG_OUTPUT_. \n
134 134
 	 * This method only functions when __DEBUG__ variable is set to 1.
135 135
 	 * __DEBUG_OUTPUT__ == 0, messages are written in ./files/_debug_message.php
136
-	 * @return void
136
+	 * @return null|string
137 137
 	 */
138 138
 	function _debugOutput()
139 139
 	{
@@ -358,6 +358,7 @@  discard block
 block discarded – undo
358 358
 
359 359
 	/**
360 360
 	 * print a HTTP HEADER for HTML, which is encoded in UTF-8
361
+	 * @param integer $code
361 362
 	 * @return void
362 363
 	 */
363 364
 	function _printHttpStatusCode($code)
Please login to merge, or discard this patch.
Braces   +13 added lines, -21 removed lines patch added patch discarded remove patch
@@ -40,24 +40,20 @@  discard block
 block discarded – undo
40 40
 		if(Context::get('xeVirtualRequestMethod') == 'xml')
41 41
 		{
42 42
 			$handler = new VirtualXMLDisplayHandler();
43
-		}
44
-		else if(Context::getRequestMethod() == 'XMLRPC')
43
+		} else if(Context::getRequestMethod() == 'XMLRPC')
45 44
 		{
46 45
 			$handler = new XMLDisplayHandler();
47 46
 			if(strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== FALSE)
48 47
 			{
49 48
 				$this->gz_enabled = FALSE;
50 49
 			}
51
-		}
52
-		else if(Context::getRequestMethod() == 'JSON')
50
+		} else if(Context::getRequestMethod() == 'JSON')
53 51
 		{
54 52
 			$handler = new JSONDisplayHandler();
55
-		}
56
-		else if(Context::getRequestMethod() == 'JS_CALLBACK')
53
+		} else if(Context::getRequestMethod() == 'JS_CALLBACK')
57 54
 		{
58 55
 			$handler = new JSCallbackDisplayHandler();
59
-		}
60
-		else
56
+		} else
61 57
 		{
62 58
 			$handler = new HTMLDisplayHandler();
63 59
 		}
@@ -71,7 +67,9 @@  discard block
 block discarded – undo
71 67
 		$called_position = 'before_display_content';
72 68
 		$oAddonController = getController('addon');
73 69
 		$addon_file = $oAddonController->getCacheFilePath(Mobile::isFromMobilePhone() ? "mobile" : "pc");
74
-		if(file_exists($addon_file)) include($addon_file);
70
+		if(file_exists($addon_file)) {
71
+			include($addon_file);
72
+		}
75 73
 
76 74
 		if(method_exists($handler, "prepareToPrint"))
77 75
 		{
@@ -84,18 +82,15 @@  discard block
 block discarded – undo
84 82
 		if($httpStatusCode && $httpStatusCode != 200)
85 83
 		{
86 84
 			$this->_printHttpStatusCode($httpStatusCode);
87
-		}
88
-		else
85
+		} else
89 86
 		{
90 87
 			if(Context::getResponseMethod() == 'JSON' || Context::getResponseMethod() == 'JS_CALLBACK')
91 88
 			{
92 89
 				$this->_printJSONHeader();
93
-			}
94
-			else if(Context::getResponseMethod() != 'HTML')
90
+			} else if(Context::getResponseMethod() != 'HTML')
95 91
 			{
96 92
 				$this->_printXMLHeader();
97
-			}
98
-			else
93
+			} else
99 94
 			{
100 95
 				$this->_printHTMLHeader();
101 96
 			}
@@ -117,8 +112,7 @@  discard block
 block discarded – undo
117 112
 		{
118 113
 			header("Content-Encoding: gzip");
119 114
 			print ob_gzhandler($output, 5);
120
-		}
121
-		else
115
+		} else
122 116
 		{
123 117
 			print $output;
124 118
 		}
@@ -213,8 +207,7 @@  discard block
 block discarded – undo
213 207
 				);
214 208
 			}
215 209
 			// dislpay the file and HTML comments
216
-		}
217
-		else
210
+		} else
218 211
 		{
219 212
 
220 213
 			$buff = array();
@@ -269,8 +262,7 @@  discard block
 block discarded – undo
269 262
 						if($query['result'] == 'Success')
270 263
 						{
271 264
 							$query_result = "Query Success";
272
-						}
273
-						else
265
+						} else
274 266
 						{
275 267
 							$query_result = sprintf("Query $s : %d\n\t\t\t   %s", $query['result'], $query['errno'], $query['errstr']);
276 268
 						}
Please login to merge, or discard this patch.
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	function printContent(&$oModule)
26 26
 	{
27 27
 		// Check if the gzip encoding supported
28
-		if(
28
+		if (
29 29
 				(defined('__OB_GZHANDLER_ENABLE__') && __OB_GZHANDLER_ENABLE__ == 1) &&
30 30
 				strpos($_SERVER['HTTP_ACCEPT_ENCODING'], 'gzip') !== FALSE &&
31 31
 				function_exists('ob_gzhandler') &&
@@ -37,23 +37,23 @@  discard block
 block discarded – undo
37 37
 		}
38 38
 
39 39
 		// Extract contents to display by the request method
40
-		if(Context::get('xeVirtualRequestMethod') == 'xml')
40
+		if (Context::get('xeVirtualRequestMethod') == 'xml')
41 41
 		{
42 42
 			$handler = new VirtualXMLDisplayHandler();
43 43
 		}
44
-		else if(Context::getRequestMethod() == 'XMLRPC')
44
+		else if (Context::getRequestMethod() == 'XMLRPC')
45 45
 		{
46 46
 			$handler = new XMLDisplayHandler();
47
-			if(strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== FALSE)
47
+			if (strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== FALSE)
48 48
 			{
49 49
 				$this->gz_enabled = FALSE;
50 50
 			}
51 51
 		}
52
-		else if(Context::getRequestMethod() == 'JSON')
52
+		else if (Context::getRequestMethod() == 'JSON')
53 53
 		{
54 54
 			$handler = new JSONDisplayHandler();
55 55
 		}
56
-		else if(Context::getRequestMethod() == 'JS_CALLBACK')
56
+		else if (Context::getRequestMethod() == 'JS_CALLBACK')
57 57
 		{
58 58
 			$handler = new JSCallbackDisplayHandler();
59 59
 		}
@@ -71,9 +71,9 @@  discard block
 block discarded – undo
71 71
 		$called_position = 'before_display_content';
72 72
 		$oAddonController = getController('addon');
73 73
 		$addon_file = $oAddonController->getCacheFilePath(Mobile::isFromMobilePhone() ? "mobile" : "pc");
74
-		if(file_exists($addon_file)) include($addon_file);
74
+		if (file_exists($addon_file)) include($addon_file);
75 75
 
76
-		if(method_exists($handler, "prepareToPrint"))
76
+		if (method_exists($handler, "prepareToPrint"))
77 77
 		{
78 78
 			$handler->prepareToPrint($output);
79 79
 		}
@@ -81,17 +81,17 @@  discard block
 block discarded – undo
81 81
 		// header output
82 82
 
83 83
 		$httpStatusCode = $oModule->getHttpStatusCode();
84
-		if($httpStatusCode && $httpStatusCode != 200)
84
+		if ($httpStatusCode && $httpStatusCode != 200)
85 85
 		{
86 86
 			$this->_printHttpStatusCode($httpStatusCode);
87 87
 		}
88 88
 		else
89 89
 		{
90
-			if(Context::getResponseMethod() == 'JSON' || Context::getResponseMethod() == 'JS_CALLBACK')
90
+			if (Context::getResponseMethod() == 'JSON' || Context::getResponseMethod() == 'JS_CALLBACK')
91 91
 			{
92 92
 				$this->_printJSONHeader();
93 93
 			}
94
-			else if(Context::getResponseMethod() != 'HTML')
94
+			else if (Context::getResponseMethod() != 'HTML')
95 95
 			{
96 96
 				$this->_printXMLHeader();
97 97
 			}
@@ -107,13 +107,13 @@  discard block
 block discarded – undo
107 107
 
108 108
 		// disable gzip if output already exists
109 109
 		ob_flush();
110
-		if(headers_sent())
110
+		if (headers_sent())
111 111
 		{
112 112
 			$this->gz_enabled = FALSE;
113 113
 		}
114 114
 
115 115
 		// results directly output
116
-		if($this->gz_enabled)
116
+		if ($this->gz_enabled)
117 117
 		{
118 118
 			header("Content-Encoding: gzip");
119 119
 			print ob_gzhandler($output, 5);
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 	 */
138 138
 	function _debugOutput()
139 139
 	{
140
-		if(!__DEBUG__)
140
+		if (!__DEBUG__)
141 141
 		{
142 142
 			return;
143 143
 		}
@@ -145,32 +145,32 @@  discard block
 block discarded – undo
145 145
 		$end = getMicroTime();
146 146
 
147 147
 		// Firebug console output
148
-		if(__DEBUG_OUTPUT__ == 2 && version_compare(PHP_VERSION, '6.0.0') === -1)
148
+		if (__DEBUG_OUTPUT__ == 2 && version_compare(PHP_VERSION, '6.0.0') === -1)
149 149
 		{
150 150
 			static $firephp;
151
-			if(!isset($firephp))
151
+			if (!isset($firephp))
152 152
 			{
153 153
 				$firephp = FirePHP::getInstance(true);
154 154
 			}
155 155
 
156
-			if(__DEBUG_PROTECT__ == 1 && __DEBUG_PROTECT_IP__ != $_SERVER['REMOTE_ADDR'])
156
+			if (__DEBUG_PROTECT__ == 1 && __DEBUG_PROTECT_IP__ != $_SERVER['REMOTE_ADDR'])
157 157
 			{
158 158
 				$firephp->fb('Change the value of __DEBUG_PROTECT_IP__ into your IP address in config/config.user.inc.php or config/config.inc.php', 'The IP address is not allowed.');
159 159
 				return;
160 160
 			}
161 161
 			// display total execution time and Request/Response info
162
-			if(__DEBUG__ & 2)
162
+			if (__DEBUG__ & 2)
163 163
 			{
164 164
 				$firephp->fb(
165 165
 						array(
166
-							'Request / Response info >>> ' . $_SERVER['REQUEST_METHOD'] . ' / ' . Context::getResponseMethod(),
166
+							'Request / Response info >>> '.$_SERVER['REQUEST_METHOD'].' / '.Context::getResponseMethod(),
167 167
 							array(
168 168
 								array('Request URI', 'Request method', 'Response method', 'Response contents size', 'Memory peak usage'),
169 169
 								array(
170 170
 									sprintf("%s:%s%s%s%s", $_SERVER['SERVER_NAME'], $_SERVER['SERVER_PORT'], $_SERVER['PHP_SELF'], $_SERVER['QUERY_STRING'] ? '?' : '', $_SERVER['QUERY_STRING']),
171 171
 									$_SERVER['REQUEST_METHOD'],
172 172
 									Context::getResponseMethod(),
173
-									$this->content_size . ' byte',
173
+									$this->content_size.' byte',
174 174
 									FileHandler::filesize(memory_get_peak_usage())
175 175
 								)
176 176
 							)
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 				);
180 180
 				$firephp->fb(
181 181
 						array(
182
-							'Elapsed time >>> Total : ' . sprintf('%0.5f sec', $end - __StartTime__),
182
+							'Elapsed time >>> Total : '.sprintf('%0.5f sec', $end - __StartTime__),
183 183
 							array(array('DB queries', 'class file load', 'Template compile', 'XmlParse compile', 'PHP', 'Widgets', 'Trans Content'),
184 184
 								array(
185 185
 									sprintf('%0.5f sec', $GLOBALS['__db_elapsed_time__']),
@@ -197,16 +197,16 @@  discard block
 block discarded – undo
197 197
 			}
198 198
 
199 199
 			// display DB query history
200
-			if((__DEBUG__ & 4) && $GLOBALS['__db_queries__'])
200
+			if ((__DEBUG__ & 4) && $GLOBALS['__db_queries__'])
201 201
 			{
202 202
 				$queries_output = array(array('Result/'.PHP_EOL.'Elapsed time', 'Query ID', 'Query'));
203
-				foreach($GLOBALS['__db_queries__'] as $query)
203
+				foreach ($GLOBALS['__db_queries__'] as $query)
204 204
 				{
205
-					$queries_output[] = array($query['result'] . PHP_EOL . sprintf('%0.5f', $query['elapsed_time']), str_replace(_XE_PATH_, '', $query['called_file']) . PHP_EOL . $query['called_method'] . '()' . PHP_EOL . $query['query_id'], $query['query']);
205
+					$queries_output[] = array($query['result'].PHP_EOL.sprintf('%0.5f', $query['elapsed_time']), str_replace(_XE_PATH_, '', $query['called_file']).PHP_EOL.$query['called_method'].'()'.PHP_EOL.$query['query_id'], $query['query']);
206 206
 				}
207 207
 				$firephp->fb(
208 208
 						array(
209
-							'DB Queries >>> ' . count($GLOBALS['__db_queries__']) . ' Queries, ' . sprintf('%0.5f sec', $GLOBALS['__db_elapsed_time__']),
209
+							'DB Queries >>> '.count($GLOBALS['__db_queries__']).' Queries, '.sprintf('%0.5f sec', $GLOBALS['__db_elapsed_time__']),
210 210
 							$queries_output
211 211
 						),
212 212
 						'TABLE'
@@ -219,9 +219,9 @@  discard block
 block discarded – undo
219 219
 
220 220
 			$buff = array();
221 221
 			// display total execution time and Request/Response info
222
-			if(__DEBUG__ & 2)
222
+			if (__DEBUG__ & 2)
223 223
 			{
224
-				if(__DEBUG_PROTECT__ == 1 && __DEBUG_PROTECT_IP__ != $_SERVER['REMOTE_ADDR'])
224
+				if (__DEBUG_PROTECT__ == 1 && __DEBUG_PROTECT_IP__ != $_SERVER['REMOTE_ADDR'])
225 225
 				{
226 226
 					return;
227 227
 				}
@@ -252,21 +252,21 @@  discard block
 block discarded – undo
252 252
 				$buff[] = sprintf("\tTrans Content \t\t\t\t\t: %0.5f sec", $GLOBALS['__trans_content_elapsed__']);
253 253
 			}
254 254
 			// DB Logging
255
-			if(__DEBUG__ & 4)
255
+			if (__DEBUG__ & 4)
256 256
 			{
257
-				if(__DEBUG_PROTECT__ == 1 && __DEBUG_PROTECT_IP__ != $_SERVER['REMOTE_ADDR'])
257
+				if (__DEBUG_PROTECT__ == 1 && __DEBUG_PROTECT_IP__ != $_SERVER['REMOTE_ADDR'])
258 258
 				{
259 259
 					return;
260 260
 				}
261 261
 
262
-				if($GLOBALS['__db_queries__'])
262
+				if ($GLOBALS['__db_queries__'])
263 263
 				{
264 264
 					$buff[] = sprintf("\n- DB Queries : %d Queries. %0.5f sec", count($GLOBALS['__db_queries__']), $GLOBALS['__db_elapsed_time__']);
265 265
 					$num = 0;
266 266
 
267
-					foreach($GLOBALS['__db_queries__'] as $query)
267
+					foreach ($GLOBALS['__db_queries__'] as $query)
268 268
 					{
269
-						if($query['result'] == 'Success')
269
+						if ($query['result'] == 'Success')
270 270
 						{
271 271
 							$query_result = "Query Success";
272 272
 						}
@@ -283,30 +283,30 @@  discard block
 block discarded – undo
283 283
 			}
284 284
 
285 285
 			// Output in HTML comments
286
-			if($buff && __DEBUG_OUTPUT__ == 1 && Context::getResponseMethod() == 'HTML')
286
+			if ($buff && __DEBUG_OUTPUT__ == 1 && Context::getResponseMethod() == 'HTML')
287 287
 			{
288 288
 				$buff = implode("\r\n", $buff);
289 289
 				$buff = sprintf("[%s %s:%d]\r\n%s", date('Y-m-d H:i:s'), $file_name, $line_num, print_r($buff, true));
290 290
 
291
-				if(__DEBUG_PROTECT__ == 1 && __DEBUG_PROTECT_IP__ != $_SERVER['REMOTE_ADDR'])
291
+				if (__DEBUG_PROTECT__ == 1 && __DEBUG_PROTECT_IP__ != $_SERVER['REMOTE_ADDR'])
292 292
 				{
293 293
 					$buff = 'The IP address is not allowed. Change the value of __DEBUG_PROTECT_IP__ into your IP address in config/config.user.inc.php or config/config.inc.php';
294 294
 				}
295 295
 
296
-				return "<!--\r\n" . $buff . "\r\n-->";
296
+				return "<!--\r\n".$buff."\r\n-->";
297 297
 			}
298 298
 
299 299
 			// Output to a file
300
-			if($buff && __DEBUG_OUTPUT__ == 0)
300
+			if ($buff && __DEBUG_OUTPUT__ == 0)
301 301
 			{
302
-				$debug_file = _XE_PATH_ . 'files/_debug_message.php';
302
+				$debug_file = _XE_PATH_.'files/_debug_message.php';
303 303
 				$buff = implode(PHP_EOL, $buff);
304 304
 				$buff = sprintf("[%s]\n%s", date('Y-m-d H:i:s'), print_r($buff, true));
305 305
 
306
-				$buff = str_repeat('=', 80) . "\n" . $buff . "\n" . str_repeat('-', 80);
307
-				$buff = "\n<?php\n/*" . $buff . "*/\n?>\n";
306
+				$buff = str_repeat('=', 80)."\n".$buff."\n".str_repeat('-', 80);
307
+				$buff = "\n<?php\n/*".$buff."*/\n?>\n";
308 308
 
309
-				if (!@file_put_contents($debug_file, $buff, FILE_APPEND|LOCK_EX))
309
+				if (!@file_put_contents($debug_file, $buff, FILE_APPEND | LOCK_EX))
310 310
 				{
311 311
 					return;
312 312
 				}
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
 	{
323 323
 		header("Content-Type: text/xml; charset=UTF-8");
324 324
 		header("Expires: Mon, 26 Jul 1997 05:00:00 GMT");
325
-		header("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
325
+		header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
326 326
 		header("Cache-Control: no-store, no-cache, must-revalidate");
327 327
 		header("Cache-Control: post-check=0, pre-check=0", false);
328 328
 		header("Pragma: no-cache");
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
 	{
337 337
 		header("Content-Type: text/html; charset=UTF-8");
338 338
 		header("Expires: Mon, 26 Jul 1997 05:00:00 GMT");
339
-		header("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
339
+		header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
340 340
 		header("Cache-Control: no-store, no-cache, must-revalidate");
341 341
 		header("Cache-Control: post-check=0, pre-check=0", false);
342 342
 		header("Pragma: no-cache");
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 	{
351 351
 		header("Content-Type: text/html; charset=UTF-8");
352 352
 		header("Expires: Mon, 26 Jul 1997 05:00:00 GMT");
353
-		header("Last-Modified: " . gmdate("D, d M Y H:i:s") . " GMT");
353
+		header("Last-Modified: ".gmdate("D, d M Y H:i:s")." GMT");
354 354
 		header("Cache-Control: no-store, no-cache, must-revalidate");
355 355
 		header("Cache-Control: post-check=0, pre-check=0", false);
356 356
 		header("Pragma: no-cache");
Please login to merge, or discard this patch.
classes/file/FileHandler.class.php 3 patches
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 * @param string $target_dir Path of target dir
35 35
 	 * @param string $filter Regex to filter files. If file matches this regex, the file is not copied.
36 36
 	 * @param string $type If set as 'force'. Even if the file exists in target, the file is copied.
37
-	 * @return void
37
+	 * @return false|null
38 38
 	 */
39 39
 	function copyDir($source_dir, $target_dir, $filter = null, $type = null)
40 40
 	{
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 	 * This function creates directories recursively, which means that if ancestors of the target directory does not exist, they will be created too.
276 276
 	 *
277 277
 	 * @param string $path_string Path of target directory
278
-	 * @return bool TRUE if success. It might return nothing when ftp is used and connection to the ftp address failed.
278
+	 * @return boolean|null TRUE if success. It might return nothing when ftp is used and connection to the ftp address failed.
279 279
 	 */
280 280
 	function makeDir($path_string)
281 281
 	{
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
 	 * @param string $url The address of the target file
616 616
 	 * @param string $target_filename The location to store
617 617
 	 * @param string $body HTTP request body
618
-	 * @param string $timeout Connection timeout
618
+	 * @param integer $timeout Connection timeout
619 619
 	 * @param string $method GET/POST
620 620
 	 * @param string $content_type Content type header of HTTP request
621 621
 	 * @param string[] $headers Headers key value array.
@@ -636,8 +636,8 @@  discard block
 block discarded – undo
636 636
 	 * Convert size in string into numeric value
637 637
 	 *
638 638
 	 * @see self::filesize()
639
-	 * @param $val Size in string (ex., 10, 10K, 10M, 10G )
640
-	 * @return int converted size
639
+	 * @param string $val Size in string (ex., 10, 10K, 10M, 10G )
640
+	 * @return double converted size
641 641
 	 */
642 642
 	function returnBytes($val)
643 643
 	{
@@ -687,7 +687,7 @@  discard block
 block discarded – undo
687 687
 	 * @param int $resize_height Height to resize
688 688
 	 * @param string $target_type If $target_type is set (gif, jpg, png, bmp), result image will be saved as target type
689 689
 	 * @param string $thumbnail_type Thumbnail type(crop, ratio)
690
-	 * @return bool TRUE: success, FALSE: failed
690
+	 * @return null|boolean TRUE: success, FALSE: failed
691 691
 	 */
692 692
 	function createImageFile($source_file, $target_file, $resize_width = 0, $resize_height = 0, $target_type = '', $thumbnail_type = 'crop')
693 693
 	{
@@ -1000,7 +1000,7 @@  discard block
 block discarded – undo
1000 1000
 	 * Check file exists.
1001 1001
 	 *
1002 1002
 	 * @param string $filename Target file name
1003
-	 * @return bool Returns FALSE if the file does not exists, or Returns full path file(string).
1003
+	 * @return string|false Returns FALSE if the file does not exists, or Returns full path file(string).
1004 1004
 	 */
1005 1005
 	function exists($filename)
1006 1006
 	{
@@ -1011,8 +1011,8 @@  discard block
 block discarded – undo
1011 1011
 	/**
1012 1012
 	 * Check it is dir
1013 1013
 	 *
1014
-	 * @param string $dir Target dir path
1015
-	 * @return bool Returns FALSE if the dir is not dir, or Returns full path of dir(string).
1014
+	 * @param string $path
1015
+	 * @return string|false Returns FALSE if the dir is not dir, or Returns full path of dir(string).
1016 1016
 	 */
1017 1017
 	function isDir($path)
1018 1018
 	{
Please login to merge, or discard this patch.
Braces   +30 added lines, -45 removed lines patch added patch discarded remove patch
@@ -74,14 +74,12 @@  discard block
 block discarded – undo
74 74
 			if(is_dir($source_dir . $file))
75 75
 			{
76 76
 				self::copyDir($source_dir . $file, $target_dir . $file, $type);
77
-			}
78
-			else
77
+			} else
79 78
 			{
80 79
 				if($type == 'force')
81 80
 				{
82 81
 					@unlink($target_dir . $file);
83
-				}
84
-				else
82
+				} else
85 83
 				{
86 84
 					if(!file_exists($target_dir . $file))
87 85
 					{
@@ -379,15 +377,13 @@  discard block
 block discarded – undo
379 377
 				if(is_dir($target))
380 378
 				{
381 379
 					self::removeDir($target);
382
-				}
383
-				else
380
+				} else
384 381
 				{
385 382
 					unlink($target);
386 383
 				}
387 384
 			}
388 385
 			rmdir($path);
389
-		}
390
-		else
386
+		} else
391 387
 		{
392 388
 			unlink($path);
393 389
 		}
@@ -454,16 +450,16 @@  discard block
 block discarded – undo
454 450
 				if(is_dir($target))
455 451
 				{
456 452
 					self::removeFilesInDir($target);
457
-				}
458
-				else
453
+				} else
459 454
 				{
460 455
 					unlink($target);
461 456
 				}
462 457
 			}
463
-		}
464
-		else
458
+		} else
465 459
 		{
466
-			if(self::exists($path)) unlink($path);
460
+			if(self::exists($path)) {
461
+				unlink($path);
462
+			}
467 463
 		}
468 464
 
469 465
 	}
@@ -532,8 +528,7 @@  discard block
 block discarded – undo
532 528
 				$oRequest = new HTTP_Request(__PROXY_SERVER__);
533 529
 				$oRequest->setMethod('POST');
534 530
 				$oRequest->addPostData('arg', serialize(array('Destination' => $url, 'method' => $method, 'body' => $body, 'content_type' => $content_type, "headers" => $headers, "post_data" => $post_data)));
535
-			}
536
-			else
531
+			} else
537 532
 			{
538 533
 				$oRequest = new HTTP_Request($url);
539 534
 
@@ -547,8 +542,7 @@  discard block
 block discarded – undo
547 542
 							{
548 543
 								$oRequest->attach($observer);
549 544
 							}
550
-						}
551
-						else
545
+						} else
552 546
 						{
553 547
 							$oRequest->setConfig($key, $val);
554 548
 						}
@@ -559,8 +553,7 @@  discard block
 block discarded – undo
559 553
 					if(extension_loaded('curl'))
560 554
 					{
561 555
 						$oRequest->setConfig('adapter', 'curl');
562
-					}
563
-					elseif(version_compare(PHP_VERSION, '5.6', '<'))
556
+					} elseif(version_compare(PHP_VERSION, '5.6', '<'))
564 557
 					{
565 558
 						$oRequest->setConfig('ssl_verify_host', false);
566 559
 					}
@@ -591,20 +584,21 @@  discard block
 block discarded – undo
591 584
 						$oRequest->addPostData($key, $val);
592 585
 					}
593 586
 				}
594
-				if(!$content_type)
595
-					$oRequest->addHeader('Content-Type', 'text/html');
596
-				else
597
-					$oRequest->addHeader('Content-Type', $content_type);
587
+				if(!$content_type) {
588
+									$oRequest->addHeader('Content-Type', 'text/html');
589
+				} else {
590
+									$oRequest->addHeader('Content-Type', $content_type);
591
+				}
598 592
 				$oRequest->setMethod($method);
599
-				if($body)
600
-					$oRequest->setBody($body);
593
+				if($body) {
594
+									$oRequest->setBody($body);
595
+				}
601 596
 			}
602 597
 			
603 598
 			if(method_exists($oRequest, 'setConfig'))
604 599
 			{
605 600
 				$oRequest->setConfig('timeout', $timeout);
606
-			}
607
-			elseif(property_exists($oRequest, '_timeout'))
601
+			} elseif(property_exists($oRequest, '_timeout'))
608 602
 			{
609 603
 				$oRequest->_timeout = $timeout;
610 604
 			}
@@ -635,13 +629,11 @@  discard block
 block discarded – undo
635 629
 			if(isset($request_config['store_body']) && !$request_config['store_body'])
636 630
 			{
637 631
 				return TRUE;
638
-			}
639
-			else
632
+			} else
640 633
 			{
641 634
 				return $response;
642 635
 			}
643
-		}
644
-		catch(Exception $e)
636
+		} catch(Exception $e)
645 637
 		{
646 638
 			return NULL;
647 639
 		}
@@ -672,8 +664,7 @@  discard block
 block discarded – undo
672 664
 		try
673 665
 		{
674 666
 			$result = self::getRemoteResource($url, $body, $timeout, $method, $content_type, $headers, $cookies, $post_data, $request_config);
675
-		}
676
-		catch(Exception $e)
667
+		} catch(Exception $e)
677 668
 		{
678 669
 			return FALSE;
679 670
 		}
@@ -803,8 +794,7 @@  discard block
 block discarded – undo
803 794
 			$per = ($width_per > $height_per) ? $height_per : $width_per;
804 795
 			$resize_width = $width * $per;
805 796
 			$resize_height = $height * $per;
806
-		}
807
-		else
797
+		} else
808 798
 		{
809 799
 			$per = ($width_per < $height_per) ? $height_per : $width_per;
810 800
 		}
@@ -814,8 +804,7 @@  discard block
 block discarded – undo
814 804
 		if(function_exists('imagecreateTRUEcolor'))
815 805
 		{
816 806
 			$thumb = imagecreateTRUEcolor($resize_width, $resize_height);
817
-		}
818
-		else if(function_exists('imagecreate'))
807
+		} else if(function_exists('imagecreate'))
819 808
 		{
820 809
 			$thumb = imagecreate($resize_width, $resize_height);
821 810
 		}
@@ -880,8 +869,7 @@  discard block
 block discarded – undo
880 869
 		if(function_exists('imagecopyresampled'))
881 870
 		{
882 871
 			imagecopyresampled($thumb, $source, $x, $y, 0, 0, $new_width, $new_height, $width, $height);
883
-		}
884
-		else
872
+		} else
885 873
 		{
886 874
 			imagecopyresized($thumb, $source, $x, $y, 0, 0, $new_width, $new_height, $width, $height);
887 875
 		}
@@ -950,8 +938,7 @@  discard block
 block discarded – undo
950 938
 		if(is_array($arr) && count($arr) > 0)
951 939
 		{
952 940
 			return $arr;
953
-		}
954
-		else
941
+		} else
955 942
 		{
956 943
 			return array();
957 944
 		}
@@ -1001,12 +988,10 @@  discard block
 block discarded – undo
1001 988
 					$return[] = sprintf("%s=\"%s\"", $k, $v);
1002 989
 				}
1003 990
 				// value
1004
-			}
1005
-			else if(is_object($val))
991
+			} else if(is_object($val))
1006 992
 			{
1007 993
 				continue;
1008
-			}
1009
-			else
994
+			} else
1010 995
 			{
1011 996
 				$return[] = sprintf("%s=\"%s\"", $key, $val);
1012 997
 			}
Please login to merge, or discard this patch.
Spacing   +131 added lines, -131 removed lines patch added patch discarded remove patch
@@ -17,9 +17,9 @@  discard block
 block discarded – undo
17 17
 	 */
18 18
 	function getRealPath($source)
19 19
 	{
20
-		if(strlen($source) >= 2 && substr_compare($source, './', 0, 2) === 0)
20
+		if (strlen($source) >= 2 && substr_compare($source, './', 0, 2) === 0)
21 21
 		{
22
-			return _XE_PATH_ . substr($source, 2);
22
+			return _XE_PATH_.substr($source, 2);
23 23
 		}
24 24
 
25 25
 		return $source;
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	{
41 41
 		$source_dir = self::getRealPath($source_dir);
42 42
 		$target_dir = self::getRealPath($target_dir);
43
-		if(!is_dir($source_dir))
43
+		if (!is_dir($source_dir))
44 44
 		{
45 45
 			return FALSE;
46 46
 		}
@@ -48,44 +48,44 @@  discard block
 block discarded – undo
48 48
 		// generate when no target exists
49 49
 		self::makeDir($target_dir);
50 50
 
51
-		if(substr($source_dir, -1) != DIRECTORY_SEPARATOR)
51
+		if (substr($source_dir, -1) != DIRECTORY_SEPARATOR)
52 52
 		{
53 53
 			$source_dir .= DIRECTORY_SEPARATOR;
54 54
 		}
55 55
 
56
-		if(substr($target_dir, -1) != DIRECTORY_SEPARATOR)
56
+		if (substr($target_dir, -1) != DIRECTORY_SEPARATOR)
57 57
 		{
58 58
 			$target_dir .= DIRECTORY_SEPARATOR;
59 59
 		}
60 60
 
61 61
 		$oDir = dir($source_dir);
62
-		while($file = $oDir->read())
62
+		while ($file = $oDir->read())
63 63
 		{
64
-			if($file{0} == '.')
64
+			if ($file{0} == '.')
65 65
 			{
66 66
 				continue;
67 67
 			}
68 68
 
69
-			if($filter && preg_match($filter, $file))
69
+			if ($filter && preg_match($filter, $file))
70 70
 			{
71 71
 				continue;
72 72
 			}
73 73
 
74
-			if(is_dir($source_dir . $file))
74
+			if (is_dir($source_dir.$file))
75 75
 			{
76
-				self::copyDir($source_dir . $file, $target_dir . $file, $type);
76
+				self::copyDir($source_dir.$file, $target_dir.$file, $type);
77 77
 			}
78 78
 			else
79 79
 			{
80
-				if($type == 'force')
80
+				if ($type == 'force')
81 81
 				{
82
-					@unlink($target_dir . $file);
82
+					@unlink($target_dir.$file);
83 83
 				}
84 84
 				else
85 85
 				{
86
-					if(!file_exists($target_dir . $file))
86
+					if (!file_exists($target_dir.$file))
87 87
 					{
88
-						@copy($source_dir . $file, $target_dir . $file);
88
+						@copy($source_dir.$file, $target_dir.$file);
89 89
 					}
90 90
 				}
91 91
 			}
@@ -110,12 +110,12 @@  discard block
 block discarded – undo
110 110
 
111 111
 		self::makeDir($target_dir);
112 112
 
113
-		if($force == 'Y')
113
+		if ($force == 'Y')
114 114
 		{
115
-			@unlink($target_dir . DIRECTORY_SEPARATOR . $target);
115
+			@unlink($target_dir.DIRECTORY_SEPARATOR.$target);
116 116
 		}
117 117
 
118
-		@copy($source, $target_dir . DIRECTORY_SEPARATOR . $target);
118
+		@copy($source, $target_dir.DIRECTORY_SEPARATOR.$target);
119 119
 	}
120 120
 
121 121
 	/**
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	 */
127 127
 	function readFile($filename)
128 128
 	{
129
-		if(($filename = self::exists($filename)) === FALSE || filesize($filename) < 1)
129
+		if (($filename = self::exists($filename)) === FALSE || filesize($filename) < 1)
130 130
 		{
131 131
 			return;
132 132
 		}
@@ -149,12 +149,12 @@  discard block
 block discarded – undo
149 149
 		self::makeDir($pathinfo['dirname']);
150 150
 
151 151
 		$flags = 0;
152
-		if(strtolower($mode) == 'a')
152
+		if (strtolower($mode) == 'a')
153 153
 		{
154 154
 			$flags = FILE_APPEND;
155 155
 		}
156 156
 
157
-		@file_put_contents($filename, $buff, $flags|LOCK_EX);
157
+		@file_put_contents($filename, $buff, $flags | LOCK_EX);
158 158
 		@chmod($filename, 0644);
159 159
 	}
160 160
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 	 */
193 193
 	function moveFile($source, $target)
194 194
 	{
195
-		if(($source = self::exists($source)) !== FALSE)
195
+		if (($source = self::exists($source)) !== FALSE)
196 196
 		{
197 197
 			self::removeFile($target);
198 198
 			return self::rename($source, $target);
@@ -230,35 +230,35 @@  discard block
 block discarded – undo
230 230
 		$path = self::getRealPath($path);
231 231
 		$output = array();
232 232
 
233
-		if(substr($path, -1) != '/')
233
+		if (substr($path, -1) != '/')
234 234
 		{
235 235
 			$path .= '/';
236 236
 		}
237 237
 
238
-		if(!is_dir($path))
238
+		if (!is_dir($path))
239 239
 		{
240 240
 			return $output;
241 241
 		}
242 242
 
243 243
 		$files = scandir($path);
244
-		foreach($files as $file)
244
+		foreach ($files as $file)
245 245
 		{
246
-			if($file{0} == '.' || ($filter && !preg_match($filter, $file)))
246
+			if ($file{0} == '.' || ($filter && !preg_match($filter, $file)))
247 247
 			{
248 248
 				continue;
249 249
 			}
250 250
 
251
-			if($to_lower)
251
+			if ($to_lower)
252 252
 			{
253 253
 				$file = strtolower($file);
254 254
 			}
255 255
 
256
-			if($filter)
256
+			if ($filter)
257 257
 			{
258 258
 				$file = preg_replace($filter, '$1', $file);
259 259
 			}
260 260
 
261
-			if($concat_prefix)
261
+			if ($concat_prefix)
262 262
 			{
263 263
 				$file = sprintf('%s%s', str_replace(_XE_PATH_, '', $path), $file);
264 264
 			}
@@ -279,12 +279,12 @@  discard block
 block discarded – undo
279 279
 	 */
280 280
 	function makeDir($path_string)
281 281
 	{
282
-		if(self::exists($path_string) !== FALSE)
282
+		if (self::exists($path_string) !== FALSE)
283 283
 		{
284 284
 			return TRUE;
285 285
 		}
286 286
 
287
-		if(!ini_get('safe_mode'))
287
+		if (!ini_get('safe_mode'))
288 288
 		{
289 289
 			@mkdir($path_string, 0755, TRUE);
290 290
 			@chmod($path_string, 0755);
@@ -295,35 +295,35 @@  discard block
 block discarded – undo
295 295
 			static $oFtp = NULL;
296 296
 
297 297
 			$ftp_info = Context::getFTPInfo();
298
-			if($oFtp == NULL)
298
+			if ($oFtp == NULL)
299 299
 			{
300
-				if(!Context::isFTPRegisted())
300
+				if (!Context::isFTPRegisted())
301 301
 				{
302 302
 					return;
303 303
 				}
304 304
 
305
-				require_once(_XE_PATH_ . 'libs/ftp.class.php');
305
+				require_once(_XE_PATH_.'libs/ftp.class.php');
306 306
 				$oFtp = new ftp();
307
-				if(!$ftp_info->ftp_host)
307
+				if (!$ftp_info->ftp_host)
308 308
 				{
309 309
 					$ftp_info->ftp_host = "127.0.0.1";
310 310
 				}
311
-				if(!$ftp_info->ftp_port)
311
+				if (!$ftp_info->ftp_port)
312 312
 				{
313 313
 					$ftp_info->ftp_port = 21;
314 314
 				}
315
-				if(!$oFtp->ftp_connect($ftp_info->ftp_host, $ftp_info->ftp_port))
315
+				if (!$oFtp->ftp_connect($ftp_info->ftp_host, $ftp_info->ftp_port))
316 316
 				{
317 317
 					return;
318 318
 				}
319
-				if(!$oFtp->ftp_login($ftp_info->ftp_user, $ftp_info->ftp_password))
319
+				if (!$oFtp->ftp_login($ftp_info->ftp_user, $ftp_info->ftp_password))
320 320
 				{
321 321
 					$oFtp->ftp_quit();
322 322
 					return;
323 323
 				}
324 324
 			}
325 325
 
326
-			if(!($ftp_path = $ftp_info->ftp_root_path))
326
+			if (!($ftp_path = $ftp_info->ftp_root_path))
327 327
 			{
328 328
 				$ftp_path = DIRECTORY_SEPARATOR;
329 329
 			}
@@ -332,19 +332,19 @@  discard block
 block discarded – undo
332 332
 			$path_list = explode(DIRECTORY_SEPARATOR, $path_string);
333 333
 
334 334
 			$path = _XE_PATH_;
335
-			for($i = 0, $c = count($path_list); $i < $c; $i++)
335
+			for ($i = 0, $c = count($path_list); $i < $c; $i++)
336 336
 			{
337
-				if(!$path_list[$i])
337
+				if (!$path_list[$i])
338 338
 				{
339 339
 					continue;
340 340
 				}
341 341
 
342
-				$path .= $path_list[$i] . DIRECTORY_SEPARATOR;
343
-				$ftp_path .= $path_list[$i] . DIRECTORY_SEPARATOR;
344
-				if(!is_dir($path))
342
+				$path .= $path_list[$i].DIRECTORY_SEPARATOR;
343
+				$ftp_path .= $path_list[$i].DIRECTORY_SEPARATOR;
344
+				if (!is_dir($path))
345 345
 				{
346 346
 					$oFtp->ftp_mkdir($ftp_path);
347
-					$oFtp->ftp_site("CHMOD 777 " . $ftp_path);
347
+					$oFtp->ftp_site("CHMOD 777 ".$ftp_path);
348 348
 				}
349 349
 			}
350 350
 		}
@@ -360,23 +360,23 @@  discard block
 block discarded – undo
360 360
 	 */
361 361
 	function removeDir($path)
362 362
 	{
363
-		if(($path = self::isDir($path)) === FALSE)
363
+		if (($path = self::isDir($path)) === FALSE)
364 364
 		{
365 365
 			return;
366 366
 		}
367 367
 
368
-		if(self::isDir($path))
368
+		if (self::isDir($path))
369 369
 		{
370 370
 			$files = array_diff(scandir($path), array('..', '.'));
371 371
 
372
-			foreach($files as $file)
372
+			foreach ($files as $file)
373 373
 			{
374
-				if(($target = self::getRealPath($path . DIRECTORY_SEPARATOR . $file)) === FALSE)
374
+				if (($target = self::getRealPath($path.DIRECTORY_SEPARATOR.$file)) === FALSE)
375 375
 				{
376 376
 					continue;
377 377
 				}
378 378
 
379
-				if(is_dir($target))
379
+				if (is_dir($target))
380 380
 				{
381 381
 					self::removeDir($target);
382 382
 				}
@@ -401,22 +401,22 @@  discard block
 block discarded – undo
401 401
 	 */
402 402
 	function removeBlankDir($path)
403 403
 	{
404
-		if(($path = self::isDir($path)) === FALSE)
404
+		if (($path = self::isDir($path)) === FALSE)
405 405
 		{
406 406
 			return;
407 407
 		}
408 408
 
409 409
 		$files = array_diff(scandir($path), array('..', '.'));
410 410
 
411
-		if(count($files) < 1)
411
+		if (count($files) < 1)
412 412
 		{
413 413
 			rmdir($path);
414 414
 			return;
415 415
 		}
416 416
 
417
-		foreach($files as $file)
417
+		foreach ($files as $file)
418 418
 		{
419
-			if(($target = self::isDir($path . DIRECTORY_SEPARATOR . $file)) === FALSE)
419
+			if (($target = self::isDir($path.DIRECTORY_SEPARATOR.$file)) === FALSE)
420 420
 			{
421 421
 				continue;
422 422
 			}
@@ -435,23 +435,23 @@  discard block
 block discarded – undo
435 435
 	 */
436 436
 	function removeFilesInDir($path)
437 437
 	{
438
-		if(($path = self::getRealPath($path)) === FALSE)
438
+		if (($path = self::getRealPath($path)) === FALSE)
439 439
 		{
440 440
 			return;
441 441
 		}
442 442
 
443
-		if(is_dir($path))
443
+		if (is_dir($path))
444 444
 		{
445 445
 			$files = array_diff(scandir($path), array('..', '.'));
446 446
 
447
-			foreach($files as $file)
447
+			foreach ($files as $file)
448 448
 			{
449
-				if(($target = self::getRealPath($path . DIRECTORY_SEPARATOR . $file)) === FALSE)
449
+				if (($target = self::getRealPath($path.DIRECTORY_SEPARATOR.$file)) === FALSE)
450 450
 				{
451 451
 					continue;
452 452
 				}
453 453
 
454
-				if(is_dir($target))
454
+				if (is_dir($target))
455 455
 				{
456 456
 					self::removeFilesInDir($target);
457 457
 				}
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
 		}
464 464
 		else
465 465
 		{
466
-			if(self::exists($path)) unlink($path);
466
+			if (self::exists($path)) unlink($path);
467 467
 		}
468 468
 
469 469
 	}
@@ -477,22 +477,22 @@  discard block
 block discarded – undo
477 477
 	 */
478 478
 	function filesize($size)
479 479
 	{
480
-		if(!$size)
480
+		if (!$size)
481 481
 		{
482 482
 			return '0Byte';
483 483
 		}
484 484
 
485
-		if($size === 1)
485
+		if ($size === 1)
486 486
 		{
487 487
 			return '1Byte';
488 488
 		}
489 489
 
490
-		if($size < 1024)
490
+		if ($size < 1024)
491 491
 		{
492
-			return $size . 'Bytes';
492
+			return $size.'Bytes';
493 493
 		}
494 494
 
495
-		if($size >= 1024 && $size < 1024 * 1024)
495
+		if ($size >= 1024 && $size < 1024 * 1024)
496 496
 		{
497 497
 			return sprintf("%0.1fKB", $size / 1024);
498 498
 		}
@@ -517,7 +517,7 @@  discard block
 block discarded – undo
517 517
 	 */
518 518
 	function getRemoteResource($url, $body = null, $timeout = 3, $method = 'GET', $content_type = null, $headers = array(), $cookies = array(), $post_data = array(), $request_config = array())
519 519
 	{
520
-		require_once(_XE_PATH_ . 'libs/idna_convert/idna_convert.class.php');
520
+		require_once(_XE_PATH_.'libs/idna_convert/idna_convert.class.php');
521 521
 		$IDN = new idna_convert(array('idn_version' => 2008));
522 522
 		$url = $IDN->encode($url);
523 523
 
@@ -527,7 +527,7 @@  discard block
 block discarded – undo
527 527
 			require_once('HTTP/Request.php');
528 528
 
529 529
 			$parsed_url = parse_url(__PROXY_SERVER__);
530
-			if($parsed_url["host"] && $parsed_url["path"])
530
+			if ($parsed_url["host"] && $parsed_url["path"])
531 531
 			{
532 532
 				// Old style proxy server support (POST payload to proxy script)
533 533
 				$oRequest = new HTTP_Request(__PROXY_SERVER__);
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
 				$oRequest = new HTTP_Request($url);
540 540
 
541 541
 				// New style proxy server support (Use HTTP_Request2 native config format)
542
-				if($parsed_url['host'])
542
+				if ($parsed_url['host'])
543 543
 				{
544 544
 					$request_config['proxy_host'] = $parsed_url['host'];
545 545
 					$request_config['proxy_port'] = $parsed_url['port'] ? $parsed_url['port'] : '';
@@ -548,13 +548,13 @@  discard block
 block discarded – undo
548 548
 					$request_config['proxy_type'] = $parsed_url['scheme'] ? $parsed_url['scheme'] : 'http';
549 549
 				}
550 550
 
551
-				if(count($request_config) && method_exists($oRequest, 'setConfig'))
551
+				if (count($request_config) && method_exists($oRequest, 'setConfig'))
552 552
 				{
553
-					foreach($request_config as $key=>$val)
553
+					foreach ($request_config as $key=>$val)
554 554
 					{
555
-						if($key === 'observers')
555
+						if ($key === 'observers')
556 556
 						{
557
-							foreach($val as $observer)
557
+							foreach ($val as $observer)
558 558
 							{
559 559
 								$oRequest->attach($observer);
560 560
 							}
@@ -565,58 +565,58 @@  discard block
 block discarded – undo
565 565
 						}
566 566
 					}
567 567
 				}
568
-				if(method_exists($oRequest, 'setConfig'))
568
+				if (method_exists($oRequest, 'setConfig'))
569 569
 				{
570
-					if(extension_loaded('curl'))
570
+					if (extension_loaded('curl'))
571 571
 					{
572 572
 						$oRequest->setConfig('adapter', 'curl');
573 573
 					}
574
-					elseif(version_compare(PHP_VERSION, '5.6', '<'))
574
+					elseif (version_compare(PHP_VERSION, '5.6', '<'))
575 575
 					{
576 576
 						$oRequest->setConfig('ssl_verify_host', false);
577 577
 					}
578
-					if(file_exists(_XE_PATH_ . 'libs/cacert/cacert.pem'))
578
+					if (file_exists(_XE_PATH_.'libs/cacert/cacert.pem'))
579 579
 					{
580
-						$oRequest->setConfig('ssl_cafile', _XE_PATH_ . 'libs/cacert/cacert.pem');
580
+						$oRequest->setConfig('ssl_cafile', _XE_PATH_.'libs/cacert/cacert.pem');
581 581
 					}
582 582
 				}
583 583
 
584
-				if(count($headers) > 0)
584
+				if (count($headers) > 0)
585 585
 				{
586
-					foreach($headers as $key => $val)
586
+					foreach ($headers as $key => $val)
587 587
 					{
588 588
 						$oRequest->addHeader($key, $val);
589 589
 					}
590 590
 				}
591 591
 				$host = parse_url($url, PHP_URL_HOST);
592
-				if($cookies[$host])
592
+				if ($cookies[$host])
593 593
 				{
594
-					foreach($cookies[$host] as $key => $val)
594
+					foreach ($cookies[$host] as $key => $val)
595 595
 					{
596 596
 						$oRequest->addCookie($key, $val);
597 597
 					}
598 598
 				}
599
-				if(count($post_data) > 0)
599
+				if (count($post_data) > 0)
600 600
 				{
601
-					foreach($post_data as $key => $val)
601
+					foreach ($post_data as $key => $val)
602 602
 					{
603 603
 						$oRequest->addPostData($key, $val);
604 604
 					}
605 605
 				}
606
-				if(!$content_type)
606
+				if (!$content_type)
607 607
 					$oRequest->addHeader('Content-Type', 'text/html');
608 608
 				else
609 609
 					$oRequest->addHeader('Content-Type', $content_type);
610 610
 				$oRequest->setMethod($method);
611
-				if($body)
611
+				if ($body)
612 612
 					$oRequest->setBody($body);
613 613
 			}
614 614
 			
615
-			if(method_exists($oRequest, 'setConfig'))
615
+			if (method_exists($oRequest, 'setConfig'))
616 616
 			{
617 617
 				$oRequest->setConfig('timeout', $timeout);
618 618
 			}
619
-			elseif(property_exists($oRequest, '_timeout'))
619
+			elseif (property_exists($oRequest, '_timeout'))
620 620
 			{
621 621
 				$oRequest->_timeout = $timeout;
622 622
 			}
@@ -626,25 +626,25 @@  discard block
 block discarded – undo
626 626
 			$code = $oRequest->getResponseCode();
627 627
 			$header = $oRequest->getResponseHeader();
628 628
 			$response = $oRequest->getResponseBody();
629
-			if($c = $oRequest->getResponseCookies())
629
+			if ($c = $oRequest->getResponseCookies())
630 630
 			{
631
-				foreach($c as $k => $v)
631
+				foreach ($c as $k => $v)
632 632
 				{
633 633
 					$cookies[$host][$v['name']] = $v['value'];
634 634
 				}
635 635
 			}
636 636
 
637
-			if($code > 300 && $code < 399 && $header['location'])
637
+			if ($code > 300 && $code < 399 && $header['location'])
638 638
 			{
639 639
 				return self::getRemoteResource($header['location'], $body, $timeout, $method, $content_type, $headers, $cookies, $post_data);
640 640
 			}
641 641
 
642
-			if($code != 200)
642
+			if ($code != 200)
643 643
 			{
644 644
 				return;
645 645
 			}
646 646
 
647
-			if(isset($request_config['store_body']) && !$request_config['store_body'])
647
+			if (isset($request_config['store_body']) && !$request_config['store_body'])
648 648
 			{
649 649
 				return TRUE;
650 650
 			}
@@ -653,7 +653,7 @@  discard block
 block discarded – undo
653 653
 				return $response;
654 654
 			}
655 655
 		}
656
-		catch(Exception $e)
656
+		catch (Exception $e)
657 657
 		{
658 658
 			return NULL;
659 659
 		}
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
 		{
686 686
 			$result = self::getRemoteResource($url, $body, $timeout, $method, $content_type, $headers, $cookies, $post_data, $request_config);
687 687
 		}
688
-		catch(Exception $e)
688
+		catch (Exception $e)
689 689
 		{
690 690
 			return FALSE;
691 691
 		}
@@ -702,7 +702,7 @@  discard block
 block discarded – undo
702 702
 	function returnBytes($val)
703 703
 	{
704 704
 		$unit = strtoupper(substr($val, -1));
705
-		$val = (float)$val;
705
+		$val = (float) $val;
706 706
 
707 707
 		switch ($unit)
708 708
 		{
@@ -725,13 +725,13 @@  discard block
 block discarded – undo
725 725
 		$K64 = 65536;
726 726
 		$TWEAKFACTOR = 2.0;
727 727
 		$channels = $imageInfo['channels'];
728
-		if(!$channels)
728
+		if (!$channels)
729 729
 		{
730 730
 			$channels = 6; //for png
731 731
 		}
732
-		$memoryNeeded = round(($imageInfo[0] * $imageInfo[1] * $imageInfo['bits'] * $channels / 8 + $K64 ) * $TWEAKFACTOR);
732
+		$memoryNeeded = round(($imageInfo[0] * $imageInfo[1] * $imageInfo['bits'] * $channels / 8 + $K64) * $TWEAKFACTOR);
733 733
 		$availableMemory = self::returnBytes(ini_get('memory_limit')) - memory_get_usage();
734
-		if($availableMemory < $memoryNeeded)
734
+		if ($availableMemory < $memoryNeeded)
735 735
 		{
736 736
 			return FALSE;
737 737
 		}
@@ -758,30 +758,30 @@  discard block
 block discarded – undo
758 758
 		}
759 759
 
760 760
 		$target_file = self::getRealPath($target_file);
761
-		if(!$resize_width)
761
+		if (!$resize_width)
762 762
 		{
763 763
 			$resize_width = 100;
764 764
 		}
765 765
 
766
-		if(!$resize_height)
766
+		if (!$resize_height)
767 767
 		{
768 768
 			$resize_height = $resize_width;
769 769
 		}
770 770
 
771 771
 		// retrieve source image's information
772 772
 		$imageInfo = getimagesize($source_file);
773
-		if(!self::checkMemoryLoadImage($imageInfo))
773
+		if (!self::checkMemoryLoadImage($imageInfo))
774 774
 		{
775 775
 			return FALSE;
776 776
 		}
777 777
 
778 778
 		list($width, $height, $type, $attrs) = $imageInfo;
779
-		if($width < 1 || $height < 1)
779
+		if ($width < 1 || $height < 1)
780 780
 		{
781 781
 			return;
782 782
 		}
783 783
 
784
-		switch($type)
784
+		switch ($type)
785 785
 		{
786 786
 			case '1' :
787 787
 				$type = 'gif';
@@ -799,7 +799,7 @@  discard block
 block discarded – undo
799 799
 				return;
800 800
 		}
801 801
 
802
-		if(!$target_type)
802
+		if (!$target_type)
803 803
 		{
804 804
 			$target_type = $type;
805 805
 		}
@@ -810,7 +810,7 @@  discard block
 block discarded – undo
810 810
 		$height_per = ($resize_height > 0 && $height >= $resize_height) ? $resize_height / $height : 1;
811 811
 
812 812
 		$per = NULL;
813
-		if($thumbnail_type == 'ratio')
813
+		if ($thumbnail_type == 'ratio')
814 814
 		{
815 815
 			$per = ($width_per > $height_per) ? $height_per : $width_per;
816 816
 			$resize_width = $width * $per;
@@ -823,16 +823,16 @@  discard block
 block discarded – undo
823 823
 
824 824
 		// create temporary image with target size
825 825
 		$thumb = NULL;
826
-		if(function_exists('imagecreateTRUEcolor'))
826
+		if (function_exists('imagecreateTRUEcolor'))
827 827
 		{
828 828
 			$thumb = imagecreateTRUEcolor($resize_width, $resize_height);
829 829
 		}
830
-		else if(function_exists('imagecreate'))
830
+		else if (function_exists('imagecreate'))
831 831
 		{
832 832
 			$thumb = imagecreate($resize_width, $resize_height);
833 833
 		}
834 834
 
835
-		if(!$thumb)
835
+		if (!$thumb)
836 836
 		{
837 837
 			return FALSE;
838 838
 		}
@@ -841,37 +841,37 @@  discard block
 block discarded – undo
841 841
 
842 842
 		// create temporary image having original type
843 843
 		$source = NULL;
844
-		switch($type)
844
+		switch ($type)
845 845
 		{
846 846
 			case 'gif' :
847
-				if(function_exists('imagecreatefromgif'))
847
+				if (function_exists('imagecreatefromgif'))
848 848
 				{
849 849
 					$source = @imagecreatefromgif($source_file);
850 850
 				}
851 851
 				break;
852 852
 			case 'jpeg' :
853 853
 			case 'jpg' :
854
-				if(function_exists('imagecreatefromjpeg'))
854
+				if (function_exists('imagecreatefromjpeg'))
855 855
 				{
856 856
 					$source = @imagecreatefromjpeg($source_file);
857 857
 				}
858 858
 				break;
859 859
 			case 'png' :
860
-				if(function_exists('imagecreatefrompng'))
860
+				if (function_exists('imagecreatefrompng'))
861 861
 				{
862 862
 					$source = @imagecreatefrompng($source_file);
863 863
 				}
864 864
 				break;
865 865
 			case 'wbmp' :
866 866
 			case 'bmp' :
867
-				if(function_exists('imagecreatefromwbmp'))
867
+				if (function_exists('imagecreatefromwbmp'))
868 868
 				{
869 869
 					$source = @imagecreatefromwbmp($source_file);
870 870
 				}
871 871
 				break;
872 872
 		}
873 873
 
874
-		if(!$source)
874
+		if (!$source)
875 875
 		{
876 876
 			imagedestroy($thumb);
877 877
 			return FALSE;
@@ -883,13 +883,13 @@  discard block
 block discarded – undo
883 883
 
884 884
 		$x = 0;
885 885
 		$y = 0;
886
-		if($thumbnail_type == 'crop')
886
+		if ($thumbnail_type == 'crop')
887 887
 		{
888 888
 			$x = (int) ($resize_width / 2 - $new_width / 2);
889 889
 			$y = (int) ($resize_height / 2 - $new_height / 2);
890 890
 		}
891 891
 
892
-		if(function_exists('imagecopyresampled'))
892
+		if (function_exists('imagecopyresampled'))
893 893
 		{
894 894
 			imagecopyresampled($thumb, $source, $x, $y, 0, 0, $new_width, $new_height, $width, $height);
895 895
 		}
@@ -903,30 +903,30 @@  discard block
 block discarded – undo
903 903
 
904 904
 		// write into the file
905 905
 		$output = NULL;
906
-		switch($target_type)
906
+		switch ($target_type)
907 907
 		{
908 908
 			case 'gif' :
909
-				if(function_exists('imagegif'))
909
+				if (function_exists('imagegif'))
910 910
 				{
911 911
 					$output = imagegif($thumb, $target_file);
912 912
 				}
913 913
 				break;
914 914
 			case 'jpeg' :
915 915
 			case 'jpg' :
916
-				if(function_exists('imagejpeg'))
916
+				if (function_exists('imagejpeg'))
917 917
 				{
918 918
 					$output = imagejpeg($thumb, $target_file, 100);
919 919
 				}
920 920
 				break;
921 921
 			case 'png' :
922
-				if(function_exists('imagepng'))
922
+				if (function_exists('imagepng'))
923 923
 				{
924 924
 					$output = imagepng($thumb, $target_file, 9);
925 925
 				}
926 926
 				break;
927 927
 			case 'wbmp' :
928 928
 			case 'bmp' :
929
-				if(function_exists('imagewbmp'))
929
+				if (function_exists('imagewbmp'))
930 930
 				{
931 931
 					$output = imagewbmp($thumb, $target_file, 100);
932 932
 				}
@@ -936,7 +936,7 @@  discard block
 block discarded – undo
936 936
 		imagedestroy($thumb);
937 937
 		imagedestroy($source);
938 938
 
939
-		if(!$output)
939
+		if (!$output)
940 940
 		{
941 941
 			return FALSE;
942 942
 		}
@@ -954,12 +954,12 @@  discard block
 block discarded – undo
954 954
 	 */
955 955
 	function readIniFile($filename)
956 956
 	{
957
-		if(($filename = self::exists($filename)) === FALSE)
957
+		if (($filename = self::exists($filename)) === FALSE)
958 958
 		{
959 959
 			return FALSE;
960 960
 		}
961 961
 		$arr = parse_ini_file($filename, TRUE);
962
-		if(is_array($arr) && count($arr) > 0)
962
+		if (is_array($arr) && count($arr) > 0)
963 963
 		{
964 964
 			return $arr;
965 965
 		}
@@ -985,7 +985,7 @@  discard block
 block discarded – undo
985 985
 	 */
986 986
 	function writeIniFile($filename, $arr)
987 987
 	{
988
-		if(!is_array($arr) || count($arr) == 0)
988
+		if (!is_array($arr) || count($arr) == 0)
989 989
 		{
990 990
 			return FALSE;
991 991
 		}
@@ -1002,19 +1002,19 @@  discard block
 block discarded – undo
1002 1002
 	function _makeIniBuff($arr)
1003 1003
 	{
1004 1004
 		$return = array();
1005
-		foreach($arr as $key => $val)
1005
+		foreach ($arr as $key => $val)
1006 1006
 		{
1007 1007
 			// section
1008
-			if(is_array($val))
1008
+			if (is_array($val))
1009 1009
 			{
1010 1010
 				$return[] = sprintf("[%s]", $key);
1011
-				foreach($val as $k => $v)
1011
+				foreach ($val as $k => $v)
1012 1012
 				{
1013 1013
 					$return[] = sprintf("%s=\"%s\"", $k, $v);
1014 1014
 				}
1015 1015
 				// value
1016 1016
 			}
1017
-			else if(is_object($val))
1017
+			else if (is_object($val))
1018 1018
 			{
1019 1019
 				continue;
1020 1020
 			}
@@ -1089,15 +1089,15 @@  discard block
 block discarded – undo
1089 1089
 	function isWritableDir($path)
1090 1090
 	{
1091 1091
 		$path = self::getRealPath($path);
1092
-		if(is_dir($path)==FALSE)
1092
+		if (is_dir($path) == FALSE)
1093 1093
 		{
1094 1094
 			return FALSE;
1095 1095
 		}
1096 1096
 
1097
-		$checkFile = $path . '/_CheckWritableDir';
1097
+		$checkFile = $path.'/_CheckWritableDir';
1098 1098
 
1099 1099
 		$fp = fopen($checkFile, 'w');
1100
-		if(!is_resource($fp))
1100
+		if (!is_resource($fp))
1101 1101
 		{
1102 1102
 			return FALSE;
1103 1103
 		}
Please login to merge, or discard this patch.
classes/httprequest/XEHttpRequest.class.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 
52 52
 	/**
53 53
 	 * Mether to add key/value pair to the HTTP request header
54
-	 * @param int|string $key HTTP header element
54
+	 * @param string $key HTTP header element
55 55
 	 * @param string $value value string for HTTP header element
56 56
 	 * @return void
57 57
 	 */
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -25,8 +25,7 @@  discard block
 block discarded – undo
25 25
 		{
26 26
 			$mskin = 'default';
27 27
 			$template_path = sprintf('%sm.skins/%s', $this->module_path, $mskin);
28
-		}
29
-		else
28
+		} else
30 29
 		{
31 30
 			$template_path = sprintf('%sm.skins/%s', $this->module_path, $mskin);
32 31
 		}
@@ -40,8 +39,7 @@  discard block
 block discarded – undo
40 39
 			if(!$this->memberInfo)
41 40
 			{
42 41
 				Context::set('member_srl','');
43
-			}
44
-			else
42
+			} else
45 43
 			{
46 44
 				Context::set('member_info',$this->memberInfo);
47 45
 			}
Please login to merge, or discard this patch.
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 	 * constructor
42 42
 	 * @return void
43 43
 	 */
44
-	function XEHttpRequest($host, $port, $scheme='')
44
+	function XEHttpRequest($host, $port, $scheme = '')
45 45
 	{
46 46
 		$this->m_host = $host;
47 47
 		$this->m_port = $port;
@@ -76,11 +76,11 @@  discard block
 block discarded – undo
76 76
 		$this->addToHeader('Connection', 'close');
77 77
 
78 78
 		$method = strtoupper($method);
79
-		if(!$allow_methods)
79
+		if (!$allow_methods)
80 80
 		{
81 81
 			$allow_methods = explode(' ', 'GET POST PUT');
82 82
 		}
83
-		if(!in_array($method, $allow_methods))
83
+		if (!in_array($method, $allow_methods))
84 84
 		{
85 85
 			$method = $allow_methods[0];
86 86
 		}
@@ -89,12 +89,12 @@  discard block
 block discarded – undo
89 89
 		$timout = max((int) $timeout, 0);
90 90
 
91 91
 		// list of post variables
92
-		if(!is_array($post_vars))
92
+		if (!is_array($post_vars))
93 93
 		{
94 94
 			$post_vars = array();
95 95
 		}
96 96
 
97
-		if(FALSE && is_callable('curl_init'))
97
+		if (FALSE && is_callable('curl_init'))
98 98
 		{
99 99
 			return $this->sendWithCurl($target, $method, $timeout, $post_vars);
100 100
 		}
@@ -117,30 +117,30 @@  discard block
 block discarded – undo
117 117
 		static $crlf = "\r\n";
118 118
 
119 119
 		$scheme = '';
120
-		if($this->m_scheme=='https')
120
+		if ($this->m_scheme == 'https')
121 121
 		{
122 122
 			$scheme = 'ssl://';
123 123
 		}
124 124
 
125
-		$sock = @fsockopen($scheme . $this->m_host, $this->m_port, $errno, $errstr, $timeout);
126
-		if(!$sock)
125
+		$sock = @fsockopen($scheme.$this->m_host, $this->m_port, $errno, $errstr, $timeout);
126
+		if (!$sock)
127 127
 		{
128 128
 			return new Object(-1, 'socket_connect_failed');
129 129
 		}
130 130
 
131 131
 		$headers = $this->m_headers + array();
132
-		if(!isset($headers['Accept-Encoding']))
132
+		if (!isset($headers['Accept-Encoding']))
133 133
 		{
134 134
 			$headers['Accept-Encoding'] = 'identity';
135 135
 		}
136 136
 
137 137
 		// post body
138 138
 		$post_body = '';
139
-		if($method == 'POST' && count($post_vars))
139
+		if ($method == 'POST' && count($post_vars))
140 140
 		{
141
-			foreach($post_vars as $key => $value)
141
+			foreach ($post_vars as $key => $value)
142 142
 			{
143
-				$post_body .= urlencode($key) . '=' . urlencode($value) . '&';
143
+				$post_body .= urlencode($key).'='.urlencode($value).'&';
144 144
 			}
145 145
 			$post_body = substr($post_body, 0, -1);
146 146
 
@@ -149,35 +149,35 @@  discard block
 block discarded – undo
149 149
 		}
150 150
 
151 151
 		$request = "$method $target HTTP/1.1$crlf";
152
-		foreach($headers as $equiv => $content)
152
+		foreach ($headers as $equiv => $content)
153 153
 		{
154 154
 			$request .= "$equiv: $content$crlf";
155 155
 		}
156
-		$request .= $crlf . $post_body;
156
+		$request .= $crlf.$post_body;
157 157
 		fwrite($sock, $request);
158 158
 
159 159
 		list($httpver, $code, $status) = preg_split('/ +/', rtrim(fgets($sock)), 3);
160 160
 
161 161
 		// read response headers
162 162
 		$is_chunked = FALSE;
163
-		while(strlen(trim($line = fgets($sock))))
163
+		while (strlen(trim($line = fgets($sock))))
164 164
 		{
165 165
 			list($equiv, $content) = preg_split('/ *: */', rtrim($line), 2);
166
-			if(!strcasecmp($equiv, 'Transfer-Encoding') && $content == 'chunked')
166
+			if (!strcasecmp($equiv, 'Transfer-Encoding') && $content == 'chunked')
167 167
 			{
168 168
 				$is_chunked = TRUE;
169 169
 			}
170 170
 		}
171 171
 
172 172
 		$body = '';
173
-		while(!feof($sock))
173
+		while (!feof($sock))
174 174
 		{
175
-			if($is_chunked)
175
+			if ($is_chunked)
176 176
 			{
177 177
 				$chunk_size = hexdec(fgets($sock));
178
-				if($chunk_size)
178
+				if ($chunk_size)
179 179
 				{
180
-					$body .= fgets($sock, $chunk_size+1);
180
+					$body .= fgets($sock, $chunk_size + 1);
181 181
 				}
182 182
 			}
183 183
 			else
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 		curl_setopt($ch, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
220 220
 		curl_setopt($ch, CURLOPT_RETURNTRANSFER, TRUE);
221 221
 
222
-		switch($method)
222
+		switch ($method)
223 223
 		{
224 224
 			case 'GET': curl_setopt($ch, CURLOPT_HTTPGET, true);
225 225
 				break;
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
 		}
233 233
 
234 234
 		$arr_headers = array();
235
-		foreach($headers as $key => $value)
235
+		foreach ($headers as $key => $value)
236 236
 		{
237 237
 			$arr_headers[] = "$key: $value";
238 238
 		}
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 		curl_setopt($ch, CURLOPT_HTTPHEADER, $arr_headers);
241 241
 
242 242
 		$body = curl_exec($ch);
243
-		if(curl_errno($ch))
243
+		if (curl_errno($ch))
244 244
 		{
245 245
 			return new Object(-1, 'socket_connect_failed');
246 246
 		}
Please login to merge, or discard this patch.
classes/module/ModuleHandler.class.php 4 patches
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 
113 113
 	/**
114 114
 	 * Initialization. It finds the target module based on module, mid, document_srl, and prepares to execute an action
115
-	 * @return boolean true: OK, false: redirected
115
+	 * @return string|boolean true: OK, false: redirected
116 116
 	 * */
117 117
 	function init()
118 118
 	{
@@ -1128,6 +1128,10 @@  discard block
 block discarded – undo
1128 1128
 		return $GLOBALS['_loaded_module'][$module][$type][$kind];
1129 1129
 	}
1130 1130
 
1131
+	/**
1132
+	 * @param string $type
1133
+	 * @param string $kind
1134
+	 */
1131 1135
 	function _getModuleFilePath($module, $type, $kind, &$classPath, &$highClassFile, &$classFile, &$instanceName)
1132 1136
 	{
1133 1137
 		$classPath = ModuleHandler::getModulePath($module);
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -59,10 +59,10 @@
 block discarded – undo
59 59
 		$this->mid = $mid ? $mid : Context::get('mid');
60 60
 		$this->document_srl = $document_srl ? (int) $document_srl : (int) Context::get('document_srl');
61 61
 		$this->module_srl = $module_srl ? (int) $module_srl : (int) Context::get('module_srl');
62
-        if($entry = Context::get('entry'))
63
-        {
64
-            $this->entry = Context::convertEncodingStr($entry);
65
-        }
62
+		if($entry = Context::get('entry'))
63
+		{
64
+			$this->entry = Context::convertEncodingStr($entry);
65
+		}
66 66
 
67 67
 		// Validate variables to prevent XSS
68 68
 		$isInvalid = NULL;
Please login to merge, or discard this patch.
Braces   +30 added lines, -45 removed lines patch added patch discarded remove patch
@@ -107,7 +107,9 @@  discard block
 block discarded – undo
107 107
 		$called_position = 'before_module_init';
108 108
 		$oAddonController = getController('addon');
109 109
 		$addon_file = $oAddonController->getCacheFilePath(Mobile::isFromMobilePhone() ? 'mobile' : 'pc');
110
-		if(file_exists($addon_file)) include($addon_file);
110
+		if(file_exists($addon_file)) {
111
+			include($addon_file);
112
+		}
111 113
 	}
112 114
 
113 115
 	/**
@@ -160,8 +162,7 @@  discard block
 block discarded – undo
160 162
 			if(!$module_info)
161 163
 			{
162 164
 				unset($this->document_srl);
163
-			}
164
-			else
165
+			} else
165 166
 			{
166 167
 				// If it exists, compare mid based on the module information
167 168
 				// if mids are not matching, set it as the document's mid
@@ -173,8 +174,7 @@  discard block
 block discarded – undo
173 174
 						$this->mid = $module_info->mid;
174 175
 						header('location:' . getNotEncodedSiteUrl($site_module_info->domain, 'mid', $this->mid, 'document_srl', $this->document_srl));
175 176
 						return FALSE;
176
-					}
177
-					else
177
+					} else
178 178
 					{
179 179
 						$this->mid = $module_info->mid;
180 180
 						Context::set('mid', $this->mid);
@@ -225,15 +225,13 @@  discard block
 block discarded – undo
225 225
 				$site_info = $oModuleModel->getSiteInfo($module_info->site_srl);
226 226
 				$redirect_url = getNotEncodedSiteUrl($site_info->domain, 'mid', Context::get('mid'), 'document_srl', Context::get('document_srl'), 'module_srl', Context::get('module_srl'), 'entry', Context::get('entry'));
227 227
 				// If it's called from a virtual site, though it's not a module of the virtual site
228
-			}
229
-			else
228
+			} else
230 229
 			{
231 230
 				$db_info = Context::getDBInfo();
232 231
 				if(!$db_info->default_url)
233 232
 				{
234 233
 					return Context::getLang('msg_default_url_is_not_defined');
235
-				}
236
-				else
234
+				} else
237 235
 				{
238 236
 					$redirect_url = getNotEncodedSiteUrl($db_info->default_url, 'mid', Context::get('mid'), 'document_srl', Context::get('document_srl'), 'module_srl', Context::get('module_srl'), 'entry', Context::get('entry'));
239 237
 				}
@@ -258,8 +256,7 @@  discard block
 block discarded – undo
258 256
 			{
259 257
 				$oLayoutAdminModel = getAdminModel('layout');
260 258
 				$layoutSrl = $oLayoutAdminModel->getSiteDefaultLayout($viewType, $module_info->site_srl);
261
-			}
262
-			else
259
+			} else
263 260
 			{
264 261
 				$layoutSrl = $module_info->{$targetSrl};
265 262
 			}
@@ -386,8 +383,7 @@  discard block
 block discarded – undo
386 383
 			if(!$allowedMethod)
387 384
 			{
388 385
 				$allowedMethodList[0] = 'POST';
389
-			}
390
-			else
386
+			} else
391 387
 			{
392 388
 				$allowedMethodList = explode('|', strtoupper($allowedMethod));
393 389
 			}
@@ -445,8 +441,7 @@  discard block
 block discarded – undo
445 441
 				Mobile::setMobile(FALSE);
446 442
 				$oModule = $this->getModuleInstance($this->module, $type, $kind);
447 443
 			}
448
-		}
449
-		else
444
+		} else
450 445
 		{
451 446
 			// create a module instance
452 447
 			$oModule = $this->getModuleInstance($this->module, $type, $kind);
@@ -499,8 +494,7 @@  discard block
 block discarded – undo
499 494
 					$forward->type = $xml_info->action->{$this->act}->type;
500 495
 					$forward->ruleset = $xml_info->action->{$this->act}->ruleset;
501 496
 					$forward->act = $this->act;
502
-				}
503
-				else
497
+				} else
504 498
 				{
505 499
 					$this->error = 'msg_invalid_request';
506 500
 					$oMessageObject = ModuleHandler::getModuleInstance('message', $display_mode);
@@ -536,8 +530,7 @@  discard block
 block discarded – undo
536 530
 					if(!$allowedMethod)
537 531
 					{
538 532
 						$allowedMethodList[0] = 'POST';
539
-					}
540
-					else
533
+					} else
541 534
 					{
542 535
 						$allowedMethodList = explode('|', strtoupper($allowedMethod));
543 536
 					}
@@ -565,8 +558,7 @@  discard block
 block discarded – undo
565 558
 						Mobile::setMobile(FALSE);
566 559
 						$oModule = $this->getModuleInstance($forward->module, $type, $kind);
567 560
 					}
568
-				}
569
-				else
561
+				} else
570 562
 				{
571 563
 					$oModule = $this->getModuleInstance($forward->module, $type, $kind);
572 564
 				}
@@ -596,8 +588,7 @@  discard block
 block discarded – undo
596 588
 							$oModule->setLayoutPath("./modules/admin/tpl");
597 589
 							$oModule->setLayoutFile("layout.html");
598 590
 						}
599
-					}
600
-					else
591
+					} else
601 592
 					{
602 593
 						$this->_setInputErrorToContext();
603 594
 
@@ -621,8 +612,7 @@  discard block
 block discarded – undo
621 612
 						$oMessageObject->setMessage($this->error);
622 613
 						$oMessageObject->dispMessage();
623 614
 						return $oMessageObject;
624
-					}
625
-					else
615
+					} else
626 616
 					{
627 617
 						if(!$grant->is_admin && $this->module != $this->orig_module->module && $xml_info->permission->{$this->act} != 'manager')
628 618
 						{
@@ -636,12 +626,10 @@  discard block
 block discarded – undo
636 626
 						}
637 627
 					}
638 628
 				}
639
-			}
640
-			else if($xml_info->default_index_act && method_exists($oModule, $xml_info->default_index_act))
629
+			} else if($xml_info->default_index_act && method_exists($oModule, $xml_info->default_index_act))
641 630
 			{
642 631
 				$this->act = $xml_info->default_index_act;
643
-			}
644
-			else
632
+			} else
645 633
 			{
646 634
 				$this->error = 'msg_invalid_request';
647 635
 				$oModule->setError(-1);
@@ -739,7 +727,9 @@  discard block
 block discarded – undo
739 727
 			$message = $oModule->getMessage();
740 728
 			$messageType = $oModule->getMessageType();
741 729
 			$redirectUrl = $oModule->getRedirectUrl();
742
-			if($messageType == 'error') debugPrint($message, 'ERROR');
730
+			if($messageType == 'error') {
731
+				debugPrint($message, 'ERROR');
732
+			}
743 733
 
744 734
 			if(!$procResult)
745 735
 			{
@@ -749,8 +739,7 @@  discard block
 block discarded – undo
749 739
 					$redirectUrl = Context::get('error_return_url');
750 740
 				}
751 741
 				$this->_setInputValueToSession();
752
-			}
753
-			else
742
+			} else
754 743
 			{
755 744
 
756 745
 			}
@@ -898,8 +887,7 @@  discard block
 block discarded – undo
898 887
 					$oModule->setTemplatePath($oMessageObject->getTemplatePath());
899 888
 					$oModule->setTemplateFile($oMessageObject->getTemplateFile());
900 889
 					// Otherwise, set message instance as the target module
901
-				}
902
-				else
890
+				} else
903 891
 				{
904 892
 					$oModule = $oMessageObject;
905 893
 				}
@@ -911,8 +899,7 @@  discard block
 block discarded – undo
911 899
 			if(Mobile::isFromMobilePhone())
912 900
 			{
913 901
 				$layout_srl = $oModule->module_info->mlayout_srl;
914
-			}
915
-			else
902
+			} else
916 903
 			{
917 904
 				$layout_srl = $oModule->module_info->layout_srl;
918 905
 			}
@@ -971,8 +958,7 @@  discard block
 block discarded – undo
971 958
 									$menu->xml_file = str_replace('.xml.php', $homeMenuSrl . '.xml.php', $menu->xml_file);
972 959
 									$menu->php_file = str_replace('.php', $homeMenuSrl . '.php', $menu->php_file);
973 960
 									$layout_info->menu->{$menu_id}->menu_srl = $homeMenuSrl;
974
-								}
975
-								else
961
+								} else
976 962
 								{
977 963
 									$menu->xml_file = str_replace($menu->menu_srl, $homeMenuSrl, $menu->xml_file);
978 964
 									$menu->php_file = str_replace($menu->menu_srl, $homeMenuSrl, $menu->php_file);
@@ -1009,8 +995,7 @@  discard block
 block discarded – undo
1009 995
 				if($kind == 'admin')
1010 996
 				{
1011 997
 					$oModule->setLayoutFile('popup_layout');
1012
-				}
1013
-				else
998
+				} else
1014 999
 				{
1015 1000
 					$oModule->setLayoutPath('common/tpl');
1016 1001
 					$oModule->setLayoutFile('default_layout');
@@ -1144,13 +1129,11 @@  discard block
 block discarded – undo
1144 1129
 		{
1145 1130
 			$instanceName = '%s';
1146 1131
 			$classFile = '%s%s.%s.php';
1147
-		}
1148
-		elseif($kind == 'admin' && array_search($type, $types) < 3)
1132
+		} elseif($kind == 'admin' && array_search($type, $types) < 3)
1149 1133
 		{
1150 1134
 			$instanceName = '%sAdmin%s';
1151 1135
 			$classFile = '%s%s.admin.%s.php';
1152
-		}
1153
-		else
1136
+		} else
1154 1137
 		{
1155 1138
 			$instanceName = '%s%s';
1156 1139
 			$classFile = '%s%s.%s.php';
@@ -1213,7 +1196,9 @@  discard block
 block discarded – undo
1213 1196
 			$slowlog->caller = $trigger_name . '.' . $called_position;
1214 1197
 			$slowlog->called = $module . '.' . $called_method;
1215 1198
 			$slowlog->called_extension = $module;
1216
-			if($trigger_name != 'XE.writeSlowlog') writeSlowlog('trigger', $elapsed_time_trigger, $slowlog);
1199
+			if($trigger_name != 'XE.writeSlowlog') {
1200
+				writeSlowlog('trigger', $elapsed_time_trigger, $slowlog);
1201
+			}
1217 1202
 
1218 1203
 			if(is_object($output) && method_exists($output, 'toBool') && !$output->toBool())
1219 1204
 			{
Please login to merge, or discard this patch.
Spacing   +178 added lines, -178 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	function ModuleHandler($module = '', $act = '', $mid = '', $document_srl = '', $module_srl = '')
36 36
 	{
37 37
 		// If XE has not installed yet, set module as install
38
-		if(!Context::isInstalled())
38
+		if (!Context::isInstalled())
39 39
 		{
40 40
 			$this->module = 'install';
41 41
 			$this->act = Context::get('act');
@@ -43,10 +43,10 @@  discard block
 block discarded – undo
43 43
 		}
44 44
 
45 45
 		$oContext = Context::getInstance();
46
-		if($oContext->isSuccessInit == FALSE)
46
+		if ($oContext->isSuccessInit == FALSE)
47 47
 		{
48 48
 			$logged_info = Context::get('logged_info');
49
-			if($logged_info->is_admin != "Y")
49
+			if ($logged_info->is_admin != "Y")
50 50
 			{
51 51
 				$this->error = 'msg_invalid_request';
52 52
 				return;
@@ -59,26 +59,26 @@  discard block
 block discarded – undo
59 59
 		$this->mid = $mid ? $mid : Context::get('mid');
60 60
 		$this->document_srl = $document_srl ? (int) $document_srl : (int) Context::get('document_srl');
61 61
 		$this->module_srl = $module_srl ? (int) $module_srl : (int) Context::get('module_srl');
62
-        if($entry = Context::get('entry'))
62
+        if ($entry = Context::get('entry'))
63 63
         {
64 64
             $this->entry = Context::convertEncodingStr($entry);
65 65
         }
66 66
 
67 67
 		// Validate variables to prevent XSS
68 68
 		$isInvalid = NULL;
69
-		if($this->module && !preg_match("/^([a-z0-9\_\-]+)$/i", $this->module))
69
+		if ($this->module && !preg_match("/^([a-z0-9\_\-]+)$/i", $this->module))
70 70
 		{
71 71
 			$isInvalid = TRUE;
72 72
 		}
73
-		if($this->mid && !preg_match("/^([a-z0-9\_\-]+)$/i", $this->mid))
73
+		if ($this->mid && !preg_match("/^([a-z0-9\_\-]+)$/i", $this->mid))
74 74
 		{
75 75
 			$isInvalid = TRUE;
76 76
 		}
77
-		if($this->act && !preg_match("/^([a-z0-9\_\-]+)$/i", $this->act))
77
+		if ($this->act && !preg_match("/^([a-z0-9\_\-]+)$/i", $this->act))
78 78
 		{
79 79
 			$isInvalid = TRUE;
80 80
 		}
81
-		if($isInvalid)
81
+		if ($isInvalid)
82 82
 		{
83 83
 			htmlHeader();
84 84
 			echo Context::getLang("msg_invalid_request");
@@ -87,14 +87,14 @@  discard block
 block discarded – undo
87 87
 			exit;
88 88
 		}
89 89
 
90
-		if(isset($this->act) && (strlen($this->act) >= 4 && substr_compare($this->act, 'disp', 0, 4) === 0))
90
+		if (isset($this->act) && (strlen($this->act) >= 4 && substr_compare($this->act, 'disp', 0, 4) === 0))
91 91
 		{
92
-			if(Context::get('_use_ssl') == 'optional' && Context::isExistsSSLAction($this->act) && $_SERVER['HTTPS'] != 'on')
92
+			if (Context::get('_use_ssl') == 'optional' && Context::isExistsSSLAction($this->act) && $_SERVER['HTTPS'] != 'on')
93 93
 			{
94
-				if(Context::get('_https_port')!=null) {
95
-					header('location:https://' . $_SERVER['HTTP_HOST'] . ':' . Context::get('_https_port') . $_SERVER['REQUEST_URI']);
94
+				if (Context::get('_https_port') != null) {
95
+					header('location:https://'.$_SERVER['HTTP_HOST'].':'.Context::get('_https_port').$_SERVER['REQUEST_URI']);
96 96
 				} else {
97
-					header('location:https://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI']);
97
+					header('location:https://'.$_SERVER['HTTP_HOST'].$_SERVER['REQUEST_URI']);
98 98
 				}
99 99
 				return;
100 100
 			}
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
 
103 103
 		// call a trigger before moduleHandler init
104 104
 		ModuleHandler::triggerCall('moduleHandler.init', 'before', $this);
105
-		if(__ERROR_LOG__ == 1 && __DEBUG_OUTPUT__ == 0)
105
+		if (__ERROR_LOG__ == 1 && __DEBUG_OUTPUT__ == 0)
106 106
 		{
107
-			if(__DEBUG_PROTECT__ === 0 || __DEBUG_PROTECT__ === 1 && __DEBUG_PROTECT_IP__ == $_SERVER['REMOTE_ADDR'])
107
+			if (__DEBUG_PROTECT__ === 0 || __DEBUG_PROTECT__ === 1 && __DEBUG_PROTECT_IP__ == $_SERVER['REMOTE_ADDR'])
108 108
 			{
109 109
 				set_error_handler(array($this, 'xeErrorLog'), E_WARNING);
110 110
 				register_shutdown_function(array($this, 'shutdownHandler'));
@@ -115,40 +115,40 @@  discard block
 block discarded – undo
115 115
 		$called_position = 'before_module_init';
116 116
 		$oAddonController = getController('addon');
117 117
 		$addon_file = $oAddonController->getCacheFilePath(Mobile::isFromMobilePhone() ? 'mobile' : 'pc');
118
-		if(file_exists($addon_file)) include($addon_file);
118
+		if (file_exists($addon_file)) include($addon_file);
119 119
 	}
120 120
 
121 121
 	public static function xeErrorLog($errnumber, $errormassage, $errorfile, $errorline, $errorcontext)
122 122
 	{
123
-		if(($errnumber & 3) == 0 || error_reporting() == 0)
123
+		if (($errnumber & 3) == 0 || error_reporting() == 0)
124 124
 		{
125 125
 			return false;
126 126
 		}
127 127
 
128 128
 		set_error_handler(function() { }, ~0);
129 129
 
130
-		$debug_file = _XE_PATH_ . 'files/_debug_message.php';
131
-		if(!file_exists($debug_file))
130
+		$debug_file = _XE_PATH_.'files/_debug_message.php';
131
+		if (!file_exists($debug_file))
132 132
 		{
133 133
 			$print[] = '<?php exit() ?>';
134 134
 		}
135 135
 
136 136
 		$errorname = self::getErrorType($errnumber);
137
-		$print[] = '['.date('Y-m-d H:i:s').'] ' . $errorname . ' : ' . $errormassage;
137
+		$print[] = '['.date('Y-m-d H:i:s').'] '.$errorname.' : '.$errormassage;
138 138
 		$backtrace_args = defined('DEBUG_BACKTRACE_IGNORE_ARGS') ? \DEBUG_BACKTRACE_IGNORE_ARGS : 0;
139 139
 		$backtrace = debug_backtrace($backtrace_args);
140
-		if(count($backtrace) > 1 && $backtrace[1]['function'] === 'xeErrorLog' && !$backtrace[1]['class'])
140
+		if (count($backtrace) > 1 && $backtrace[1]['function'] === 'xeErrorLog' && !$backtrace[1]['class'])
141 141
 		{
142 142
 			array_shift($backtrace);
143 143
 		}
144 144
 
145
-		foreach($backtrace as $key => $value)
145
+		foreach ($backtrace as $key => $value)
146 146
 		{
147
-			$message = '    - ' . $value['file'] . ' : ' . $value['line'];
147
+			$message = '    - '.$value['file'].' : '.$value['line'];
148 148
 			$print[] = $message;
149 149
 		}
150 150
 		$print[] = PHP_EOL;
151
-		@file_put_contents($debug_file, implode(PHP_EOL, $print), FILE_APPEND|LOCK_EX);
151
+		@file_put_contents($debug_file, implode(PHP_EOL, $print), FILE_APPEND | LOCK_EX);
152 152
 		restore_error_handler();
153 153
 
154 154
 		return true;
@@ -164,21 +164,21 @@  discard block
 block discarded – undo
164 164
 
165 165
 		set_error_handler(function() { }, ~0);
166 166
 
167
-		$debug_file = _XE_PATH_ . 'files/_debug_message.php';
168
-		if(!file_exists($debug_file))
167
+		$debug_file = _XE_PATH_.'files/_debug_message.php';
168
+		if (!file_exists($debug_file))
169 169
 		{
170 170
 			$print[] = '<?php exit() ?>';
171 171
 		}
172 172
 
173 173
 		$errorname = self::getErrorType($errinfo['type']);
174 174
 		$print[] = '['.date('Y-m-d H:i:s').']';
175
-		$print[] = $errorname . ' : ' . $errinfo['message'];
175
+		$print[] = $errorname.' : '.$errinfo['message'];
176 176
 
177
-		$message = '    - ' . $errinfo['file'] . ' : ' . $errinfo['line'];
177
+		$message = '    - '.$errinfo['file'].' : '.$errinfo['line'];
178 178
 		$print[] = $message;
179 179
 
180 180
 		$print[] = PHP_EOL;
181
-		@file_put_contents($debug_file, implode(PHP_EOL, $print), FILE_APPEND|LOCK_EX);
181
+		@file_put_contents($debug_file, implode(PHP_EOL, $print), FILE_APPEND | LOCK_EX);
182 182
 		set_error_handler(array($this, 'dummyHandler'), ~0);
183 183
 
184 184
 		return true;
@@ -218,9 +218,9 @@  discard block
 block discarded – undo
218 218
 
219 219
 		// if success_return_url and error_return_url is incorrect
220 220
 		$urls = array(Context::get('success_return_url'), Context::get('error_return_url'));
221
-		foreach($urls as $url)
221
+		foreach ($urls as $url)
222 222
 		{
223
-			if(empty($url))
223
+			if (empty($url))
224 224
 			{
225 225
 				continue;
226 226
 			}
@@ -232,29 +232,29 @@  discard block
 block discarded – undo
232 232
 			$defaultUrlInfo = parse_url($dbInfo->default_url);
233 233
 			$defaultHost = $defaultUrlInfo['host'];
234 234
 		
235
-			if($host && ($host != $defaultHost && $host != $site_module_info->domain))
235
+			if ($host && ($host != $defaultHost && $host != $site_module_info->domain))
236 236
 			{
237 237
 				throw new Exception('msg_default_url_is_null');
238 238
 			}
239 239
 		}
240 240
 		
241
-		if(!$this->document_srl && $this->mid && $this->entry)
241
+		if (!$this->document_srl && $this->mid && $this->entry)
242 242
 		{
243 243
 			$oDocumentModel = getModel('document');
244 244
 			$this->document_srl = $oDocumentModel->getDocumentSrlByAlias($this->mid, $this->entry);
245
-			if($this->document_srl)
245
+			if ($this->document_srl)
246 246
 			{
247 247
 				Context::set('document_srl', $this->document_srl);
248 248
 			}
249 249
 		}
250 250
 
251 251
 		// Get module's information based on document_srl, if it's specified
252
-		if($this->document_srl)
252
+		if ($this->document_srl)
253 253
 		{
254 254
 			
255 255
 			$module_info = $oModuleModel->getModuleInfoByDocumentSrl($this->document_srl);
256 256
 			// If the document does not exist, remove document_srl
257
-			if(!$module_info)
257
+			if (!$module_info)
258 258
 			{
259 259
 				unset($this->document_srl);
260 260
 			}
@@ -262,13 +262,13 @@  discard block
 block discarded – undo
262 262
 			{
263 263
 				// If it exists, compare mid based on the module information
264 264
 				// if mids are not matching, set it as the document's mid
265
-				if(!$this->mid || ($this->mid != $module_info->mid))
265
+				if (!$this->mid || ($this->mid != $module_info->mid))
266 266
 				{
267 267
 					
268
-					if(Context::getRequestMethod() == 'GET')
268
+					if (Context::getRequestMethod() == 'GET')
269 269
 					{
270 270
 						$this->mid = $module_info->mid;
271
-						header('location:' . getNotEncodedSiteUrl($site_module_info->domain, 'mid', $this->mid, 'document_srl', $this->document_srl));
271
+						header('location:'.getNotEncodedSiteUrl($site_module_info->domain, 'mid', $this->mid, 'document_srl', $this->document_srl));
272 272
 						return FALSE;
273 273
 					}
274 274
 					else
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 					
280 280
 				}
281 281
 				// if requested module is different from one of the document, remove the module information retrieved based on the document number
282
-				if($this->module && $module_info->module != $this->module)
282
+				if ($this->module && $module_info->module != $this->module)
283 283
 				{
284 284
 					unset($module_info);
285 285
 				}
@@ -288,36 +288,36 @@  discard block
 block discarded – undo
288 288
 		}
289 289
 
290 290
 		// If module_info is not set yet, and there exists mid information, get module information based on the mid
291
-		if(!$module_info && $this->mid)
291
+		if (!$module_info && $this->mid)
292 292
 		{
293 293
 			$module_info = $oModuleModel->getModuleInfoByMid($this->mid, $site_module_info->site_srl);
294 294
 			//if($this->module && $module_info->module != $this->module) unset($module_info);
295 295
 		}
296 296
 
297 297
 		// redirect, if module_site_srl and site_srl are different
298
-		if(!$this->module && !$module_info && $site_module_info->site_srl == 0 && $site_module_info->module_site_srl > 0)
298
+		if (!$this->module && !$module_info && $site_module_info->site_srl == 0 && $site_module_info->module_site_srl > 0)
299 299
 		{
300 300
 			$site_info = $oModuleModel->getSiteInfo($site_module_info->module_site_srl);
301
-			header("location:" . getNotEncodedSiteUrl($site_info->domain, 'mid', $site_module_info->mid));
301
+			header("location:".getNotEncodedSiteUrl($site_info->domain, 'mid', $site_module_info->mid));
302 302
 			return FALSE;
303 303
 		}
304 304
 
305 305
 		// If module_info is not set still, and $module does not exist, find the default module
306
-		if(!$module_info && !$this->module && !$this->mid)
306
+		if (!$module_info && !$this->module && !$this->mid)
307 307
 		{
308 308
 			$module_info = $site_module_info;
309 309
 		}
310 310
 
311
-		if(!$module_info && !$this->module && $site_module_info->module_site_srl)
311
+		if (!$module_info && !$this->module && $site_module_info->module_site_srl)
312 312
 		{
313 313
 			$module_info = $site_module_info;
314 314
 		}
315 315
 
316 316
 		// redirect, if site_srl of module_info is different from one of site's module_info
317
-		if($module_info && $module_info->site_srl != $site_module_info->site_srl && !isCrawler())
317
+		if ($module_info && $module_info->site_srl != $site_module_info->site_srl && !isCrawler())
318 318
 		{
319 319
 			// If the module is of virtual site
320
-			if($module_info->site_srl)
320
+			if ($module_info->site_srl)
321 321
 			{
322 322
 				$site_info = $oModuleModel->getSiteInfo($module_info->site_srl);
323 323
 				$redirect_url = getNotEncodedSiteUrl($site_info->domain, 'mid', Context::get('mid'), 'document_srl', Context::get('document_srl'), 'module_srl', Context::get('module_srl'), 'entry', Context::get('entry'));
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
 			else
327 327
 			{
328 328
 				$db_info = Context::getDBInfo();
329
-				if(!$db_info->default_url)
329
+				if (!$db_info->default_url)
330 330
 				{
331 331
 					return Context::getLang('msg_default_url_is_not_defined');
332 332
 				}
@@ -335,12 +335,12 @@  discard block
 block discarded – undo
335 335
 					$redirect_url = getNotEncodedSiteUrl($db_info->default_url, 'mid', Context::get('mid'), 'document_srl', Context::get('document_srl'), 'module_srl', Context::get('module_srl'), 'entry', Context::get('entry'));
336 336
 				}
337 337
 			}
338
-			header("location:" . $redirect_url);
338
+			header("location:".$redirect_url);
339 339
 			return FALSE;
340 340
 		}
341 341
 
342 342
 		// If module info was set, retrieve variables from the module information
343
-		if($module_info)
343
+		if ($module_info)
344 344
 		{
345 345
 			$this->module = $module_info->module;
346 346
 			$this->mid = $module_info->mid;
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 			$targetSrl = (Mobile::isFromMobilePhone()) ? 'mlayout_srl' : 'layout_srl';
352 352
 
353 353
 			// use the site default layout.
354
-			if($module_info->{$targetSrl} == -1)
354
+			if ($module_info->{$targetSrl} == -1)
355 355
 			{
356 356
 				$oLayoutAdminModel = getAdminModel('layout');
357 357
 				$layoutSrl = $oLayoutAdminModel->getSiteDefaultLayout($viewType, $module_info->site_srl);
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
 		}
370 370
 
371 371
 		// Set module and mid into module_info
372
-		if(!isset($this->module_info))
372
+		if (!isset($this->module_info))
373 373
 		{
374 374
 			$this->module_info = new stdClass();
375 375
 		}
@@ -380,21 +380,21 @@  discard block
 block discarded – undo
380 380
 		$this->module_info->site_srl = $site_module_info->site_srl;
381 381
 
382 382
 		// Still no module? it's an error
383
-		if(!$this->module)
383
+		if (!$this->module)
384 384
 		{
385 385
 			$this->error = 'msg_module_is_not_exists';
386 386
 			$this->httpStatusCode = '404';
387 387
 		}
388 388
 
389 389
 		// If mid exists, set mid into context
390
-		if($this->mid)
390
+		if ($this->mid)
391 391
 		{
392 392
 			Context::set('mid', $this->mid, TRUE);
393 393
 		}
394 394
 		
395 395
 		// Call a trigger after moduleHandler init
396 396
 		$output = ModuleHandler::triggerCall('moduleHandler.init', 'after', $this->module_info);
397
-		if(!$output->toBool())
397
+		if (!$output->toBool())
398 398
 		{
399 399
 			$this->error = $output->getMessage();
400 400
 			return TRUE;
@@ -416,14 +416,14 @@  discard block
 block discarded – undo
416 416
 		$display_mode = Mobile::isFromMobilePhone() ? 'mobile' : 'view';
417 417
 
418 418
 		// If error occurred while preparation, return a message instance
419
-		if($this->error)
419
+		if ($this->error)
420 420
 		{
421 421
 			$this->_setInputErrorToContext();
422 422
 			$oMessageObject = ModuleHandler::getModuleInstance('message', $display_mode);
423 423
 			$oMessageObject->setError(-1);
424 424
 			$oMessageObject->setMessage($this->error);
425 425
 			$oMessageObject->dispMessage();
426
-			if($this->httpStatusCode)
426
+			if ($this->httpStatusCode)
427 427
 			{
428 428
 				$oMessageObject->setHttpStatusCode($this->httpStatusCode);
429 429
 			}
@@ -434,22 +434,22 @@  discard block
 block discarded – undo
434 434
 		$xml_info = $oModuleModel->getModuleActionXml($this->module);
435 435
 
436 436
 		// If not installed yet, modify act
437
-		if($this->module == "install")
437
+		if ($this->module == "install")
438 438
 		{
439
-			if(!$this->act || !$xml_info->action->{$this->act})
439
+			if (!$this->act || !$xml_info->action->{$this->act})
440 440
 			{
441 441
 				$this->act = $xml_info->default_index_act;
442 442
 			}
443 443
 		}
444 444
 
445 445
 		// if act exists, find type of the action, if not use default index act
446
-		if(!$this->act)
446
+		if (!$this->act)
447 447
 		{
448 448
 			$this->act = $xml_info->default_index_act;
449 449
 		}
450 450
 
451 451
 		// still no act means error
452
-		if(!$this->act)
452
+		if (!$this->act)
453 453
 		{
454 454
 			$this->error = 'msg_module_is_not_exists';
455 455
 			$this->httpStatusCode = '404';
@@ -459,7 +459,7 @@  discard block
 block discarded – undo
459 459
 			$oMessageObject->setError(-1);
460 460
 			$oMessageObject->setMessage($this->error);
461 461
 			$oMessageObject->dispMessage();
462
-			if($this->httpStatusCode)
462
+			if ($this->httpStatusCode)
463 463
 			{
464 464
 				$oMessageObject->setHttpStatusCode($this->httpStatusCode);
465 465
 			}
@@ -470,17 +470,17 @@  discard block
 block discarded – undo
470 470
 		$type = $xml_info->action->{$this->act}->type;
471 471
 		$ruleset = $xml_info->action->{$this->act}->ruleset;
472 472
 		$kind = stripos($this->act, 'admin') !== FALSE ? 'admin' : '';
473
-		if(!$kind && $this->module == 'admin')
473
+		if (!$kind && $this->module == 'admin')
474 474
 		{
475 475
 			$kind = 'admin';
476 476
 		}
477 477
 
478 478
 		// check REQUEST_METHOD in controller
479
-		if($type == 'controller')
479
+		if ($type == 'controller')
480 480
 		{
481 481
 			$allowedMethod = $xml_info->action->{$this->act}->method;
482 482
 
483
-			if(!$allowedMethod)
483
+			if (!$allowedMethod)
484 484
 			{
485 485
 				$allowedMethodList[0] = 'POST';
486 486
 			}
@@ -489,7 +489,7 @@  discard block
 block discarded – undo
489 489
 				$allowedMethodList = explode('|', strtoupper($allowedMethod));
490 490
 			}
491 491
 
492
-			if(!in_array(strtoupper($_SERVER['REQUEST_METHOD']), $allowedMethodList))
492
+			if (!in_array(strtoupper($_SERVER['REQUEST_METHOD']), $allowedMethodList))
493 493
 			{
494 494
 				$this->error = "msg_invalid_request";
495 495
 				$oMessageObject = ModuleHandler::getModuleInstance('message', $display_mode);
@@ -500,7 +500,7 @@  discard block
 block discarded – undo
500 500
 			}
501 501
 		}
502 502
 
503
-		if($this->module_info->use_mobile != "Y")
503
+		if ($this->module_info->use_mobile != "Y")
504 504
 		{
505 505
 			Mobile::setMobile(FALSE);
506 506
 		}
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 		$logged_info = Context::get('logged_info');
509 509
 
510 510
 		// check CSRF for POST actions
511
-		if($_SERVER['REQUEST_METHOD'] !== 'GET' && Context::isInstalled() && $this->act !== 'procFileUpload' && !checkCSRF()) {
511
+		if ($_SERVER['REQUEST_METHOD'] !== 'GET' && Context::isInstalled() && $this->act !== 'procFileUpload' && !checkCSRF()) {
512 512
 			$this->error = 'msg_invalid_request';
513 513
 			$oMessageObject = ModuleHandler::getModuleInstance('message', $display_mode);
514 514
 			$oMessageObject->setError(-1);
@@ -518,7 +518,7 @@  discard block
 block discarded – undo
518 518
 		}
519 519
 
520 520
 		// Admin ip
521
-		if($kind == 'admin' && $_SESSION['denied_admin'] == 'Y')
521
+		if ($kind == 'admin' && $_SESSION['denied_admin'] == 'Y')
522 522
 		{
523 523
 			$this->_setInputErrorToContext();
524 524
 			$this->error = "msg_not_permitted_act";
@@ -530,13 +530,13 @@  discard block
 block discarded – undo
530 530
 		}
531 531
 
532 532
 		// if(type == view, and case for using mobilephone)
533
-		if($type == "view" && Mobile::isFromMobilePhone() && Context::isInstalled())
533
+		if ($type == "view" && Mobile::isFromMobilePhone() && Context::isInstalled())
534 534
 		{
535 535
 			$orig_type = "view";
536 536
 			$type = "mobile";
537 537
 			// create a module instance
538 538
 			$oModule = $this->getModuleInstance($this->module, $type, $kind);
539
-			if(!is_object($oModule) || !method_exists($oModule, $this->act))
539
+			if (!is_object($oModule) || !method_exists($oModule, $this->act))
540 540
 			{
541 541
 				$type = $orig_type;
542 542
 				Mobile::setMobile(FALSE);
@@ -549,14 +549,14 @@  discard block
 block discarded – undo
549 549
 			$oModule = $this->getModuleInstance($this->module, $type, $kind);
550 550
 		}
551 551
 
552
-		if(!is_object($oModule))
552
+		if (!is_object($oModule))
553 553
 		{
554 554
 			$this->_setInputErrorToContext();
555 555
 			$oMessageObject = ModuleHandler::getModuleInstance('message', $display_mode);
556 556
 			$oMessageObject->setError(-1);
557 557
 			$oMessageObject->setMessage($this->error);
558 558
 			$oMessageObject->dispMessage();
559
-			if($this->httpStatusCode)
559
+			if ($this->httpStatusCode)
560 560
 			{
561 561
 				$oMessageObject->setHttpStatusCode($this->httpStatusCode);
562 562
 			}
@@ -564,10 +564,10 @@  discard block
 block discarded – undo
564 564
 		}
565 565
 
566 566
 		// If there is no such action in the module object
567
-		if(!isset($xml_info->action->{$this->act}) || !method_exists($oModule, $this->act))
567
+		if (!isset($xml_info->action->{$this->act}) || !method_exists($oModule, $this->act))
568 568
 		{
569 569
 
570
-			if(!Context::isInstalled())
570
+			if (!Context::isInstalled())
571 571
 			{
572 572
 				$this->_setInputErrorToContext();
573 573
 				$this->error = 'msg_invalid_request';
@@ -575,7 +575,7 @@  discard block
 block discarded – undo
575 575
 				$oMessageObject->setError(-1);
576 576
 				$oMessageObject->setMessage($this->error);
577 577
 				$oMessageObject->dispMessage();
578
-				if($this->httpStatusCode)
578
+				if ($this->httpStatusCode)
579 579
 				{
580 580
 					$oMessageObject->setHttpStatusCode($this->httpStatusCode);
581 581
 				}
@@ -584,12 +584,12 @@  discard block
 block discarded – undo
584 584
 
585 585
 			$forward = NULL;
586 586
 			// 1. Look for the module with action name
587
-			if(preg_match('/^([a-z]+)([A-Z])([a-z0-9\_]+)(.*)$/', $this->act, $matches))
587
+			if (preg_match('/^([a-z]+)([A-Z])([a-z0-9\_]+)(.*)$/', $this->act, $matches))
588 588
 			{
589
-				$module = strtolower($matches[2] . $matches[3]);
589
+				$module = strtolower($matches[2].$matches[3]);
590 590
 				$xml_info = $oModuleModel->getModuleActionXml($module);
591 591
 
592
-				if($xml_info->action->{$this->act} && ((stripos($this->act, 'admin') !== FALSE) || $xml_info->action->{$this->act}->standalone != 'false'))
592
+				if ($xml_info->action->{$this->act} && ((stripos($this->act, 'admin') !== FALSE) || $xml_info->action->{$this->act}->standalone != 'false'))
593 593
 				{
594 594
 					$forward = new stdClass();
595 595
 					$forward->module = $module;
@@ -609,12 +609,12 @@  discard block
 block discarded – undo
609 609
 				}
610 610
 			}
611 611
 
612
-			if(!$forward)
612
+			if (!$forward)
613 613
 			{
614 614
 				$forward = $oModuleModel->getActionForward($this->act);
615 615
 			}
616 616
 
617
-			if($forward->module && $forward->type && $forward->act && $forward->act == $this->act)
617
+			if ($forward->module && $forward->type && $forward->act && $forward->act == $this->act)
618 618
 			{
619 619
 				$kind = stripos($forward->act, 'admin') !== FALSE ? 'admin' : '';
620 620
 				$type = $forward->type;
@@ -626,11 +626,11 @@  discard block
 block discarded – undo
626 626
 
627 627
 				// SECISSUE also check foward act method
628 628
 				// check REQUEST_METHOD in controller
629
-				if($type == 'controller')
629
+				if ($type == 'controller')
630 630
 				{
631 631
 					$allowedMethod = $xml_info->action->{$forward->act}->method;
632 632
 
633
-					if(!$allowedMethod)
633
+					if (!$allowedMethod)
634 634
 					{
635 635
 						$allowedMethodList[0] = 'POST';
636 636
 					}
@@ -639,7 +639,7 @@  discard block
 block discarded – undo
639 639
 						$allowedMethodList = explode('|', strtoupper($allowedMethod));
640 640
 					}
641 641
 
642
-					if(!in_array(strtoupper($_SERVER['REQUEST_METHOD']), $allowedMethodList))
642
+					if (!in_array(strtoupper($_SERVER['REQUEST_METHOD']), $allowedMethodList))
643 643
 					{
644 644
 						$this->error = "msg_invalid_request";
645 645
 						$oMessageObject = ModuleHandler::getModuleInstance('message', $display_mode);
@@ -650,13 +650,13 @@  discard block
 block discarded – undo
650 650
 					}
651 651
 				}
652 652
 
653
-				if($type == "view" && Mobile::isFromMobilePhone())
653
+				if ($type == "view" && Mobile::isFromMobilePhone())
654 654
 				{
655 655
 					$orig_type = "view";
656 656
 					$type = "mobile";
657 657
 					// create a module instance
658 658
 					$oModule = $this->getModuleInstance($forward->module, $type, $kind);
659
-					if(!is_object($oModule) || !method_exists($oModule, $this->act))
659
+					if (!is_object($oModule) || !method_exists($oModule, $this->act))
660 660
 					{
661 661
 						$type = $orig_type;
662 662
 						Mobile::setMobile(FALSE);
@@ -668,25 +668,25 @@  discard block
 block discarded – undo
668 668
 					$oModule = $this->getModuleInstance($forward->module, $type, $kind);
669 669
 				}
670 670
 
671
-				if(!is_object($oModule))
671
+				if (!is_object($oModule))
672 672
 				{
673 673
 					$this->_setInputErrorToContext();
674 674
 					$oMessageObject = ModuleHandler::getModuleInstance('message', $display_mode);
675 675
 					$oMessageObject->setError(-1);
676 676
 					$oMessageObject->setMessage('msg_module_is_not_exists');
677 677
 					$oMessageObject->dispMessage();
678
-					if($this->httpStatusCode)
678
+					if ($this->httpStatusCode)
679 679
 					{
680 680
 						$oMessageObject->setHttpStatusCode($this->httpStatusCode);
681 681
 					}
682 682
 					return $oMessageObject;
683 683
 				}
684 684
 
685
-				if($this->module == "admin" && $type == "view")
685
+				if ($this->module == "admin" && $type == "view")
686 686
 				{
687
-					if($logged_info->is_admin == 'Y')
687
+					if ($logged_info->is_admin == 'Y')
688 688
 					{
689
-						if($this->act != 'dispLayoutAdminLayoutModify')
689
+						if ($this->act != 'dispLayoutAdminLayoutModify')
690 690
 						{
691 691
 							$oAdminView = getAdminView('admin');
692 692
 							$oAdminView->makeGnbUrl($forward->module);
@@ -706,10 +706,10 @@  discard block
 block discarded – undo
706 706
 						return $oMessageObject;
707 707
 					}
708 708
 				}
709
-				if($kind == 'admin')
709
+				if ($kind == 'admin')
710 710
 				{
711 711
 					$grant = $oModuleModel->getGrant($this->module_info, $logged_info);
712
-					if(!$grant->manager)
712
+					if (!$grant->manager)
713 713
 					{
714 714
 						$this->_setInputErrorToContext();
715 715
 						$this->error = 'msg_is_not_manager';
@@ -721,7 +721,7 @@  discard block
 block discarded – undo
721 721
 					}
722 722
 					else
723 723
 					{
724
-						if(!$grant->is_admin && $this->module != $this->orig_module->module && $xml_info->permission->{$this->act} != 'manager')
724
+						if (!$grant->is_admin && $this->module != $this->orig_module->module && $xml_info->permission->{$this->act} != 'manager')
725 725
 						{
726 726
 							$this->_setInputErrorToContext();
727 727
 							$this->error = 'msg_is_not_administrator';
@@ -734,7 +734,7 @@  discard block
 block discarded – undo
734 734
 					}
735 735
 				}
736 736
 			}
737
-			else if($xml_info->default_index_act && method_exists($oModule, $xml_info->default_index_act))
737
+			else if ($xml_info->default_index_act && method_exists($oModule, $xml_info->default_index_act))
738 738
 			{
739 739
 				$this->act = $xml_info->default_index_act;
740 740
 			}
@@ -748,16 +748,16 @@  discard block
 block discarded – undo
748 748
 		}
749 749
 
750 750
 		// ruleset check...
751
-		if(!empty($ruleset))
751
+		if (!empty($ruleset))
752 752
 		{
753 753
 			$rulesetModule = $forward->module ? $forward->module : $this->module;
754 754
 			$rulesetFile = $oModuleModel->getValidatorFilePath($rulesetModule, $ruleset, $this->mid);
755
-			if(!empty($rulesetFile))
755
+			if (!empty($rulesetFile))
756 756
 			{
757
-				if($_SESSION['XE_VALIDATOR_ERROR_LANG'])
757
+				if ($_SESSION['XE_VALIDATOR_ERROR_LANG'])
758 758
 				{
759 759
 					$errorLang = $_SESSION['XE_VALIDATOR_ERROR_LANG'];
760
-					foreach($errorLang as $key => $val)
760
+					foreach ($errorLang as $key => $val)
761 761
 					{
762 762
 						Context::setLang($key, $val);
763 763
 					}
@@ -766,7 +766,7 @@  discard block
 block discarded – undo
766 766
 
767 767
 				$Validator = new Validator($rulesetFile);
768 768
 				$result = $Validator->validate();
769
-				if(!$result)
769
+				if (!$result)
770 770
 				{
771 771
 					$lastError = $Validator->getLastError();
772 772
 					$returnUrl = Context::get('error_return_url');
@@ -798,26 +798,26 @@  discard block
 block discarded – undo
798 798
 				'dispLayoutPreviewWithModule' => 1
799 799
 		);
800 800
 		$db_use_mobile = Mobile::isMobileEnabled();
801
-		if($type == "view" && $this->module_info->use_mobile == "Y" && Mobile::isMobileCheckByAgent() && !isset($skipAct[Context::get('act')]) && $db_use_mobile === true)
801
+		if ($type == "view" && $this->module_info->use_mobile == "Y" && Mobile::isMobileCheckByAgent() && !isset($skipAct[Context::get('act')]) && $db_use_mobile === true)
802 802
 		{
803 803
 			global $lang;
804 804
 			$header = '<style>div.xe_mobile{opacity:0.7;margin:1em 0;padding:.5em;background:#333;border:1px solid #666;border-left:0;border-right:0}p.xe_mobile{text-align:center;margin:1em 0}a.xe_mobile{color:#ff0;font-weight:bold;font-size:24px}@media only screen and (min-width:500px){a.xe_mobile{font-size:15px}}</style>';
805
-			$footer = '<div class="xe_mobile"><p class="xe_mobile"><a class="xe_mobile" href="' . getUrl('m', '1') . '">' . $lang->msg_pc_to_mobile . '</a></p></div>';
805
+			$footer = '<div class="xe_mobile"><p class="xe_mobile"><a class="xe_mobile" href="'.getUrl('m', '1').'">'.$lang->msg_pc_to_mobile.'</a></p></div>';
806 806
 			Context::addHtmlHeader($header);
807 807
 			Context::addHtmlFooter($footer);
808 808
 		}
809 809
 
810
-		if($type == "view" && $kind != 'admin')
810
+		if ($type == "view" && $kind != 'admin')
811 811
 		{
812 812
 			$module_config = $oModuleModel->getModuleConfig('module');
813
-			if($module_config->htmlFooter)
813
+			if ($module_config->htmlFooter)
814 814
 			{
815 815
 				Context::addHtmlFooter($module_config->htmlFooter);
816 816
 			}
817
-			if($module_config->siteTitle)
817
+			if ($module_config->siteTitle)
818 818
 			{
819 819
 				$siteTitle = Context::getBrowserTitle();
820
-				if(!$siteTitle)
820
+				if (!$siteTitle)
821 821
 				{
822 822
 					Context::setBrowserTitle($module_config->siteTitle);
823 823
 				}
@@ -830,18 +830,18 @@  discard block
 block discarded – undo
830 830
 		$procResult = $oModule->proc();
831 831
 
832 832
 		$methodList = array('XMLRPC' => 1, 'JSON' => 1, 'JS_CALLBACK' => 1);
833
-		if(!$oModule->stop_proc && !isset($methodList[Context::getRequestMethod()]))
833
+		if (!$oModule->stop_proc && !isset($methodList[Context::getRequestMethod()]))
834 834
 		{
835 835
 			$error = $oModule->getError();
836 836
 			$message = $oModule->getMessage();
837 837
 			$messageType = $oModule->getMessageType();
838 838
 			$redirectUrl = $oModule->getRedirectUrl();
839
-			if($messageType == 'error') debugPrint($message, 'ERROR');
839
+			if ($messageType == 'error') debugPrint($message, 'ERROR');
840 840
 
841
-			if(!$procResult)
841
+			if (!$procResult)
842 842
 			{
843 843
 				$this->error = $message;
844
-				if(!$redirectUrl && Context::get('error_return_url'))
844
+				if (!$redirectUrl && Context::get('error_return_url'))
845 845
 				{
846 846
 					$redirectUrl = Context::get('error_return_url');
847 847
 				}
@@ -854,13 +854,13 @@  discard block
 block discarded – undo
854 854
 
855 855
 			$_SESSION['XE_VALIDATOR_ERROR'] = $error;
856 856
 			$_SESSION['XE_VALIDATOR_ID'] = Context::get('xe_validator_id');
857
-			if($message != 'success')
857
+			if ($message != 'success')
858 858
 			{
859 859
 				$_SESSION['XE_VALIDATOR_MESSAGE'] = $message;
860 860
 			}
861 861
 			$_SESSION['XE_VALIDATOR_MESSAGE_TYPE'] = $messageType;
862 862
 
863
-			if(Context::get('xeVirtualRequestMethod') != 'xml')
863
+			if (Context::get('xeVirtualRequestMethod') != 'xml')
864 864
 			{
865 865
 				$_SESSION['XE_VALIDATOR_RETURN_URL'] = $redirectUrl;
866 866
 			}
@@ -876,27 +876,27 @@  discard block
 block discarded – undo
876 876
 	 * */
877 877
 	function _setInputErrorToContext()
878 878
 	{
879
-		if($_SESSION['XE_VALIDATOR_ERROR'] && !Context::get('XE_VALIDATOR_ERROR'))
879
+		if ($_SESSION['XE_VALIDATOR_ERROR'] && !Context::get('XE_VALIDATOR_ERROR'))
880 880
 		{
881 881
 			Context::set('XE_VALIDATOR_ERROR', $_SESSION['XE_VALIDATOR_ERROR']);
882 882
 		}
883
-		if($_SESSION['XE_VALIDATOR_MESSAGE'] && !Context::get('XE_VALIDATOR_MESSAGE'))
883
+		if ($_SESSION['XE_VALIDATOR_MESSAGE'] && !Context::get('XE_VALIDATOR_MESSAGE'))
884 884
 		{
885 885
 			Context::set('XE_VALIDATOR_MESSAGE', $_SESSION['XE_VALIDATOR_MESSAGE']);
886 886
 		}
887
-		if($_SESSION['XE_VALIDATOR_MESSAGE_TYPE'] && !Context::get('XE_VALIDATOR_MESSAGE_TYPE'))
887
+		if ($_SESSION['XE_VALIDATOR_MESSAGE_TYPE'] && !Context::get('XE_VALIDATOR_MESSAGE_TYPE'))
888 888
 		{
889 889
 			Context::set('XE_VALIDATOR_MESSAGE_TYPE', $_SESSION['XE_VALIDATOR_MESSAGE_TYPE']);
890 890
 		}
891
-		if($_SESSION['XE_VALIDATOR_RETURN_URL'] && !Context::get('XE_VALIDATOR_RETURN_URL'))
891
+		if ($_SESSION['XE_VALIDATOR_RETURN_URL'] && !Context::get('XE_VALIDATOR_RETURN_URL'))
892 892
 		{
893 893
 			Context::set('XE_VALIDATOR_RETURN_URL', $_SESSION['XE_VALIDATOR_RETURN_URL']);
894 894
 		}
895
-		if($_SESSION['XE_VALIDATOR_ID'] && !Context::get('XE_VALIDATOR_ID'))
895
+		if ($_SESSION['XE_VALIDATOR_ID'] && !Context::get('XE_VALIDATOR_ID'))
896 896
 		{
897 897
 			Context::set('XE_VALIDATOR_ID', $_SESSION['XE_VALIDATOR_ID']);
898 898
 		}
899
-		if(count($_SESSION['INPUT_ERROR']))
899
+		if (count($_SESSION['INPUT_ERROR']))
900 900
 		{
901 901
 			Context::set('INPUT_ERROR', $_SESSION['INPUT_ERROR']);
902 902
 		}
@@ -926,7 +926,7 @@  discard block
 block discarded – undo
926 926
 	{
927 927
 		$requestVars = Context::getRequestVars();
928 928
 		unset($requestVars->act, $requestVars->mid, $requestVars->vid, $requestVars->success_return_url, $requestVars->error_return_url);
929
-		foreach($requestVars AS $key => $value)
929
+		foreach ($requestVars AS $key => $value)
930 930
 		{
931 931
 			$_SESSION['INPUT_ERROR'][$key] = $value;
932 932
 		}
@@ -940,41 +940,41 @@  discard block
 block discarded – undo
940 940
 	function displayContent($oModule = NULL)
941 941
 	{
942 942
 		// If the module is not set or not an object, set error
943
-		if(!$oModule || !is_object($oModule))
943
+		if (!$oModule || !is_object($oModule))
944 944
 		{
945 945
 			$this->error = 'msg_module_is_not_exists';
946 946
 			$this->httpStatusCode = '404';
947 947
 		}
948 948
 
949 949
 		// If connection to DB has a problem even though it's not install module, set error
950
-		if($this->module != 'install' && isset($GLOBALS['__DB__']) && $GLOBALS['__DB__'][Context::getDBType()]->isConnected() == FALSE)
950
+		if ($this->module != 'install' && isset($GLOBALS['__DB__']) && $GLOBALS['__DB__'][Context::getDBType()]->isConnected() == FALSE)
951 951
 		{
952 952
 			$this->error = 'msg_dbconnect_failed';
953 953
 		}
954 954
 
955 955
 		// Call trigger after moduleHandler proc
956 956
 		$output = ModuleHandler::triggerCall('moduleHandler.proc', 'after', $oModule);
957
-		if(!$output->toBool())
957
+		if (!$output->toBool())
958 958
 		{
959 959
 			$this->error = $output->getMessage();
960 960
 		}
961 961
 
962 962
 		// Use message view object, if HTML call
963 963
 		$methodList = array('XMLRPC' => 1, 'JSON' => 1, 'JS_CALLBACK' => 1);
964
-		if(!isset($methodList[Context::getRequestMethod()]))
964
+		if (!isset($methodList[Context::getRequestMethod()]))
965 965
 		{
966 966
 
967
-			if($_SESSION['XE_VALIDATOR_RETURN_URL'])
967
+			if ($_SESSION['XE_VALIDATOR_RETURN_URL'])
968 968
 			{
969 969
 				$display_handler = new DisplayHandler();
970 970
 				$display_handler->_debugOutput();
971 971
 
972
-				header('location:' . $_SESSION['XE_VALIDATOR_RETURN_URL']);
972
+				header('location:'.$_SESSION['XE_VALIDATOR_RETURN_URL']);
973 973
 				return;
974 974
 			}
975 975
 
976 976
 			// If error occurred, handle it
977
-			if($this->error)
977
+			if ($this->error)
978 978
 			{
979 979
 				// display content with message module instance
980 980
 				$type = Mobile::isFromMobilePhone() ? 'mobile' : 'view';
@@ -983,14 +983,14 @@  discard block
 block discarded – undo
983 983
 				$oMessageObject->setMessage($this->error);
984 984
 				$oMessageObject->dispMessage();
985 985
 
986
-				if($oMessageObject->getHttpStatusCode() && $oMessageObject->getHttpStatusCode() != '200')
986
+				if ($oMessageObject->getHttpStatusCode() && $oMessageObject->getHttpStatusCode() != '200')
987 987
 				{
988 988
 					$this->_setHttpStatusMessage($oMessageObject->getHttpStatusCode());
989 989
 					$oMessageObject->setTemplateFile('http_status_code');
990 990
 				}
991 991
 
992 992
 				// If module was called normally, change the templates of the module into ones of the message view module
993
-				if($oModule)
993
+				if ($oModule)
994 994
 				{
995 995
 					$oModule->setTemplatePath($oMessageObject->getTemplatePath());
996 996
 					$oModule->setTemplateFile($oMessageObject->getTemplateFile());
@@ -1005,7 +1005,7 @@  discard block
 block discarded – undo
1005 1005
 			}
1006 1006
 
1007 1007
 			// Check if layout_srl exists for the module
1008
-			if(Mobile::isFromMobilePhone())
1008
+			if (Mobile::isFromMobilePhone())
1009 1009
 			{
1010 1010
 				$layout_srl = $oModule->module_info->mlayout_srl;
1011 1011
 			}
@@ -1015,58 +1015,58 @@  discard block
 block discarded – undo
1015 1015
 			}
1016 1016
 
1017 1017
 			// if layout_srl is rollback by module, set default layout
1018
-			if($layout_srl == -1)
1018
+			if ($layout_srl == -1)
1019 1019
 			{
1020 1020
 				$viewType = (Mobile::isFromMobilePhone()) ? 'M' : 'P';
1021 1021
 				$oLayoutAdminModel = getAdminModel('layout');
1022 1022
 				$layout_srl = $oLayoutAdminModel->getSiteDefaultLayout($viewType, $oModule->module_info->site_srl);
1023 1023
 			}
1024 1024
 
1025
-			if($layout_srl && !$oModule->getLayoutFile())
1025
+			if ($layout_srl && !$oModule->getLayoutFile())
1026 1026
 			{
1027 1027
 
1028 1028
 				// If layout_srl exists, get information of the layout, and set the location of layout_path/ layout_file
1029 1029
 				$oLayoutModel = getModel('layout');
1030 1030
 				$layout_info = $oLayoutModel->getLayout($layout_srl);
1031
-				if($layout_info)
1031
+				if ($layout_info)
1032 1032
 				{
1033 1033
 
1034 1034
 					// Input extra_vars into $layout_info
1035
-					if($layout_info->extra_var_count)
1035
+					if ($layout_info->extra_var_count)
1036 1036
 					{
1037 1037
 
1038
-						foreach($layout_info->extra_var as $var_id => $val)
1038
+						foreach ($layout_info->extra_var as $var_id => $val)
1039 1039
 						{
1040
-							if($val->type == 'image')
1040
+							if ($val->type == 'image')
1041 1041
 							{
1042
-								if(strncmp('./files/attach/images/', $val->value, 22) === 0)
1042
+								if (strncmp('./files/attach/images/', $val->value, 22) === 0)
1043 1043
 								{
1044
-									$val->value = Context::getRequestUri() . substr($val->value, 2);
1044
+									$val->value = Context::getRequestUri().substr($val->value, 2);
1045 1045
 								}
1046 1046
 							}
1047 1047
 							$layout_info->{$var_id} = $val->value;
1048 1048
 						}
1049 1049
 					}
1050 1050
 					// Set menus into context
1051
-					if($layout_info->menu_count)
1051
+					if ($layout_info->menu_count)
1052 1052
 					{
1053
-						foreach($layout_info->menu as $menu_id => $menu)
1053
+						foreach ($layout_info->menu as $menu_id => $menu)
1054 1054
 						{
1055 1055
 							// set default menu set(included home menu)
1056
-							if(!$menu->menu_srl || $menu->menu_srl == -1)
1056
+							if (!$menu->menu_srl || $menu->menu_srl == -1)
1057 1057
 							{
1058 1058
 								$oMenuAdminController = getAdminController('menu');
1059 1059
 								$homeMenuCacheFile = $oMenuAdminController->getHomeMenuCacheFile();
1060 1060
 
1061
-								if(FileHandler::exists($homeMenuCacheFile))
1061
+								if (FileHandler::exists($homeMenuCacheFile))
1062 1062
 								{
1063 1063
 									include($homeMenuCacheFile);
1064 1064
 								}
1065 1065
 
1066
-								if(!$menu->menu_srl)
1066
+								if (!$menu->menu_srl)
1067 1067
 								{
1068
-									$menu->xml_file = str_replace('.xml.php', $homeMenuSrl . '.xml.php', $menu->xml_file);
1069
-									$menu->php_file = str_replace('.php', $homeMenuSrl . '.php', $menu->php_file);
1068
+									$menu->xml_file = str_replace('.xml.php', $homeMenuSrl.'.xml.php', $menu->xml_file);
1069
+									$menu->php_file = str_replace('.php', $homeMenuSrl.'.php', $menu->php_file);
1070 1070
 									$layout_info->menu->{$menu_id}->menu_srl = $homeMenuSrl;
1071 1071
 								}
1072 1072
 								else
@@ -1077,7 +1077,7 @@  discard block
 block discarded – undo
1077 1077
 							}
1078 1078
 
1079 1079
 							$php_file = FileHandler::exists($menu->php_file);
1080
-							if($php_file)
1080
+							if ($php_file)
1081 1081
 							{
1082 1082
 								include($php_file);
1083 1083
 							}
@@ -1093,17 +1093,17 @@  discard block
 block discarded – undo
1093 1093
 
1094 1094
 					// If layout was modified, use the modified version
1095 1095
 					$edited_layout = $oLayoutModel->getUserLayoutHtml($layout_info->layout_srl);
1096
-					if(file_exists($edited_layout))
1096
+					if (file_exists($edited_layout))
1097 1097
 					{
1098 1098
 						$oModule->setEditedLayoutFile($edited_layout);
1099 1099
 					}
1100 1100
 				}
1101 1101
 			}
1102 1102
 			$isLayoutDrop = Context::get('isLayoutDrop');
1103
-			if($isLayoutDrop)
1103
+			if ($isLayoutDrop)
1104 1104
 			{
1105 1105
 				$kind = stripos($this->act, 'admin') !== FALSE ? 'admin' : '';
1106
-				if($kind == 'admin')
1106
+				if ($kind == 'admin')
1107 1107
 				{
1108 1108
 					$oModule->setLayoutFile('popup_layout');
1109 1109
 				}
@@ -1141,7 +1141,7 @@  discard block
 block discarded – undo
1141 1141
 	function &getModuleInstance($module, $type = 'view', $kind = '')
1142 1142
 	{
1143 1143
 
1144
-		if(__DEBUG__ == 3)
1144
+		if (__DEBUG__ == 3)
1145 1145
 		{
1146 1146
 			$start_time = getMicroTime();
1147 1147
 		}
@@ -1151,51 +1151,51 @@  discard block
 block discarded – undo
1151 1151
 		$type = strtolower($type);
1152 1152
 
1153 1153
 		$kinds = array('svc' => 1, 'admin' => 1);
1154
-		if(!isset($kinds[$kind]))
1154
+		if (!isset($kinds[$kind]))
1155 1155
 		{
1156 1156
 			$kind = 'svc';
1157 1157
 		}
1158 1158
 
1159
-		$key = $module . '.' . ($kind != 'admin' ? '' : 'admin') . '.' . $type;
1159
+		$key = $module.'.'.($kind != 'admin' ? '' : 'admin').'.'.$type;
1160 1160
 
1161
-		if(is_array($GLOBALS['__MODULE_EXTEND__']) && array_key_exists($key, $GLOBALS['__MODULE_EXTEND__']))
1161
+		if (is_array($GLOBALS['__MODULE_EXTEND__']) && array_key_exists($key, $GLOBALS['__MODULE_EXTEND__']))
1162 1162
 		{
1163 1163
 			$module = $extend_module = $GLOBALS['__MODULE_EXTEND__'][$key];
1164 1164
 		}
1165 1165
 
1166 1166
 		// if there is no instance of the module in global variable, create a new one
1167
-		if(!isset($GLOBALS['_loaded_module'][$module][$type][$kind]))
1167
+		if (!isset($GLOBALS['_loaded_module'][$module][$type][$kind]))
1168 1168
 		{
1169 1169
 			ModuleHandler::_getModuleFilePath($module, $type, $kind, $class_path, $high_class_file, $class_file, $instance_name);
1170 1170
 
1171
-			if($extend_module && (!is_readable($high_class_file) || !is_readable($class_file)))
1171
+			if ($extend_module && (!is_readable($high_class_file) || !is_readable($class_file)))
1172 1172
 			{
1173 1173
 				$module = $parent_module;
1174 1174
 				ModuleHandler::_getModuleFilePath($module, $type, $kind, $class_path, $high_class_file, $class_file, $instance_name);
1175 1175
 			}
1176 1176
 
1177 1177
 			// Check if the base class and instance class exist
1178
-			if(!class_exists($module, true))
1178
+			if (!class_exists($module, true))
1179 1179
 			{
1180 1180
 				return NULL;
1181 1181
 			}
1182
-			if(!class_exists($instance_name, true))
1182
+			if (!class_exists($instance_name, true))
1183 1183
 			{
1184 1184
 				return NULL;
1185 1185
 			}
1186 1186
 
1187 1187
 			// Create an instance
1188 1188
 			$oModule = new $instance_name();
1189
-			if(!is_object($oModule))
1189
+			if (!is_object($oModule))
1190 1190
 			{
1191 1191
 				return NULL;
1192 1192
 			}
1193 1193
 
1194 1194
 			// Load language files for the class
1195
-			Context::loadLang($class_path . 'lang');
1196
-			if($extend_module)
1195
+			Context::loadLang($class_path.'lang');
1196
+			if ($extend_module)
1197 1197
 			{
1198
-				Context::loadLang(ModuleHandler::getModulePath($parent_module) . 'lang');
1198
+				Context::loadLang(ModuleHandler::getModulePath($parent_module).'lang');
1199 1199
 			}
1200 1200
 
1201 1201
 			// Set variables to the instance
@@ -1203,10 +1203,10 @@  discard block
 block discarded – undo
1203 1203
 			$oModule->setModulePath($class_path);
1204 1204
 
1205 1205
 			// If the module has a constructor, run it.
1206
-			if(!isset($GLOBALS['_called_constructor'][$instance_name]))
1206
+			if (!isset($GLOBALS['_called_constructor'][$instance_name]))
1207 1207
 			{
1208 1208
 				$GLOBALS['_called_constructor'][$instance_name] = TRUE;
1209
-				if(@method_exists($oModule, $instance_name))
1209
+				if (@method_exists($oModule, $instance_name))
1210 1210
 				{
1211 1211
 					$oModule->{$instance_name}();
1212 1212
 				}
@@ -1216,7 +1216,7 @@  discard block
 block discarded – undo
1216 1216
 			$GLOBALS['_loaded_module'][$module][$type][$kind] = $oModule;
1217 1217
 		}
1218 1218
 
1219
-		if(__DEBUG__ == 3)
1219
+		if (__DEBUG__ == 3)
1220 1220
 		{
1221 1221
 			$GLOBALS['__elapsed_class_load__'] += getMicroTime() - $start_time;
1222 1222
 		}
@@ -1232,17 +1232,17 @@  discard block
 block discarded – undo
1232 1232
 		$highClassFile = sprintf('%s%s%s.class.php', _XE_PATH_, $classPath, $module);
1233 1233
 		$highClassFile = FileHandler::getRealPath($highClassFile);
1234 1234
 
1235
-		$types = array('view','controller','model','api','wap','mobile','class');
1236
-		if(!in_array($type, $types))
1235
+		$types = array('view', 'controller', 'model', 'api', 'wap', 'mobile', 'class');
1236
+		if (!in_array($type, $types))
1237 1237
 		{
1238 1238
 			$type = $types[0];
1239 1239
 		}
1240
-		if($type == 'class')
1240
+		if ($type == 'class')
1241 1241
 		{
1242 1242
 			$instanceName = '%s';
1243 1243
 			$classFile = '%s%s.%s.php';
1244 1244
 		}
1245
-		elseif($kind == 'admin' && array_search($type, $types) < 3)
1245
+		elseif ($kind == 'admin' && array_search($type, $types) < 3)
1246 1246
 		{
1247 1247
 			$instanceName = '%sAdmin%s';
1248 1248
 			$classFile = '%s%s.admin.%s.php';
@@ -1267,26 +1267,26 @@  discard block
 block discarded – undo
1267 1267
 	function triggerCall($trigger_name, $called_position, &$obj)
1268 1268
 	{
1269 1269
 		// skip if not installed
1270
-		if(!Context::isInstalled())
1270
+		if (!Context::isInstalled())
1271 1271
 		{
1272 1272
 			return new Object();
1273 1273
 		}
1274 1274
 
1275 1275
 		$oModuleModel = getModel('module');
1276 1276
 		$triggers = $oModuleModel->getTriggers($trigger_name, $called_position);
1277
-		if(!$triggers || count($triggers) < 1)
1277
+		if (!$triggers || count($triggers) < 1)
1278 1278
 		{
1279 1279
 			return new Object();
1280 1280
 		}
1281 1281
 		
1282 1282
 		//store before trigger call time
1283 1283
 		$before_trigger_time = NULL;
1284
-		if(__LOG_SLOW_TRIGGER__> 0)
1284
+		if (__LOG_SLOW_TRIGGER__ > 0)
1285 1285
 		{
1286 1286
 			$before_trigger_time = microtime(true);
1287 1287
 		}
1288 1288
 
1289
-		foreach($triggers as $item)
1289
+		foreach ($triggers as $item)
1290 1290
 		{
1291 1291
 			$module = $item->module;
1292 1292
 			$type = $item->type;
@@ -1294,7 +1294,7 @@  discard block
 block discarded – undo
1294 1294
 
1295 1295
 			// todo why don't we call a normal class object ?
1296 1296
 			$oModule = getModule($module, $type);
1297
-			if(!$oModule || !method_exists($oModule, $called_method))
1297
+			if (!$oModule || !method_exists($oModule, $called_method))
1298 1298
 			{
1299 1299
 				continue;
1300 1300
 			}
@@ -1307,12 +1307,12 @@  discard block
 block discarded – undo
1307 1307
 			$elapsed_time_trigger = $after_each_trigger_time - $before_each_trigger_time;
1308 1308
 
1309 1309
 			$slowlog = new stdClass;
1310
-			$slowlog->caller = $trigger_name . '.' . $called_position;
1311
-			$slowlog->called = $module . '.' . $called_method;
1310
+			$slowlog->caller = $trigger_name.'.'.$called_position;
1311
+			$slowlog->called = $module.'.'.$called_method;
1312 1312
 			$slowlog->called_extension = $module;
1313
-			if($trigger_name != 'XE.writeSlowlog') writeSlowlog('trigger', $elapsed_time_trigger, $slowlog);
1313
+			if ($trigger_name != 'XE.writeSlowlog') writeSlowlog('trigger', $elapsed_time_trigger, $slowlog);
1314 1314
 
1315
-			if(is_object($output) && method_exists($output, 'toBool') && !$output->toBool())
1315
+			if (is_object($output) && method_exists($output, 'toBool') && !$output->toBool())
1316 1316
 			{
1317 1317
 				return $output;
1318 1318
 			}
@@ -1397,9 +1397,9 @@  discard block
 block discarded – undo
1397 1397
 			'511' => 'Network Authentication Required',
1398 1398
 		);
1399 1399
 		$statusMessage = $statusMessageList[$code];
1400
-		if(!$statusMessage)
1400
+		if (!$statusMessage)
1401 1401
 		{
1402
-			$statusMessage = 'HTTP ' . $code;
1402
+			$statusMessage = 'HTTP '.$code;
1403 1403
 		}
1404 1404
 
1405 1405
 		Context::set('http_status_code', $code);
Please login to merge, or discard this patch.
classes/module/ModuleObject.class.php 3 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 
142 142
 	/**
143 143
 	 * sett to set module information
144
-	 * @param object $module_info object containing module information
144
+	 * @param stdClass $module_info object containing module information
145 145
 	 * @param object $xml_info object containing module description
146 146
 	 * @return void
147 147
 	 * */
@@ -247,6 +247,7 @@  discard block
 block discarded – undo
247 247
 	/**
248 248
 	 * set the file name of the template file
249 249
 	 * @param string name of file
250
+	 * @param string $filename
250 251
 	 * @return void
251 252
 	 * */
252 253
 	function setTemplateFile($filename)
@@ -270,6 +271,7 @@  discard block
 block discarded – undo
270 271
 	/**
271 272
 	 * set the directory path of the template directory
272 273
 	 * @param string path of template directory.
274
+	 * @param string $path
273 275
 	 * @return void
274 276
 	 * */
275 277
 	function setTemplatePath($path)
@@ -325,6 +327,7 @@  discard block
 block discarded – undo
325 327
 	/**
326 328
 	 * set the file name of the layout file
327 329
 	 * @param string name of file
330
+	 * @param string $filename
328 331
 	 * @return void
329 332
 	 * */
330 333
 	function setLayoutFile($filename)
Please login to merge, or discard this patch.
Braces   +21 added lines, -12 removed lines patch added patch discarded remove patch
@@ -168,8 +168,7 @@  discard block
 block discarded – undo
168 168
 			{
169 169
 				$grant = $oModuleModel->getGrant($request_module, $logged_info);
170 170
 			}
171
-		}
172
-		else
171
+		} else
173 172
 		{
174 173
 			$grant = $oModuleModel->getGrant($module_info, $logged_info, $xml_info);
175 174
 			// have at least access grant
@@ -274,7 +273,9 @@  discard block
 block discarded – undo
274 273
 	 * */
275 274
 	function setTemplatePath($path)
276 275
 	{
277
-		if(!$path) return;
276
+		if(!$path) {
277
+			return;
278
+		}
278 279
 
279 280
 		if((strlen($path) >= 1 && substr_compare($path, '/', 0, 1) !== 0) && (strlen($path) >= 2 && substr_compare($path, './', 0, 2) !== 0))
280 281
 		{
@@ -304,7 +305,9 @@  discard block
 block discarded – undo
304 305
 	 * */
305 306
 	function setEditedLayoutFile($filename)
306 307
 	{
307
-		if(!$filename) return;
308
+		if(!$filename) {
309
+			return;
310
+		}
308 311
 
309 312
 		if(substr_compare($filename, '.html', -5) !== 0)
310 313
 		{
@@ -329,7 +332,9 @@  discard block
 block discarded – undo
329 332
 	 * */
330 333
 	function setLayoutFile($filename)
331 334
 	{
332
-		if(!$filename) return;
335
+		if(!$filename) {
336
+			return;
337
+		}
333 338
 
334 339
 		if(substr_compare($filename, '.html', -5) !== 0)
335 340
 		{
@@ -353,7 +358,9 @@  discard block
 block discarded – undo
353 358
 	 * */
354 359
 	function setLayoutPath($path)
355 360
 	{
356
-		if(!$path) return;
361
+		if(!$path) {
362
+			return;
363
+		}
357 364
 
358 365
 		if((strlen($path) >= 1 && substr_compare($path, '/', 0, 1) !== 0) && (strlen($path) >= 2 && substr_compare($path, './', 0, 2) !== 0))
359 366
 		{
@@ -401,7 +408,9 @@  discard block
 block discarded – undo
401 408
 		$called_position = 'before_module_proc';
402 409
 		$oAddonController = getController('addon');
403 410
 		$addon_file = $oAddonController->getCacheFilePath(Mobile::isFromMobilePhone() ? "mobile" : "pc");
404
-		if(FileHandler::exists($addon_file)) include($addon_file);
411
+		if(FileHandler::exists($addon_file)) {
412
+			include($addon_file);
413
+		}
405 414
 
406 415
 		if(isset($this->xml_info->action->{$this->act}) && method_exists($this, $this->act))
407 416
 		{
@@ -425,8 +434,7 @@  discard block
 block discarded – undo
425 434
 				if($this->module == 'page')
426 435
 				{
427 436
 					$this->module_info->{$valueName} = $skinName;
428
-				}
429
-				else
437
+				} else
430 438
 				{
431 439
 					$isTemplatPath = (strpos($this->getTemplatePath(), '/tpl/') !== FALSE);
432 440
 					if(!$isTemplatPath)
@@ -441,8 +449,7 @@  discard block
 block discarded – undo
441 449
 			Context::set('module_info', $this->module_info);
442 450
 			// Run
443 451
 			$output = $this->{$this->act}();
444
-		}
445
-		else
452
+		} else
446 453
 		{
447 454
 			return FALSE;
448 455
 		}
@@ -460,7 +467,9 @@  discard block
 block discarded – undo
460 467
 		$called_position = 'after_module_proc';
461 468
 		$oAddonController = getController('addon');
462 469
 		$addon_file = $oAddonController->getCacheFilePath(Mobile::isFromMobilePhone() ? "mobile" : "pc");
463
-		if(FileHandler::exists($addon_file)) include($addon_file);
470
+		if(FileHandler::exists($addon_file)) {
471
+			include($addon_file);
472
+		}
464 473
 
465 474
 		if(is_a($output, 'Object') || is_subclass_of($output, 'Object'))
466 475
 		{
Please login to merge, or discard this patch.
Spacing   +41 added lines, -41 removed lines patch added patch discarded remove patch
@@ -44,9 +44,9 @@  discard block
 block discarded – undo
44 44
 	 * */
45 45
 	function setModulePath($path)
46 46
 	{
47
-		if(substr_compare($path, '/', -1) !== 0)
47
+		if (substr_compare($path, '/', -1) !== 0)
48 48
 		{
49
-			$path.='/';
49
+			$path .= '/';
50 50
 		}
51 51
 		$this->module_path = $path;
52 52
 	}
@@ -60,12 +60,12 @@  discard block
 block discarded – undo
60 60
 	function setRedirectUrl($url = './', $output = NULL)
61 61
 	{
62 62
 		$ajaxRequestMethod = array_flip($this->ajaxRequestMethod);
63
-		if(!isset($ajaxRequestMethod[Context::getRequestMethod()]))
63
+		if (!isset($ajaxRequestMethod[Context::getRequestMethod()]))
64 64
 		{
65 65
 			$this->add('redirect_url', $url);
66 66
 		}
67 67
 
68
-		if($output !== NULL && is_object($output))
68
+		if ($output !== NULL && is_object($output))
69 69
 		{
70 70
 			return $output;
71 71
 		}
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 	{
111 111
 		$type = $this->get('message_type');
112 112
 		$typeList = array('error' => 1, 'info' => 1, 'update' => 1);
113
-		if(!isset($typeList[$type]))
113
+		if (!isset($typeList[$type]))
114 114
 		{
115 115
 			$type = $this->getError() ? 'error' : 'info';
116 116
 		}
@@ -161,10 +161,10 @@  discard block
 block discarded – undo
161 161
 		$oModuleModel = getModel('module');
162 162
 		// permission settings. access, manager(== is_admin) are fixed and privilege name in XE
163 163
 		$module_srl = Context::get('module_srl');
164
-		if(!$module_info->mid && !is_array($module_srl) && preg_match('/^([0-9]+)$/', $module_srl))
164
+		if (!$module_info->mid && !is_array($module_srl) && preg_match('/^([0-9]+)$/', $module_srl))
165 165
 		{
166 166
 			$request_module = $oModuleModel->getModuleInfoByModuleSrl($module_srl);
167
-			if($request_module->module_srl == $module_srl)
167
+			if ($request_module->module_srl == $module_srl)
168 168
 			{
169 169
 				$grant = $oModuleModel->getGrant($request_module, $logged_info);
170 170
 			}
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 		{
174 174
 			$grant = $oModuleModel->getGrant($module_info, $logged_info, $xml_info);
175 175
 			// have at least access grant
176
-			if(substr_count($this->act, 'Member') || substr_count($this->act, 'Communication'))
176
+			if (substr_count($this->act, 'Member') || substr_count($this->act, 'Communication'))
177 177
 			{
178 178
 				$grant->access = 1;
179 179
 			}
@@ -181,24 +181,24 @@  discard block
 block discarded – undo
181 181
 		// display no permission if the current module doesn't have an access privilege
182 182
 		//if(!$grant->access) return $this->stop("msg_not_permitted");
183 183
 		// checks permission and action if you don't have an admin privilege
184
-		if(!$grant->manager)
184
+		if (!$grant->manager)
185 185
 		{
186 186
 			// get permission types(guest, member, manager, root) of the currently requested action
187 187
 			$permission_target = $xml_info->permission->{$this->act};
188 188
 			// check manager if a permission in module.xml otherwise action if no permission
189
-			if(!$permission_target && substr_count($this->act, 'Admin'))
189
+			if (!$permission_target && substr_count($this->act, 'Admin'))
190 190
 			{
191 191
 				$permission_target = 'manager';
192 192
 			}
193 193
 			// Check permissions
194
-			switch($permission_target)
194
+			switch ($permission_target)
195 195
 			{
196 196
 				case 'root' :
197 197
 				case 'manager' :
198 198
 					$this->stop('msg_is_not_administrator');
199 199
 					return;
200 200
 				case 'member' :
201
-					if(!$is_logged)
201
+					if (!$is_logged)
202 202
 					{
203 203
 						$this->stop('msg_not_permitted_act');
204 204
 						return;
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 
214 214
 		$this->module_config = $oModuleModel->getModuleConfig($this->module, $module_info->site_srl);
215 215
 
216
-		if(method_exists($this, 'init'))
216
+		if (method_exists($this, 'init'))
217 217
 		{
218 218
 			$this->init();
219 219
 		}
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
 	 * */
252 252
 	function setTemplateFile($filename)
253 253
 	{
254
-		if(isset($filename) && substr_compare($filename, '.html', -5) !== 0)
254
+		if (isset($filename) && substr_compare($filename, '.html', -5) !== 0)
255 255
 		{
256 256
 			$filename .= '.html';
257 257
 		}
@@ -274,14 +274,14 @@  discard block
 block discarded – undo
274 274
 	 * */
275 275
 	function setTemplatePath($path)
276 276
 	{
277
-		if(!$path) return;
277
+		if (!$path) return;
278 278
 
279
-		if((strlen($path) >= 1 && substr_compare($path, '/', 0, 1) !== 0) && (strlen($path) >= 2 && substr_compare($path, './', 0, 2) !== 0))
279
+		if ((strlen($path) >= 1 && substr_compare($path, '/', 0, 1) !== 0) && (strlen($path) >= 2 && substr_compare($path, './', 0, 2) !== 0))
280 280
 		{
281
-			$path = './' . $path;
281
+			$path = './'.$path;
282 282
 		}
283 283
 
284
-		if(substr_compare($path, '/', -1) !== 0)
284
+		if (substr_compare($path, '/', -1) !== 0)
285 285
 		{
286 286
 			$path .= '/';
287 287
 		}
@@ -304,9 +304,9 @@  discard block
 block discarded – undo
304 304
 	 * */
305 305
 	function setEditedLayoutFile($filename)
306 306
 	{
307
-		if(!$filename) return;
307
+		if (!$filename) return;
308 308
 
309
-		if(substr_compare($filename, '.html', -5) !== 0)
309
+		if (substr_compare($filename, '.html', -5) !== 0)
310 310
 		{
311 311
 			$filename .= '.html';
312 312
 		}
@@ -329,9 +329,9 @@  discard block
 block discarded – undo
329 329
 	 * */
330 330
 	function setLayoutFile($filename)
331 331
 	{
332
-		if(!$filename) return;
332
+		if (!$filename) return;
333 333
 
334
-		if(substr_compare($filename, '.html', -5) !== 0)
334
+		if (substr_compare($filename, '.html', -5) !== 0)
335 335
 		{
336 336
 			$filename .= '.html';
337 337
 		}
@@ -353,13 +353,13 @@  discard block
 block discarded – undo
353 353
 	 * */
354 354
 	function setLayoutPath($path)
355 355
 	{
356
-		if(!$path) return;
356
+		if (!$path) return;
357 357
 
358
-		if((strlen($path) >= 1 && substr_compare($path, '/', 0, 1) !== 0) && (strlen($path) >= 2 && substr_compare($path, './', 0, 2) !== 0))
358
+		if ((strlen($path) >= 1 && substr_compare($path, '/', 0, 1) !== 0) && (strlen($path) >= 2 && substr_compare($path, './', 0, 2) !== 0))
359 359
 		{
360
-			$path = './' . $path;
360
+			$path = './'.$path;
361 361
 		}
362
-		if(substr_compare($path, '/', -1) !== 0)
362
+		if (substr_compare($path, '/', -1) !== 0)
363 363
 		{
364 364
 			$path .= '/';
365 365
 		}
@@ -382,7 +382,7 @@  discard block
 block discarded – undo
382 382
 	function proc()
383 383
 	{
384 384
 		// pass if stop_proc is true
385
-		if($this->stop_proc)
385
+		if ($this->stop_proc)
386 386
 		{
387 387
 			debugPrint($this->message, 'ERROR');
388 388
 			return FALSE;
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
 
391 391
 		// trigger call
392 392
 		$triggerOutput = ModuleHandler::triggerCall('moduleObject.proc', 'before', $this);
393
-		if(!$triggerOutput->toBool())
393
+		if (!$triggerOutput->toBool())
394 394
 		{
395 395
 			$this->setError($triggerOutput->getError());
396 396
 			$this->setMessage($triggerOutput->getMessage());
@@ -401,12 +401,12 @@  discard block
 block discarded – undo
401 401
 		$called_position = 'before_module_proc';
402 402
 		$oAddonController = getController('addon');
403 403
 		$addon_file = $oAddonController->getCacheFilePath(Mobile::isFromMobilePhone() ? "mobile" : "pc");
404
-		if(FileHandler::exists($addon_file)) include($addon_file);
404
+		if (FileHandler::exists($addon_file)) include($addon_file);
405 405
 
406
-		if(isset($this->xml_info->action->{$this->act}) && method_exists($this, $this->act))
406
+		if (isset($this->xml_info->action->{$this->act}) && method_exists($this, $this->act))
407 407
 		{
408 408
 			// Check permissions
409
-			if($this->module_srl && !$this->grant->access)
409
+			if ($this->module_srl && !$this->grant->access)
410 410
 			{
411 411
 				$this->stop("msg_not_permitted_act");
412 412
 				return FALSE;
@@ -415,21 +415,21 @@  discard block
 block discarded – undo
415 415
 			// integrate skin information of the module(change to sync skin info with the target module only by seperating its table)
416 416
 			$is_default_skin = ((!Mobile::isFromMobilePhone() && $this->module_info->is_skin_fix == 'N') || (Mobile::isFromMobilePhone() && $this->module_info->is_mskin_fix == 'N'));
417 417
 			$usedSkinModule = !($this->module == 'page' && ($this->module_info->page_type == 'OUTSIDE' || $this->module_info->page_type == 'WIDGET'));
418
-			if($usedSkinModule && $is_default_skin && $this->module != 'admin' && strpos($this->act, 'Admin') === false && $this->module == $this->module_info->module)
418
+			if ($usedSkinModule && $is_default_skin && $this->module != 'admin' && strpos($this->act, 'Admin') === false && $this->module == $this->module_info->module)
419 419
 			{
420 420
 				$dir = (Mobile::isFromMobilePhone()) ? 'm.skins' : 'skins';
421 421
 				$valueName = (Mobile::isFromMobilePhone()) ? 'mskin' : 'skin';
422 422
 				$oModuleModel = getModel('module');
423 423
 				$skinType = (Mobile::isFromMobilePhone()) ? 'M' : 'P';
424 424
 				$skinName = $oModuleModel->getModuleDefaultSkin($this->module, $skinType);
425
-				if($this->module == 'page')
425
+				if ($this->module == 'page')
426 426
 				{
427 427
 					$this->module_info->{$valueName} = $skinName;
428 428
 				}
429 429
 				else
430 430
 				{
431 431
 					$isTemplatPath = (strpos($this->getTemplatePath(), '/tpl/') !== FALSE);
432
-					if(!$isTemplatPath)
432
+					if (!$isTemplatPath)
433 433
 					{
434 434
 						$this->setTemplatePath(sprintf('%s%s/%s/', $this->module_path, $dir, $skinName));
435 435
 					}
@@ -449,7 +449,7 @@  discard block
 block discarded – undo
449 449
 
450 450
 		// trigger call
451 451
 		$triggerOutput = ModuleHandler::triggerCall('moduleObject.proc', 'after', $this);
452
-		if(!$triggerOutput->toBool())
452
+		if (!$triggerOutput->toBool())
453 453
 		{
454 454
 			$this->setError($triggerOutput->getError());
455 455
 			$this->setMessage($triggerOutput->getMessage());
@@ -460,25 +460,25 @@  discard block
 block discarded – undo
460 460
 		$called_position = 'after_module_proc';
461 461
 		$oAddonController = getController('addon');
462 462
 		$addon_file = $oAddonController->getCacheFilePath(Mobile::isFromMobilePhone() ? "mobile" : "pc");
463
-		if(FileHandler::exists($addon_file)) include($addon_file);
463
+		if (FileHandler::exists($addon_file)) include($addon_file);
464 464
 
465
-		if(is_a($output, 'Object') || is_subclass_of($output, 'Object'))
465
+		if (is_a($output, 'Object') || is_subclass_of($output, 'Object'))
466 466
 		{
467 467
 			$this->setError($output->getError());
468 468
 			$this->setMessage($output->getMessage());
469 469
 
470
-			if(!$output->toBool())
470
+			if (!$output->toBool())
471 471
 			{
472 472
 				return FALSE;
473 473
 			}
474 474
 		}
475 475
 		// execute api methos of the module if view action is and result is XMLRPC or JSON
476
-		if($this->module_info->module_type == 'view')
476
+		if ($this->module_info->module_type == 'view')
477 477
 		{
478
-			if(Context::getResponseMethod() == 'XMLRPC' || Context::getResponseMethod() == 'JSON')
478
+			if (Context::getResponseMethod() == 'XMLRPC' || Context::getResponseMethod() == 'JSON')
479 479
 			{
480 480
 				$oAPI = getAPI($this->module_info->module, 'api');
481
-				if(method_exists($oAPI, $this->act))
481
+				if (method_exists($oAPI, $this->act))
482 482
 				{
483 483
 					$oAPI->{$this->act}($this);
484 484
 				}
Please login to merge, or discard this patch.