moduleModel

Complexity

Total Complexity

471

Size/Duplication

Total Lines	2335
Duplicated Lines	10.19 %

Coupling/Cohesion

Components	2
Dependencies	11

Importance

Changes

0

57 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	3	1
B	isIDExists()	0	26	6
A	getSiteInfo()	0	7	1
A	getSiteInfoByDomain()	0	7	1
A	getModuleInfoByDocumentSrl()	0	8	1
F	getDefaultMid()	2	122	38
B	getModuleInfoByMid()	6	46	10
F	getModuleInfoByMenuItemSrl()	6	101	21
B	getModuleInfoByModuleSrl()	12	43	9
A	applyDefaultSkin()	0	12	3
A	getModulesInfoByLayout()	4	16	2
A	getModulesInfo()	0	9	3
C	addModuleExtraVars()	0	30	12
C	getMidList()	8	41	15
A	getModuleSrlList()	0	10	3
B	getModuleSrlByMid()	0	24	9
B	getActionForward()	0	40	8
B	getTriggers()	0	28	7
B	getTrigger()	0	17	7
A	getModuleExtend()	0	12	2
B	loadModuleExtends()	0	39	7
C	getModuleInfoXml()	10	68	10
F	getModuleActionXml()	0	201	35
A	getModuleSkinInfoList()	0	17	3
D	getSkins()	0	85	14
F	loadSkinInfo()	10	218	39
A	getModuleCount()	0	8	2
B	getModuleConfig()	35	35	6
B	getModulePartConfig()	35	35	6
A	getModulePartConfigs()	0	14	5
A	getModuleCategories()	0	17	5
A	getModuleCategory()	0	9	2
A	getModulesXmlInfo()	0	28	4
A	checkNeedInstall()	5	23	5
A	checkNeedUpdate()	0	10	3
A	needUpdate()	0	14	5
B	getModuleList()	5	60	10
B	syncModuleToSite()	0	38	9
B	isSiteAdmin()	10	22	6
A	getSiteAdmin()	0	7	1
A	getAdminId()	0	9	3
C	getModuleExtraVars()	6	71	14
B	getModuleSkinVars()	29	29	6
C	getModuleDefaultSkin()	0	50	12
B	syncSkinInfoToModuleInfo()	0	22	6
B	getModuleMobileSkinVars()	29	29	7
B	syncMobileSkinInfoToModuleInfo()	17	31	9
F	getGrant()	9	161	49
A	getModuleFileBox()	0	6	1
A	getModuleFileBoxList()	0	12	1
B	unserializeAttributes()	0	30	7
B	getFileBoxListHtml()	0	32	7
A	getModuleFileBoxPath()	0	4	1
B	getValidatorFilePath()	0	30	6
A	getLangListByLangcodeForAutoComplete()	0	30	3
A	getModuleListByInstance()	0	7	1
A	getLangByLangcode()	0	10	2

<?php
/* Copyright (C) XEHub <https://www.xehub.io> */
/**
 * @class  moduleModel
 * @author XEHub (developers@xpressengine.com)
 * @brief Model class of module module
 */
class moduleModel extends module
{
	/**
	 * @brief Initialization
	 */
	function init()
	{
	}

	/**
	 * @brief Check if mid, vid are available
	 */
	function isIDExists($id, $site_srl = 0)
	{
		if(!preg_match('/^[a-z]{1}([a-z0-9_]+)$/i',$id)) return true;
		// directory and rss/atom/api reserved checking, etc.
		$dirs = FileHandler::readDir(_XE_PATH_);
		$dirs[] = 'rss';
		$dirs[] = 'atom';
		$dirs[] = 'api';
		if(in_array($id, $dirs)) return true;
		// mid test
		$args = new stdClass();
		$args->mid = $id;
		$args->site_srl = $site_srl;
		$output = executeQuery('module.isExistsModuleName', $args);
		if($output->data->count) return true;
		// vid test (check mid != vid if site_srl=0, which means it is not a virtual site)
		if(!$site_srl)
		{
			$site_args = new stdClass();
			$site_args->domain = $id;
			$output = executeQuery('module.isExistsSiteDomain', $site_args);
			if($output->data->count) return true;
		}

		return false;
	}

	/**
	 * @brief Get site information
	 */
	function getSiteInfo($site_srl, $columnList = array())
	{
		$args = new stdClass();
		$args->site_srl = $site_srl;
		$output = executeQuery('module.getSiteInfo', $args, $columnList);
		return $output->data;
	}

	function getSiteInfoByDomain($domain, $columnList = array())
	{
		$args = new stdClass();
		$args->domain = $domain;
		$output = executeQuery('module.getSiteInfoByDomain', $args, $columnList);
		return $output->data;
	}

	/**
	 * @brief Get module information with document_srl
	 * In this case, it is unable to use the cache file
	 */
	function getModuleInfoByDocumentSrl($document_srl)
	{
		$args = new stdClass();
		$args->document_srl = $document_srl;
		$output = executeQuery('module.getModuleInfoByDocument', $args);
		$this->applyDefaultSkin($output->data);
		return $this->addModuleExtraVars($output->data);
	}

	/**
	 * @brief Get the default mid according to the domain
	 */
	function getDefaultMid()
	{
		$default_url = Context::getDefaultUrl();
		if($default_url && substr_compare($default_url, '/', -1) === 0) $default_url = substr($default_url, 0, -1);

		$request_url = Context::getRequestUri();
		if($request_url && substr_compare($request_url, '/', -1) === 0) $request_url = substr($request_url, 0, -1);

		$default_url_parse = parse_url($default_url);
		$request_url_parse = parse_url($request_url);
		$vid = Context::get('vid');
		$mid = Context::get('mid');

		// Set up
		$domain = '';
		$site_info = NULL;
		if($default_url && $default_url_parse['host'] != $request_url_parse['host'])
		{
			$hostname = $request_url_parse['host'];
			$path = $request_url_parse['path'];
			$port = $request_url_parse['port'];
			if(strlen($path) >= 1 && substr_compare($path, '/', -1) === 0) $path = substr($path, 0, -1);

			$domain = sprintf('%s%s%s', $hostname, $port && ($port != 80 )? ':'.$port  : '', $path);
		}

		if($domain === '')
		{
			if(!$vid) $vid = $mid;
			if($vid)
			{
				$domain = $vid;
			}
		}

		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		// If domain is set, look for subsite
		if($domain !== '')
		{
			$site_info = false;
			if($oCacheHandler->isSupport())
			{
				$object_key = 'site_info:' . md5($domain);
				$domain_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
				$site_info = $oCacheHandler->get($domain_cache_key);
			}

			if($site_info === false)
			{
				$args = new stdClass();
				$args->domain = $domain;
				$output = executeQuery('module.getSiteInfoByDomain', $args);
				$site_info = $output->data;

				if($oCacheHandler->isSupport()) $oCacheHandler->put($domain_cache_key, $site_info);

The variable $domain_cache_key does not seem to be defined for all execution paths leading up to this point.

			}

			if($site_info && $vid)
			{
				Context::set('vid', $site_info->domain, true);

true is of type boolean, but the function expects a integer.

				if(strtolower($mid)==strtolower($site_info->domain)) Context::set('mid', $site_info->mid,true);

true is of type boolean, but the function expects a integer.

			}
			if(!$site_info || !$site_info->domain) { $domain = ''; unset($site_info); }
		}

		// If no virtual website was found, get default website
		if($domain === '')
		{
			$site_info = false;
			if($oCacheHandler->isSupport())
			{
				$object_key = 'default_site';
				$default_site_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
				$site_info = $oCacheHandler->get($default_site_cache_key);
			}

			if($site_info === false)
			{
				$args = new stdClass();
				$args->site_srl = 0;
				$output = executeQuery('module.getSiteInfo', $args);
				// Update the related informaion if there is no default site info
				if(!$output->data)
				{
					// Create a table if sites table doesn't exist
					$oDB = &DB::getInstance();
					if(!$oDB->isTableExists('sites')) $oDB->createTableByXmlFile(_XE_PATH_.'modules/module/schemas/sites.xml');

The method createTableByXmlFile() does not exist on DB. Did you maybe mean create()?

					if(!$oDB->isTableExists('sites')) return;

					// Get mid, language
					$mid_output = $oDB->executeQuery('module.getDefaultMidInfo', $args);
					$db_info = Context::getDBInfo();
					$domain = Context::getDefaultUrl();
					$url_info = parse_url($domain);
					$domain = $url_info['host'].( (!empty($url_info['port'])&&$url_info['port']!=80)?':'.$url_info['port']:'').$url_info['path'];

					$site_args = new stdClass;
					$site_args->site_srl = 0;
					$site_args->index_module_srl  = $mid_output->data->module_srl;
					$site_args->domain = $domain;
					$site_args->default_language = $db_info->lang_type;

					if($output->data && !$output->data->index_module_srl)
					{
						$output = executeQuery('module.updateSite', $site_args);

$output is not used, you could remove the assignment.

					}
					else
					{
						$output = executeQuery('module.insertSite', $site_args);
						if(!$output->toBool()) return $output;
					}
					$output = executeQuery('module.getSiteInfo', $args);
				}
				$site_info = $output->data;
				if($oCacheHandler->isSupport()) $oCacheHandler->put($default_site_cache_key, $site_info);

The variable $default_site_cache_key does not seem to be defined for all execution paths leading up to this point.

			}
		}

		if(!$site_info->module_srl) return $site_info;
		if(is_array($site_info) && $site_info->data[0]) $site_info = $site_info[0];
		return $this->addModuleExtraVars($site_info);
	}

	/**
	 * @brief Get module information by mid
	 */
	function getModuleInfoByMid($mid, $site_srl = 0, $columnList = array())

The parameter $columnList is not used and could be removed.

	{
		if(!$mid || ($mid && !preg_match("/^[a-z][a-z0-9_]+$/i", $mid)))
		{
			return;
		}

		$args = new stdClass();
		$args->mid = $mid;
		$args->site_srl = (int)$site_srl;

		$module_srl = false;

$module_srl is not used, you could remove the assignment.

		$module_info = false;

		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			$object_key = 'module_srl:'.$mid.'_'.$site_srl;
			$module_srl_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
			$module_srl = $oCacheHandler->get($module_srl_cache_key);
			if($module_srl)
			{
				$object_key = 'mid_info:' . $module_srl;
				$module_info_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
				$module_info = $oCacheHandler->get($module_info_cache_key);
			}
		}

		if($module_info === false)
		{
			$output = executeQuery('module.getMidInfo', $args);
			$module_info = $output->data;
			if($oCacheHandler->isSupport())
			{
				$oCacheHandler->put($module_srl_cache_key, $module_info->module_srl);

The variable $module_srl_cache_key does not seem to be defined for all execution paths leading up to this point.

				$object_key = 'mid_info:' . $module_info->module_srl;
				$module_info_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
				$oCacheHandler->put($module_info_cache_key, $module_info);
			}
		}

		$this->applyDefaultSkin($module_info);
		if(!$module_info->module_srl && $module_info->data[0]) $module_info = $module_info->data[0];
		return $this->addModuleExtraVars($module_info);
	}

	/**
	 * Get module info by menu_item_srl.
	 *
	 * @params int $menu_item_srl
	 *
	 * @return BaseObject $moduleInfo
	 */
	public function getModuleInfoByMenuItemSrl($menu_item_srl = 0)
	{
		$menuItemSrl = Context::get('menu_item_srl');
		$menuItemSrl = (!$menuItemSrl) ? $menu_item_srl : $menuItemSrl;

		if(!$menuItemSrl)
		{
			$this->stop(-1, 'msg_invalid_request');

The call to moduleModel::stop() has too many arguments starting with 'msg_invalid_request'.

			return;
		}

		$args = new stdClass();
		$args->menu_item_srl = $menuItemSrl;
		$output = executeQuery('module.getModuleInfoByMenuItemSrl', $args);
		if(!$output->toBool())
		{
			return $output;
		}

		$moduleInfo = $output->data;
		$mid = $moduleInfo->mid;
		$site_srl = $moduleInfo->site_srl;

		$moduleInfo->designSettings = new stdClass();
		$moduleInfo->designSettings->layout = new stdClass();
		$moduleInfo->designSettings->skin = new stdClass();

		$oLayoutAdminModel = getAdminModel('layout');
		$layoutSrlPc = ($moduleInfo->layout_srl == -1) ? $oLayoutAdminModel->getSiteDefaultLayout('P', $moduleInfo->site_srl) : $moduleInfo->layout_srl;
		$layoutSrlMobile = ($moduleInfo->mlayout_srl == -1) ? $oLayoutAdminModel->getSiteDefaultLayout('M', $moduleInfo->site_srl) : $moduleInfo->mlayout_srl;
		$skinNamePc = ($moduleInfo->is_skin_fix == 'N') ? $this->getModuleDefaultSkin($moduleInfo->module, 'P') : $moduleInfo->skin;
		$skinNameMobile = ($moduleInfo->is_mskin_fix == 'N') ? $this->getModuleDefaultSkin($moduleInfo->module, 'M') : $moduleInfo->mskin;

		$oLayoutModel = getModel('layout');
		$layoutInfoPc = $layoutSrlPc ? $oLayoutModel->getLayoutRawData($layoutSrlPc, array('title')) : NULL;
		$layoutInfoMobile = $layoutSrlMobile ? $oLayoutModel->getLayoutRawData($layoutSrlMobile, array('title')) : NULL;
		$skinInfoPc = $this->loadSkinInfo(Modulehandler::getModulePath($moduleInfo->module), $skinNamePc);
		$skinInfoMobile = $this->loadSkinInfo(Modulehandler::getModulePath($moduleInfo->module), $skinNameMobile, 'm.skins');
		if(!$skinInfoPc)
		{
			$skinInfoPc = new stdClass();
			$skinInfoPc->title = $skinNamePc;
		}
		if(!$skinInfoMobile)
		{
			$skinInfoMobile = new stdClass();
			$skinInfoMobile->title = $skinNameMobile;
		}

		$moduleInfo->designSettings->layout->pcIsDefault = $moduleInfo->layout_srl == -1 ? 1 : 0;
		$moduleInfo->designSettings->layout->pc = $layoutInfoPc->title;
		$moduleInfo->designSettings->layout->mobileIsDefault = $moduleInfo->mlayout_srl == -1 ? 1 : 0;
		$moduleInfo->designSettings->layout->mobile = $layoutInfoMobile->title;
		$moduleInfo->designSettings->skin->pcIsDefault = $moduleInfo->is_skin_fix == 'N' ? 1 : 0;
		$moduleInfo->designSettings->skin->pc = $skinInfoPc->title;
		$moduleInfo->designSettings->skin->mobileIsDefault = $moduleInfo->is_mskin_fix == 'N' ? 1 : 0;
		$moduleInfo->designSettings->skin->mobile = $skinInfoMobile->title;

		$module_srl = false;

$module_srl is not used, you could remove the assignment.

		$mid_info = false;

		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			$object_key = 'module_srl:'.$mid.'_'.$site_srl;
			$module_srl_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
			$module_srl = $oCacheHandler->get($module_srl_cache_key);
			if($module_srl)
			{
				$object_key = 'mid_info:' . $module_srl;
				$module_info_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
				$mid_info = $oCacheHandler->get($module_info_cache_key);
			}

			if($mid_info === false)
			{
				$oCacheHandler->put($module_srl_cache_key, $output->data->module_srl);

				$object_key = 'mid_info:' . $output->data->module_srl;
				$module_info_cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
				$oCacheHandler->put($module_info_cache_key, $moduleInfo);
			}
			else
			{
				$mid_info->designSettings = $moduleInfo->designSettings;
				$moduleInfo = $mid_info;
			}
		}

		$moduleInfo = $this->addModuleExtraVars($moduleInfo);

		if($moduleInfo->module == 'page' && $moduleInfo->page_type != 'ARTICLE')
		{
			unset($moduleInfo->skin);
			unset($moduleInfo->mskin);
		}

		$this->add('module_info_by_menu_item_srl', $moduleInfo);

		return $moduleInfo;
	}

	/**
	 * @brief Get module information corresponding to module_srl
	 */
	function getModuleInfoByModuleSrl($module_srl, $columnList = array())
	{
		$mid_info = false;

		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			$object_key = 'mid_info:' . $module_srl;
			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
			$mid_info = $oCacheHandler->get($cache_key);
		}

		if($mid_info === false)
		{
			// Get data
			$args = new stdClass();
			$args->module_srl = $module_srl;
			$output = executeQuery('module.getMidInfo', $args);
			if(!$output->toBool()) return;

			$mid_info = $output->data;
			$this->applyDefaultSkin($mid_info);
			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $mid_info);

The variable $cache_key does not seem to be defined for all execution paths leading up to this point.

		}

		if($mid_info && count($columnList))
		{
			$module_info = new stdClass();
			foreach($mid_info as $key => $item)

The expression $mid_info of type object<stdClass>|boolean is not guaranteed to be traversable. How about adding an additional type check?

			{
				if(in_array($key, $columnList))
				{
					$module_info->$key = $item;
				}
			}
		}
		else $module_info = $mid_info;

		$oModuleController = getController('module');

$oModuleController is not used, you could remove the assignment.

		$this->applyDefaultSkin($module_info);

It seems like $module_info defined by $mid_info on line 403 can also be of type boolean; however, moduleModel::applyDefaultSkin() does only seem to accept object<stdClass>, maybe add an additional type check?

		return $this->addModuleExtraVars($module_info);
	}

	/**
	 * Apply default skin info
	 *
	 * @param stdClass $moduleInfo Module information
	 */
	private function applyDefaultSkin(&$moduleInfo)
	{
		if($moduleInfo->is_skin_fix == 'N')
		{
			$moduleInfo->skin = '/USE_DEFAULT/';
		}

		if($moduleInfo->is_mskin_fix == 'N')
		{
			$moduleInfo->mskin = '/USE_DEFAULT/';
		}
	}
	/**
	 * @brief Get module information corresponding to layout_srl
	 */
	function getModulesInfoByLayout($layout_srl, $columnList = array())
	{
		// Imported data
		$args = new stdClass;
		$args->layout_srl = $layout_srl;
		$output = executeQueryArray('module.getModulesByLayout', $args, $columnList);

		$count = count($output->data);

		$modules = array();
		for($i=0;$i<$count;$i++)
		{
			$modules[] = $output->data[$i];
		}
		return $this->addModuleExtraVars($modules);
	}

	/**
	 * @brief Get module information corresponding to multiple module_srls
	 */
	function getModulesInfo($module_srls, $columnList = array())
	{
		if(is_array($module_srls)) $module_srls = implode(',',$module_srls);
		$args = new stdClass();
		$args->module_srls = $module_srls;
		$output = executeQueryArray('module.getModulesInfo', $args, $columnList);
		if(!$output->toBool()) return;
		return $this->addModuleExtraVars($output->data);
	}

	/**
	 * @brief Add extra vars to the module basic information
	 */
	function addModuleExtraVars($module_info)
	{
		// Process although one or more module informaion is requested
		if(!is_array($module_info)) $target_module_info = array($module_info);
		else $target_module_info = $module_info;
		// Get module_srl
		$module_srls = array();
		foreach($target_module_info as $key => $val)
		{
			$module_srl = $val->module_srl;
			if(!$module_srl) continue;
			$module_srls[] = $val->module_srl;
		}
		// Extract extra information of the module and skin
		$extra_vars = $this->getModuleExtraVars($module_srls);
		if(!count($module_srls) || !count($extra_vars)) return $module_info;

		foreach($target_module_info as $key => $val)
		{
			if(!$extra_vars[$val->module_srl] || !count($extra_vars[$val->module_srl])) continue;
			foreach($extra_vars[$val->module_srl] as $k => $v)
			{
				if($target_module_info[$key]->{$k}) continue;
				$target_module_info[$key]->{$k} = $v;
			}
		}

		if(is_array($module_info)) return $target_module_info;
		return $target_module_info[0];
	}

	/**
	 * @brief Get a complete list of mid, which is created in the DB
	 */
	function getMidList($args = null, $columnList = array())
	{
		$list = false;
		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			if(count($args) === 1 && isset($args->site_srl))
			{
				$object_key = 'module:mid_list_' . $args->site_srl;
				$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
				$list = $oCacheHandler->get($cache_key);
			}
		}

		if($list === false)
		{
			if($oCacheHandler->isSupport() && count($args) === 1 && isset($args->site_srl))
			{
				$columnList = array();
			}

			$output = executeQuery('module.getMidList', $args, $columnList);
			if(!$output->toBool()) return $output;
			$list = $output->data;

			if($oCacheHandler->isSupport() && count($args) === 1 && isset($args->site_srl))
			{
				$oCacheHandler->put($cache_key, $list);

The variable $cache_key does not seem to be defined for all execution paths leading up to this point.

			}
		}
		if(!$list) return;

		if(!is_array($list)) $list = array($list);

		foreach($list as $val)
		{
			$mid_list[$val->mid] = $val;

$mid_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $mid_list = array(); before regardless.

		}

		return $mid_list;

The variable $mid_list does not seem to be defined for all execution paths leading up to this point.

	}

	/**
	 * @brief Get a complete list of module_srl, which is created in the DB
	 */
	function getModuleSrlList($args = null, $columnList = array())
	{
		$output = executeQueryArray('module.getMidList', $args, $columnList);
		if(!$output->toBool()) return $output;

		$list = $output->data;
		if(!$list) return;

		return $list;
	}

	/**
	 * @brief Return an array of module_srl corresponding to a mid list
	 */
	function getModuleSrlByMid($mid)
	{
		if($mid && !is_array($mid)) $mid = explode(',',$mid);
		if(is_array($mid)) $mid = "'".implode("','",$mid)."'";

		$site_module_info = Context::get('site_module_info');

		$args = new stdClass;
		$args->mid = $mid;
		if($site_module_info) $args->site_srl = $site_module_info->site_srl;
		$output = executeQuery('module.getModuleSrlByMid', $args);
		if(!$output->toBool()) return $output;

		$list = $output->data;
		if(!$list) return;
		if(!is_array($list)) $list = array($list);

		foreach($list as $key => $val)
		{
			$module_srl_list[] = $val->module_srl;

$module_srl_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $module_srl_list = array(); before regardless.

		}

		return $module_srl_list;

The variable $module_srl_list does not seem to be defined for all execution paths leading up to this point.

	}

	/**
	 * @brief Get forward value by the value of act
	 */
	function getActionForward($act)
	{
		$action_forward = false;
		// cache controll
		$oCacheHandler = CacheHandler::getInstance('object', NULL, TRUE);
		if($oCacheHandler->isSupport())
		{
			$cache_key = 'action_forward';
			$action_forward = $oCacheHandler->get($cache_key);
		}

		// retrieve and caching all registered action_forward
		if($action_forward === false)
		{
			$args = new stdClass();
			$output = executeQueryArray('module.getActionForward',$args);
			if(!$output->toBool()) return new stdClass;
			if(!$output->data) $output->data = array();

			$action_forward = array();
			foreach($output->data as $item)
			{
				$action_forward[$item->act] = $item;
			}

			if($oCacheHandler->isSupport())
			{
				$oCacheHandler->put($cache_key, $action_forward);

The variable $cache_key does not seem to be defined for all execution paths leading up to this point.

			}
		}

		if($action_forward[$act])
		{
			return $action_forward[$act];
		}
		else
		{
			return new stdClass();
		}
	}

	/**
	 * @brief Get a list of all triggers on the trigger_name
	 */
	function getTriggers($trigger_name, $called_position)
	{
		if(is_null($GLOBALS['__triggers__']))
		{
			$triggers = FALSE;
			$oCacheHandler = CacheHandler::getInstance('object', NULL, TRUE);
			if($oCacheHandler->isSupport())
			{
				$cache_key = 'triggers';
				$triggers = $oCacheHandler->get($cache_key);
			}
			if($triggers === FALSE)
			{
				$output = executeQueryArray('module.getTriggers');
				$triggers = $output->data;
				if($output->toBool() && $oCacheHandler->isSupport())
				{
					$oCacheHandler->put($cache_key, $triggers);

The variable $cache_key does not seem to be defined for all execution paths leading up to this point.

				}
			}
			foreach($triggers as $item)
			{
				$GLOBALS['__triggers__'][$item->trigger_name][$item->called_position][] = $item;
			}
		}

		return $GLOBALS['__triggers__'][$trigger_name][$called_position];
	}

	/**
	 * @brief Get specific triggers from the trigger_name
	 */
	function getTrigger($trigger_name, $module, $type, $called_method, $called_position)
	{
		$triggers = $this->getTriggers($trigger_name, $called_position);

		if($triggers && is_array($triggers))
		{
			foreach($triggers as $item)
			{
				if($item->module == $module && $item->type == $type && $item->called_method == $called_method)
				{
					return $item;
				}
			}
		}

		return NULL;
	}

	/**
	 * @brief Get module extend
	 */
	function getModuleExtend($parent_module, $type, $kind='')
	{
		$key = $parent_module.'.'.$kind.'.'.$type;

		$module_extend_info = $this->loadModuleExtends();
		if(array_key_exists($key, $module_extend_info))
		{
			return $module_extend_info[$key];
		}

		return false;
	}

	/**
	 * @brief Get all the module extend
	 */
	function loadModuleExtends()
	{
		$cache_file = './files/config/module_extend.php';
		$cache_file = FileHandler::getRealPath($cache_file);

		if(!isset($GLOBALS['__MODULE_EXTEND__']))
		{
			// check pre install
			if(file_exists(FileHandler::getRealPath('./files')) && !file_exists($cache_file))
			{
				$arr = array();
				$output = executeQueryArray('module.getModuleExtend');
				if($output->data)
				{
					foreach($output->data as $v)
					{
						$arr[] = sprintf("'%s.%s.%s' => '%s'", $v->parent_module, $v->kind, $v->type, $v->extend_module);
					}
				}

				$str = '<?PHP return array(%s); ?>';
				$str = sprintf($str, join(',',$arr));

				FileHandler::writeFile($cache_file, $str);
			}


			if(file_exists($cache_file))
			{
				$GLOBALS['__MODULE_EXTEND__'] = include($cache_file);
			}
			else
			{
				$GLOBALS['__MODULE_EXTEND__'] = array();
			}
		}

		return $GLOBALS['__MODULE_EXTEND__'];
	}

	/**
	 * @brief Get information from conf/info.xml
	 */
	function getModuleInfoXml($module)
	{
		// Get a path of the requested module. Return if not exists.
		$module_path = ModuleHandler::getModulePath($module);
		if(!$module_path) return;
		// Read the xml file for module skin information
		$xml_file = sprintf("%s/conf/info.xml", $module_path);
		if(!file_exists($xml_file)) return;

		$oXmlParser = new XmlParser();
		$tmp_xml_obj = $oXmlParser->loadXmlFile($xml_file);
		$xml_obj = $tmp_xml_obj->module;

		if(!$xml_obj) return;

		// Module Information
		$module_info = new stdClass();
		if($xml_obj->version && $xml_obj->attrs->version == '0.2')
		{
			// module format 0.2
			$module_info->title = $xml_obj->title->body;
			$module_info->description = $xml_obj->description->body;
			$module_info->version = $xml_obj->version->body;
			$module_info->homepage = $xml_obj->link->body;
			$module_info->category = $xml_obj->category->body;
			if(!$module_info->category) $module_info->category = 'service';
			sscanf($xml_obj->date->body, '%d-%d-%d', $date_obj->y, $date_obj->m, $date_obj->d);

The variable $date_obj does not exist. Did you forget to declare it?

			$module_info->date = sprintf('%04d%02d%02d', $date_obj->y, $date_obj->m, $date_obj->d);
			$module_info->license = $xml_obj->license->body;
			$module_info->license_link = $xml_obj->license->attrs->link;

			if(!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;

$author_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $author_list = array(); before regardless.

			else $author_list = $xml_obj->author;

			foreach($author_list as $author)
			{
				$author_obj = new stdClass();
				$author_obj->name = $author->name->body;
				$author_obj->email_address = $author->attrs->email_address;
				$author_obj->homepage = $author->attrs->link;
				$module_info->author[] = $author_obj;
			}
		}
		else
		{
			// module format 0.1
			$module_info->title = $xml_obj->title->body;
			$module_info->description = $xml_obj->author->description->body;
			$module_info->version = $xml_obj->attrs->version;
			$module_info->category = $xml_obj->attrs->category;
			if(!$module_info->category) $module_info->category = 'service';
			sscanf($xml_obj->author->attrs->date, '%d. %d. %d', $date_obj->y, $date_obj->m, $date_obj->d);
			$module_info->date = sprintf('%04d%02d%02d', $date_obj->y, $date_obj->m, $date_obj->d);
			$author_obj = new stdClass();
			$author_obj->name = $xml_obj->author->name->body;
			$author_obj->email_address = $xml_obj->author->attrs->email_address;
			$author_obj->homepage = $xml_obj->author->attrs->link;
			$module_info->author[] = $author_obj;
		}
		// Add admin_index by using action information
		$action_info = $this->getModuleActionXml($module);
		$module_info->admin_index_act = $action_info->admin_index_act;
		$module_info->default_index_act = $action_info->default_index_act;
		$module_info->setup_index_act = $action_info->setup_index_act;
		$module_info->simple_setup_index_act = $action_info->simple_setup_index_act;

		return $module_info;
	}

	/**
	 * @brief Return permisson and action data by conf/module.xml in the module
	 * Cache it because it takes too long to parse module.xml file
	 * When caching, add codes so to include it directly
	 * This is apparently good for performance, but not sure about its side-effects
	 */
	function getModuleActionXml($module)
	{
		// Get a path of the requested module. Return if not exists.
		$class_path = ModuleHandler::getModulePath($module);
		if(!$class_path) return;

		// Check if module.xml exists in the path. Return if not exist
		$xml_file = sprintf("%sconf/module.xml", $class_path);
		if(!file_exists($xml_file)) return;

		// Check if cached file exists
		$cache_file = sprintf(_XE_PATH_ . "files/cache/module_info/%s.%s.%s.php", $module, Context::getLangType(), __XE_VERSION__);

		// Update if no cache file exists or it is older than xml file
		if(!file_exists($cache_file) || filemtime($cache_file) < filemtime($xml_file) || $re_cache)

The variable $re_cache does not exist. Did you forget to declare it?

		{
			$info = new stdClass();
			$buff = array(); // /< Set buff variable to use in the cache file
			$buff[] = '<?php if(!defined("__XE__")) exit();';
			$buff[] = '$info = new stdClass;';
			$buff['default_index_act'] = '$info->default_index_act = \'%s\';';
			$buff['setup_index_act'] = '$info->setup_index_act=\'%s\';';
			$buff['simple_setup_index_act'] = '$info->simple_setup_index_act=\'%s\';';
			$buff['admin_index_act'] = '$info->admin_index_act = \'%s\';';

			$xml_obj = XmlParser::loadXmlFile($xml_file); // /< Read xml file and convert it to xml object

			if(!count($xml_obj->module)) return; // /< Error occurs if module tag doesn't included in the xml

			$grants = $xml_obj->module->grants->grant; // /< Permission information
			$permissions = $xml_obj->module->permissions->permission; // /<  Acting permission
			$menus = $xml_obj->module->menus->menu;
			$actions = $xml_obj->module->actions->action; // /< Action list (required)

			$default_index = $admin_index = '';

$admin_index is not used, you could remove the assignment.

$default_index is not used, you could remove the assignment.

			// Arrange permission information
			if($grants)
			{
				if(is_array($grants)) $grant_list = $grants;
				else $grant_list[] = $grants;

$grant_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $grant_list = array(); before regardless.

				$info->grant = new stdClass();
				$buff[] = '$info->grant = new stdClass;';
				foreach($grant_list as $grant)
				{
					$name = $grant->attrs->name;
					$default = $grant->attrs->default?$grant->attrs->default:'guest';
					$title = $grant->title->body;

					$info->grant->{$name} = new stdClass();
					$info->grant->{$name}->title = $title;
					$info->grant->{$name}->default = $default;

					$buff[] = sprintf('$info->grant->%s = new stdClass;', $name);
					$buff[] = sprintf('$info->grant->%s->title=\'%s\';', $name, $title);
					$buff[] = sprintf('$info->grant->%s->default=\'%s\';', $name, $default);
				}
			}
			// Permissions to grant
			if($permissions)
			{
				if(is_array($permissions)) $permission_list = $permissions;
				else $permission_list[] = $permissions;

$permission_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $permission_list = array(); before regardless.

				$buff[] = '$info->permission = new stdClass;';

				$info->permission = new stdClass();
				foreach($permission_list as $permission)
				{
					$action = $permission->attrs->action;
					$target = $permission->attrs->target;

					$info->permission->{$action} = $target;

					$buff[] = sprintf('$info->permission->%s = \'%s\';', $action, $target);
				}
			}
			// for admin menus
			if($menus)
			{
				if(is_array($menus)) $menu_list = $menus;
				else $menu_list[] = $menus;

$menu_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $menu_list = array(); before regardless.

				$buff[] = '$info->menu = new stdClass;';
				$info->menu = new stdClass();
				foreach($menu_list as $menu)
				{
					$menu_name = $menu->attrs->name;
					$menu_title = is_array($menu->title) ? $menu->title[0]->body : $menu->title->body;
					$menu_type = $menu->attrs->type;

					$info->menu->{$menu_name} = new stdClass();
					$info->menu->{$menu_name}->title = $menu_title;
					$info->menu->{$menu_name}->acts = array();
					$info->menu->{$menu_name}->type = $menu_type;

					$buff[] = sprintf('$info->menu->%s = new stdClass;', $menu_name);
					$buff[] = sprintf('$info->menu->%s->title=\'%s\';', $menu_name, $menu_title);
					$buff[] = sprintf('$info->menu->%s->type=\'%s\';', $menu_name, $menu_type);
				}
			}

			// actions
			if($actions)
			{
				if(is_array($actions)) $action_list = $actions;
				else $action_list[] = $actions;

$action_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $action_list = array(); before regardless.

				$buff[] = '$info->action = new stdClass;';
				$info->action = new stdClass();
				foreach($action_list as $action)
				{
					$name = $action->attrs->name;

					$type = $action->attrs->type;
					$grant = $action->attrs->grant?$action->attrs->grant:'guest';
					$standalone = $action->attrs->standalone=='false'?'false':'true';
					$ruleset = $action->attrs->ruleset?$action->attrs->ruleset:'';
					$method = $action->attrs->method?$action->attrs->method:'';
					$check_csrf = $action->attrs->check_csrf=='false'?'false':'true';
					$meta_noindex = $action->attrs->{'meta-noindex'} === 'true' ? 'true' : 'false';

					$index = $action->attrs->index;
					$admin_index = $action->attrs->admin_index;
					$setup_index = $action->attrs->setup_index;
					$simple_setup_index = $action->attrs->simple_setup_index;
					$menu_index = $action->attrs->menu_index;

					$info->action->{$name} = new stdClass();
					$info->action->{$name}->type = $type;
					$info->action->{$name}->grant = $grant;
					$info->action->{$name}->standalone = $standalone;
					$info->action->{$name}->ruleset = $ruleset;
					$info->action->{$name}->method = $method;
					$info->action->{$name}->check_csrf = $check_csrf;
					$info->action->{$name}->meta_noindex = $meta_noindex;
					if($action->attrs->menu_name)
					{
						if($menu_index == 'true')
						{
							$info->menu->{$action->attrs->menu_name}->index = $name;
							$buff[] = sprintf('$info->menu->%s->index=\'%s\';', $action->attrs->menu_name, $name);
						}
						if(is_array($info->menu->{$action->attrs->menu_name}->acts))
						{
							$info->menu->{$action->attrs->menu_name}->acts[] = $name;
							$currentKey = array_search($name, $info->menu->{$action->attrs->menu_name}->acts);
						}

						$buff[] = sprintf('$info->menu->%s->acts[%d]=\'%s\';', $action->attrs->menu_name, $currentKey, $name);

The variable $currentKey does not seem to be defined for all execution paths leading up to this point.

						$i++;

The variable $i does not seem to be defined for all execution paths leading up to this point.

					}

					$buff[] = sprintf('$info->action->%s = new stdClass;', $name);
					$buff[] = sprintf('$info->action->%s->type=\'%s\';', $name, $type);
					$buff[] = sprintf('$info->action->%s->grant=\'%s\';', $name, $grant);
					$buff[] = sprintf('$info->action->%s->standalone=\'%s\';', $name, $standalone);
					$buff[] = sprintf('$info->action->%s->ruleset=\'%s\';', $name, $ruleset);
					$buff[] = sprintf('$info->action->%s->method=\'%s\';', $name, $method);
					$buff[] = sprintf('$info->action->%s->check_csrf=\'%s\';', $name, $check_csrf);
					$buff[] = sprintf('$info->action->%s->meta_noindex=\'%s\';', $name, $meta_noindex);

					if($index=='true')
					{
						$default_index_act = $name;
						$info->default_index_act = $name;
					}
					if($admin_index=='true')
					{
						$admin_index_act = $name;
						$info->admin_index_act = $name;
					}
					if($setup_index=='true')
					{
						$setup_index_act = $name;
						$info->setup_index_act = $name;
					}
					if($simple_setup_index=='true')
					{
						$simple_setup_index_act = $name;
						$info->simple_setup_index_act = $name;
					}
				}
			}
			$buff['default_index_act'] = sprintf($buff['default_index_act'], $default_index_act);

The variable $default_index_act does not seem to be defined for all execution paths leading up to this point.

			$buff['setup_index_act'] = sprintf($buff['setup_index_act'], $setup_index_act);

The variable $setup_index_act does not seem to be defined for all execution paths leading up to this point.

			$buff['simple_setup_index_act'] = sprintf($buff['simple_setup_index_act'], $simple_setup_index_act);

The variable $simple_setup_index_act does not seem to be defined for all execution paths leading up to this point.

			$buff['admin_index_act'] = sprintf($buff['admin_index_act'], $admin_index_act);

The variable $admin_index_act does not seem to be defined for all execution paths leading up to this point.

			$buff[] = 'return $info;';

			$buff = implode(PHP_EOL, $buff);

			FileHandler::writeFile($cache_file, $buff);

			return $info;
		}

		if(file_exists($cache_file)) return include($cache_file);
	}

	/**
	 * Get a skin list for js API.
	 * return void
	 */
	public function getModuleSkinInfoList()
	{
		$module = Context::get('module_type');

		if($module == 'ARTICLE')
		{
			$module = 'page';
		}

		$skinType = Context::get('skin_type');

		$path = ModuleHandler::getModulePath($module);
		$dir = ($skinType == 'M') ? 'm.skins' : 'skins';
		$skin_list = $this->getSkins($path, $dir);

		$this->add('skin_info_list', $skin_list);
	}

	/**
	 * @brief Get a list of skins for the module
	 * Return file analysis of skin and skin.xml
	 */
	function getSkins($path, $dir = 'skins')
	{
		if(substr($path, -1) == '/')
		{
			$path = substr($path, 0, -1);
		}

		$skin_path = sprintf("%s/%s/", $path, $dir);
		$list = FileHandler::readDir($skin_path);
		if(!count($list)) return;

		natcasesort($list);

		foreach($list as $skin_name)
		{
			if(!is_dir($skin_path . $skin_name))
			{
				continue;
			}
			unset($skin_info);
			$skin_info = $this->loadSkinInfo($path, $skin_name, $dir);
			if(!$skin_info)
			{
				$skin_info = new stdClass();
				$skin_info->title = $skin_name;
			}

			$skin_list[$skin_name] = $skin_info;

$skin_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $skin_list = array(); before regardless.

		}

		$tmpPath = strtr($path, array('/' => ' '));
		$tmpPath = trim($tmpPath);
		$module = array_pop(explode(' ', $tmpPath));

explode(' ', $tmpPath) cannot be passed to array_pop() as the parameter $array expects a reference.

		if($dir == 'skins')
		{
			$oAdminModel = getAdminModel('admin');
			$themesInfo = $oAdminModel->getThemeList();

			foreach($themesInfo as $themeName => $info)
			{
				$skinInfos = $info->skin_infos;
				if(isset($skinInfos[$module]) && $skinInfos[$module]->is_theme)
				{
					$themeSkinInfo = $GLOBALS['__ThemeModuleSkin__'][$module]['skins'][$skinInfos[$module]->name];
					$skin_list[$skinInfos[$module]->name] = $themeSkinInfo;

The variable $skin_list does not seem to be defined for all execution paths leading up to this point.

				}
			}
		}

		$siteInfo = Context::get('site_module_info');
		$oMenuAdminModel = getAdminModel('menu');
		$installedMenuTypes = $oMenuAdminModel->getModuleListInSitemap($siteInfo->site_srl);
		$moduleName = $module;
		if($moduleName === 'page')
		{
			$moduleName = 'ARTICLE';
		}
		if(array_key_exists($moduleName, $installedMenuTypes))
		{
			if($dir == 'skins')
			{
				$type = 'P';
			}
			else
			{
				$type = 'M';
			}
			$defaultSkinName = $this->getModuleDefaultSkin($module, $type, $site_info->site_srl);

The variable $site_info does not exist. Did you forget to declare it?

			if(isset($defaultSkinName))
			{
				$defaultSkinInfo = $this->loadSkinInfo($path, $defaultSkinName, $dir);

				$useDefault = new stdClass();
				$useDefault->title = Context::getLang('use_site_default_skin') . ' (' . $defaultSkinInfo->title . ')';

				$useDefaultList['/USE_DEFAULT/'] = $useDefault;

$useDefaultList was never initialized. Although not strictly required by PHP, it is generally a good practice to add $useDefaultList = array(); before regardless.

				$skin_list = array_merge($useDefaultList, $skin_list);
			}
		}

		return $skin_list;
	}

	/**
	 * @brief Get skin information on a specific location
	 */
	function loadSkinInfo($path, $skin, $dir = 'skins')
	{
		// Read xml file having skin information
		if(substr($path,-1)!='/') $path .= '/';
		$skin_xml_file = sprintf("%s%s/%s/skin.xml", $path, $dir, $skin);
		if(!file_exists($skin_xml_file)) return;
		// Create XmlParser object
		$oXmlParser = new XmlParser();
		$_xml_obj = $oXmlParser->loadXmlFile($skin_xml_file);
		// Return if no skin information is
		if(!$_xml_obj->skin) return;
		$xml_obj = $_xml_obj->skin;
		// Skin Name
		$skin_info = new stdClass();
		$skin_info->title = $xml_obj->title->body;
		// Author information
		if($xml_obj->version && $xml_obj->attrs->version == '0.2')
		{
			// skin format v0.2
			sscanf($xml_obj->date->body, '%d-%d-%d', $date_obj->y, $date_obj->m, $date_obj->d);

The variable $date_obj does not exist. Did you forget to declare it?

			$skin_info->version = $xml_obj->version->body;
			$skin_info->date = sprintf('%04d%02d%02d', $date_obj->y, $date_obj->m, $date_obj->d);
			$skin_info->homepage = $xml_obj->link->body;
			$skin_info->license = $xml_obj->license->body;
			$skin_info->license_link = $xml_obj->license->attrs->link;
			$skin_info->description = $xml_obj->description->body;

			if(!is_array($xml_obj->author)) $author_list[] = $xml_obj->author;

$author_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $author_list = array(); before regardless.

			else $author_list = $xml_obj->author;

			foreach($author_list as $author)
			{
				$author_obj = new stdClass();
				$author_obj->name = $author->name->body;
				$author_obj->email_address = $author->attrs->email_address;
				$author_obj->homepage = $author->attrs->link;
				$skin_info->author[] = $author_obj;
			}
			// List extra vars
			if($xml_obj->extra_vars)
			{
				$extra_var_groups = $xml_obj->extra_vars->group;
				if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
				if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);

				foreach($extra_var_groups as $group)
				{
					$extra_vars = $group->var;
					if(!$extra_vars)
					{
						continue;
					}
					if(!is_array($group->var)) $extra_vars = array($group->var);

					foreach($extra_vars as $key => $val)
					{
						$obj = new stdClass();
						if(!$val->attrs->type) { $val->attrs->type = 'text'; }

						$obj->group = $group->title->body;
						$obj->name = $val->attrs->name;
						$obj->title = $val->title->body;
						$obj->type = $val->attrs->type;
						$obj->description = $val->description->body;
						$obj->value = $extra_vals->{$obj->name};

The variable $extra_vals does not exist. Did you mean $extra_vars?

						$obj->default = $val->attrs->default;
						if(strpos($obj->value, '|@|') != false) { $obj->value = explode('|@|', $obj->value); }

It seems like you are loosely comparing strpos($obj->value, '|@|') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

						if($obj->type == 'mid_list' && !is_array($obj->value)) { $obj->value = array($obj->value); }
						// Get an option list from 'select'type
						if(is_array($val->options))
						{
							$option_count = count($val->options);

							for($i = 0; $i < $option_count; $i++)
							{
								$obj->options[$i] = new stdClass();
								$obj->options[$i]->title = $val->options[$i]->title->body;
								$obj->options[$i]->value = $val->options[$i]->attrs->value;
							}
						}
						else
						{
							$obj->options[0] = new stdClass();
							$obj->options[0]->title = $val->options->title->body;
							$obj->options[0]->value = $val->options->attrs->value;
						}

						$skin_info->extra_vars[] = $obj;
					}
				}
			}
		}
		else
		{
			// skin format v0.1
			sscanf($xml_obj->maker->attrs->date, '%d-%d-%d', $date_obj->y, $date_obj->m, $date_obj->d);

			$skin_info->version = $xml_obj->version->body;
			$skin_info->date = sprintf('%04d%02d%02d', $date_obj->y, $date_obj->m, $date_obj->d);
			$skin_info->homepage = $xml_obj->link->body;
			$skin_info->license = $xml_obj->license->body;
			$skin_info->license_link = $xml_obj->license->attrs->link;
			$skin_info->description = $xml_obj->maker->description->body;

			$skin_info->author[0] = new stdClass();
			$skin_info->author[0]->name = $xml_obj->maker->name->body;
			$skin_info->author[0]->email_address = $xml_obj->maker->attrs->email_address;
			$skin_info->author[0]->homepage = $xml_obj->maker->attrs->link;
			// Variables used in the skin
			$extra_var_groups = $xml_obj->extra_vars->group;
			if(!$extra_var_groups) $extra_var_groups = $xml_obj->extra_vars;
			if(!is_array($extra_var_groups)) $extra_var_groups = array($extra_var_groups);

			foreach($extra_var_groups as $group)
			{
				$extra_vars = $group->var;

				if($extra_vars)
				{
					if(!is_array($extra_vars)) $extra_vars = array($extra_vars);

					foreach($extra_vars as $var)
					{
						unset($obj);
						unset($options);

						$group = $group->title->body;
						$name = $var->attrs->name;
						$type = $var->attrs->type;
						$title = $var->title->body;
						$description = $var->description->body;
						// Get an option list from 'select'type.
						if(is_array($var->default))
						{
							$option_count = count($var->default);

							for($i = 0; $i < $option_count; $i++)
							{
								$options[$i]->title = $var->default[$i]->body;

The variable $options does not exist. Did you forget to declare it?

								$options[$i]->value = $var->default[$i]->body;
							}
						}
						else
						{
							$options[0]->title = $var->default->body;
							$options[0]->value = $var->default->body;
						}

						$width = $var->attrs->width;
						$height = $var->attrs->height;

						unset($obj);
						$obj->group = $group;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

						$obj->title = $title;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

						$obj->description = $description;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

						$obj->name = $name;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

						$obj->type = $type;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

						$obj->options = $options;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

						$obj->width = $width;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

						$obj->height = $height;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

						$obj->default = $options[0]->value;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

						$skin_info->extra_vars[] = $obj;

The variable $obj seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

					}
				}
			}
		}

		// colorset
		$colorset = $xml_obj->colorset->color;
		if($colorset)
		{
			if(!is_array($colorset)) $colorset = array($colorset);

			foreach($colorset as $color)
			{
				$name = $color->attrs->name;
				$title = $color->title->body;
				$screenshot = $color->attrs->src;
				if($screenshot)
				{
					$screenshot = sprintf("%s%s/%s/%s", $path, $dir, $skin, $screenshot);
					if(!file_exists($screenshot)) $screenshot = "";
				}
				else $screenshot = "";

				$obj = new stdClass();
				$obj->name = $name;
				$obj->title = $title;
				$obj->screenshot = $screenshot;
				$skin_info->colorset[] = $obj;
			}
		}
		// Menu type (settings for layout)
		if($xml_obj->menus->menu)
		{
			$menus = $xml_obj->menus->menu;
			if(!is_array($menus)) $menus = array($menus);

			$menu_count = count($menus);
			$skin_info->menu_count = $menu_count;
			for($i=0;$i<$menu_count;$i++)
			{
				unset($obj);

				$obj->name = $menus[$i]->attrs->name;

The variable $obj does not seem to be defined for all execution paths leading up to this point.

				if($menus[$i]->attrs->default == "true") $obj->default = true;
				$obj->title = $menus[$i]->title->body;
				$obj->maxdepth = $menus[$i]->maxdepth->body;

				$skin_info->menu->{$obj->name} = $obj;
			}
		}

		$thumbnail = sprintf("%s%s/%s/thumbnail.png", $path, $dir, $skin);
		$skin_info->thumbnail = (file_exists($thumbnail))?$thumbnail:null;
		return $skin_info;
	}

	/**
	 * @brief Return the number of modules which are registered on a virtual site
	 */
	function getModuleCount($site_srl, $module = null)
	{
		$args = new stdClass;
		$args->site_srl = $site_srl;
		if(!is_null($module)) $args->module = $module;
		$output = executeQuery('module.getModuleCount', $args);
		return $output->data->count;
	}

	/**
	 * @brief Return module configurations
	 * Global configuration is used to manage board, member and others
	 */
	function getModuleConfig($module, $site_srl = 0)

This method seems to be duplicated in your project.

	{
		$config = false;
		// cache controll
		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			$object_key = 'module_config:' . $module . '_' . $site_srl;
			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
			$config = $oCacheHandler->get($cache_key);
		}

		if($config === false)
		{
			if(!$GLOBALS['__ModuleConfig__'][$site_srl][$module])
			{
				$args = new stdClass();
				$args->module = $module;
				$args->site_srl = $site_srl;
				$output = executeQuery('module.getModuleConfig', $args);
				if($output->data->config) $config = unserialize($output->data->config);
				else $config = null;

				//insert in cache
				if($oCacheHandler->isSupport())
				{
					$oCacheHandler->put($cache_key, $config);

The variable $cache_key does not seem to be defined for all execution paths leading up to this point.

				}
				$GLOBALS['__ModuleConfig__'][$site_srl][$module] = $config;
			}
			return $GLOBALS['__ModuleConfig__'][$site_srl][$module];
		}

		return $config;
	}

	/**
	 * @brief Return the module configuration of mid
	 * Manage mid configurations which depend on module
	 */
	function getModulePartConfig($module, $module_srl)

This method seems to be duplicated in your project.

	{
		$config = false;
		// cache controll
		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			$object_key = 'module_part_config:'.$module.'_'.$module_srl;
			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
			$config = $oCacheHandler->get($cache_key);
		}

		if($config === false)
		{
			if(!isset($GLOBALS['__ModulePartConfig__'][$module][$module_srl]))
			{
				$args = new stdClass();
				$args->module = $module;
				$args->module_srl = $module_srl;
				$output = executeQuery('module.getModulePartConfig', $args);
				if($output->data->config) $config = unserialize($output->data->config);
				else $config = null;

				//insert in cache
				if($oCacheHandler->isSupport())
				{
					$oCacheHandler->put($cache_key, $config);

The variable $cache_key does not seem to be defined for all execution paths leading up to this point.

				}
				$GLOBALS['__ModulePartConfig__'][$module][$module_srl] = $config;
			}
			return $GLOBALS['__ModulePartConfig__'][$module][$module_srl];
		}

		return $config;
	}

	/**
	 * @brief Get all of module configurations for each mid
	 */
	function getModulePartConfigs($module, $site_srl = 0)
	{
		$args = new stdClass();
		$args->module = $module;
		if($site_srl) $args->site_srl = $site_srl;
		$output = executeQueryArray('module.getModulePartConfigs', $args);
		if(!$output->toBool() || !$output->data) return array();

		foreach($output->data as $key => $val)
		{
			$result[$val->module_srl] = unserialize($val->config);

$result was never initialized. Although not strictly required by PHP, it is generally a good practice to add $result = array(); before regardless.

		}
		return $result;

The variable $result does not seem to be defined for all execution paths leading up to this point.

	}

	/**
	 * @brief Get a list of module category
	 */
	function getModuleCategories($moduleCategorySrl = array())
	{
		$args = new stdClass();
		$args->moduleCategorySrl = $moduleCategorySrl;
		// Get data from the DB
		$output = executeQuery('module.getModuleCategories', $args);
		if(!$output->toBool()) return $output;
		$list = $output->data;
		if(!$list) return;
		if(!is_array($list)) $list = array($list);

		foreach($list as $val)
		{
			$category_list[$val->module_category_srl] = $val;

$category_list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $category_list = array(); before regardless.

		}
		return $category_list;

The variable $category_list does not seem to be defined for all execution paths leading up to this point.

	}

	/**
	 * @brief Get content from the module category
	 */
	function getModuleCategory($module_category_srl)
	{
		// Get data from the DB
		$args = new stdClass;
		$args->module_category_srl = $module_category_srl;
		$output = executeQuery('module.getModuleCategory', $args);
		if(!$output->toBool()) return $output;
		return $output->data;
	}

	/**
	 * @brief Get xml information of the module
	 */
	function getModulesXmlInfo()
	{
		// Get a list of downloaded and installed modules
		$searched_list = FileHandler::readDir('./modules');
		$searched_count = count($searched_list);
		if(!$searched_count) return;
		sort($searched_list);

		for($i=0;$i<$searched_count;$i++)
		{
			// Module name
			$module_name = $searched_list[$i];

			$path = ModuleHandler::getModulePath($module_name);
			// Get information of the module
			$info = $this->getModuleInfoXml($module_name);
			unset($obj);

			if(!isset($info)) continue;
			$info->module = $module_name;
			$info->created_table_count = $created_table_count;

The variable $created_table_count does not exist. Did you forget to declare it?

			$info->table_count = $table_count;

The variable $table_count does not exist. Did you forget to declare it?

			$info->path = $path;
			$info->admin_index_act = $info->admin_index_act;
			$list[] = $info;

$list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $list = array(); before regardless.

		}
		return $list;

The variable $list does not seem to be defined for all execution paths leading up to this point.

	}

	function checkNeedInstall($module_name)
	{
		$oDB = &DB::getInstance();
		$info = null;

$info is not used, you could remove the assignment.

		$moduledir = ModuleHandler::getModulePath($module_name);
		if(file_exists(FileHandler::getRealPath($moduledir."schemas")))
		{
			$tmp_files = FileHandler::readDir($moduledir."schemas", '/(\.xml)$/');
			$table_count = count($tmp_files);
			// Check if the table is created
			$created_table_count = 0;
			for($j=0;$j<count($tmp_files);$j++)

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

			{
				list($table_name) = explode(".",$tmp_files[$j]);
				if($oDB->isTableExists($table_name)) $created_table_count ++;
			}
			// Check if DB is installed
			if($table_count > $created_table_count) return true;
			else return false;
		}
		return false;
	}

	function checkNeedUpdate($module_name)
	{
		// Check if it is upgraded to module.class.php on each module
		$oDummy = getModule($module_name, 'class');
		if($oDummy && method_exists($oDummy, "checkUpdate"))
		{
			return $oDummy->checkUpdate();
		}
		return false;
	}

	/**
	 * @brief 업데이트 적용 여부 확인
	 * @param array|string $update_id
	 * @return Boolean
	 */
	public function needUpdate($update_id)
	{
		if(!is_array($update_id)) $update_id = array($update_id);

		$args = new stdClass();
		$args->update_id = implode(',', $update_id);
		$output = executeQueryArray('module.getModuleUpdateLog', $args);

		if(!!$output->error) return false;
		if(!$output->data) $output->data = array();
		if(count($update_id) === count($output->data)) return false;

		return true;
	}

	/**
	 * @brief Get a type and information of the module
	 */
	function getModuleList()
	{
		// Create DB Object
		$oDB = &DB::getInstance();
		// Get a list of downloaded and installed modules
		$searched_list = FileHandler::readDir('./modules', '/^([a-zA-Z0-9_-]+)$/');
		sort($searched_list);

		$searched_count = count($searched_list);
		if(!$searched_count) return;

		for($i=0;$i<$searched_count;$i++)
		{
			// module name
			$module_name = $searched_list[$i];

			$path = ModuleHandler::getModulePath($module_name);
			if(!is_dir(FileHandler::getRealPath($path))) continue;

			// Get the number of xml files to create a table in schemas
			$tmp_files = FileHandler::readDir($path.'schemas', '/(\.xml)$/');
			$table_count = count($tmp_files);
			// Check if the table is created
			$created_table_count = 0;
			for($j=0;$j<$table_count;$j++)
			{
				list($table_name) = explode('.',$tmp_files[$j]);
				if($oDB->isTableExists($table_name)) $created_table_count ++;
			}
			// Get information of the module
			$info = NULL;

$info is not used, you could remove the assignment.

			$info = $this->getModuleInfoXml($module_name);

Are you sure the assignment to $info is correct as $this->getModuleInfoXml($module_name) (which targets moduleModel::getModuleInfoXml()) seems to always return null.

			if(!$info) continue;

			$info->module = $module_name;
			$info->category = $info->category;
			$info->created_table_count = $created_table_count;
			$info->table_count = $table_count;
			$info->path = $path;
			$info->admin_index_act = $info->admin_index_act;
			// Check if DB is installed
			if($table_count > $created_table_count) $info->need_install = true;
			else $info->need_install = false;
			// Check if it is upgraded to module.class.php on each module
			$oDummy = null;

$oDummy is not used, you could remove the assignment.

			$oDummy = getModule($module_name, 'class');
			if($oDummy && method_exists($oDummy, "checkUpdate"))
			{
				$info->need_update = $oDummy->checkUpdate();
			}
			else
			{
				continue;
			}

			$list[] = $info;

$list was never initialized. Although not strictly required by PHP, it is generally a good practice to add $list = array(); before regardless.

		}
		return $list;

The variable $list does not seem to be defined for all execution paths leading up to this point.

	}

	/**
	 * @brief Combine module_srls with domain of sites
	 * Because XE DBHandler doesn't support left outer join,
	 * it should be as same as $Output->data[]->module_srl.
	 */
	function syncModuleToSite(&$data)
	{
		if(!$data) return;

		if(is_array($data))
		{
			foreach($data as $key => $val)
			{
				$module_srls[] = $val->module_srl;

$module_srls was never initialized. Although not strictly required by PHP, it is generally a good practice to add $module_srls = array(); before regardless.

			}
			if(!count($module_srls)) return;

The variable $module_srls does not seem to be defined for all execution paths leading up to this point.

		}
		else
		{
			$module_srls[] = $data->module_srl;
		}

		$args = new stdClass();
		$args->module_srls = implode(',',$module_srls);
		$output = executeQueryArray('module.getModuleSites', $args);
		if(!$output->data) return array();
		foreach($output->data as $key => $val)
		{
			$modules[$val->module_srl] = $val;

$modules was never initialized. Although not strictly required by PHP, it is generally a good practice to add $modules = array(); before regardless.

		}

		if(is_array($data))
		{
			foreach($data as $key => $val)
			{
				$data[$key]->domain = $modules[$val->module_srl]->domain;

The variable $modules does not seem to be defined for all execution paths leading up to this point.

			}
		}
		else
		{
			$data->domain = $modules[$data->module_srl]->domain;
		}
	}

	/**
	 * @brief Check if it is an administrator of site_module_info
	 */
	function isSiteAdmin($member_info, $site_srl = null)
	{
		if(!$member_info->member_srl) return false;
		if($member_info->is_admin == 'Y') return true;

		$args = new stdClass();
		if(!isset($site_srl))
		{
			$site_module_info = Context::get('site_module_info');
			if(!$site_module_info) return;
			$args->site_srl = $site_module_info->site_srl;
		}
		else
		{
			$args->site_srl = $site_srl;
		}

		$args->member_srl = $member_info->member_srl;
		$output = executeQuery('module.isSiteAdmin', $args);
		if($output->data->member_srl == $args->member_srl) return true;
		return false;
	}

	/**
	 * @brief Get admin information of the site
	 */
	function getSiteAdmin($site_srl)
	{
		$args = new stdClass;
		$args->site_srl = $site_srl;
		$output = executeQueryArray('module.getSiteAdmin', $args);
		return $output->data;
	}

	/**
	 * @brief Get admin ID of the module
	 */
	function getAdminId($module_srl)
	{
		$obj = new stdClass();
		$obj->module_srl = $module_srl;
		$output = executeQueryArray('module.getAdminID', $obj);
		if(!$output->toBool() || !$output->data) return;

		return $output->data;
	}

	/**
	 * @brief Get extra vars of the module
	 * Extra information, not in the modules table
	 */
	function getModuleExtraVars($list_module_srl)
	{
		$extra_vars = array();
		$get_module_srls = array();
		if(!is_array($list_module_srl)) $list_module_srl = array($list_module_srl);

		$vars = false;

$vars is not used, you could remove the assignment.

		// cache controll
		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			foreach($list_module_srl as $module_srl)
			{
				$object_key = 'module_extra_vars:'.$module_srl;
				$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
				$vars = $oCacheHandler->get($cache_key);

				if($vars)
				{
					$extra_vars[$module_srl] = $vars;
				}
				else
				{
					$get_module_srls[] = $module_srl;
				}
			}
		}
		else
		{
			$get_module_srls = $list_module_srl;
		}

		if(count($get_module_srls) > 0)
		{
			$args = new stdClass();
			$args->module_srl = implode(',', $get_module_srls);
			$output = executeQueryArray('module.getModuleExtraVars', $args);

			if(!$output->toBool())
			{
				return;
			}

			if(!$output->data)
			{
				foreach($get_module_srls as $module_srl)
				{
					$extra_vars[$module_srl] = new stdClass;
				}
			}
			foreach($output->data as $key => $val)
			{
				if(in_array($val->name, array('mid','module')) || $val->value == 'Array') continue;

				if(!isset($extra_vars[$val->module_srl]))
				{
					$extra_vars[$val->module_srl] = new stdClass();
				}
				$extra_vars[$val->module_srl]->{$val->name} = $val->value;

				if($oCacheHandler->isSupport())
				{
					$object_key = 'module_extra_vars:'.$val->module_srl;
					$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
					$oCacheHandler->put($cache_key, $extra_vars[$val->module_srl]);
				}
			}
		}

		return $extra_vars;
	}

	/**
	 * @brief Get skin information of the module
	 */
	function getModuleSkinVars($module_srl)

This method seems to be duplicated in your project.

	{
		$skin_vars = false;
		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			$object_key = 'module_skin_vars:'.$module_srl;
			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
			$skin_vars = $oCacheHandler->get($cache_key);
		}

		if($skin_vars === false)
		{
			$args = new stdClass();
			$args->module_srl = $module_srl;
			$output = executeQueryArray('module.getModuleSkinVars',$args);
			if(!$output->toBool()) return;

			$skin_vars = array();
			foreach($output->data as $vars)
			{
				$skin_vars[$vars->name] = $vars;
			}

			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);

The variable $cache_key does not seem to be defined for all execution paths leading up to this point.

		}

		return $skin_vars;
	}

	/**
	 * Get default skin name
	 */
	function getModuleDefaultSkin($module_name, $skin_type = 'P', $site_srl = 0, $updateCache = true)
	{
		$target = ($skin_type == 'M') ? 'mskin' : 'skin';
		if(!$site_srl) $site_srl = 0;

		$designInfoFile = sprintf(_XE_PATH_.'files/site_design/design_%s.php', $site_srl);
		if(is_readable($designInfoFile))
		{
			include($designInfoFile);

			$skinName = $designInfo->module->{$module_name}->{$target};

The variable $designInfo does not exist. Did you mean $designInfoFile?

		}
		if(!$skinName)

The variable $skinName does not seem to be defined for all execution paths leading up to this point.

		{
			$dir = ($skin_type == 'M') ? 'm.skins/' : 'skins/';
			$moduleSkinPath = ModuleHandler::getModulePath($module_name).$dir;

			if(is_dir($moduleSkinPath.'default'))
			{
				$skinName = 'default';
			}
			else if(is_dir($moduleSkinPath.'xe_default'))
			{
				$skinName = 'xe_default';
			}
			else
			{
				$skins = FileHandler::readDir($moduleSkinPath);
				if(count($skins) > 0)
				{
					$skinName = $skins[0];
				}
				else
				{
					$skinName = NULL;
				}
			}

			if($updateCache && $skinName)

The expression $skinName of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

			{
				if(!isset($designInfo->module->{$module_name})) $designInfo->module->{$module_name} = new stdClass();

The variable $designInfo does not exist. Did you mean $designInfoFile?

				$designInfo->module->{$module_name}->{$target} = $skinName;

The variable $designInfo does not exist. Did you mean $designInfoFile?

				$oAdminController = getAdminController('admin');
				$oAdminController->makeDefaultDesignFile($designInfo, $site_srl);

The variable $designInfo does not exist. Did you mean $designInfoFile?

			}
		}

		return $skinName;
	}

	/**
	 * @brief Combine skin information with module information
	 */
	function syncSkinInfoToModuleInfo(&$module_info)
	{
		if(!$module_info->module_srl) return;

		$oCacheHandler = CacheHandler::getInstance('object', null, true);

$oCacheHandler is not used, you could remove the assignment.

		if(Mobile::isFromMobilePhone())
		{
			$skin_vars = $this->getModuleMobileSkinVars($module_info->module_srl);
		}
		else
		{
			$skin_vars = $this->getModuleSkinVars($module_info->module_srl);
		}

		if(!$skin_vars) return;

		foreach($skin_vars as $name => $val)

The expression $skin_vars of type array|boolean is not guaranteed to be traversable. How about adding an additional type check?

		{
			if(isset($module_info->{$name})) continue;
			$module_info->{$name} = $val->value;
		}
	}

	/**
	 * Get mobile skin information of the module
	 * @param $module_srl Sequence of module
	 * @return array
	 */
	function getModuleMobileSkinVars($module_srl)

This method seems to be duplicated in your project.

	{
		$skin_vars = false;
		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			$object_key = 'module_mobile_skin_vars:'.$module_srl;
			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
			$skin_vars = $oCacheHandler->get($cache_key);
		}

		if($skin_vars === false)
		{
			$args = new stdClass();
			$args->module_srl = $module_srl;
			$output = executeQueryArray('module.getModuleMobileSkinVars',$args);
			if(!$output->toBool() || !$output->data) return;

			$skin_vars = array();
			foreach($output->data as $vars)
			{
				$skin_vars[$vars->name] = $vars;
			}

			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);

The variable $cache_key does not seem to be defined for all execution paths leading up to this point.

		}

		return $skin_vars;
	}

	/**
	 * Combine skin information with module information
	 * @param $module_info Module information
	 */
	function syncMobileSkinInfoToModuleInfo(&$module_info)
	{
		if(!$module_info->module_srl) return;
		$skin_vars = false;
		// cache controll
		$oCacheHandler = CacheHandler::getInstance('object', null, true);
		if($oCacheHandler->isSupport())
		{
			$object_key = 'module_mobile_skin_vars:'.$module_info->module_srl;
			$cache_key = $oCacheHandler->getGroupKey('site_and_module', $object_key);
			$skin_vars = $oCacheHandler->get($cache_key);
		}
		if($skin_vars === false)
		{
			$args = new stdClass;
			$args->module_srl = $module_info->module_srl;
			$output = executeQueryArray('module.getModuleMobileSkinVars',$args);
			if(!$output->toBool()) return;
			$skin_vars = $output->data;

			//insert in cache
			if($oCacheHandler->isSupport()) $oCacheHandler->put($cache_key, $skin_vars);

The variable $cache_key does not seem to be defined for all execution paths leading up to this point.

		}
		if(!$skin_vars) return;

		foreach($output->data as $val)

The variable $output does not seem to be defined for all execution paths leading up to this point.

		{
			if(isset($module_info->{$val->name})) continue;
			$module_info->{$val->name} = $val->value;
		}
	}

	/**
	 * @brief Return permission by using module info, xml info and member info
	 */
	function getGrant($module_info, $member_info, $xml_info = '')
	{
		$grant = new stdClass();

		if(!$xml_info)
		{
			$module = $module_info->module;
			$xml_info = $this->getModuleActionXml($module);
		}
		// Set variables to grant group permission
		$module_srl = $module_info->module_srl;
		$grant_info = $xml_info->grant;
		if($member_info->member_srl)
		{
			if(is_array($member_info->group_list)) $group_list = array_keys($member_info->group_list);
			else $group_list = array();
		}
		else
		{
			$group_list = array();
		}
		// If module_srl doesn't exist(if unable to set permissions)
		if(!$module_srl)
		{
			$grant->access = true;
			if($this->isSiteAdmin($member_info, $module_info->site_srl))
			{
				$grant->access = $grant->manager = $grant->is_site_admin = true;
			}

			$grant->is_admin = $grant->manager = ($member_info->is_admin == 'Y') ? true : false;
		}
		else
		{
			// If module_srl exists
			// Get a type of granted permission
			$grant->access = $grant->manager = $grant->is_site_admin = ($member_info->is_admin=='Y'||$this->isSiteAdmin($member_info, $module_info->site_srl))?true:false;
			$grant->is_admin = ($member_info->is_admin == 'Y') ? true : false;
			// If a just logged-in member is, check if the member is a module administrator
			if(!$grant->manager && $member_info->member_srl)
			{
				$args = new stdClass();
				$args->module_srl = $module_srl;
				$args->member_srl = $member_info->member_srl;
				$output = executeQuery('module.getModuleAdmin',$args);
				if($output->data && $output->data->member_srl == $member_info->member_srl) $grant->manager = true;
			}
			// If not an administrator, get information from the DB and grant manager privilege.
			if(!$grant->manager)
			{
				$args = new stdClass();
				// If planet, get permission settings from the planet home
				if($module_info->module == 'planet')
				{
					$output = executeQueryArray('module.getPlanetGrants', $args);
				}
				else
				{
					$args = new stdClass;
					$args->module_srl = $module_srl;
					$output = executeQueryArray('module.getModuleGrants', $args);
				}

				$grant_exists = $granted = array();

				if($output->data)
				{
					// Arrange names and groups who has privileges
					foreach($output->data as $val)
					{
						$grant_exists[$val->name] = true;
						if($granted[$val->name]) continue;
						// Log-in member only
						if($val->group_srl == -1)
						{
							$granted[$val->name] = true;
							if($member_info->member_srl) $grant->{$val->name} = true;
							// Site-joined member only
						}
						elseif($val->group_srl == -2)
						{
							$granted[$val->name] = true;
							// Do not grant any permission for non-logged member
							if(!$member_info->member_srl) $grant->{$val->name} = false;
							// Log-in member
							else
							{
								$site_module_info = Context::get('site_module_info');
								// Permission granted if no information of the currently connected site exists
								if(!$site_module_info->site_srl) $grant->{$val->name} = true;
								// Permission is not granted if information of the currently connected site exists
								elseif(count($group_list)) $grant->{$val->name} = true;
							}
							// All of non-logged members
						}
						elseif($val->group_srl == -3)
						{
							$granted[$val->name] = true;
							$grant->{$val->name} = ($grant->is_admin || $grant->is_site_admin);
						}
						elseif($val->group_srl == 0)
						{
							$granted[$val->name] = true;
							$grant->{$val->name} = true;
							// If a target is a group
						}
						else
						{
							if($group_list && count($group_list) && in_array($val->group_srl, $group_list))

The expression $group_list of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

							{
								$grant->{$val->name} = true;
								$granted[$val->name] = true;
							}
						}
					}
				}
				// Separate processing for the virtual group access
				if(!$grant_exists['access']) $grant->access = true;
				if(count($grant_info))
				{
					foreach($grant_info as  $grant_name => $grant_item)
					{
						if($grant_exists[$grant_name]) continue;
						switch($grant_item->default)
						{
							case 'guest' :
								$grant->{$grant_name} = true;
								break;
							case 'member' :
								if($member_info->member_srl) $grant->{$grant_name} = true;
								else $grant->{$grant_name} = false;
								break;
							case 'site' :
								$site_module_info = Context::get('site_module_info');
								if($member_info->member_srl && (($site_module_info->site_srl && count($group_list)) || !$site_module_info->site_srl)) $grant->{$grant_name} = true;
								else $grant->{$grant_name} = false;
								break;
							case 'manager' :
							case 'root' :
								if($member_info->is_admin == 'Y') $grant->{$grant_name} = true;
								else $grant->{$grant_name} = false;
								break;
						}
					}
				}
			}
			// Set true to grant all privileges if an administrator is
			if($grant->manager)
			{
				$grant->access = true;
				if(count($grant_info))
				{
					foreach($grant_info as $key => $val)
					{
						$grant->{$key} = true;
					}
				}
			}
		}
		return $grant;
	}

	function getModuleFileBox($module_filebox_srl)
	{
		$args = new stdClass();
		$args->module_filebox_srl = $module_filebox_srl;
		return executeQuery('module.getModuleFileBox', $args);
	}

	function getModuleFileBoxList()
	{
		$oModuleModel = getModel('module');

		$args = new stdClass();
		$args->page = Context::get('page');
		$args->list_count = 5;
		$args->page_count = 5;
		$output = executeQuery('module.getModuleFileBoxList', $args);
		$output = $oModuleModel->unserializeAttributes($output);
		return $output;
	}

	function unserializeAttributes($module_filebox_list)
	{
		if(is_array($module_filebox_list->data))
		{
			foreach($module_filebox_list->data as &$item)
			{
				if(empty($item->comment))
				{
					continue;
				}

				$attributes = explode(';', $item->comment);
				foreach($attributes as $attribute)
				{
					$values = explode(':', $attribute);
					if((count($values) % 2) ==1)
					{
						for($i=2;$i<count($values);$i++)

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

						{
							$values[1].=":".$values[$i];
						}
					}
					$atts[$values[0]]=$values[1];

$atts was never initialized. Although not strictly required by PHP, it is generally a good practice to add $atts = array(); before regardless.

				}
				$item->attributes = $atts;

The variable $atts does not seem to be defined for all execution paths leading up to this point.

				unset($atts);
			}
		}
		return $module_filebox_list;
	}

	function getFileBoxListHtml()
	{
		$logged_info = Context::get('logged_info');
		if($logged_info->is_admin !='Y' && !$logged_info->is_site_admin) return new BaseObject(-1, 'msg_not_permitted');
		$link = parse_url($_SERVER["HTTP_REFERER"]);
		$link_params = explode('&',$link['query']);
		foreach ($link_params as $param)
		{
			$param = explode("=",$param);
			if($param[0] == 'selected_widget') $selected_widget = $param[1];
		}
		$oWidgetModel = getModel('widget');
		if($selected_widget) $widget_info = $oWidgetModel->getWidgetInfo($selected_widget);

The variable $selected_widget does not seem to be defined for all execution paths leading up to this point.

		Context::set('allow_multiple', $widget_info->extra_var->images->allow_multiple);

The variable $widget_info does not seem to be defined for all execution paths leading up to this point.

		$oModuleModel = getModel('module');
		$output = $oModuleModel->getModuleFileBoxList();
		Context::set('filebox_list', $output->data);

		$page = Context::get('page');
		if (!$page) $page = 1;
		Context::set('page', $page);
		Context::set('page_navigation', $output->page_navigation);

		$security = new Security();
		$security->encodeHTML('filebox_list..comment', 'filebox_list..attributes.');

		$oTemplate = &TemplateHandler::getInstance();
		$html = $oTemplate->compile(_XE_PATH_ . 'modules/module/tpl/', 'filebox_list_html');

		$this->add('html', $html);
	}

	function getModuleFileBoxPath($module_filebox_srl)
	{
		return sprintf("./files/attach/filebox/%s",getNumberingPath($module_filebox_srl,3));
	}

	/**
	 * @brief Return ruleset cache file path
	 * @param module, act
	 */
	function getValidatorFilePath($module, $ruleset, $mid=null)
	{
		// load dynamic ruleset xml file
		if(strpos($ruleset, '@') !== false)
		{
			$rulsetFile = str_replace('@', '', $ruleset);
			$xml_file = sprintf('./files/ruleset/%s.xml', $rulsetFile);
			return FileHandler::getRealPath($xml_file);
		}
		else if (strpos($ruleset, '#') !== false)
		{
			$rulsetFile = str_replace('#', '', $ruleset).'.'.$mid;
			$xml_file = sprintf('./files/ruleset/%s.xml', $rulsetFile);
			if(is_readable($xml_file))
				return FileHandler::getRealPath($xml_file);
			else{
				$ruleset = str_replace('#', '', $ruleset);
			}

		}
		// Get a path of the requested module. Return if not exists.
		$class_path = ModuleHandler::getModulePath($module);
		if(!$class_path) return;

		// Check if module.xml exists in the path. Return if not exist
		$xml_file = sprintf("%sruleset/%s.xml", $class_path, $ruleset);
		if(!file_exists($xml_file)) return;

		return $xml_file;
	}

	function getLangListByLangcodeForAutoComplete()
	{
		$keyword = Context::get('search_keyword');

$keyword is not used, you could remove the assignment.

		$requestVars = Context::getRequestVars();

		$args = new stdClass;
		$args->site_srl = (int)$requestVars->site_srl;

The property site_srl does not seem to exist in BaseObject.

		$args->page = 1; // /< Page
		$args->list_count = 100; // /< the number of posts to display on a single page
		$args->page_count = 5; // /< the number of pages that appear in the page navigation
		$args->sort_index = 'name';
		$args->order_type = 'asc';
		$args->search_keyword = Context::get('search_keyword'); // /< keyword to search*/

		$output = executeQueryArray('module.getLangListByLangcode', $args);

		$list = array();

		if($output->toBool())
		{
			foreach((array)$output->data as $code_info)
			{
				unset($codeInfo);
				$codeInfo = array('name'=>'$user_lang->'.$code_info->name, 'value'=>$code_info->value);
				$list[] = $codeInfo;
			}
		}
		$this->add('results', $list);
	}

	/**
	 * @brief already instance created module list
	 */
	function getModuleListByInstance($site_srl = 0, $columnList = array())
	{
		$args = new stdClass();
		$args->site_srl = $site_srl;
		$output = executeQueryArray('module.getModuleListByInstance', $args, $columnList);
		return $output;
	}

	function getLangByLangcode()
	{
		$langCode = Context::get('langCode');
		if (!$langCode) return;

		$oModuleController = getController('module');
		$oModuleController->replaceDefinedLangCode($langCode);

		$this->add('lang', $langCode);
	}
}
/* End of file module.model.php */
/* Location: ./modules/module/module.model.php */