ElementFinderFactory::create() - Code Metrics - Inspection of "Merge branch 'master' of github.com:xparse/Parser" - xparse/Parser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( df9ed0...44c010 )

by Shcherbak

created 2016-04-21 13:39 UTC

ElementFinderFactory::create() A

↳ Parent: ElementFinderFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	13
ccs	10
cts	10
cp	1
rs	9.4285
cc	2
eloc	9
nc	2
nop	2
crap	2

<?php

  namespace Xparse\Parser;

  use GuzzleHttp\Psr7\Response;
  use Xparse\ElementFinder\ElementFinder;
  use Xparse\ElementFinder\Helper;
  use Xparse\Parser\Helper\HtmlEncodingConverter;
  use Xparse\Parser\Helper\LinkConverter;

  /**
   * Create ElementFinder.
   * Convert charset to UTF-8
   * Convert relative links to absolute
   * @package Xparse\Parser\Helper
   */
  class ElementFinderFactory implements ElementFinderFactoryInterface {

    /**
     * @inheritdoc
     */
    public function create(Response $response, $affectedUrl = null) {
      $html = $response->getBody();
      $html = Helper::safeEncodeStr((string) $html);
      $contentType = $response->getHeaderLine('content-type');
      $html = HtmlEncodingConverter::convertToUtf($html, $contentType);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      $page = new ElementFinder((string) $html);

      if ($affectedUrl !== null) {
        LinkConverter::convertUrlsToAbsolute($page, $affectedUrl);
      }

      return $page;
    }

  }

1		<?php
2
3		namespace Xparse\Parser;
4
5		use GuzzleHttp\Psr7\Response;
6		use Xparse\ElementFinder\ElementFinder;
7		use Xparse\ElementFinder\Helper;
8		use Xparse\Parser\Helper\HtmlEncodingConverter;
9		use Xparse\Parser\Helper\LinkConverter;
10
11		/**
12		* Create ElementFinder.
13		* Convert charset to UTF-8
14		* Convert relative links to absolute
15		* @package Xparse\Parser\Helper
16		*/
17		class ElementFinderFactory implements ElementFinderFactoryInterface {
18
19		/**
20		* @inheritdoc
21		*/
22	14	public function create(Response $response, $affectedUrl = null) {
23	14	$html = $response->getBody();
24	14	$html = Helper::safeEncodeStr((string) $html);
25	14	$contentType = $response->getHeaderLine('content-type');
26	14	$html = HtmlEncodingConverter::convertToUtf($html, $contentType);
		0 ignored issues – show Documentation introduced 2016-03-30 11:26 UTC by Report Bug Copy Issue Report `$contentType` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27	14	$page = new ElementFinder((string) $html);
28
29	14	if ($affectedUrl !== null) {
30	4	LinkConverter::convertUrlsToAbsolute($page, $affectedUrl);
31	4	}
32
33	14	return $page;
34		}
35
36		}

xparse / Parser

GitHub Access Token became invalid

Push — master ( df9ed0...44c010 )

ElementFinderFactory::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like