SingleEliminationTeamTreeGen::addFighterToGroup() - Code Metrics - Inspection of "refactor teams and competitors to traits" - xoco70/laravel-tournaments - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 547255...753a4f )

by Julien

created 2017-09-18 16:08 UTC

SingleEliminationTeamTreeGen::addFighterToGroup() A

↳ Parent: SingleEliminationTeamTreeGen

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	3

<?php

namespace Xoco70\LaravelTournaments\TreeGen;

use Illuminate\Support\Collection;
use Xoco70\LaravelTournaments\Models\FighterGroupTeam;
use Xoco70\LaravelTournaments\Models\FightersGroup;
use Xoco70\LaravelTournaments\Models\Team;
use Xoco70\LaravelTournaments\Traits\hasTeamsTrait;

class SingleEliminationTeamTreeGen extends SingleEliminationTreeGen
{
    use hasTeamsTrait;
    

    /**
     * @param FightersGroup $group
     * @param $fighters
     *
     * @return FightersGroup
     */
    public function syncGroup(FightersGroup $group, $fighters)
    {
        // Add all competitors to Pivot Table
        return $group->syncTeams($fighters);
    }

    /**
     * @param FightersGroup $group
     * @param $team
     * @param $fighterToUpdate
     */
    protected function addFighterToGroup(FightersGroup $group, $team, $fighterToUpdate)
    {
        // fighterToUpdate is coming at format c1, c2, c3 etc.
        $numFighterToUpdate = substr($fighterToUpdate, 1);
        $competitorGroup = FighterGroupTeam::where('fighters_group_id', $group->id)
            ->get()
            ->get($numFighterToUpdate - 1);

        // we must update the right result
        $competitorGroup->team_id = $team->id;
        $competitorGroup->save();
    }
}


1			<?php
2
3			namespace Xoco70\LaravelTournaments\TreeGen;
4
5			use Illuminate\Support\Collection;
6			use Xoco70\LaravelTournaments\Models\FighterGroupTeam;
7			use Xoco70\LaravelTournaments\Models\FightersGroup;
8			use Xoco70\LaravelTournaments\Models\Team;
9			use Xoco70\LaravelTournaments\Traits\hasTeamsTrait;
10
11			class SingleEliminationTeamTreeGen extends SingleEliminationTreeGen
12			{
13			use hasTeamsTrait;
14
15
16			/**
17			* @param FightersGroup $group
18			* @param $fighters
19			*
20			* @return FightersGroup
21			*/
22			public function syncGroup(FightersGroup $group, $fighters)
23			{
24			// Add all competitors to Pivot Table
25			return $group->syncTeams($fighters);
26			}
27
28			/**
29			* @param FightersGroup $group
30			* @param $team
31			* @param $fighterToUpdate
32			*/
33			protected function addFighterToGroup(FightersGroup $group, $team, $fighterToUpdate)
34			{
35			// fighterToUpdate is coming at format c1, c2, c3 etc.
36			$numFighterToUpdate = substr($fighterToUpdate, 1);
37			$competitorGroup = FighterGroupTeam::where('fighters_group_id', $group->id)
38			->get()
39			->get($numFighterToUpdate - 1);
40
41			// we must update the right result
42			$competitorGroup->team_id = $team->id;
43			$competitorGroup->save();
44			}
45			}
46

xoco70 / laravel-tournaments

Push — master ( 547255...753a4f )

SingleEliminationTeamTreeGen::addFighterToGroup() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like