xoco70 /
laravel-tournaments
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 12 |
| Code Lines | 7 |
| Lines | 12 |
| Ratio | 100 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 30 | protected function addFighterToGroup(FightersGroup $group, $competitor, $fighterToUpdate) |
||
| 31 | { |
||
| 32 | // fighterToUpdate is coming at format c1, c2, c3 etc. |
||
| 33 | $numFighterToUpdate = substr($fighterToUpdate, 1); |
||
| 34 | $competitorGroup = FighterGroupCompetitor::where('fighters_group_id', $group->id) |
||
| 35 | ->get() |
||
| 36 | ->get($numFighterToUpdate - 1); |
||
| 37 | |||
| 38 | // we must update the right result |
||
| 39 | $competitorGroup->competitor_id = $competitor->id; |
||
| 40 | $competitorGroup->save(); |
||
| 41 | } |
||
| 42 | } |
||
| 43 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.