hasTeamsTrait - Code Metrics - Inspection of "refactor teams and competitors to traits" - xoco70/laravel-tournaments - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 547255...753a4f )

by Julien

created 2017-09-18 16:08 UTC

hasTeamsTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	1
dl	0
loc	31
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	getFighter()	4	1
A	getFighters()	4	1
A	createByeFighter()	4	1

<?php

namespace Xoco70\LaravelTournaments\Traits;


use Illuminate\Support\Collection;
use Xoco70\LaravelTournaments\Models\Team;

trait hasTeamsTrait
{
    /**
     * get Fighter by Id.
     *
     * @param $teamId
     *
     * @return Team
     */
    protected function getFighter($teamId)
    {
        return Team::find($teamId);
    }

    /**
     * Fighter is the name for competitor or team, depending on the case.
     *
     * @return Collection
     */
    protected function getFighters()
    {
        return $this->championship->teams;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    protected function createByeFighter()
    {
        return new Team();
    }


}

1			<?php
2
3			namespace Xoco70\LaravelTournaments\Traits;
4
5
6			use Illuminate\Support\Collection;
7			use Xoco70\LaravelTournaments\Models\Team;
8
9			trait hasTeamsTrait
10			{
11			/**
12			* get Fighter by Id.
13			*
14			* @param $teamId
15			*
16			* @return Team
17			*/
18			protected function getFighter($teamId)
19			{
20			return Team::find($teamId);
21			}
22
23			/**
24			* Fighter is the name for competitor or team, depending on the case.
25			*
26			* @return Collection
27			*/
28			protected function getFighters()
29			{
30			return $this->championship->teams;
			0 ignored issues – show Bug introduced 2017-09-18 16:19 UTC by Report Bug Copy Issue Report The property `championship` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31			}
32
33			protected function createByeFighter()
34			{
35			return new Team();
36			}
37
38
39			}

xoco70 / laravel-tournaments

Push — master ( 547255...753a4f )

hasTeamsTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like