Completed
Push — master ( 547255...753a4f )
by Julien
11:37 queued 25s
created

hasCompetitorsTrait   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 30
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 1

Importance

Changes 0
Metric Value
wmc 3
lcom 0
cbo 1
dl 0
loc 30
rs 10
c 0
b 0
f 0

3 Methods

Rating   Name   Duplication   Size   Complexity  
A getFighter() 0 4 1
A getFighters() 0 4 1
A createByeFighter() 0 4 1
1
<?php
2
3
namespace Xoco70\LaravelTournaments\Traits;
4
5
6
use Illuminate\Support\Collection;
7
use Xoco70\LaravelTournaments\Models\Competitor;
8
9
trait hasCompetitorsTrait
10
{
11
    /**
12
     * get Fighter by Id.
13
     *
14
     * @param $competitorId
15
     *
16
     * @return Competitor
17
     */
18
    protected function getFighter($competitorId)
19
    {
20
        return Competitor::find($competitorId);
21
    }
22
23
    /**
24
     * Fighter is the name for competitor or team, depending on the case.
25
     *
26
     * @return Collection
27
     */
28
    protected function getFighters()
29
    {
30
        return $this->championship->competitors;
0 ignored issues
show
Bug introduced by
The property championship does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
31
    }
32
33
    protected function createByeFighter()
34
    {
35
        return new Competitor();
36
    }
37
38
}