Xoco70\KendoTournaments\TreeController

Complexity

Total Complexity

16

Size/Duplication

Total Lines	87
Duplicated Lines	16.09 %

Coupling/Cohesion

Components	1
Dependencies	14

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	12	1
C	store()	14	56	15

<?php

namespace Xoco70\KendoTournaments;

use Illuminate\Foundation\Auth\User;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\DB;
use Xoco70\KendoTournaments\Exceptions\TreeGenerationException;
use Xoco70\KendoTournaments\Models\Championship;
use Xoco70\KendoTournaments\Models\ChampionshipSettings;
use Xoco70\KendoTournaments\Models\Competitor;
use Xoco70\KendoTournaments\Models\FightersGroup;
use Xoco70\KendoTournaments\Models\Tournament;
use Xoco70\KendoTournaments\TreeGen\DirectEliminationCompetitorTreeGen;
use Xoco70\KendoTournaments\TreeGen\DirectEliminationTeamTreeGen;
use Xoco70\KendoTournaments\TreeGen\PlayOffCompetitorTreeGen;
use Xoco70\KendoTournaments\TreeGen\PlayOffTeamTreeGen;
use Xoco70\KendoTournaments\TreeGen\TreeGen;

class TreeController extends Controller
{
    /**
     * Display a listing of trees.
     *
     * @param Request $request
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        $tournament = Tournament::with(

The method first does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

            'competitors',
            'championshipSettings',
            'championships.settings',
            'championships.category')->first();

        return view('kendo-tournaments::tree.index')

The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

            ->with('tournament', $tournament)
            ->with('settings', $tournament->championships[0]->setting);
    }

    /**
     * Build Tree.
     *
     * @param Request $request
     * @param Championship $championship
     *
     * @return \Illuminate\Http\Response|string
     */
    public function store(Request $request, Championship $championship)
    {
        DB::table('fight')->delete();
        DB::table('fighters_groups')->delete();
        DB::table('fighters_group_competitor')->delete();
        DB::table('fighters_group_team')->delete();
        DB::table('competitor')->delete();
        DB::table('users')->where('id', '<>', 1)->delete();

        $championship = Championship::with('teams', 'users', 'category', 'settings')->find($championship->id);

The method find does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

        $numFighters = $request->numFighters;

        $users = factory(User::class, (int)$numFighters)->create();

        foreach ($users as $user) {

This code seems to be duplicated across your project.

            factory(Competitor::class)->create([
                'championship_id' => $championship->id,
                'user_id' => $user->id,
                'confirmed' => 1,
                'short_id' => $user->id
            ]);
        }
        $championship->settings = ChampionshipSettings::createOrUpdate($request, $championship);

        $generation = new TreeGen($championship, null);
        //TODO Set groupBy argument to NULL for now
        if ($championship->hasPreliminary() && $championship->category->isTeam()) {
            $generation = new PlayOffTeamTreeGen($championship, null);
        }
        if ($championship->hasPreliminary() && !$championship->category->isTeam()) {
            $generation = new PlayOffCompetitorTreeGen($championship, null);
        }
        if (!$championship->hasPreliminary() && $championship->isDirectEliminationType() && $championship->category->isTeam()) {

This code seems to be duplicated across your project.

            $generation = new DirectEliminationTeamTreeGen($championship, null);
        }
        if (!$championship->hasPreliminary() && $championship->isDirectEliminationType() && !$championship->category->isTeam()) {

This code seems to be duplicated across your project.

            $generation = new DirectEliminationCompetitorTreeGen($championship, null);
        }

        $fighterToUpdate = null;

$fighterToUpdate is not used, you could remove the assignment.

        try {
            $generation->run();
            FightersGroup::generateFights($championship);
            // For Now, We don't generate fights when Preliminary
            if ($championship->isDirectEliminationType() && !$championship->hasPreliminary()) {
                FightersGroup::generateNextRoundsFights($championship);
            }
        } catch (TreeGenerationException $e) {
            redirect()->back()
                ->withErrors([$numFighters . "-" . $e->getMessage()]);
        }
        return redirect()->back()
            ->with('numFighters', $numFighters)
            ->with('hasPreliminary', $championship->settings->hasPreliminary)
            ->with(['success', "Success"]);
    }
}