xoco70 / laravel-tournaments

database/migrations/2016_11_23_125509_create_Fight_table.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     public function up()
     {
-        Schema::create('fight', function (Blueprint $table) {
+        Schema::create('fight', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('short_id')->unsigned()->nullable();
             $table->integer('fighters_group_id')->unsigned()->index();

database/migrations/2015_12_03_230346_create_Category_table.php

Spacing +3 added lines, -3 removed lines

@@ -12,7 +12,7 @@ 
      */
     public function up()
     {
-        Schema::create('category', function (Blueprint $table) {
+        Schema::create('category', function(Blueprint $table) {
             $table->increments('id');
             $table->string('name');
             $table->string('gender')->nullable();
@@ -28,7 +28,7 @@ 
             $table->engine = 'InnoDB';
         });
 
-        Schema::create('championship', function (Blueprint $table) {
+        Schema::create('championship', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('tournament_id')->unsigned()->index();
             $table->integer('category_id')->unsigned()->index();
@@ -50,7 +50,7 @@ 
             $table->engine = 'InnoDB';
         });
 
-        Schema::create('competitor', function (Blueprint $table) {
+        Schema::create('competitor', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('short_id')->unsigned()->nullable();
             $table->integer('championship_id')->unsigned()->index();

database/migrations/2016_10_24_223706_create_FightersGroup_table.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     public function up()
     {
-        Schema::create('fighters_groups', function (Blueprint $table) {
+        Schema::create('fighters_groups', function(Blueprint $table) {
             $table->increments('id');
             $table->tinyInteger('short_id')->unsigned()->nullable();
             $table->integer('championship_id')->unsigned()->index();

src/TreeGen/PlayOffTreeGen.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     {
         if ($this->championship->hasPreliminary()) {
             $fightersGroup = $fightersByEntity->chunk($this->settings->preliminaryGroupSize);
-            if (!App::runningUnitTests()){
+            if (!App::runningUnitTests()) {
                 $fightersGroup = $fightersGroup->shuffle();
             }
         } else { // Round Robin

database/seeds/CompetitorSeeder.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use Faker\Factory as Faker;
 use Illuminate\Database\Seeder;
 use Illuminate\Foundation\Auth\User;
 use Xoco70\KendoTournaments\Models\Championship;

src/TreeController.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
             );
         }
 
-        $championship->settings =  ChampionshipSettings::createOrUpdate($request, $championship);
+        $championship->settings = ChampionshipSettings::createOrUpdate($request, $championship);
         $generation = $championship->chooseGenerationStrategy();
 
         try {

src/models/FightersGroup.php

Braces +3 added lines, -1 removed lines

@@ -49,7 +49,9 @@
     {
         foreach ($fightsByRound as $fight) {
             $parentGroup = $fight->group->parent;
-            if ($parentGroup == null) break;
+            if ($parentGroup == null) {
+                break;
+            }
             $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary
 
             // IN this $fight, is c1 or c2 has the info?

src/Models/DirectEliminationFight.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace Xoco70\KendoTournaments\Models;
 
-use Illuminate\Database\Eloquent\Model;
-use Illuminate\Support\Collection;
-
 class DirectEliminationFight extends Fight
 {
 

src/models/Fight.php

Braces +18 added lines, -6 removed lines

@@ -46,7 +46,9 @@ 
      */
     protected static function getActorsToFights(FightersGroup $group)
     {
-        if ($group == null) return null;
+        if ($group == null) {
+            return null;
+        }
         $fighters = $group->getFighters();
         $fighterType = $group->getFighterType();
         if (sizeof($fighters) == 0) {
@@ -186,18 +188,26 @@ 
      */
     public function hasDeterminedParent()
     {
-        if ($this->has2Fighters()) return true;
+        if ($this->has2Fighters()) {
+            return true;
+        }
         foreach ($this->group->children as $child) {
             $fight = $child->fights->get(0);
-            if ($fight->has2Fighters()) return false;
+            if ($fight->has2Fighters()) {
+                return false;
+            }
         }
         return true;
     }
 
     public function shouldBeInFightList()
     {
-        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) return false;
-        if ($this->has2Fighters()) return true;
+        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) {
+            return false;
+        }
+        if ($this->has2Fighters()) {
+            return true;
+        }
         // We aint in the first round, and there is 1 or 0 competitor
         // We check children, and see :
         // if there is 2  - 2 fighters -> undetermine, we cannot add it to fight list
@@ -223,7 +233,9 @@ 
     private function belongsToFirstRound()
     {
         $firstRoundFights = $this->group->championship->firstRoundFights->pluck('id')->toArray();
-        if (in_array($this->id, $firstRoundFights)) return true;
+        if (in_array($this->id, $firstRoundFights)) {
+            return true;
+        }
         return false;
     }