xoco70 / laravel-tournaments

src/Models/DirectEliminationFight.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace Xoco70\KendoTournaments\Models;
 
-use Illuminate\Database\Eloquent\Model;
-use Illuminate\Support\Collection;
-
 class DirectEliminationFight extends Fight
 {
     public function __construct(Fight $fight = null)

src/TreeGen/TreeGen.php

Unused Use Statements -2 removed lines

@@ -8,10 +8,8 @@
 use Xoco70\KendoTournaments\Exceptions\TreeGenerationException;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\ChampionshipSettings;
-use Xoco70\KendoTournaments\Models\DirectEliminationFight;
 use Xoco70\KendoTournaments\Models\Fight;
 use Xoco70\KendoTournaments\Models\FightersGroup;
-use Xoco70\KendoTournaments\Models\PreliminaryFight;
 
 class TreeGen implements TreeGenerable
 {

Braces +3 added lines, -1 removed lines

@@ -392,7 +392,9 @@
     {
         foreach ($groupsByRound as $keyGroup => $group) {
             $parentGroup = $group->parent;
-            if ($parentGroup == null) break;
+            if ($parentGroup == null) {
+                break;
+            }
             $parentFight = $parentGroup->fights->get(0);
 
             // determine whether c1 or c2 must be updated

src/models/FightersGroup.php

Braces +3 added lines, -1 removed lines

@@ -184,7 +184,9 @@
             return false;
         }
         foreach ($this->children as $child) {
-            if (sizeof($child->fighters()) > 1) return false;
+            if (sizeof($child->fighters()) > 1) {
+                return false;
+            }
         }
         return true;
 

src/models/Fight.php

Braces +12 added lines, -4 removed lines

@@ -46,7 +46,9 @@ 
      */
     protected static function getFightersWithByes(FightersGroup $group)
     {
-        if ($group == null) return null;
+        if ($group == null) {
+            return null;
+        }
         $fighters = $group->getFighters();
         $fighterType = $group->getFighterType();
         if (sizeof($fighters) == 0) {
@@ -121,8 +123,12 @@ 
 
     public function shouldBeInFightList()
     {
-        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) return false;
-        if ($this->has2Fighters()) return true;
+        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) {
+            return false;
+        }
+        if ($this->has2Fighters()) {
+            return true;
+        }
         // We aint in the first round, and there is 1 or 0 competitor
         // We check children, and see :
         // if there is 2  - 2 fighters -> undetermine, we cannot add it to fight list
@@ -148,7 +154,9 @@ 
     private function belongsToFirstRound()
     {
         $firstRoundFights = $this->group->championship->firstRoundFights->pluck('id')->toArray();
-        if (in_array($this->id, $firstRoundFights)) return true;
+        if (in_array($this->id, $firstRoundFights)) {
+            return true;
+        }
         return false;
     }