DirectEliminationFight - Code Metrics - Inspection of "updateParentFight seems to be working" - xoco70/laravel-tournaments - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0a3a64...75d382 )

by Julien

created 2017-06-05 18:05 UTC

DirectEliminationFight A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	20.41 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	2
dl	10
loc	49
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	10	10	2
B	saveFights()	0	31	5

How to fix Duplicated Code

<?php

namespace Xoco70\KendoTournaments\Models;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Collection;

class DirectEliminationFight extends Fight
{
    public function __construct(Fight $fight = null)

    {
        if ($fight!=null){
            $this->id= $fight->id;
            $this->short_id= $fight->short_id;
            $this->fighters_group_id= $fight->fighters_group_id;
            $this->c1= $fight->c1;
            $this->c2= $fight->c2;
        }
    }
    /**
     * @param Championship $championship
     */
    public static function saveFights(Championship $championship, $fromRound = 1)
    {
        $round = [];
        $groupsFromRound = $championship->groupsFromRound($fromRound)->get();
//        dd($groupsFromRound->map->id);

        foreach ($groupsFromRound as $group) {
            $fighters = parent::getFightersWithByes($group);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            $away = $fighters->splice(count($fighters) / 2); // 2
            $home = $fighters; // 1

            $countHome = count($home);
            $countAway = count($away);
            for ($i = 0; $i < $countHome + $countAway - 1; $i++) {
                for ($j = 0; $j < $countHome; $j++) {
                    $round[$i][$j]['Home'] = $home[$j];
                    $round[$i][$j]['Away'] = $away[$j];
                    $fight = new Fight();
                    $fight->fighters_group_id = $group->id;
                    $fight->c1 = $round[$i][$j]['Home']->id;
                    $fight->c2 = $round[$i][$j]['Away']->id;
                    $fight->area = $group->area;
                    $fight->save();

                }
                if ($countHome + $countAway - 1 > 2) {
                    $away->prepend($home->splice(1, 1)->shift());
                    $home->push($away->pop());
                }
            }
        }
    }


}

1		<?php
2
3		namespace Xoco70\KendoTournaments\Models;
4
5		use Illuminate\Database\Eloquent\Model;
6		use Illuminate\Support\Collection;
7
8		class DirectEliminationFight extends Fight
9		{
10	View Code Duplication	public function __construct(Fight $fight = null)
		0 ignored issues – show Duplication introduced 2017-06-05 18:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		if ($fight!=null){
13		$this->id= $fight->id;
14		$this->short_id= $fight->short_id;
15		$this->fighters_group_id= $fight->fighters_group_id;
16		$this->c1= $fight->c1;
17		$this->c2= $fight->c2;
18		}
19		}
20		/**
21		* @param Championship $championship
22		*/
23		public static function saveFights(Championship $championship, $fromRound = 1)
24		{
25		$round = [];
26		$groupsFromRound = $championship->groupsFromRound($fromRound)->get();
27		// dd($groupsFromRound->map->id);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-06-02 17:29 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28		foreach ($groupsFromRound as $group) {
29		$fighters = parent::getFightersWithByes($group);
		0 ignored issues – show Comprehensibility Bug introduced 2017-05-25 04:48 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getFightersWithByes()` instead of `saveFights()`). Are you sure this is correct? If so, you might want to change this to `$this->getFightersWithByes()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
30		$away = $fighters->splice(count($fighters) / 2); // 2
31		$home = $fighters; // 1
32
33		$countHome = count($home);
34		$countAway = count($away);
35		for ($i = 0; $i < $countHome + $countAway - 1; $i++) {
36		for ($j = 0; $j < $countHome; $j++) {
37		$round[$i][$j]['Home'] = $home[$j];
38		$round[$i][$j]['Away'] = $away[$j];
39		$fight = new Fight();
40		$fight->fighters_group_id = $group->id;
41		$fight->c1 = $round[$i][$j]['Home']->id;
42		$fight->c2 = $round[$i][$j]['Away']->id;
43		$fight->area = $group->area;
44		$fight->save();
45
46		}
47		if ($countHome + $countAway - 1 > 2) {
48		$away->prepend($home->splice(1, 1)->shift());
49		$home->push($away->pop());
50		}
51		}
52		}
53		}
54
55
56		}

xoco70 / laravel-tournaments

Push — master ( 0a3a64...75d382 )

DirectEliminationFight A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like