xoco70 / laravel-tournaments

database/migrations/2016_11_23_125509_create_Fight_table.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     public function up()
     {
-        Schema::create('fight', function (Blueprint $table) {
+        Schema::create('fight', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('short_id')->unsigned()->nullable();
             $table->integer('fighters_group_id')->unsigned()->index();

database/migrations/2015_12_03_230346_create_Category_table.php

Spacing +3 added lines, -3 removed lines

@@ -12,7 +12,7 @@ 
      */
     public function up()
     {
-        Schema::create('category', function (Blueprint $table) {
+        Schema::create('category', function(Blueprint $table) {
             $table->increments('id');
             $table->string('name');
             $table->string('gender')->nullable();
@@ -28,7 +28,7 @@ 
             $table->engine = 'InnoDB';
         });
 
-        Schema::create('championship', function (Blueprint $table) {
+        Schema::create('championship', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('tournament_id')->unsigned()->index();
             $table->integer('category_id')->unsigned()->index();
@@ -50,7 +50,7 @@ 
             $table->engine = 'InnoDB';
         });
 
-        Schema::create('competitor', function (Blueprint $table) {
+        Schema::create('competitor', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('short_id')->unsigned()->nullable();
             $table->integer('championship_id')->unsigned()->index();

database/migrations/2016_10_24_223706_create_FightersGroup_table.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     public function up()
     {
-        Schema::create('fighters_groups', function (Blueprint $table) {
+        Schema::create('fighters_groups', function(Blueprint $table) {
             $table->increments('id');
             $table->tinyInteger('short_id')->unsigned()->nullable();
             $table->integer('championship_id')->unsigned()->index();

resources/views/partials/tree/preliminary.blade.php

Indentation +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-  $settings = $championship->getSettings();
+    $settings = $championship->getSettings();
 ?>
 <div align="center">
     @if (Request::is('championships/'.$championship->id.'/pdf'))

src/models/Competitor.php

Braces +6 added lines, -2 removed lines

@@ -69,8 +69,12 @@
      */
     private function defaultName()
     {
-        if ($this == null) return "BYE";
-        if ($this->user == null) return "BYE";
+        if ($this == null) {
+            return "BYE";
+        }
+        if ($this->user == null) {
+            return "BYE";
+        }
         return null;
     }
 

src/TreeGen/TreeGen.php

Doc Comments +5 added lines, -5 removed lines

@@ -47,7 +47,7 @@ 
 
     /**
      * Get the biggest entity group
-     * @param $userGroups
+     * @param Collection $userGroups
      *
      * @return int
      */
@@ -104,7 +104,7 @@ 
 
     /**
      * Repart BYE in the tree,
-     * @param $fighterGroups
+     * @param Collection $fighterGroups
      * @param int $max
      *
      * @return Collection
@@ -185,9 +185,9 @@ 
     }
 
     /**
-     * @param $area
-     * @param $order
-     * @param $round
+     * @param integer $area
+     * @param integer $order
+     * @param integer $round
      * @param $parent
      * @return FightersGroup
      */

Spacing +3 added lines, -3 removed lines

@@ -55,7 +55,7 @@ 
     private function getMaxFightersByEntity($userGroups): int
     {
         return $userGroups
-            ->sortByDesc(function ($group) {
+            ->sortByDesc(function($group) {
                 return $group->count();
             })
             ->first()
@@ -91,7 +91,7 @@ 
     protected function getTreeSize($fighterCount, $groupSize)
     {
         $square = collect([1, 2, 4, 8, 16, 32, 64]);
-        $squareMultiplied = $square->map(function ($item, $key) use ($groupSize) {
+        $squareMultiplied = $square->map(function($item, $key) use ($groupSize) {
             return $item * $groupSize;
         });
 
@@ -174,7 +174,7 @@ 
             $order = 1;
             foreach ($fightersGroup as $fighters) {
                 $fighters = $fighters->pluck('id');
-                if (!App::runningUnitTests()){
+                if (!App::runningUnitTests()) {
                     $fighters = $fighters->shuffle();
                 }
                 $group = $this->saveGroup($area, $order, $round, null);

src/TreeController.php

Unused Use Statements -6 removed lines

@@ -6,18 +6,12 @@
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
 use Illuminate\Support\Facades\DB;
-use Xoco70\KendoTournaments\Contracts\TreeGenerable;
 use Xoco70\KendoTournaments\Exceptions\TreeGenerationException;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\ChampionshipSettings;
 use Xoco70\KendoTournaments\Models\Competitor;
 use Xoco70\KendoTournaments\Models\FightersGroup;
 use Xoco70\KendoTournaments\Models\Tournament;
-use Xoco70\KendoTournaments\TreeGen\DirectEliminationCompetitorTreeGen;
-use Xoco70\KendoTournaments\TreeGen\DirectEliminationTeamTreeGen;
-use Xoco70\KendoTournaments\TreeGen\PlayOffCompetitorTreeGen;
-use Xoco70\KendoTournaments\TreeGen\PlayOffTeamTreeGen;
-use Xoco70\KendoTournaments\TreeGen\TreeGen;
 
 class TreeController extends Controller
 {

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
                 ]
             );
         }
-        $championship->settings =  ChampionshipSettings::createOrUpdate($request, $championship);
+        $championship->settings = ChampionshipSettings::createOrUpdate($request, $championship);
         $generation = $championship->chooseGenerationStrategy();
 
         try {

src/models/FightersGroup.php

Braces +3 added lines, -1 removed lines

@@ -203,7 +203,9 @@
             $fightsByRound = $championship->fightsByRound($numRound)->with('group.parent')->get();
             foreach ($fightsByRound as $fight) {
                 $parentGroup = $fight->group->parent;
-                if ($parentGroup == null) break;
+                if ($parentGroup == null) {
+                    break;
+                }
                 $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary
 
                 // IN this $fight, is c1 or c2 has the info?

src/TreeGen/DirectEliminationTreeGen.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
         $fightersGroup = null;
 
         $fightersGroup = $fightersByEntity->chunk(2);
-        if (!App::runningUnitTests()){
+        if (!App::runningUnitTests()) {
             $fightersGroup = $fightersGroup->shuffle();
         }
         return $fightersGroup;