xoco70 / laravel-tournaments

database/factories/VenueFactory.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 use Xoco70\LaravelTournaments\Models\Venue;
 
-$factory->define(Venue::class, function (Faker\Generator $faker) {
+$factory->define(Venue::class, function(Faker\Generator $faker) {
     return [
         'venue_name' => $faker->colorName,
         'address'    => $faker->streetName,

database/factories/CategoryFactory.php

Spacing +1 added lines, -1 removed lines

@@ -3,7 +3,7 @@
 
 use Xoco70\LaravelTournaments\Models\Category as Cat;
 
-$factory->define(Cat::class, function (Faker\Generator $faker) {
+$factory->define(Cat::class, function(Faker\Generator $faker) {
     $name = ['categories.junior',
         'categories.junior_team',
         'categories.men_single',

database/factories/ChampionshipFactory.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
 use Xoco70\LaravelTournaments\Models\Championship;
 use Xoco70\LaravelTournaments\Models\Tournament;
 
-$factory->define(Championship::class, function (Faker\Generator $faker) {
+$factory->define(Championship::class, function(Faker\Generator $faker) {
     $tournaments = Tournament::all()->pluck('id')->toArray();
     $categories = Cat::all()->pluck('id')->toArray();
 

database/factories/TeamFactory.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 use Xoco70\LaravelTournaments\Models\Team;
 
-$factory->define(Team::class, function (Faker\Generator $faker) {
+$factory->define(Team::class, function(Faker\Generator $faker) {
     return [
         'name'            => $faker->name,
         'championship_id' => 2,

src/TreeGen/TreeGen.php

Spacing +3 added lines, -3 removed lines

@@ -72,7 +72,7 @@ 
     private function getMaxFightersByEntity($userGroups): int
     {
         return $userGroups
-            ->sortByDesc(function ($group) {
+            ->sortByDesc(function($group) {
                 return $group->count();
             })
             ->first()
@@ -113,7 +113,7 @@ 
     protected function getTreeSize($fighterCount, $groupSize)
     {
         $squareMultiplied = collect([1, 2, 4, 8, 16, 32, 64])
-            ->map(function ($item) use ($groupSize) {
+            ->map(function($item) use ($groupSize) {
                 return $item * $groupSize;
             }); // [4, 8, 16, 32, 64,...]
 
@@ -171,7 +171,7 @@ 
         $sizeGroupBy = count($byeGroup);
 
         $frequency = $sizeGroupBy != 0
-            ? (int) floor($sizeFighters / $sizeGroupBy)
+            ? (int)floor($sizeFighters / $sizeGroupBy)
             : -1;
 
         // Create Copy of $competitors

Doc Comments +13 added lines, -7 removed lines

@@ -22,8 +22,14 @@ 
     abstract protected function generateFights();
 
 
+    /**
+     * @param string|null $fighterToUpdate
+     */
     abstract protected function addFighterToGroup(FightersGroup $group, $fighter, $fighterToUpdate);
 
+    /**
+     * @return Collection
+     */
     abstract protected function getByeGroup($fighters);
 
     abstract protected function getNumRounds($fightersCount);
@@ -61,7 +67,7 @@ 
     /**
      * Get the biggest entity group.
      *
-     * @param $userGroups
+     * @param Collection $userGroups
      *
      * @return int
      */
@@ -130,7 +136,7 @@ 
     /**
      * Repart BYE in the tree,.
      *
-     * @param $fighterGroups
+     * @param Collection $fighterGroups
      * @param int $max
      *
      * @return Collection
@@ -288,7 +294,7 @@ 
     /**
      * Attach a parent to every child for nestedSet Navigation.
      *
-     * @param $numFightersElim
+     * @param integer $numFightersElim
      */
     protected function addParentToChildren($numFightersElim)
     {
@@ -312,8 +318,8 @@ 
 
     /**
      * @param Collection $fighters
-     * @param $frequency
-     * @param $sizeGroupBy
+     * @param integer $frequency
+     * @param integer $sizeGroupBy
      * @param $bye
      *
      * @return Collection
@@ -338,8 +344,8 @@ 
     /**
      * @param $frequency
      * @param $sizeGroupBy
-     * @param $count
-     * @param $byeCount
+     * @param integer $count
+     * @param integer $byeCount
      *
      * @return bool
      */

src/TreeController.php

Spacing +2 added lines, -2 removed lines

@@ -81,10 +81,10 @@
     {
         if ($isTeam) {
             $championship = Championship::find(2);
-            factory(Team::class, (int) $numFighters)->create(['championship_id' => $championship->id]);
+            factory(Team::class, (int)$numFighters)->create(['championship_id' => $championship->id]);
         } else {
             $championship = Championship::find(1);
-            $users = factory(User::class, (int) $numFighters)->create();
+            $users = factory(User::class, (int)$numFighters)->create();
             foreach ($users as $user) {
                 factory(Competitor::class)->create(
                     ['championship_id' => $championship->id,

Doc Comments +4 added lines, -1 removed lines

@@ -37,7 +37,7 @@ 
      *
      * @param Request $request
      *
-     * @return \Illuminate\Http\Response|string
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function store(Request $request, $championshipId)
     {
@@ -137,6 +137,9 @@ 
         return back();
     }
 
+    /**
+     * @param integer $numFighter
+     */
     public function getWinnerId($fighters, $scores, $numFighter)
     {
         return $scores[$numFighter] != null ? $fighters[$numFighter] : null;

src/Models/Competitor.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      */
     public function getFullName() //TODO Should remove get prefix
     {
-        return $this->defaultName() ?? $this->user->firstname.' '.$this->user->lastname;
+        return $this->defaultName() ?? $this->user->firstname . ' ' . $this->user->lastname;
     }
 
     /**

Doc Comments +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     /**
      * Get User from Competitor.
      *
-     * @return mixed
+     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
      */
     public function user()
     {

src/TreeGen/SingleEliminationTreeGen.php

Doc Comments +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
     /**
      * Create empty groups after round 1.
      *
-     * @param $numFighters
+     * @param integer $numFighters
      */
     protected function pushEmptyGroupsToTree($numFighters)
     {
@@ -155,7 +155,7 @@ 
 
     /**
      * @param Collection $usersByArea
-     * @param $round
+     * @param integer $round
      */
     public function generateGroupsForRound(Collection $usersByArea, $round)
     {

src/TreeGen/CreateSingleEliminationTree.php

Spacing +5 added lines, -5 removed lines

@@ -26,7 +26,7 @@ 
         $this->groupsByRound = $groupsByRound;
         $this->hasPreliminary = $hasPreliminary;
 
-        $this->firstRoundName = $groupsByRound->first()->map(function ($item) use ($championship) {
+        $this->firstRoundName = $groupsByRound->first()->map(function($item) use ($championship) {
             $fighters = $item->getFightersWithBye();
             $fighter1 = $fighters->get(0);
             $fighter2 = $fighters->get(1);
@@ -140,7 +140,7 @@ 
             //The minus 3 is to ignore the final, semi final and quarter final rounds
 
             for ($i = 0; $i < $noRounds - 3; $i++) {
-                $tempRounds[] = 'Last '.$noTeamsInFirstRound;
+                $tempRounds[] = 'Last ' . $noTeamsInFirstRound;
                 $noTeamsInFirstRound /= 2;
             }
 
@@ -162,7 +162,7 @@ 
         foreach ($roundTitles as $key => $roundTitle) {
             $left = $key * ($this->matchWrapperWidth + $this->roundSpacing - 1);
 
-            echo '<div class="round-title" style="left: '.$left.'px;">'.$roundTitle.'</div>';
+            echo '<div class="round-title" style="left: ' . $left . 'px;">' . $roundTitle . '</div>';
         }
         echo '</div>';
     }
@@ -175,7 +175,7 @@ 
     public function getPlayerList($selected)
     {
         $html = '<select>
-                <option'.($selected == '' ? ' selected' : '').'></option>';
+                <option'.($selected == '' ? ' selected' : '') . '></option>';
 
         foreach ($this->championship->fighters as $fighter) {
             $html = $this->addOptionToSelect($selected, $fighter, $html);
@@ -235,7 +235,7 @@ 
     {
         if ($fighter != null) {
             $select = $selected != null && $selected->id == $fighter->id ? ' selected' : '';
-            $html .= '<option'.$select
+            $html .= '<option' . $select
                 .' value='
                 .($fighter->id ?? '')
                 .'>'