xoco70 / laravel-tournaments

src/models/Tree.php

Doc Comments +1 added lines, -1 removed lines

@@ -218,7 +218,7 @@
 
     /**
      * @param Collection $tree
-     * @param $settings
+     * @param ChampionshipSettings $settings
      */
     public static function generateFights(Collection $tree, $settings, Championship $championship = null)
     {

src/TreeGen/TreeGen.php

Doc Comments +4 added lines, -1 removed lines

@@ -20,6 +20,9 @@ 
     public $championship, $settings;
 
 
+    /**
+     * @param \Xoco70\KendoTournaments\Models\ChampionshipSettings $settings
+     */
     public function __construct(Championship $championship, $groupBy, $settings)
     {
         $this->championship = $championship;
@@ -257,7 +260,7 @@ 
 
     /**
      * @param $userGroups
-     * @param $max
+     * @param integer $max
      * @return Collection
      */
     private function repart($userGroups, $max)

Braces +16 added lines, -6 removed lines

@@ -69,7 +69,7 @@ 
 
             } else if ($this->championship->isDirectEliminationType()) {
                 $roundRobinGroups = $users->chunk(2)->shuffle();
-            }else{
+            } else{
                 $roundRobinGroups = new Collection();
 
                 // Not so good, Round Robin has no trees
@@ -106,11 +106,21 @@ 
                 $c4 = $robinGroup->get(3);
                 $c5 = $robinGroup->get(4);
 
-                if (isset($c1)) $pt->c1 = $c1->id;
-                if (isset($c2)) $pt->c2 = $c2->id;
-                if (isset($c3)) $pt->c3 = $c3->id;
-                if (isset($c4)) $pt->c4 = $c4->id;
-                if (isset($c5)) $pt->c5 = $c5->id;
+                if (isset($c1)) {
+                    $pt->c1 = $c1->id;
+                }
+                if (isset($c2)) {
+                    $pt->c2 = $c2->id;
+                }
+                if (isset($c3)) {
+                    $pt->c3 = $c3->id;
+                }
+                if (isset($c4)) {
+                    $pt->c4 = $c4->id;
+                }
+                if (isset($c5)) {
+                    $pt->c5 = $c5->id;
+                }
                 $pt->save();
                 $trees->push($pt);
                 $order++;

resources/views/partials/tree/directElimination.blade.php

Braces +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 
         $user1 = $item->team1 != null ? $item->team1->name : "Bye";
         $user2 = $item->team2 != null ? $item->team2->name : "Bye";
-    }else{
+    } else{
         $user1 = $item->user1 != null ? $item->user1->name : "Bye";
         $user2 = $item->user2 != null ? $item->user2->name : "Bye";
     }

src/models/Fight.php

Braces +30 added lines, -10 removed lines

@@ -43,17 +43,37 @@
         } else {
             $fighters = new Collection;
             if ($championship->category->isTeam) {
-                if ($treeGroup->c1 != null) $fighters->push($treeGroup->team1);
-                if ($treeGroup->c2 != null) $fighters->push($treeGroup->team2);
-                if ($treeGroup->c3 != null) $fighters->push($treeGroup->team3);
-                if ($treeGroup->c4 != null) $fighters->push($treeGroup->team4);
-                if ($treeGroup->c5 != null) $fighters->push($treeGroup->team5);
+                if ($treeGroup->c1 != null) {
+                    $fighters->push($treeGroup->team1);
+                }
+                if ($treeGroup->c2 != null) {
+                    $fighters->push($treeGroup->team2);
+                }
+                if ($treeGroup->c3 != null) {
+                    $fighters->push($treeGroup->team3);
+                }
+                if ($treeGroup->c4 != null) {
+                    $fighters->push($treeGroup->team4);
+                }
+                if ($treeGroup->c5 != null) {
+                    $fighters->push($treeGroup->team5);
+                }
             } else {
-                if ($treeGroup->c1 != null) $fighters->push($treeGroup->user1);
-                if ($treeGroup->c2 != null) $fighters->push($treeGroup->user2);
-                if ($treeGroup->c3 != null) $fighters->push($treeGroup->user3);
-                if ($treeGroup->c4 != null) $fighters->push($treeGroup->user4);
-                if ($treeGroup->c5 != null) $fighters->push($treeGroup->user5);
+                if ($treeGroup->c1 != null) {
+                    $fighters->push($treeGroup->user1);
+                }
+                if ($treeGroup->c2 != null) {
+                    $fighters->push($treeGroup->user2);
+                }
+                if ($treeGroup->c3 != null) {
+                    $fighters->push($treeGroup->user3);
+                }
+                if ($treeGroup->c4 != null) {
+                    $fighters->push($treeGroup->user4);
+                }
+                if ($treeGroup->c5 != null) {
+                    $fighters->push($treeGroup->user5);
+                }
             }
         }
         if ($championship->category->isTeam) {

Doc Comments +4 added lines, -1 removed lines

@@ -106,7 +106,7 @@ 
 
     /**
      * Save a Fight.
-     * @param $tree
+     * @param Collection $tree
      * @param int $numRound
      */
     public static function saveFightRound($tree, $numRound = 1)
@@ -166,6 +166,9 @@ 
 //        }
 //    }
 
+    /**
+     * @param Collection $tree
+     */
     public static function saveRoundRobinFights(Championship $championship, $tree)
     {