Xoco70\KendoTournaments\TreeGen\DirectEliminationTreeGen

Complexity

Total Complexity

4

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	2
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getByeGroup()	0	8	1
A	pushEmptyGroupsToTree()	0	6	1
A	chunkAndShuffle()	0	10	2

<?php

namespace Xoco70\KendoTournaments\TreeGen;

use Illuminate\Support\Collection;
use Xoco70\KendoTournaments\Models\Championship;

class DirectEliminationTreeGen extends TreeGen
{

    /**
     * Calculate the Byes need to fill the Championship Tree.
     * @param Championship $championship
     * @return Collection
     */
    protected function getByeGroup(Championship $championship, $fighters)

The parameter $championship is not used and could be removed.

    {
        $fighterCount = $fighters->count();
        $treeSize = $this->getTreeSize($fighterCount, $preliminaryGroupSize = 2);
        $byeCount = $treeSize - $fighterCount;

        return $this->createNullsGroup($byeCount);
    }


    /**
     * Create empty groups for direct Elimination Tree
     * @param $numFightersEliminatory
     */
    public function pushEmptyGroupsToTree($numFightersEliminatory)
    {
        // We calculate how much rounds we will have
        $numRounds = intval(log($numFightersEliminatory, 2));
        $this->pushGroups($numRounds, $numFightersEliminatory);
    }

    /**
     * Chunk Fighters into groups for fighting, and optionnaly shuffle
     * @param $round
     * @param $shuffle
     * @param $fightersByEntity
     * @return Collection|null
     */
    protected function chunkAndShuffle($round, $shuffle, $fightersByEntity)

The parameter $round is not used and could be removed.

    {
        $fightersGroup = null;

$fightersGroup is not used, you could remove the assignment.

        $fightersGroup = $fightersByEntity->chunk(2);
        if ($shuffle) {
            $fightersGroup = $fightersGroup->shuffle();
        }
        return $fightersGroup;
    }
}