TreeController::store() - Code Metrics - Inspection of "refactoring" - xoco70/laravel-tournaments - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 028749...4233d7 )

by Julien

created 2017-02-16 04:22 UTC

TreeController::store() B

↳ Parent: TreeController

Complexity

Conditions	2
Paths	3

Size

Total Lines	45
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	45
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	20
nc	3
nop	2

<?php

namespace Xoco70\KendoTournaments;

use Illuminate\Routing\Controller;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\DB;
use Xoco70\KendoTournaments\Exceptions\TreeGenerationException;
use Xoco70\KendoTournaments\Models\Championship;
use Xoco70\KendoTournaments\Models\ChampionshipSettings;
use Xoco70\KendoTournaments\Models\Round;
use Xoco70\KendoTournaments\Models\Tournament;
use Xoco70\KendoTournaments\TreeGen\TreeGen;

class TreeController extends Controller
{
    /**
     * Display a listing of trees.
     *
     * @param Request $request
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index(Request $request)

    {
        $tournament = Tournament::with(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'competitors',
            'championshipSettings',
            'championships.settings',
            'championships.category')->first();

        return view('kendo-tournaments::tree.index')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('tournament', $tournament)
            ->with('settings', $tournament->championships[0]->setting);

    }

    /**
     * Build Tree
     *
     * @param Request $request
     * @param Championship $championship
     * @return \Illuminate\Http\Response|string
     */
    public function store(Request $request, Championship $championship)
    {


        DB::table('fight')->delete();
        DB::table('round')->delete();
        DB::table('round_competitor')->delete();
        DB::table('round_team')->delete();

        $tournament = Tournament::with(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'competitors',
            'championshipSettings'
        )->first();

        $championship = Championship::with('teams', 'users', 'category', 'settings')->find($championship->id);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

//        $numFighters = $request->numFighters;


//        $users = factory(User::class, (int)$numFighters)->create();

//
//        foreach ($users as $user) {
//            factory(Competitor::class)->create([
//                'championship_id' => $championship->id,
//                'user_id' => $user->id,
//                'confirmed' => 1,
//            ]);
//        }

        $settings = ChampionshipSettings::createOrUpdate($request, $championship);

        //TODO Set groupBy argument to NULL for now
        $generation = new TreeGen($championship, null, $settings);
        try {

            $rounds = $generation->run();
            Round::generateFights($rounds, $settings, $championship);

        } catch (TreeGenerationException $e) {
            return view('kendo-tournaments::tree.index')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                ->with('tournament', $tournament)
                ->with('error', "Error Generating Tree");
        }

        return redirect()->back();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }


}


Push — master ( 028749...4233d7 )

TreeController::store() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Xoco70\KendoTournaments;
4
5			use Illuminate\Routing\Controller;
6			use Illuminate\Http\Request;
7			use Illuminate\Support\Facades\DB;
8			use Xoco70\KendoTournaments\Exceptions\TreeGenerationException;
9			use Xoco70\KendoTournaments\Models\Championship;
10			use Xoco70\KendoTournaments\Models\ChampionshipSettings;
11			use Xoco70\KendoTournaments\Models\Round;
12			use Xoco70\KendoTournaments\Models\Tournament;
13			use Xoco70\KendoTournaments\TreeGen\TreeGen;
14
15			class TreeController extends Controller
16			{
17			/**
18			* Display a listing of trees.
19			*
20			* @param Request $request
21			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
22			*/
23			public function index(Request $request)
			0 ignored issues – show Unused Code introduced 2017-02-09 21:46 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
24			{
25			$tournament = Tournament::with(
			0 ignored issues – show Bug introduced 2017-02-09 21:13 UTC by Report Bug Copy Issue Report The method `first` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
26			'competitors',
27			'championshipSettings',
28			'championships.settings',
29			'championships.category')->first();
30
31			return view('kendo-tournaments::tree.index')
			0 ignored issues – show Bug introduced 2017-02-09 21:46 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
32			->with('tournament', $tournament)
33			->with('settings', $tournament->championships[0]->setting);
34
35			}
36
37			/**
38			* Build Tree
39			*
40			* @param Request $request
41			* @param Championship $championship
42			* @return \Illuminate\Http\Response\|string
43			*/
44			public function store(Request $request, Championship $championship)
45			{
46
47
48			DB::table('fight')->delete();
49			DB::table('round')->delete();
50			DB::table('round_competitor')->delete();
51			DB::table('round_team')->delete();
52
53			$tournament = Tournament::with(
			0 ignored issues – show Bug introduced 2017-02-09 21:13 UTC by Report Bug Copy Issue Report The method `first` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
54			'competitors',
55			'championshipSettings'
56			)->first();
57
58			$championship = Championship::with('teams', 'users', 'category', 'settings')->find($championship->id);
			0 ignored issues – show Bug introduced 2017-02-09 21:13 UTC by Report Bug Copy Issue Report The method `find` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
59
60			// $numFighters = $request->numFighters;
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-12 21:18 UTC by Report Bug Copy Issue Report `45%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
61
62			// $users = factory(User::class, (int)$numFighters)->create();
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-12 07:08 UTC by Report Bug Copy Issue Report `52%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
63			//
64			// foreach ($users as $user) {
65			// factory(Competitor::class)->create([
66			// 'championship_id' => $championship->id,
67			// 'user_id' => $user->id,
68			// 'confirmed' => 1,
69			// ]);
70			// }
71
72			$settings = ChampionshipSettings::createOrUpdate($request, $championship);
73
74			//TODO Set groupBy argument to NULL for now
75			$generation = new TreeGen($championship, null, $settings);
76			try {
77
78			$rounds = $generation->run();
79			Round::generateFights($rounds, $settings, $championship);
80
81			} catch (TreeGenerationException $e) {
82			return view('kendo-tournaments::tree.index')
			0 ignored issues – show Bug introduced 2017-02-09 21:46 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
83			->with('tournament', $tournament)
84			->with('error', "Error Generating Tree");
85			}
86
87			return redirect()->back();
			0 ignored issues – show Bug Best Practice introduced 2017-02-15 23:43 UTC by Report Bug Copy Issue Report The return type of `return redirect()->back();` (`Illuminate\Http\RedirectResponse`) is incompatible with the return type documented by `Xoco70\KendoTournaments\TreeController::store` of type `Illuminate\Http\Response\|string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
88			}
89
90
91			}
92

xoco70 / laravel-tournaments

Push — master ( 028749...4233d7 )

TreeController::store() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like