Passed
Push — master ( 3dfec8...77351e )
by Julien
06:18
created
src/TreeGen/SingleEliminationTreeGen.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     /**
51 51
      * Create empty groups for direct Elimination Tree.
52 52
      *
53
-     * @param $numFighters
53
+     * @param integer $numFighters
54 54
      */
55 55
     protected function pushEmptyGroupsToTree($numFighters)
56 56
     {
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 
148 148
     /**
149 149
      * @param Collection $usersByArea
150
-     * @param $round
150
+     * @param integer $round
151 151
      */
152 152
     public function generateGroupsForRound(Collection $usersByArea, $round)
153 153
     {
Please login to merge, or discard this patch.
src/TreeGen/CreateSingleEliminationTree.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
         $this->groupsByRound = $groupsByRound;
27 27
         $this->hasPreliminary = $hasPreliminary;
28 28
 
29
-        $this->firstRoundName = $groupsByRound->first()->map(function ($item) use ($championship) {
29
+        $this->firstRoundName = $groupsByRound->first()->map(function($item) use ($championship) {
30 30
             $fighters = $item->getFightersWithBye();
31 31
             $fighter1 = $fighters->get(0);
32 32
             $fighter2 = $fighters->get(1);
Please login to merge, or discard this patch.
src/TreeGen/PlayOffTreeGen.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      *
31 31
      * @param $fightersByEntity
32 32
      *
33
-     * @return mixed
33
+     * @return Collection
34 34
      */
35 35
     protected function chunkAndShuffle(Collection $fightersByEntity)
36 36
     {
@@ -97,6 +97,9 @@  discard block
 block discarded – undo
97 97
         }
98 98
     }
99 99
 
100
+    /**
101
+     * @param integer $round
102
+     */
100 103
     protected function generateGroupsForRound(Collection $fightersByArea, $round)
101 104
     {
102 105
         $fightersId = $fightersByArea->pluck('id');
Please login to merge, or discard this patch.
resources/views/partials/tree/brackets/playerList.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,10 +1,10 @@
 block discarded – undo
1 1
 <?php
2 2
 $prefix = "singleElimination";
3
-if ($championship->hasPreliminary() && $roundNumber ==1){
3
+if ($championship->hasPreliminary() && $roundNumber == 1) {
4 4
     $prefix = "preliminary";
5 5
 }
6
-$className = $prefix."_select";
7
-$selectName = $prefix."_fighters[]";
6
+$className = $prefix . "_select";
7
+$selectName = $prefix . "_fighters[]";
8 8
 
9 9
 ?>
10 10
 <!-- r = round, m = match, f = fighter -->
Please login to merge, or discard this patch.
src/TreeController.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
      *
38 38
      * @param Request $request
39 39
      *
40
-     * @return \Illuminate\Http\Response|string
40
+     * @return \Illuminate\Http\RedirectResponse
41 41
      */
42 42
     public function store(Request $request, $championshipId)
43 43
     {
@@ -137,6 +137,9 @@  discard block
 block discarded – undo
137 137
     }
138 138
 
139 139
 
140
+    /**
141
+     * @param integer $numFighter
142
+     */
140 143
     function getWinnerId($fighters, $scores, $numFighter)
141 144
     {
142 145
         return $scores[$numFighter] != null ? $fighters[$numFighter] : null;
Please login to merge, or discard this patch.