xoco70 / laravel-tournaments

src/Models/PreliminaryFight.php

Spacing +6 added lines, -6 removed lines

@@ -9,12 +9,12 @@
 
     public function __construct(Fight $fight = null)
     {
-        if ($fight!=null){
-            $this->id= $fight->id;
-            $this->short_id= $fight->short_id;
-            $this->fighters_group_id= $fight->fighters_group_id;
-            $this->c1= $fight->c1;
-            $this->c2= $fight->c2;
+        if ($fight != null) {
+            $this->id = $fight->id;
+            $this->short_id = $fight->short_id;
+            $this->fighters_group_id = $fight->fighters_group_id;
+            $this->c1 = $fight->c1;
+            $this->c2 = $fight->c2;
         }
     }
 

src/models/FightersGroup.php

Spacing +1 added lines, -1 removed lines

@@ -180,7 +180,7 @@
     public function hasDeterminedParent()
     {
         // There is more than 1 fight, should be Preliminary
-        if (sizeof($this->fighters()) > 1){
+        if (sizeof($this->fighters()) > 1) {
             return false;
         }
         foreach ($this->children as $child) {

Braces +3 added lines, -1 removed lines

@@ -184,7 +184,9 @@
             return false;
         }
         foreach ($this->children as $child) {
-            if (sizeof($child->fighters()) > 1) return false;
+            if (sizeof($child->fighters()) > 1) {
+                return false;
+            }
         }
         return true;
 

src/TreeGen/DirectEliminationTreeGen.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Support\Facades\App;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\DirectEliminationFight;
-use Xoco70\KendoTournaments\Models\Fight;
 
 abstract class DirectEliminationTreeGen extends TreeGen
 {

src/TreeGen/PlayOffTreeGen.php

Doc Comments +1 added lines, -2 removed lines

@@ -15,7 +15,6 @@ 
 
     /**
      * Calculate the Byes need to fill the Championship Tree.
-     * @param Championship $championship
      * @param $fighters
      * @return Collection
      */
@@ -65,7 +64,7 @@ 
      * Chunk Fighters into groups for fighting, and optionnaly shuffle
      * @param $round
      * @param $fightersByEntity
-     * @return mixed
+     * @return Collection
      */
     protected function chunkAndShuffle($round, Collection $fightersByEntity)
     {

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Support\Facades\App;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\DirectEliminationFight;
-use Xoco70\KendoTournaments\Models\Fight;
 use Xoco70\KendoTournaments\Models\PreliminaryFight;
 
 abstract class PlayOffTreeGen extends TreeGen

src/TreeGen/CreateDirectEliminationTree.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
         $this->groupsByRound = $groupsByRound;
         $this->hasPreliminary = $hasPreliminary;
 
-        $this->firstRoundName = $groupsByRound->first()->map(function ($item) use ($championship) {
+        $this->firstRoundName = $groupsByRound->first()->map(function($item) use ($championship) {
             $fighters = $item->getFightersWithBye();
             $fighter1 = $fighters->get(0);
             $fighter2 = $fighters->get(1);

src/models/Fight.php

Braces +12 added lines, -4 removed lines

@@ -44,7 +44,9 @@ 
      */
     protected static function getFightersWithByes(FightersGroup $group)
     {
-        if ($group == null) return null;
+        if ($group == null) {
+            return null;
+        }
         $fighters = $group->getFightersWithBye();
         $fighterType = $group->getFighterType();
         if (sizeof($fighters) == 0) {
@@ -127,8 +129,12 @@ 
      */
     public function shouldBeInFightList()
     {
-        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) return false;
-        if ($this->has2Fighters()) return true;
+        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) {
+            return false;
+        }
+        if ($this->has2Fighters()) {
+            return true;
+        }
         // We aint in the first round, and there is 1 or 0 competitor
         // We check children, and see :
         // if there is 2  - 2 fighters -> undetermine, we cannot add it to fight list
@@ -157,7 +163,9 @@ 
     private function belongsToFirstRound()
     {
         $firstRoundFights = $this->group->championship->firstRoundFights->pluck('id')->toArray();
-        if (in_array($this->id, $firstRoundFights)) return true;
+        if (in_array($this->id, $firstRoundFights)) {
+            return true;
+        }
         return false;
     }
 

database/factories/ChampionshipFactory.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\Tournament;
 
-$factory->define(Championship::class, function (Faker\Generator $faker) {
+$factory->define(Championship::class, function(Faker\Generator $faker) {
     $tournaments = Tournament::all()->pluck('id')->toArray();
     $categories = Cat::all()->pluck('id')->toArray();
 

database/factories/CategoryFactory.php

Spacing +1 added lines, -1 removed lines

@@ -3,7 +3,7 @@
 
 use Xoco70\KendoTournaments\Models\Category as Cat;
 
-$factory->define(Cat::class, function (Faker\Generator $faker) {
+$factory->define(Cat::class, function(Faker\Generator $faker) {
     $name = ['categories.junior',
         'categories.junior_team',
         'categories.men_single',

src/TreeController.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\ChampionshipSettings;
 use Xoco70\KendoTournaments\Models\Competitor;
-use Xoco70\KendoTournaments\Models\Fight;
 use Xoco70\KendoTournaments\Models\FightersGroup;
 use Xoco70\KendoTournaments\Models\Team;
 use Xoco70\KendoTournaments\Models\Tournament;

Doc Comments +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      *
      * @param Request $request
      *
-     * @return \Illuminate\Http\Response|string
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function store(Request $request, $championshipId)
     {

Spacing +2 added lines, -2 removed lines

@@ -118,8 +118,8 @@
         $query = FightersGroup::with('fights')
             ->where('championship_id', $championship->id);
 
-        if ($championship->hasPreliminary()){
-            $query = $query->where('round','>',1);
+        if ($championship->hasPreliminary()) {
+            $query = $query->where('round', '>', 1);
         }
         $groups = $query->get();
         $fights = $request->fights;