xoco70 / laravel-tournaments

database/migrations/2014_10_12_000000_create_users_table.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
      */
     public function up()
     {
-        Schema::create('users', function (Blueprint $table) {
+        Schema::create('users', function(Blueprint $table) {
             $table->increments('id');
             $table->string('name');
             $table->string('email')->unique();

database/factories/TeamFactory.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 use Xoco70\LaravelTournaments\Models\Team;
 
-$factory->define(Team::class, function (Faker\Generator $faker) {
+$factory->define(Team::class, function(Faker\Generator $faker) {
     return [
         'name'            => $faker->name,
         'championship_id' => 2,

database/factories/CompetitorFactory.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 use Xoco70\LaravelTournaments\Models\Championship;
 use Xoco70\LaravelTournaments\Models\Competitor;
 
-$factory->define(Competitor::class, function (Faker\Generator $faker) {
+$factory->define(Competitor::class, function(Faker\Generator $faker) {
     $tcs = Championship::all()->pluck('id')->toArray();
     $users = User::all()->pluck('id')->toArray();
     $championshipId = $faker->randomElement($tcs);

database/migrations/2014_10_12_000010_add_users_fields_table.php

Spacing +3 added lines, -3 removed lines

@@ -13,7 +13,7 @@ 
      */
     public function up()
     {
-        Schema::table('users', function ($table) {
+        Schema::table('users', function($table) {
             $table->string('firstname')->default('firstname');
             $table->string('lastname')->default('lastname');
         });
@@ -28,12 +28,12 @@ 
     {
         DBHelpers::setFKCheckOff();
         if (Schema::hasColumn('users', 'firstname')) {
-            Schema::table('users', function (Blueprint $table) {
+            Schema::table('users', function(Blueprint $table) {
                 $table->dropColumn('firstname');
             });
         }
         if (Schema::hasColumn('users', 'lastname')) {
-            Schema::table('users', function (Blueprint $table) {
+            Schema::table('users', function(Blueprint $table) {
                 $table->dropColumn('lastname');
             });
         }

src/models/Competitor.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      */
     public function getFullName() //TODO Should remove get prefix
     {
-        return $this->defaultName() ?? $this->user->firstname.' '.$this->user->lastname;
+        return $this->defaultName() ?? $this->user->firstname . ' ' . $this->user->lastname;
     }
 
     /**

src/models/Championship.php

Spacing +3 added lines, -3 removed lines

@@ -28,11 +28,11 @@ 
     {
         parent::boot();
 
-        static::deleting(function ($championship) {
+        static::deleting(function($championship) {
             $championship->competitors()->delete();
             $championship->settings()->delete();
         });
-        static::restoring(function ($championship) {
+        static::restoring(function($championship) {
             $championship->competitors()->restore();
             $championship->settings()->restore();
         });
@@ -195,7 +195,7 @@ 
         $ageCategoryText = $this->category->getAgeString();
         $gradeText = $this->category->getGradeString();
 
-        return $teamText.' '.$genders[$this->category->gender].' '.$ageCategoryText.' '.$gradeText;
+        return $teamText . ' ' . $genders[$this->category->gender] . ' ' . $ageCategoryText . ' ' . $gradeText;
     }
 
     public function getSettings()

src/TreeGen/TreeGen.php

Spacing +2 added lines, -2 removed lines

@@ -76,7 +76,7 @@ 
     private function getMaxFightersByEntity($userGroups): int
     {
         return $userGroups
-            ->sortByDesc(function ($group) {
+            ->sortByDesc(function($group) {
                 return $group->count();
             })
             ->first()
@@ -114,7 +114,7 @@ 
     protected function getTreeSize($fighterCount, $groupSize)
     {
         $squareMultiplied = collect([1, 2, 4, 8, 16, 32, 64])
-            ->map(function ($item) use ($groupSize) {
+            ->map(function($item) use ($groupSize) {
                 return $item * $groupSize;
             }); // [4, 8, 16, 32, 64,...]
 

Doc Comments +14 added lines, -8 removed lines

@@ -34,8 +34,14 @@ 
 
     abstract protected function generateGroupsForRound(Collection $fightersByArea, $round);
 
+    /**
+     * @return Collection
+     */
     abstract protected function getByeGroup($fighters);
 
+    /**
+     * @param integer $fighterId
+     */
     abstract protected function getFighter($fighterId);
 
     abstract protected function getFighters();
@@ -114,7 +120,7 @@ 
     /**
      * Get the biggest entity group.
      *
-     * @param $userGroups
+     * @param Collection $userGroups
      *
      * @return int
      */
@@ -182,7 +188,7 @@ 
     /**
      * Repart BYE in the tree,.
      *
-     * @param $fighterGroups
+     * @param Collection $fighterGroups
      * @param int $max
      *
      * @return Collection
@@ -342,7 +348,7 @@ 
     /**
      * Attach a parent to every child for nestedSet Navigation.
      *
-     * @param $numFightersElim
+     * @param integer $numFightersElim
      */
     protected function addParentToChildren($numFightersElim)
     {
@@ -366,8 +372,8 @@ 
 
     /**
      * @param Collection $fighters
-     * @param $frequency
-     * @param $sizeGroupBy
+     * @param integer $frequency
+     * @param integer $sizeGroupBy
      * @param $bye
      *
      * @return Collection
@@ -392,8 +398,8 @@ 
     /**
      * @param $frequency
      * @param $sizeGroupBy
-     * @param $count
-     * @param $byeCount
+     * @param integer $count
+     * @param integer $byeCount
      *
      * @return bool
      */
@@ -511,7 +517,7 @@ 
 
     /**
      * @param $fighters
-     * @param $numFighter
+     * @param integer $numFighter
      * @param $fight
      * @param $winners
      * @return int

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\DB;
 use Xoco70\LaravelTournaments\Contracts\TreeGenerable;
-use Xoco70\LaravelTournaments\Exceptions\DuplicatedException;
 use Xoco70\LaravelTournaments\Exceptions\DuplicatedFighterException;
 use Xoco70\LaravelTournaments\Exceptions\TreeGenerationException;
 use Xoco70\LaravelTournaments\Models\Championship;

src/TournamentsServiceProvider.php

Spacing +8 added lines, -8 removed lines

@@ -16,18 +16,18 @@
      */
     public function boot(Router $router)
     {
-        $viewPath = __DIR__.'/../resources/views';
+        $viewPath = __DIR__ . '/../resources/views';
         $this->loadViewsFrom($viewPath, 'laravel-tournaments');
 
-        $this->loadMigrationsFrom(__DIR__.'/../database/migrations');
-        $this->loadTranslationsFrom(__DIR__.'/../translations', 'laravel-tournaments');
+        $this->loadMigrationsFrom(__DIR__ . '/../database/migrations');
+        $this->loadTranslationsFrom(__DIR__ . '/../translations', 'laravel-tournaments');
 
-        $this->publishes([__DIR__.'/../database/migrations' => $this->app->databasePath().'/migrations'], 'laravel-tournaments');
-        $this->publishes([__DIR__.'/../database/seeds' => $this->app->databasePath().'/seeds'], 'laravel-tournaments');
-        $this->publishes([__DIR__.'/../database/factories' => $this->app->databasePath().'/factories'], 'laravel-tournaments');
-        $this->publishes([__DIR__.'/../resources/assets' => public_path('vendor/laravel-tournaments')], 'laravel-tournaments');
+        $this->publishes([__DIR__ . '/../database/migrations' => $this->app->databasePath() . '/migrations'], 'laravel-tournaments');
+        $this->publishes([__DIR__ . '/../database/seeds' => $this->app->databasePath() . '/seeds'], 'laravel-tournaments');
+        $this->publishes([__DIR__ . '/../database/factories' => $this->app->databasePath() . '/factories'], 'laravel-tournaments');
+        $this->publishes([__DIR__ . '/../resources/assets' => public_path('vendor/laravel-tournaments')], 'laravel-tournaments');
 
-        $router->group(['prefix' => 'laravel-tournaments', 'middleware' => ['web']], function ($router) {
+        $router->group(['prefix' => 'laravel-tournaments', 'middleware' => ['web']], function($router) {
             $router->get('/', 'Xoco70\LaravelTournaments\TreeController@index')->name('tree.index');
             $router->post('/championships/{championship}/trees', 'Xoco70\LaravelTournaments\TreeController@store')->name('tree.store');
             $router->put('/championships/{championship}/trees', 'Xoco70\LaravelTournaments\TreeController@update')->name('tree.update');

resources/views/partials/tree/brackets/fight.blade.php

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-$topOffset = ($numRound == 1 ? 0 : (pow(2, $numRound-1)-1) * 51);
+$topOffset = ($numRound == 1 ? 0 : (pow(2, $numRound - 1) - 1) * 51);
 $top = \App\Bracket::getTopFight($numRound, $numFight) + $topOffset;
 
 $left = \App\Bracket::getLeftFight($numRound);