@@ -49,7 +49,9 @@ |
||
| 49 | 49 | { |
| 50 | 50 | foreach ($fightsByRound as $fight) { |
| 51 | 51 | $parentGroup = $fight->group->parent; |
| 52 | - if ($parentGroup == null) break; |
|
| 52 | + if ($parentGroup == null) { |
|
| 53 | + break; |
|
| 54 | + } |
|
| 53 | 55 | $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary |
| 54 | 56 | |
| 55 | 57 | // IN this $fight, is c1 or c2 has the info? |
@@ -169,8 +169,9 @@ |
||
| 169 | 169 | |
| 170 | 170 | public function buildName() |
| 171 | 171 | { |
| 172 | - if ($this->settings != null && $this->settings->alias != null) |
|
| 173 | - return $this->settings->alias; |
|
| 172 | + if ($this->settings != null && $this->settings->alias != null) { |
|
| 173 | + return $this->settings->alias; |
|
| 174 | + } |
|
| 174 | 175 | |
| 175 | 176 | if ($this->hasNoCustomSettings()) { |
| 176 | 177 | return $this->category->name; |
@@ -48,7 +48,7 @@ discard block |
||
| 48 | 48 | |
| 49 | 49 | /** |
| 50 | 50 | * Get the biggest entity group |
| 51 | - * @param $userGroups |
|
| 51 | + * @param Collection $userGroups |
|
| 52 | 52 | * |
| 53 | 53 | * @return int |
| 54 | 54 | */ |
@@ -107,7 +107,7 @@ discard block |
||
| 107 | 107 | |
| 108 | 108 | /** |
| 109 | 109 | * Repart BYE in the tree, |
| 110 | - * @param $fighterGroups |
|
| 110 | + * @param Collection $fighterGroups |
|
| 111 | 111 | * @param int $max |
| 112 | 112 | * |
| 113 | 113 | * @return Collection |
@@ -175,9 +175,9 @@ discard block |
||
| 175 | 175 | } |
| 176 | 176 | |
| 177 | 177 | /** |
| 178 | - * @param $area |
|
| 179 | - * @param $order |
|
| 180 | - * @param $round |
|
| 178 | + * @param integer $area |
|
| 179 | + * @param integer $order |
|
| 180 | + * @param integer $round |
|
| 181 | 181 | * @return FightersGroup |
| 182 | 182 | */ |
| 183 | 183 | protected function saveGroup($area, $order, $round): FightersGroup |
@@ -334,8 +334,8 @@ discard block |
||
| 334 | 334 | |
| 335 | 335 | /** |
| 336 | 336 | * @param Collection $fighters |
| 337 | - * @param $frequency |
|
| 338 | - * @param $sizeGroupBy |
|
| 337 | + * @param integer $frequency |
|
| 338 | + * @param integer $sizeGroupBy |
|
| 339 | 339 | * @param $bye |
| 340 | 340 | * @return Collection |
| 341 | 341 | */ |
@@ -358,8 +358,8 @@ discard block |
||
| 358 | 358 | /** |
| 359 | 359 | * @param $frequency |
| 360 | 360 | * @param $sizeGroupBy |
| 361 | - * @param $count |
|
| 362 | - * @param $byeCount |
|
| 361 | + * @param integer $count |
|
| 362 | + * @param integer $byeCount |
|
| 363 | 363 | * @return bool |
| 364 | 364 | */ |
| 365 | 365 | private function shouldInsertBye($frequency, $sizeGroupBy, $count, $byeCount): bool |
@@ -46,7 +46,9 @@ discard block |
||
| 46 | 46 | */ |
| 47 | 47 | protected static function getFightersWithNull(FightersGroup $group) |
| 48 | 48 | { |
| 49 | - if ($group == null) return null; |
|
| 49 | + if ($group == null) { |
|
| 50 | + return null; |
|
| 51 | + } |
|
| 50 | 52 | $fighters = $group->getFighters(); |
| 51 | 53 | $fighterType = $group->getFighterType(); |
| 52 | 54 | if (sizeof($fighters) == 0) { |
@@ -186,18 +188,26 @@ discard block |
||
| 186 | 188 | */ |
| 187 | 189 | public function hasDeterminedParent() |
| 188 | 190 | { |
| 189 | - if ($this->has2Fighters()) return true; |
|
| 191 | + if ($this->has2Fighters()) { |
|
| 192 | + return true; |
|
| 193 | + } |
|
| 190 | 194 | foreach ($this->group->children as $child) { |
| 191 | 195 | $fight = $child->fights->get(0); |
| 192 | - if ($fight->has2Fighters()) return false; |
|
| 196 | + if ($fight->has2Fighters()) { |
|
| 197 | + return false; |
|
| 198 | + } |
|
| 193 | 199 | } |
| 194 | 200 | return true; |
| 195 | 201 | } |
| 196 | 202 | |
| 197 | 203 | public function shouldBeInFightList() |
| 198 | 204 | { |
| 199 | - if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) return false; |
|
| 200 | - if ($this->has2Fighters()) return true; |
|
| 205 | + if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) { |
|
| 206 | + return false; |
|
| 207 | + } |
|
| 208 | + if ($this->has2Fighters()) { |
|
| 209 | + return true; |
|
| 210 | + } |
|
| 201 | 211 | // We aint in the first round, and there is 1 or 0 competitor |
| 202 | 212 | // We check children, and see : |
| 203 | 213 | // if there is 2 - 2 fighters -> undetermine, we cannot add it to fight list |
@@ -223,7 +233,9 @@ discard block |
||
| 223 | 233 | private function belongsToFirstRound() |
| 224 | 234 | { |
| 225 | 235 | $firstRoundFights = $this->group->championship->firstRoundFights->pluck('id')->toArray(); |
| 226 | - if (in_array($this->id, $firstRoundFights)) return true; |
|
| 236 | + if (in_array($this->id, $firstRoundFights)) { |
|
| 237 | + return true; |
|
| 238 | + } |
|
| 227 | 239 | return false; |
| 228 | 240 | } |
| 229 | 241 | |