xoco70 / kendozone

app/Notifications/InviteCompetitor.php

<?php

namespace App\Notifications;

use App\Tournament;
use App\User;
use Illuminate\Bus\Queueable;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;
use Illuminate\Support\Facades\URL;

class InviteCompetitor extends Notification
{
    use Queueable;

    protected $user, $tournament, $code, $category;

    /**
     * Create a new notification instance.
     *
     * @param User $user
     * @param Tournament $tournament
     * @param $code
     * @param null $category

Are you sure the doc-type for parameter $category is correct as it would always require null to be passed?

     */
    public function __construct(User $user, Tournament $tournament, $code, $category = null)
    {
        $this->user = $user;
        $this->tournament = $tournament;
        $this->code = $code;
        $this->category = $category;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed $notifiable
     * @return array
     */
    public function via($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

The parameter $notifiable is not used and could be removed.

    {

        $subject = trans('mail.invite_to_tournament') . ": " . $this->tournament->name;
        $message = (new MailMessage)
            ->subject($subject)
            ->greeting(trans('mail.dear_kenshi'))
            ->line(trans('mail.you_are_invited_to_tournament') . ":" . $this->tournament->name);

        if ($this->tournament->venue_id != null) {
            $message
                ->line("<strong>" . trans('core.venue') . ': </strong>' . $this->tournament->venue_name)

The property venue_name does not exist on App\Tournament. Did you mean venue?

                ->line("<strong>" . trans('core.address') . ': </strong>' . $this->tournament->venue->address);
        }
        $message
            ->line(trans("<strong>" . trans('core.eventDateIni') . ': </strong>' . $this->tournament->dateIni))
            ->line(trans("<strong>" . trans('core.eventDateFin') . ': </strong>' . $this->tournament->dateFin));

        if ($this->tournament->cost != null) {

The property cost does not seem to exist on App\Tournament. Are you sure there is no database migration missing?

            $message->line("<strong>" . trans('core.cost') . ': </strong>' . $this->tournament->cost);
        }

        if ($this->tournament->registerDateLimit != null && $this->tournament->registerDateLimit != '0000-00-00') {
            $message->line("<strong>" . trans('core.limitDateRegistration') . ': </strong>' . $this->tournament->registerDateLimit);
        }
        if (isset($this->category)) {
            $message->line("<strong>" . trans('mail.you_have_been_preregistered') . "</strong>")
                ->line('- ' . $this->category);
        } else {
            $message->action(trans('mail.confirm_registration'),
                URL::action('ChampionshipController@create', [
                    'tournamentSlug' => $this->tournament->slug,
                    'token' => $this->code
                ]));
        }
        if ($this->user->password != null) {
            $message->line(trans('mail.your_connection_data') . ":")
                ->line(trans('core.username') . ":" . $this->user->email)
                ->line(trans('core.password') . ":" . $this->user->clearPassword);
        }

        $message->line(trans('core.thanks'));

        return $message;
    }


    /**
     * Get the array representation of the notification.
     *
     * @param  mixed $notifiable
     * @return array
     */
    public function toArray($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return [
            //
        ];
    }
}