xoco70 / kendozone

app/Http/Controllers/UserController.php

<?php

namespace App\Http\Controllers;


use App\Association;
use App\Club;
use App\Country;
use App\Federation;
use App\Grade;
use App\Http\Requests\UserRequest;
use App\Notifications\AccountCreated;
use App\Role;
use App\User;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Database\QueryException;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Response;
use Illuminate\Support\Facades\View;
use Maatwebsite\Excel\Facades\Excel;
use URL;

class UserController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return View
     */
    public function index()
    {
        $users = User::with('country', 'role', 'association', 'federation')
            ->forUser(Auth::user())
            ->where('id', '>', 1)
            ->paginate(config('constants.PAGINATION'));

        return view('users.index', compact('users'));

The expression return view('users.index', compact('users')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Show the form for creating a new resource.
     * @return View
     * @throws AuthorizationException
     */
    public function create()
    {

        $user = new User();
        if (Auth::user()->cannot('create', $user)) {
            throw new AuthorizationException();
        }

        $roles = Role::grantedRoles(Auth::user()->role_id)->pluck('name', 'id');
        $grades = Grade::getAllPlucked();
        $countries = Country::getAllPlucked();
        $federations = Federation::fillSelect();
        $associations = Association::forUser(auth()->user());
        $clubs = Club::fillSelect(Auth::user()->federation_id, Auth::user()->association_id);
        return view('users.form', compact('user', 'grades', 'countries', 'roles', 'federations', 'associations', 'clubs')); //

The expression return view('users.form', compact('user', 'grades', 'countries', 'roles', 'federations', 'associations', 'clubs')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param UserRequest $userForm
     * @return \Illuminate\Http\RedirectResponse|Response
     */
    public function store(UserRequest $userForm)
    {
        try {
            $userForm->store();
            $user = User::where('email', $userForm->email)->first();
            $user->notify(new AccountCreated($user));
            flash()->success(trans('msg.user_create_successful'));

Are you sure the usage of flash() is correct as it seems to always return null.

        } catch (QueryException $e) {
            flash()->error(trans('msg.user_already_exists'));

Are you sure the usage of flash() is correct as it seems to always return null.

            return redirect()->back()->withInput();

The expression return redirect()->back()->withInput() also could return the type Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\RedirectResponse|Illuminate\Support\Facades\Response.

        }
        return redirect(route('users.index'));

The expression return redirect(route('users.index')) also could return the type Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\RedirectResponse|Illuminate\Support\Facades\Response.

    }

    /**
     * Display the specified resource.
     *
     * @param User $user
     * @return View
     */
    public function show(User $user)
    {


        return view('users.show', compact('user'));

The expression return view('users.show', compact('user')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param User $user
     * @return View
     * @throws AuthorizationException
     */
    public function edit(User $user)
    {
        if (Auth::user()->cannot('edit', $user)) {
            throw new AuthorizationException();
        }
        $roles = Role::grantedRoles(Auth::user()->role_id)->pluck('name', 'id');
        $grades = Grade::orderBy('order')->pluck('name', 'id');
        $countries = Country::pluck('name', 'id');
        $federations = Federation::fillSelect();
        $associations = Association::forUser(auth()->user());
        $clubs = Club::fillSelect(Auth::user()->federation_id, Auth::user()->association_id);

        return view('users.form', compact('user', 'grades', 'countries', 'roles', 'federations', 'associations', 'clubs')); //

The expression return view('users.form', compact('user', 'grades', 'countries', 'roles', 'federations', 'associations', 'clubs')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  UserRequest $userForm
     * @param User $user
     * @return Response
     */
    public function update(UserRequest $userForm, User $user)
    {
        if ($userForm->update($user)) {
            flash()->success(trans('msg.user_update_successful'));

Are you sure the usage of flash() is correct as it seems to always return null.

        } else
            flash()->error(Lang::get('msg.user_update_error'));

Are you sure the usage of flash() is correct as it seems to always return null.

        if ($user->id == Auth::user()->id) {
            return redirect(URL::action('UserController@edit', Auth::user()->slug));

The expression return redirect(URL::action('UserController@edit', Illuminate\Support\Facades\Auth::user()->slug)) returns the type Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Support\Facades\Response.

        }

        return redirect(route('users.index'));

The expression return redirect(route('users.index')) returns the type Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Support\Facades\Response.

    }


    public function export()
    {

        Excel::create(trans_choice('core.user', 2), function ($excel) {
            $appName = (app()->environment() == 'local' ? getenv('APP_NAME') : config('app.name'));

            // Set the title
            $excel->setTitle(trans_choice('core.user', 2));

            // Chain the setters
            $excel->setCreator($appName)
                ->setCompany($appName);

            // Call them separately
            $excel->setDescription('A list of users');
            $excel->sheet(trans_choice('core.user', 2), function ($sheet) {
                //TODO Here we should join grade, role, country to print name not FK
                $users = User::all();
//                $users = User::with(['grade', 'role'])->get();
                $sheet->fromArray($users);
            });


        })->export('xls');
    }

    public function getMyTournaments(Request $request)

The parameter $request is not used and could be removed.

    {
        $tournaments = Auth::user()->myTournaments()->with('owner')
            ->orderBy('created_at', 'desc')
            ->paginate(config('constants.PAGINATION'));;

        $title = trans('core.tournaments_registered');

        return view('users.tournaments', compact('tournaments', 'title'));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param User $user
     * @return \Illuminate\Http\JsonResponse
     * @throws \Exception
     */
    public function destroy(User $user)
    {

        if ($user->delete()) {
            return Response::json(['msg' => trans('msg.user_delete_successful'), 'status' => 'success']);
        }
        return Response::json(['msg' => trans('msg.user_delete_error'), 'status' => 'error']);

    }

    /**
     * @param $userSlug
     * @return \Illuminate\Http\JsonResponse
     */
    public function restore($userSlug)

    {
        $user = User::withTrashed()->whereSlug($userSlug)->first();
        if ($user->restore()) {
            return Response::json(['msg' => trans('msg.user_restore_successful'), 'status' => 'success']);
        }
        return Response::json(['msg' => trans('msg.user_restore_successful'), 'status' => 'error']);

    }

    public function myFederations(User $user)
    {
        return Federation::fillSelectForVueJs($user);
    }

    public function myAssociations(User $user, $federationId)
    {
        return Association::fillSelectForVuejs($user, $federationId);
    }

    public function myClubs(User $user, $federationId, $associationId)
    {
        return Club::fillSelectForVueJs($user, $federationId, $associationId);
    }

}