xoco70 / kendozone

app/Http/Controllers/TreeController.php

<?php

namespace App\Http\Controllers;

use App\Championship;
use App\FightersGroup;
use App\Grade;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Xoco70\LaravelTournaments\Exceptions\TreeGenerationException;

class TreeController extends Controller
{
    /**
     * Display a listing of trees.
     *
     * @param Request $request
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {

        $grades = Grade::getAllPlucked();
        $tournament = FightersGroup::getTournament($request);
        return view('trees.index', compact('tournament', 'grades'));

The expression return view('trees.index', compact('tournament', 'grades')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Build Tree
     *
     * @param Request $request
     * @return \Illuminate\Http\Response|string
     * @throws AuthorizationException
     */
    public function store(Request $request)
    {

        $tournament = FightersGroup::getTournament($request); // Builder

        if (Auth::user()->cannot('store', [FightersGroup::class, $tournament])) {
            throw new AuthorizationException();
        }
        foreach ($tournament->championships as $championship) {

The property championships does not seem to exist on Illuminate\Database\Eloquent\Builder.

            $generation = $championship->chooseGenerationStrategy();

            try {
                $generation->run();
                flash()->success(trans('msg.championships_tree_generation_success'));

Are you sure the usage of flash() is correct as it seems to always return null.

            } catch (TreeGenerationException $e) {
                flash()->error($e->message);

Are you sure the usage of flash() is correct as it seems to always return null.

            }
        }

        return redirect(route('tree.index', $tournament->slug))->with('activeTreeTab', $request->activeTreeTab);

The expression return redirect(route('tree.index', $tournament->slug))->with('activeTreeTab', $request->activeTreeTab) also could return the type Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\Response|string.

The property slug does not seem to exist on Illuminate\Database\Eloquent\Builder.

    }

    public function single(Request $request)
    {
        $championship = Championship::find($request->championship);
        $grades = Grade::getAllPlucked();
        return view('pdf.tree', compact('championship', 'grades'));
    }

    /**
     * @param Request $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, $championshipId)
    {
        $championship = Championship::find($championshipId);
        $numFighter = 0;
        $query = FightersGroup::with('fights')
            ->where('championship_id', $championship->id);

        $fighters = $request->singleElimination_fighters;
        $scores = $request->score;
        if ($championship->hasPreliminary()) {
            $query = $query->where('round', '>', 1);
            $fighters = $request->preliminary_fighters;
        }
        $groups = $query->get();

        foreach ($groups as $group) {
            foreach ($group->fights as $fight) {

The property fights does not exist on App\FightersGroup. Since you implemented __get, consider adding a @property annotation.

                // Find the fight in array, and update order
                $fight->c1 = $fighters[$numFighter];
                $scores[$numFighter] != null
                    ? $fight->winner_id = $fighters[$numFighter]
                    : $fight->winner_id = null;
                $numFighter++;

                $fight->c2 = $fighters[$numFighter];
                if ($fight->winner_id == null) {
                    $scores[$numFighter] != null
                        ? $fight->winner_id = $fighters[$numFighter]
                        : $fight->winner_id = null;
                }

                $numFighter++;
                $fight->save();
            }
        }
        return back();
    }

}