xoco70 / kendozone

app/Http/Controllers/FederationController.php

<?php

namespace App\Http\Controllers;


use App\Exceptions\NotOwningFederationException;
use App\Federation;
use App\Http\Requests\FederationRequest;
use App\User;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Database\QueryException;
use Illuminate\Support\Facades\Auth;

class FederationController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return Federation
     */
    public function index()
    {
        $federations = Federation::with('president', 'country'); // ,'vicepresident','secretary','treasurer','admin'

        $federations = $federations->where('id', '>', 1)->get();
        return view('federations.index', compact('federations'));

The expression return view('federations.index', compact('federations')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type App\Federation.

    }


    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $federation = Federation::findOrFail($id);
        return view('federations.show', compact('federation'));

The expression return view('federations.show', compact('federation')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param $id
     * @return \Illuminate\Http\Response
     * @throws AuthorizationException
     */
    public function edit($id)
    {
        $federation = Federation::findOrFail($id);
        if (Auth::user()->cannot('edit', $federation)) {
            throw new AuthorizationException();
        }

        $users = User::where('country_id', '=', $federation->country_id)->pluck('name', 'id');
        return view('federations.edit', compact('federation', 'users'));

The expression return view('federations.edit', compact('federation', 'users')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param FederationRequest|\Illuminate\Http\Request $request
     * @param  int $id
     * @return \Illuminate\Http\Response
     * @throws NotOwningFederationException
     */
    public function update(FederationRequest $request, $id)
    {
        $federation = Federation::findOrFail($id);
        if (Auth::user()->cannot('update', $federation)) {
            throw new NotOwningFederationException();
        }
        try {
            $federation->update($request->all());
            $users = User::where('country_id', '=', $federation->country_id)->pluck('name', 'id');

The assignment to $users is dead and can be removed.

            $msg = trans('msg.federation_edit_successful', ['name' => $federation->name]);
            flash()->success($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

            return redirect(route('federations.index'));

The expression return redirect(route('federations.index')) returns the type Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\Response.

        } catch (QueryException $e) {

            $msg = trans('msg.federation_president_already_exists');
            flash()->error($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

            return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\Response.

        }
    }
}