xoco70 / kendozone

app/Http/Controllers/ClubController.php

<?php

namespace App\Http\Controllers;

use App\Association;
use App\Club;
use App\Federation;
use App\Http\Requests\ClubRequest;
use App\User;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Database\QueryException;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\RedirectResponse;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Request;
use Illuminate\Support\Facades\View;
use Response;

class ClubController extends Controller
{
    // Only Super Admin and Club President can manage Clubs

    /**
     * Display a listing of the resource.
     *
     * @return Collection|View
     */
    public function index()
    {

        if (Request::ajax()) {
            return Club::fillSelect(Auth::user()->federation_id, Auth::user()->association_id);
        } else {
            $clubs = Club::with('president', 'association.federation')
                ->forUser(Auth::user())
                ->where('id', '>', 1)
                ->get();

            return view('clubs.index', compact('clubs'));

The expression return view('clubs.index', compact('clubs')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Collection|Illuminate\Support\Facades\View.

        }

    }


    /**
     * Show the form for creating a new resource.
     * @return View
     * @throws AuthorizationException
     */
    public function create()
    {


        $club = new Club;
        // Authorization

        $federations = Federation::fillSelect();
        $associations = Association::forUser(auth()->user())->pluck('name', 'id')->prepend('-', 0);
        $users = Auth::user()->fillSelect();


        $defaultLng = Auth::user()->latitude ?? geoip()->lat;

The property lat does not seem to exist on Torann\GeoIP\GeoIP.

        $defaultLat = Auth::user()->longitude ?? geoip()->lon;

The property lon does not seem to exist on Torann\GeoIP\GeoIP.

        return view('clubs.form', compact('club', 'users', 'federations', 'associations', 'defaultLng', 'defaultLat')); //

The expression return view('clubs.form', compact('club', 'users', 'federations', 'associations', 'defaultLng', 'defaultLat')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param ClubRequest $request
     * @return JsonResponse|RedirectResponse
     */
    public function store(ClubRequest $request)
    {

        try {
            if ($request->president_id == 0) $request->merge(['president_id' => null]);
            if ($request->federation_id == 0) $request->merge(['federation_id' => null]);
            if ($request->association_id == 0) $request->merge(['association_id' => null]);
            $club = Club::create($request->all());

            if (Request::ajax()) {
                return Response::json(['msg' => trans('msg.club_create_successful', ['name' => $club->name]), 'status' => 'success', 'data' => $club], 200);
            } else {
                $msg = trans('msg.club_edit_successful', ['name' => $club->name]);
                flash()->success($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

                return redirect("clubs");

The expression return redirect('clubs') also could return the type Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\JsonResponse|Illuminate\Http\RedirectResponse.

            }
        } catch (QueryException $e) {
            $user = User::find($request->president_id);
            $msg = trans('msg.club_president_already_exists', ['user' => $user->name]);
            flash()->error($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

            return redirect()->back();

The expression return redirect()->back() also could return the type Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\JsonResponse|Illuminate\Http\RedirectResponse.

        }

    }


    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return View
     */
    public function show($id)
    {
        $club = Club::findOrFail($id);
        return view('clubs.show', compact('club'));

The expression return view('clubs.show', compact('club')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     * @return View
     * @throws AuthorizationException
     */
    public function edit($id)
    {

        $defaultLng = Auth::user()->latitude ?? geoip()->lat;

The property lat does not seem to exist on Torann\GeoIP\GeoIP.

        $defaultLat = Auth::user()->longitude ?? geoip()->lon;

The property lon does not seem to exist on Torann\GeoIP\GeoIP.

        $club = Club::findOrFail($id);
        $this->authorize('edit', [$club, Auth::user()]);

        $federations = Federation::fillSelect();
        $associations = Association::forUser(auth()->user())->pluck('name', 'id')->prepend('-', 0);
        $users = Auth::user()->fillSelect();

        return view('clubs.form', compact('club', 'users', 'associations', 'federations', 'defaultLng', 'defaultLat')); //

The expression return view('clubs.form', compact('club', 'users', 'associations', 'federations', 'defaultLng', 'defaultLat')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param ClubRequest|Request $request
     * @param  int $id
     * @return \Illuminate\Http\Response
     * @throws AuthorizationException
     */
    public function update(ClubRequest $request, $id)
    {
        $club = Club::findOrFail($id);

        $this->authorize('update', [$club, Auth::user()]);

        try {
            if ($request->president_id == 0) $request->merge(['president_id' => null]);
            if ($request->association_id == 0) $request->merge(['association_id' => null]);

            $club->update($request->all());
            $msg = trans('msg.club_edit_successful', ['name' => $club->name]);
            flash()->success($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

            return redirect("clubs");

The expression return redirect('clubs') returns the type Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\Response.

        } catch (QueryException $e) {
            // Already
            $msg = "User" . $request->id . "is already president of another club";
            flash()->error($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

            return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\Response.

        }
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param $clubId
     * @return JsonResponse
     * @internal param Club $club
     */
    public function destroy($clubId)
    {
        $club = Club::find($clubId);
        if ($club->delete()) {
            return Response::json(['msg' => trans('msg.club_delete_successful', ['name' => $club->name]), 'status' => 'success']);
        } else {
            return Response::json(['msg' => trans('msg.club_delete_error', ['name' => $club->name]), 'status' => 'error']);
        }
    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function restore($id)

    {
        $club = Club::withTrashed()->find($id);
        if ($club->restore()) {
            return Response::json(['msg' => trans('msg.club_restored_successful', ['name' => $club->name]), 'status' => 'success']);
        } else {
            return Response::json(['msg' => trans('msg.club_restored_error', ['name' => $club->name]), 'status' => 'error']);
        }
    }
}