xoco70 / kendozone

app/Http/Controllers/AssociationController.php

<?php

namespace App\Http\Controllers;

use App\Association;
use App\Federation;
use App\Http\Requests\AssociationRequest;
use App\User;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Database\QueryException;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\RedirectResponse;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Request;
use Illuminate\Support\Facades\Response;
use Illuminate\Support\Facades\View;

class AssociationController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return Collection|View
     */
    public function index()
    {
        $associations = Association::forUser(auth()->user());
        if (Request::ajax()) {
            return $associations->pluck('name', 'id')->prepend('-', 0);
        }
        $associations = $associations->where('id', '>', 1)->get();
        return view('associations.index', compact('associations'));

The expression return view('associations.index', compact('associations')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Collection|Illuminate\Support\Facades\View.

    }


    /**
     * Show the form for creating a new resource.
     * @return View
     * @throws AuthorizationException
     */
    public function create()
    {
        $association = new Association;
        $federation = new Collection;

        $users = User::forUser(Auth::user())->pluck('name', 'id')->prepend('-', 0);
        $federations = Federation::forUser(Auth::user())->pluck('name', 'id');
        $submitButton = trans('core.addModel', ['currentModelName' => trans_choice('structures.association', 1)]);
        return view('associations.form', compact('association', 'users', 'federation', 'federations', 'submitButton')); //

The expression return view('associations.form', compact('association', 'users', 'federation', 'federations', 'submitButton')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param AssociationRequest $request
     * @return Response|RedirectResponse
     * @throws AuthorizationException
     */
    public function store(AssociationRequest $request)
    {
        try {
            if ($request->president_id == 0)
                $request->merge(['president_id' => null]);

            $association = Association::create($request->all());
            if (Request::ajax()) {
                return Response::json(['msg' => trans('msg.association_create_successful', ['name' => $association->name]), 'status' => 'success', 'data' => $association], 200);

The expression return Illuminate\Support\Facades\Response::json(array('msg' => trans('msg.association_create_successful', array('name' => $association->name)), 'status' => 'success', 'data' => $association), 200) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\RedirectResponse|Illuminate\Support\Facades\Response.

            } else {
                $msg = trans('msg.association_create_successful', ['name' => $association->name]);
                flash()->success($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

                return redirect(route("associations.index"));

The expression return redirect(route('associations.index')) also could return the type Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\RedirectResponse|Illuminate\Support\Facades\Response.

            }
        } catch (QueryException $e) {
            if (Request::ajax()) {
                return Response::json(['msg' => $e], 500);

The expression return Illuminate\Support\Facades\Response::json(array('msg' => $e), 500) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\RedirectResponse|Illuminate\Support\Facades\Response.

            } else {
                $user = User::find($request->president_id);
                $msg = trans('msg.association_president_already_exists', ['user' => $user->name]);
                flash()->error($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

                return redirect()->back();

The expression return redirect()->back() also could return the type Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\RedirectResponse|Illuminate\Support\Facades\Response.

            }
        }
    }


    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return View
     */
    public function show($id)
    {
        $association = Association::findOrFail($id);
        return view('associations.show', compact('association'));

The expression return view('associations.show', compact('association')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     * @return View
     * @throws AuthorizationException
     */
    public function edit($id)
    {
        $association = Association::findOrFail($id);
        $federation = $association->federation;

        if (Auth::user()->cannot('edit', $association)) {
            throw new AuthorizationException();
        }

        $users = User::forUser(Auth::user())->pluck('name', 'id')->prepend('-', 0);
        $federations = Federation::forUser(Auth::user())->pluck('name', 'id');

        return view('associations.form', compact('association', 'users', 'federations', 'federation'));

The expression return view('associations.form', compact('association', 'users', 'federations', 'federation')) returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Facades\View.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param AssociationRequest|Request $request
     * @param  int $id
     * @return Response|RedirectResponse
     * @throws AuthorizationException
     */
    public function update(AssociationRequest $request, $id)
    {
        $association = Association::findOrFail($id);

        if (Auth::user()->cannot('update', $association)) {
            throw new AuthorizationException();
        }
        try {
            if ($request->president_id == 0)
                $request->merge(['president_id' => null]);

            $association->update($request->all());
            $msg = trans('msg.association_edit_successful', ['name' => $association->name]);
            flash()->success($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

            return redirect(route('associations.index'));

The expression return redirect(route('associations.index')) also could return the type Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\RedirectResponse|Illuminate\Support\Facades\Response.

        } catch (QueryException $e) {
            $user = User::find($request->president_id);
            $msg = trans('msg.association_president_already_exists', ['user' => $user->name]);
            flash()->error($msg);

Are you sure the usage of flash() is correct as it seems to always return null.

            return redirect()->back();

The expression return redirect()->back() also could return the type Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\RedirectResponse|Illuminate\Support\Facades\Response.

        }

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param $associationId
     * @return JsonResponse
     */
    public function destroy($associationId)
    {
        $association = Association::find($associationId);

        if ($association->delete()) {
            return Response::json(['msg' => trans('msg.association_delete_successful', ['name' => $association->name]), 'status' => 'success']);
        } else {
            return Response::json(['msg' => trans('msg.association_delete_error', ['name' => $association->name]), 'status' => 'error']);
        }
    }

    /**
     * @param $id
     * @return JsonResponse
     */
    public function restore($id)
    {
        $association = Association::withTrashed()->find($id);
        if ($association->restore()) {
            return Response::json(['msg' => trans('msg.association_restored_successful', ['name' => $association->name]), 'status' => 'success']);
        } else {
            return Response::json(['msg' => trans('msg.association_restored_error', ['name' => $association->name]), 'status' => 'error']);
        }
    }


    public function changePresident()
    {
        // Open Transaction
        // Get the current president
        // Set the new president
        // Save
        // Close transaction
    }
}