xoco70 / kendozone

app/Http/Controllers/FederationController.php

Doc Comments +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
      *
      * @param FederationRequest|\Illuminate\Http\Request $request
      * @param  int $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      * @throws NotOwningFederationException
      */
     public function update(FederationRequest $request, $id)

app/Http/Controllers/InviteController.php

Doc Comments +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
      * Send an email to competitor and store invitation.
      *
      * @param InviteRequest|Request $request
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function store(Request $request)
     {
@@ -89,7 +89,7 @@ 
      * Send an email to competitor and store invitation.
      *
      * @param InviteRequest|Request $request
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function upload(Request $request)
     {

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
         $tournament = Tournament::where('slug', $request->tournamentSlug)->first();
         // Parse Csv File
 
-        $reader = Excel::load("storage/app/" . $file, function ($reader) {
+        $reader = Excel::load("storage/app/" . $file, function($reader) {
         })->get();
 
         // Checking if malformed email

app/Http/Controllers/TeamController.php

Doc Comments +3 added lines, -3 removed lines

@@ -69,7 +69,7 @@ 
 
     /**
      * @param $championship
-     * @param $tempAssignCompatitors
+     * @param Collection $tempAssignCompatitors
      * @return mixed
      */
     private function getAssignedCompetitors($championship, $tempAssignCompatitors)
@@ -98,7 +98,7 @@ 
      *
      * @param Request $request
      * @param Championship $championship
-     * @return View
+     * @return \Illuminate\Http\RedirectResponse
      * @throws AuthorizationException
      */
     public function store(Request $request, Championship $championship)
@@ -143,7 +143,7 @@ 
      * @param TeamRequest $request
      * @param Tournament $tournament
      * @param $teamId
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      * @throws AuthorizationException
      */
     public function update(TeamRequest $request, Tournament $tournament, $teamId)

Spacing +6 added lines, -6 removed lines

@@ -26,20 +26,20 @@ 
      */
     public function index(Tournament $tournament)
     {
-        $tournament = Tournament::with(['championships' => function ($query) {
+        $tournament = Tournament::with(['championships' => function($query) {
             $query->with('teams')
-                ->whereHas('category', function ($subquery) {
+                ->whereHas('category', function($subquery) {
                     $subquery->where('isTeam', '=', 1);
                 });
         }])->withCount('competitors', 'teams')
             ->find($tournament->id);
 
 
-        $arrChampionshipsWithTeamsAndCompetitors = $tournament->championships->map(function ($championship) {
-            $competitors = $championship->competitors->load('user')->map(function ($competitor) {
+        $arrChampionshipsWithTeamsAndCompetitors = $tournament->championships->map(function($championship) {
+            $competitors = $championship->competitors->load('user')->map(function($competitor) {
                 return ["id" => $competitor->id, "name" => $competitor->user->name];
             })->toArray();
-            $teams = $championship->teams()->with('competitors.user')->select('id','name')->get()->toArray();
+            $teams = $championship->teams()->with('competitors.user')->select('id', 'name')->get()->toArray();
             $tempAssignCompatitors = new Collection();
             $assignedCompetitors = $this->getAssignedCompetitors($championship, $tempAssignCompatitors);
             $freeCompetitors = $championship->competitors;
@@ -66,7 +66,7 @@ 
      */
     private function getAssignedCompetitors($championship, $tempAssignCompatitors)
     {
-        return $championship->teams->reduce(function ($acc, $team) use ($tempAssignCompatitors) {
+        return $championship->teams->reduce(function($acc, $team) use ($tempAssignCompatitors) {
             return $tempAssignCompatitors->push($team->competitors()->with('user')->get())->collapse();
         });
     }

app/Http/Controllers/TournamentController.php

Doc Comments +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
      * Store a new Tournament
      *
      * @param TournamentRequest $form
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function store(TournamentRequest $form)
     {

Braces +3 added lines, -2 removed lines

@@ -144,8 +144,9 @@
     {
         //TODO Shouldn't I have a Policy???
         $venue = $tournament->venue;
-        if ($venue == null)
-            $venue = new Venue;
+        if ($venue == null) {
+                    $venue = new Venue;
+        }
 
         if ($venueRequest->has('venue_name')) {
             $venue->fill($venueRequest->all());

Spacing +2 added lines, -2 removed lines

@@ -110,8 +110,8 @@
         $tournament = Tournament::with('competitors', 'championshipSettings', 'championships.settings', 'championships.category')
             ->withCount('competitors', 'teams')
             ->find($tournament->id);
-        $selectedCategories = $tournament->categories->pluck('name','id'); // 3,4 ,240
-        $defaultCategories = Category::take(7)->get()->sortBy('id')->pluck('name','id'); // 1 2 3 4 5 6 7
+        $selectedCategories = $tournament->categories->pluck('name', 'id'); // 3,4 ,240
+        $defaultCategories = Category::take(7)->get()->sortBy('id')->pluck('name', 'id'); // 1 2 3 4 5 6 7
 
         $categories = $selectedCategories->union($defaultCategories)->toArray();
 

app/Http/Controllers/TreeController.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
      * Build Tree
      *
      * @param Request $request
-     * @return \Illuminate\Http\Response|string
+     * @return \Illuminate\Http\RedirectResponse
      * @throws AuthorizationException
      */
     public function store(Request $request)

app/Http/Controllers/UserController.php

Doc Comments +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
      *
      * @param  UserRequest $userForm
      * @param User $user
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function update(UserRequest $userForm, User $user)
     {

Spacing +3 added lines, -3 removed lines

@@ -151,7 +151,7 @@ 
     public function export()
     {
 
-        Excel::create(trans_choice('core.user', 2), function ($excel) {
+        Excel::create(trans_choice('core.user', 2), function($excel) {
             $appName = (app()->environment() == 'local' ? getenv('APP_NAME') : config('app.name'));
 
             // Set the title
@@ -163,7 +163,7 @@ 
 
             // Call them separately
             $excel->setDescription('A list of users');
-            $excel->sheet(trans_choice('core.user', 2), function ($sheet) {
+            $excel->sheet(trans_choice('core.user', 2), function($sheet) {
                 //TODO Here we should join grade, role, country to print name not FK
                 $users = User::all();
 //                $users = User::with(['grade', 'role'])->get();
@@ -178,7 +178,7 @@ 
     {
         $tournaments = Auth::user()->myTournaments()->with('owner')
             ->orderBy('created_at', 'desc')
-            ->paginate(config('constants.PAGINATION'));;
+            ->paginate(config('constants.PAGINATION')); ;
 
         $title = trans('core.tournaments_registered');
 

Braces +3 added lines, -2 removed lines

@@ -136,8 +136,9 @@
     {
         if ($userForm->update($user)) {
             flash()->success(trans('msg.user_update_successful'));
-        } else
-            flash()->error(Lang::get('msg.user_update_error'));
+        } else {
+                    flash()->error(Lang::get('msg.user_update_error'));
+        }
 
         if ($user->id == Auth::user()->id) {
             return redirect(URL::action('UserController@edit', Auth::user()->slug));

app/Notifications/AccountCreated.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      * Get the notification's delivery channels.
      *
      * @param  mixed $notifiable
-     * @return array
+     * @return string[]
      */
     public function via($notifiable)
     {

app/Policies/FederationPolicy.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
      * Create a new policy instance.
      * @param User $user
      * @param $ability
-     * @return bool
+     * @return boolean|null
      */
     public function before(User $user, $ability)
     {

Braces +6 added lines, -4 removed lines

@@ -46,16 +46,18 @@
 
     public function edit(User $user, Federation $federation)
     {
-        if ($user->federationOwned == null)
-            return false;
+        if ($user->federationOwned == null) {
+                    return false;
+        }
 
         return $user->federationOwned->id == $federation->id;
     }
 
     public function update(User $user, Federation $federation)
     {
-        if ($user->federationOwned == null)
-            return false;
+        if ($user->federationOwned == null) {
+                    return false;
+        }
 
         return $user->federationOwned->id == $federation->id;
     }

app/Repositories/Eloquent/UserRepository.php

Doc Comments +3 added lines

@@ -8,6 +8,9 @@
 class UserRepository extends BaseRepository
 {
 
+    /**
+     * @param \Laravel\Socialite\Contracts\User $userData
+     */
     public function findByUserNameOrCreate($userData, $provider)
     {
 

Braces +5 added lines, -4 removed lines

@@ -65,10 +65,11 @@
             $user->slug = str_slug($userData->name);
             $user->email = $userData->email;
             $user->firstname = $userData->name;
-            if (strlen($userData->nickname) != 0)
-                $user->name = $userData->nickname;
-            else
-                $user->name = $userData->email;
+            if (strlen($userData->nickname) != 0) {
+                            $user->name = $userData->nickname;
+            } else {
+                            $user->name = $userData->email;
+            }
             $user->save();
         }
     }