App\Http\Controllers\CompetitorController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	132
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Test Coverage

Coverage

83.33%

Importance

Changes

0

<?php
class CompetitorController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @param Tournament $tournament
     * @return View
     */
    public function index(Tournament $tournament)
    {
        $tournament = Tournament::with('championships.users', 'championships.teams', 'championships.category')->find($tournament->id);

The method find does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

        $settingSize = $tournament->championshipSettings()->count();
        $categorySize = $tournament->categories->count();
        $grades = Grade::getAllPlucked();
        $countries = Country::getAll();
        return view("tournaments.users", compact('tournament', 'settingSize', 'categorySize', 'grades', 'countries'));

    }

    /**
     * Show the form for creating a new competitor.
     *
     * @param Request $request
     * @param Tournament $tournament
     * @return View
     */
    public function create(Request $request, Tournament $tournament)
    {
        $championshipId = $request->get('categoryId');

        return view("tournaments/users/create", compact('tournament', 'championshipId')); //, compact()
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param CompetitorRequest $request
     * @param Tournament $tournament
     * @return \Illuminate\Http\Response
     */
    public function store(CompetitorRequest $request, Tournament $tournament)
    {

        $championshipId = $request->championshipId;

The property championshipId does not seem to exist in App\Http\Requests\CompetitorRequest.

        $championship = Championship::findOrFail($championshipId);

        foreach ($request->firstnames as $id => $firstname) {

The property firstnames does not exist on object<App\Http\Requests\CompetitorRequest>. Since you implemented __get, maybe consider adding a @property annotation.

            $email = $request->emails[$id] ?? Auth::user()->id . sha1(rand(1, 999999999999)) . (User::count() + 1) . "@kendozone.com";

The property emails does not exist on object<App\Http\Requests\CompetitorRequest>. Since you implemented __get, maybe consider adding a @property annotation.

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $lastname = $request->lastnames[$id] ?? '';

The property lastnames does not exist on object<App\Http\Requests\CompetitorRequest>. Since you implemented __get, maybe consider adding a @property annotation.

            $user = Competitor::createUser([
                'firstname' => $firstname,
                'lastname' => $lastname,
                'name' => $firstname . " " . $lastname,
                'email' => $email
            ]);

            $championships = $user->championships();
            // If user has not registered yet this championship
            if (!$championships->get()->contains($championship)) {
                // Get Competitor Short ID
                $categories = $tournament->championships->pluck('id');
                $shortId = Competitor::getShortId($categories, $tournament);
                $championships->attach($championshipId, ['confirmed' => 0, 'short_id' => $shortId]);
            }
            //TODO Should add a test for this
            // We send him an email with detail (and user /password if new)
            if (strpos($email, '@kendozone.com') === -1) { // Substring is not present
                $code = resolve(Invite::class)->generateTournamentInvite($user->email, $tournament);
                $user->notify(new InviteCompetitor($user, $tournament, $code, $championship->category->name));
            }
        }
        flash()->success(trans('msg.user_registered_successful', ['tournament' => $tournament->name]));

The method success cannot be called on flash() (of type null).

        return redirect(URL::action('CompetitorController@index', $tournament->slug));


    }

    /**
     * @param $tournamentSlug
     * @param $tcId
     * @param $userSlug
     * @return \Illuminate\Http\JsonResponse
     */
    public function confirmUser($tournamentSlug, $tcId, $userSlug)

The parameter $tournamentSlug is not used and could be removed.

    {
        $user = User::where('slug', $userSlug)->first();
        $ctu = Competitor::where('championship_id', $tcId)
            ->where('user_id', $user->id)->first();

        $ctu->confirmed ? $ctu->confirmed = 0 : $ctu->confirmed = 1;
        if ($ctu->save()) {
            return Response::json(['msg' => trans('msg.user_status_successful'), 'status' => 'success']);
        } else {
            return Response::json(['msg' => trans('msg.user_status_error'), 'status' => 'error']);
        }

    }

    /**
     * @param $tournamentSlug
     * @param $tcId
     * @param $userSlug
     * @return \Illuminate\Http\JsonResponse
     */
    public function deleteUser($tournamentSlug, $tcId, $userSlug)

The parameter $tournamentSlug is not used and could be removed.

    {

        $user = User::where('slug', $userSlug)->first();
        $ctu = Competitor::where('championship_id', $tcId)
            ->where('user_id', $user->id);

        if ($ctu->forceDelete()) {
            return Response::json(['msg' => trans('msg.user_delete_successful'), 'status' => 'success']);
        } else {
            return Response::json(['msg' => trans('msg.user_delete_error'), 'status' => 'error']);
        }
    }


    /**
     * Display the specified resource.
     *
     * @param Tournament $tournament
     * @param User $user
     * @return View
     */
    public function show(Tournament $tournament, User $user)
    {
        return view('users.show', compact('tournament', 'user'));
    }
}