AssociationPolicy::update() - Code Metrics - Inspection of "Bump http-proxy from 1.16.2 to 1.18.1" - xoco70/kendozone - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#46)

unknown

created 2020-09-04 23:04 UTC

AssociationPolicy::update() A

↳ Parent: AssociationPolicy

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.3332

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	2
dl	0
loc	11
ccs	4
cts	6
cp	0.6667
crap	3.3332
rs	10
c	0
b	0
f	0

<?php

namespace App\Policies;

use App\Association;
use App\User;

class AssociationPolicy
{
    /**
     * @param User $user
     * @param $ability
     * @return bool|null
     */
    public function before(User $user, $ability)
    public function before(User $user, /** @scrutinizer ignore-unused */ $ability)
    {
        if ($user->isSuperAdmin()) {
            return true;
        }
        return null;
    }

    // Only SuperAdmin And FederationPresident should be able to create Associations

    /**
     * @param User $user
     * @return bool
     */
    public function create(User $user)
    {
        if ($user->isFederationPresident()) {
            return true;
        }
        return false;
    }

    // Only SuperAdmin And FederationPresident should be able to create Associations

    /**
     * @param User $user
     * @param Association $association
     * @return bool
     */
    public function store(User $user, Association $association)
    public function store(/** @scrutinizer ignore-unused */ User $user, Association $association)
    {
//        if ($user->isFederationPresident()) {
        return true;
//        }
//        return false;
    }

    // Only SuperAdmin And FederationPresident should be able to delete Associations

    /**
     * @param User $user
     * @param Association $association
     * @return bool
     */
    public function delete(User $user, Association $association)
    {
        return $association->belongsToFederationPresident($user);
    }

    /**
     *
     * @param User $user
     * @param Association $association
     * @return bool
     */
    public function edit(User $user, Association $association)
    {

        if ($user->isFederationPresident()) {
            return $association->belongsToFederationPresident($user);
        }

        if ($user->isAssociationPresident()) {
            return $association->belongsToAssociationPresident($user);

        }
        return false;
    }

    public function update(User $user, Association $association)
    {
        if ($user->isFederationPresident()) {
            return $association->belongsToFederationPresident($user);
        }

        if ($user->isAssociationPresident()) {
            return $association->belongsToAssociationPresident($user);

        }
        return false;
    }


}


xoco70 / kendozone

Pull Request — master (#46)

AssociationPolicy::update() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like