App\Http\Controllers\CategoryController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Test Coverage

Coverage

86.67%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	17	1
A	create()	0	3	1

<?php

namespace App\Http\Controllers;

use App\Category;
use App\Http\Requests\CategoryRequest;
use Illuminate\Http\Request;


class CategoryController extends Controller
{

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('categories.create');

The expression return view('categories.create') returns the type Illuminate\Contracts\View\Factory|Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @param Request|CategoryRequest $request
     * @return \Illuminate\Database\Eloquent\Model
     */

    public function store(CategoryRequest $request)
    {
        $category = $request->getCategoryByFilters();

        $category->isTeam = $request->isTeam;
        $category->gender = $request->gender;
        $category->ageCategory = $request->ageCategory;
        $category->ageMin = $request->ageMin;
        $category->ageMax = $request->ageMax;
        $category->gradeCategory = $request->gradeCategory;

The property gradeCategory does not exist on App\Category. Since you implemented __set, consider adding a @property annotation.

        $category->gradeMin = $request->gradeMin;
        $category->gradeMax = $request->gradeMax;
        $category->name = $category->buildName();

The property name does not exist on App\Category. Since you implemented __set, consider adding a @property annotation.

        $newCategoryName = Category::firstOrCreate($category->toArray());

        return $newCategoryName;
    }
}